KDE CI: Frameworks kservice kf5-qt5 XenialQt5.7 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20XenialQt5.7/28/ Project: Frameworks kservice kf5-qt5 XenialQt5.7 Date of build: Thu, 26 Oct 2017 05:10:27 + Build duration: 7 min 8 sec and counting JUnit Tests

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij added a comment. In https://phabricator.kde.org/D7660#158479, @ngraham wrote: > @safaalfulaij, any progress on the latest comments? Not really. I was busy with college. I'll try finishing it in the coming week. REPOSITORY R39 KTextEditor REVISION DETAIL

Re: No good way to play video files located on password-protected Samba shares in KDE Plasma

Theoretically another option is to remove "smb" from the list of protocols listed in X-KDE-Protocols in the desktop files for these programs, which will force KIO to do the local download routine. This effectively implements #6 without needing to involve the distros, but still suffers from the

D5209: Load translations from KPackage files if bundled

Zren added a comment. Another note: `plasmoidviewer` is unaffected by this patch. Meaning - `devpath/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` will not show translations in plasmoidviewer, but if you install to -

D5209: Load translations from KPackage files if bundled

Zren added a comment. This worked - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` These didn't work -

Re: No good way to play video files located on password-protected Samba shares in KDE Plasma

Looks like the MPV folks have already rejected that approach: https://github.com/mpv-player/mpv/issues/1512#issuecomment-77504217 They say it should be up to the system to provide them with an accessible path. So if the VLC folks say something similar (which I suspect is going to happen),

KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.9 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.9/4/ Project: Frameworks kunitconversion kf5-qt5 AndroidQt5.9 Date of build: Thu, 26 Oct 2017 00:31:45 + Build duration: 1 min 27 sec and counting

D8296: Use Alt+, as the standard shortcut for "Configure "

ngraham planned changes to this revision. ngraham added a comment. Oh, great idea. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik,

D8296: Use Alt+, as the standard shortcut for "Configure "

abetts added a comment. Could this also be added to global shortcuts if it is not there already? That the user can define the keys to use for Preferences? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc:

Re: No good way to play video files located on password-protected Samba shares in KDE Plasma

That's certainly another option, though I suspect they might say that it's the system's responsibility to pass them an accessible path. For VLC, I've filed https://trac.videolan.org/vlc/ticket/18982 I will do the same for MPV and MPlayer. Nate Graham On 10/25/2017 05:12 PM, Christoph Feck

Re: Frameworks release schedule?

On Wed, Oct 25, 2017 at 1:44 AM, Harald Sitter wrote: > On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote: >> Hi, >> I send this email to kde-frameworks-devel >> >> It's the correct ML for having an answer about it >> >> Regards. Hi Laurent, I thought that

Re: Frameworks release schedule?

On Wed, Oct 25, 2017 at 1:44 AM, Harald Sitter wrote: > On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote: >> Hi, >> I send this email to kde-frameworks-devel >> >> It's the correct ML for having an answer about it >> >> Regards. Hi Laurent, I thought that

KDE CI: Frameworks kconfig kf5-qt5 AndroidQt5.9 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20AndroidQt5.9/2/ Project: Frameworks kconfig kf5-qt5 AndroidQt5.9 Date of build: Wed, 25 Oct 2017 23:09:37 + Build duration: 3 min 57 sec and counting

Re: No good way to play video files located on password-protected Samba shares in KDE Plasma

On 26.10.2017 00:47, Nate Graham wrote: It seems that our users don't have a good way to play videos on password-protected Samba shares: https://bugs.kde.org/show_bug.cgi?id=355328 Why aren't VLC etc. ask for passwords on protected links? They could/should use KWallet indirectly via the dozen

D8457: Don't build the kconfig_compiler tests when crosscompiling

This revision was automatically updated to reflect the committed changes. Closed by commit R237:a07822207374: Dont build the kconfig_compiler tests when crosscompiling (authored by apol). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8457?vs=21267=21342

D8457: Don't build the kconfig_compiler tests when crosscompiling

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D8457 To: apol, #frameworks, davidedmundson

No good way to play video files located on password-protected Samba shares in KDE Plasma

It seems that our users don't have a good way to play videos on password-protected Samba shares: https://bugs.kde.org/show_bug.cgi?id=355328 For programs that use it, KIO transparently provides network protocol access, abstracting away the details and security aspects. DragonPlayer is the

D8296: Use Alt+, as the standard shortcut for "Configure "

ngraham added a comment. Thanks for your comments, @rkflx. I have no strong opinions on what the shortcut should be. Side note: if KMail and Kontact don't get this change automatically, that's a sign that they're not using `KStandardAction::Preferences()` and should be. REPOSITORY

D8296: Use Alt+, as the standard shortcut for "Configure "

rkflx added a comment. Since @ngraham added me as reviewer, here are my 2 cents. Trying the patch, I made those observations: - [Alt] often is released by the user only after the dialog is shown already, resulting in the (normally hidden) accelerators ("_") of the dialog showing and

D7828: createKMessageBox tries to focus a default button when available

rkflx added a comment. In general, having a default button while setting the initial focus elsewhere is mainly useful for larger dialogs like our various standard configuration dialogs, where this provides a way to accept without tabbing forever. For smaller dialogs like a messagebox this

D8437: KWidgetsAddons : more compact password dialog

ngraham accepted this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks, kfunk, ngraham Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

rjvbb edited the summary of this revision. rjvbb edited the test plan for this revision. rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks, kfunk Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

rjvbb updated this revision to Diff 21340. rjvbb added a comment. patch cleaned up as requested. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8437?vs=21188=21340 REVISION DETAIL https://phabricator.kde.org/D8437 AFFECTED FILES src/kpassworddialog.ui To: rjvbb, #frameworks,

D7828: createKMessageBox tries to focus a default button when available

aacid added a comment. In https://phabricator.kde.org/D7828#160029, @ngraham wrote: > In other words, it seems intentional that the button marked default will always receive focus. No, open kate->settings->configure kate Ok is the default button and it is not supposed to

D7828: createKMessageBox tries to focus a default button when available

emateli added a comment. I think this is getting a bit out of hand here. Please try to read my last message where I explain why I decided to submit this patch and why I think it's a bug (the whole parent widget thing). Given the new information on why this occurs the whole focus by

D7828: createKMessageBox tries to focus a default button when available

ngraham added a comment. In https://phabricator.kde.org/D7828#160028, @aacid wrote: > In https://phabricator.kde.org/D7828#160018, @ngraham wrote: > > > Once you press tab the focus moves elsewhere and hitting return or enter will press whatever's selected rather than the original

D7828: createKMessageBox tries to focus a default button when available

aacid added a comment. In https://phabricator.kde.org/D7828#160018, @ngraham wrote: > Once you press tab the focus moves elsewhere and hitting return or enter will press whatever's selected rather than the original default button. So really the concept of a "Default Button" in our world

D7828: createKMessageBox tries to focus a default button when available

ngraham added a comment. Once you press tab the focus moves elsewhere and hitting return or enter will press whatever's selected rather than the original default button. So really the concept of a "Default Button" in our world seems to mostly be synonymous with "the button that receives

D7828: createKMessageBox tries to focus a default button when available

aacid added a comment. In https://phabricator.kde.org/D7828#159598, @ngraham wrote: > In https://phabricator.kde.org/D7828#159556, @abetts wrote: > > > If you have two highlights, how do you know what's going to be activated when hitting enter? > > > My thoughts exactly.

D7194: Detach before setting the d pointer

apol added a comment. In https://phabricator.kde.org/D7194#159878, @kossebau wrote: > @apol Was this patch created due to some bug seen, or perhaps only of the kind oh-that-seems-wrong-lets-be-nice-and-prevent-things? If the latter that might be handy :) I had some issue where I

D8450: User can now hide an entire places group from KFilePlacesView

franckarrecot added a comment. I will add pics soonish REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, mlaurent Cc: #frameworks

D7194: Detach before setting the d pointer

kossebau added a comment. @leinir I now completely gave up on the patch which tried to adapt to the non-shared EntryInternal. As the screenshot loading code and the payload download code rely on the explicitly shared data to attach the fetched screenshots resp. update the download state,

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 132 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/132/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 25 Oct 2017 13:10:40 + Build duration: 13 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 128 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/128/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Wed, 25 Oct 2017 13:10:40 + Build duration: 4 min 13 sec and counting

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c52a6c574869: [PlasmaComponents Menu] Add ungrabMouseHack (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 134 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/134/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 25 Oct 2017 11:47:45 + Build duration: 1 min 49 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 128 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/128/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 25 Oct 2017 11:47:45 + Build duration: 1 min 17 sec and counting JUnit Tests

D8451: JavaScript: include standard mime types

ChALkeR edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8451 To: ChALkeR, #framework_syntax_highlighting Cc: #frameworks

D8434: Created 'shared' section

renatoo updated this revision to Diff 21297. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21238=21297 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8348: Add a section for removable devices

renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8348: Add a section for removable devices

renatoo updated this revision to Diff 21296. renatoo added a comment. Used new connect API REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21228=21296 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 133 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/133/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 25 Oct 2017 10:43:44 + Build duration: 4 min 58 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 127 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/127/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 25 Oct 2017 10:43:44 + Build duration: 44 sec and counting JUnit Tests

D8450: User can now hide an entire places group from KFilePlacesView

franckarrecot updated this revision to Diff 21291. franckarrecot added a comment. updated according to comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8450?vs=21244=21291 REVISION DETAIL https://phabricator.kde.org/D8450 AFFECTED FILES

D8367: Hidding place groups implementation in KFilePlacesModel

franckarrecot updated this revision to Diff 21290. franckarrecot added a comment. updated according to comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=21243=21290 REVISION DETAIL https://phabricator.kde.org/D8367 AFFECTED FILES

D8366: Factoring out lists of url data within KFilePlacesModelTest

franckarrecot updated this revision to Diff 21289. franckarrecot added a comment. switch removable after regular devices REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8366?vs=20973=21289 REVISION DETAIL https://phabricator.kde.org/D8366 AFFECTED FILES

D8450: User can now hide an entire places group

franckarrecot retitled this revision from "WIP: User can now hide an entire places group" to "User can now hide an entire places group". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, mlaurent Cc: #frameworks

D8450: User can now hide an entire places group from KFilePlacesView

franckarrecot retitled this revision from "User can now hide an entire places group" to "User can now hide an entire places group from KFilePlacesView". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, mlaurent Cc: #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. seems ok for me REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, mlaurent Cc: mlaurent, #frameworks

D8450: WIP: User can now hide an entire places group

mlaurent added inline comments. INLINE COMMENTS > kfileplacesview.cpp:297 > +const QModelIndexList indexesGroup = > placesModel->groupIndexes(placesModel->groupType(index)); > + > +for (const QModelIndex : indexesGroup) { m_disappearingItems.reserve(m_disappearingItems.count() +

Re: Frameworks release schedule?

On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote: > Hi, > I send this email to kde-frameworks-devel > > It's the correct ML for having an answer about it > > Regards. > > Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit : >> Hello folks, with my Kubuntu

Re: Frameworks release schedule?

On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote: > Hi, > I send this email to kde-frameworks-devel > > It's the correct ML for having an answer about it > > Regards. > > Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit : >> Hello folks, with my Kubuntu

Re: Frameworks release schedule?

Hi, I send this email to kde-frameworks-devel It's the correct ML for having an answer about it Regards. Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit : > Hello folks, with my Kubuntu release manager hat on, I was filling in > the calendar for the next 6 months. For

Re: Frameworks release schedule?

Hi, I send this email to kde-frameworks-devel It's the correct ML for having an answer about it Regards. Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit : > Hello folks, with my Kubuntu release manager hat on, I was filling in > the calendar for the next 6 months. For

D7828: createKMessageBox tries to focus a default button when available

emateli added a comment. Hey @subdiff, thanks for your input on this. Whether this patch goes in or not, I still think that this "odd" behaviour is something that the frameworks should fix or change rather than relying on the developer of each application to do this. However I never

D7194: Detach before setting the d pointer

leinir added a subscriber: sitter. leinir added a comment. Damn... Well spotted, @kossebau. Right, so immediate (at least temporary solution) to make things not broken would annoyingly enough be to revert the patch, yes... I am now thinking that another oddity noticed by @sitter last week

D8463: C# syntax highlighting, add support for multi-line @"verbatim strings"

genethomas created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I have added support for mult-iline @"verbatim strings" REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D8367: Hidding place groups implementation in KFilePlacesModel

mlaurent added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:596 > +const QHash groupStates = groupStateHidden(root); > +for (KFilePlacesItem *item : items) { > +if (bool hasToBeHidden = groupStates.value(item->groupType())) { for(... :

Frameworks release schedule?

Hello folks, with my Kubuntu release manager hat on, I was filling in the calendar for the next 6 months. For Frameworks, this page: https://community.kde.org/Schedules/Frameworks is now on a provisional schedule - 5.40 (expected) Sat November 4th, 2017 for tagging, (expected) Sat November 11th,

D8348: Add a section for removable devices

mlaurent added inline comments. INLINE COMMENTS > kfileplacesitem.cpp:354 > +if (m_access) { > +connect(m_access, SIGNAL(accessibilityChanged(bool,QString)), > +this, SLOT(onAccessibilityChanged(bool))); could you use new connect api please ? REPOSITORY

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

fabianr added a comment. Not really on topic, but could you change the label for the "Advanced options" to something more meaningful, eg "Terminal options" ? The HIG recommends not to use the label "Advanced options", but " Use a descriptive label so that it reflects the functionality. "