KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9 - Build # 33 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.9/33/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 17 Nov 2017 04:04:57 + Build duration: 2 hr 21 min and counting JUnit

D8782: add *.email to the extensions

genethomas added a comment. I can not commit. Can you please arrange access for myself? $git push fatal: remote error: service not enabled: /syntax-highlighting REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8782 To: genethomas, vkrause, dhaumann

D8811: [knewstuff] Do not leak ImageLoader on error

This revision was automatically updated to reflect the committed changes. Closed by commit R304:ab6a48778bbe: [knewstuff] Do not leak ImageLoader on error (authored by anthonyfieroni). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8811?vs=22408=22501

D8858: Fix testWaylandFullscreenShell.

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Could you please add a message that it is missing? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8858 To: cgiboudeaux, graesslin Cc:

D8173: Use readelf to find project dependencies

apol updated this revision to Diff 22498. apol added a comment. Added "" around a variable that may contain ; REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8173?vs=22496=22498 BRANCH arcpatch-D8173_1 (branched from master) REVISION DETAIL

D8173: Use readelf to find project dependencies

apol updated this revision to Diff 22496. apol added a comment. Pass LANG=C to readelf so it doesn't appear in catalan (or anything other than C) and pass ECM_ADDITIONAL_FIND_ROOT_PATH to look for dependencies REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D8847: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40

This revision was automatically updated to reflect the committed changes. Closed by commit R320:75a3723c45e3: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40 (authored by ngraham). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8847?vs=22466=22495

D8858: Fix testWaylandFullscreenShell.

cgiboudeaux created this revision. cgiboudeaux added a reviewer: graesslin. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY This test needs the weston executable. Skip the test if the

KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 60 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/60/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Thu, 16 Nov 2017 22:28:36 + Build duration: 6 min 7 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 59 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/59/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 22:28:36 + Build duration: 6 min 33 sec and counting JUnit Tests

Re: liquidshell in kdereview

On Dienstag, 7. November 2017 20:55:57 CET Martin Flöser wrote: > Am 2017-11-07 20:08, schrieb Martin Koller: > >> Are you aware that KWin uses QtQuick for all its UI elements, such as > >> Alt+TAB? > > > > I have deactivated the compositor since sadly it simply does not work > > on my laptop

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

rkflx added a comment. IMHO the problem is not so much in the single text field, but how/where the results are presented. (Sorry I haven't got around to open the task yet. I did not forget, but Okular was more important last weekend…) REPOSITORY R241 KIO REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

ngraham added a comment. If the ability to add a custom path is important, maybe we should put that under "Terminal options". I don't think we're ever going to figure out a functional UI for that single text field to work equally well for searching and entering a path with history.

D8332: Added baloo urls into places model

ngraham added a comment. @ervin and @dvratil, any remaining concerns? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: mwolff, dfaure, ervin, usta, mlaurent,

D8348: Add a section for removable devices

renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source model for PlacesItemModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff Cc: mwolff, abetts, mlaurent, anthonyfieroni,

D8332: Added baloo urls into places model

renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source model for PlacesItemModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: mwolff,

D8434: Created 'remote' section

renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source model for PlacesItemModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent,

KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 59 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/59/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Thu, 16 Nov 2017 19:23:25 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 58 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/58/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 19:23:25 + Build duration: 8 min 52 sec and counting JUnit Tests

D8396: Add support for zwp_idle_inhibit_manager_v1

This revision was automatically updated to reflect the committed changes. Closed by commit R127:9520c2f292d0: Add support for zwp_idle_inhibit_manager_v1 (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8396?vs=21046=22482#toc REPOSITORY R127 KWayland CHANGES

D8837: Fix testtrash with qtbase 5.10 beta 4

bcooksley added a comment. The reason why I ask is - would it be worth setting up a parallel build against Qt 5.10 on the CI to see what else breaks test wise? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: cgiboudeaux,

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 - Build # 58 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/58/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 16 Nov 2017 15:20:59 + Build duration: 2 hr 29 min and counting

Re: Latte : make_unique for gcc <=4.8

2017-11-09 10:58 GMT+02:00 Tomaz Canabrava : > > >> regards, >> [michail] >> >> >> BTW: for every e-mail I send I need moderator approval is that a standard >> procedure or I can register somewhere to avoid this? >> > > yes, you can:

Re: Latte : make_unique for gcc <=4.8

gcc 4.8.5 is used by openSUSE Leap. If you check the code now i enable it through cmake if it is needed by using the flag -DINCLUDE_MAKE_UNIQUE=ON Στις 9 Νοε 2017 11:56, ο χρήστης "Sven Brauch" έγραψε: On 05/11/17 16:12, Michail Vourlakos wrote: > Do you know any better

D8851: Set enable_blur_behind hint on demand.

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Creating a window handle is relatively slow. We don't want it in the constructor if we don't need it. Replaces

D8848: do not install development tool to aggregate desktop files

gregormi accepted this revision. gregormi added a comment. This revision is now accepted and ready to land. Approval from my side. Thanks. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D8848 To: sitter, #frameworks, whiting, gregormi

D8847: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40

elvisangelaccio accepted this revision as: elvisangelaccio. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D8847 To: ngraham, #frameworks, broulik, elvisangelaccio

D8848: do not install development tool to aggregate desktop files

sitter created this revision. sitter added reviewers: Frameworks, whiting, gregormi. Restricted Application added a project: Frameworks. REVISION SUMMARY it's not useful in production REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D8848 AFFECTED

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 139 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/139/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Thu, 16 Nov 2017 15:20:59 + Build duration: 9 min 1 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 143 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/143/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 15:20:59 + Build duration: 7 min 0 sec and counting

D8847: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40

ngraham created this revision. ngraham added reviewers: Frameworks, broulik, elvisangelaccio. REVISION SUMMARY master now has KF 5.40, so require that and always use KIO::PreviewJob::defaultPlugins(), which lets us get rid of some unnecessary code TEST PLAN Tested in KDE Neon. Compiles and

D8809: Reduce spurious signal emissions

This revision was automatically updated to reflect the committed changes. Closed by commit R242:11c9206bf68f: Reduce spurious signal emissions (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8809?vs=22304=22465 REVISION

D8809: Reduce spurious signal emissions

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvgitem.cpp:295 > If we always have 4 and can initialised them to 0 qreal[4] with a c style > array would be better. Would it? it's harder to compare then as you can't do a simple `!=` REPOSITORY R242 Plasma

D8522: keyboard navigation in and out QML kcms

This revision was automatically updated to reflect the committed changes. Closed by commit R295:9ebf898572ca: keyboard navigation in and out QML kcms (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=22463=22464 REVISION DETAIL

D8522: keyboard navigation in and out QML kcms

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel,

D8522: keyboard navigation in and out QML kcms

mart marked 2 inline comments as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8522: keyboard navigation in and out QML kcms

mart updated this revision to Diff 22463. mart added a comment. - guard null REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=21440=22463 BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 AFFECTED FILES

D8809: Reduce spurious signal emissions

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > framesvgitem.cpp:295 > + > +const QVector m_oldMargins; > +FrameSvgItemMargins *const m_margins; If we always have 4 and can initialised them

D8728: Install mimetype definitions for kcfg/kcfgc/ui.rc/knotify & qrc files

kossebau added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8728 To: kossebau, #frameworks, dfaure Cc: ngraham

D8811: [knewstuff] Do not leak ImageLoader on error

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good to me :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D8811 To: anthonyfieroni, leinir, dfaure Cc: broulik, #frameworks, ZrenBot

D8348: Add a section for removable devices

renatoo updated this revision to Diff 22453. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=22393=22453 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks

D8434: Created 'remote' section

renatoo updated this revision to Diff 22454. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22394=22454 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 22451. renatoo added a comment. Make 'isFileIndexingEnabled' a static function REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=22328=22451 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES

Re: What controls the default ordering of which application handles an opened file?

On Thu, Nov 16, 2017 at 4:24 AM, Nate Graham wrote: > Howdy all, > I'm working on adding Krita file support to Gwenview > (https://phabricator.kde.org/D8751) and my patch works, but has the side > effect of causing Krita files to prefer being opened in Gwenview rather than

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 140 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/140/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Thu, 16 Nov 2017 12:56:08 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 141 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/141/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 12:56:08 + Build duration: 6 min 58 sec and counting JUnit Tests Name:

D8841: Fix build on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a208dc70c9a5: Fix build on FreeBSD (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8841?vs=22441=22446 REVISION DETAIL

KDE CI: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.9 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.9/13/ Project: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 16 Nov 2017 12:07:38 + Build duration: 12 min and counting JUnit

D8825: do not show edit bookmarks action if keditbookmarks is not installed

sitter updated this revision to Diff 22443. sitter added a comment. rebased REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8825?vs=22379=22443 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8825 AFFECTED FILES

D8824: port from deprecated KAuthorized::authorizeKAction to authorizeAction

This revision was automatically updated to reflect the committed changes. Closed by commit R294:378808a575d7: port from deprecated KAuthorized::authorizeKAction to authorizeAction (authored by sitter). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE

D8841: Fix build on FreeBSD

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Weird, I wonder what's the relation with FreeBSD :) Compiler, I guess... REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8841 To: elvisangelaccio,

D8841: Fix build on FreeBSD

elvisangelaccio created this revision. elvisangelaccio added reviewers: adridg, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I broke the build on FreeBSD, this patch should fix it. REPOSITORY R241 KIO

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 139 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/139/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Thu, 16 Nov 2017 11:14:33 + Build duration: 5 min 59 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 140 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/140/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 11:14:33 + Build duration: 4 min 55 sec and counting CONSOLE OUTPUT

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2353119aae8f: Fix KIO::mkpath with qtbase 5.10 beta 4 (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8836?vs=22433=22436 REVISION

D8837: Fix testtrash with qtbase 5.10 beta 4

This revision was automatically updated to reflect the committed changes. Closed by commit R241:05938a167dd4: Fix testtrash with qtbase 5.10 beta 4 (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8837?vs=22431=22437 REVISION DETAIL

D8522: keyboard navigation in and out QML kcms

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmoduleqml.cpp:154 > can this be null? Quick glance at `QQuickItemPrivate::nextPrevItemInTabFocusChain` shows it cannot. In doubt it returns `this`. REPOSITORY R295 KCMUtils REVISION DETAIL

D8522: keyboard navigation in and out QML kcms

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmoduleqml.cpp:143 > +{ > +//FIXME: those are all workarounds around the QQuickWidget brokeness > +if (watched == d->quickWidget &&

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 To: elvisangelaccio, #frameworks, dfaure, thiago

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

elvisangelaccio edited the summary of this revision. elvisangelaccio edited the test plan for this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 To: elvisangelaccio, #frameworks, dfaure, thiago

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

elvisangelaccio marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 To: elvisangelaccio, #frameworks, dfaure, thiago

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

elvisangelaccio updated this revision to Diff 22433. elvisangelaccio added a comment. - Use local variables REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8836?vs=22432=22433 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 AFFECTED FILES

D8837: Fix testtrash with qtbase 5.10 beta 4

cgiboudeaux added a comment. In https://phabricator.kde.org/D8837#168327, @bcooksley wrote: > Elvis, how many other issues like this do we expect to crop up due to Qt 5.10? https://bugs.kde.org/386420 ? REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

dfaure added inline comments. INLINE COMMENTS > mkpathjob.cpp:46 > for (; i < basePathComponents.count() && i < > m_pathComponents.count(); ++i) { > if (m_pathComponents.at(i) == basePathComponents.at(i)) { > +if (m_url.path() == QLatin1Char('/')) { I

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

elvisangelaccio updated this revision to Diff 22432. elvisangelaccio added a comment. - Fix also mkpathjobtest and fileundomanagertest REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8836?vs=22430=22432 BRANCH master REVISION DETAIL

D8837: Fix testtrash with qtbase 5.10 beta 4

elvisangelaccio added a comment. In https://phabricator.kde.org/D8837#168327, @bcooksley wrote: > Elvis, how many other issues like this do we expect to crop up due to Qt 5.10? I have two other failing tests in kio, which I'm fixing now. I guess this change will probably break

D8837: Fix testtrash with qtbase 5.10 beta 4

bcooksley added a comment. Elvis, how many other issues like this do we expect to crop up due to Qt 5.10? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: bcooksley, #frameworks

D8837: Fix testtrash with qtbase 5.10 beta 4

dfaure added a comment. More seriously, this could be a reason for adding QUrl::addPath(), like we had in KUrl. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: #frameworks

D8837: Fix testtrash with qtbase 5.10 beta 4

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: #frameworks

D8837: Fix testtrash with qtbase 5.10 beta 4

dfaure added a comment. Maybe we need a KUrl class :-) Just kidding. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: #frameworks

D8837: Fix testtrash with qtbase 5.10 beta 4

elvisangelaccio created this revision. elvisangelaccio added reviewers: dfaure, thiago. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Same fix as in https://phabricator.kde.org/D8836, this time for testtrash. TEST

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Urgh. That QUrl change doesn't make things easy for this type of code indeed. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 To:

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

dfaure added a reviewer: thiago. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8836 To: elvisangelaccio, #frameworks, dfaure, thiago

D8522: keyboard navigation in and out QML kcms

mart added a comment. ping REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8836: Fix KIO::mkpath with qtbase 5.10 beta 4

elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY The latest Qt 5.10 beta includes [1] which breaks KIO all over the place, since `url.setPath("//foo")` will now result in an invalid