Re: Closing old Plasma 4 bugs

2018-05-26 Thread Olivier Churlaud
Hello, Just to remind you that companies using KDE/Plasma on RHEL7 are still using plasma 4. I don't know if it has an impact but in case I wanted to point it out. Cheers, Olivier Le samedi 26 mai 2018, 05:09:06 CEST Nate Graham a écrit : > Kubuntu 18.04 has now now been out for a month, so

D13124: [RFC] Add Share action to Dolphin context menu

2018-05-26 Thread Nicolas Fella
nicolasfella updated this revision to Diff 34934. nicolasfella added a comment. - Set mimetype to */* if reported mimetype is empty REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=34933=34934 BRANCH fiap REVISION DETAIL

D13124: [RFC] Add Share action to Dolphin context menu

2018-05-26 Thread Nicolas Fella
nicolasfella marked an inline comment as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun,

D13124: [RFC] Add Share action to Dolphin context menu

2018-05-26 Thread Nicolas Fella
nicolasfella updated this revision to Diff 34933. nicolasfella added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. Make it a FileItemActionPlugin REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

2018-05-26 Thread Alessandro Longo
alex-l added a comment. Gray seems OK to me. And I confirm the bug with Saturday column. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks, #vdg Cc: alex-l, rkflx, cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham,

D13137: Updated handles and overflow-menu-*

2018-05-26 Thread Alessandro Longo
alex-l edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13137 To: alex-l, mart, andreask, andreaska Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13137: Updated handles and overflow-menu-*

2018-05-26 Thread Alessandro Longo
alex-l created this revision. alex-l added reviewers: mart, andreask, andreaska. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. alex-l requested review of this revision. REVISION SUMMARY - Added the icons in the image as 22px

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 272 - Still Unstable!

2018-05-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/272/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 26 May 2018 16:52:01 + Build duration: 23 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 122 - Still Unstable!

2018-05-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/122/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 26 May 2018 16:48:33 + Build duration: 16 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 271 - Still Unstable!

2018-05-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/271/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 26 May 2018 16:40:36 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 26 - Still Unstable!

2018-05-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/26/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 26 May 2018 16:46:46 + Build duration: 4 min 36 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 121 - Still Unstable!

2018-05-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/121/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 26 May 2018 16:40:36 + Build duration: 7 min 55 sec and counting JUnit Tests Name:

D12728: KFileItemActions: fallback to default mimetype when selecting only files

2018-05-26 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R241:233a00b7e162: KFileItemActions: fallback to default mimetype when selecting only files (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 25 - Still Unstable!

2018-05-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/25/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 26 May 2018 16:40:36 + Build duration: 5 min 28 sec and counting JUnit Tests

D12727: Introduce KFileItemListProperties::isFile()

2018-05-26 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R241:c84c8afd7f55: Introduce KFileItemListProperties::isFile() (authored by elvisangelaccio). Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO CHANGES SINCE LAST

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

2018-05-26 Thread Nathaniel Graham
ngraham added a comment. I don't know. Perhaps it's time to involve more VDG people. #VDG , how should we style weekend days and day names? Currently we draw them in dark red, which is problematic for a few reasons: F5869969:

Re: Closing old Plasma 4 bugs

2018-05-26 Thread Nate Graham
Yes, in fact I work for a company some of whose employees and customers use RHEL 7 (and 6, and 5, believe it or not...). In the end, I don't think it's relevant to us. KDE Plasma 4 wasn't the default shell in any of these distros anyway, so we are talking about an inherently old, niche use

D13120: fix i18n issues in framworks/purpose/plugins

2018-05-26 Thread Albert Astals Cid
aacid added a comment. if there's other places using the backslash it's fine, no need to change :) REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13120 To: lueck, #frameworks, #localization, nicolasfella, apol Cc: aacid, apol, kde-frameworks-devel,

D13117: Don't set custom domain filter rules

2018-05-26 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R281 ModemManagerQt BRANCH fix-logging REVISION DETAIL https://phabricator.kde.org/D13117 To: aleksanderm, jgrulich, broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13120: fix i18n issues in framworks/purpose/plugins

2018-05-26 Thread Burkhard Lück
lueck added a comment. In D13120#268343 , @aacid wrote: > Are you sure you need the backslashes in add_definitions? probably not. i simply used what is used in the majority of all modules (frameworks, workspace, kde*, pim), except

D13131: Add general purpose data types for PostgreSQL

2018-05-26 Thread damien clochard
damienclochard created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. damienclochard requested review of this revision. REVISION SUMMARY see

D13130: Add new DDL partitioning keywords

2018-05-26 Thread damien clochard
damienclochard created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. damienclochard requested review of this revision. REVISION SUMMARY see https://www.postgresql.org/docs/current/static/ddl-partitioning.html

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

2018-05-26 Thread Henrik Fehlauer
rkflx added a comment. In D12756#268345 , @ngraham wrote: > Use conditional grays instead of reds (red was never an appropriate color anyway) Hm, now Sundays look like they belong to the previous/next month. (Do we even need to change