KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 274 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/274/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 May 2018 03:36:24 + Build duration: 33 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 124 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/124/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 29 May 2018 03:36:24 + Build duration: 19 min and counting JUnit Tests Name: (root)

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

smithjd added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Is your report in bug https://bugs.kde.org/show_bug.cgi?id=364574 related to this diff? If so it could be marked as a duplicate. REPOSITORY R293 Baloo REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/28/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 29 May 2018 03:36:24 + Build duration: 5 min 7 sec and counting JUnit Tests Name:

D12025: Terminate query execution early if subterm returns empty result set

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH terminate_empty_terms_early REVISION DETAIL https://phabricator.kde.org/D12025 To: bruns, #baloo, michaelh, #frameworks, dhaumann Cc: kde-frameworks-devel, #frameworks,

D13067: add pgf to the latex-ish file formats (same format as tikz)

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. This patch is correct, except that the version needs to be increased. Will integrate later. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL

D13067: add pgf to the latex-ish file formats (same format as tikz)

dhaumann added a project: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13067 To: jan.hajer Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, vkrause, dhaumann

D12233: Avoid manipulation of lists with quadratic complexity

dhaumann added a comment. Looks good to me. INLINE COMMENTS > pendingfilequeue.cpp:69 > +const auto droppedFilesBegin = std::partition(m_cache.begin(), end, > keepFile); > +for (auto it = droppedFilesBegin; it != end; it++) { > +m_pendingFiles.remove(it->path());

D12047: Avoid crash when reading corrupt data from document terms db

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. If the format is really such that a term must appear before any Suffix, then this patch is already better that before. Could it happen to have e.g.: a\0b1c1 If so, this code

D12025: Terminate query execution early if subterm returns empty result set

bruns added a comment. If there a no comments, I will push tomorrow. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12025 To: bruns, #baloo, michaelh, #frameworks Cc: kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D12025: Terminate query execution early if subterm returns empty result set

bruns updated this revision to Diff 35070. bruns added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12025?vs=31612=35070 BRANCH terminate_empty_terms_early REVISION

D12047: Avoid crash when reading corrupt data from document terms db

bruns updated this revision to Diff 35069. bruns added a comment. Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12047?vs=31672=35069 BRANCH b392878_avoid_docterms_decode_crash REVISION DETAIL https://phabricator.kde.org/D12047 AFFECTED FILES

D12233: Avoid manipulation of lists with quadratic complexity

bruns marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh Cc: ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun

D12233: Avoid manipulation of lists with quadratic complexity

bruns commandeered this revision. bruns edited reviewers, added: michaelh; removed: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh Cc: ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun

D12233: Avoid manipulation of lists with quadratic complexity

bruns updated this revision to Diff 35068. bruns added a comment. Fix remaining issue (inverse condition in std::partition), cleanup REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12233?vs=32595=35068 BRANCH arcpatch-D12233 REVISION DETAIL

D12047: Avoid crash when reading corrupt data from document terms db

bruns added a comment. If there is noone willing to review, I will push this tomorrow REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12047 To: bruns, #baloo, michaelh, ngraham, #frameworks Cc: kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich,

D12513: CVE-2018-10361: privilege escalation

aacid added a comment. I think it was agreed this is an improvement, so i'm going to suggest we commit it. I'm definitely very short on time to spend here because someone added poppler to oss-fuzz and i've a pile of files that are crashing / causing bad behaviour on poppler to care

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 123 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/123/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 28 May 2018 17:55:47 + Build duration: 31 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 273 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/273/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 May 2018 17:55:47 + Build duration: 5 min 16 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/27/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 28 May 2018 17:55:48 + Build duration: 5 min 30 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/8/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 28 May 2018 17:36:22 + Build duration: 55 sec and counting JUnit Tests

Re: Closing old Plasma 4 bugs

On Sun, May 27, 2018 at 9:05 PM, Elvis Angelaccio wrote: > On Fri, May 11, 2018 at 11:06 PM Christoph Feck wrote: > >> On 11.02.2018 20:52, Nate Graham wrote: >> > All right, so let's give it a shot. How about we make it so that normal >> > users have

D13137: Updated handles and overflow-menu-*

hein accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13137 To: alex-l, mart, andreask, andreaska, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13137: Updated handles and overflow-menu-*

andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13137 To: alex-l, mart, andreask, andreaska Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

chinmoyr abandoned this revision. chinmoyr added a comment. As of now this change is not of any importance. If in future a situation arises where we need it I will reopen this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12291 To: chinmoyr, #frameworks,

D13137: Updated handles and overflow-menu-*

mart added a comment. +1 from me, exactly what was needed! any definitive ship it from other vdg people REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13137 To: alex-l, mart, andreask, andreaska Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

chinmoyr updated this revision to Diff 35010. chinmoyr added a comment. Accept socket connection where getsockopt() is not present REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12291?vs=34966=35010 BRANCH master REVISION DETAIL

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoredirlister.cpp:963 > QUrl oldurl = src.adjusted(QUrl::StripTrailingSlash); > -KFileItem *fileitem = findByUrl(nullptr, oldurl); > -if

D12291: Accept file descriptor only from root owned process

ossi added inline comments. INLINE COMMENTS > chinmoyr wrote in fdreceiver.cpp:89 > > i don't see why that would be horrible > > I meant adding "acceptConnection = true;" after #warning would look weird. > Obviously that's not even an issue and I shouldn't have mentioned it. > > There is a

D12745: Unify API for file descriptor sharing

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 27 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/27/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 28 May 2018 06:28:41 + Build duration: 6 min 11 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/51/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 May 2018 06:28:41 + Build duration: 1 min 48 sec and counting JUnit Tests

D12291: Accept file descriptor only from root owned process

chinmoyr added inline comments. INLINE COMMENTS > ossi wrote in fdreceiver.cpp:89 > i don't see why that would be horrible; as i pointed out multiple times > already, this change is redundant. one correction, though: add a code comment > here rather than extending the commit message. > >

KDE CI: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 - Build # 21 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20WindowsMSVCQt5.10/21/ Project: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 Date of build: Mon, 28 May 2018 06:05:36 + Build duration: 2 min 17 sec and counting JUnit