D20697: Review IconBorder

loh.tar added a comment. @dhaumann Beside these annotation stuff I think I'm done with this now. Should you, or someone else, not stop me in the next few days I may treat this as OK and push it. There are still some issues in the mouse move handling but will try to fix that in some other

D20697: Review IconBorder

loh.tar edited the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D20697: Review IconBorder

loh.tar updated this revision to Diff 56694. loh.tar edited the summary of this revision. loh.tar added a comment. - Fix bookmark pixmap painting Left before, right with fix F6786476: bookmark-pixmap.png CHANGES SINCE LAST UPDATE

D20697: Review IconBorder

loh.tar updated this revision to Diff 56693. loh.tar edited the summary of this revision. loh.tar added a comment. - Add margin to the edit area, but I'm not sure if it should be done here. I guess renderer should do it - Simplify "additional folding highlighting", there is now the slightly

D20708: Change input-* device icon styles, add 16px icons

ndavis added a comment. Actually, `dialog-input-devices` is used by inkscape for configuring pointing devices and tablets. AFAIK, only Inkscape uses that icon. If I made it show more types of devices, it would be more accurate to use a tablet. Looking at the Input Devices dock in Inkscape,

D20708: Change input-* device icon styles, add 16px icons

ndavis added a comment. In D20708#453690 , @ngraham wrote: > Overall very nice. > > Instead of symlinking `input-mouse` to `dialog-input-devices`, I think it might make more sense to rename `dialog-input-devices` to be `input-mouse` and

D20169: Add profile support interface for TerminalInterface

mschiller added a comment. > wrt getProfilePath: what if an application does not store a profile as single filename, for example as directory, or even stored e.g. in a DB? maybe it would be better to have this as property of a profile Yeah Konsole Profiles seem to already have a path

D20695: Add more icon sizes for audio, configure, distribute

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great, thanks! REPOSITORY R242 Plasma Framework (Library) BRANCH add-new-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D20695 To: ndavis, #vdg,

D20169: Add profile support interface for TerminalInterface

pino added a comment. General notes on the API (not a konsole developer though): - an abstract virtual destructor is needed - in kdelibs/kf5 lingo, the "get" as prefix of API getters is generally not used - `setCurrentProfile` instead of `changeCurrentProfile`? the latter makes me

D20536: Use consistent default Kickoff user icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:1c6e30d312c7: Use consistent default Kickoff user icon (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20536?vs=56677=56678#toc REPOSITORY R266 Breeze Icons CHANGES

D20536: Use consistent default Kickoff user icon

GB_2 updated this revision to Diff 56677. GB_2 added a comment. Fix diff REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20536?vs=56263=56677 BRANCH arcpatch-D20536_1 REVISION DETAIL https://phabricator.kde.org/D20536 AFFECTED FILES

D20700: Add "edit-remove" icon symlink

ngraham added a comment. Yeah, I think the current minus icon is similar in that it's only meaningful next to a plus sign. So if we had a user interface with conjoined or adjacent plus and minus buttons, using that icon would make sense. But for removing a specific list item, I think this

D20169: Add profile support interface for TerminalInterface

mschiller updated this revision to Diff 56672. mschiller edited the summary of this revision. mschiller added a comment. Move the profile support to different class REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20169?vs=55201=56672 BRANCH

D20708: Change input-* device icon styles, add 16px icons

ngraham added a comment. Overall very nice. Instead of symlinking `input-mouse` to `dialog-input-devices`, I think it might make more sense to rename `dialog-input-devices` to be `input-mouse` and then change the `dialog-input-devices` so that it depicts more than one input device, to

D20169: Add profile support interface for TerminalInterface

pino added a comment. Yes, this change breaks the binary compatibility. Please add a TerminalInterfaceV2 that inherits TerminalInterface instead, or add a separate interface for profile handling. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller,

D20169: Add profile support interface for TerminalInterface

mschiller edited the summary of this revision. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: michaelh, ngraham, bruns

D20700: Add "edit-remove" icon symlink

GB_2 added a comment. In D20700#453658 , @ndavis wrote: > We have a problem where we don't use consistent iconography for "remove". Sometimes it's a normal minus, sometimes it's a red minus, sometimes it's a red X and sometimes it's a red trash

D20700: Add "edit-remove" icon symlink

ndavis added a comment. In D20700#453565 , @GB_2 wrote: > `list-remove` is just a minus icon, which has no context and looks weird when used alone, without `list-add` next to it. An example where the new icon can be used is D20576

Re: May 10: Removing l10n support for kde4 playground-* repos

El diumenge, 21 d’abril de 2019, a les 17:47:47 CEST, Luigi Toscano va escriure: > Christoph Feck ha scritto: > > On 04/21/19 12:47, Albert Astals Cid wrote: > >> We have a huge list of playground kde4 repos that are being processed for > >> l10n. > >> > >> This takes some resources that make no

D20702: KTar: Protect against negative longlink sizes

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20702 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: May 10: Removing l10n support for kde4 playground-* repos

Christoph Feck ha scritto: On 04/21/19 12:47, Albert Astals Cid wrote: We have a huge list of playground kde4 repos that are being processed for l10n. This takes some resources that make no sense since you should really not be developing for KDE4 anymore, and if you really really really need

D20708: Change input-* device icon styles, add 16px icons

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20708 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20708: Change input-* device icon styles, add 16px icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY `devices/16` was missing some `input-*` icons. `input-keyboard-virtual` looked more like

D20700: Add "edit-remove" icon symlink

GB_2 added a comment. In D20700#453562 , @ndavis wrote: > Why does `list-remove` need an alternative? > alternative to list-remove, which needs to be next to list-add for context `list-remove` is just a minus icon, which has no

D20700: Add "edit-remove" icon symlink

ndavis added a comment. Why does `list-remove` need an alternative? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20702: KTar: Protect against negative longlink sizes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20702 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: May 10: Removing l10n support for kde4 playground-* repos

On 04/21/19 12:47, Albert Astals Cid wrote: We have a huge list of playground kde4 repos that are being processed for l10n. This takes some resources that make no sense since you should really not be developing for KDE4 anymore, and if you really really really need it, it shouldn't be in

D20700: Add "edit-remove" icon symlink

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon symlink

GB_2 retitled this revision from "Add "edit-remove" icon" to "Add "edit-remove" icon symlink". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon

GB_2 updated this revision to Diff 56651. GB_2 added a comment. Use symlinks: `edit-remove` -> `paint-none` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56634=56651 BRANCH add-edit-remove-icon (branched from master) REVISION DETAIL

May 10: Removing l10n support for kde4 playground-* repos

We have a huge list of playground kde4 repos that are being processed for l10n. This takes some resources that make no sense since you should really not be developing for KDE4 anymore, and if you really really really need it, it shouldn't be in playground. So on May 10 i'll make sure scripty

D20264: Add test for "Auto Reload Document" option

loh.tar added a comment. @dhaumann asked elsewhere > Instead of waiting so long, we could alternatively also have a while loop waiting up to 20 times for 50ms. This way, the test would be faster if possible. Like this? diff --git a/autotests/src/katedocument_test.cpp

D20697: Review IconBorder

loh.tar updated this revision to Diff 56644. loh.tar added a comment. - Fix missing printed background in proper theme color - Fix scroll past end of document - Fix less pushy paint unfolded icon in not dark themes and don't try to use currentLineNumberColor, the folded icon gets also not