Disabling of 'kdav-davitemfetchjob' test in KDav

Hi everyone, Currently we have an issue where the test 'kdav-davitemfetchjob' within kdav causes kdeinit5 to be relaunched, as can be seen in the CI run log below. https://build.kde.org/job/Applications/job/kdav/job/kf5-qt5%20SUSEQt5.12/38/console This is behaviour which is not permitted within

Disabling of 'kdav-davitemfetchjob' test in KDav

Hi everyone, Currently we have an issue where the test 'kdav-davitemfetchjob' within kdav causes kdeinit5 to be relaunched, as can be seen in the CI run log below. https://build.kde.org/job/Applications/job/kdav/job/kf5-qt5%20SUSEQt5.12/38/console This is behaviour which is not permitted within

Disabling akonadi test runner infrastructure across all repositories

Hi all, For some time now the Akonadi Test Runner infrastructure has had issues on the CI system where it will fail to properly shutdown the akonadiserver (and associated subprocesses) that it starts up for tests. This leads to jobs on the CI system becoming indefinitely stuck as CTest will wait

Disabling of 'testkioarchive' in kio-extras

Hi all, Currently we have an issue where the test 'testkioarchive' within kio-extras causes kdeinit5 to be relaunched, as can be seen in the CI run log below. https://build.kde.org/job/Applications/job/kio-extras/job/kf5-qt5%20SUSEQt5.12/40/console This is behaviour which is not permitted

D25296: [RFC] Fix Display Configuration icon margins

ndavis added a comment. I figured it out. The 22px version needs the `22-22-` prefix in its ID. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25296 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Sysadmin Load Reduction: Code Related Services

пт, 15 нояб. 2019 г. в 22:05, Ben Cooksley : > > On Sat, Nov 16, 2019 at 3:27 AM Alexander Potashev > wrote: > > > > пт, 15 нояб. 2019 г. в 15:46, Harald Sitter : > > > > > > On Sat, Nov 9, 2019 at 11:37 PM Alexander Potashev > > > wrote: > > > > > > > > сб, 9 нояб. 2019 г. в 02:51, Ben

Re: kconfig-elektra

On mardi 12 novembre 2019 16:58:19 CET k...@markus-raab.org wrote: > Dear KDE developers, > > As discussed in Akademy 2018 [1] Felix Resch and Dardan Haxhimustafa are > working on a patch for KConfig so that KConfig uses Elektra [2] instead > of the KConfigINI backend. > > We forked the KConfig

D25265: Support adding a contact to a specific backend

jbbgameich added inline comments. INLINE COMMENTS > apol wrote in datasourcemodel.h:43 > Use DisplayRole for this? I intend to add an actual display role later. Strictly speaking this is the id used by KPeople and not anything that should be shown to the user ideally. REPOSITORY R307

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added inline comments. INLINE COMMENTS > sitter wrote in krun.cpp:598 > So did the old code though. See old line 584. > > It's iterating by-reference, so you can simply assign to it via > > https://doc.qt.io/qt-5/qurl.html#operator-eq-1 > > to change the content of the QUrl object

D25015: Update breeze theme shadows

niccolove added a comment. In D25015#563147 , @ngraham wrote: > Do these shadows get cached or something? When I build the diff and restart plasmashell, the shadows I see are identical, pixel-for-pixel. I don't know. But you can manually

D25015: Update breeze theme shadows

ngraham added a comment. Do these shadows get cached or something? When I build the diff and restart plasmashell, the shadows I see are identical, pixel-for-pixel. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc:

D19498: loadLibrary: Use enum values to define what type of plugin we load

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R317 Kross BRANCH enum-for-plugin-types REVISION DETAIL https://phabricator.kde.org/D19498 To: aspotashev, #frameworks, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

bruns added a comment. Moving it to a separate class will also make creating a unit test trivial. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21235 To: hallas, bruns, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fstabhandling.cpp:301 > + > +void Solid::Backends::Fstab::FstabHandling::parseMtabFile(const QString& > mtabPath, QMultiHash& activeMounts, QHash QString>&

D25015: Update breeze theme shadows

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 69820. niccolove added a comment. Updated to new shadows REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=68912=69820 BRANCH breeze-shadows (branched from master) REVISION DETAIL

Re: Sysadmin Load Reduction: Code Related Services

On Sat, Nov 16, 2019 at 3:27 AM Alexander Potashev wrote: > > пт, 15 нояб. 2019 г. в 15:46, Harald Sitter : > > > > On Sat, Nov 9, 2019 at 11:37 PM Alexander Potashev > > wrote: > > > > > > сб, 9 нояб. 2019 г. в 02:51, Ben Cooksley : > > > > In the category of no longer in use, we have the

kconfig-elektra

Dear KDE developers, As discussed in Akademy 2018 [1] Felix Resch and Dardan Haxhimustafa are working on a patch for KConfig so that KConfig uses Elektra [2] instead of the KConfigINI backend. We forked the KConfig repository [3] and currently try to: 1. successfully start KDE to use Elektra

D25236: Remove the last traces of KSslError from TCPSlaveBase

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D25236 To: vkrause, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

davidedmundson added a comment. As an update on this from the Plasma POV. I added the macro to every repo and told every dev to do a final test before we commit the formatted results. I had some feedback and the result was that we can't proceed with in the current state [1].

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/39/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 15 Nov 2019 18:07:37 + Build duration: 4 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/62/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 15 Nov 2019 18:07:36 + Build duration: 3 min 50 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/36/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 15 Nov 2019 18:07:36 + Build duration: 2 min 5 sec and counting JUnit Tests Name:

D25330: Expose KNumberModel to QML

This revision was automatically updated to reflect the committed changes. Closed by commit R275:a1cccfa14d06: Expose KNumberModel to QML (authored by davidedmundson). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25330?vs=69813=69818 REVISION DETAIL

D25330: Expose KNumberModel to QML

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D25330 To: davidedmundson, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: When will akonadi work with Gmail?

This really needs attention, obviously the best fix would be to go back in time and change a few things so this didn't happen in the first place but it is probably more cost effective and quicker if the devs were more proactive about sorting things out with google. FWIW the "fix" isn't working

Re: When will akonadi work with Gmail?

I am always afraid the KDE will lose support or interest from other platforms since most of the Linux distros are choosing GNOME as the default. Will this mean that there will be less support for KDE applications? Evolution seems to work well when set up through GNOME Online Accounts, but KOA is

D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

anthonyfieroni added inline comments. INLINE COMMENTS > slave.cpp:521 > +// isn't the same as applicationDirPath(). > +QString kioslaveExecutable = > QStandardPaths::findExecutable(QStringLiteral("kioslave5")); > +} Remove QString declaration before. REPOSITORY

D25331: Duplicate QML installation for unit tests

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY We run tests pre-installation so have to do various hacks to make things findable. This copies the

D25296: [RFC] Fix Display Configuration icon margins

ngraham updated this revision to Diff 69815. ngraham marked 4 inline comments as done. ngraham added a comment. - Fix stylesheet and color-changing ability - Vertical lines still blurry; not sure why REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/38/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 15 Nov 2019 15:40:40 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/61/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 15 Nov 2019 15:40:41 + Build duration: 11 min and counting BUILD ARTIFACTS

Re: KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 37 - Unstable!

Urgh, my fault. Will fix.

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/35/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 15 Nov 2019 15:40:40 + Build duration: 8 min 10 sec and counting JUnit Tests Name:

D25330: Expose KNumberModel to QML

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D25330 AFFECTED FILES

D25270: Correctly set i18n arguments in one pass

This revision was automatically updated to reflect the committed changes. Closed by commit R304:0099d090be51: Correctly set i18n arguments in one pass (authored by davidedmundson). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25270?vs=69630=69814

D13358: Add new class that is a model of numbers between two values

This revision was automatically updated to reflect the committed changes. Closed by commit R275:4b1e1b44ef9f: Add new class that is a model of numbers between two values (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13358?vs=35681=69812#toc REPOSITORY

D25270: Correctly set i18n arguments in one pass

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D25270 To: davidedmundson, leinir, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25308 To: sitter, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25265: Support adding a contact to a specific backend

apol added inline comments. INLINE COMMENTS > datasourcemodel.h:43 > +enum RoleNames { > +PluginIdRole = Qt::UserRole + 1, > +}; Use DisplayRole for this? > personpluginmanager.h:91 > + * Creates a contact with the specified @p properties > + * in the requested backend

D25311: Add KColumnHeadersProxyModel

vkrause added a comment. In D25311#563011 , @ahiemstra wrote: > > I'm wondering if this is technically a proxy model, or rather a QAbstractListModel? Its content is not representing cells in the source model after all, which mapTo/FromSource

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

kossebau added a comment. In D25323#562989 , @meven wrote: > In D25323#562908 , @kossebau wrote: > > > Thanks for looking at the issue. No time to look closer the next days, but curious about this

D25311: Add KColumnHeadersProxyModel

ahiemstra marked an inline comment as done. ahiemstra added a comment. > We should probably have a unit test, even if it just covers the basic case. Done. > This currently assumes the source model's columns are static. At a minimum that needs a comment. Oops. That was not the

D25311: Add KColumnHeadersProxyModel

ahiemstra updated this revision to Diff 69807. ahiemstra added a comment. - Add a unit test for KColumnHeadersProxyModel REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=69806=69807 BRANCH columnheadersmodel REVISION DETAIL

D25311: Add KColumnHeadersProxyModel

ahiemstra updated this revision to Diff 69806. ahiemstra added a comment. - Forward column change singals as row change signals - Forward header data change signals as dataChanged - Add a unit test for KColumnHeadersProxyModel REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D25015: Update breeze theme shadows

ngraham added a comment. In D25015#562992 , @niccolove wrote: > What do you think of: > F7765076: Screenshot_20191115_145942.png That feels smoother. REPOSITORY R242 Plasma Framework

Re: Sysadmin Load Reduction: Code Related Services

пт, 15 нояб. 2019 г. в 15:46, Harald Sitter : > > On Sat, Nov 9, 2019 at 11:37 PM Alexander Potashev > wrote: > > > > сб, 9 нояб. 2019 г. в 02:51, Ben Cooksley : > > > In the category of no longer in use, we have the compatibility > > > generator for the kde_projects.xml file. This was

D25015: Update breeze theme shadows

niccolove added a comment. This is what you think ends too early (for comparison): F7762929: Screenshot_20191114_100519.png What do you think of: F7765076: Screenshot_20191115_145942.png REPOSITORY R242

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

meven added a comment. In D25323#562908 , @kossebau wrote: > Thanks for looking at the issue. No time to look closer the next days, but curious about this partial change (which has been discussed before and discarded): > changing `QColor (

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25323 To: meven, kossebau, cullmann, vkrause Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D25328: Always rehiglhight() after definition was changed

meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25328 To: meven, kossebau, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,

D25328: Always rehiglhight() after definition was changed

meven created this revision. meven added reviewers: kossebau, cullmann, vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. meven requested review of this revision. REVISION SUMMARY When setting definition, Rehighlight text even if the

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

sitter added inline comments. INLINE COMMENTS > feverfew wrote in krun.cpp:598 > Yes, but note later I need to then change the values in the `QList` outside > of the for loop, hence why I store the index in a struct associated with the > reply. How would I do that easily with a range based for

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

broulik added inline comments. INLINE COMMENTS > sortfiltermodel.cpp:84 > +QQmlEngine *engine = QQmlEngine::contextForObject(this)->engine(); > +args << > engine->toScriptValue(idx.data(m_roleIds.value(m_filterRole))); > + Can we also just have it send `source_row` and

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added inline comments. INLINE COMMENTS > sitter wrote in krun.cpp:583 > Coding style says we use curly braces even for single-line if statements I > think. Yep you're right, will fix in a mo. > sitter wrote in krun.cpp:598 > What I meant is you should literally iterate using > >

Re: Sysadmin Load Reduction: Code Related Services

On Sat, Nov 9, 2019 at 11:37 PM Alexander Potashev wrote: > > сб, 9 нояб. 2019 г. в 02:51, Ben Cooksley : > > In the category of no longer in use, we have the compatibility > > generator for the kde_projects.xml file. This was introduced when we > > shutdown Redmine/Chiliproject and migrated to

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson added inline comments. INLINE COMMENTS > ahiemstra wrote in sortfiltermodel.h:63 > This (and sortRole below) hides the properties from QSortFilterProxy with the > same name. Maybe it is a better idea to use filterRoleName/sortRoleName? Or potentially we could just kill our

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann added a comment. Ok, thank you! REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24641: Collect more information from version control systems

sitter added a comment. This is starting to look really good. All functions will need documenting in the header of that file so they show up on api.kde.org, see other modules for examples. INLINE COMMENTS > ECMSourceVersionControl.cmake:61 > + >

D25312: Document configuration file path on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R289:61cc70fd3cff: Document configuration file path on Android (authored by jbbgameich). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25312?vs=69768=69801

D25244: Implement ISpellChecker backend for Windows >= 8

mludwig added a comment. In D25244#562817 , @cullmann wrote: > Some feedback? > Else I would just try that. > For me it worked fine (obviously). I will try it out over the weekend. It's something I planned to work on myself, but

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

sitter added a comment. some style complaints. Looks great other than that  INLINE COMMENTS > krun.cpp:583 > +const QUrl url = urls[i]; > +if (KIO::DesktopExecParser::isProtocolInSupportedList(url, > appSupportedProtocols)) > +continue; Coding style

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

ahiemstra added inline comments. INLINE COMMENTS > sortfiltermodel.h:63 > + */ > +Q_PROPERTY(QString filterRole READ filterRole WRITE setFilterRole) > + This (and sortRole below) hides the properties from QSortFilterProxy with the same name. Maybe it is a better idea to use

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson edited the summary of this revision. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25326 To: davidedmundson Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

mart added a comment. +1: i found myself many times wanting to use this but not being able because of plasma dep. the code is used a lot in plasmoids and seems quite robust REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25326 To: davidedmundson Cc: mart,

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY It exposes QSFPM in a usable way from QML, but also exposes a way to perform JS callbacks as an

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

kossebau added a comment. Also am I wonfering how this relates to the bug report you referred to? Can you tell what effect your code change has on the symptoms reported in https://bugs.kde.org/show_bug.cgi?id=409380#c0 ? REPOSITORY R320 KIO Extras REVISION DETAIL

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

kossebau added a comment. Thanks for looking at the issue. No time to look closer the next days, but curious about this partial change (which has been discussed before and discarded): changing `QColor ( 245, 245, 245 ); // light-grey background ` to

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 60 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/60/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 15 Nov 2019 11:02:45 + Build duration: 8 min 22 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemmodels » kf5-qt5 WindowsMSVCQt5.13 - Build # 25 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.13/25/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 15 Nov 2019 11:02:45 + Build duration: 8 min 6 sec and counting JUnit Tests

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/34/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 15 Nov 2019 11:02:44 + Build duration: 3 min 34 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 37 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/37/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 15 Nov 2019 11:02:44 + Build duration: 2 min 55 sec and counting BUILD ARTIFACTS

D25313: Add autotest for QML KConcatenateRowsProxyModel

This revision was automatically updated to reflect the committed changes. Closed by commit R275:a820a2800f03: Add autotest for QML KConcatenateRowsProxyModel (authored by davidedmundson). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25313?vs=69773=69796

D20766: Use appropriate background color for text previews

meven added a comment. I have opened https://phabricator.kde.org/D25323 to fix the missing highlighting in kio-extras. REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau, cfeck Cc: dhaumann, cullmann, vkrause, cfeck, meven, broulik, kde-frameworks-devel,

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

meven created this revision. meven added reviewers: kossebau, cullmann, vkrause. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY By default KSyntaxHighlighter does not highlight text

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 69788. feverfew added a comment. - Align arguments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=69774=69788 BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D23384 AFFECTED FILES

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann added a comment. Some feedback? Else I would just try that. For me it worked fine (obviously). REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25296: [RFC] Fix Display Configuration icon margins

ndavis added inline comments. INLINE COMMENTS > preferences.svg:4 > +.ColorScheme-Text { > color:#7B7C7E; >} Wrong default colors. Just replace the whole stylesheet with this one:

D25296: [RFC] Fix Display Configuration icon margins

ndavis added a comment. It's blurry in your screenshot because you're scaling a 22px icon up to 32px. The solution is to make a 32px version named `32-32-preferences-desktop-display-randr`. BTW, the icon is not actually aligned with the grid. It's a little off here and there. You should be

D25311: Add KColumnHeadersProxyModel

vkrause added a comment. I'm wondering if this is technically a proxy model, or rather a QAbstractListModel? Its content is not representing cells in the source model after all, which mapTo/FromSource assumes I think. It works in the example as you implement the entire QAIM interface needed