D27597: KRunner: Refactor deprecated toSet() method

ahmadsamir added a comment. Hi there. Since KF5 min. supported Qt version is 5.12, you have to make the code conditional so that it still build on Qt < 5.14. (Qt 5.14 is where range-iterators-based constructors were introduced to Qt containers including QList

D27451: Drop KToolInvocation support from KRun::runService

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27451 To: davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27288: [policy-gen] Fix the code to actually use the correct capture group

This revision was automatically updated to reflect the committed changes. Closed by commit R283:f6020e857424: [policy-gen] Fix the code to actually use the correct capture group (authored by ahmadsamir). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE

D27288: [policy-gen] Fix the code to actually use the correct capture group

ahmadsamir updated this revision to Diff 75459. ahmadsamir retitled this revision from "[policy-gen] Fix the code to actually captured the correct capture group" to "[policy-gen] Fix the code to actually use the correct capture group". ahmadsamir added a comment. Fix commit message

D27288: [policy-gen] Fix the code to actually captured the correct capture group

ahmadsamir updated this revision to Diff 75458. ahmadsamir added a comment. Follow naming convention, KAuth REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27288?vs=75451=75458 BRANCH l-policy-gen (branched from master) REVISION DETAIL

D27288: [policy-gen] Fix the code to actually captured the correct capture group

ahmadsamir updated this revision to Diff 75451. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Add a simple/crude unit test REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE

D27269: Use ecm_qt_install_logging_categories over manual categories file

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27269 To: kossebau, #build_system, #frameworks, broulik, mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27268: Fixed handling of relative paths by KUrlNavigator

ahmadsamir added reviewers: dfaure, elvisangelaccio. ahmadsamir added a comment. I am curious, why would you remove the already present part of the path? when I make the url navigator editable the text cursor is already at the end of the path, so I can just start typing the name of a

D27288: [policy-gen] Fix the code to actually captured the correct capture group

ahmadsamir edited the test plan for this revision. ahmadsamir added a reviewer: apol. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D27288 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26118#608935 , @broulik wrote: > This appears to have broken policy file generation. The polkit files I now get have > > Neues Plymouth-Design installieren > > > Note the "Name" in the `xml:lang`

D27288: [policy-gen] Fix the code to actually captured the correct capture group

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This was a mistake in porting form QRegExp::capturedTexts() to QRegularExpression; capturedTexts(1) translates

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

ahmadsamir requested review of this revision. ahmadsamir added a comment. krununittest fails to pass, I tried to debug it but can't get it to work. Disabling the third row "QTest::newRow("tempfile") << true << false;" in KRunUnitTest::KRunRunService_data, makes it pass... I can't figure it

D26468: Tests: don't build benchmark test by default

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26468 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27157: [KConfigLoader] Code cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R237:9dec6961b3ae: [KConfigLoader] Code cleanup (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27157?vs=75029=75210 REVISION DETAIL

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

ahmadsamir planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27216 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY When a process that KRun tried to run fails to launch: - Tell the user when the executable could not be found

D27148: update d->m_file in ReadOnlyPart::setUrl()

ahmadsamir added a comment. I thought of making ReadOnlyPart::setUrl() set d->m_file if the url is a local file... but I am guessing d->m_file and d->m_url are kept separate on purpose, so the idea seemed a bit off. REPOSITORY R306 KParts REVISION DETAIL

D27148: update d->m_file in ReadOnlyPart::setUrl()

ahmadsamir added a comment. IIUC, this diff is fixing https://bugs.kde.org/show_bug.cgi?id=416989 (Konqueror -> Tools -> open terminal, doesn't work after D26140 ). Looking at the code in dolphin/src/dolphinpart.cpp, openUrl() is reimplemented[1],

D27157: [KConfigLoader] Code cleanup

ahmadsamir updated this revision to Diff 75029. ahmadsamir added a comment. Tweak commit message REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27157?vs=75008=75029 BRANCH l-configloader (branched from master) REVISION DETAIL

D27158: Fix some compiler warnings

ahmadsamir updated this revision to Diff 75028. ahmadsamir added a comment. Add missing space after , REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27158?vs=75009=75028 BRANCH l-compiler-warnings (branched from master) REVISION DETAIL

D27158: Fix some compiler warnings

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Fix order of member initialisation (compiling with -Wreorder) - Use Q_UNUSED where needed -

D27157: [KConfigLoader] Code cleanup

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Drop redundant args to startElement()/endEelement() - Use range-for - Drop ConfigLoaderHandler methods

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir updated this revision to Diff 74893. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24951?vs=68769=74893 BRANCH arcpatch-D24951 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24951

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:efa5438e39bb: [KOpenWithDialog] Automatically select the result if the model filter has only… (authored by

D27112: Fix errors in the QRegularExpression porting commit

ahmadsamir added a comment. I'll try and add some unit tests to catch those issues... REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D27112 To: ahmadsamir, #frameworks, drosca, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27112: Fix errors in the QRegularExpression porting commit

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, drosca, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Properties::parse(): - The regex is case sensitive - Fix copy/paste error, it's just one

D27097: Port from QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 74871. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Add test plan section REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27097?vs=74850=74871 BRANCH l-qregularexpression

D27097: Port from QRegExp to QRegularExpression

ahmadsamir added a comment. A couple of notes: - "Incremental" search isn't used by anything in KDE, AFAICS from lxr.kde.org, remove it (in a separate diff)? - Nothing in KDE uses the static KFind::find(... QRegExp..) directly; should we make the new one that takes a

D27097: Port from QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mlaurent, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::setMinimal() by making the regex pattern non-greedy, where possible. Deprecate the

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, kfunk Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh,

D23457: Port the search interface from QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 74387. ahmadsamir added a comment. - Rebase - Match the old code and check if the pattern is empty, this lets the vimode_emulatedcommandbar unit test pass REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D26101: Port away from Qt 5.14 deprecated QList methods

ahmadsamir added a comment. FTR, a recent discussion on #kde-devel on Freenode, which involved QSet and toSet(), made me understand why the original code was using toSet(), then fromSet(), it was to remove duplicates as QSet doesn't allow duplicates. REPOSITORY R293 Baloo REVISION DETAIL

D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0d2959c96b6b: Fix QRegularExpression::wildcardToRegularExpression() usage (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

ahmadsamir updated this revision to Diff 73991. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26692?vs=73650=73991 BRANCH l-qregularexpression-too-wildcard (branched from master) REVISION DETAIL

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73989. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Rebase and tweak the commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73796=73989 BRANCH l-qregexp-deprecate

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R241:df383663d14e: [KCoreDirLister] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73989=73990

D26786: Port away from deprecated QList::toSet() method

This revision was automatically updated to reflect the committed changes. Closed by commit R286:c36ecf9c474a: Port away from deprecated QList::toSet() method (authored by ahmadsamir). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26786?vs=73926=73986

D26786: Port away from deprecated QList::toSet() method

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, apol, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: Baloo. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R286 KFileMetaData BRANCH l-toset (branched from

D26759: [Solid] Port away from deprecated QList methods

This revision was automatically updated to reflect the committed changes. Closed by commit R245:4b3f108b1809: [Solid] Port away from deprecated QList methods (authored by ahmadsamir). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26759?vs=73855=73857 REVISION

D26759: [Solid] Port away from deprecated QList methods

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R245 Solid BRANCH l-toset (branched from master) REVISION DETAIL

D26734: Revert readEntryList() to use QRegExp::Wildcard

This revision was automatically updated to reflect the committed changes. Closed by commit R311:02ab54ea6fe8: Revert readEntryList() to use QRegExp::Wildcard (authored by ahmadsamir). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26734?vs=73808=73828

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir added a comment. In D26734#596420 , @dfaure wrote: > Any longer terms plan for porting away from QRegExp then? > > Or is it arguably a bug in QRegularExpression that is assumes globbing is only used for files? Qt upstream

D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one

ahmadsamir added a comment. FRT, there's only one usage of perlSplit(QChar...), https://lxr.kde.org/source/kde/kdemultimedia/libkcddb/libkcddb/cdinfo.cpp#0313 nothing else uses any of the perlSplit() functions. REPOSITORY R244 KCoreAddons REVISION DETAIL

D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one

This revision was automatically updated to reflect the committed changes. Closed by commit R244:aa908f7b2006: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp… (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir updated this revision to Diff 73808. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Tweak commit message REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26734?vs=73786=73808 BRANCH l-fix (branched from master)

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73796. ahmadsamir added a comment. - Don't use anchoredPattern() with wilcardToRegularExpression() as the latter already returns an anchored pattern - Remove the bit about setNameFilter() from the commit message, wildcardToRegularExpression() should

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir added a comment. See D26205 for details. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D26734 To: ahmadsamir, #frameworks, dfaure, apol Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir updated this revision to Diff 73786. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Tweak commit message and test plan REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir added a comment. Another way to fix the issue, would be to pass an empty QString as the first argument to readEntryList(), in which case readEntryList() returns all the entries, and to change the behaviour of readEntryList to use a full-fledged regex pattern to use instead of

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The issue with QRegularExpression::wildcardToRegularExpression() is that it's more strict in its

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kcoredirlister.cpp:2306 > I think you said this would anchor twice, in another review? Needs to be > fixed then. > > (Good for readability!) Right. (I searched through all the porting commits, I missed this one as it hasn't

D26707: Fix QRegularExpression::wildcardToRegularExpression() usage

This revision was automatically updated to reflect the committed changes. Closed by commit R311:d4980443755f: Fix QRegularExpression::wildcardToRegularExpression() usage (authored by ahmadsamir). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26205#595111 , @blaze wrote: > > otherwise, we could just revert this patch > > The rest of the code is OK. The part that works funny is just the wildcard method, and since it's relatively new, I hope there

D26707: Fix QRegularExpression::wildcardToRegularExpression() usage

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY It turns out that QRegularExpression::wildcardToRegularExpression() returns an anchored (with \A and \z)

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added a comment. INLINE COMMENTS > blaze wrote in kwallet.cpp:180 > > The transformation is targeting file path globbing, which means in > > particular that path separators receive special treatment. > > I'm pretty sure the file path case is different from what we have here. > >

D26693: Fix QRegularExpression::wildcardToRegularExpression() usage

This revision was automatically updated to reflect the committed changes. Closed by commit R495:ce27c7cf1121: Fix QRegularExpression::wildcardToRegularExpression() usage (authored by ahmadsamir). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73676. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Add TODO KF6 notes to remove doNameFilter() and doMimeFilter() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73605=73676

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26205#595034 , @blaze wrote: > https://github.com/KDE/falkon/blob/master/src/plugins/KDEFrameworksIntegration/kwalletpasswordbackend.cpp#L187 > > QMap entries; > if (m_wallet->readEntryList("*", entries)

D26693: Fix QRegularExpression::wildcardToRegularExpression() usage

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY It turns out that QRegularExpression::wildcardToRegularExpression() returns an anchored (with \A and \z)

D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY It turns out that QRegularExpression::wildcardToRegularExpression() returns an anchored (with \A and \z)

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > blaze wrote in kwallet.cpp:179 > QRegularExpression::wildcardToRegularExpression() already returns an anchored > output. What do you mean? I didn't get what you meant before. I've just tested and you're right; I didn't know that

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added a comment. A test case of what is broken would be appreciated, to try and fix/debug the issue. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D26205 To: ahmadsamir, #frameworks, aacid, apol Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2,

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > blaze wrote in kwallet.cpp:179 > anchoredPattern() is excessive here, it creates a horror like that > "\\A(?:\\A(?:[^/]*)\\z)\\z" with the stuff being anchored twice. > It has to be removed with no doubt at all. The pattern has to be anchored

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73605. ahmadsamir added a comment. Add TODO KF6 to doNameFilter() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73530=73605 BRANCH l-qregexp-deprecate (branched from master) REVISION DETAIL

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73530. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73529=73530 BRANCH l-qregexp-deprecate (branched from master)

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > broulik wrote in kcoredirlister.h:595 > This class is exported, you cannot change this existing method and you also > cannot add a new `virtual`, see > https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B Thanks,

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73529. ahmadsamir removed a subscriber: broulik. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73527=73529 BRANCH l-qregexp-deprecate (branched from master) REVISION

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73527. ahmadsamir added a comment. Can't change doNameFilter due to BIC REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73515=73527 BRANCH l-qregexp-deprecate (branched from master) REVISION DETAIL

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added a reviewer: dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY doNameFilter() was the only protected function that took a QRegExp param., but I couldn't find any users of it in KDE. Also

D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This adds a perlSplit() overload that takes a QRegularExpression parameter, and also deprecates the

D26099: Port QRegExp to QRegularExpression

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R293:eec35486c419: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R293 Baloo CHANGES SINCE

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73367. ahmadsamir added a comment. - Rebase\n- Move second match inside if condition, otherwise the control flow never passes through the next else if branch REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D26487: [Kuit] Revert changes in parseUiMarker()

This revision was automatically updated to reflect the committed changes. Closed by commit R249:fff18126b973: [Kuit] Revert changes in parseUiMarker() (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26487?vs=72955=73251 REVISION DETAIL

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

ahmadsamir added inline comments. INLINE COMMENTS > davidedmundson wrote in ksortfilterproxymodel.cpp:101 > I'm not sure your comments are still valid, we switched to using the > superclass QSortFilterProxyModel's methods, and don't shadow that part here. Right, I was looking at an old

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

ahmadsamir added inline comments. INLINE COMMENTS > ksortfilterproxymodel.cpp:101 > +{ > +return QSortFilterProxyModel::filterRegExp().pattern(); > +} In setFilterRegExp(), QSortFilterProxyModel::setFilterRegularExpression(QRegularExpression &) is used, so IIUC here it should be :

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

ahmadsamir added a comment. Hello. Bug 415951 doesn't look related to this diff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26492 To: broulik, #frameworks, ngraham Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26487: [Kuit] Revert changes in parseUiMarker()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This commit partially reverts a9f4cbdda790c3962

D26453: [Purpose] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R495:8dc165f088f3: [Purpose] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26453?vs=72856=72949

D26194: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R308:7b356e9dd1ad: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26194?vs=72946=72947 REVISION DETAIL

D26194: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72946. ahmadsamir added a comment. Rebase REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26194?vs=72116=72946 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. In D26366#589229 , @dfaure wrote: > So, the old way was 76 times faster than the new regexp :-) > > I'm not surprised, though, it's consistent with my experience with regexps. > > This might be a good reason to

D26470: [Solid] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R245:11ec991bd14b: [Solid] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26470?vs=72894=72903 REVISION

D26470: [Solid] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern(). TEST PLAN make && ctest

D26461: [networkmanager-qt] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R282:7627f64e0103: [networkmanager-qt] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D26461: [networkmanager-qt] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, jgrulich, dfaure. Herald added a project: Frameworks. Herald added 1 blocking reviewer(s): jgrulich. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R282 NetworkManagerQt BRANCH

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. In D26366#588416 , @dfaure wrote: > Benchmarking is complex ;) > > 1. you need to make sure both Qt and your benchmark are built with optimizations enabled (-O2) > 2. you need to actually use those 3 variables

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. In D26366#588416 , @dfaure wrote: > Benchmarking is complex ;) > > 1. you need to make sure both Qt and your benchmark are built with optimizations enabled (-O2) > 2. you need to actually use those 3 variables

D26453: [Purpose] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY QRegExp::exactMatch -> QRegularExpression::anchoredPattern() QRegExp::Wildcard ->

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. I hacked up some (rather crude, to say the least) benchmarking: void KLocalizedStringTest::benchmarkRegexSimple() { QString roleName, cueName, formatName; QString context = QStringLiteral("@info:tooltip/plaintext"); QBENCHMARK

D26429: [KCompletion] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R284:846f686dfe5b: [KCompletion] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26429?vs=72777=72786

D26194: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D26194 To: ahmadsamir, #plasma, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24793: [Konqueror] Remove KonqView::setActiveComponent()

This revision was automatically updated to reflect the committed changes. Closed by commit R226:fefbc0ce295c: [Konqueror] Remove KonqView::setActiveComponent() (authored by ahmadsamir). REPOSITORY R226 Konqueror CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24793?vs=72782=72783

D24793: [Konqueror] Remove KonqView::setActiveComponent()

ahmadsamir updated this revision to Diff 72782. ahmadsamir added a comment. Rebase REPOSITORY R226 Konqueror CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24793?vs=68322=72782 BRANCH ahmad/setactiveComponent (branched from master) REVISION DETAIL

D26136: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R265:05ea3d2926e7: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72780=72781 REVISION

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72780. ahmadsamir added a comment. Rebase REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72083=72780 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26099: Port QRegExp to QRegularExpression

ahmadsamir added reviewers: apol, dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent, apol, dfaure Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D26177: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R237:2055025c0c79: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26177?vs=72138=72779 REVISION DETAIL

D26429: [KCompletion] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This was pretty trivial. TEST PLAN make && ctest and klineedittest still works. REPOSITORY R284

D26412: [Kuit] Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26412#587395 , @dfaure wrote: > Unittest for this method added in https://commits.kde.org/ki18n/a92305a4c15ac361417eeb7b933682960c7545e1 > Please check your change passes the test. > Extend as needed if you

D26412: [Kuit] Port QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26412 To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

<    1   2   3   4   5   6   7   8   9   10   >