D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado
aleksanderm updated this revision to Diff 61582. aleksanderm added a comment. Renamed methods and made the getter const. REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22395?vs=61580=61582 BRANCH aleksander/dbus-timeout REVISION DETAIL

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado
aleksanderm added a comment. F7006291: test.cpp attaching a tester program to exercise the new API in one of the interfaces. REPOSITORY R281 ModemManagerQt REVISION DETAIL https://phabricator.kde.org/D22395 To: aleksanderm, #frameworks, jgrulich,

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado
aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added 1 blocking reviewer(s): jgrulich. aleksanderm requested review of this revision. REVISION SUMMARY Some

D20238: device: include reapplyConnection() in the interface

2019-04-04 Thread Aleksander Morgado
aleksanderm marked an inline comment as done. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D20238 To: aleksanderm, jgrulich, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include reapplyConnection() in the interface

2019-04-04 Thread Aleksander Morgado
aleksanderm updated this revision to Diff 55395. aleksanderm retitled this revision from "device: include Reapply() in the interface" to "device: include reapplyConnection() in the interface". REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D20238: device: include Reapply() in the interface

2019-04-03 Thread Aleksander Morgado
aleksanderm updated this revision to Diff 55379. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20238?vs=55377=55379 REVISION DETAIL https://phabricator.kde.org/D20238 AFFECTED FILES src/device.cpp src/device.h To: aleksanderm, jgrulich,

D20238: device: include Reapply() in the interface

2019-04-03 Thread Aleksander Morgado
aleksanderm created this revision. aleksanderm added reviewers: jgrulich, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added 1 blocking reviewer(s): jgrulich. aleksanderm requested review of this revision. REVISION SUMMARY The

D13117: Don't set custom domain filter rules

2018-06-11 Thread Aleksander Morgado
aleksanderm added a comment. Any ETA to land this change? REPOSITORY R281 ModemManagerQt BRANCH fix-logging REVISION DETAIL https://phabricator.kde.org/D13117 To: aleksanderm, jgrulich, broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13482: Implement support for the Voice and Call interfaces

2018-06-11 Thread Aleksander Morgado
aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich. aleksanderm added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. aleksanderm requested review of this revision. REVISION SUMMARY The Voice and Call interfaces were

D13117: Don't set custom domain filter rules

2018-05-25 Thread Aleksander Morgado
aleksanderm added a reviewer: Frameworks. REPOSITORY R281 ModemManagerQt REVISION DETAIL https://phabricator.kde.org/D13117 To: aleksanderm, jgrulich, broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13117: Don't set custom domain filter rules

2018-05-25 Thread Aleksander Morgado
aleksanderm created this revision. aleksanderm added reviewers: jgrulich, broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. aleksanderm requested review of this revision. REVISION SUMMARY The library shouldn't set

D11320: Fix QVariantMapList operator >> implementation

2018-03-15 Thread Aleksander Morgado
aleksanderm added a comment. In D11320#225486 , @broulik wrote: > Is that custom marshaller even neccessary? I thought Qt could resolve QList and QVariantMap (even nested) automatically? Can you try just removing that entire thing?

D11353: manager: add support to R/W the GlobalDnsConfiguration property

2018-03-15 Thread Aleksander Morgado
aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich. aleksanderm added a project: Frameworks. aleksanderm requested review of this revision. REPOSITORY R282 NetworkManagerQt BRANCH globaldnsconfiguration REVISION DETAIL https://phabricator.kde.org/D11353

D11320: Fix QVariantMapList operator >> implementation

2018-03-14 Thread Aleksander Morgado
aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich. Restricted Application added a project: Frameworks. aleksanderm requested review of this revision. REVISION SUMMARY Thread 1 "united-airlion" received signal SIGSEGV, Segmentation fault.

D10366: cmake: don't flag libnm-util as found when ModemManager is found

2018-02-07 Thread Aleksander Morgado
aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich. Restricted Application added a project: Frameworks. aleksanderm requested review of this revision. REVISION SUMMARY Looks like a leftover from when this file was imported from NM. libnm-util has nothing to

D10309: device: define StateChangeReason and MeteredStatus as Q_ENUMs

2018-02-04 Thread Aleksander Morgado
aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich. Restricted Application added a project: Frameworks. aleksanderm requested review of this revision. REVISION SUMMARY So that e.g. users of the library can easily print them as strings. REPOSITORY R282