marked as submitted.
Review request for KDE Frameworks and Olivier Churlaud.
Changes
---
Submitted with commit c10f62202065b4b760764882689fee00b4f35d75 by Daniel Vrátil
to branch master.
Repository: kapidox
Description
---
We have some a few repositories called "akonadi-some
apidox_generate - the library is listed as "Akonadi Calendar" in the
Library list table
2) Ran kapidox_generate on akonadi-contacts.git without adding `fancyname` to
metainfo.yaml, the library was correctly listed as "Akonadi-Contacts".
Thanks,
Daniel Vrátil
__
rc/krearrangecolumnsproxymodel.cpp 72e4f14
Diff: https://git.reviewboard.kde.org/r/128575/diff/
Testing
---
Triggered by Kleopatra on start, no more assert with this patch.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-fra
-
>
> (Updated Aug. 2, 2016, 2:39 p.m.)
>
>
> Review request for KDE Frameworks and Daniel Vrátil.
>
>
> Repository: kitemmodels
>
>
> Description
> ---
>
> KRearrangeColumnsProxyModel: fix assert in index(0, 0) on empty model
>
>
>
n automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128575/#review97996
---
On Aug. 2, 2016, 2:14 p.m., Daniel Vrátil wrote:
>
> ---
> This is an
/128575/diff/
Testing
---
Triggered by Kleopatra on start, no more assert with this patch.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
__
> > Kde-frameworks-devel mailing list
> > Kde-frameworks-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
> _______
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailm
cker). Any
ideas what's going on there? Is it a problem on the CI side, our side or maybe
something in sycoca?
Thanks
Dan
[0] https://build.kde.org/view/KDE-PIM/job/kblog
%20Applications-16.04%20stable-kf5-qt5/7/PLATFORM=Linux,compiler=gcc/
testReport/junit/%28root%29/TestSuite/kblog_testblogger1/
--
On 2016-04-03 15:28, Scarlett Clark wrote:
On Sun, Apr 3, 2016 at 5:16 AM, Daniel Vrátil <dvra...@kde.org>
wrote:
On Sunday, April 3, 2016 12:58:24 PM CEST David Faure wrote:
On Sunday 03 April 2016 12:43:27 Daniel Vrátil wrote:
Turns out when you include /usr/share in XDG_DATA_DIR
On Sunday, April 3, 2016 12:58:24 PM CEST David Faure wrote:
> On Sunday 03 April 2016 12:43:27 Daniel Vrátil wrote:
> > Turns out when you include /usr/share in XDG_DATA_DIRS, all mime types
> > that
> > might have been provided by other dependencies in
> > /srv/jenk
ve all of the frameworks
> > anymore. Would sometime have the time to go through the list and check
> > what else is missing?
> Cheers,
> Ben
>
> > --
> > David Faure, fa...@kde.org, http://www.davidfaure.fr
> > Working on KDE Frameworks 5
>
> ________
/r/127091/diff/
Testing
---
I can see sni-qt apps icons in Plasma systray again.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-
src/declarativeimports/core/iconitem.cpp 1d7921a
Diff: https://git.reviewboard.kde.org/r/127091/diff/
Testing
---
I can see sni-qt apps icons in Plasma systray again.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks
--
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)
GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683
signature.asc
Description: This is a digitally signed message part
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126630/#review90715
---
Ship it!
Ship It!
- Daniel Vrátil
On Jan. 5, 2016, 1:08
g/r/126630/#comment61957>
Keep this one, fake backend is only for unit-tests.
- Daniel Vrátil
On Jan. 5, 2016, 12:27 p.m., Peter Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
committing. Thanks!
src/kcodecs.cpp (line 721)
<https://git.reviewboard.kde.org/r/126481/#comment61730>
Move the "else {" to this line.
- Daniel Vrátil
On Dec. 23, 2015, 3:50 a.m., Michael Pyne wrote:
>
> ---
>
nitpicks, I think it's time to
merge this :)
Thanks a lot for you work, you rock!
- Daniel Vrátil
On Dec. 21, 2015, 1:59 p.m., Sebastian Kügler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
nd deep
copy, use Q_FOREACH instead.
tests/kwayland/waylandtestserver.cpp (line 105)
<https://git.reviewboard.kde.org/r/126381/#comment61506>
Q_FOREACH
tests/kwayland/waylandtestserver.cpp (line 156)
<https://git.reviewboard.kde.org/r/126381/#comment61504>
Q_FOREACH
- Da
kde.org/r/126381/#comment61360>
const&
tests/kwayland/waylandconfigreader.cpp (lines 98 - 102)
<https://git.reviewboard.kde.org/r/126381/#comment61362>
Use initializer list
- Daniel Vrátil
On Dec. 16, 2015, 3:05 a.m., Sebastian Kügler wrote:
>
>
> -------
>
> (Updated Dec. 16, 2015, 3:05 a.m.)
>
>
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
>
>
> Repository: libkscreen
>
>
> Description
> ---
>
> This
Frameworks release soon)?
> Apart from anything else, moving previously-released stuff into the KF5
> namespace when they join Frameworks will probably help packagers.
>
> Alex
> ___
> KDE PIM mailing list kde-...@kde.org
> https://mail.kd
Frameworks.
Andre is the current maintainer of GpgME++, he might new what the current
situation is.
Cheers,
Dan
>
> R.
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kd
the plugin binary from the
process (just deleting QPluginLoader does not).
src/setconfigoperation.cpp (line 58)
<https://git.reviewboard.kde.org/r/126101/#comment60758>
Remove
- Daniel Vrátil
On Nov. 20, 2015, 1:16 a.m., Sebastian Kügler wrote:
>
>
ading
based on current env variables.
src/configoperation_p.h (line 43)
<https://git.reviewboard.kde.org/r/126101/#comment60687>
Maybe we don't even need to store it? Looking at the implementation in both
Operations, it might just fine if loadBackend() returned the backend pointer...
- Daniel Vrá
/ktextedit.cpp f549825
Diff: https://git.reviewboard.kde.org/r/125532/diff/
Testing
---
Switched KNoteEditor in KNotes in KDE PIM (which uses
PimCommon::CustomTextEditor) to use this patched KTextEdit, everything works as
before.
Thanks,
Daniel Vrátil
> On Oct. 9, 2015, 2:21 p.m., Daniel Vrátil wrote:
> > kf5/convert-kabc-to-kcontacts.pl, line 78
> > <https://git.reviewboard.kde.org/r/125570/diff/1/?file=410354#file410354line78>
> >
> > This will still break build (as expected):
&g
better to keep the deprecated classes references in the
code to make porting easier and to avoid unnecessary porting mistakes.
- Daniel Vrátil
On Oct. 9, 2015, 2:09 p.m., R.Harish Navnit wrote:
>
> ---
> This is an automatically ge
, everything works as
before.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
lid is closed/opened.
Thanks,
Daniel Vrátil
___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
, but that I don't know how to solve.
Dan
Cheers,
Thomas
--
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)
GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683
signature.asc
Description
and the amount of
developers (3), bugs often take more than a year to get to and to be fixed.
I think this would make a lot of time consuming bug triaging much easier.
Cannot agree more :)
Cheers,
Daniel
Greetings
Christoph
--
Daniel Vrátil
Email: dvra...@kde.org
Jabber: dan.vra...@kdetalk.net
`
instance pointer as an argument.
Diffs
-
src/runtime/kwalletd/migrationagent.cpp a2a6498
Diff: https://git.reviewboard.kde.org/r/124372/diff/
Testing
---
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
functionality are you planning
and what's the general usecase for your OSD? We could then discuss how to
implement it in a way that will be possible to merge into main branches and
get into releases?
Cheers,
Daniel
--
Daniel Vrátil
Email: dvra...@kde.org
Jabber: dan.vra...@kdetalk.net
IRC: dvratil
Cheers,
Daniel
Regards,
Leslie Zhai - a KDE developer
--
Daniel Vrátil
Email: dvra...@kde.org
Jabber: dan.vra...@kdetalk.net
IRC: dvratil on Freenode (#kde, #kontact, #akonadi)
___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
On Friday, July 24, 2015 10:24:10 AM laurent Montel wrote:
Le Friday 24 July 2015, 00:13:48 Albert Astals Cid a écrit :
El Dimarts, 21 de juliol de 2015, a les 13:52:01, Daniel Vrátil va
escriure:
On Monday, July 20, 2015 04:17:16 PM Daniel Vrátil wrote:
Hi all,
we (the KDE PIM
On Monday, July 20, 2015 04:17:16 PM Daniel Vrátil wrote:
Hi all,
we (the KDE PIM team) kinda screwed up when we forgot to communicate our
intentions about
next KDE PIM release with the release team and we ended up in a
situation that we have
some repositories in modules from which
in during the years :)
I'd like to move both repositories to kde/pim module where other KDE PIM
repos (mostly those
split from kdepimlibs) currently live.
If that's fine with everyone I'd request the move ASAP.
Cheers,
Daniel
--
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil
On 20.07.2015 16:44, Martin Sandsmark wrote:
On Mon, Jul 20, 2015 at 04:17:16PM +0200, Daniel Vrátil wrote:
We only ported the code to KF5
Unless I'm misunderstanding something, isn't this a quite significant
change?
From experience even seemingly simple ports can introduce pretty
serious
---
On July 16, 2015, 1:38 p.m., Daniel Vrátil wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124371
;-),
this patch makes the `invokeAndCheck()` template to take the `MigrationAgent`
instance pointer as an argument.
Diffs
-
src/runtime/kwalletd/migrationagent.cpp a2a6498
Diff: https://git.reviewboard.kde.org/r/124372/diff/
Testing
---
Thanks,
Daniel Vrátil
discovered this in Fedora, because we ship our own ugly LnF package, and we
renamed it at some point, which caused KDED to go nuts.
Diffs
-
src/platformstatus/platformstatus.cpp e03c16d
Diff: https://git.reviewboard.kde.org/r/124371/diff/
Testing
---
Thanks,
Daniel Vrátil
On Tuesday, May 19, 2015 03:32:03 PM Albert Astals Cid wrote:
El Dimarts, 19 de maig de 2015, a les 11:17:09, Daniel Vrátil va escriure:
On Monday, May 18, 2015 07:32:54 PM Robby Stephenson wrote:
Hi,
In the process of porting Tellico to KF5, one of my unit tests that
depends
Hi,
I'm trying to get kdepim to build on the OSX CI, but this one is beyond me.
Hopefully someone more knowledgable of the OSX build system might help.
The build is currently failing with following error:
00:28:09.901 Undefined symbols for architecture x86_64:
00:28:09.902
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123860/#review80661
---
Ship it!
Ship It!
- Daniel Vrátil
On May 20, 2015, 2:36
-
src/kcodecsbase64.cpp fc03262
Diff: https://git.reviewboard.kde.org/r/123861/diff/
Testing
---
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Monday, May 18, 2015 07:32:54 PM Robby Stephenson wrote:
Hi,
In the process of porting Tellico to KF5, one of my unit tests that
depends on KCodecs::base64Encode() started to fail. After poking at it a
little bit, my impression is that KF5::KCodecs is including a newline at
the end of
---
On May 14, 2015, 1:48 p.m., Daniel Vrátil wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123791
email in KMail and it correctly used the new theme.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
Switching between emails in KMail is faster now (even more noticable when the
system is under load).
Switched to another emoticon theme in System Settings, then opened another
email in KMail and it correctly used the new theme.
Thanks,
Daniel Vrátil
is under load).
Switched to another emoticon theme in System Settings, then opened another
email in KMail and it correctly used the new theme.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
Hi,
commit a5f6c247d99db3a3f565f5fa8d1346420e5a892c (frameworksintegration tests
want oxygen-fonts) in kde-build-metadata has introduced a circular dependency
between frameworkintegration and oxygen, leading to
$ kdesrc-build --refresh-build kf5 plasma5
* Downloading projects.kde.org project
by Akregator.
I would like to submit KF5Syndication for the standard 2 week review
period, and if everything is OK, then move it to Frameworks.
Cheers,
Daniel
--
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde
On Wednesday, April 22, 2015 10:51:15 PM Mark Gaiser wrote:
On Wed, Apr 22, 2015 at 9:44 PM, Daniel Vrátil dvra...@kde.org wrote:
Hi all,
I'd like to ask for review of another Framework from kdepimlibs:
KF5Syndication
KF5Syndication is an RSS/Atom parsing library. It also provides
it. If Akregator ever gets ported to Akonadi :), then the retrieval will be
handled by the resource and other applications using Syndication will probably
prefer their own retrieval methods and can always fall back to just calling
KIO::get themselves.
Dan
Frank
--
Daniel Vrátil
www.dvratil.cz | dvra
home page at http://pim.kde.org/
--
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
On Tuesday, April 14, 2015 12:17:39 AM Albert Astals Cid wrote:
El Diumenge, 12 d'abril de 2015, a les 11:31:26, Daniel Vrátil va escriure:
Greetings from Toulouse!
Instead we will aim towards releasing KF5-based KDE PIM with Akonadi 1
in
the next release of KDE Applications in August
On Sunday, April 12, 2015 09:57:54 AM Marko Käning wrote:
Hi Daniel,
On 12 Apr 2015, at 09:50 , Daniel Vrátil dvra...@kde.org wrote:
it's referring to a file in kdepim-runtime.git/resources (where Knut
originally was before it was moved to kdepimlibs auto tests).
I see.
I don't
from other PIM devs who are not here in
Toulouse. If everyone is fine with this proposal, we will put this plan to
work as soon as possible.
Regards,
Daniel
--
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)
GPG Key
from other PIM devs who are not here in
Toulouse. If everyone is fine with this proposal, we will put this plan to
work as soon as possible.
Regards,
Daniel
--
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)
GPG Key
/listinfo/kde-frameworks-devel
--
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)
GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683
signature.asc
Description: This is a digitally signed
:)
Regards,
Jan
--
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)
GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683
signature.asc
Description: This is a digitally signed message part
On Friday, January 30, 2015 09:12:01 AM David Faure wrote:
On Wednesday 28 January 2015 17:12:04 Daniel Vrátil wrote:
I guess I should update kde-build-metadata and release-tools and ask for
the _stable_qt5 build once the repo is moved to frameworks on
projects.k.o, so that changes don't
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122383/#review75906
---
Ship it!
KXmlRpcClient is a framework now!
- Daniel Vrátil
only when the
`result` value returned from KPluginMetaData is also a string.
Diffs
-
src/services/kplugininfo.cpp 572f14b
Diff: https://git.reviewboard.kde.org/r/122541/diff/
Testing
---
KDevelop can load plugins again.
Thanks,
Daniel Vrátil
can load plugins again.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Monday, January 26, 2015 08:15:14 PM Albert Astals Cid wrote:
El Dilluns, 26 de gener de 2015, a les 15:25:34, Daniel Vrátil va escriure:
On Thursday, January 08, 2015 06:08:00 PM Daniel Vrátil wrote:
Hi all,
KXmlRpcClient provides a complete XMLRPC client for applications to use
On Wednesday, January 28, 2015 04:17:53 PM David Faure wrote:
On Monday 26 January 2015 15:25:34 Daniel Vrátil wrote:
Bump.
We would really love to get this to 5.7, so unless anyone objects, I'll
wait couple days, then file a sysadmin request and flip the 'Release'
flag
in the YAML
On Thursday, January 08, 2015 06:08:00 PM Daniel Vrátil wrote:
Hi all,
KXmlRpcClient provides a complete XMLRPC client for applications to use.
It's used most notably by DrKonqi to talk to b.k.o. It's the first
framework split from kdepimlibs that we feel is ready to be shipped with
KDE
to invoke the helper tool
(because of the broken service file), the ExecJob got simply stuck. This was
only fixed be rebuilding PowerDevil against the fixed KAuth...
- Daniel Vrátil
On Jan. 19, 2015, 4:46 p.m., Hrvoje Senjan wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122048/#review73999
---
+1, looks good to me
- Daniel Vrátil
On Jan. 14, 2015, 12
against KAuth with this fix, PowerDevil KDED module
fully initialized and plasma-nm auth dialog works again.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
works again.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
On Jan. 8, 2015, 1:04 p.m., Daniel Vrátil wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121915
d51ab19
Diff: https://git.reviewboard.kde.org/r/121915/diff/
Testing
---
Tested with qdbus-monitor, signal is emitted when laptop lid is closed/opened.
Thanks,
Daniel Vrátil
___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https
finally
drop the bundled copy from DrKonqi ;-)).
Cheers,
Daniel
--
Daniel Vrátil | dvra...@redhat.com | dvratil on #kde-devel, #kontact, #akonadi
Software Engineer - KDE Desktop Team, Red Hat Inc.
GPG Key: 0xC59D614F6F4AE348
Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348
:-) Is there a
plan to move it to Tier 3, or remove the dependency? Sorry if this was
discussed before.
Cheers,
Dan
--
Daniel Vrátil | dvra...@redhat.com | dvratil on #kde-devel, #kontact, #akonadi
Software Engineer - KDE Desktop Team, Red Hat Inc.
GPG Key: 0xC59D614F6F4AE348
Fingerprint: 4EC1 86E3 C54E 0B39
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121700/#review72777
---
Ship it!
Ship It!
- Daniel Vrátil
On Dec. 27, 2014, 6:43
the same DBus service name, and I don't want to run
multiple backends in one process.
- Daniel Vrátil
On Dec. 28, 2014, 11:33 a.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
--empty
git read-tree --prefix qgpgme/src/ $GIT_COMMIT:qgpgme/src
true
' master --all --tags
___
KDE PIM mailing list kde-...@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--
Daniel Vrátil | dvra
PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121118/diff/
Testing
---
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-CREATION
Diff: https://git.reviewboard.kde.org/r/121094/diff/
Testing
---
Unit test passes
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/121094/diff/
Testing
---
Unit test passes
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
it, we could have renamed KCodecs to KStringUtils and moved
the kcoreaddons text subdir there, but it's too late for that.
So my suggestion would be to add KEmailAddress to kcoreaddons/src/lib/text.
Daniel Vrátil wrote:
There's a small problem with that, because KEmailAddress depends
/CMakeLists.txt 8b5c4a0
src/kemailaddress.h PRE-CREATION
src/kemailaddress.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121175/diff/
Testing
---
Test passes.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde
Diff: https://git.reviewboard.kde.org/r/121094/diff/
Testing
---
Unit test passes
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
- Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121175/#review70816
---
On Nov. 19, 2014, 2:23 p.m., Daniel Vrátil wrote
://git.reviewboard.kde.org/r/121118/diff/
Testing
---
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/#comment49426
The d pointers are actually accessed by implementations, so it has to be
protected.
- Daniel Vrátil
On Nov. 18, 2014, 2:31 p.m., Daniel Vrátil wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/data/codec_x-kmime-rfc2231/basic-encode PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121047/diff/
Testing
---
Builds, all unit-tests pass.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
On Nov. 19, 2014, 1:45 p.m., Daniel Vrátil wrote:
src/kcodecs.h, line 786
https://git.reviewboard.kde.org/r/121047/diff/1-2/?file=327084#file327084line786
The d pointers are actually accessed by implementations, so it has to
be protected.
Blah, this was supposed to be a comment
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121047/#review70616
---
On Nov. 18, 2014, 2:31 p.m., Daniel Vrátil wrote
/121047/diff/
Testing
---
Builds, all unit-tests pass.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-CREATION
Diff: https://git.reviewboard.kde.org/r/121175/diff/
Testing
---
Test passes.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
On Nov. 14, 2014, 1:41 p.m., Daniel Vrátil wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121047
pass.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/lib/text/ktexttohtml.cpp PRE-CREATION
src/lib/text/ktexttohtml_p.h PRE-CREATION
src/lib/text/ktexttohtmlemoticonsinterface.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121094/diff/
Testing
---
Unit test passes
Thanks,
Daniel Vrátil
://git.reviewboard.kde.org/r/120155/diff/
Testing
---
QIcon icon = QIcon::fromTheme(QLatin1String(process-working));
QPixmap pix = icon.pixmap(22, 8 * 22);
With this patch, the pix looks as expected.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde
://git.reviewboard.kde.org/r/121095/diff/
Testing
---
Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems
to work.
Thanks,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
,
Daniel Vrátil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
101 - 200 of 228 matches
Mail list logo
