D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. In D7909#346328 , @cullmann wrote: > Ping? ;=) Hi, I'm still here, I need some more time to get it working well. :) REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar,

D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. In D7909#318737 , @cullmann wrote: > Hi, any update on this? Not yet! :) REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhaumann, vkrause,

D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. In D7909#307484 , @cullmann wrote: > Hi, did you get some time to look at the remaining issues? > If they are fixed, I am happy to merge that. Hi, I haven't fixed the issues yet. I'm working on that, I will

D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. In D7909#242422 , @cullmann wrote: > Ah, I let just the build run once more locally, the current static check says: > > "/local/cullmann/kf5/src/frameworks/syntax-highlighting/data/syntax/crystal.xml" Unused

D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. In D7909#242391 , @cullmann wrote: > The hard-coded colors got removed, test is there, all fine. > Thanks for the contribution! > If you can't push youself, tell me, I will push for you. Great!, This is my

D7909: Add syntax support for Crystal Programming Language

faguilar added inline comments. INLINE COMMENTS > crystal.xml:160 > + > + > + char1="%" context="Find closing macro brace" beginRegion="def block"/> @dhaumann Crystal language supports macros. This macro syntax is a bit different from

D7909: Add syntax support for Crystal Programming Language

faguilar updated this revision to Diff 26743. faguilar added a comment. Restricted Application added a project: Kate. Remove colors from itemData (suggested by @dhaumann) REPOSITORY R40 Kate CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7909?vs=19732=26743 REVISION DETAIL

D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. In https://phabricator.kde.org/D7909#199469, @dhaumann wrote: > Sorry for the late reply. > > Please do the following changes: > > - remove hard-coded colors from itemDatas. This way, your highlighting will look good in all color themes. > > Also,

D7909: Add syntax support for Crystal Programming Language

faguilar added a reviewer: Kate. faguilar added a subscriber: Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate Cc: #kate, #frameworks, faguilar, cullmann, vkrause, dhaumann

D7909: Add syntax support for Crystal Programming Language

faguilar edited the test plan for this revision. faguilar added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting Cc: #frameworks, faguilar,

D7909: Add syntax support for Crystal Programming Language

faguilar updated this revision to Diff 19732. faguilar added a comment. Add Crystal input for autotests REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7909?vs=19730=19732 REVISION DETAIL https://phabricator.kde.org/D7909 AFFECTED FILES

D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. I'm user of Manjaro KDE and I love coding using Kate. Currently I'm focused in Crystal learning using Ruby syntax, however Ruby syntax doesn't support all Crystal features. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7909

D7909: Add syntax support for Crystal Programming Language

faguilar created this revision. faguilar added reviewers: dhaumann, vkrause. faguilar added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This add syntax support the Crystal