Re: Review Request 128065: move glass theme to kde-look.

marked as submitted. Review request for KDE Frameworks and Andreas Kainz. Changes --- Submitted with commit e5363599936edec5ff3f51ed378e1325ea4cd4d1 by Harald Sitter to branch master. Repository: kemoticons Description --- we don't need 300 default themes http://kde-look.org

Re: Review Request 128147: isolate autotests from (installed) production data

://git.reviewboard.kde.org/r/128147/diff/ Testing --- make && test && install => all good Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128065: move glass theme to kde-look.

knewstuff Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128147: isolate autotests from (installed) production data

/tongue.png PRE-CREATION autotests/kemoticontest.cpp fdada9dfdaf9938e48f86face8e60c853ba54da3 autotests/ktexttohtmlplugintest.cpp 9326430f0a4e6545c4507ec9b4dfe64414dd0e4b Diff: https://git.reviewboard.kde.org/r/128147/diff/ Testing --- make && test && install => all goo

Re: Review Request 128114: do not load and debug in the same line

marked as submitted. Review request for KDE Frameworks, Andreas Cord-Landwehr and Jeremy Whiting. Changes --- Submitted with commit 81e2895b40684e275aadc944cdbc2f333a20782f by Harald Sitter to branch master. Repository: knewstuff Description --- if debugging is off the line is no-op

Re: Review Request 128114: do not load and debug in the same line

14/#review96247 --- On June 7, 2016, 8:48 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128114/ > --

Review Request 128115: do not load and debug in the same line

it might make debugging harder if something fails in an isolated testbed (e.g. CI) Diffs - autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d Diff: https://git.reviewboard.kde.org/r/128115/diff/ Testing --- makes && test passes Thanks, Haral

Review Request 128114: do not load and debug in the same line

Diff: https://git.reviewboard.kde.org/r/128114/diff/ Testing --- makes && passes test Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128072: add missing type_traits include making sure std::enable_if is declared

marked as submitted. Review request for KDE Frameworks and Gleb Popov. Changes --- Submitted with commit 8ab7daa8cbd54a51319a9086e3f143ad0559d3ae by Harald Sitter to branch master. Repository: kconfigwidgets Description --- fixes abi compliance test from http://build.neon.kde.org

Re: Review Request 125343: bump so version from 5 to 6

ebd4b8981a658665a42140250b6eb3d92662e607 Diff: https://git.reviewboard.kde.org/r/125343/diff/ Testing --- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128072: add missing type_traits include making sure std::enable_if is declared

&& make test Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128065: move glass theme to kde-look.

128065/#review96078 --- On May 31, 2016, 8:33 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://g

Review Request 128065: move glass theme to kde-look.

/wink.png 166aef1e5675dabd41ce1a868c9f1d53cc494cc2 Diff: https://git.reviewboard.kde.org/r/128065/diff/ Testing --- builds and installs version from kde-look also installs via knewstuff Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list

Re: Review Request 127954: force icon themes explicitly via new testing helper function

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit 6ad988cb3df6ca3eac302444182b68fef383770f by Harald Sitter to branch master. Repository: plasma-framework Description --- force icon themes explicitly via new testing

Review Request 127954: force icon themes explicitly via new testing helper function

/127954/diff/ Testing --- passes in session env. whether it passes in testbeds we'll see on jenkins :O Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127953: rename fake icon set to hicolor as oxygen is no longer a fallback

marked as submitted. Review request for KDE Frameworks and Aleix Pol Gonzalez. Changes --- Submitted with commit cfc0a65e4dda986311c74f10797b09b1084a8e19 by Harald Sitter to branch master. Repository: kxmlgui Description --- rename fake icon set to hicolor as oxygen is no longer

Review Request 127953: rename fake icon set to hicolor as oxygen is no longer a fallback

/actions/go-up.png autotests/icons/oxygen/64x64/actions/go-up.png autotests/icons/oxygen/index.theme Diff: https://git.reviewboard.kde.org/r/127953/diff/ Testing --- - test fails without /usr/share/icons and icons/oxygen fake dir - test passes with icons/hicolor Thanks, Harald Sitter

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

> On May 18, 2016, 9:58 a.m., Marco Martin wrote: > > src/kicontheme.h, line 223 > > <https://git.reviewboard.kde.org/r/127952/diff/1/?file=465111#file465111line223> > > > > what about just a testmode bool like qstandardpaths? > > Harald Sitter wrote:

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

to use this Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

with the presented ::forceCurrent we can solve the issue at hand and reduce overhead code in testing. - Harald --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127952/#review

Re: Broken ABI in networkmanager-qt

On Tue, May 17, 2016 at 11:06 AM, Jan Grulich wrote: > Hi, > > we decided to drop WiMAX support in nm-qt when it's compiled against NM 1.2.0, > but this seems to break binary compatibility when nm-qt was previously build > against older NM version. I didn't realize this

Re: Review Request 127905: refine current icon theme heuristics

marked as submitted. Review request for KDE Frameworks, Christoph Feck and Marco Martin. Changes --- Submitted with commit 1425523dad0ba4f3acb9d0caa0ff772fd0a1a7e2 by Harald Sitter to branch master. Repository: kiconthemes Description --- this is to prevent incorrect default themes

Re: Review Request 127830: use QUrl::fromUserInput to construct sound url

marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit 9db06adc8114163f401417064b07772139bc36bc by Harald Sitter to branch master. Bugs: 337276 https://bugs.kde.org/show_bug.cgi?id=337276 Repository: knotifications Description

Re: Review Request 127829: use QUrl::fromUserInput to construct sound url

marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit 4832f7d9f2f3bd0fa8ab9b9162bf50e855efc448 by Harald Sitter to branch master. Bugs: 337276 https://bugs.kde.org/show_bug.cgi?id=337276 Repository: knotifyconfig Description

Re: Review Request 127829: use QUrl::fromUserInput to construct sound url

git.reviewboard.kde.org/r/127829/#review95167 ------- On May 4, 2016, 1:26 p.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 127829: use QUrl::fromUserInput to construct sound url

onswidget.cpp 98286c4d0e8a7deec5d35986a261222931afb60d Diff: https://git.reviewboard.kde.org/r/127829/diff/ Testing --- built and played all of the above Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@

Review Request 127830: use QUrl::fromUserInput to construct sound url

fybyaudio.cpp 6ae63b8df8e7aa692e88b03ca7b7538c78101917 Diff: https://git.reviewboard.kde.org/r/127830/diff/ Testing --- builds & test pass & I trust my testing in https://git.reviewboard.kde.org/r/127829/ Thanks, Harald Sitter ___ Kde-frameworks-d

Re: Review Request 127821: mark runtime dependency as type runtime

marked as submitted. Review request for Baloo. Changes --- Submitted with commit 84d7fcb8cccf4d845b5359853551e5362059ab3c by Harald Sitter to branch master. Repository: kfilemetadata Description --- mark runtime dependency as type runtime Diffs - CMakeLists.txt

Review Request 127821: mark runtime dependency as type runtime

--- mark runtime dependency as type runtime Diffs - CMakeLists.txt d4b6f7e9a378bbb41aa90252aff6d587ffca35f1 Diff: https://git.reviewboard.kde.org/r/127821/diff/ Testing --- Thanks, Harald Sitter

Re: Review Request 127764: warn about need for production data, skip tests that depend on them

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit c9e8c4b38c0d633b9e288169f647bceebddda72f by Harald Sitter to branch master. Repository: plasma-framework Description --- numerous icon tests expect the actual production plasma

Review Request 127764: warn about need for production data, skip tests that depend on them

/127764/diff/ Testing --- test passes in minimal environment - skips when xdg_data is not set - doesnt' skip with data set - skips when hicolor is not installed at all - passes when hicolor is installed Thanks, Harald Sitter ___ Kde-frameworks

Re: Review Request 127759: fix unresolvable types by adding relevant includes

marked as submitted. Review request for KDE Frameworks and David Edmundson. Changes --- Submitted with commit 95e30fd2668700374140d4c590aa96dd6d1f593d by Harald Sitter to branch master. Repository: kcoreaddons Description --- - QString for versionString - uint is a typedef, use

Review Request 127759: fix unresolvable types by adding relevant includes

ake test - abi-compliance-checker happy Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127743: mkpath instead of mkdir

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 90e8bb655f98722f6904c4aeb5b1089249814224 by Harald Sitter to branch master. Repository: kio Description --- if the parent directory/ies does not exist yet mkdir would fail even when

Re: mark kget obsolete?

On Mon, Apr 25, 2016 at 10:56 AM, Thomas Pfeiffer wrote: > On Montag, 25. April 2016 07:58:04 CEST Luigi Toscano wrote: >> Il 25 aprile 2016 03:40:33 CEST, Nick Shaforostoff ha > scritto: >> >distro packagers note that libktorrent for kf5 conflicts with

Re: ECM metainfo path

On Fri, Apr 22, 2016 at 10:13 PM, Matthias Klumpp <matth...@tenstral.net> wrote: > 2016-04-22 12:45 GMT+02:00 Harald Sitter <sit...@kde.org>: >> Lost mailing list CC, I am assuming that was intentional? (: > > Oops, no - I didn't see the CC and didn't hit reply-all the

Review Request 127743: mkpath instead of mkdir

.cpp 9f9d9449b2f06f33ac479b0b5fb47f26c169fb41 Diff: https://git.reviewboard.kde.org/r/127743/diff/ Testing --- tested the at the outlined scenario works make test still passes Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-framew

Re: appstream icons and the hicolor madness we have in KDE software

On Thu, Apr 21, 2016 at 1:02 PM, Aleix Pol wrote: > On Thu, Apr 21, 2016 at 1:12 AM, Rex Dieter wrote: >> Matthias Klumpp wrote: >> >>> GNOME ships icons for all its apps in hicolor/ >> >> KDE should too (in general) > > Would it be enough if Breeze

ECM metainfo path

ahoy ahoy! http://commits.kde.org/extra-cmake-modules/4b7a90bfe7a3e2eb3ae83c946c182a79fabc51e3 doesn't that break compatibility with older appstreams for everything that uses ECM? if so, I am not sure that is appropriate TBH HS ___

Re: Could we enable Travis-CI on our github mirrors?

On Wed, Apr 20, 2016 at 6:42 PM, Elvis Angelaccio wrote: > Hi, > as many of you already know, KDE has a github mirror in place at [1]. > I've been playing with travis-ci [2] and I was surprised by how easy to use > and how well integrated with github is. > > I think

appstream icons and the hicolor madness we have in KDE software

Hola, For the longest time I was annoyed by dolphin having a fishy icon in discover, which as it turns out is because it uses a default icon name so it gets a silly icon from a silly theme as appstream has no proper way of handling this. BUT That lead me to notice that there is branding

Re: Review Request 122403: [OS X] adaptations to phonon component.

looks fine in general. - Harald Sitter On Feb. 3, 2015, 12:41 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127577: install index.theme to same directory it always was in

marked as submitted. Review request for KDE Frameworks, David Faure, Jonathan Riddell, and Rex Dieter. Changes --- Submitted with commit 25a83b55f6b2439470bcc5d0963fd2ffa5c086ee by Harald Sitter to branch master. Repository: oxygen-icons5 Description --- otherwise we break

Review Request 127577: install index.theme to same directory it always was in

://git.reviewboard.kde.org/r/127577/diff/ Testing --- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Should kwalletd be automatically started

On Thu, Mar 24, 2016 at 8:35 AM, Valerio Pachera wrote: > Hi all, I need to understand if a problem I encountered with > owncloud-client is related to kde, the library qtkeychain or kde > itself. > > Once kde is started, owcnloud isn't able to cominicate with kwalletd > because

Re: oxygen icon name clasheroo

On Sun, Mar 20, 2016 at 10:08 AM, David Faure <fa...@kde.org> wrote: > On Wednesday 16 March 2016 15:57:45 Harald Sitter wrote: >> Hola! >> >> Our most awesome icon maintainers wanted to carry over icon symlinking >> from breeze to oxygen, alas that turned up

oxygen icon name clasheroo

Hola! Our most awesome icon maintainers wanted to carry over icon symlinking from breeze to oxygen, alas that turned up a whole slew of compatibility problems. examples: https://bugs.kde.org/show_bug.cgi?id=360605 https://bugs.kde.org/show_bug.cgi?id=360510 # Problem In kde4 software people

Re: Review Request 126004: add symlink verification tech

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 5fb092abc5961f4403ac87853ad2f524e62c0983 by Harald Sitter to branch master. Repository: breeze-icons Description --- to ensure greatest possible compatibility icon names are often symlinked

Review Request 126004: add symlink verification tech

/testdata.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126004/diff/ Testing --- ctest with both conditions true and false (master actually doesn't pass right now :() Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: icon frameworks

On Sat, Nov 7, 2015 at 8:35 PM, David Faure wrote: > On Saturday 07 November 2015 10:04:52 David Faure wrote: >> >> Did you check the list from >> https://community.kde.org/Frameworks/CreationGuidelines >> ? >> >> At first sight I see already one thing missing: no CI job under >>

breeze-icons open for business

breeze-icons have been split from breeze into its own repo and is now open for business. HS ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: icon frameworks

Quick update with On Thu, Nov 5, 2015 at 10:07 AM, Harald Sitter <sit...@kde.org> wrote: > - breeze-icons is a new repo going to be split from breeze and moving > to frameworks (tier1) This is now in frameworks and open to push to. > - oxygen-icons is a new repo of an old tarb

icon frameworks

Salut, I am presently preparing to move icons into frameworks scope. So we are all on the same page: - breeze-icons is a new repo going to be split from breeze and moving to frameworks (tier1) - oxygen-icons is a new repo of an old tarball (previously part of apps) that ought to be released

Re: Review Request 125928: Ship the "new file templates" in the kiofilewidgets library using a .qrc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125928/#review87905 --- Ship it! LGTM - Harald Sitter On Nov. 3, 2015, 8:24 a.m

Re: icons packages with frameworks

On Thu, Oct 22, 2015 at 10:12 AM, David Faure wrote: > On Wednesday 21 October 2015 21:07:16 Christoph Cullmann wrote: >> Hi, >> >> >> So maybe this wouldn't be such a bad move after all. >> > >> > Agreed, we have frameworks (e.g. KIconThemes) "depending" on breeze, so it >> >

Re: Review Request 125158: add logic to use icons for default xdg user dirs

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 93d71cdd19a6a844363751bd0299205d00d9a3a6 by Harald Sitter to branch master. Bugs: 352498 https://bugs.kde.org/show_bug.cgi?id=352498 Repository: kio Description --- this acts

breeze icons default and its inheritance

Aloha! So, yesterday I switched the default kiconthemes theme from oxygen to breeze [1] to get all builtin defaults of frameworks to be breeze rather than oxygen. Alas, as it turns out breeze icons do not inherit from oxygen for a while now, which has the very unfortunate disadvantage of

Re: Review Request 125720: set default theme to breeze rather than oxygen

marked as submitted. Review request for KDE Frameworks, Plasma and Christoph Feck. Changes --- Submitted with commit b544c17decc22685207ac11fbd95536e0d798650 by Harald Sitter to branch master. Bugs: 336739 https://bugs.kde.org/show_bug.cgi?id=336739 Repository: kiconthemes

Review Request 125720: set default theme to breeze rather than oxygen

is missing in breeze we will continue to find it with breeze as default. BUG: 336739 Diffs - src/kicontheme.cpp d0ab4b94b69679fba08131d0b0b577247b8db46b Diff: https://git.reviewboard.kde.org/r/125720/diff/ Testing --- Thanks, Harald Sitter

Re: Review Request 125717: initialize socket size with correct value

marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit f1e6b9d168281196010c44af2eae4587c1d2d088 by Harald Sitter to branch master. Bugs: 351805 https://bugs.kde.org/show_bug.cgi?id=351805 Repository: kwallet Description

Review Request 125717: initialize socket size with correct value

- - got error with Kubuntu build of kwallet using nvidia driver - applied patch - no longer got error in multiple test runs - removed patch and rebuilt kwallet - error returns Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-d

Re: phonon hassle to build WAS: Re: Policy for Dependencies

On Wed, Oct 14, 2015 at 8:47 AM, Christoph Cullmann wrote: >> On Tue, Oct 13, 2015 at 8:42 AM, Christoph Cullmann >> wrote: >>> phonon is a hassle on both win/mac (if you don't require audio, like most >>> applications won't) >> >> Oo >> >> explain

Re: phonon hassle to build WAS: Re: Policy for Dependencies

On Wed, Oct 14, 2015 at 8:58 AM, Christoph Cullmann wrote: > Hi, > >> On Wed, Oct 14, 2015 at 8:47 AM, Christoph Cullmann >> wrote: On Tue, Oct 13, 2015 at 8:42 AM, Christoph Cullmann wrote: > phonon is a hassle on

phonon hassle to build WAS: Re: Policy for Dependencies

On Tue, Oct 13, 2015 at 8:42 AM, Christoph Cullmann wrote: > phonon is a hassle on both win/mac (if you don't require audio, like most > applications won't) Oo explain please? ___ Kde-frameworks-devel mailing list

Re: phonon hassle to build WAS: Re: Policy for Dependencies

On Wed, Oct 14, 2015 at 9:11 AM, Christoph Cullmann wrote: > Hi, > but why would you want to build a backend if you need no sound anyway? >>> Thats the point, if I don't build a backend, I don't need phonon and I can >>> save building + shipping it with just making

Review Request 125529: switch kde4libs defaults from oxygen to breeze

d9efbb0275e1094c887bb62382d5ddb4135684d7 kdeui/kernel/kstyle.cpp 95a71c24842338fbe6bf5128f6fb76029960b64a Diff: https://git.reviewboard.kde.org/r/125529/diff/ Testing --- Thanks, Harald Sitter

Re: Review Request 125529: switch kde4libs defaults from oxygen to breeze

r/125529/#review86378 --- On Oct. 5, 2015, 2:21 p.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125529/ > -

Re: Review Request 125158: add logic to use icons for default xdg user dirs

isDirectoryMounted(url)) { > > // iconFromDirectoryFile > > } > > } I ordered this the other way around as we want .directory to take preference over the standardpath icon - Harald ----------

Re: Review Request 125158: add logic to use icons for default xdg user dirs

itemtest.cpp 5f728a411401fe3009924b66970d9ae6f12c60f2 src/core/kfileitem.cpp 966d8626708a8f2672f1777c873f4e27e13023d6 Diff: https://git.reviewboard.kde.org/r/125158/diff/ Testing --- maked autotested installed dolphin and file open dialogs now show icons Thanks, H

Re: Review Request 125158: add logic to use icons for default xdg user dirs

tps://git.reviewboard.kde.org/r/125158/#comment59432> This actually makes my eyes bleed a fair amount. Are there any objections to moving the struct declaration out of the function? If so, any perferences on where to put it? Other suggestions also very welcome. - Harald Sitter On Oct. 2, 2015,

Re: qca-qt5 (qt5 branch) merge into qca (master branch)

QCA's qt5 branch has now been merged back into master. master now behaves like qt5 did. If qt5 is found libqca-qt5 is built, if it isn't found qt4 is a requirement and libqca will be built. You can override this behavior by using the cmake option QT4_BUILD. Going to prep a tarball shortly. HS

Re: qca-qt5 (qt5 branch) merge into qca (master branch)

QCA's qt5 branch has now been merged back into master. master now behaves like qt5 did. If qt5 is found libqca-qt5 is built, if it isn't found qt4 is a requirement and libqca will be built. You can override this behavior by using the cmake option QT4_BUILD. Going to prep a tarball shortly. HS

Re: plasma-nm fails to build

you need to build qca from git as well. On Tue, Sep 29, 2015 at 4:06 AM, Jeffrey Brusseau wrote: > I'm trying to build KF5 (inside a archlinux base docker container via this > project). It ran all the way up to plasma-nm, failed to compile then > stopped. Here's the build

Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

marked as submitted. Review request for KDE Frameworks, David Faure, Jonathan Riddell, and Rex Dieter. Changes --- Submitted with commit 16e6b2b6a10622b060c22201085e26e8abcd60e2 by Harald Sitter to branch master. Repository: kservice Description --- To not conflict

Re: kcrash when started from terminal

n Thu, Sep 24, 2015 at 9:30 AM, David Faure <fa...@kde.org> wrote: > On Wednesday 23 September 2015 14:24:33 Harald Sitter wrote: >> Heya >> >> is it intentional that KCrash is not running when an application is >> started via kdeinit? >> >> In particul

Re: Icons installed by apps

On Wed, Sep 23, 2015 at 11:27 PM, Jaroslaw Staniek wrote: >>> Thirdly, I suppose it's possible to indicate in the code that I am >>> looking for a "place" icon group for example. That would slash the >>> number of lookups and also limit conflicts. Maybe that would be a >>>

qca-qt5 (qt5 branch) merge into qca (master branch)

ahoy ahoy qca-qt5 as a "thing" is a build time switch on the same source as qca (qt4). so, it is the same source base but depending on how you run cmake you either get the qt5 or the qt4 build. originally various adjustments had to be made to qca-qt5 to make it work reliably without conflicting

qca-qt5 (qt5 branch) merge into qca (master branch)

ahoy ahoy qca-qt5 as a "thing" is a build time switch on the same source as qca (qt4). so, it is the same source base but depending on how you run cmake you either get the qt5 or the qt4 build. originally various adjustments had to be made to qca-qt5 to make it work reliably without conflicting

Re: Icons installed by apps

On Wed, Sep 23, 2015 at 12:17 AM, Albert Astals Cid wrote: > El Dimarts, 22 de setembre de 2015, a les 23:01:06, Jaroslaw Staniek va > escriure: >> On 22 September 2015 at 22:55, Matthias Klumpp > wrote: >> > Am 22.09.2015 10:32 nachm. schrieb "Albert

Re: marble builds when it shouldn't

On Wed, Sep 23, 2015 at 11:13 AM, Ben Cooksley wrote: > On Wed, Sep 23, 2015 at 7:25 AM, Scarlett Clark > wrote: >> That is correct. I have turned this off and on so many times it is not >> funny. Somehow everyone needs to agree on this. > >

Review Request 125343: bump so version from 5 to 6

, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/#review85701 ----------- On Sept. 17, 2015, 9:32 a.m., Harald Sitter wrote: > > -

Review Request 125284: make install name of applications.menu file a cached cmake variable

mp; make install > -- Installing: ./etc/xdg/menus/applications.menu changed cached var && make && make install > -- Installing: ./etc/xdg/menus/kf5-applications.menu Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-framewo

breeze repo to be split into breeze and breeze-icons come plasma 5.5

Some time between now and plasma 5.5 branching we will split the breeze icon theme from the breeze repo to its own breeze-icons repo. HS

Re: Review Request 125158: add logic to use icons for default xdg user dirs

966d8626708a8f2672f1777c873f4e27e13023d6 Diff: https://git.reviewboard.kde.org/r/125158/diff/ Testing --- maked autotested installed dolphin and file open dialogs now show icons Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: folder icons where should they be set

http://freedesktop.org/wiki/Software/xdg-user-dirs/ On Fri, Sep 11, 2015 at 8:57 AM, Thomas Lübking <thomas.luebk...@gmail.com> wrote: > On Freitag, 11. September 2015 00:16:35 CEST, Harald Sitter wrote: > >> being my confused self I am rather clueless as to where th

Re: folder icons where should they be set

On Fri, Sep 11, 2015 at 9:43 AM, Thomas Lübking <thomas.luebk...@gmail.com> wrote: > On Freitag, 11. September 2015 09:37:44 CEST, Harald Sitter wrote: >> >> http://freedesktop.org/wiki/Software/xdg-user-dirs/ > > > "Interesting" concept where the system

Re: folder icons where should they be set

On Fri, Sep 11, 2015 at 9:00 AM, Kai Uwe Broulik wrote: > Hi, > > Aren't these XDG standard dirs you can even configure? Just show the folder > at XDG images with a pictures folder icon and so on. "Just" xD I did however find kfileitem.cpp which seems like the right

Review Request 125158: add logic to use icons for default xdg user dirs

Diff: https://git.reviewboard.kde.org/r/125158/diff/ Testing --- maked autotested installed dolphin and file open dialogs now show icons Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Moving KDE Connect out of playground

+1000 On Thu, Sep 10, 2015 at 10:32 AM, Albert Vaca wrote: > Hi, > > With the latest changes we are making to KDE Connect as part of the sprint > in Randa, I think that the project is becoming mature enough to be moved out > of playground. Not only that, but Kubuntu and

folder icons where should they be set

salut mes amis so this popped up https://bugs.kde.org/show_bug.cgi?id=352498 and GTK/Gnome rather seems to set the folder icon as part of their folder-display-component sort of thing (e.g. file open as well as file browsers and what not). it does so however *without* creating a .directory file

folder icons where should they be set

salut mes amis so this popped up https://bugs.kde.org/show_bug.cgi?id=352498 and GTK/Gnome rather seems to set the folder icon as part of their folder-display-component sort of thing (e.g. file open as well as file browsers and what not). it does so however *without* creating a .directory file

folder icons where should they be set

salut mes amis so this popped up https://bugs.kde.org/show_bug.cgi?id=352498 and GTK/Gnome rather seems to set the folder icon as part of their folder-display-component sort of thing (e.g. file open as well as file browsers and what not). it does so however *without* creating a .directory file

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 31, 2015, 8:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > <https://git.reviewboard.kde.org/r/124919/diff/2/?file=398321#file398321line26> > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 31, 2015, 8:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit Yeah

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

, and Harald Sitter. Bugs: 342962 https://bugs.kde.org/show_bug.cgi?id=342962 Repository: kdeclarative Description --- The kdeclarative plugins (draganddropplugin, kcoreaddonsplugin, kio, kquickcontrolsprivateplugin, and kquickcontrolsaddonsplugin) are being built as shared

QML plugin name resolution WAS Re: Review Request 124916: also make kwindowsystem a module rather than a shared lib

Aloha as we noticed in https://git.reviewboard.kde.org/r/124916/ the qml plugin name resolution is pretty meh and desperately needs improving [1]. Essentially QML plugins on Linux *must* be prefixed with 'lib' e.g. libdragandrop.so If they do not have the prefix they won't get found. This is

Re: Review Request 124916: also make kwindowsystem a module rather than a shared lib

/qmlcontrols/kwindowsystemplugin/CMakeLists.txt ce0ea7476fd69b9bef84d5efdee273214b6aacf8 Diff: https://git.reviewboard.kde.org/r/124916/diff/ Testing --- make make install Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

have to revert this before release. [1] https://aur.archlinux.org/packages/plasma-desktop-git/ Harald Sitter wrote: I tried it this morning and it seemed to work. Now I try it again and it fails I suppose this is the point where we call for a revert hammer? :P Harald

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

have to revert this before release. [1] https://aur.archlinux.org/packages/plasma-desktop-git/ Harald Sitter wrote: I tried it this morning and it seemed to work. Now I try it again and it fails I suppose this is the point where we call for a revert hammer? :P Harald

<    6   7   8   9   10   11   12   13   >