D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella updated this revision to Diff 36578. nicolasfella added a comment. Use JSON metadata and install in kf5/fileitemaction namespace REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=34934=36578 BRANCH fiap REVISION DETAIL

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added inline comments. INLINE COMMENTS > elvisangelaccio wrote in CMakeLists.txt:12-13 > Please consider using json metadata and installing the plugin into the > `kf5/kfileitemaction` namespace. Sorry, I don't quite understand what I am supposed to do REPOSITORY R495 Purpose

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. Friendly ping? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh,

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. In D13124#269655 , @broulik wrote: > I like yours better, I can abandon mine if you want to finish this :) I would have abandoned mine because you were first, but fine with me :) REPOSITORY R495 Purpose

D13150: Add ellipsis where appropriate

nicolasfella added a comment. Quote from VDG: If there will be further user input needed and a dialogue or similar popping up for it: needs ellipsis Therefore Pastebin would not need one, but I guess this is neglectable REPOSITORY R495 Purpose Library REVISION DETAIL

D13150: Add ellipsis where appropriate

nicolasfella added a comment. It's done this way in Email, KTP and KDE Connect already. If we add the ellipsis in AlternativesModel's DisplayRole we get it on every entry, even if it would be inappropriate. REPOSITORY R495 Purpose Library REVISION DETAIL

D13160: Highlight the selected device in the KDE Connect plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R495:956efe4cd21f: Highlight the selected device in the KDE Connect plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D13151: Fix Phabricator icon

This revision was automatically updated to reflect the committed changes. Closed by commit R495:65f9072a2ec7: Fix Phabricator icon (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13151?vs=34976=35002#toc REPOSITORY R495 Purpose Library CHANGES SINCE LAST

D13160: Highlight the selected device in the KDE Connect plugin

nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R495 Purpose Library BRANCH highlight

D13158: Fix i18n issues in Phabricator Plugin

nicolasfella edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13158 To: nicolasfella, apol Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D13158: Fix i18n issues in Phabricator Plugin

nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When the diffs combo box is empty i18n

D13151: Fix Phabricator icon

nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY use the right icon name REPOSITORY

D13150: Add ellipsis where appropriate

nicolasfella created this revision. nicolasfella added reviewers: VDG, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Add ellipsis to actions that open up

D12895: WIP: Add KFileItemActionsPlugin

nicolasfella added inline comments. INLINE COMMENTS > sharefileitemaction.cpp:83 > +m_purposeMenu->model()->setInputData(QJsonObject{ > +{QStringLiteral("mimeType"), fileItemInfos.mimeType()}, > +{QStringLiteral("urls"), mimeType() can be empty which can cause problems (see

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. In D13124#268906 , @broulik wrote: > Have you seen D12895 ? I looked for similar patches with the #dolphin tag, but I didn't see

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella updated this revision to Diff 34934. nicolasfella added a comment. - Set mimetype to */* if reported mimetype is empty REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=34933=34934 BRANCH fiap REVISION DETAIL

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella marked an inline comment as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun,

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella updated this revision to Diff 34933. nicolasfella added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. Make it a FileItemActionPlugin REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D12896: Add Telegram plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R495:6f74cbb9659f: Add Telegram plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12896?vs=34737=34750 REVISION DETAIL

D12896: Add Telegram plugin

nicolasfella updated this revision to Diff 34737. nicolasfella added a comment. : - Hardcode commands and try until success REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12896?vs=34213=34737 BRANCH master REVISION DETAIL

D12896: Add Telegram plugin

nicolasfella added a comment. I played around a bit and it turns out more difficult than expected. - telegram-desktop-bin from AUR has telegramdesktop.desktop whereas the Flatpak version has org.telegram.desktop.desktop, so we would need to look for at least those desktop files - the

D12896: Add Telegram plugin

nicolasfella added a comment. In D12896#266713 , @apol wrote: > Then just read the Exec field and we'll add the sendpath by hand. This is ad-hoc for telegram anyway. I'm not quite sure what to do. Best I came up with is something like

D12896: Add Telegram plugin

nicolasfella added a comment. I've played around with flatpaked Telegram and made it working. However: My Telegram.desktop file executes this: /usr/bin/flatpak run --branch=stable --arch=x86_64 --command=telegram-desktop --file-forwarding org.telegram.desktop -- @@u %u @@ I can share a

D12896: Add Telegram plugin

nicolasfella added a comment. Can this even work with Telegram installed as sandboxed Flatpak? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12896 To: nicolasfella, apol Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12896: Add Telegram plugin

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in telegramplugin.cpp:61 > Instead of finding the program, we could execute using > `org.telegram.desktop.desktop`, it would allow it to work even if it's > installed from appimage/flatpak. > > I'm not sure how this would work

D12896: Add Telegram plugin

nicolasfella marked 2 inline comments as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12896 To: nicolasfella, apol Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12896: Add Telegram plugin

nicolasfella updated this revision to Diff 34213. nicolasfella added a comment. - Use url.toLocalfile() REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12896?vs=34200=34213 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12896

D12896: Add Telegram plugin

nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Add a "Share via Telegram plugin". It's

D11649: Fix crash in the file slave

nicolasfella added a subscriber: KDE Connect. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11649 To: aacid, #frameworks, dfaure Cc: #kde_connect, michaelh, ngraham

D11643: Fix crash when device emits ready read after job is finished

nicolasfella added a subscriber: KDE Connect. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11643 To: aacid, #frameworks, dfaure Cc: #kde_connect, michaelh, ngraham

D10807: fileindexerconfig: Exclude Vaults by default

nicolasfella added a subscriber: ivan. nicolasfella added a comment. I honestly don't know. @ivan any idea? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: ivan, nicolasfella, ashaposhnikov, michaelh,

D10807: fileindexerconfig: Exclude Vaults by default

nicolasfella added a comment. You have to hit next a couple of times REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spoorun, alexeymin

D10807: fileindexerconfig: Exclude Vaults by default

nicolasfella added a comment. When creating a Vault you can choose any location for it. ~/Vaults is just the default REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh,

D10807: fileindexerconfig: Exclude Vaults by default

nicolasfella added a comment. F5728282: Screenshot_20180224_212932.png REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski,

D10807: fileindexerconfig: Exclude Vaults by default

nicolasfella added a comment. Vault can also be mounted in other directories than ~/Vaults REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spoorun, alexeymin

D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()

nicolasfella added a comment. Now it does. Awesome! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9190 To: aacid, dfaure, apol, albertvaka Cc: ngraham, nicolasfella, anthonyfieroni, #frameworks

D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()

nicolasfella added a comment. In https://phabricator.kde.org/D9190#179713, @aacid wrote: > Sorry guys i unsubscribed you by mistake when updating the summary. > > Nicolas can you check if this fixes it for you? It does for me. Will do on Monday REPOSITORY R241 KIO REVISION

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

nicolasfella added a comment. > Yes it does. You don't know it but > m_reply = Daemon::instance()->networkAccessManager()->put(req, m_origin.data()); > in filetransferjob.cpp is using kio. I really didn't know that > Are you sure you know how to run kdeconnect with the

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

nicolasfella added a comment. I'm sorry, but this does not resolve https://bugs.kde.org/show_bug.cgi?id=386246 for me. KDE Connect's FileTransferJob does not even use KIO's TransferJob. It just extends KJob, so it could be a (similar) bug there. REPOSITORY R241 KIO REVISION DETAIL

D8146: Don't try to override label heights - PlasmaComponents

nicolasfella abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8146 To: nicolasfella, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8146: Don't try to override label heights - PlasmaComponents

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. nicolasfella added a project: Plasma. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Same as https://phabricator.kde.org/D8129 but

D7855: Fix tags KIO-slave protocol description

This revision was automatically updated to reflect the committed changes. Closed by commit R293:8d7db8710ed6: Fix tags KIO-slave protocol description (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7855?vs=19598=19782 REVISION DETAIL

D7855: Fix tags KIO-slave protocol description

nicolasfella added a comment. This is a workaround for issues which will be more visible when https://phabricator.kde.org/D7700 gets merged REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7855 To: nicolasfella, #frameworks Cc: #frameworks

D7855: Fix tags KIO-slave protocol description

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. nicolasfella added a project: Frameworks. REVISION SUMMARY tags.protocol lies about what actions are implemented/available. This disables all unsupported actions in Dolphin etc until these are implemented in the

<    5   6   7   8   9   10