D1231: Add Remote Access interface to KWayland

Kanedias added a comment. - squashed before pushing - fixed all versions to 5.45 Thanks gentlemen, it's was 1 day more for the second birthday of this patch :) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson,

D1231: Add Remote Access interface to KWayland

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:5116fe0c6345: Add Remote Access interface to KWayland (authored by Kanedias). CHANGED PRIOR TO COMMIT

D1231: Add Remote Access interface to KWayland

Kanedias marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, schernikov, michaelh,

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30273. Kanedias marked an inline comment as done. Kanedias added a comment. - Merge branch 'master' into gbm-vnc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=30272=30273 BRANCH gbm-vnc REVISION DETAIL

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30272. Kanedias added a comment. Remove already merged changes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=30271=30272 BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1231 AFFECTED FILES

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30271. Kanedias added a comment. - Implement releasing of client-freed output - Review fixes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=25976=30271 BRANCH gbm-vnc REVISION DETAIL

D9871: Add partial busy-widget support

Kanedias abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D9871 To: Kanedias, apol, colomar, andreask Cc: #frameworks, michaelh, ngraham

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. In D1231#224441 , @jtamate wrote: > As I don't see anything related to security in this patch, I have two questions. > > Could anyone with access to server:port manage the server wayland sessions or just create a

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. It will soon be this patch 2nd birthday. Can we speed up things a bit? I've seen this is scheduled for Plasma 5.13, would be good if we have time to test it. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin,

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @graesslin , @davidedmundson , please approve this once again, this was updated numerous times after initial review REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jgrulich,

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 25976. Kanedias edited the test plan for this revision. Kanedias added a comment. - Add RemoteAccess interface to KWayland - Merge branch - Fix compilation warnings uint -> int REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @ngraham, yes, he didn't review this after changes were made REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu,

D9871: Add partial busy-widget support

Kanedias created this revision. Kanedias added reviewers: apol, colomar. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. Kanedias requested review of this revision. REVISION SUMMARY - added busy-widget icon 32-px action variant -

D1231: Add Remote Access interface to KWayland

Kanedias marked 5 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: subdiff, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 21212. Kanedias added a comment. Updated against latest master, fixed review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=16359=21212 REVISION DETAIL https://phabricator.kde.org/D1231

D1231: Add Remote Access interface to KWayland

Kanedias added inline comments. INLINE COMMENTS > subdiff wrote in remote_access_interface.cpp:206 > Can a rogue client do it though? This would crash the server then? > Can a rogue client do it though? This would crash the server then? Yes, I guess so... What would you propose? Should we send

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. Gentle reminder REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. Btw, should I bump patches to KWin/KRfb to match this version? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @davidedmundson , @graesslin , I cleaned up fake-input handling, fixed autotests. Tested this manually with patched KWin and KRfb version - all works fine (only one screen though). I'm able to retrieve wl_output from native interface as David suggested.

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 16359. Kanedias added a comment. some -> const modifiers and typos REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=16318=16359 REVISION DETAIL https://phabricator.kde.org/D1231 AFFECTED FILES

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. I'll get rid of the fakeinput-related changes and test it with KRfb tomorrow. @davidedmundson , can you test this with multiple outputs? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc:

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 16318. Kanedias added a comment. Added wl_output reference for buffers as requested by @davidedmundson and @graesslin REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=15553=16318 REVISION DETAIL

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. How do I get ID from wl_output interface? I kinda got how I can get the needed info from DrmOutput instance, but not sure how to compare them on server and client side REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias,

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 15553. Kanedias added a comment. Fixed KWAYLAND -> Kwayland in CmakeLists.txt REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=15125=15553 REVISION DETAIL https://phabricator.kde.org/D1231 AFFECTED FILES

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @davidedmundson , do we really have nativeResourceForScreen call? AFAIK KWin uses its own QPA, which implements only bits of functionality. We need to have nativeResourceForScreen to be able to pass wl_output, should I patch QPA also, or is there better way?

D1231: Add Remote Access interface to KWayland

Kanedias added a dependent revision: D6186: Implement software cursor in OpenGL backend . REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, spstarr,

D1231: Add Remote Access interface to KWayland

Kanedias added a dependent revision: D6096: Add Wayland RemoteAccess capabilities to KRfb. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff,

D1231: Add Remote Access interface to KWayland

Kanedias added a dependent revision: D1230: GBM remote access support for KWin. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. In https://phabricator.kde.org/D1231#112772, @davidedmundson wrote: > > Would it benefit from a series of damage events being sent in the org_kde_kwin_remote_buffer before the gbm_handle event? > Kwin should have all this information available.

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 15125. Kanedias added a reviewer: davidedmundson. Kanedias added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. Rebased the protocol against latest KWayland branch. Will update on