Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-05-23 Thread Ralf Jung
On May 3, 2013, 8:52 p.m., Marco Martin wrote: any news on this? Martin, what do you think about it? Thomas fixed some existing issues which were uncovered by this patch, see https://bugs.kde.org/show_bug.cgi?id=179042#c71 . As far as I can tell, no other issues are known. - Ralf

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-04-10 Thread Ralf Jung
kdelibs developer to have a look at this, so that this 4-year-old bug can finally be resolved? It'd be a shame if KDE 4.11 would ship without this patch. - Ralf Jung On March 23, 2013, 9:06 p.m., Thomas Lübking wrote

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-03-23 Thread Ralf Jung
the old and annoying issue of Plasma picking the wrong theme. - Ralf Jung On Jan. 9, 2013, 3 a.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983

Review Request 109385: Fix parse error in advanced memroy information for 3.8 kernels

2013-03-10 Thread Ralf Jung
that Advanced Memory Information is working again. Thanks, Ralf Jung

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-13 Thread Ralf Jung
Hi, First, sorry I confused kdelibs with kde-baseapps in this response. So forget what I said about changes being merged back into 4.10 branch by David. Anyhow, I have now attempted to fix this issue as reported here. See

Re: Review Request: kdepasswd KCM: add option to remove the user image

2012-03-07 Thread Ralf Jung
are properly set up and removed again. Thanks, Ralf Jung

Re: Review Request: kdepasswd KCM: add option to remove the user image

2012-03-06 Thread Ralf Jung
no comments for 10 days now. - Ralf Jung On Feb. 24, 2012, 1:25 p.m., Ralf Jung wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104054

Re: Binary compatiblity for liboxygenstyle.so

2012-03-06 Thread Ralf Jung
Hi, Adding Ralf in CC, since he is experiencing the same issues. Thanks Hugo :) The issue I have is the same as Andreas, except that the application does not crash for me if it uses the wrong Oxygen. It just looks ugly because the gradient seems to have changed between KDE 4.6 (which lives in

Re: Review Request: kdepasswd KCM: add option to remove the user image

2012-02-24 Thread Ralf Jung
/ Testing --- Compiled, and verified that images are properly set up and removed again. Thanks, Ralf Jung

Review Request: kdepasswd KCM: add option to remove the user image

2012-02-23 Thread Ralf Jung
/kcm/chfacedlg.h c389e49 kdepasswd/kcm/chfacedlg.cpp a80c5af kdepasswd/kcm/main.cpp b664f98 Diff: http://git.reviewboard.kde.org/r/104054/diff/ Testing --- Compiled, and verified that images are properly set up and removed again. Thanks, Ralf Jung

Review Request: make folderview compile with Qt 4.7

2012-02-20 Thread Ralf Jung
, Ralf Jung

Re: Review Request: make folderview compile with Qt 4.7

2012-02-20 Thread Ralf Jung
/folderview/actionoverlay.cpp 791cfdf Diff: http://git.reviewboard.kde.org/r/104030/diff/ Testing --- compile-tested Thanks, Ralf Jung

Re: Review Request: make folderview compile with Qt 4.7

2012-02-20 Thread Ralf Jung
-tested Thanks, Ralf Jung

Re: Review Request: KActivities requires Soprano 2.7 to compile

2011-11-09 Thread Ralf Jung
On Nov. 7, 2011, 3:56 p.m., Ralf Jung wrote: Any comment on this? The patch looks trivial, but I am still new to all this so I'd prefer if someone could confirm that KActivites can and should actually require Soprano 2.7. Aaron J. Seigo wrote: it builds here with 2.6.51. so 2.7

Re: Review Request: KActivities requires Soprano 2.7 to compile

2011-11-07 Thread Ralf Jung
new to all this so I'd prefer if someone could confirm that KActivites can and should actually require Soprano 2.7. - Ralf Jung On Oct. 16, 2011, 10:29 a.m., Ralf Jung wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-11-07 Thread Ralf Jung
changes. Alex Ralf Jung wrote: The problem is that this results in a warning about CMake files being overridden when running cmake for kde-workspace. Plus, the files is not even exactly the same as the CMakeParseArgument.cmake that is shipped with my cmake version - it is missing

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-24 Thread Ralf Jung
On Oct. 23, 2011, 4:22 p.m., Ralf Jung wrote: Any news? Can I ship this (simplified) version of the original request? Oswald Buddenhagen wrote: in qt review terms, you get a +1 from me. this code is pretty much unmaintained, so it's unlikely that you'll get more feedback than

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-24 Thread Ralf Jung
Hi, Yes, most probably. I guess it was first developed as a standalone tool, where you have to do everything yourself, including searching for Qt4 etc., and then was added into kdebase. Checking the other cmake files of libkephal, it does not seem to support standalone builds anymore. I

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-23 Thread Ralf Jung
Hi, That's the problem. CMP0017 should be set to NEW, and it is set to NEW in FindKDE4Internal.cmake. So we need to find out why it is not set in this case. Thanks for this hint! After some more debugging, I came up with attached patch against kde-workspace which also fixes the warning here

Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Ralf Jung
/diff Testing --- re-ran cmake and make install for kdelibs and kde-workspace, all working fine and the file is no longer installed (I am using cmake 2.8.5) Thanks, Ralf Jung

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Ralf Jung
, visit: http://git.reviewboard.kde.org/r/102869/#review7375 --- On Oct. 15, 2011, 2:47 p.m., Ralf Jung wrote: --- This is an automatically generated e-mail. To reply, visit: http

Review Request: KActivities requires Soprano 2.7 to compile

2011-10-16 Thread Ralf Jung
this is the right list, there is no kactivities group in reviewboard) Diffs - service/CMakeLists.txt 5489b6b Diff: http://git.reviewboard.kde.org/r/102893/diff/diff Testing --- compile-tested Thanks, Ralf Jung

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-14 Thread Ralf Jung
Hi, No tabs, 4 spaces instead. http://techbase.kde.org/Policies/Kdelibs_Coding_Style Almost the complete main.cpp is using tabs currently (except for KCMUserAccount::decodeImgDrop, which uses 2 spaces) so I used it for the two lines I added. Is that okay, or am I supposed to use 4 spaces

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-13 Thread Ralf Jung
320126f kdepasswd/kcm/main.cpp 5ce1961 Diff: http://git.reviewboard.kde.org/r/102799/diff/diff Testing --- Compiled and verified that the KCM now behaves as desired. Thanks, Ralf Jung

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-09 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102799/#review7185 --- On Oct. 7, 2011, 11:46 a.m., Ralf Jung wrote

Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-07 Thread Ralf Jung
/chfacedlg.cpp a80c5af kdepasswd/kcm/main.h 320126f kdepasswd/kcm/main.cpp 5ce1961 Diff: http://git.reviewboard.kde.org/r/102799/diff/diff Testing --- Compiled and verified that the KCM now behaves as desired. Thanks, Ralf Jung

Review Request: Reset password field to be empty for subsequent attempts to open the wallet

2011-09-27 Thread Ralf Jung
in to see if the reset happens properly Thanks, Ralf Jung