D11685: Implement single click on line number to select line of text

rkron added a comment. Yes, tested and it works. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: kwrite-devel, kde-frameworks-devel, dhaumann, rkron, mwolff, ngraham, #ktexteditor, #kate,

D11685: Implement single click on line number to select line of text

rkron added a comment. Would someone please land this for me? Thanks. REPOSITORY R39 KTextEditor BRANCH Bug372503 (branched from master) REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: dhaumann, rkron, mwolff,

D11685: Implement single click on line number to select line of text

rkron marked 4 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: rkron, mwolff, richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, bruns,

D11685: Implement single click on line number to select line of text

rkron edited the summary of this revision. rkron edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: mwolff, richardbowen, ngraham, #ktexteditor, #kate,

D11685: Implement single click on line number to select line of text

rkron updated this revision to Diff 31505. rkron added a comment. - Revise patch per review comments. Added comments and removed code to fix view scrolling inconsistancy when dragging over line numbers. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D11685: Implement single click on line number to select line of text

rkron updated this revision to Diff 31182. rkron added a comment. - Removed two unnecessary lines in patch. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11685?vs=30560=31182 BRANCH Bug372503 (branched from master) REVISION DETAIL

D11685: Implement single click on line number to select line of text

rkron added a reviewer: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, cullmann, sars,

D11685: Implement single click on line number to select line of text

rkron edited the summary of this revision. rkron edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh,

D11685: Implement single click on line number to select line of text

rkron updated this revision to Diff 30560. rkron added a comment. - Update revision per review comments. Removed the config option to enable and disable the single-click behavior. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11685?vs=30517=30560

D11685: Implement single click on line number to select line of text

rkron added a comment. @ngraham Qt Designer made those changes when I added the checkbox. They will be gone with the update. The four files concerning the config option will be as they were before this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D11685: Implement single click on line number to select line of text

rkron added a comment. And actually, if you have the line modification marker border turned on, clicking in it will just move the cursor without selecting the line. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate,

D11685: Implement single click on line number to select line of text

rkron added a comment. @ngraham I agree. Single-click is pretty much standard. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh,

D11685: Implement single click on line number to select line of text

rkron added a comment. OK. I will remove the option and update the revision. Thanks for the input! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: ngraham, #ktexteditor, #kate, #frameworks, michaelh,

D11685: Implement single click on line number to select line of text

rkron added a comment. If you think it should be on by default, that's easily done. I know what you mean, that nobody would ever find it. When I first started using Kate, I thought the triple-clicking was very annoying. But I got used to it and now it's automatic for me. It also became

D11685: Implement single click on line number to select line of text

rkron edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

rkron created this revision. rkron added reviewers: Frameworks, Kate, KTextEditor, ngraham. Restricted Application added projects: Kate, Frameworks. rkron requested review of this revision. REVISION SUMMARY Implements selecting entire line of text with a single click on line number.

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

rkron added a comment. @davidedmundson Thanks for the commit! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9928 To: rkron, #frameworks, davidedmundson Cc: dhaumann, ngraham, alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

rkron added a comment. I'm new to phabricator and do not have commit access. Does someone need to commit this? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9928 To: rkron, #frameworks, davidedmundson Cc: ngraham, alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

rkron updated this revision to Diff 25540. rkron added a comment. After reviewing the kio commit where similar changes were made, I changed QFile::exists to QFileInfo::exists as was done in kio and have updated my patch. I should have looked at kio before my first submission. Sorry.

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

rkron created this revision. rkron added a reviewer: Frameworks. rkron added a project: Frameworks. rkron requested review of this revision. REVISION SUMMARY I found two places in plasma-framework svg.cpp (Plasma::Svg) that were triggering this message. path variable was not being checked