Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Sebastian Kügler
this approach, the code is fine and good to go. src/plasma/private/packages.cpp (line 46) <https://git.reviewboard.kde.org/r/127345/#comment63705> I'd just go for test.qml or perhaps even autotest.qml - Sebastian Kügler On March 12, 2016, 12:29 a.m., Aleix Pol Gonzalez

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-11 Thread Sebastian Kügler
src/plasmaquick/appletquickitem.h (line 129) <https://git.reviewboard.kde.org/r/127345/#comment63682> teh mistake! src/plasmaquick/appletquickitem.cpp (line 652) <https://git.reviewboard.kde.org/r/127345/#comment63683> { } also for single lines - Sebastian Kügler On Ma

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
us quo but with maintainer), that would already be an improvement of course. The question mark was honest, we haven't made a decision on it, but different people do have expressed a preference for not shipping it (as or by default in Plasma releases). We may have missed important points, and we do

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
anks in advance for your answer. Yuri, this is an discussion between developers, and your email doesn't meet the requirement of being constructive or respectful. Please change your attitude or refrain from further commenting. If you're unsure, read https://www.kde.org/code-of-conduct/ -- sebas S

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
hat pretty clear. We do think that disconnected systems are rather a fringe case, and that our time and effort is better spent on other things. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
-bent on keeping it, this person should consider maintaining it as well. Unmaintained code in Plasma is not cool, and so far nobody seems to care enough to step up. Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: Google Summer of Code 2016 - C# bindings for Qt

2016-03-03 Thread Sebastian Kügler
SoC admins on the mailinglist kde- s...@kde.org , they can answer your questions and get you set up to mentor. > On Thu, Mar 3, 2016 at 5:58 PM, Sebastian Kügler <se...@kde.org> wrote: > > On Thursday, March 03, 2016 06:20:49 PM Arno Rehn wrote: > > > having worked with Dimitar

Re: Google Summer of Code 2016 - C# bindings for Qt

2016-03-03 Thread Sebastian Kügler
SoC admins on the mailinglist kde- s...@kde.org , they can answer your questions and get you set up to mentor. > On Thu, Mar 3, 2016 at 5:58 PM, Sebastian Kügler <se...@kde.org> wrote: > > On Thursday, March 03, 2016 06:20:49 PM Arno Rehn wrote: > > > having worked with Dimitar

Re: KDE file dialog

2016-03-01 Thread Sebastian Kügler
On Tuesday, March 01, 2016 06:45:14 PM Martin Koller wrote: > On Monday 29 February 2016 21:34:13 Luigi Toscano wrote: > > > Should a KF5 app (with frameworksintegration) not also use the settings > > > from a still used KDE4 desktop ?> > > > > > > frameworksintegration is going to be part of

Re: Review Request 127090: Clean KWalletQuery cmake file

2016-02-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127090/#review92744 --- Ship it! Ship It! - Sebastian Kügler On Feb. 16, 2016

Re: KDE5 Theme

2016-02-04 Thread Sebastian Kügler
On Wednesday, February 03, 2016 10:07:08 AM jfsanchez wrote: > Is there any guide for writing a full KDE5 theme? There is no KDE5. You may be looking for one of the following: - A Plasma Look and Feel package (defines the UI of different interactive screens, such as the splash, lock screen,

Re: [Kde-hardware-devel] All hail the new KScreen king

2016-01-27 Thread Sebastian Kügler
On Wednesday, January 27, 2016 08:39:38 PM Albert Astals Cid wrote: > > - Kill libkscreen usage in plasmashell (Aleix has a patch, but it needs Qt > > > > 5.6, so until we can depend on that, we have to wait), in general, > > libkscreen should not be used for just reading the screen

Re: [Kde-hardware-devel] All hail the new KScreen king

2016-01-27 Thread Sebastian Kügler
On Thursday, January 28, 2016 00:03:34 Luca Beltrame wrote: > In data mercoledì 27 gennaio 2016 22:43:03 CET, Sebastian Kügler ha scritto: > > What for? Would it be possible to use QScreen directly for it? > > For example, for selecting (in preferences) on which screen open a

Re: [Kde-hardware-devel] All hail the new KScreen king

2016-01-27 Thread Sebastian Kügler
Hey, First of all: Thanks a lot, Dan, for your KScreen maintainership. I'll have big shoes to fill. On Wednesday, January 27, 2016 04:31:45 PM Daniel Vrátil wrote: > since I no longer have that much time to work on KDE, I decide to cut back > on the number of projects I am involved in. KScreen

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread Sebastian Kügler
> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote: > > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 395 > > <https://git.reviewboard.kde.org/r/126804/diff/1/?file=434496#file434496line395> > > > > DPI-dependent, could be shared with

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread Sebastian Kügler
> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote: > > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 311 > > <https://git.reviewboard.kde.org/r/126804/diff/1/?file=434496#file434496line311> > > > > So this means that we either pass a

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread Sebastian Kügler
board.kde.org/r/126804/#comment62476> Q_FOREACH and const& src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp (line 321) <https://git.reviewboard.kde.org/r/126804/#comment62477> DPI-dependent, could be shared with the above - Sebastian Kügler On Jan. 18, 201

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread Sebastian Kügler
> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote: > > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 390 > > <https://git.reviewboard.kde.org/r/126804/diff/1/?file=434496#file434496line390> > > > > Q_FOREACH and const& > > David R

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread Sebastian Kügler
e good enough IMO to break out of the loop after like 8 icons. - Sebastian Kügler On Jan. 21, 2016, 2:26 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 126806: DragDropEvent: Add ignore() function

2016-01-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126806/#review91340 --- Ship it! Ship It! - Sebastian Kügler On Jan. 18, 2016

Re: Review Request 126740: Add a script for optimizing svgs

2016-01-14 Thread Sebastian Kügler
> On Jan. 14, 2016, 10:27 a.m., Marco Martin wrote: > > does the svg stuff still workk? > > this script goes well together the others i have (only in plasma-framework > > atm) to remove the hardcoded colors inkscape likes to put even when an > > element is using the stylesheet and the one to

Re: Review Request 126740: Add a script for optimizing svgs

2016-01-14 Thread Sebastian Kügler
t's a problem having non-optimized svgs in git, but we > should provide users whatever is easier to execute when we release. > > Sebastian Kügler wrote: > If we run this only on releases, it means that typically no developer > uses the final result of the icons. (I run master a

Re: Review Request 126740: Add a script for optimizing svgs

2016-01-14 Thread Sebastian Kügler
> On Jan. 14, 2016, 12:22 p.m., andreas kainz wrote: > > I have no problems to optimzie the svg files BUT my problem with the svg > > files is that they become more complex all the time last time the > > stylesheet, now optimization, > > > > I love scripts BUT it would be awesome for us

Re: KIOGui ?

2016-01-13 Thread Sebastian Kügler
On Wednesday, January 13, 2016 12:33:36 AM David Faure wrote: > The question is: this would only depend on KIOCore and QImage. Shall I put > it in KIOWidgets or shall I create a new KIOGui library, for QML apps to > avoid the QWidget dependency ? I'd use this in the angelfish (experimental)

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-11 Thread Sebastian Kügler
> On Jan. 11, 2016, 12:38 p.m., Sebastian Kügler wrote: > > autotests/coronatest.cpp, line 215 > > <https://git.reviewboard.kde.org/r/126672/diff/1/?file=429035#file429035line215> > > > > Do we really not want the C++11 for here? If we don't, I'd prefer >

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

2016-01-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90879 --- +1 from me, too. - Sebastian Kügler On Jan. 5, 2016, 11:16

Re: New to KDE

2016-01-07 Thread Sebastian Kügler
Hi shubham, On Thursday, January 07, 2016 06:05:06 PM shubham tibra wrote: > I would really like to contribute to KDE. I have coding experience in C and > C++ but I am new to open source community. I don't really know how to get > started. > > Can someone help me with it? Surely we can help!

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-07 Thread Sebastian Kügler
> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 190 > > <https://git.reviewboard.kde.org/r/126660/diff/1/?file=428735#file428735line190> > > > > What does the category have to do with this? We should only be goin

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-07 Thread Sebastian Kügler
> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 190 > > <https://git.reviewboard.kde.org/r/126660/diff/1/?file=428735#file428735line190> > > > > What does the category have to do with this? We should only be goin

Re: [Kde-hardware-devel] Review Request 126630: Do not unconditionally enable logging

2016-01-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126630/#review90719 --- Ship it! Ship It! - Sebastian Kügler On Jan. 5, 2016, 12

Re: [Kde-hardware-devel] Review Request 126630: Do not unconditionally enable logging

2016-01-05 Thread Sebastian Kügler
backend. - Sebastian Kügler On Jan. 5, 2016, 12:08 p.m., Peter Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

2016-01-04 Thread Sebastian Kügler
> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

2016-01-04 Thread Sebastian Kügler
e kpart.desktop file that KTextEditor was looking for is in > /share/kservicetypes5/. > > I added AppLocalData to get the path which is normally > "/bin/" for KDE aplications. I could also live with > KDE_INSTALL_FULL_KSERVICETYPES5DIR, but generally I would try to avoid > absolute paths ha

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2016-01-04 Thread Sebastian Kügler
> > be marked as required in top CMakeLists.tyt > > Sebastian Kügler wrote: > KF5Wayland is required in top-level CMakeLists.txt. Where did you see > that it isn't? > > Hrvoje Senjan wrote: > >find_package(KF5Wayland CONFIG) > > There's no REQUIR

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2016-01-04 Thread Sebastian Kügler
viewboard.kde.org/r/126381/#review90076 --- On Dec. 21, 2015, 11:46 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 126494: Add cross compile support for desktoptojson.

2016-01-04 Thread Sebastian Kügler
with it. (But also can't judge if it's obviously right.) Given the possible impact, I'd say go for it. - Sebastian Kügler On Dec. 23, 2015, 10:46 p.m., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 126348: Make it possible to provide the metadata in json

2015-12-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review90302 --- Ship it! Ship It! - Sebastian Kügler On Dec. 15, 2015, 3

Re: Review Request 126472: Don't always load the timetracker

2015-12-22 Thread Sebastian Kügler
be good to have documented. (Is that even English?) But then, where? - Sebastian Kügler On Dec. 22, 2015, 2:14 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-21 Thread Sebastian Kügler
marked as submitted. Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin. Changes --- Submitted with commit cc4de29cf24f06e51dbc7e221ccb89162be525d4 by Sebastian Kügler to branch master. Repository: libkscreen Description --- This adds a kwayland backend

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-21 Thread Sebastian Kügler
e.org/r/126381/#review89839 --- On Dec. 21, 2015, 11:46 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

2015-12-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126418/#review89816 --- Ship it! Ship It! - Sebastian Kügler On Dec. 18, 2015, 6

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-21 Thread Sebastian Kügler
everything. I also tested the kscreen UI, which also works as expected. Thanks, Sebastian Kügler ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-21 Thread Sebastian Kügler
change, fixed now. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89768 --- On Dec. 21, 2015, 1

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-21 Thread Sebastian Kügler
--- On Dec. 18, 2015, 3:16 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126381/ > -

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-21 Thread Sebastian Kügler
, visit: https://git.reviewboard.kde.org/r/126381/#review89770 --- On Dec. 18, 2015, 3:16 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To r

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-21 Thread Sebastian Kügler
- Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89769 ------- On Dec. 18, 2015, 3:16 p.m., Sebastian Kügler wrote: >

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-18 Thread Sebastian Kügler
e init list makes it harder to read, IMO. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89688 --- On

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-18 Thread Sebastian Kügler
server to test everything. I also tested the kscreen UI, which also works as expected. Thanks, Sebastian Kügler ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-18 Thread Sebastian Kügler
ptured, though. So I made it do that. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89681 -------

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-17 Thread Sebastian Kügler
everything. I also tested the kscreen UI, which also works as expected. Thanks, Sebastian Kügler ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-17 Thread Sebastian Kügler
s://git.reviewboard.kde.org/r/126381/#review89616 --- On Dec. 16, 2015, 2:05 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-17 Thread Sebastian Kügler
> On Dec. 16, 2015, 9:08 a.m., Martin Gräßlin wrote: > > backends/kwayland/waylandbackend.cpp, line 46 > > <https://git.reviewboard.kde.org/r/126381/diff/2/?file=423833#file423833line46> > > > > where does it get deleted? > >

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-16 Thread Sebastian Kügler
nd code. There is no need for this. What > > do you want to achieve? I can provide you the correct KWayland method to > > call. > > Sebastian Kügler wrote: > It hung and never arrived on the other side. I'll check again if it's > needed, and if so, will get back to you

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-16 Thread Sebastian Kügler
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89616 --- On Dec. 16, 2015, 2:05 a.m., Sebastian Kügler wrote: > > -

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-16 Thread Sebastian Kügler
ver arrived on the other side. I'll check again if it's needed, and if so, will get back to you. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89584

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

2015-12-16 Thread Sebastian Kügler
maintains knotifications. - Sebastian Kügler On Dec. 15, 2015, 7:44 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: [Kde-hardware-devel] Do we want to drop support for "enterprise" devices in plasma-nm applet?

2015-12-16 Thread Sebastian Kügler
zilla.gnome.org/show_bug.cgi?id=753369[2] > > And btw. gnome-shell also ignores those devices. > > What do you think? Sounds sensible to me. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ Kde-hard

Re: Review Request 126348: Make it possible to provide the metadata in json

2015-12-15 Thread Sebastian Kügler
> On Dec. 14, 2015, 9:50 p.m., Sebastian Kügler wrote: > > src/kpackage/private/packagejobthread.cpp, line 189 > > <https://git.reviewboard.kde.org/r/126348/diff/1/?file=422766#file422766line189> > > > > Why this change? > > Aleix Pol Gonzalez wrote:

[Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-15 Thread Sebastian Kügler
, Sebastian Kügler ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen

2015-12-15 Thread Sebastian Kügler
everything. I also tested the kscreen UI, which also works as expected. Thanks, Sebastian Kügler ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

2015-12-15 Thread Sebastian Kügler
aggressive. src/lib/plugin/kpluginmetadata.cpp (line 68) <https://git.reviewboard.kde.org/r/126366/#comment61279> I don't like the assert here. It may be third party data, and we're crashing the application then? - Sebastian Kügler On Dec. 15, 2015, 3:04 p.m., Aleix Pol Gonzalez

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-14 Thread Sebastian Kügler
. (If no one steps up within a week or so, please ship it.) src/lib/kaboutdata.cpp (line 823) <https://git.reviewboard.kde.org/r/126343/#comment61232> Unrelated, but doesn't match what we define as "KDE" anymore. - Sebastian Kügler On Dec. 14, 2015, 11:45 a.m., Alex

Re: Review Request 126348: Make it possible to provide the metadata in json

2015-12-14 Thread Sebastian Kügler
ude in its user). src/kpackage/private/packages.cpp (line 57) <https://git.reviewboard.kde.org/r/126348/#comment61257> Fix spelling of "Fuck" and make it a fatal error? ;) - Sebastian Kügl

Re: system tray test?

2015-12-11 Thread Sebastian Kügler
On Friday, December 11, 2015 12:19:51 PM René J.V. Bertin wrote: > Does KF5 provide any classes above Qt's for putting up and controlling an > icon (with/out menu) in the "system tray"? If so, is there a simple test > app I can try? > > Reason I'm asking: kwalletmanager5 isn't showing a systray

Re: Review Request 126246: Add test for dynamically changing file definitions

2015-12-11 Thread Sebastian Kügler
102) <https://git.reviewboard.kde.org/r/126246/#comment61112> ws (just because RB makes it totally red) autotests/packagestructuretest.cpp (line 108) <https://git.reviewboard.kde.org/r/126246/#comment61113> seems unnecessary? - Sebastian Kügler On Dec. 4, 2015, 6:23

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-07 Thread Sebastian Kügler
On Friday, December 04, 2015 11:28:03 AM Jan Kundrát wrote: > On Friday, 4 December 2015 10:56:42 CET, Ben Cooksley wrote: > > Note that in the long run with DMARC looming you will need to switch > > to #2 anyway, and keeping your current behaviour will likely lead to > > mail from people who use

Review Request 126226: kdetemplate_add_app_templates installs previews

2015-12-02 Thread Sebastian Kügler
Diff: https://git.reviewboard.kde.org/r/126226/diff/ Testing --- Installed templates/ from plasma-framework, this patch makes them work in kapptemplate. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: [Kde-hardware-devel] Review Request 126138: Use absolute brightness value in conservative check when loading profile

2015-11-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126138/#review88723 --- Ship it! Ship It! - Sebastian Kügler On Nov. 22, 2015, 3

Re: [Kde-hardware-devel] Review Request 126101: allow loading backends in-process

2015-11-23 Thread Sebastian Kügler
marked as submitted. Review request for Plasma, Solid, Àlex Fiestas, Aleix Pol Gonzalez, Daniel Vrátil, and Martin Gräßlin. Changes --- Submitted with commit 3382bba2b403f82f3e21e4a89a6631781e5950fe by Sebastian Kügler to branch master. Repository: libkscreen Description

Re: Review Request 126119: remove unused platformstatus kded

2015-11-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126119/#review88618 --- Ship it! Ship It! - Sebastian Kügler On Nov. 19, 2015, 4

Re: [Kde-hardware-devel] Review Request 126101: allow loading backends in-process

2015-11-17 Thread Sebastian Kügler
: https://git.reviewboard.kde.org/r/126101/diff/ Testing --- Added a ton of autotests, made sure all existing ones pass. tried "KSCREEN_BACKEND_INPROCESS=1 kcmshell5 kscreen", all working as expected. Thanks, Sebastian Kügler ___ Kde-hard

Re: [Kde-hardware-devel] Review Request 126101: allow loading backends in-process

2015-11-17 Thread Sebastian Kügler
n the way of a running server. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/#review88502 ------- On Nov.

Re: Review Request 126084: Small KDeclarative cleanup

2015-11-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126084/#review88420 --- Ship it! Ship It! - Sebastian Kügler On Nov. 16, 2015, 11

Re: Review Request 126004: add symlink verification tech

2015-11-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126004/#review88189 --- Ship it! Good stuff! - Sebastian Kügler On Nov. 9, 2015

Re: Review Request 125976: add an update() method

2015-11-09 Thread Sebastian Kügler
disk (though this should probably not say harddisk, but filesystem) src/kpackage/package.h (line 99) <https://git.reviewboard.kde.org/r/125976/#comment60483> -(from the hard disk) Nice. - Sebastian Kügler On Nov. 9, 2015, 2:40 p.m.,

Re: Review Request 125976: add an update() method

2015-11-07 Thread Sebastian Kügler
e API, OK, but the code here is getting really convoluted that I think another boolean trap won't help... src/kpackage/private/versionparser.cpp (line 25) <https://git.reviewboard.kde.org/r/125976/#comment60462> I think we can remove most of these includes? - S

Re: Review Request 125750: Reduce some allocations

2015-10-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125750/#review87237 --- Ship it! Ship It! - Sebastian Kügler On Oct. 22, 2015, 2

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

2015-10-06 Thread Sebastian Kügler
and I personally think it's a useful thing.) -- sebas Sebastian Kügler | http://vizZzion.org | http://kde.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125527: Add mimeTypes() to KPluginMetaData

2015-10-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125527/#review86417 --- Ship it! Ship It! - Sebastian Kügler On Oct. 6, 2015, 10

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

2015-09-18 Thread Sebastian Kügler
> On Sept. 16, 2015, 9:44 p.m., Sebastian Kügler wrote: > > autotests/kpluginmetadatatest.cpp, line 110 > > <https://git.reviewboard.kde.org/r/125261/diff/1/?file=404287#file404287line110> > > > > Should be a list, so enclosed with [ ]. > > &

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

2015-09-16 Thread Sebastian Kügler
. autotests/kpluginmetadatatest.cpp (line 110) <https://git.reviewboard.kde.org/r/125261/#comment59108> Should be a list, so enclosed with [ ]. In the header docs, you also say "string", so maybe I'm overlooking something? - Sebastian Kügler On Sept. 16, 2015,

Re: [kde-community] Phabricator: Make it happen already!

2015-08-27 Thread Sebastian Kügler
On Wednesday, August 26, 2015 20:57:25 Jaroslaw Staniek wrote: +1 (I am using it as if it was official) Same here. The Plasma team is in the process of migrating to phaaab! already. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

Re: Review Request 124846: i18n: Fix untranslatable string

2015-08-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124846/#review84260 --- Ship it! Ship It! - Sebastian Kügler On Aug. 24, 2015, 10

Re: Modular startkde proof of concept

2015-08-20 Thread Sebastian Kügler
On Thursday, August 20, 2015 11:31:57 Helio Chissini de Castro wrote: We ( aka's distros ) been patching startkde for years due obvious particular things oriented to the specific distro. Believe or not, is always an issue, since systems changes, and changed a lot in this years. So, in a

Re: Plasma Applet for Audio Volume for kdereview

2015-08-17 Thread Sebastian Kügler
I think we should be peachy now. Can plasma-pa be moved from kdereview to kde/workspace? On Wednesday, August 05, 2015 12:45:01 Jonathan Riddell wrote: plasma-pa is a new volume manager and is intended to be a replacement for KMix in Plasma. We plan to ship it as a beta in Plasma 5.4 and

Re: Documentation (was Re: Plasma Applet for Audio Volume for kdereview)

2015-08-12 Thread Sebastian Kügler
On Wednesday, August 12, 2015 12:20:29 Luigi Toscano wrote: On Wednesday 12 of August 2015 10:05:34 Sebastian Kügler wrote: Also, the Evolve survey was pretty clear that we utterly suck in the documentation arena. Playing with words doesn't solve that, writing documentation and maintaining

Re: Plasma Applet for Audio Volume for kdereview

2015-08-12 Thread Sebastian Kügler
On Wednesday, August 12, 2015 21:49:43 Ben Cooksley wrote: On Wed, Aug 12, 2015 at 12:02 PM, David Edmundson da...@davidedmundson.co.uk wrote: We've had it marked as hard requirement for a long time in https://techbase.kde.org/Policies/Application_Lifecycle But it's true that Plasma

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread Sebastian Kügler
marked as submitted. Review request for KDE Frameworks, Plasma, Alex Richardson, and David Faure. Changes --- Submitted with commit 6d82a824b3a7e5e87b4691439ecba064a75fa8a1 by Sebastian Kügler to branch master. Repository: kservice Description --- Parse formfactor in KService

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread Sebastian Kügler
robust. About ksycocathreadtest: I just pushed many fixes for it, does it pass for you now? Sebastian Kügler wrote: My primary concern was to make sure FormFactors is not lost in conversion. Adding API in KPluginInfo was more a side-effect of this (for symmetry reasons

Re: Plasma Applet for Audio Volume for kdereview

2015-08-11 Thread Sebastian Kügler
On Monday, August 10, 2015 19:40:34 Sebastian Kügler wrote: On Monday, August 10, 2015 20:37:26 Albert Astals Cid wrote: El Dilluns, 10 d'agost de 2015, a les 10:35:48, Sebastian Kügler va escriure: On Thursday, August 06, 2015 22:56:09 Luigi Toscano wrote: Is this a hard requirement

Re: Plasma Applet for Audio Volume for kdereview

2015-08-10 Thread Sebastian Kügler
On Thursday, August 06, 2015 12:25:32 Burkhard Lück wrote: Am Donnerstag, 6. August 2015, 00:40:41 schrieb Albert Astals Cid: Missing or not so good i18n ./src/kcm/package/contents/ui/VolumeSlider.qml:84:text: Math.floor(slider.value / slider.maximumValue * 100.0) + %

Re: Plasma Applet for Audio Volume for kdereview

2015-08-10 Thread Sebastian Kügler
On Sunday, August 09, 2015 14:59:59 Dāvis Mosāns wrote: 2015-08-05 15:45 GMT+03:00 Jonathan Riddell j...@jriddell.org: plasma-pa is a new volume manager and is intended to be a replacement for KMix in Plasma. We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview for

Re: Plasma Applet for Audio Volume for kdereview

2015-08-10 Thread Sebastian Kügler
On Thursday, August 06, 2015 22:56:09 Luigi Toscano wrote: Jonathan Riddell ha scritto: plasma-pa is a new volume manager and is intended to be a replacement for KMix in Plasma. We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview for your reviewing attention.

Re: Plasma Applet for Audio Volume for kdereview

2015-08-06 Thread Sebastian Kügler
On Thursday, August 06, 2015 00:40:41 Albert Astals Cid wrote: Missing or not so good i18n ./src/kcm/package/contents/ui/VolumeSlider.qml:84:text: Math.floor(slider.value / slider.maximumValue * 100.0) + % ./src/kcm/package/contents/ui/VolumeSlider.qml:90:text: 100%

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-06 Thread Sebastian Kügler
--- On Aug. 5, 2015, 10:41 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633

Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-05 Thread Sebastian Kügler
(also in master without this patch). Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Help wanted to evolve KDEs music players

2015-07-31 Thread Sebastian Kügler
seems like going back to the past. On the other hand, if I could get a modern interface and well designed interface for spotify which I can run on my desktop, laptop and phone and stream via bluetooth to a hifi set, I'd be happy. -- sebas Sebastian Kügler|http://vizZzion.org| http

Re: Qt version requirement in KF 5.13

2015-07-29 Thread Sebastian Kügler
?), and by the fact that Qt 5.3 was released more than a year ago. +1 -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Alternative of Plasma::IconWidget

2015-07-20 Thread Sebastian Kügler
On Sunday, July 19, 2015 19:29:56 Aroonav Mishra wrote: I am involved in porting Amarok to Qt5/KF5 and I couldn't find any documentation regarding the removal of Plasma::IconWidget from the API. So can someone please suggest the alternative of Plasma::IconWidget in Plasma 5 ?

Re: Review Request 124306: Don't choke on empty QIconItem

2015-07-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/#review82276 --- Ship it! Ship It! - Sebastian Kügler On July 9, 2015, 2

<    1   2   3   4   5   6   7   8   9   >