Re: Review Kid3

2020-02-25 Thread Urs Fleisch
> The usage of bugzilla is not under discussion right now for any project. I have now switched to bugzilla in the code and on the web site.

Re: Review Kid3

2020-02-23 Thread Urs Fleisch
>> Right. Urs, could you please request creation of a bugzilla product? Then could someone please tell me how to request creation of a bugzilla product? I could not find such an option on https://bugs.kde.org/.

Re: Review Kid3

2020-02-18 Thread Urs Fleisch
Hi Christoph, >> You should change the bug reporting to use bugzilla not your email address in KAboutData > > Right. Urs, could you please request creation of a bugzilla product? I discussed the migration of the existing bug reports, feature requests and help form items with Jonathan, and we agre

Re: Review Kid3

2020-02-18 Thread Urs Fleisch
Hi Albert, > You don't need all that > echo "Extracting po/en/kid3_qt.po" > part, scripty just does it every single day for you I saw that an English po is now generated and downloaded when using translations/download-pos.sh. In this case the file po/en/kid3_qt.po already exists and the "Extracti

Re: Review Kid3

2020-02-17 Thread Urs Fleisch
> tr("%n files", "", m_fileCount) > And if you know, how do you solve it? Thanks, Albert, this was in fact a problem. I have now read https://community.kde.org/Frameworks/Frameworks_Localization_Policy and fixed it accordingly, see https://invent.kde.org/kde/kid3/commit/723218fa6fdda2caeba7179d666

Re: Review Kid3

2020-02-14 Thread Urs Fleisch
> lupdate is complaining about singular messages > > ../src/gui/forms/basemainwindow.cpp:639: '%n folders' message is missing '//~ singular' comment > ../src/gui/forms/basemainwindow.cpp:639: '%n folders' message is missing '//~ plural' comment > ../src/gui/forms/basemainwindow.cpp:642: '%n files'

Re: Review Kid3

2020-02-14 Thread Urs Fleisch
> Short legal review: > (..) > Please add the missing licenses files to the root folder. > If possible, also add BSD license headers to your FindXXX.cmake files. Thanks for looking at this, it is now fixed [f8ef0d60].

Re: Review Kid3

2020-02-13 Thread Urs Fleisch
> Is there a way to subscribe to bugs reported there? Another possibility is to click on the bell icon near the top on the project web site. In the drop-down you can select "Watch". Regards, Urs

Review Kid3

2020-02-12 Thread Urs Fleisch
Hello everybody, As you may know, Kid3, an audio tagger, has moved from SourceForge.net to kde.org. Jonathan Riddell is attending the incubation process as a sponsor. To complete the incubation, I would kindly ask you to execute a KDE review on the project. Website: https://kid3.kde.org/ Git, Iss