Re: Q_ASSERT(!FalseSecurity)

2018-03-12 Thread Michael Heidelbach
Got it. Thanks to you all, Michael On 10.03.2018 10:53, Albert Astals Cid wrote: El dissabte, 10 de març de 2018, a les 10:37:12 CET, Sven Brauch va escriure: Hi, On 03/10/2018 09:53 AM, Michael Heidelbach wrote: Am I getting something wrong? Or is "Q_ASSERT(m_writeTrans);

Re: Q_ASSERT(!FalseSecurity)

2018-03-11 Thread Thiago Macieira
On Saturday, 10 March 2018 00:53:24 PDT Michael Heidelbach wrote: > Hi! > > Am I getting something wrong? Or is > > "Q_ASSERT(m_writeTrans); > > m_writeTrans->commit();" > > providing false security? This is not false security. It's not security, period. You use a Q_ASSERT when a

Re: Q_ASSERT(!FalseSecurity)

2018-03-10 Thread Albert Astals Cid
El dissabte, 10 de març de 2018, a les 10:37:12 CET, Sven Brauch va escriure: > Hi, > > On 03/10/2018 09:53 AM, Michael Heidelbach wrote: > > Am I getting something wrong? Or is > > > >"Q_ASSERT(m_writeTrans); > > > >m_writeTrans->commit();" > > > > providing false security? > > a lot

Re: Q_ASSERT(!FalseSecurity)

2018-03-10 Thread Sven Brauch
Hi, On 03/10/2018 09:53 AM, Michael Heidelbach wrote: > Am I getting something wrong? Or is > >    "Q_ASSERT(m_writeTrans); > >    m_writeTrans->commit();" > > providing false security? a lot of KDE code is written this way. It will end up crashing in both debug and release, but in debug the

Re: Q_ASSERT(!FalseSecurity)

2018-03-10 Thread James Augustus Zuccon
Good pickup - I'm not sure of the answer but my interpretation of it is the same as yours. Here's a StackOverflow thread that might be good reference for anyone else that wants to chime in: https://stackoverflow.com/questions/12573230/q-assert-release-build-semantics#12573446 Cheers! On Sat,

Q_ASSERT(!FalseSecurity)

2018-03-10 Thread Michael Heidelbach
Hi! Am I getting something wrong? Or is "Q_ASSERT(m_writeTrans); m_writeTrans->commit();" providing false security? Shouldn't it better be "Q_ASSERT(m_writeTrans); if (m_writeTrans) {     m_writeTrans->commit(); ? Baloo's code is full of Q_ASSERTs that have no