El dijous, 11 de juliol de 2019, a les 16:18:08 CEST, David Edmundson va
escriure:
> One topic discussed at the recent Plasma sprint was that we should run
> a code formatting tool (clang-format) over all our repos to ease all
> future review comments about whitespace.
>
> All new contributions
> There's one comment about constructor initialisers, which seems resolvable.
If that solvable, then it's great. I'm in favour of this idea, maybe
even extend to frameworks repos?
> So if there's anything else, then yes, please be more specific.
No, so far that was the only problem we've
>Aren't the problems described in task
https://phabricator.kde.org/T11214 specific enough?
There's one comment about constructor initialisers, which seems resolvable.
So if there's anything else, then yes, please be more specific.
If we find we we can't do this until we get some more features
Aren't the problems described in task
https://phabricator.kde.org/T11214 specific enough?
сб, 13 июл. 2019 г. в 14:18, Vlad Zagorodniy :
> Can you be more specific about it? What parts of the kdelibs/Frameworks
> coding style can't be implemented/enforced with clang-format?
>
On 7/13/19 1:01 AM, Allan Sandfeld Jensen wrote:
I would argue against it. clang-format is extremely primitive and stupid, it
can't implement KDE or Qt coding styles or anything close to i
Can you be more specific about it? What parts of the kdelibs/Frameworks
coding style can't be
On Donnerstag, 11. Juli 2019 16:18:08 CEST David Edmundson wrote:
> One topic discussed at the recent Plasma sprint was that we should run
> a code formatting tool (clang-format) over all our repos to ease all
> future review comments about whitespace.
>
> All new contributions simply have to run
> Presumably this would impose a common coding style throughout all KDE
> repositories? Or would each project be able to specify its own clang-format
> configuration? In past discussions about KDE coding style, it was accepted
> that
> while Frameworks and PIM libraries would adopt a common
Am 2019-07-11 16:18, schrieb David Edmundson:
One topic discussed at the recent Plasma sprint was that we should run
a code formatting tool (clang-format) over all our repos to ease all
future review comments about whitespace.
All new contributions simply have to run the same tool and we get
On Thu, Jul 11, 2019 at 3:32 PM alcinos wrote:
>
> Hi,
>
> Just to mention that we have a .clang-format in Kdenlive as well
> (https://invent.kde.org/kde/kdenlive/blob/master/.clang-format)
Oh awesome, do you mind if I ask some questions?
Did running it across the base cause any issues?
Did it
Hi,
Just to mention that we have a .clang-format in Kdenlive as well (
https://invent.kde.org/kde/kdenlive/blob/master/.clang-format)
I designed it so that it would be consistent but match rather closely the
dominant style in the code-base at the time I wrote it.
Unfortunately, we don't
Hi,
I like the idea a lot and I would love to do the same for the websites.
Probably using tools like [PHP Coding Standards Fixer](https://cs.symfony.com/).
Cheers,
Carl
‐‐‐ Original Message ‐‐‐
On Thursday 11 July 2019 16:18, David Edmundson
wrote:
> One topic discussed at the
Hi David,
On 7/11/19 4:18 PM, David Edmundson wrote:
One topic discussed at the recent Plasma sprint was that we should run
a code formatting tool (clang-format) over all our repos to ease all
future review comments about whitespace.
All new contributions simply have to run the same tool and
One topic discussed at the recent Plasma sprint was that we should run
a code formatting tool (clang-format) over all our repos to ease all
future review comments about whitespace.
All new contributions simply have to run the same tool and we get
consistent code without having to comment on every
13 matches
Mail list logo
