Re: RSIBreak / KIdleTime on Wayland

2020-11-16 Thread Dominik Waurenschk
> > Yes, I meant that progress bar. > > I've had that 1s idle timer idea as well, unfortunately after writing this, > > but thank you for confirming that this would indeed work. > > I will give that a try and if I can get RSIBreak to a working state on > > wayland submit a PR for it. > >

Re: RSIBreak / KIdleTime on Wayland

2020-11-16 Thread Dominik Waurenschk
> > 2. It works with XWayland, but only detects user activity if the user > > makes an input to an XWayland window. > Yeah, that's expected. We only send things to X when an X app has focus. > Changing this behaviour is not an option. I don't think this is a viable > setup option to support. >

Re: RSIBreak / KIdleTime on Wayland

2020-11-16 Thread Dominik Waurenschk
> > 2. It works with XWayland, but only detects user activity if the user > > makes an input to an XWayland window. > Yeah, that's expected. We only send things to X when an X app has focus. > Changing this behaviour is not an option. I don't think this is a viable > setup option to support. >

Re: RSIBreak / KIdleTime on Wayland

2020-11-16 Thread Dominik Waurenschk
> > Yes, I meant that progress bar. > > I've had that 1s idle timer idea as well, unfortunately after writing this, > > but thank you for confirming that this would indeed work. > > I will give that a try and if I can get RSIBreak to a working state on > > wayland submit a PR for it. > >

Re: RSIBreak / KIdleTime on Wayland

2020-11-16 Thread David Edmundson
change made: https://invent.kde.org/plasma/kwayland-server/-/merge_requests/133

Re: RSIBreak / KIdleTime on Wayland

2020-11-16 Thread David Edmundson
change made: https://invent.kde.org/plasma/kwayland-server/-/merge_requests/133

Re: RSIBreak / KIdleTime on Wayland

2020-11-16 Thread David Edmundson
>If the user was idle for a second (using a KIdleTime timeout), I start my own >idle time counter (counter++ every second). >Then I catch the next resume event (next user input) and reset my counter to 0. That sounds like what I had in mind. > 2) It works with XWayland, but only detects user

Re: RSIBreak / KIdleTime on Wayland

2020-11-16 Thread David Edmundson
>If the user was idle for a second (using a KIdleTime timeout), I start my own >idle time counter (counter++ every second). >Then I catch the next resume event (next user input) and reset my counter to 0. That sounds like what I had in mind. > 2) It works with XWayland, but only detects user

Re: RSIBreak / KIdleTime on Wayland

2020-11-15 Thread Dominik Waurenschk
> > > So do you think it makes sense to have the function return some form or > > > error instead of just returning 0, or is there a good reason it is not > > > doing that already? > I don't think it helps with a lot, you need to change clients to > handle the error, at which point we've not

Re: RSIBreak / KIdleTime on Wayland

2020-11-15 Thread Dominik Waurenschk
> > > So do you think it makes sense to have the function return some form or > > > error instead of just returning 0, or is there a good reason it is not > > > doing that already? > I don't think it helps with a lot, you need to change clients to > handle the error, at which point we've not

Re: RSIBreak / KIdleTime on Wayland

2020-11-15 Thread David Edmundson
> > Yes, I meant that progress bar. > I've had that 1s idle timer idea as well, unfortunately after writing this, > but thank you for confirming that this would indeed work. > I will give that a try and if I can get RSIBreak to a working state on > wayland submit a PR for it. Excellent, thank

Re: RSIBreak / KIdleTime on Wayland

2020-11-15 Thread David Edmundson
> > Yes, I meant that progress bar. > I've had that 1s idle timer idea as well, unfortunately after writing this, > but thank you for confirming that this would indeed work. > I will give that a try and if I can get RSIBreak to a working state on > wayland submit a PR for it. Excellent, thank

Re: RSIBreak / KIdleTime on Wayland

2020-11-15 Thread David Edmundson
> I agree, if we can't make the KIdleTime framework work in Wayland there > should be a way to query the framework if it's going to work or not. Just to make sure that's not misread by others; the framework works for the majority of methods used in the common case, just not this one polling

Re: RSIBreak / KIdleTime on Wayland

2020-11-15 Thread David Edmundson
> I agree, if we can't make the KIdleTime framework work in Wayland there > should be a way to query the framework if it's going to work or not. Just to make sure that's not misread by others; the framework works for the majority of methods used in the common case, just not this one polling

Re: RSIBreak / KIdleTime on Wayland

2020-11-15 Thread Albert Astals Cid
El dissabte, 14 de novembre de 2020, a les 12:46:41 CET, Dominik Waurenschk va escriure: > Hi, I just came across the issue that RSIBreak is unable to count down in > wayland, after 1 second it always resets its timer. > > I investigated the code and found that it calls KIdleTime, which in turn

Re: RSIBreak / KIdleTime on Wayland

2020-11-15 Thread Albert Astals Cid
El dissabte, 14 de novembre de 2020, a les 12:46:41 CET, Dominik Waurenschk va escriure: > Hi, I just came across the issue that RSIBreak is unable to count down in > wayland, after 1 second it always resets its timer. > > I investigated the code and found that it calls KIdleTime, which in turn

RSIBreak / KIdleTime on Wayland

2020-11-14 Thread Dominik Waurenschk
Hi, I just came across the issue that RSIBreak is unable to count down in wayland, after 1 second it always resets its timer. I investigated the code and found that it calls KIdleTime, which in turn calls a platform-specific plugin. In particular, it calls forcePollRequest() to get the