Re: Review Request 128664: Nested tags for Baloo

2017-02-19 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/#review102559 --- Awesome, thanks :-) - Boudhayan Gupta On Feb. 20, 2017,

Re: Review Request 128664: Nested tags for Baloo

2017-02-15 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/ --- (Updated Feb. 15, 2017, 1:26 p.m.) Review request for Baloo and

Re: Review Request 128664: Nested tags for Baloo

2017-02-06 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/ --- (Updated Feb. 6, 2017, 5:44 p.m.) Review request for Baloo and Boudhayan

Re: Review Request 128664: Nested tags for Baloo

2017-02-05 Thread Boudhayan Gupta
> On Sept. 23, 2016, 2:46 p.m., Boudhayan Gupta wrote: > > Diff looks sane to me, and the feature seems useful in theory. > > > > Will this require a reindexing? Seems to me from previous comments made by > > vHanda that there's a schema change involved? > > James Smith wrote: > Yes. The

Re: Review Request 128664: Nested tags for Baloo

2016-12-01 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/ --- (Updated Dec. 1, 2016, 7:04 p.m.) Review request for Baloo and Boudhayan

Re: Review Request 128664: Nested tags for Baloo

2016-10-09 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/ --- (Updated Oct. 9, 2016, 11:34 p.m.) Review request for Baloo and

Re: Review Request 128664: Nested tags for Baloo

2016-09-23 Thread Boudhayan Gupta
> On Sept. 23, 2016, 2:46 p.m., Boudhayan Gupta wrote: > > Diff looks sane to me, and the feature seems useful in theory. > > > > Will this require a reindexing? Seems to me from previous comments made by > > vHanda that there's a schema change involved? > > James Smith wrote: > Yes. The

Re: Review Request 128664: Nested tags for Baloo

2016-09-22 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/ --- (Updated Sept. 22, 2016, 6:41 p.m.) Review request for Baloo and

Re: Review Request 128664: Nested tags for Baloo

2016-09-07 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/ --- (Updated Sept. 8, 2016, 3:01 a.m.) Review request for Baloo and Vishesh

Re: Review Request 128664: Nested tags for Baloo

2016-09-07 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/ --- (Updated Sept. 7, 2016, 9:01 p.m.) Review request for Baloo and Vishesh

Re: Review Request 128664: Nested tags for Baloo

2016-09-07 Thread James Smith
> On Sept. 4, 2016, 9:51 a.m., Vishesh Handa wrote: > > Please test out all possible workflows. Ideally it would be great if we > > could have automated tests for all the workflows with tags. The only thing that could impact the existing workflow is a new hard length of 64. The new FT prefix

Re: Review Request 128664: Nested tags for Baloo

2016-09-04 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/#review98860 --- Please test out all possible workflows. Ideally it would be

Re: Review Request 128664: Nested tags for Baloo

2016-08-20 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/ --- (Updated Aug. 20, 2016, 10:58 p.m.) Review request for Baloo and Vishesh

Re: Review Request 128664: Nested tags for Baloo

2016-08-19 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/#review98494 --- This is quite an interesting change. Could you please also

Review Request 128664: Nested tags for Baloo

2016-08-17 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/ --- Review request for Baloo. Bugs: 334615