D11960: Support nvidia reset notifications in QtQuickViews

This revision was automatically updated to reflect the committed changes. Closed by commit R296:2b0a68b70e71: Support nvidia reset notifications in QtQuickViews (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D11452: sanitizer: Improve device listing

michaelh updated this revision to Diff 31791. michaelh added a comment. - Optimize device listing even more REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11452?vs=31773=31791 BRANCH sanitize-devices (branched from master) REVISION DETAIL

Upcoming CI changes - service disruption

Hi all, In order to allow for two replacement physical build hosts to be rotated in and the old ones to be decommissioned, i'm scheduling some downtime for both the CI system and the Binary Factory tomorrow. Assuming all goes well, this downtime should be fairly short. During the downtime

Upcoming CI changes - service disruption

Hi all, In order to allow for two replacement physical build hosts to be rotated in and the old ones to be decommissioned, i'm scheduling some downtime for both the CI system and the Binary Factory tomorrow. Assuming all goes well, this downtime should be fairly short. During the downtime

D12082: Don't offer qml plugin as a link target

leinir created this revision. leinir added reviewers: Frameworks, KNewStuff. leinir added a project: KNewStuff. Restricted Application added a project: Frameworks. leinir requested review of this revision. REVISION SUMMARY This removes the KNSQuick plugin as a link target for cmake. It was

D10702: Always use a job to delete files to avoid freezing process waiting on IO

jtamate added a comment. This freezing process happens for me in ktorrent the first time in a day I delete a file, but not the files after, even if they are iso images (>4GiB). Are we sure the problem is here and not in the notification step, for example loading the sound data and starting

Upcoming CI changes - service disruption

Hi all, In order to allow for two replacement physical build hosts to be rotated in and the old ones to be decommissioned, i'm scheduling some downtime for both the CI system and the Binary Factory tomorrow. Assuming all goes well, this downtime should be fairly short. During the downtime

D11786: Fix returning of data in the helper example

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R283:de225f87ae11: Fix returning of data in the helper example (authored by volkov). REPOSITORY R283 KAuth CHANGES

D12064: Don't alter memory management to hide an item

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D12064 To: davidedmundson, #plasma, mart Cc: rikmills, #frameworks, michaelh,

D11675: use KDE_INSTALL_DATADIR instead of FULL_DATADIR

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. If no-one else can be bothered, here my shipit. REPOSITORY R290 KPackage BRANCH usedatadir REVISION DETAIL https://phabricator.kde.org/D11675 To: bshah, kossebau Cc:

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham added a comment. To elaborate, the open/save dialog has four view modes: - Simple View: what most other platforms would calll "Icons view". Can be configured to have the icons to the left side of the labels (Windows style), or above them (macOS, GNOME, Cinnamon, XFCE,

D11745: databasesanitizer: Use flags for filtering

michaelh updated this revision to Diff 31811. michaelh added a comment. - Improve printList summary REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=31807=31811 BRANCH sanitize-enums (branched from master) REVISION DETAIL

D12064: Don't alter memory management to hide an item

This revision was automatically updated to reflect the committed changes. Closed by commit R242:2785916d01b2: Dont alter memory management to hide an item (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/101/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 10 Apr 2018 13:39:13 + Build duration: 3 min 55 sec and counting

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: mmustac, broulik, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: mmustac, broulik, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham added a comment. In D12077#243556 , @broulik wrote: > Can we arrange them so that they're more consistent with Dolphin? i.e. put the Preview button at right-most Sure! F5802899: Like this.png

D11745: databasesanitizer: Use flags for filtering

michaelh updated this revision to Diff 31807. michaelh marked 2 inline comments as done. michaelh added a comment. - Adapt to upstream changes - Correct enum - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=31365=31807

D11745: databasesanitizer: Use flags for filtering

michaelh marked 4 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11745 To: michaelh, #baloo, #frameworks Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, alexeymin

D11948: [KFileWidget] Hardcode example user name

broulik added a comment. Ping, if no one objects I'll push this once next FW is released REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11948 To: broulik, #frameworks Cc: elvisangelaccio, michaelh, ngraham, bruns

Re: bugs.kde.org: kio vs frameworks-kio vs kfile etc.

Yep, just got my permissions, and I've pinged David Faure regarding the proposed changes. Nate On Mon, 09 Apr 2018 14:42:11 -0700 David Edmundson wrote > > ​> Should we mark kio and kfile as not accepting new bugs, add some more > components to

D11948: [KFileWidget] Hardcode example user name

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. Makes sense to me. Go for it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11948 To: broulik, #frameworks, kfunk Cc: kfunk, elvisangelaccio, michaelh, ngraham, bruns

D12095: convert setDirLister to the new connect syntax

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY The only tricky part is the use of QOverload<>::of to distinguish between signals with same name but

D11745: databasesanitizer: Use flags for filtering

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:116 > if ((!includeIds.isEmpty() && > !includeIds.contains(info.deviceId)) > || (!excludeIds.isEmpty() && > excludeIds.contains(info.deviceId)) > || (urlFilter &&

D11745: databasesanitizer: Use flags for filtering

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:134 > +map.size() - ignoredCount - accessibleCount > +)}; > } I'm not content with this solution. Still, it's the best I could do without bloating the code too much. >

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham updated this revision to Diff 31813. ngraham added a comment. Also move the Preview button over to the right, so it doesn't compete with the view mode buttons REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=31779=31813 BRANCH

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/126/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 10 Apr 2018 13:39:13 + Build duration: 8 min 42 sec and counting

D12082: Don't offer qml plugin as a link target

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D12082 To: leinir, #frameworks, #knewstuff, apol Cc: michaelh, ZrenBot, ngraham, bruns

D12045: Clean up existing documentation

ngraham added a comment. Sorry, not aware of a better workflow for now, but yeah, this does not seem ideal. Perhaps real-time chat would be better, during a time when everyone's available. INLINE COMMENTS > michaelh wrote in README.md:36 > "Baloo is developed and tested exclusively for

D11733: Allow opening items from the open/save dialogs

ngraham abandoned this revision. ngraham added a comment. After thinking about this for a few weeks, I can't imagine and haven't seen a use case for using the Open File dialog to open the file in a different app that wouldn't be better served in another way. REPOSITORY R241 KIO REVISION

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze Cc: abetts, sharvey, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added a reviewer: Frameworks. ngraham edited subscribers, added: Dolphin; removed: Frameworks. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks Cc: #dolphin, cfeck, fabiank, broulik, michaelh,

D12097: Make room for footer and header.

hein created this revision. hein added reviewers: Kirigami, mart. Restricted Application added projects: Kirigami, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. hein requested review of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION

D12095: convert setDirLister to the new connect syntax

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Should remove the private slot declaration? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12095 To: jtamate, dfaure, #frameworks, apol Cc: apol, michaelh, ngraham,

D12045: Clean up existing documentation

michaelh added inline comments. INLINE COMMENTS > ngraham wrote in README.md:36 > I think the original paragraph was fine, but needed a bit of cleanup and > grammar work. How's this? > > "We recommend not packaging Baloo for Windows or macOS, as both these > operating systems offer their own

D11851: Add syntax highlighting for Logcat

nibags added a comment. Everything is ready. But my account is not developer and I do not have permission to push it to the repository. REPOSITORY R216 Syntax Highlighting BRANCH add-logcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D11851 To: nibags,

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D12034: Use the more appropriate "two sliders" icon for "configure"

hein added a comment. In D12034#244019 , @hein wrote: > In principle I totally agree with this, but I'm not sure about the `input-keyboard` icon it extends to. Do you know where it's used currently? It's sometimes even used as window

D12034: Use the more appropriate "two sliders" icon for "configure"

hein added a comment. In principle I totally agree with this, but I'm not sure about the `input-keyboard` icon it extends to. Do you know where it's used currently? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze Cc:

D11984: Android: Explicitly point at upstream documentation and deprecate duplicated concepts

apol added a comment. ping-o REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D11984 To: apol, #build_system, #frameworks Cc: michaelh, ngraham, bruns

D12097: Make room for footer and header.

hein added a dependent revision: D12102: Port Language KCM to Qt Quick. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12097 To: hein, #kirigami, mart Cc: plasma-devel, #frameworks, michaelh, ngraham, bruns, apol, davidedmundson, mart, hein

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. Is that "three sliders" icon one we already have, or did you just mock it up? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze Cc: bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

bruns added a comment. Thats a new one REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze Cc: bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12016: [ktexteditor] much faster positionFromCursor

mwolff added a comment. some nits, otherwise lgtm assuming all tests pass bonus points for a proper benchmark that shows the before/after gain in hard numbers INLINE COMMENTS > kateviewaccessible.h:191 > { > -int pos = 0; > -for (int line = 0; line < cursor.line();

D12034: Use the more appropriate "two sliders" icon for "configure"

bruns added a comment. +1 for making it more consistent ... For the design - how about this one (Shortcuts - old, Toolbars - new)? F5803306: Screenshot_20180410_224347.png REPOSITORY R266 Breeze Icons REVISION DETAIL

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. If we're proposing new icons, what I'd like to see is a "base" configure iconography that you can add other things to. For example, if we use a base "two sliders" icon for "configure", then... - "Configure shortcuts" would have one of the sliders replaced with a

D12045: Clean up existing documentation

michaelh added inline comments. INLINE COMMENTS > michaelh wrote in README.md:36 > For FreeBSD everything is built, test are run in CI and pass. For Windows > it's a stub: Only KF5Baloo.dll and KF5BalooEngine.dll. OSX? > > "Baloo is developed and tested exclusively for Linux and FreeBSD. While

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

broulik added a comment. Can we arrange them so that they're more consistent with Dolphin? i.e. put the Preview button at right-most REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: broulik, michaelh, ngraham, bruns

D12071: add a new ConstrainedSquare formfactor

apol added inline comments. INLINE COMMENTS > plasma.h:89 > for the desktop or the particular device. */ > +ConstrainedSquare /**When the applet is constrained both vertically > and horizontally, > + and can't grow in neither directions, such as

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

mmustac added a comment. Great, I even didn't know that this was possible *lol* But wouldn't it be more consistent with dolphin to add the list view also ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: mmustac, broulik, michaelh,

Re: bugs.kde.org: kio vs frameworks-kio vs kfile etc.

On Tue, Apr 10, 2018 at 6:43 AM, Nate Graham wrote: > > > On Mon, 09 Apr 2018 11:35:49 -0700 Elvis > Angelaccio wrote > > Yes. > > > > Note that this is not kio-specific: every library in kdelibs that used to > > have its own

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham updated this revision to Diff 31848. ngraham added a comment. Also add a Sort menu to the toolbar REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=31813=31848 BRANCH show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master)

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

ngraham retitled this revision from "Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs" to "Show view mode buttons and a sort menu in the open/save dialog's toolbar". ngraham edited the summary of this revision. ngraham edited the test

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

ngraham added a comment. I'm not thrilled about the dropdown menu button losing its an arrow when you make it activate-able with a regular click, but that's a Breeze issue (that I plan to fix soon...). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham,

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. Eike reports that I have bribed him into acquiescing to this patch!  Keep in mind we will be able to very easily change the icons in the future if need be, once this is landed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added a comment. Any more opinions on this? As you can see from the Summary section, it fixes (or obviates) a //ton// of bugs, many of them very old. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure,