Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/ --- Review request for kdelibs. Description --- The real changes are:

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/#review7164 --- You can configure kate not to remove trailing whitespaces in

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Ruurd Pels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/#review7165 --- Revert the whitespace changes with git. Other than that I

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Ruurd Pels
On Oct. 7, 2011, 2:35 p.m., Ruurd Pels wrote: Revert the whitespace changes with git. Other than that I dislike multiple exit points even in trivially short functions. It really does not hurt to create a local variable holding the result of the function and then return that as the

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/ --- (Updated Oct. 7, 2011, 4:25 p.m.) Review request for kdelibs. Changes

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Thiago Macieira
On Friday, 7 de October de 2011 15:49:59 Ruurd Pels wrote: On Oct. 7, 2011, 2:35 p.m., Ruurd Pels wrote: Revert the whitespace changes with git. Other than that I dislike multiple exit points even in trivially short functions. It really does not hurt to create a local variable holding

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Ruurd Pels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/#review7169 --- Ship it! Ship It! - Ruurd Pels On Oct. 7, 2011, 4:25 p.m.,

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102794/#review7170 --- This review has been submitted with commit

Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-07 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102799/ --- Review request for KDE Base Apps. Description --- Currently, the

Review Request: Cleanup the use of HTTPProtocol::httpClose

2011-10-07 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102801/ --- Review request for kdelibs and Andreas Hartmetz. Description ---

Re: Bug triage process needs help

2011-10-07 Thread Steven Sroka
On 28 September 2011 13:46, Bart Kelsey elba...@gmail.com wrote: Hi folks, I'd like to draw attention to the fact that KDE's bug triage process is lacking. In case anyone is interested and as a FYI, Ubuntu is looking at an option to help bug triaging: https://wiki.ubuntu.com/ErrorTracker