Re: KF5/Qt5 and multiple QPAs

2016-10-03 Thread Martin Graesslin 
On Wednesday, September 21, 2016 10:14:33 PM CEST René J.V. Bertin wrote:
> Hi,
> 
> Am I correct that Qt now provides a Wayland QPA and that users on Linux can
> now decide, in principle "on the fly" which displaying protocol a newly
> started application is going to use, presumably with a platform-wide
> default either hardwired into Qt or defined in some settings file?

That's correct. This mail is written in a kmail on --platform xcb in a Wayland 
session.

> 
> If so, how does that work out with KF5 applications that get started by
> others? Say, a user with a Wayland-based desktop logs in over ssh+X11 and
> wants to run kate remotely with `kate -platform xcb`. A new session dbus
> will be started, and during Kate's start-up sequence kdeinit5 will start
> which will then start klauncher.
> 
> I just tried this on OS X (I have a working XCB QPA on my system, plus a
> patched dbus that works without launchd). kdeinit5 starts up fine because
> it's not a GUI app (I think), but klauncher is. It doesn't inherit the
> `-platform xcb` arguments, and thus fails because the Cocoa QPA only works
> locally.
> 
> Mostly asking out of curiosity, though I would of course appreciate it if on
> occasion I could use applications like Kate remotely.

That's something I have never tried and I think is a corner case. In case of 
starting a new dbus session it would be enough to just do an
export QT_QPA_PLATFORM=xcb

prior to starting any remote application. That will force all to use the xcb 
platform. Which is what you want in a remote situation.

But I need to remind that the x11 over the network is broken. It just doesn't 
work and I highly suggest to look into different solutions for this. If it 
breaks, it breaks and that's a good thing!

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.

Re: Review Request 129092: Fix crashes in NotifyByAudio

2016-10-03 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129092/#review99749
---



This is not a correct place to patch it. What is your used phonon backend?


src/notifybyaudio.cpp (line 144)


if (notification) {
finish...


- Anthony Fieroni


On Окт. 4, 2016, 12:31 преди обяд, Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129092/
> ---
> 
> (Updated Окт. 4, 2016, 12:31 преди обяд)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Phonon::MediaObject::stop does not emit finished and thus onAudioFinished is 
> not called and thus finished() was not called and then when closing the app, 
> the notification manager would go and delete all the non finished 
> notifications, meaning it would call close() again, add the same 
> Phonon::MediaObject to m_reusablePhonons again and then crash because it 
> would delete them twice in the destructor
> 
> 
> Diffs
> -
> 
>   src/notifybyaudio.h 6726a93 
>   src/notifybyaudio.cpp 903e996 
> 
> Diff: https://git.reviewboard.kde.org/r/129092/diff/
> 
> 
> Testing
> ---
> 
> configure konsole notifications to emit sound on "Bell in Visible Session" 
> and also show an info box.
> 
> Make it bell and quickly close the info box.
> 
> Close konsole.
> 
> Without this patch it will crash.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Low quality input country flags

2016-10-03 Thread Albert Astals Cid 
El dimecres, 3 d’agost de 2016, a les 12:39:21 CEST, Viorel-Cătălin Răpițeanu 
va escriure:
> > I don't understand this bug, are you saying flags of France and Romania
> 
> are shown differently even if the png files have the same size?
> 
> Of course that the png size is the same, but the France flag doesn't fill
> the whole canvas. 

I just fixed that (the France flag part).

> As a result of this, the flag seems smaller when
> displayed in the panel.
> Also, due to the format and size limitation, more complex flags (like that
> of Nepal) can never be displayed correctly.
> 
> A solution for this would be replacing the png format with an svg one, but
> I'm not sure exactly of the complete implications of such a change.

Neither am I, if you're interested in investigating who uses those flags and 
how they are used I'm sure people will appreciate the possibility to move to 
higher resolution flags (SVG is not really the pinnacle since it's slow in 
rendering).

Cheers,
  Albert

> 
> Kind regards,
> Catalin
> 
> 2016-08-03 0:45 GMT+03:00 Albert Astals Cid :
> > El diumenge, 31 de juliol de 2016, a les 17:13:07 CEST, Viorel-Cătălin
> > 
> > Răpițeanu va escriure:
> > > Hi all,
> > > 
> > > I've got a question related to the flags used to display the input
> > > layout
> > > in plasma.
> > > To explain, the flags used for the input sources either don't have the
> > > correct aspect ratio, either they are pixelated. The flags of Romania
> > > and
> > > France should have the same aspect ratio (2:3) when they are displayed
> > > in
> > > the taskbar. For more information, you can visit:
> > > https://bugs.kde.org/show_bug.cgi?id=355261
> > 
> > I don't understand this bug, are you saying flags of France and Romania
> > are
> > shown differently even if the png files have the same size?
> > 
> > > The flags are installed by* kde-runtime*
> > 
> > No, by kdelibs4support.
> > 
> > Cheers,
> > 
> >   Albert
> >   
> > > and can be found in: *#
> > > l10n/$COUNTRY/flag.png*
> > > The reason why they are pixelated is because of their size. To quote
> > > from
> > > README file: > You will need a nice flag for your country. The size
> > 
> > should
> > 
> > > be 21x14 > pixels, and it should be called "flag.png". Potential fixes
> > 
> > for
> > 
> > > this problem would be: 1. Replacing the png format with the svg one,
> > 
> > thing
> > 
> > > that would also require some modifications to
> > 
> > kcontrol/locale/kcmlocale.cpp
> > 
> > > and khelpcenter/htmlsearch/klangcombo.cpp. 2. Improving the existing png
> > > resolution. Any other suggestions to fix this problem?
> > > Will the format replacement (Fix 1) impact other components?
> > > 
> > > Kind regards,
> > > Cătălin

Review Request 129092: Fix crashes in NotifyByAudio

2016-10-03 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129092/
---

Review request for KDE Frameworks and Martin Klapetek.


Repository: knotifications


Description
---

Phonon::MediaObject::stop does not emit finished and thus onAudioFinished is 
not called and thus finished() was not called and then when closing the app, 
the notification manager would go and delete all the non finished 
notifications, meaning it would call close() again, add the same 
Phonon::MediaObject to m_reusablePhonons again and then crash because it would 
delete them twice in the destructor


Diffs
-

  src/notifybyaudio.h 6726a93 
  src/notifybyaudio.cpp 903e996 

Diff: https://git.reviewboard.kde.org/r/129092/diff/


Testing
---

configure konsole notifications to emit sound on "Bell in Visible Session" and 
also show an info box.

Make it bell and quickly close the info box.

Close konsole.

Without this patch it will crash.


Thanks,

Albert Astals Cid

Re: kdereview

2016-10-03 Thread Luigi Toscano 
Ben Cooksley ha scritto:
> On Sat, Oct 1, 2016 at 10:49 AM, Albert Astals Cid  wrote:
>> El divendres, 30 de setembre de 2016, a les 21:17:56 CEST, Ben Cooksley va
>> escriure:
>>> On Fri, Sep 30, 2016 at 11:27 AM, Albert Astals Cid  wrote:
 El dimecres, 21 de setembre de 2016, a les 11:01:18 CEST, Allen Winter va

 escriure:
> kwave is now moved to kdemultimedia.

 Why did that happen?
>>>
>>> It was moved at the request of it's maintainer and Allen.
>>>
 Did i miss the emails to k-c-d about reviewing it?
>>>
>>> I've just searched my mail - you didn't miss it. When the repository
>>> was moved to KDE Review the Sysadmin ticket would have expressly
>>> requested that the review process on kde-core-devel be started by the
>>> maintainer now that we'd processed the move. It appears that didn't
>>> happen.
>>>
>>> Thoughts on what should be done in regards to KWave here?
>>
>> Following the rules strictly I'd say to move it back to kdereview until we do
>> the usual steps, i.e. email to k-c-d and the module list and get the review.
>>
>> Now, moving stuff around is a bit of a pain, so if Thomas can get those 
>> emails
>> sent *NOW* I guess we can do the discussion with the kwave repo still in the
>> kdemultimedia location and if nothing critical is found we save ourselves
>> moving things back and forth.
> 
> I've not seen the email, so i've now pushed KWave back into review.
> 

... so another round of moving translations.

I would have advocated for a slightly longer waiting time.

-- 
Luigi

Re: Review Request 129090: use ECM variables to find binary

2016-10-03 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129090/#review99741
---


Fix it, then Ship it!





cmake/FindUTEMPTER.cmake (line 37)


You can do:

${KDE_INSTALL_FULL_LIBDIR}/utempter


- David Edmundson


On Oct. 3, 2016, 4:28 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129090/
> ---
> 
> (Updated Oct. 3, 2016, 4:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> use ECM variables to find binary
> 
> currently on debian distros the binary isn't found, we use arch specific 
> directories which aren't search for with the current search string
> this finds it hidden away in /usr/lib/x86_64-linux-gnu/utempter/utempter
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 8e16d69 
> 
> Diff: https://git.reviewboard.kde.org/r/129090/diff/
> 
> 
> Testing
> ---
> 
> build, it works
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

Review Request 129090: use ECM variables to find binary

2016-10-03 Thread Jonathan Riddell 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129090/
---

Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: kpty


Description
---

use ECM variables to find binary

currently on debian distros the binary isn't found, we use arch specific 
directories which aren't search for with the current search string
this finds it hidden away in /usr/lib/x86_64-linux-gnu/utempter/utempter


Diffs
-

  cmake/FindUTEMPTER.cmake 8e16d69 

Diff: https://git.reviewboard.kde.org/r/129090/diff/


Testing
---

build, it works


Thanks,

Jonathan Riddell

Re: Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays

2016-10-03 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129083/#review99729
---


Ship it!




Ship It!

- David Edmundson


On Oct. 2, 2016, 9:29 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129083/
> ---
> 
> (Updated Oct. 2, 2016, 9:29 p.m.)
> 
> 
> Review request for Dolphin, KDE Frameworks and David Edmundson.
> 
> 
> Bugs: 369640
> https://bugs.kde.org/show_bug.cgi?id=369640
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Keeps them from being painted outside view and scales them with the image 
> they're supposed to be painted on.
> 
> 
> Diffs
> -
> 
>   src/kiconloader.cpp 5315ea4 
> 
> Diff: https://git.reviewboard.kde.org/r/129083/diff/
> 
> 
> Testing
> ---
> 
> Ran dolphin with device pixel ratio 2, got my symolic link icon again.
> Ran it with device pixel ratio 1, looked as it did before.
> 
> (couldn't figure out why the VCS icons don't show up though)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 195 - Unstable!

2016-10-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/195/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 03 Oct 2016 10:45:55 +
Build duration: 10 min

CHANGE SET
Revision 752626ad550552232d73d8b009db62b0f8e86113 by David Edmundson: 
(Don#039;t load containment actions for embedded containments (system 
trays))
  change: edit src/plasma/containment.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
16 test(s)Failed: TestSuite.coronatest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 76/117 (65%)CLASSES 76/117 (65%)LINE 4158/11557 
(36%)CONDITIONAL 2164/8614 (25%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 885/916 
(97%)CONDITIONAL 508/1036 (49%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2128 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 12/20 (60%)CLASSES 12/20 (60%)LINE 1170/3598 
(33%)CONDITIONAL 701/2693 (26%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/24 (54%)CLASSES 13/24 (54%)LINE 779/1638 
(48%)CONDITIONAL 329/1060 (31%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 544/1786 
(30%)CONDITIONAL 298/1397 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1132 (1%)CONDITIONAL 
1/970 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 195 - Unstable!

2016-10-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/195/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 03 Oct 2016 10:45:55 +
Build duration: 11 min

CHANGE SET
Revision 752626ad550552232d73d8b009db62b0f8e86113 by David Edmundson: 
(Don#039;t load containment actions for embedded containments (system 
trays))
  change: edit src/plasma/containment.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
15 test(s)Failed: TestSuite.coronatest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 73/113 (65%)CLASSES 73/113 (65%)LINE 3718/11042 
(34%)CONDITIONAL 1861/8210 (23%)

By packages
  
autotests
FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 815/845 
(96%)CONDITIONAL 470/960 (49%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 12/20 (60%)CLASSES 12/20 (60%)LINE 1168/3598 
(32%)CONDITIONAL 693/2693 (26%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 12/22 (55%)CLASSES 12/22 (55%)LINE 719/1565 
(46%)CONDITIONAL 303/1014 (30%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 323/1663 
(19%)CONDITIONAL 150/1271 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1132 (1%)CONDITIONAL 
1/970 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 195 - Unstable!

2016-10-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/195/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 03 Oct 2016 10:45:55 +
Build duration: 4 min 29 sec

CHANGE SET
Revision 752626ad550552232d73d8b009db62b0f8e86113 by David Edmundson: 
(Don#039;t load containment actions for embedded containments (system 
trays))
  change: edit src/plasma/containment.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
16 test(s)Failed: TestSuite.coronatest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 76/117 (65%)CLASSES 76/117 (65%)LINE 4149/11557 
(36%)CONDITIONAL 2162/8614 (25%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 886/916 
(97%)CONDITIONAL 509/1036 (49%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2128 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 12/20 (60%)CLASSES 12/20 (60%)LINE 1170/3598 
(33%)CONDITIONAL 701/2693 (26%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/24 (54%)CLASSES 13/24 (54%)LINE 769/1638 
(47%)CONDITIONAL 326/1060 (31%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 544/1786 
(30%)CONDITIONAL 298/1397 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1132 (1%)CONDITIONAL 
1/970 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 195 - Unstable!

2016-10-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/195/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 03 Oct 2016 10:45:55 +
Build duration: 3 min 40 sec

CHANGE SET
Revision 752626ad550552232d73d8b009db62b0f8e86113 by David Edmundson: 
(Don#039;t load containment actions for embedded containments (system 
trays))
  change: edit src/plasma/containment.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
15 test(s)Failed: TestSuite.coronatest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 73/113 (65%)CLASSES 73/113 (65%)LINE 3718/11042 
(34%)CONDITIONAL 1861/8210 (23%)

By packages
  
autotests
FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 815/845 
(96%)CONDITIONAL 470/960 (49%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 12/20 (60%)CLASSES 12/20 (60%)LINE 1168/3598 
(32%)CONDITIONAL 693/2693 (26%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 12/22 (55%)CLASSES 12/22 (55%)LINE 719/1565 
(46%)CONDITIONAL 303/1014 (30%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 323/1663 
(19%)CONDITIONAL 150/1271 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1132 (1%)CONDITIONAL 
1/970 (0%)

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-03 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129086/
---

(Updated Oct. 3, 2016, 10:45 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

It's reasnoble to expect people to download an applet just before trying
to change an existing applet using the alternatives system.

Therefore doing the check that any alternative applets exist during applet 
initialisation time is semantically
wrong as the option will be prematurely disabled.

This patch moves it to be verified in contextualActionsAboutToShow.

This patch also gives a startup performance boost.
Loading all the applets metadata takes a small amount of time (~50 
milliseconds) not really noticable when you're doing it once, but it adds up 
when we're doing it for a lot of applets in a row.


Diffs
-

  src/plasma/applet.cpp 5e278dc69055de0316b49decc08e471081e34b53 
  src/plasma/private/applet_p.cpp 0f37fe5e3a3c417e079f54b6d8b45fa0051684a5 

Diff: https://git.reviewboard.kde.org/r/129086/diff/


Testing
---

Right click on kickoff, option was there and worked
Right click on system tray, no option
Locked widges, option wasn't there
Unlocked widgets, option in kickoff came back

Context menu still appears "instantly"


Thanks,

David Edmundson

Re: Review Request 129078: Don't load containment actions for embedded containments (system trays)

2016-10-03 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129078/
---

(Updated Oct. 3, 2016, 10:45 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 752626ad550552232d73d8b009db62b0f8e86113 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Also load the correct default actions for custom panels.


Diffs
-

  src/plasma/containment.cpp 803887d2038719028ef424883619d416c120740e 

Diff: https://git.reviewboard.kde.org/r/129078/diff/


Testing
---


Thanks,

David Edmundson

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-03 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129086/#review99728
---


Ship it!




very good point

- Marco Martin


On Oct. 3, 2016, 12:42 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129086/
> ---
> 
> (Updated Oct. 3, 2016, 12:42 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's reasnoble to expect people to download an applet just before trying
> to change an existing applet using the alternatives system.
> 
> Therefore doing the check that any alternative applets exist during applet 
> initialisation time is semantically
> wrong as the option will be prematurely disabled.
> 
> This patch moves it to be verified in contextualActionsAboutToShow.
> 
> This patch also gives a startup performance boost.
> Loading all the applets metadata takes a small amount of time (~50 
> milliseconds) not really noticable when you're doing it once, but it adds up 
> when we're doing it for a lot of applets in a row.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.cpp 5e278dc69055de0316b49decc08e471081e34b53 
>   src/plasma/private/applet_p.cpp 0f37fe5e3a3c417e079f54b6d8b45fa0051684a5 
> 
> Diff: https://git.reviewboard.kde.org/r/129086/diff/
> 
> 
> Testing
> ---
> 
> Right click on kickoff, option was there and worked
> Right click on system tray, no option
> Locked widges, option wasn't there
> Unlocked widgets, option in kickoff came back
> 
> Context menu still appears "instantly"
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 129078: Don't load containment actions for embedded containments (system trays)

2016-10-03 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129078/#review99727
---


Ship it!




Ship It!

- Marco Martin


On Sept. 30, 2016, 11:02 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129078/
> ---
> 
> (Updated Sept. 30, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Also load the correct default actions for custom panels.
> 
> 
> Diffs
> -
> 
>   src/plasma/containment.cpp 803887d2038719028ef424883619d416c120740e 
> 
> Diff: https://git.reviewboard.kde.org/r/129078/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 322 - Fixed!

2016-10-03 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/322/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Oct 2016 06:44:04 +
Build duration: 3 min 17 sec

CHANGE SET
Revision 22b383359e3a0e02d4828e6fa8ed8a3d213440b1 by kainz.a: (remove 
duplicates)
  change: edit icons/mimetypes/16/x-office-drawing.svg
  change: edit icons/mimetypes/64/x-office-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 325 - Fixed!

2016-10-03 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/325/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Oct 2016 06:44:03 +
Build duration: 2 min 52 sec

CHANGE SET
Revision 22b383359e3a0e02d4828e6fa8ed8a3d213440b1 by kainz.a: (remove 
duplicates)
  change: edit icons/mimetypes/16/x-office-drawing.svg
  change: edit icons/mimetypes/64/x-office-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 322 - Fixed!

2016-10-03 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/322/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Oct 2016 06:44:04 +
Build duration: 3 min 17 sec

CHANGE SET
Revision 22b383359e3a0e02d4828e6fa8ed8a3d213440b1 by kainz.a: (remove 
duplicates)
  change: edit icons/mimetypes/16/x-office-drawing.svg
  change: edit icons/mimetypes/64/x-office-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 325 - Fixed!

2016-10-03 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/325/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Oct 2016 06:44:03 +
Build duration: 2 min 52 sec

CHANGE SET
Revision 22b383359e3a0e02d4828e6fa8ed8a3d213440b1 by kainz.a: (remove 
duplicates)
  change: edit icons/mimetypes/16/x-office-drawing.svg
  change: edit icons/mimetypes/64/x-office-drawing.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)