D10776: Make it possible to generate po files in parallel

[Harald Sitter]

sitter added a comment.


  Ingenious code!
  
  You left some debug clutter behind though.
  
  Also, the if i statement is inconsistent between the two files
  
  `if (i EQUAL ${numberOfProcesses})` vs. `if (i GREATER 
${numberOfProcesses})`

INLINE COMMENTS

> build-pofiles.cmake:45
> +)
> +if(code)
> +message(FATAL_ERROR "failed generating ${PO_DIR}")

I think `!(code EQUAL 0)` may be more explicit here.

> build-pofiles.cmake:62
> +math(EXPR i "${i}+1")
> +message(STATUS "::: ${i}")
> +if (i EQUAL ${numberOfProcesses})

debug

> build-pofiles.cmake:63
> +message(STATUS "::: ${i}")
> +if (i EQUAL ${numberOfProcesses})
> +message(STATUS "holt")

no space after if.

> build-pofiles.cmake:64
> +if (i EQUAL ${numberOfProcesses})
> +message(STATUS "holt")
> +_processCommands()

debug

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D10776

To: apol, #frameworks, sitter
Cc: michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 140 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/140/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 06 Mar 2018 04:22:17 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/11/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 06 Mar 2018 04:22:17 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31599/59623)38%
(18532/48872)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5232/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8403/14349)50%
(4893/9724)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3896/7874)33%
(1643/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 160 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/160/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Mar 2018 04:22:17 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31550/59623)38%
(18512/48876)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5232/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8354/14348)50%
(4876/9720)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)50%
(3901/7875)33%
(1643/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D10989: Check for nullptr in indexForNode

[Michael Pyne]

mpyne added a comment.


  I'm not sure the job could have been deleted before 
`KDialogJobUiDelegate::showErrorMessage()` since much of the call stack before 
then involves making method calls on the job.  
KDirLister::handleError(KIO::Job*) (kdirlister.cpp:81) makes a call to 
`job->error()` right before calling `handleError`, for instance.
  
  Is it possible that the widget itself has been deleted early somehow?  Does 
the job run on a different event loop (due to threading or similar)?
  
  I think valgrind has some flags you can use to try to generate a backtrace 
for where a freed block of memory was freed from, which might be useful for 
debugging.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10989

To: jtamate, #frameworks, dfaure
Cc: mpyne, michaelh

D10168: Use nullptr for passing a null pointer to crc32

[Michael Pyne]

mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.


  Actually `-Wzero-as-null-pointer-constant` is probably a good idea, and this 
is a correct fix.  A decade ago when everything was going from 32 to 64-bits, 
we ran into a JuK crash bug because we used `GST_NULL` (or similar) as the null 
constant for a gstreamer variadic C function, which in C++ mode was `0`.  Well, 
C++ didn't know that the `0` was supposed to be a pointer instead of an `int`, 
so the function in question crashed because C++ put a 32-bit `int` on the stack 
instead of a 64-bit null pointer.
  
  Using `nullptr` consistently solves this issue, even though it wouldn't be a 
problem here since C++ can see that the `0` is supposed to convert to a pointer.
  
  The real fix should probably go in zlib, but I wouldn't hold my breath due to 
the compatibility requirements that I would imagine they maintain.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10168

To: aacid, mpyne
Cc: mpyne, #frameworks, michaelh

D11080: Make org.kde. components include a donate URL

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  AppStream can offer information to donate about a product, we better point our
  happy users to the right direction.

TEST PLAN
  output validates successfully against appstreamcli

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11080

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp

To: apol, #frameworks
Cc: michaelh

D11077: [Icon Item] Remove unused variables

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11077

To: broulik, #plasma, davidedmundson
Cc: #frameworks, michaelh

D11077: [Icon Item] Remove unused variables

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

TEST PLAN
  Compiles

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11077

AFFECTED FILES
  src/declarativeimports/core/iconitem.h

To: broulik, #plasma
Cc: #frameworks, michaelh

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/27/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 05 Mar 2018 22:02:35 +
 Build duration:
5 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1276/2499)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/21/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 05 Mar 2018 22:02:35 +
 Build duration:
2 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/4/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 05 Mar 2018 22:02:35 +
 Build duration:
1 min 19 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1276/2499)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

D11067: Fix 3 more cases of incorrect parameter to findProtocol

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kprotocolmanager.cpp:1141
> +}
>  KProtocolInfoPrivate *prot = findProtocol(url);
>  if (!prot) {

You could move the check to inside findProtocol, so it's done in a central 
location.

> kurlcompletion.cpp:626
>  
> +if (!url.kurl().isValid()) {
> +return QString();

I'm not 100% sure about this one because kurl() is only supposed to be called 
if url.isURL().

Also, I tried to reproduce this assert with a unittest for kcompletion, but it 
works here !?

http://www.davidfaure.fr/2018/kurlcompletion_test.diff

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11067

To: jtamate, #frameworks, dfaure
Cc: michaelh

D11067: Fix 3 more cases of incorrect parameter to findProtocol

[Jaime Torres Amate]

jtamate added a comment.


  The backtraces:
  
  deleting characters from the beginning
  
  #10 0x7fdc893f249a in KProtocolInfoFactory::findProtocol 
(this=0x7fdc896b9720 <(anonymous 
namespace)::Q_QGS_kProtocolInfoFactoryInstance::innerFunction()::holder>, 
protocol=...) at 
/virtual/kde5/5kde/frameworks/kio/src/core/kprotocolinfofactory.cpp:72
  #11 0x7fdc893f1c07 in KProtocolInfo::proxiedBy (_protocol=...) at 
/virtual/kde5/5kde/frameworks/kio/src/core/kprotocolinfo.cpp:380
  #12 0x7fdc893da776 in findProtocol (url=...) at 
/virtual/kde5/5kde/frameworks/kio/src/core/kprotocolmanager.cpp:1108
  #13 0x7fdc893da8ce in KProtocolManager::supportsListing (url=...) at 
/virtual/kde5/5kde/frameworks/kio/src/core/kprotocolmanager.cpp:1148
  #14 0x7fdc8d583f31 in 
DolphinViewContainer::slotUrlNavigatorLocationChanged (this=0x7fdc70007610, 
url=...) at /g/5kde/kde/applications/dolphin/src/dolphinviewcontainer.cpp:568
  #15 0x7fdc85abe0cc in QMetaObject::activate(QObject*, int, int, void**) 
() from /usr/lib64/libQt5Core.so.5
  #16 0x7fdc8c1d6611 in KUrlNavigator::urlChanged (this=0x2de9730, _t1=...) 
at 
/virtual/kde5/5kde/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kurlnavigator.cpp:318
  #17 0x7fdc8c1d54a4 in KUrlNavigator::setLocationUrl (this=0x2de9730, 
newUrl=...) at 
/virtual/kde5/5kde/frameworks/kio/src/filewidgets/kurlnavigator.cpp:1092
  #18 0x7fdc8c1d13cb in KUrlNavigator::Private::applyUncommittedUrl 
(this=0x373c6f0) at 
/virtual/kde5/5kde/frameworks/kio/src/filewidgets/kurlnavigator.cpp:322
  #19 0x7fdc8c1d1447 in KUrlNavigator::Private::slotReturnPressed 
(this=0x373c6f0) at 
/virtual/kde5/5kde/frameworks/kio/src/filewidgets/kurlnavigator.cpp:331
  
  an url like ~:/
  
  #10 0x7f553750949a in KProtocolInfoFactory::findProtocol 
(this=0x7f55377d0720 <(anonymous 
namespace)::Q_QGS_kProtocolInfoFactoryInstance::innerFunction()::holder>, 
protocol=...) at 
/virtual/kde5/5kde/frameworks/kio/src/core/kprotocolinfofactory.cpp:72
  #11 0x7f55375089a9 in KProtocolInfo::protocolClass (_protocol=...) at 
/virtual/kde5/5kde/frameworks/kio/src/core/kprotocolinfo.cpp:331
  #12 0x7f553956acab in isLocalProtocol (protocol=...) at 
/virtual/kde5/5kde/frameworks/kio/src/widgets/kurlcompletion.cpp:1001
  #13 0x7f553956ae6e in KUrlCompletionPrivate::urlCompletion 
(this=0x45b4e30, url=..., pMatch=0x7fff73123518) at 
/virtual/kde5/5kde/frameworks/kio/src/widgets/kurlcompletion.cpp:1024
  #14 0x7f55395693f1 in KUrlCompletion::makeCompletion (this=0x45b44c0, 
text=...) at 
/virtual/kde5/5kde/frameworks/kio/src/widgets/kurlcompletion.cpp:686
  #15 0x7f55388449f6 in KLineEdit::makeCompletion (this=0x45b66a0, 
text=...) at /g/5kde/frameworks/kcompletion/src/klineedit.cpp:432
  #16 0x7f553884a8ab in KLineEdit::doCompletion (this=0x45b66a0, text=...) 
at /g/5kde/frameworks/kcompletion/src/klineedit.cpp:1665
  #17 0x7f5538846d5a in KLineEdit::keyPressEvent (this=0x45b66a0, 
e=0x7fff73124020) at /g/5kde/frameworks/kcompletion/src/klineedit.cpp:901
  
  an url like ~:/  (second attempt)
  
  #10 0x7fe8140c74b4 in KProtocolInfoFactory::findProtocol 
(this=0x7fe81438e720 <(anonymous 
namespace)::Q_QGS_kProtocolInfoFactoryInstance::innerFunction()::holder>, 
protocol=...) at 
/virtual/kde5/5kde/frameworks/kio/src/core/kprotocolinfofactory.cpp:72
  #11 0x7fe8140c6c21 in KProtocolInfo::proxiedBy (_protocol=...) at 
/virtual/kde5/5kde/frameworks/kio/src/core/kprotocolinfo.cpp:380
  #12 0x7fe8140af776 in findProtocol (url=...) at 
/virtual/kde5/5kde/frameworks/kio/src/core/kprotocolmanager.cpp:1108
  #13 0x7fe8140af896 in KProtocolManager::isSourceProtocol (url=...) at 
/virtual/kde5/5kde/frameworks/kio/src/core/kprotocolmanager.cpp:1138
  #14 0x7fe818258f88 in 
DolphinViewContainer::slotUrlNavigatorLocationChanged (this=0x24b01e0, url=...) 
at /g/5kde/kde/applications/dolphin/src/dolphinviewcontainer.cpp:579
  #15 0x7fe8107930cc in QMetaObject::activate(QObject*, int, int, void**) 
() from /usr/lib64/libQt5Core.so.5
  #16 0x7fe816eab611 in KUrlNavigator::urlChanged (this=0x25d6fc0, _t1=...) 
at 
/virtual/kde5/5kde/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kurlnavigator.cpp:318
  #17 0x7fe816eaa4a4 in KUrlNavigator::setLocationUrl (this=0x25d6fc0, 
newUrl=...) at 
/virtual/kde5/5kde/frameworks/kio/src/filewidgets/kurlnavigator.cpp:1092
  #18 0x7fe816ea63cb in KUrlNavigator::Private::applyUncommittedUrl 
(this=0x1f49730) at 
/virtual/kde5/5kde/frameworks/kio/src/filewidgets/kurlnavigator.cpp:322
  #19 0x7fe816ea6447 in KUrlNavigator::Private::slotReturnPressed 
(this=0x1f49730) at 
/virtual/kde5/5kde/frameworks/kio/src/filewidgets/kurlnavigator.cpp:331

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11067

To: jtamate, #frameworks, dfaure
Cc: michaelh

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/61/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 05 Mar 2018 19:58:35 +
 Build duration:
8 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

D11067: Fix 3 more cases of incorrect parameter to findProtocol

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  deleting characters from the beginning in a url in dolphin
  trying to use this url: ~:/

REPOSITORY
  R241 KIO

BRANCH
  protocol (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11067

AFFECTED FILES
  src/core/kprotocolmanager.cpp
  src/widgets/kurlcompletion.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/5/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 05 Mar 2018 19:58:34 +
 Build duration:
5 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/44/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 05 Mar 2018 19:58:34 +
 Build duration:
3 min 52 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

D11037: balooctl: checkDb should also verify the last known url for the documentId.

[James Smith]

smithjd added a comment.


  This change includes orphan file entries as invalid database entries in 
checkFsTree().

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11037

To: smithjd, #baloo
Cc: michaelh, #frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11038: balooctl: Add pruneDb option to remove stale file index entries.

[James Smith]

smithjd marked 7 inline comments as done.
smithjd added a comment.


  All mounts must be manually made available by the user before running this 
option, or all files on a previously available mount will be removed from the 
index.

INLINE COMMENTS

> michaelh wrote in transaction.cpp:271
> Can we or should we check the result of the operation here?

removeDocument() is void.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11038

To: smithjd, #baloo, #frameworks
Cc: michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11038: balooctl: Add pruneDb option to remove stale file index entries.

[James Smith]

smithjd updated this revision to Diff 28747.
smithjd added a comment.


  Review changes.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11038?vs=28656=28747

BRANCH
  master-purgeDb (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11038

AFFECTED FILES
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/tools/balooctl/main.cpp

To: smithjd, #baloo, #frameworks
Cc: michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/10/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 05 Mar 2018 18:27:23 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31595/59622)38%
(18546/48872)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5231/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8393/14348)50%
(4891/9724)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3897/7874)33%
(1644/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 159 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/159/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 05 Mar 2018 18:27:23 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31536/59621)38%
(18518/48876)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5230/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8348/14347)50%
(4880/9720)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3896/7874)33%
(1643/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 139 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/139/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 05 Mar 2018 18:27:23 +
 Build duration:
8 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

D11044: Don't try to find an icon for an empty url

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8ba93b82e451: Dont try to find an icon for an empty 
url (authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11044?vs=28690=28739

REVISION DETAIL
  https://phabricator.kde.org/D11044

AFFECTED FILES
  src/core/global.cpp

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh

D10824: Delete IdleSlave having temporary authorization

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  I haven't yet tried your patch (which btw involves the http ioslave right?) 
but I am quite sure that exit() is not called for file ioslave after 
interrupting the application. I have placed the debug statements inside exit() 
as well as before every exit() call and I am not seeing any output.
  
  That aside here's what I have observed till now,
  After IdleSlave is created, inside `dispatchLoop()` SlaveBase waits in this 
line
  
if (d->appConnection.hasTaskAvailable() || 
d->appConnection.waitForIncomingTask(ms)) {
  
  with `appConnection` having no tasks available.
  After deleting the IdleSlave `waitForIncomingTask` returns false because the 
`Connection` object in IdleSlave was destroyed which interrupted the connection 
and  changed the socket state from `QAbstractSocket::ConnectedState` (It's 
merely a speculation. I haven't verified it yet). Then the variable `ret` is 
assigned -1. Since the connection was interrupted, SlaveBase returns from 
`dispatchLoop` and in `FileProtocol` kdemain returns thus terminating the 
process.
  
  Please fill me in if you think I have missed something.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D10824

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks, michaelh

Re: OneTimePass-Plasma

[Sebastian Kügler]

Thanks, both! Also good luck with this project, it sounds useful!

On zaterdag 3 maart 2018 10:33:45 CET Luca Beltrame wrote:
> Il giorno Fri, 02 Mar 2018 21:47:01 +0100
> 
> Sebastian Kügler  ha scritto:
> > For those not familiar wit hGoogle Authenticator, what does your
> > application do, what problem does it solve for the user? From your
> 
> It provides time-based one-time passwords (TOTP) for two-factor
> authentication: despite the name, it is not just used by Google or by
> Google products.
> 
> Other non-Google implementations exist, for example the Yubico
> Authenticator (which exists as a Qt application and a mobile
> application) which uses the YubiKey hardware token to generate the
> one-time password.
> 
> Examples of software using this particular approach in the wild are
> Github and Gitlab if you enable their 2FA support.


-- 
sebas

http://www.kde.org | http://vizZzion.org

D11055: Pack python bindings into right dirs

[Antonio Rojas]

arojas added a comment.


  The sip part is distro-specific. At least in Arch we don't have separate 
sip/sip3 directories (what's the point? sip files are independent of the python 
version)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11055

To: McPain, vkrause
Cc: arojas, apol, #frameworks, #build_system, michaelh

D10744: Use correct directory to lookup trigrams in windows build dir

[Hannah von Reth]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:e07142e27819: Use correct directory to lookup trigrams in 
windows build dir (authored by vonreth).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10744?vs=2=28732

REVISION DETAIL
  https://phabricator.kde.org/D10744

AFFECTED FILES
  src/core/guesslanguage.cpp
  src/plugins/hunspell/CMakeLists.txt
  src/plugins/hunspell/hunspellclient.cpp
  src/plugins/hunspell/hunspelldict.h

To: vonreth, mlaurent, dfaure, leinir
Cc: #frameworks, michaelh

D9973: ktooltipwidget: Fix tooltip positioning

[Michael Heidelbach]

michaelh marked 2 inline comments as done.
michaelh added a comment.


  If had known I would mess up the inline comments, I would not have moved the 
code in this step. Sorry.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9973

To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: dfaure, cfeck, michaelh

D9973: ktooltipwidget: Fix tooltip positioning

[Michael Heidelbach]

michaelh marked 2 inline comments as done.
michaelh added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in ktooltippositiontest.cpp:65
> Weird comma position :p

Old habits, sorry.

> elvisangelaccio wrote in ktooltippositiontest.cpp:136
> This should be a QCOMPARE

We're letting go of the description with QCOMPARE

> elvisangelaccio wrote in ktooltippositiontest.cpp:148
> What do you mean with "test is wrong"? Can this branch ever happen?

A better message would have been "michaelh was not thinking correctly" ;-)

> Can this branch ever happen?

Not unless we add conditions which are expected to fail. In that case testing 
the margin makes no sense.

> elvisangelaccio wrote in ktooltipwidget.cpp:122
> `centerBelow()` is `const`, but this actually changes the tooltip, right?
> Maybe we can move this call to `addWidget()` ?

Not needed. Dolphin calls `adjustSize() ` on the widget before calling 
`tooltip->showBelow()`.

> elvisangelaccio wrote in ktooltipwidget.cpp:142
> This looks unrelated to this patch. I don't see a testcase for it and if I 
> revert this change, the new tests still pass.
> 
> Ideally we need a failing test case that is fixed by this line of code. Btw, 
> don't we have a similar "negative y" problem?

In addition I cannot reproduce the behaviour depicted here 

 anymore.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9973

To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: dfaure, cfeck, michaelh

D9973: ktooltipwidget: Fix tooltip positioning

[Michael Heidelbach]

michaelh updated this revision to Diff 28731.
michaelh marked 12 inline comments as done.
michaelh added a comment.


  - Apply suggested changes
  - Join ktooltippositiontest and ktooltipwidgettest
  - Remove negative x constraint
  - Make some variables const

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9973?vs=26940=28731

BRANCH
  tooltip_and_test

REVISION DETAIL
  https://phabricator.kde.org/D9973

AFFECTED FILES
  autotests/ktooltipwidgettest.cpp
  autotests/ktooltipwidgettest.h
  src/ktooltipwidget.cpp

To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: dfaure, cfeck, michaelh

D9141: Setup QQmlEngine only once in QmlObject

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:0ecea38b5998: Setup QQmlEngine only once in QmlObject 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9141?vs=28691=28728#toc

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9141?vs=28691=28728

REVISION DETAIL
  https://phabricator.kde.org/D9141

AFFECTED FILES
  src/kdeclarative/kdeclarative.cpp
  src/kdeclarative/kdeclarative.h
  src/kdeclarative/qmlobject.cpp
  src/kdeclarative/qmlobject.h
  src/kdeclarative/qmlobjectsharedengine.cpp

To: broulik, #plasma, mart
Cc: davidedmundson, hein, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: Fallback Icon Theme

[Harald Sitter]

On Sun, Mar 4, 2018 at 7:30 PM, Martin Kostolný  wrote:
> If there is a better way of solving our situation, please tell us :).

Someone needs to file bug reports against adwaita so the missing icons
can get added.
That is the proper solution to an incomplete icon set.

It's a game of pick your poison:

- Inject breeze as "fallback": icons are now an inconsistent mix of
adwaita and breeze making for poor integration with workspace
- Don't inject breeze: icons are consistent but some are missing
- Force breeze: icons are consistent and none are missing but now the
integration with the workspace is poor

If adwaita grows the missing icons: the icons will be consistent, none
will be missing and the icons will match the rest of the workspace.

HS

D10989: Check for nullptr in indexForNode

[Jaime Torres Amate]

jtamate added a comment.


  > I tried testing
  > 
  >   kdialog --getexistingdirectory smb://
  > 
  > but this gives an error here "Unable to find any workgroups in your local 
network." even with samba started locally. Don't know why.
  
  I get always a crash trying kdialog --getexistingdirectory smb://, only 
executed directly or under valgrind, but not under gdb when I get that message 
also.
  
  8150== Process terminating with default action of signal 11 (SIGSEGV)
  -
  
  8150==  Access not within mapped region at address 0x28
  ---
  
  8150==at 0x62701D6: QObject::isWidgetType() const (qobject.h:147)
  -
  
  8150==by 0x627022C: QWidget* qobject_cast(QObject*) 
(qwidget.h:741)
  
-
  
  8150==by 0x627072B: 
QtPrivate::QVariantValueHelper::object(QVariant const&) 
(qvariant.h:709)
  
--
  
  8150==by 0x62704BD: 
QtPrivate::ObjectInvoker, QVariant 
const&, QWidget*>::invoke(QVariant const&) (qvariant.h:102)
  
---
  
  8150==by 0x627037B: QWidget* qvariant_cast(QVariant const&) 
(qvariant.h:835)
  
--
  
  8150==by 0x62702D5: QWidget* QVariant::value() const 
(qvariant.h:352)
  
---
  
  8150==by 0x626FF64: KJobWidgets::window(KJob*) (kjobwidgets.cpp:35)
  ---
  
  8150==by 0x6268028: KDialogJobUiDelegate::window() const 
(kdialogjobuidelegate.cpp:144)
  
---
  
  8150==by 0x62680E6: KDialogJobUiDelegate::showErrorMessage() 
(kdialogjobuidelegate.cpp:162)
  
---
  
  8150==by 0x4F48236: KDirLister::handleError(KIO::Job*) (kdirlister.cpp:81)
  --
  
  8150==by 0x5F9F573: KCoreDirListerCache::slotResult(KJob*) 
(kcoredirlister.cpp:1334)
  

  
  8150==by 0x5FAAC6E: KCoreDirListerCache::qt_static_metacall(QObject*, 
QMetaObject::Call, int, void**) (moc_kcoredirlister_p.cpp:136)
  

  
  8150==by 0x921B029: QMetaObject::activate(QObject*, int, int, void**) (in 
/usr/lib64/libQt5Core.so.5.10.0)
  
--
  
  8150==by 0x8A798DC: KJob::result(KJob*, KJob::QPrivateSignal) 
(moc_kjob.cpp:569)
  

  
  8150==by 0x8A778B4: KJob::finishJob(bool) (kjob.cpp:114)
  
  
  8150==by 0x8A77F9A: KJob::emitResult() (kjob.cpp:298)
  -
  
  8150==by 0x5F592AB: KIO::SimpleJob::slotFinished() (simplejob.cpp:232)
  --
  
  8150==by 0x5F52050: KIO::ListJob::slotFinished() (listjob.cpp:247)
  --
  
  8150==by 0x5F593C6: KIO::SimpleJob::slotError(int, QString const&) 
(simplejob.cpp:245)
  
--
  
  8150==by 0x5F5BA92: QtPrivate::FunctorCall, 
QtPrivate::List, void, void (KIO::SimpleJob::*)(int, 
QString const&)>::call(void (KIO::SimpleJob::*)(int, QString const&), 
KIO::SimpleJob*, void**) (qobjectdefs_impl.h:136)
  
--
  
  8150==by 0x5F5B8EF: void QtPrivate::FunctionPointer::call, void>(void (KIO::SimpleJob::*)(int, QString const&), KIO::SimpleJob*, 
void**) 

D10776: Make it possible to generate po files in parallel

[Aleix Pol Gonzalez]

apol updated this revision to Diff 28724.
apol added a comment.


  Make sure we don't run more than nproc processes at the same time

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10776?vs=27871=28724

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10776

AFFECTED FILES
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake

To: apol, #frameworks, sitter
Cc: michaelh

D11055: Pack python bindings into right dirs

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> FindPythonModuleGeneration.cmake:448
>  if (GPB_SIP_DEPENDS MATCHES PyKF5)
> -  set(_kf5_python_prefix 
> ${CMAKE_INSTALL_PREFIX}/lib/python${pyversion${pyversion}_maj_min}/${GPB_INSTALL_DIR_SUFFIX})
> +  set(_kf5_python_prefix 
> ${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX}/python${pyversion${pyversion}_maj_min}/${GPB_INSTALL_DIR_SUFFIX})
>  else()

Maybe use KDE_INSTALL_FULL_LIBDIR?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11055

To: McPain, vkrause
Cc: apol, #frameworks, #build_system, michaelh

D11054: Add media status icons

[Roman Gilg]

romangg added a dependent revision: D11056: [mediacontroller applet] Use media 
playback status icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11054

To: romangg, #plasma, #frameworks, #vdg
Cc: michaelh

D10776: Make it possible to generate po files in parallel

[Harald Sitter]

sitter added a comment.


  As discussed on telegram: the proposed change makes it a different problem. 
Now instead of running serial all the time, it'd fork bomb all the time (peaks 
at 3671 forks for plasma-desktop 5.12 when run on a fairly fast system with 
SSD).
  
  Also, missing adjustment to build-tsfiles.cmake ;)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D10776

To: apol, #frameworks, sitter
Cc: michaelh

D11055: Pack python bindings into right dirs

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: vkrause.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
McPain requested review of this revision.

REVISION SUMMARY
  1. Python modules are packed into /usr/lib/ for both x86 and x86_64 
architectures
  
  Should be:
  /usr/lib/ for x86
  /usr/lib64/ for x86_63
  
  2. sip modules are packed into /usr/share/sip for both python2 and python3
  
  Should be:
  /usr/share/sip/ for python2
  /usr/share/sip3/ for python3

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11055

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: McPain, vkrause
Cc: #frameworks, #build_system, michaelh

D11049: Remove frame around media action icons

[Roman Gilg]

romangg added a dependent revision: D11054: Add media status icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11049

To: romangg, #breeze, #vdg
Cc: mart, #frameworks, michaelh

D11054: Add media status icons

[Roman Gilg]

romangg added a dependency: D11049: Remove frame around media action icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11054

To: romangg, #plasma, #frameworks, #vdg
Cc: michaelh

D11054: Add media status icons

[Roman Gilg]

romangg created this revision.
romangg added reviewers: Plasma, Frameworks, VDG.
Restricted Application added a project: Frameworks.
romangg requested review of this revision.

REVISION SUMMARY
  This is used to show the state of a media playing process.
  
  These icons are introduced to distinguish the state from the action of
  triggering the state.

REPOSITORY
  R266 Breeze Icons

BRANCH
  mediaStatus

REVISION DETAIL
  https://phabricator.kde.org/D11054

AFFECTED FILES
  icons-dark/status/16/media-playback-paused.svg
  icons-dark/status/16/media-playback-playing.svg
  icons-dark/status/16/media-playback-stopped.svg
  icons-dark/status/22/media-playback-paused.svg
  icons-dark/status/22/media-playback-playing.svg
  icons-dark/status/22/media-playback-stopped.svg
  icons-dark/status/24/media-playback-paused.svg
  icons-dark/status/24/media-playback-playing.svg
  icons-dark/status/24/media-playback-stopped.svg
  icons/status/16/media-playback-paused.svg
  icons/status/16/media-playback-playing.svg
  icons/status/16/media-playback-stopped.svg
  icons/status/22/media-playback-paused.svg
  icons/status/22/media-playback-playing.svg
  icons/status/22/media-playback-stopped.svg
  icons/status/24/media-playback-paused.svg
  icons/status/24/media-playback-playing.svg
  icons/status/24/media-playback-stopped.svg

To: romangg, #plasma, #frameworks, #vdg
Cc: michaelh

D10716: handle wrong password when using sudo which asks for another password

[Harald Sitter]

sitter added a comment.


  Ping

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter
Cc: #frameworks, michaelh

D9141: Setup QQmlEngine only once in QmlObject

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  i like it now

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9141

To: broulik, #plasma, mart
Cc: davidedmundson, hein, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10769

To: broulik, #plasma, mart
Cc: mart, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

[Marco Martin]

mart added a comment.


  did you try if after removing it, repeatedly showing and hiding, the dialog 
does not appear in the taskbar, even for an instant? (if so, good to go for me)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10769

To: broulik, #plasma
Cc: mart, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10863: [KRecentDocument] Use QGuiApplication::desktopFileName()

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10863

To: broulik, #frameworks, #plasma, hein, aleksejshilin, mart
Cc: michaelh

D11044: Don't try to find an icon for an empty url

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11044

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh

D10446: Add KLanguageName

[Mark Gaiser]

markg added a comment.


  Isn't this better suited for KCoreAddons?
  
  On a related note, i did make this bug report for Qt: 
https://bugreports.qt.io/browse/QTBUG-64942 with regard to ISO 3166 country 
names. But language names also came up, see this 

 comment.
  
  I don't know of any progress there though.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: markg, apol, #frameworks, michaelh

D11049: Remove frame around media action icons

[Marco Martin]

mart added a comment.


  as a pure code review, +1 from me as i see 
style="fill:currentColor;fill-opacity:1;stroke:none" remained inalterated so 
you did fix the mess inkscape likes to do with it :)
  
  as style, i definitely like it more without circles around, final approval is 
by Andreas. (maybe add a couple of screenshots?)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11049

To: romangg, #breeze, #vdg
Cc: mart, #frameworks, michaelh

D11050: Remove frames around media buttons

[Marco Martin]

mart added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11050

To: romangg, #frameworks, #plasma
Cc: mart, michaelh

D11050: Remove frames around media buttons

[Roman Gilg]

romangg edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11050

To: romangg, #frameworks, #plasma
Cc: michaelh

D11050: Remove frames around media buttons

[Roman Gilg]

romangg added a dependency: D11049: Remove frame around media action icons.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11050

To: romangg, #frameworks, #plasma
Cc: michaelh

D11050: Remove frames around media buttons

[Roman Gilg]

romangg created this revision.
romangg added reviewers: Frameworks, Plasma.
Restricted Application added a project: Frameworks.
romangg requested review of this revision.

REVISION SUMMARY
  We were inconsistent on that and it can get in way with placement on buttons.
  
  Mirrors a change in Breeze icons.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  reworkMediaIcons

REVISION DETAIL
  https://phabricator.kde.org/D11050

AFFECTED FILES
  src/desktoptheme/breeze/icons/media.svgz

To: romangg, #frameworks, #plasma
Cc: michaelh

D11049: Remove frame around media action icons

[Roman Gilg]

romangg added a dependent revision: D11050: Remove frames around media buttons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11049

To: romangg, #breeze, #vdg
Cc: #frameworks, michaelh

D9141: Setup QQmlEngine only once in QmlObject

[Kai Uwe Broulik]

broulik updated this revision to Diff 28691.
broulik edited the test plan for this revision.
broulik added a comment.


  - Use protected constructor with pseudo argument instead of flags

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9141?vs=23360=28691

REVISION DETAIL
  https://phabricator.kde.org/D9141

AFFECTED FILES
  src/kdeclarative/kdeclarative.cpp
  src/kdeclarative/kdeclarative.h
  src/kdeclarative/qmlobject.cpp
  src/kdeclarative/qmlobject.h
  src/kdeclarative/qmlobjectsharedengine.cpp

To: broulik, #plasma, mart
Cc: davidedmundson, hein, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11044: Don't try to find an icon for an empty url

[Jaime Torres Amate]

jtamate updated this revision to Diff 28690.
jtamate added a comment.


  Checking for empty url at the top of the method.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11044?vs=28680=28690

REVISION DETAIL
  https://phabricator.kde.org/D11044

AFFECTED FILES
  src/core/global.cpp

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh

D11049: Remove frame around media action icons

[Roman Gilg]

romangg added reviewers: Breeze, VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11049

To: romangg, #breeze, #vdg
Cc: #frameworks, michaelh

D11049: Remove frame around media action icons

[Roman Gilg]

romangg created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
romangg requested review of this revision.

REVISION SUMMARY
  We were inconsistent on that and it can get in way with placement on buttons.
  
  Also Research showed that many established media players do not per se feature
  a frame around their media control buttons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  reworkMediaActions

REVISION DETAIL
  https://phabricator.kde.org/D11049

AFFECTED FILES
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons-dark/actions/16/media-record.svg
  icons-dark/actions/16/media-seek-backward.svg
  icons-dark/actions/16/media-seek-forward.svg
  icons-dark/actions/16/media-skip-backward.svg
  icons-dark/actions/16/media-skip-forward.svg
  icons-dark/actions/22/media-playback-pause.svg
  icons-dark/actions/22/media-playback-start.svg
  icons-dark/actions/22/media-playback-stop.svg
  icons-dark/actions/22/media-seek-backward.svg
  icons-dark/actions/22/media-seek-forward.svg
  icons-dark/actions/22/media-skip-backward.svg
  icons-dark/actions/22/media-skip-forward.svg
  icons-dark/actions/24/media-playback-pause.svg
  icons-dark/actions/24/media-playback-start.svg
  icons-dark/actions/24/media-playback-stop.svg
  icons-dark/actions/24/media-record.svg
  icons-dark/actions/24/media-seek-backward.svg
  icons-dark/actions/24/media-seek-forward.svg
  icons-dark/actions/24/media-skip-backward.svg
  icons-dark/actions/24/media-skip-forward.svg
  icons-dark/actions/32/media-playback-pause.svg
  icons-dark/actions/32/media-playback-start.svg
  icons-dark/actions/32/media-playback-stop.svg
  icons-dark/actions/32/media-record.svg
  icons-dark/actions/32/media-seek-backward.svg
  icons-dark/actions/32/media-seek-forward.svg
  icons-dark/actions/32/media-skip-backward.svg
  icons-dark/actions/32/media-skip-forward.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg
  icons/actions/16/media-record.svg
  icons/actions/16/media-seek-backward.svg
  icons/actions/16/media-seek-forward.svg
  icons/actions/16/media-skip-backward.svg
  icons/actions/16/media-skip-forward.svg
  icons/actions/22/media-playback-pause.svg
  icons/actions/22/media-playback-start.svg
  icons/actions/22/media-playback-stop.svg
  icons/actions/22/media-seek-backward.svg
  icons/actions/22/media-seek-forward.svg
  icons/actions/22/media-skip-backward.svg
  icons/actions/22/media-skip-forward.svg
  icons/actions/24/media-playback-pause.svg
  icons/actions/24/media-playback-start.svg
  icons/actions/24/media-playback-stop.svg
  icons/actions/24/media-record.svg
  icons/actions/24/media-seek-backward.svg
  icons/actions/24/media-seek-forward.svg
  icons/actions/24/media-skip-backward.svg
  icons/actions/24/media-skip-forward.svg
  icons/actions/32/media-playback-pause.svg
  icons/actions/32/media-playback-start.svg
  icons/actions/32/media-playback-stop.svg
  icons/actions/32/media-record.svg
  icons/actions/32/media-seek-backward.svg
  icons/actions/32/media-seek-forward.svg
  icons/actions/32/media-skip-backward.svg
  icons/actions/32/media-skip-forward.svg

To: romangg
Cc: #frameworks, michaelh

D11044: Don't try to find an icon for an empty url

[Jaime Torres Amate]

jtamate added a comment.


  In D11044#218896 , @dfaure wrote:
  
  > Wait, who's calling KIO::iconNameForUrl() with an empty URL? This should be 
an assert or an early-return at the top of that method, not nested into one 
specific if(). Even the very beginning, db.mimeTypeForUrl(url), makes no sense 
for an empty URL.
  
  
  When I just click in network in the save dialog,  
KFileWidgetPrivate::_k_urlEntered just has the following data:
  url= QUrl("remote:/") but filename=locationEditCurrentText() == ""
  
  #11 0x7f96d01cca5b in KProtocolInfo::icon (_protocol=...) at 
/home/jtorres/kdesrc/frameworks/kio/src/core/kprotocolinfo.cpp:251
  #12 0x7f96d01c87c0 in KIO::iconNameForUrl (url=...) at 
/home/jtorres/kdesrc/frameworks/kio/src/core/global.cpp:332
  #13 0x7f96ba0c2cb5 in **KFileWidgetPrivate::_k_urlEntered** 
(this=0x7f96b40091a0, url=...) at 
/home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kfilewidget.cpp:1487
  #14 0x7f96ba0ca25d in KFileWidget::qt_static_metacall (_o=0x210a3a0, 
_c=QMetaObject::InvokeMetaMethod, _id=9, _a=0x7ffdb629f960) at 
/home/jtorres/kdesrc/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kfilewidget.cpp:176
  #15 0x7f96cbed302a in QMetaObject::activate(QObject*, int, int, void**) 
() from /usr/lib64/libQt5Core.so.5
  #16 0x7f96ba0a6eef in KDirOperator::urlEntered (this=0x218f400, _t1=...) 
at 
/home/jtorres/kdesrc/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kdiroperator.cpp:602
  #17 0x7f96ba09a83d in KDirOperator::setUrl (this=0x218f400, _newurl=..., 
clearforward=true) at 
/home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kdiroperator.cpp:1040
  #18 0x7f96ba0c2bea in KFileWidget::setUrl (this=0x210a3a0, url=..., 
clearforward=true) at 
/home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kfilewidget.cpp:1469
  #19 0x7f96ba0c2f52 in KFileWidgetPrivate::_k_enterUrl 
(this=0x7f96b40091a0, url=...) at 
/home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kfilewidget.cpp:1523
  #20 0x7f96ba0ca280 in KFileWidget::qt_static_metacall (_o=0x210a3a0, 
_c=QMetaObject::InvokeMetaMethod, _id=10, _a=0x7ffdb629fd10) at 
/home/jtorres/kdesrc/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kfilewidget.cpp:177
  #21 0x7f96cbed302a in QMetaObject::activate(QObject*, int, int, void**) 
() from /usr/lib64/libQt5Core.so.5
  #22 0x7f96ba0e429f in KFilePlacesView::urlChanged (this=0x22c4f40, 
_t1=...) at 
/home/jtorres/kdesrc/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kfileplacesview.cpp:263
  #23 0x7f96ba0e2a3a in KFilePlacesView::Private::setCurrentIndex 
(this=0x2267fb0, index=...) at 
/home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kfileplacesview.cpp:1113
  #24 0x7f96ba0e3719 in KFilePlacesView::Private::_k_placeClicked 
(this=0x2267fb0, index=...) at 
/home/jtorres/kdesrc/frameworks/kio/src/filewidgets/kfileplacesview.cpp:1330
  #25 0x7f96ba0e3e41 in KFilePlacesView::qt_static_metacall (_o=0x22c4f40, 
_c=QMetaObject::InvokeMetaMethod, _id=9, _a=0x7ffdb629ff20) at 
/home/jtorres/kdesrc/build/frameworks/kio/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kfileplacesview.cpp:167
  #26 0x7f96cbed302a in QMetaObject::activate(QObject*, int, int, void**) 
() from /usr/lib64/libQt5Core.so.5
  #27 0x7f96cd0e6cd5 in QAbstractItemView::clicked(QModelIndex const&) () 
from /usr/lib64/libQt5Widgets.so.5
  #28 0x7f96cd0e9a4b in QAbstractItemView::mouseReleaseEvent(QMouseEvent*) 
() from /usr/lib64/libQt5Widgets.so.5
  #29 0x7f96cd126cbf in QListView::mouseReleaseEvent(QMouseEvent*) () from 
/usr/lib64/libQt5Widgets.so.5

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11044

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh

D11013: Detect incorrect paramenter in findProtocol

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Yes, but please don't push this until you have fixed the caller in your 
testcase, and used a Plasma/KF5 session with these asserts enabled for 2 weeks.
  
  Thanks ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11013

To: jtamate, #frameworks, dfaure
Cc: michaelh

D11044: Don't try to find an icon for an empty url

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Wait, who's calling KIO::iconNameForUrl() with an empty URL? This should be 
an assert or an early-return at the top of that method, not nested into one 
specific if(). Even the very beginning, db.mimeTypeForUrl(url), makes no sense 
for an empty URL.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11044

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh

D11044: Don't try to find an icon for an empty url

[Kai Uwe Broulik]

broulik added a comment.


  Shouldn't it check emptiness of the url scheme specifically?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11044

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh

D11037: balooctl: checkDb should also verify the last known url for the documentId.

[Michael Heidelbach]

michaelh added a comment.


  `balooctl checkDb` is no more. See D10778 
. We could turn it into a separate 
executable like 'balooDbDebug' or so. It should be made clear then that it is 
for developers only.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11037

To: smithjd, #baloo
Cc: michaelh, #frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11013: Detect incorrect paramenter in findProtocol

[Jaime Torres Amate]

jtamate added a dependent revision: D11044: Don't try to find an icon for an 
empty url.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11013

To: jtamate, #frameworks, dfaure
Cc: michaelh

D11044: Don't try to find an icon for an empty url

[Jaime Torres Amate]

jtamate added a dependency: D11013: Detect incorrect paramenter in findProtocol.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11044

To: jtamate, #frameworks, dfaure
Cc: michaelh

D11044: Don't try to find an icon for an empty url

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  The message kf5.kio.core: Refilling KProtocolInfoFactory cache in the hope to 
find "" 
  was produced when findProtocol was called by KProtocolInfo::icon that was
  called with an empty url.

TEST PLAN
  No more Refilling KProtocolInfoFactory cache in the hope to find "" when 
browsing net or samba shares.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11044

AFFECTED FILES
  src/core/global.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh

D11013: Detect incorrect paramenter in findProtocol

[Jaime Torres Amate]

jtamate updated this revision to Diff 28679.
jtamate retitled this revision from "Remove trailing data in the protocol 
parameter in findProtocol" to "Detect incorrect paramenter in findProtocol".
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  I've detected so far only the case of KProtocolInfo::icon with "", in a 
dependent revision.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11013?vs=28566=28679

REVISION DETAIL
  https://phabricator.kde.org/D11013

AFFECTED FILES
  src/core/kprotocolinfofactory.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh

D11038: balooctl: Add pruneDb option to remove stale file index entries.

[Michael Heidelbach]

michaelh added a comment.


  Baloo is in bad need for something like this. Unfortunately in cannot be done 
so easily.
  We have to account for indexed net shares and removable drives which are only 
temporarily unavailable. Files on those should not be removed. And most likely 
some user interaction is needed here.
  
  #Baloo  has it own Project page now. 
Please have a look and file your plans for Baloo as tasks there. Also I'm very 
much interested in your opinion about the tasks filed there specially about  
T8054  and .

INLINE COMMENTS

> transaction.cpp:264
> +QTextStream out(stdout);
> +out << "Total Document IDs: " << map.size() << endl;
> +

This should go to stderr so only pruned files go to stdout

> transaction.cpp:270
> +if (!QFileInfo::exists(url)) {
> +out << "Purging " << id << endl;
> +m_writeTrans->removeDocument(id);

Place this at the end of the loop and also print url, please. E.g. `out << 
"Removed" << id << ":" << url;` would be easily parseable. So one could catch 
stdout with

  balooctl pruneDb | tr '-d:' -f2 >removed_files.lst

> transaction.cpp:271
> +out << "Purging " << id << endl;
> +m_writeTrans->removeDocument(id);
> +count++;

Can we or should we check the result of the operation here?

> transaction.cpp:276
> +
> +out << "Removed Entries: " << count << " (" << count * 100.0 / 
> map.size() << "%)" << endl;
> +}

Same as above

> main.cpp:90
>  parser.addPositionalArgument(QStringLiteral("monitor"), i18n("Monitor 
> the file indexer"));
> +parser.addPositionalArgument(QStringLiteral("pruneDb"), i18n("Purge 
> invalid index entries"));
>  parser.addPositionalArgument(QStringLiteral("indexSize"), i18n("Display 
> the disk space used by index"));

Just 'prune'?

> main.cpp:326
>  
> +if (command == QStringLiteral("pruneDb")) {
> +Database *db = globalDatabaseInstance();

see above

> main.cpp:329
> +if (!db->open(Database::ReadOnlyDatabase)) {
> +out << "Baloo Index could not be opened\n";
> +return 1;

stderr

> main.cpp:334
> +Transaction tr(db, Transaction::ReadOnly);
> +out << "Checking file paths .. " << endl;
> +tr.pruneFsTree();

stderr

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11038

To: smithjd, #baloo, #frameworks
Cc: michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin

D4911: add Baloo DBus signals for moved or removed files

[Christoph Cullmann]

cullmann added a comment.


  > I did some test today on tbaloo and noticed one problem when fetching the 
results from a query. The paths are encoded like URLs but without the scheme. I 
had to modify my code to use it. Apart from that, nice work. It just works. Are 
you still interested to work on that ?
  
  I would be willing to work more on that, if there is consensus that it should 
replace baloo and we use the synergy with tracker instead of doing all things 
tracker does just once again for the sake of it (beside running in all the same 
security problems).
  But until now, that doesn't look like there is such a consensus.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D4911

To: mgallien, vhanda, dfaure, michaelh, #baloo
Cc: ngraham, cullmann, apol, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella, alexeymin

D10997: Fix conversion of AccessPoint flags to capabilities

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:641f26a3d48d: Fix conversion of AccessPoint flags to 
capabilities (authored by fvogt).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10997?vs=28512=28676

REVISION DETAIL
  https://phabricator.kde.org/D10997

AFFECTED FILES
  src/accesspoint.cpp

To: fvogt, #frameworks, jgrulich, kfunk
Cc: #frameworks, michaelh

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Jaime Torres Amate]

jtamate added a comment.


  In D10742#218222 , @markg wrote:
  
  > In D10742#218171 , @dfaure wrote:
  >
  > > Can someone explain to me how switching from pointers to values is making 
anything faster, or is a first step towards making anything faster? This step 
in itself can only make things slower due to more "copying" (refcount updating).
  >
  >
  > I don't know what the ultimate goal of @jtamate is here (speeding things 
up, that i do know).
  
  
  Hi,
  
To speedup findByUrl, there are strategies like using a QHash for DirItem* 
or just having it sorted and search using std::binary_search.
I guess this will be easier to do if there are less pointers in the path, 
therefore  I'm just trying to remove a TODO: introduced in 
4b498196899223692e8a7d334618b2874bb6c77e in 2014.
I haven't done any benchmarks on this code yet, first it needs to pass all 
the tests.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: markg, michaelh