D24490: Make kconfig_compiler generate ctors with the optional parent arg

ervin added a comment. Any chance to get another round of reviews now that this patch changed quite a bit? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: kossebau, apol, kde-frameworks-devel, LeGast00n,

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

ervin added a comment. Any chance to get another round of reviews now that this patch changed quite a bit? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24494 To: ervin, #plasma, #frameworks, dfaure, mart Cc: kossebau, davidedmundson, kde-frameworks-devel,

D24355: TypeScript: update grammar and fixes

nibags updated this revision to Diff 67588. nibags added a comment. - TypeScript React: fix end-line regex REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24355?vs=67587=67588 BRANCH update-typescript REVISION DETAIL

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/36/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 10 Oct 2019 03:26:51 + Build duration: 1 hr 26 min and counting JUnit Tests Name:

D24355: TypeScript: update grammar and fixes

nibags updated this revision to Diff 67587. nibags added a comment. typescript-react: increase version. javascript: use non-capturing groups in RegExpr REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24355?vs=67162=67587 BRANCH

D24355: TypeScript: update grammar and fixes

nibags added a comment. ups! i will correct it REPOSITORY R216 Syntax Highlighting BRANCH update-typescript REVISION DETAIL https://phabricator.kde.org/D24355 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 60 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/60/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 10 Oct 2019 03:27:17 + Build duration: 20 min and counting BUILD ARTIFACTS

Re: How to prevent users from opening GitLab issues?

You can add templates by following the directions here: https://docs.gitlab.com/ee/user/project/description_templates.html#creating-issue-templates (Similar steps for pull requests, check out the kdeconnect-kde repo if you want the templates I made) Unfortunately regular developers can't set the

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

ndavis added a comment. Thanks REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7fea43c57c59: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24477?vs=67456=67586

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

ndavis retitled this revision from "[PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation" to "Add PATH/LD_LIBRARY_PATH to qrcAlias invocation". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg,

D24477: [PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67584. kossebau added a comment. improve documentation, especially about the generated C++ macros REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67554=67584 BRANCH addgenerateexportheader

Akonadi SchemaVersionTable is broken with PostgreSQL Version 12 changes

Dear development team, As per the PostgreSQL release documents: E.1. Release 12 https://www.postgresql.org/docs/12/release-12.html#id-1.11.6.5.5 PostgreSQL Version 12 removes: obsolete pg_constraint.consrc column obsolete pg_attrdef.adsrc column Akonadi executes this query that fails due to

D24524: Add a common widget config control library starting with ConfigIcon.qml

Zren created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Zren requested review of this revision. REVISION SUMMARY I'm submitting this to start discussion on creating a common config control library. I've started with a more common

Re: How to prevent users from opening GitLab issues?

One should be able to add a issue template to issues (similar to how diffs are prefilled in phab), which would make clear the purpose of issues. feverfew On Wed, 9 Oct 2019, 19:23 Nate Graham, wrote: > GitLab Issues are intended to be the replacement for Phabricator tasks > and are not

Re: How to prevent users from opening GitLab issues?

GitLab Issues are intended to be the replacement for Phabricator tasks and are not intended to be used for user bug reports. We can't disable this feature or else we lose the project task tracking functionality entirely, which would be a major regression compared to Phabricator. Yes, it is

D4363: Don't set gnu style parameter with Clang and MSVC

cullmann added a comment. Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. Is this still relevant? If yes, from the diff, looks ok for me. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4363

D24355: TypeScript: update grammar and fixes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems fine. Does typescript-react.xml lack a version update? REPOSITORY R216 Syntax Highlighting BRANCH update-typescript REVISION DETAIL https://phabricator.kde.org/D24355

D24357: KateModeMenuList: force the vertical position above the button

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok with that. REPOSITORY R39 KTextEditor BRANCH menu-vertical-position REVISION DETAIL https://phabricator.kde.org/D24357 To: nibags, #ktexteditor, cullmann, dhaumann Cc:

How to prevent users from opening GitLab issues?

As we transition to Gitlab, our users find two different ways of reporting issues: in Bugzilla and in Gitlab. Since we don't have plans to deprecate bugzilla, is there any way we can disable issues in Gitlab? Albert

D23835: Add TabKCM

ngraham added a dependent revision: D24224: Start of the accessibility KCM. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23835 To: nicolasfella, mart Cc: onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh I see. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added a comment. In D24453#544251 , @ngraham wrote: > +1. Can you do the same thing for the similar header that's seen in System Settings' icon view? > > F7556761: Screenshot_20191009_085522.png

D24522: Add presentwindows icon (old "task view" from windows)

Zren added a comment. > `preferences-system-windows-effect-presentwindows` That would look like the `homerun` icon, which looks like the "windows" logo. F7557693: 2019-10-09___13-01-07.png When you clicked on "Task View" in Windows, the 2

D24502: Replace recursion in FilteredDirIterator with loop iteration

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3319b6656043: Replace recursion in FilteredDirIterator with loop iteration (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24502?vs=67506=67569

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/26/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 09 Oct 2019 16:30:24 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 09 Oct 2019 16:13:29 + Build duration: 2 min 28 sec and counting JUnit Tests Name:

D24522: Add presentwindows icon (old "task view" from windows)

ngraham added a comment. Thanks! However I'm not sure this is the most accurate icon to depict the Present Windows effect. It shows one window in the front obscuring two windows behind it. This would seem to depict the macOS "coverflow" effect

D24522: Add presentwindows icon (old "task view" from windows)

Zren created this revision. Zren added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Zren requested review of this revision. REVISION SUMMARY Needed for T11776 , but only we we want the widget

D24502: Replace recursion in FilteredDirIterator with loop iteration

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This makes sense to me. REPOSITORY R293 Baloo BRANCH iterative_filtereddiriterator REVISION DETAIL https://phabricator.kde.org/D24502 To: bruns, #baloo, ngraham, astippich Cc:

D24263: edit mode action

mart added inline comments. INLINE COMMENTS > broulik wrote in corona.cpp:378 > Why is this switch to explicitly stating all the cases? > The action is always visible and enabled only when Mutable ah, it wanted to be setVisible(false) in case of systemimmutable, so they should be all different

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a comment. +1. Can you do the same thing for the similar header that's seen in System Settings' icon view? F7556761: Screenshot_20191009_085522.png REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453

D24263: edit mode action

mart updated this revision to Diff 67557. mart added a comment. - add parameter to editModeChanged - hide action on systemimmutable REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24263?vs=67113=67557 BRANCH phab/editModeActionwq!

D24492: [FilteredDirIterator] Reduce stack pressure

hurikhan77 abandoned this revision. hurikhan77 added a comment. Let's close this in favor of https://phabricator.kde.org/D24502 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To: hurikhan77, #baloo Cc: bruns, cullmann, shubham, kde-frameworks-devel, lots0logs,

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau marked 2 inline comments as done. kossebau added inline comments. INLINE COMMENTS > dfaure wrote in ECMGenerateExportHeader.cmake:269 > Really? Isn't doWhat excluded only if EXCLUDE_DEPRECATED_BEFORE_AND_AT is set > to 5.12.0? > With 5.0.0 it's still available, no? > > I'm also

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67554. kossebau marked an inline comment as done. kossebau added a comment. - update to David's findings in the docs REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67523=67554 BRANCH

D24263: edit mode action

broulik added inline comments. INLINE COMMENTS > corona.cpp:378 > +switch (d->immutability) { > +case Types::UserImmutable: > +action->setEnabled(false); Why is this switch to explicitly stating all the cases? The action is always visible and enabled only when

D24492: [FilteredDirIterator] Reduce stack pressure

bruns added a comment. In D24492#543641 , @hurikhan77 wrote: > Let me change that into a proper loop. See D24502 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To:

D24502: Replace recursion in FilteredDirIterator with loop iteration

bruns added reviewers: ngraham, astippich. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24502 To: bruns, #baloo, ngraham, astippich Cc: kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

Re: Work Branches

On woensdag 9 oktober 2019 12:32:39 CEST David Edmundson wrote: > > 2) Protect all branches, aside from a given prefix (proposed to be work/) > > Works for me. > Would protection here also cover deletion? If so we need some heads up > notice in Plasma to do a mass move of people's forks. > In

Re: Work Branches

> 2) Protect all branches, aside from a given prefix (proposed to be work/) Works for me. Would protection here also cover deletion? If so we need some heads up notice in Plasma to do a mass move of people's forks.

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre marked an inline comment as done. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, #kpublictransport, #amarok Cc: ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre updated this revision to Diff 67529. davidre added a comment. Make code more expressive and add comments REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24453?vs=67480=67529 BRANCH newcategorystyle (branched from master) REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 121 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/121/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 09 Oct 2019 07:16:20 + Build duration: 8 min 38 sec and counting JUnit Tests Name: