tier3/kprintutils/src/CMakeLists.txt 5d797d1
tier3/ktextwidgets/CMakeLists.txt a8b4aa9
tier3/xmlgui/CMakeLists.txt a45d86d
tier3/xmlgui/src/CMakeLists.txt 9677b0a
Diff: http://git.reviewboard.kde.org/r/113052/diff/
Testing
---
Everything keeps building
Thanks,
Aleix Pol
dnssd/src/servicebrowser.h
dnssd/src/servicemodel.h
dnssd/src/servicemodel.cpp
dnssd/src/servicetypebrowser.h
dnssd/src/settings.kcfgc
tier2/CMakeLists.txt 73175b3
Diff: http://git.reviewboard.kde.org/r/112942/diff/
Testing
---
Builds, no tests
Thanks,
Aleix Pol
---
Everything keeps building
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
Everything still builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113039/#review41141
---
Ship it!
Woa amazing :)
+1
- Aleix Pol Gonzalez
On Oct. 1
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/#review41179
---
Ship it!
Looks good to me
- Aleix Pol Gonzalez
On Oct. 2
that at the moment is quite
verbose.
Diffs
-
modules/ECMMarkAsTest.cmake f1e53e4
Diff: http://git.reviewboard.kde.org/r/112772/diff/
Testing
---
Ported some tests in KF5, it worked.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112928/#review41181
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 27, 2013
dnssd/src/servicebrowser.h
dnssd/src/servicemodel.h
dnssd/src/servicemodel.cpp
dnssd/src/servicetypebrowser.h
dnssd/src/settings.kcfgc
tier2/CMakeLists.txt 73175b3
Diff: http://git.reviewboard.kde.org/r/112942/diff/
Testing
---
Builds, no tests
Thanks,
Aleix Pol
the module to its tier yet)
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/113087/#comment30222
It's missing tons of dependencies, you want to add them later?
khtml/src/CMakeLists.txt
http://git.reviewboard.kde.org/r/113087/#comment30221
We usually put the find_package in the root CMakeLists.txt
(khtml/CMakeLists.txt)
- Aleix Pol Gonzalez
On Oct. 3, 2013
remove this
- Aleix Pol Gonzalez
On Oct. 3, 2013, 10:56 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113088
://git.reviewboard.kde.org/r/113094/#comment30230
I think now it's kpty. Does it build?
- Aleix Pol Gonzalez
On Oct. 4, 2013, 9:58 a.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
, visit:
http://git.reviewboard.kde.org/r/113086/#review41220
---
On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41215
---
On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote
Diff: http://git.reviewboard.kde.org/r/113097/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
as PlasmaWidgets
I'm unsure what to do with those. (can do in a further commit, we're not moving
the module to its tier yet)
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/113008/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113110/#review41260
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 4, 2013, 8
guess it's too late
in the night, at least my brain noticed a few minutes later. :D
Anyway, it was meant as a compliment, now I shut up. :)
Have a good weekend guys!
- Aleix Pol Gonzalez
On Oct. 5, 2013, 12:14 a.m., Aleix Pol Gonzalez wrote
/KWalletConfig.cmake.in 4dec013
Diff: http://git.reviewboard.kde.org/r/113105/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
/start_kdeinit/CMakeLists.txt PRE-CREATION
tier1/kwindowsystem/src/CMakeLists.txt 00c92de
Diff: http://git.reviewboard.kde.org/r/113097/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113142/#review41337
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 7, 2013, 11
/#comment30273
Maybe it could be removed?
kded/kbuildsycoca.cpp
http://git.reviewboard.kde.org/r/113148/#comment30274
What happens with this?
- Aleix Pol Gonzalez
On Oct. 7, 2013, 2:43 p.m., Àlex Fiestas wrote
/kinit/CMakeLists.txt 10c226c
staging/kinit/KInitConfig.cmake PRE-CREATION
tier2/kdoctools/CMakeLists.txt a74ef92
tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113149/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
/CMakeLists.txt 10c226c
staging/kinit/KInitConfig.cmake PRE-CREATION
tier2/kdoctools/CMakeLists.txt a74ef92
tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113149/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
/CMakeLists.txt 10c226c
staging/kinit/KInitConfig.cmake PRE-CREATION
tier2/kdoctools/CMakeLists.txt a74ef92
tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113149/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
kioslave/http/tests/CMakeLists.txt 000c488
Diff: http://git.reviewboard.kde.org/r/113155/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
/frameworkintegration/autotests/kdeplatformtheme_unittest.cpp 417e9e1
staging/frameworkintegration/src/platformtheme/khintssettings.cpp 5d5bf82
Diff: http://git.reviewboard.kde.org/r/113112/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde
/kdeclarative/tests/CMakeLists.txt PRE-CREATION
tier3/kdeclarative/tests/test.qml PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113160/diff/
Testing
---
the test starts and seems to work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e
staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19
staging/kinit/src/wrapper.cpp c9d40cc
Diff: http://git.reviewboard.kde.org/r/113170/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
.
Diffs
-
tier1/kjs/src/wtf/Platform.h 843cfd2
Diff: http://git.reviewboard.kde.org/r/113173/diff/
Testing
---
Builds, KJS tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
-CREATION
staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION
staging/kross/src/kjs/CMakeLists.txt cfa026e
Diff: http://git.reviewboard.kde.org/r/113174/diff/
Testing
---
Builds, the test case seems to work.
Thanks,
Aleix Pol Gonzalez
, including kde-workspace.
Couldn't test it, there's no tests for it or even an application to test it :/.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote:
There's also runner-related code in
src/declarativeimports/{core,runnermodel}, these should be reenabled as
well. Possibly, they also need changes to make built. I had disabled this
after a discussion with Aaron (who has refactored
. :) Maybe you should put a note
on KDE5Porting.hml
- Aleix Pol Gonzalez
On Oct. 7, 2013, 5:01 p.m., Vishesh Handa wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113153
/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kjsembed/CMakeLists.txt 8089c4b
Diff: http://git.reviewboard.kde.org/r/113174/diff/
Testing
---
Builds, the test case seems to work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113174/#review41435
---
On Oct. 10, 2013, 1:30 p.m., Aleix Pol Gonzalez wrote
-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113174/#review41456
---
On Oct. 10, 2013, 1:30 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail
59a0a56
kio/tests/CMakeLists.txt a60eac0
kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26
kioslave/http/tests/CMakeLists.txt 000c488
Diff: http://git.reviewboard.kde.org/r/113155/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde
d5142a2
Diff: http://git.reviewboard.kde.org/r/113179/diff/
Testing
---
Everything builds, including kde-workspace.
Couldn't test it, there's no tests for it or even an application to test it :/.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks
another kde4support dependency
less :).
- Aleix Pol Gonzalez
On Oct. 11, 2013, 12:16 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113199
d5e1070
staging/kinit/src/CMakeLists.txt 9fc6736
Diff: http://git.reviewboard.kde.org/r/113170/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113174/#review41564
---
On Oct. 10, 2013, 1:30 p.m., Aleix Pol Gonzalez wrote
d5e1070
staging/kinit/src/CMakeLists.txt 9fc6736
Diff: http://git.reviewboard.kde.org/r/113170/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
://git.reviewboard.kde.org/r/113206/diff/
Testing
---
Makes ktoolbartest pass (and valgrind-proof)
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
them again instead.
Diffs
-
tier3/kiconthemes/src/kiconloader.cpp bf3899a
Diff: http://git.reviewboard.kde.org/r/113206/diff/
Testing
---
Makes ktoolbartest pass (and valgrind-proof)
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
/CMakeLists.txt 4f5c1c8
Diff: http://git.reviewboard.kde.org/r/113237/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
/src/start_kdeinit/start_kdeinit_wrapper.c
staging/kinit/src/wrapper.cpp
tier3/CMakeLists.txt 4f5c1c8
Diff: http://git.reviewboard.kde.org/r/113237/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113243/#review41746
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 14, 2013, 4
---
Sort dependencies out, adopt the different cmake constructions to make sure
everything will be installed properly.
Diffs
-
Diff: http://git.reviewboard.kde.org/r/113248/diff/
Testing
---
builds, teh test seems to work still.
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113247/#review41750
---
Ship it!
Good catch David!
- Aleix Pol Gonzalez
On Oct. 14
/KNotifyConfigConfig.cmake.in fbdea78
staging/knotifyconfig/src/CMakeLists.txt 9be9ba4
staging/knotifyconfig/tests/CMakeLists.txt 1ed0360
Diff: http://git.reviewboard.kde.org/r/113248/diff/
Testing
---
builds, teh test seems to work still.
Thanks,
Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/113248/#review41776
---
On Oct. 14, 2013, 5:33 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113181/#review41821
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 16, 2013, 7
://git.reviewboard.kde.org/r/113276/#comment30542
really needed?
Good work! :)
- Aleix Pol Gonzalez
On Oct. 16, 2013, 4:44 p.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
832cdd2
tools/port-includes.sh PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113300/diff/
Testing
---
Been trying to port an application, to see how it worked.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde
://git.reviewboard.kde.org/r/113248/#review41778
---
On Oct. 14, 2013, 5:33 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
/r/113328/#comment30603
The KF5 find_package should be outside of the if
- Aleix Pol Gonzalez
On Oct. 18, 2013, 12:14 p.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
cases when porting cmake files, adding the Qt libraries as well.
Diffs
-
tools/port-cmake.sh 832cdd2
tools/port-includes.sh PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113300/diff/
Testing
---
Been trying to port an application, to see how it worked.
Thanks,
Aleix Pol
already added it.
- Aleix Pol Gonzalez
On Oct. 21, 2013, 11:23 p.m., Sebastian Kügler wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113377
On Oct. 23, 2013, 2:40 p.m., Chusslove Illich wrote:
I can only say that whatever is the proper fix here, it is fine with me.
Since non-installed headers are being used, maybe ki18n is using KJS in a
way which became deprecated somewhere along the way? If so, I've nothing
against fixing
that instead.
Aleix Pol Gonzalez wrote:
Well the thing is that ki18n was using private API (since it was in the
same module, kdelibs).
Aurélien: what about installing these headers in a private/ directory?
Chusslove Illich wrote:
If I recall, when implementing that I
://paste.opensuse.org/90980400
Diffs
-
modules/ECMGenerateHeaders.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113406/diff/
Testing
---
Ported KParts and still everything works.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks
://git.reviewboard.kde.org/r/113406/diff/
Testing
---
Ported KParts and still everything works.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
On Oct. 24, 2013, 1:40 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406
-platform fix to it.
- Aleix Pol Gonzalez
On Oct. 24, 2013, 3:55 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113422
/kconfigcompiler_test.cpp
http://git.reviewboard.kde.org/r/113423/#comment30775
You can pass CMAKE_EXECUTABLE_SUFFIX from cmake.
- Aleix Pol Gonzalez
On Oct. 24, 2013, 3:59 p.m., Alexander Richardson wrote
On Oct. 21, 2013, 8:06 p.m., Stephen Kelly wrote:
As far as I know, only threadweaver and karchive will be released in
December. The rest of the frameworks won't be released until summer.
By summer, CMake 3.0.0 will most likely be out.
Volker Krause wrote:
while the CMake 3
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote:
modules/ECMGenerateHeaders.cmake, line 29
http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line29
This variable shouldn't be needed at all.
Aleix Pol Gonzalez wrote:
Variable? Or argument? Why?
Stephen
://git.reviewboard.kde.org/r/113406/diff/
Testing
---
Ported KParts and still everything works.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
everything works.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
(DIRECTORY) to install the generated files.
Aleix Pol Gonzalez wrote:
Why?
Stephen Kelly wrote:
I think it's better API. It's what all existing functions which generate
headers do.
Then it's weird because we'll need to have a separate call for installing all
the headers as well, so
---
Ported KParts and still everything works.
File Attachments (updated)
example of how KParts would change
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/43e2c958-9908-4249-9bb6-9395d91b5643__kf5-kparts-headers-test.patch
Thanks,
Aleix Pol Gonzalez
would change
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/43e2c958-9908-4249-9bb6-9395d91b5643__kf5-kparts-headers-test.patch
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
(DIRECTORY) to install the generated files.
Aleix Pol Gonzalez wrote:
Why?
Stephen Kelly wrote:
I think it's better API. It's what all existing functions which generate
headers do.
Aleix Pol Gonzalez wrote:
Then it's weird because we'll need to have a separate call
/CMakeLists.txt a60eac0
kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26
kioslave/http/tests/CMakeLists.txt 000c488
Diff: http://git.reviewboard.kde.org/r/113155/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
(updated)
kparts changes example
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/a3557579-801b-4ee6-8e3d-5d487428759a__kf5-kparts-headers-test.patch
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde
(DIRECTORY) to install the generated files.
Aleix Pol Gonzalez wrote:
Why?
Stephen Kelly wrote:
I think it's better API. It's what all existing functions which generate
headers do.
Aleix Pol Gonzalez wrote:
Then it's weird because we'll need to have a separate call
(DIRECTORY) to install the generated files.
Aleix Pol Gonzalez wrote:
Why?
Stephen Kelly wrote:
I think it's better API. It's what all existing functions which generate
headers do.
Aleix Pol Gonzalez wrote:
Then it's weird because we'll need to have a separate call
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113625/#review43050
---
Ship it!
Looks good to me
- Aleix Pol Gonzalez
On Nov. 5
On Nov. 5, 2013, 1:54 p.m., Aurélien Gâteau wrote:
tier2/kjobwidgets/src/CMakeLists.txt, line 17
http://git.reviewboard.kde.org/r/113643/diff/1/?file=209153#file209153line17
You should replace this line with:
if(${CMAKE_BINARY_DIR} STREQUAL ${CMAKE_CURRENT_BINARY_DIR})
/kde-devel/kde5/include/KDE/KParts/StatusBarExtension
/home/kde-devel/kde5/include/KDE/KParts/TextExtension
/home/kde-devel/kde5/include/KDE/KParts/WindowArgs
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
---
Specify the different dependencies so it builds.
Diffs
-
tier3/kunitconversion/CMakeLists.txt 6895079
Diff: http://git.reviewboard.kde.org/r/113677/diff/
Testing
---
Builds, installs and tests still pass.
Thanks,
Aleix Pol Gonzalez
/KParts/StatusBarExtension
/home/kde-devel/kde5/include/KDE/KParts/TextExtension
/home/kde-devel/kde5/include/KDE/KParts/WindowArgs
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
and tests still pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113681/#review43172
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 6, 2013, 3
: http://git.reviewboard.kde.org/r/113686/diff/
Testing
---
Builds, installs, tests still pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
---
Just find the dependencies.
Diffs
-
tier3/kjsembed/CMakeLists.txt c7a3040
Diff: http://git.reviewboard.kde.org/r/113692/diff/
Testing
---
Builds, installs, I can run the test.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
---
Add the dependencies of dependencies.
Small fixes.
Diffs
-
tier3/knotifyconfig/CMakeLists.txt 8be2ceb
tier3/knotifyconfig/tests/CMakeLists.txt 385ff70
Diff: http://git.reviewboard.kde.org/r/113693/diff/
Testing
---
Builds, installs, the test seems to work.
Thanks,
Aleix
---
Adds dependencies to make sure KNewStuff can be compiled alone
Diffs
-
tier3/knewstuff/CMakeLists.txt f7f4dfa
Diff: http://git.reviewboard.kde.org/r/113694/diff/
Testing
---
Builds and installs. All tests are commented out.
Thanks,
Aleix Pol Gonzalez
On Nov. 7, 2013, 9:21 a.m., Aurélien Gâteau wrote:
It's going in the right direction, but I am wondering whether the
Find*.cmake files should go to extra-cmake-modules instead of being part of
the framework. You should add Steve (skelly) to the review to get his
opinion.
Well, the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113702/#review43211
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 7, 2013, 10
://git.reviewboard.kde.org/r/113695/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/
Testing
---
Builds and installs. All tests are commented out.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
901 - 1000 of 4752 matches
Mail list logo
