D23782: Add "edit-none-border" icon

2019-09-08 Thread Björn Feber
GB_2 abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg, ndavis Cc: trickyricky26, ndavis, ngraham, broulik, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D23782: Add "edit-none-border" icon

2019-09-08 Thread Björn Feber
GB_2 added a comment. The fallback is needed, because Plasma 5.17 depends on Frameworks 5.62, which was already tagged and `edit-none` was the best fallback I could find. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg Cc: trickyricky26,

D23782: Add "edit-none-border" icon

2019-09-08 Thread Björn Feber
GB_2 added a comment. In D23782#527558 , @broulik wrote: > Shouldn't it be "edit-border-none"? No, then it doesn't fall back to `edit-none`. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2,

D23782: Add "edit-none-border" icon

2019-09-08 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY F7329452: edit-none-border Icon.png For D23779

D23777: Fix diff

2019-09-07 Thread Björn Feber
GB_2 removed R242 Plasma Framework (Library) as the repository for this revision. GB_2 removed a project: Frameworks. GB_2 removed subscribers: apol, kde-frameworks-devel. REVISION DETAIL https://phabricator.kde.org/D23777 To: GB_2 Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham,

D23777: Fix diff

2019-09-07 Thread Björn Feber
GB_2 abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23777 To: GB_2 Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel, LeGast00n,

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65592. GB_2 added a comment. Don't hide button if revealing password, like in the PolKit dialog and simplify code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65585=65592 BRANCH

D23777: Fix diff

2019-09-07 Thread Björn Feber
GB_2 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D23777 AFFECTED FILES

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65585. GB_2 added a comment. Fix normal text fields REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65551=65585 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362

D22155: Add new activities and virtual desktops icons

2019-09-07 Thread Björn Feber
GB_2 added a comment. In D22155#527004 , @dfaure wrote: > This commit introduced dangling symlinks, detected by `make` and the CI. > > warning: failed to load external entity "./icons-dark/status/symbolic/content-loading-symbolic.svg" >

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel, LeGast00n,

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65551. GB_2 added a comment. Use `length` property and stop revealing password if field is empty REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65541=65551 BRANCH arcpatch-D10362 REVISION

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 requested review of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel, LeGast00n,

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 edited the summary of this revision. GB_2 edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel,

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65541. GB_2 added a comment. Fix diff REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65540=65541 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362 AFFECTED FILES

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65540. GB_2 added a comment. This revision is now accepted and ready to land. Change `onPressedChanged` back to `onClicked` and only show the button when there is text inside the TextField, like in the PolKit dialog REPOSITORY R242 Plasma Framework

D22173: [kactivities] Use new activities icon

2019-09-07 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R6:004b16aaf129: [kactivities] Use new activities icon (authored by GB_2). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22173?vs=60874=65539 REVISION DETAIL

D22172: [kio-extras] Use new activities icon

2019-09-07 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R320:a4efa5e997df: [kio-extras] Use new activities icon (authored by GB_2). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22172?vs=60873=65538 REVISION DETAIL

D22155: Add new activities and virtual desktops icons

2019-09-07 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b5261c6e3b69: Add new activities and virtual desktops icons (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22155?vs=60836=65532 REVISION

D23749: Add "preferences-desktop-navigation" icon

2019-09-06 Thread Björn Feber
GB_2 added a dependent revision: D23750: Use large colorful category icons in Dolphin settings. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23749 To: GB_2, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23749: Add "preferences-desktop-navigation" icon

2019-09-06 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:debde7d66d89: Add preferences-desktop-navigation icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23749?vs=65502=65503 REVISION DETAIL

D23749: Add "preferences-desktop-navigation" icon

2019-09-06 Thread Björn Feber
GB_2 retitled this revision from "Add preferences-desktop-navigation icon" to "Add "preferences-desktop-navigation" icon". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23749 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham,

D23749: Add preferences-desktop-navigation icon

2019-09-06 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 402910 F7324021: preferences-desktop-navigation Icon.png

D23711: Improve "user-trash" icon

2019-09-04 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:c3a9be4d311a: Improve user-trash icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23711?vs=65376=65377 REVISION DETAIL

D23711: Improve "user-trash" icon

2019-09-04 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D23711 REVISION DETAIL https://phabricator.kde.org/D23711 To: GB_2, #vdg, ngraham, ndavis Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D23711: Improve "user-trash" icon

2019-09-04 Thread Björn Feber
GB_2 updated this revision to Diff 65376. GB_2 added a comment. Fix more 64px hard shadows REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23711?vs=65373=65376 BRANCH arcpatch-D23711 REVISION DETAIL https://phabricator.kde.org/D23711 AFFECTED

D23711: Improve "user-trash" icon

2019-09-04 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23711 To: GB_2, #vdg, ngraham, ndavis Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D23711: Improve "user-trash" icon

2019-09-04 Thread Björn Feber
GB_2 updated this revision to Diff 65373. GB_2 added a comment. Fix margins and hard shadows REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23711?vs=65353=65373 BRANCH arcpatch-D23711 REVISION DETAIL https://phabricator.kde.org/D23711 AFFECTED

D23711: Improve "user-trash" icon

2019-09-03 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Make some gradients and details look better. Old: F7314350: Old Trash Icon.png

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 abandoned this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23286 To: GB_2, #plasma, #frameworks, #vdg, davidedmundson Cc: ngraham, filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 added a comment. > This would disable it when using a touch swipe or a touchpad on the desktop too though, right? That doesn;t seem desirable. I think we on;y want scroll overshoot disabled when using a scroll wheel; for all other cases, IMO it should be on. That's how it is now,

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 added a comment. In D23286#515322 , @ngraham wrote: > +1, but maybe this doesn't go far enough. How about doing it for `ScrollablePage` instead? That would fix https://bugs.kde.org/show_bug.cgi?id=403837 as well as this. I will fix

D23285: Prevent dragging QQC2 ComboBox contents outside menu

2019-08-20 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R858:ec1b5c60c19f: Prevent dragging QQC2 ComboBox contents outside menu (authored by GB_2). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 updated this revision to Diff 64096. GB_2 added a comment. Only affect desktop REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23286?vs=64094=64096 BRANCH prevent-dragging-simplekcm-contents-outside-view (branched from master) REVISION DETAIL

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY You should not be able to drag the contents outside the view, it looks weird.

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23286 To: GB_2, #plasma, #frameworks, #vdg Cc: #vdg, #frameworks, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D23285: Prevent dragging QQC2 ComboBox contents outside menu

2019-08-20 Thread Björn Feber
GB_2 edited the test plan for this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH prevent-dragging-qqc2-combobox-contents-outside-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D23285 To: GB_2, #plasma, #frameworks, #vdg, filipf Cc: #vdg,

D23285: Prevent dragging QQC2 ComboBox contents outside menu

2019-08-20 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, Frameworks, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY You should not be able to drag the items outside the menu, it looks weird. This fixes it.

D19620: Use a searchbar similar to the one in okular

2019-08-17 Thread Björn Feber
GB_2 added a comment. See https://phabricator.kde.org/D19774#inline-110882 REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n,

D19620: Use a searchbar similar to the one in okular

2019-08-16 Thread Björn Feber
GB_2 added a comment. Don't use the unicode ellipsis. We use three dots everywhere. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n,

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Björn Feber
GB_2 added a comment. F7247689: photo5775267645204048231.jpg This would fix the unbalanced icon style in file operation notifications. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23161 To: guoyunhe, #vdg, ndavis,

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-13 Thread Björn Feber
GB_2 added a comment. Maybe instead of hardcoding the blue and red colors you can use the stylesheet colors `ButtonFocus` and `NegativeText`: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets REPOSITORY R266 Breeze Icons REVISION DETAIL

D22884: [RFC] Don't show title on page by default

2019-08-09 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. In D22884#507052 , @ngraham wrote: > This patch simply adjusts the defaults. If we decide to do this, KCMShell can be adjusted to show the title on the page when showing a single KCM. But even

D22155: Add new activities and virtual desktops icons

2019-08-03 Thread Björn Feber
GB_2 added a comment. Actually, it is Frameworks 5.63 that releases on October 12, in time for 5.17 which releases on October 15. I guess I'll need to wait another month. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION

D22822: Add "user-others" icon

2019-08-02 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:4c1c97eb9d9b: Add user-others icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22822?vs=62966=62978 REVISION DETAIL

D22884: [RFC] Don't show title on page by default

2019-08-02 Thread Björn Feber
GB_2 added a comment. In D22884#505656 , @ndavis wrote: > In D22884#505651 , @cfeck wrote: > > > The header title is usually more descriptive (longer) than the icon name, so no. > > > Perhaps

D22822: Add "user-others" icon

2019-08-02 Thread Björn Feber
GB_2 retitled this revision from "Add "users-other" icon" to "Add "user-others" icon". GB_2 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22822 To: GB_2, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n,

D22822: Add "users-other" icon

2019-08-02 Thread Björn Feber
GB_2 updated this revision to Diff 62966. GB_2 added a comment. Rename icon to `user-others` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22822?vs=62782=62966 BRANCH add-users-other-icon (branched from master) REVISION DETAIL

D22822: Add "users-other" icon

2019-08-01 Thread Björn Feber
GB_2 added a comment. In D22822#505557 , @ngraham wrote: > - Can we name it `user-others`? No other icon starts with `user`. Sure. > - Do we really need the 24px version? Well, the other user/group icons also have 24px versions,

D10362: Change reveal password button logic

2019-08-01 Thread Björn Feber
GB_2 abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel, LeGast00n, sbergeron,

D22855: Make "edit-none" a symlink to "dialog-cancel"

2019-07-31 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:2513b6c6f0c2: Make edit-none a symlink to dialog-cancel (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22855?vs=62853=62867 REVISION

D22855: Make "edit-none" a symlink to "dialog-cancel"

2019-07-31 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22855 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22855: Make "edit-none" a symlink to "dialog-cancel"

2019-07-31 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY A "disable" icon better represents "none" and then we don't have two cross icons with different

D22822: Add "users-other" icon

2019-07-30 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 407782 Needed to represent permissions for other users. F7118835: users-other

D22155: Add new activities and virtual desktops icons

2019-07-08 Thread Björn Feber
GB_2 added a comment. In D22155#491783 , @ngraham wrote: > Frameworks 5.60 has been tagged, so this would end up in 5.61 if it lands now. I kind of think we should wait one more month and land it for 5.62 so it's perfectly aligned with Plasma

D22155: Add new activities and virtual desktops icons

2019-07-05 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n,

D22155: Add new activities and virtual desktops icons

2019-07-03 Thread Björn Feber
GB_2 added a comment. In D22155#488981 , @anthonyfieroni wrote: > +1 to be part of Plasma 5.17 Wouldn't my proposed approach be better? Also, only one patch out of many actually affects Plasma. In D22155#488595

D22155: Add new activities and virtual desktops icons

2019-06-30 Thread Björn Feber
GB_2 added a comment. In D22155#488593 , @ngraham wrote: > In D22155#488485 , @anthonyfieroni wrote: > > > Renaming the icon is not quite good, if someone use newer framework and old applications /

D22155: Add new activities and virtual desktops icons

2019-06-30 Thread Björn Feber
GB_2 added a comment. Phew, done! REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg,

D22173: [kactivities] Use new activities icon

2019-06-30 Thread Björn Feber
GB_2 added a dependency: D22155: Add new activities and virtual desktops icons. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D22173 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, michaelh, ngraham, bruns

D22173: [kactivities] Use new activities icon

2019-06-30 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 . F6948432:

D22155: Add new activities and virtual desktops icons

2019-06-30 Thread Björn Feber
GB_2 added a dependent revision: D22173: [kactivities] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham,

D22172: [kio-extras] Use new activities icon

2019-06-30 Thread Björn Feber
GB_2 added a dependency: D22155: Add new activities and virtual desktops icons. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22172 To: GB_2, #plasma, #vdg Cc: kde-frameworks-devel, #vdg, kfm-devel, #plasma, fprice, LeGast00n, fbampaloukas, alexde, feverfew,

D22155: Add new activities and virtual desktops icons

2019-06-30 Thread Björn Feber
GB_2 added a dependent revision: D22172: [kio-extras] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham,

D22172: [kio-extras] Use new activities icon

2019-06-30 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 .

D22155: Add new activities and virtual desktops icons

2019-06-30 Thread Björn Feber
GB_2 added a comment. In D22155#488485 , @anthonyfieroni wrote: > Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new

D22155: Add new activities and virtual desktops icons

2019-06-30 Thread Björn Feber
GB_2 added a dependent revision: D22171: [colord-kde] Use more appropriate icon, because the activities icon changed. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2,

D22155: Add new activities and virtual desktops icons

2019-06-30 Thread Björn Feber
GB_2 added a dependent revision: D22170: [latte-dock] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D22155: Add new activities and virtual desktops icons

2019-06-30 Thread Björn Feber
GB_2 added a dependent revision: D22167: [plasma-workspace] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D22155: Add new activities and virtual desktops icons

2019-06-30 Thread Björn Feber
GB_2 added a dependent revision: D22168: [plasma-desktop] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D22155: Add new activities and virtual desktops icons

2019-06-30 Thread Björn Feber
GB_2 added a dependent revision: D22169: [plasma-active-window-control] Use new activities icon. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc:

D10362: Change reveal password button logic

2019-06-30 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello, elvisangelaccio,

D22155: Add new activities and virtual desktops icons

2019-06-29 Thread Björn Feber
GB_2 added a comment. In D22155#488192 , @ndavis wrote: > Nice job! > > Are there other patches coming soon to fix the code where `preferences-activities` was used? Yeah, I'll make them soon. REPOSITORY R266 Breeze Icons REVISION

D22155: Add new activities and virtual desktops icons

2019-06-29 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY This adds new monochrome icons corresponding to the colorful ones. Also deletes the old

D22055: Improve Job Dialog buttons' icons and text

2019-06-23 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R495 Purpose Library BRANCH better-job-dialog-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22055 To: ngraham, nicolasfella, apol,

D19646: Redesign config pages

2019-06-21 Thread Björn Feber
GB_2 added a comment. It would be great if you also improved the JobDialog buttons: - put them on the right - give them icons REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: GB_2, trmdi, abetts,

D21953: Replace "Details" button with KCollapsibleGroupBox

2019-06-21 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. Thanks! Perhaps just "Details" would be enough. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21953 To: chinmoyr, #vdg, ngraham, GB_2 Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham,

D21782: Add a warning dialog with details, continue, and cancel button

2019-06-13 Thread Björn Feber
GB_2 added a comment. I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/ REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21782 To: chinmoyr, #vdg, #frameworks, dfaure Cc: GB_2,

D10362: Change reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 added a comment. In D10362#202592 , @elvisangelaccio wrote: > Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho). > > Would it be possible to implement this feature

D10362: Change reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 retitled this revision from "Swap reveal password button logic" to "Change reveal password button logic". REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2,

D10362: Swap reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello,

D10362: Swap reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 added a comment. Changed `onClicked` to `onPressedChanged` REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc:

D10362: Swap reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 updated this revision to Diff 59081. GB_2 added a comment. Change reveal password button logic REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=26701=59081 BRANCH change-reveal-password-button-logic (branched from master)

D10362: Swap reveal password button logic

2019-06-03 Thread Björn Feber
GB_2 commandeered this revision. GB_2 added a reviewer: broulik. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel,

D20934: Rename file dialog "Filter" label text to "Type"

2019-05-01 Thread Björn Feber
GB_2 abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20934 To: GB_2, #frameworks, #plasma, #vdg, elvisangelaccio Cc: elvisangelaccio, #vdg, #plasma, kde-frameworks-devel, #frameworks, michaelh, ngraham, bruns

D20934: Rename file dialog "Filter" label text to "Type"

2019-05-01 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Frameworks, Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 79903 The term "Filter" is a bit strange for choosing a file type,

D20827: Reword some text, a couple clean ups, add a separator

2019-04-25 Thread Björn Feber
GB_2 accepted this revision. REPOSITORY R241 KIO BRANCH rewored REVISION DETAIL https://phabricator.kde.org/D20827 To: meven, ngraham, #frameworks, #vdg, GB_2 Cc: kde-frameworks-devel, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde,

D20827: Reword some text, a couple clean ups, add a separator

2019-04-25 Thread Björn Feber
GB_2 added reviewers: Frameworks, VDG. GB_2 added a project: VDG. REPOSITORY R241 KIO BRANCH rewored REVISION DETAIL https://phabricator.kde.org/D20827 To: meven, ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh,

D19812: Add a web page to view and compare icons of different sizes

2019-04-25 Thread Björn Feber
GB_2 added a comment. I personally think this could be quite useful. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: trickyricky26, GB_2, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes

2019-04-24 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:2cbbfe2351a6: Rename edit-remove icon to edit-delete-remove to support Oxygen and other… (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20791?vs=56905=56907#toc REPOSITORY

D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes

2019-04-24 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Icon themes that don't have the icon will now fall back to `edit-delete`. TEST PLAN Search for

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

2019-04-23 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:7c6559bdb86f: Add edit-remove icon symlink and add 22px version of paint-none and edit… (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

2019-04-23 Thread Björn Feber
GB_2 updated this revision to Diff 56835. GB_2 added a comment. Fix one 16px path point REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56834=56835 BRANCH add-edit-remove-icon (branched from master) REVISION DETAIL

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

2019-04-23 Thread Björn Feber
GB_2 retitled this revision from "Add "edit-remove" icon symlink and add 22px version of "paint-none"" to "Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg,

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

2019-04-23 Thread Björn Feber
GB_2 updated this revision to Diff 56834. GB_2 added a comment. (Hopefully) fix icons and add 22px version of `edit-none` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56747=56834 BRANCH add-edit-remove-icon (branched from master)

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

2019-04-22 Thread Björn Feber
GB_2 updated this revision to Diff 56747. GB_2 added a comment. Fix icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56707=56747 BRANCH add-edit-remove-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D20700

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

2019-04-22 Thread Björn Feber
GB_2 retitled this revision from "Add "edit-remove" icon symlink" to "Add "edit-remove" icon symlink and add 22px version of "paint-none"". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel,

D20700: Add "edit-remove" icon symlink

2019-04-22 Thread Björn Feber
GB_2 updated this revision to Diff 56707. GB_2 added a comment. Add 22px version of `paint-none` and add symlink for it REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56651=56707 BRANCH add-edit-remove-icon (branched from master) REVISION

D20536: Use consistent default Kickoff user icon

2019-04-21 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:1c6e30d312c7: Use consistent default Kickoff user icon (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20536?vs=56677=56678#toc REPOSITORY R266 Breeze Icons CHANGES

<    1   2   3   4   >