D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb updated this revision to Diff 53928. ognarb added a comment. Use Unicode ellipsis REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53906=53928 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb planned changes to this revision. ognarb added a comment. Look likes I misread a part of the HIG: Since the placeholder won’t be visible anymore as soon as the user types, you should only use it on standalone input elements, not in groups of input elements such as forms. So the

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb updated this revision to Diff 53922. ognarb added a comment. Use proper Unicode ellipsis REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19771?vs=53919=53922 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19771 AFFECTED FILES

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb added a reviewer: VDG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann,

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ognarb requested review of this revision. REVISION SUMMARY See https://hig.kde.org/style/writing/placeholder.html Also change Find -> Search in Search and

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb updated this revision to Diff 53906. ognarb added a comment. Remove icon to option button REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53505=53906 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19557: Update design to look more similar to kde.org

2019-03-10 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R238:a67daca8199c: Update design to look more similar to kde.org (authored by ognarb). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53616=53617 REVISION

D19557: Update design to look more similar to kde.org

2019-03-10 Thread Carl Schwan
ognarb added a comment. In D19557#428634 , @ltoscano wrote: > Thank you! And sorry for the ping-pong. No problems ;) Thanks for the review. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL

D19557: Update design to look more similar to kde.org

2019-03-10 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor, ltoscano Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh,

D19557: Update design to look more similar to kde.org

2019-03-10 Thread Carl Schwan
ognarb updated this revision to Diff 53616. ognarb added a comment. Don't change image link and remove kde.png REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53603=53616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557

D19557: Update design to look more similar to kde.org

2019-03-10 Thread Carl Schwan
ognarb retitled this revision from "Update css" to "Update design to look more similar to kde.org". ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg,

D19557: Update css

2019-03-10 Thread Carl Schwan
ognarb added a comment. In D19557#428618 , @ltoscano wrote: > In D19557#428617 , @ognarb wrote: > > > They use the old link for the image, also the jpg version instead of the png. I tested with new

D19557: Update css

2019-03-10 Thread Carl Schwan
ognarb added a comment. In D19557#428614 , @ltoscano wrote: > No, wait a minute. What happens with pages which are not regenerated? They use the old link for the image, also the jpg version instead of the png. I tested with new page and

D19557: Update css

2019-03-10 Thread Carl Schwan
ognarb updated this revision to Diff 53603. ognarb added a comment. Don't change image size REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53598=53603 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

2019-03-10 Thread Carl Schwan
ognarb updated this revision to Diff 53598. ognarb added a comment. - Add deleted image - Rename top-kde.png to kde.png - Fix strange margin issues for some elements @rooty The font can be changed in the khelpcenter settings. But it's strange that it doesn't use Plasma settings per

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53546. ognarb added a comment. Apply optipng. Thanks @bruns I learned something new :D. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53545=53546 BRANCH master REVISION DETAIL

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53545. ognarb added a comment. Use inkscape to generate png REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53544=53545 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb added a comment. Lol 128x128 png image 6kb, 129x129 png image 2kb REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham,

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53544. ognarb added a comment. Use a 128x128 png image REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53542=53544 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb added a comment. In D19557#428086 , @bruns wrote: > Is it intentional the PNG is 129x129 while the JPEG is 128x128? I have no idea why 129x129. I used `convert` to convert the svg to png, just like I did with the jpg. But I will

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53542. ognarb added a comment. Change png image REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53541=53542 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53541. ognarb added a comment. Use png instead of jpg REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53521=53541 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb added a comment. @aacid it is ready to land? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53521. ognarb added a comment. Use correct breeze color for important and warning REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53469=53521 BRANCH master REVISION DETAIL

D19620: Use a searchbar similar to the one in okular

2019-03-09 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-09 Thread Carl Schwan
ognarb updated this revision to Diff 53505. ognarb added a comment. Add icons REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53488=53505 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Carl Schwan
ognarb updated this revision to Diff 53488. ognarb edited the summary of this revision. ognarb added a comment. This revision is now accepted and ready to land. Use placeholder text and clearButton REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Carl Schwan
ognarb retitled this revision from "Use a searchbar similar to the one from okular" to "Use a searchbar similar to the one in okular". REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19557: Update css

2019-03-08 Thread Carl Schwan
ognarb updated this revision to Diff 53469. ognarb added a comment. Improve display inline media REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53367=53469 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19620: Use a searchbar similar to the one from okular

2019-03-08 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added reviewers: VDG, Frameworks. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one from okular

2019-03-08 Thread Carl Schwan
ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Improve consistency between different KDE apps. It's not perfect (close button isn't aligned). Screenshot

D19557: Update css

2019-03-07 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

2019-03-07 Thread Carl Schwan
ognarb updated this revision to Diff 53367. ognarb added a comment. Add breeze like style for note/info/warning/tip admonitions and make image responsive REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53359=53367 BRANCH master REVISION

D19557: Update css

2019-03-07 Thread Carl Schwan
ognarb updated this revision to Diff 53359. ognarb edited the test plan for this revision. ognarb added a comment. Change to jpg and remove now useless files REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53251=53359 BRANCH master REVISION

D19557: Update css

2019-03-06 Thread Carl Schwan
ognarb added a comment. In D19557#426051 , @aacid wrote: > Why changing from jpg to png for the image file ? I only had a png version in my hard drive, but if it's a problem I can convert the png in a jpg. In D19557#426057

D19557: Update css

2019-03-05 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

2019-03-05 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

2019-03-05 Thread Carl Schwan
ognarb added reviewers: VDG, Documentation. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

2019-03-05 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

2019-03-05 Thread Carl Schwan
ognarb created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Header look like http://docs.carlschwan.eu/ Screenshot comming TEST PLAN Wasn't

<    1   2   3