, though.
- Christoph Feck
On July 3, 2013, 1:54 p.m., Róbert Szókovács wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111379
report. Using Dolphin I could
rename, delete, and Open With Okteta the file.
- Christoph Feck
On July 3, 2013, 1:54 p.m., Róbert Szókovács wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
=ASSIGNEDbug_status=REOPENEDbug_status=NEEDSINFObug_severity=crashlist_id=697588
Christoph Feck (kdepepo)
KDE Quality Team
: http://git.reviewboard.kde.org/r/111626/diff/
Testing
---
I could not test, my system has no disc drives.
Thanks,
Christoph Feck
e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111633/#review36261
---
On July 21, 2013, 4:40 p.m., Christoph Feck wrote:
---
This is an automatically generated e-mail
On July 21, 2013, 4:47 p.m., Albert Astals Cid wrote:
Is that qt change really needed? Otherwise we are a bit past the dependency
freeze
Christoph Feck wrote:
CMakeLists.txt already requires Qt 4.8.0.
Albert Astals Cid wrote:
But isn't the content of CMakeLists.txt
/
- Christoph
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111626/#review37598
---
On Aug. 16, 2013, 12:34 p.m., Christoph Feck wrote
-
kcontrol/dateandtime/dtime.cpp 9bbfee1
Diff: http://git.reviewboard.kde.org/r/112122/diff/
Testing
---
Thanks,
Christoph Feck
of the data files, together with scripts to
compile it to the binary.
- Christoph Feck
On Aug. 14, 2013, 8:30 a.m., Thomas Fischer wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r
testers, see bug 315259.
Thanks,
Christoph Feck
On Tuesday 01 October 2013 15:25:27 Sebastian Kügler wrote:
On Tuesday, October 01, 2013 15:11:51 Stephen Kelly wrote:
We're planning to merge the frameworks-scratch branch of
kde-workspace into master next Monday.
I tried building the branch. It requires qimageblitz, which I
didn't
On Sept. 23, 2013, 4:18 p.m., Sune Vuorela wrote:
Ship It!
Nicolas, do you have or want to obtain commit rights? If not, Nepomuk
developers can commit it for you.
- Christoph
---
This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113185/#review41483
---
Ship it!
Ship It!
- Christoph Feck
On Oct. 10, 2013, 9:51
On Oct. 12, 2013, 6:23 p.m., Jiří Pinkava wrote:
Ship It!
Thanks Jiří. If possible, please request commit rights to the KDE repositories,
so you can commit yourself after each review. This simplifies the work for
others.
- Christoph
On Oct. 12, 2013, 6:23 p.m., Jiří Pinkava wrote:
Ship It!
Christoph Feck wrote:
Thanks Ji?í. If possible, please request commit rights to the KDE
repositories, so you can commit yourself after each review. This simplifies
the work for others.
reviewboard isn't even Unicode safe
to mention 800
pixels...) I hope the key size and font size is not hard coded, did not look at
the code yet.
- Christoph Feck
On Oct. 25, 2013, 7:13 p.m., shivam makkar wrote:
---
This is an automatically generated e-mail. To reply
On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote:
Ah, that makes sense, thanks for your investigation!
What could be done to improve it, is to let the timer fire again sometimes
later, until the item could actually be removed. I am not sure, though, if
it is needed, in other
,
Christoph Feck
omitted the '='
Diffs
-
plasma/generic/runners/calculator/calculatorrunner.cpp 0d52301
Diff: http://git.reviewboard.kde.org/r/113504/diff/
Testing
---
Thanks,
Christoph Feck
understand the letter check correctly, it is
very hard to support functions in the case the user had omitted the '='
Diffs
-
plasma/generic/runners/calculator/calculatorrunner.cpp 0d52301
Diff: http://git.reviewboard.kde.org/r/113504/diff/
Testing
---
Thanks,
Christoph Feck
Hi,
what would be nice to have is information about which MIME types an
application can read and write.
Christoph Feck (kdepepo)
KDE Quality Team
://git.reviewboard.kde.org/r/113846/#comment31365
Use '/' (single quotes) for single characters.
But this line also misses some QLatin1String or QStringLiteral to be
NO_ASCII_CAST safe.
- Christoph Feck
On Nov. 13, 2013, 5:33 p.m., Jonathan Riddell wrote
!
Next in queue: Screenlocker ;)
Btw, is the plan to move KScreen to the Workspace for the Plasma 2
release? It really shouldn't be an extra, but a standard component.
But I am not sure if the plan is to split the Workspace repo or rather
unify it (including Plasma-NM components, etc.).
Christoph
On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote:
This review has been submitted with commit
53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch
frameworks.
Locally, I get this error:
AUTOMOC: error: process for /local/build/kf5/runtime/ktimezoned/ktimezoned.moc
On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote:
This review has been submitted with commit
53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch
frameworks.
Christoph Feck wrote:
Locally, I get this error:
AUTOMOC: error: process for
/local/build
On May 28, 2013, 11:06 a.m., Martin Gräßlin wrote:
Could you please get some feedback from packagers. I'm not sure whether
they like words like unmaintained and upgrade. The fact that we as
upstream don't accept bugs doesn't mean it's unmaintained by the distro and
it's not said that
://git.reviewboard.kde.org/r/113931/diff/
Testing
---
I use this patch since some weeks.
Thanks,
Christoph Feck
On Nov. 20, 2013, 6:02 p.m., Albert Astals Cid wrote:
I don't see why this should fix anything. Do you think anyone in the bug
can provide a valgrind trace to better understand why it's crashing?
See also https://git.reviewboard.kde.org/r/102981/ which has some discussion
and links to
with a patch :P
Anyway, nice analysis, and this probably also fixes bug 290971, but have not
tested it yet.
- Christoph Feck
On Nov. 20, 2013, 9:47 p.m., Yichao Yu wrote:
---
This is an automatically generated e-mail. To reply, visit
. Someone
please confirm it fixes the problem.
Diffs
-
kdeui/widgets/ktabwidget.cpp 49dc293
Diff: http://git.reviewboard.kde.org/r/114017/diff/
Testing (updated)
---
Fixes the crash, according to a tester.
Thanks,
Christoph Feck
, because it is not handled by the tabbar code. Someone
please confirm it fixes the problem.
Diffs
-
kdeui/widgets/ktabwidget.cpp 49dc293
Diff: http://git.reviewboard.kde.org/r/114017/diff/
Testing
---
Fixes the crash, according to a tester.
Thanks,
Christoph Feck
by the tabbar code. Someone
please confirm it fixes the problem.
Diffs
-
kdeui/widgets/ktabwidget.cpp 49dc293
Diff: http://git.reviewboard.kde.org/r/114017/diff/
Testing
---
Fixes the crash, according to a tester.
Thanks,
Christoph Feck
. I do not
know of previous bugs reported for the delegate either, so there is no
need to delay the release to test the reverted state.
Christoph Feck (kdepepo)
KDE Quality Team
openSUSE Review Team
-widgets.
How does Baloo cooperate with Nepomuk? Note that we have ABI
guarantees, so if the metadata is not shared between running instances
of two services, but applications would have to be ported to the new
ABI, then you cannot introduce Baloo in KDE 4.x, but only for KF5.
Christoph Feck
On Dec. 29, 2013, 4:39 p.m., Àlex Fiestas wrote:
I wonder if we could use
https://code.google.com/p/chromium-compact-language-detector/, apparently
it is known to be really small, fast and contained, what do you think?
It probably has better detection (uses quadgraphs instead of
:
- kiconthemes
- kimageformats (including webp plugin from kde-runtime)
- kplotting
- kwidgetsaddons
I may also be interested in kconfigwidgets, kcmutils, kcompletion, and
kguiaddons in the future (I don't know the code good enough yet).
Christoph Feck (kdepepo)
trust you that
Baloo offers better performance than Nepomuk.
But if the above scenario does not work, we should probably not
introduce Baloo for KDE SC 4.x.
Christoph Feck (kdepepo)
KDE Quality Team
applications can get
ported faster this way.
Christoph Feck (kdepepo)
KDE Quality Team
to do with kqmlgraphplugin first, since we can't
have a kdeedu app depending on a playground lib.
Are there technical reasons why we cannot?
Christoph Feck (kdepepo)
at this patch, they
are busy with Plasma Next. If there are no objections in the next 7 days,
please commit it to 4.11 branch.
I do not understand the bug fully, but I am using the patch since a few weeks,
and did not notice a regression (not that I am a heavy krunner user).
- Christoph Feck
.
Thanks,
Christoph Feck (kdepepo)
.
Diffs
-
libs/ksysguard/processui/ksysguardprocesslist.cpp ed2c1ff
Diff: https://git.reviewboard.kde.org/r/113931/diff/
Testing
---
I use this patch since some weeks.
Thanks,
Christoph Feck
On March 26, 2014, 10:07 p.m., Thomas Lübking wrote:
you could sighup or sigusr the greeter process and have it
setImmediateLock(true);
desktopResized();
in return
Wolfgang Bauer wrote:
I agree, this would be a bit nicer...
But I tried it and cannot get it to work.
I cannot remember we had these issues with the KDE3-KDE4 transition.
Can anyone explain what changed? What's wrong with separate prefixes?
Christoph Feck (kdepepo)
On March 2, 2014, 12:03 a.m., Kai Uwe Broulik wrote:
Thanks for looking into this, I have a few code-styling related issues, see
below.
In the future I want to get rid of all of this, especially the magic ints
instead of enums, and move that stuff to Solid - where it's already
/
Testing
---
Thanks,
Christoph Feck
-
kdesu/kdesud/lexer.cpp f2c5db8
Diff: https://git.reviewboard.kde.org/r/118058/diff/
Testing
---
Thanks,
Christoph Feck
it no longer crashes when invoking with --waitforwm, but I have no
idea how to test if it actually works.
Diffs
-
kdeui/kernel/kapplication.cpp cc20f05
Diff: https://git.reviewboard.kde.org/r/103478/diff/
Testing
---
Thanks,
Christoph Feck
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112235/#review58424
---
This probably causes bug 335177.
- Christoph Feck
On Nov
On May 25, 2014, 9:03 p.m., Christoph Feck wrote:
This probably causes bug 335177.
Ignore this, wrong match.
- Christoph
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112235
, you cannot give Ship It to yourself, others have to approve it.
- Christoph Feck
On June 3, 2014, 5:58 a.m., TOM Harrison wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180
rid of nested event loops.
- Christoph Feck
On June 21, 2014, 8:26 a.m., Frank Reininghaus wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118858
On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote:
Hmm, now we seem to have a strange situation between KDE4 and KF5/PN.
The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0)
with libkonq.so.5 pointing to it.
With this change libkonq has a lower version
...
Anyway, if the current patch is all that is needed to restore sanity as in KDE
3, the I am all for getting it fixed.
- Christoph Feck
On June 23, 2014, 5:01 p.m., Wolfgang Bauer wrote:
---
This is an automatically generated e-mail
On June 23, 2014, 10:41 p.m., Christoph Feck wrote:
Not sure why you added Marcel to the list of reviewers...
Anyway, if the current patch is all that is needed to restore sanity as in
KDE 3, the I am all for getting it fixed.
(And if the same issue was the cause for the KRandR
On July 9, 2014, 8:26 a.m., Andrea Iacovitti wrote:
If there are no objections or other suggestions it would be good to have
the bug fixed in 4.11.11 release :)
Thanks Andrea. Could you please check if this also affects bug 244857, bug
325868, or bug 326971 ? Their descriptions all seem
On June 5, 2014, 10:12 a.m., Christoph Feck wrote:
Please add Plasma developers to the group of reviewers.
Btw, you cannot give Ship It to yourself, others have to approve it.
TOM Harrison wrote:
that just a wrong click :)
TOM Harrison wrote:
thanks for reminding
be too
small.
- Christoph Feck
On Aug. 10, 2014, 9:34 p.m., Mathieu Tarral wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119701
( this );
+QHBoxLayout *hbHBoxLayout = new QHBoxLayout(hb);
+hbHBoxLayout-setMargin(0);
+hbHBoxLayout-setSpacing( 4 );
Please do not use hard coded spacings. If you feel the default spacing
provided by the Qt layouts is too big, use some fraction of the font
height as a reference.
Christoph Feck
-of
duplicated - and especially provide charge/discharge time reporting for
individual batteries.
Christoph Feck wrote:
What is the status of this review? From what I see, Joschi resolved all
raised issues.
Kai?
- Christoph
On Sept. 9, 2014, 8:02 p.m., Thomas Lübking wrote:
treeview.cpp, line 232
https://git.reviewboard.kde.org/r/120120/diff/2/?file=310611#file310611line232
Maybe rather try to limit to the font height instead?
Why? We use Small icon size next to text everywhere (buttons, menu items
://git.reviewboard.kde.org/r/120287/#comment46757
here
- Christoph Feck
On Sept. 19, 2014, 10:05 p.m., René J.V. Bertin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287
On Sept. 20, 2014, 8:20 a.m., Martin Gräßlin wrote:
CMakeLists.txt, lines 225-234
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225
tabs instead of whitespaces
René J.V. Bertin wrote:
I looked into those yesterday, and cannot find tabs on my end.
in KDE code, and could be
discussed, but not specific to this bug.
- Christoph Feck
On Sept. 9, 2014, 8:10 p.m., Boris Egorov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
On Sept. 23, 2014, 9:04 p.m., Christoph Feck wrote:
No problem if we want to discuss it longer, and eventually change icon
sizes to match text sizes (as is done in Skulpture style) or optionally
allow configuring icon sizes.
But right now, limiting to a hardcoded 20px value
On Sept. 23, 2014, 9:04 p.m., Christoph Feck wrote:
No problem if we want to discuss it longer, and eventually change icon
sizes to match text sizes (as is done in Skulpture style) or optionally
allow configuring icon sizes.
But right now, limiting to a hardcoded 20px value
Hi,
I got this question from Boris, but do not feel qualified to answer,
so forwarding it here. Please CC Boris in reply.
-- Forwarded Message --
Subject: PVS-Studio KDE analysis
Date: Monday 29 September 2014, 18:04:24
From: Boris Egorov ego...@linux.com
To:
on KDE site?
--
Christoph Feck
http://kdepepo.wordpress.com/
KDE Quality Team
here:
http://developer.kde.org/~cfeck/
Would be nice if someone hacks a script to format them to readable
pages.
Thanks Svyatoslav and Boris!
--
Christoph Feck
http://kdepepo.wordpress.com/
KDE Quality Team
requests on the
qt-project.org site: http://qt-project.org/wiki/Gerrit-Introduction
- Christoph Feck
On Oct. 8, 2014, 11:28 a.m., René J.V. Bertin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Oct. 8, 2014, 11:47 a.m., Christoph Feck wrote:
To get changes into Qt, you directly create the review requests on the
qt-project.org site: http://qt-project.org/wiki/Gerrit-Introduction
Ignore that comment... :P
- Christoph
generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120839/
---
(Updated Oct. 28, 2014, 7:50 p.m.)
Review request for kdelibs, Solid and Christoph Feck.
Bugs: 243046 and 261376
http://bugs.kde.org
/
---
(Updated Oct. 28, 2014, 11:37 p.m.)
Review request for kdelibs, Solid, Christoph Feck, and Helio Castro.
Bugs: 243046 and 261376
http://bugs.kde.org/show_bug.cgi?id=243046
http://bugs.kde.org/show_bug.cgi?id=261376
Repository
On Oct. 29, 2014, 12:02 p.m., Helio Castro wrote:
Ok, way better than the previous one :-)
Frank Schütte wrote:
Thanks for your approval. Now who is going to commit my patch? I don't
have write access to the repository, as far as I know.
Christoph Feck wrote:
me. I am just
users will appreciate this bug getting solved.
Suggestions for next month's bug to the kde-gardening mailing list.
Thanks in advance!
--
Christoph Feck
http://kdepepo.wordpress.com/
KDE Quality Team
/r/120343/
David Faure already approved a backport to KDE 4 there, but was not sure if
release team is okey with the backport.
- Christoph Feck
On Nov. 16, 2014, 2:23 p.m., Mathias Tillman wrote:
---
This is an automatically generated
, how
do I get the correct QPaintDevice needed for the QFontMetrics?
Otherwise, please provide a QFontMetrics (see QStyleOption).
Q_PROPERTY(int smallSpacing
Which unit is this property in? Pixels?
Christoph Feck (kdepepo)
On Friday 28 November 2014 12:00:43 Martin Gräßlin wrote:
On Sunday 16 November 2014 23:30:35 Christoph Feck wrote:
On Friday 31 October 2014 08:22:53 Martin Gräßlin wrote:
today I want to start the review process for the new
KDecoration
Hi Martin,
thanks for the work, here
to the relevant
pages, review requests, or bugzilla pages. Anyone is invited to
participate and our users will appreciate this bug getting solved.
Suggestions for next month's bug to the kde-gardening mailing list.
Thanks in advance!
--
Christoph Feck
http://kdepepo.wordpress.com/
KDE Quality Team
, or as a tooltip. This is a simple accessibility requirement.
Christoph Feck (kdepepo)
frameworks branch can be deleted.
Please rewire CI, translations or whatever else is needed.
Merci :)
Christoph Feck (kdepepo)
4.11 or Applications releases, until everything is ported?
Christoph Feck (kdepepo)
.
Christoph Feck (kdepepo)
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Thanks, please allow me to moderate kde-imaging.
Christoph Feck (kdepepo)
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
oh, well. i give up.
I don't want to. Not yet. But the more I read here, the more confused I get.
Christoph Feck (kdepepo)
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
On Saturday 04 June 2011 15:45:10 Olivier Goffart wrote:
This is a bug in Qt
I'll fix it, thanks for reporting.
(Reported there: http://bugreports.qt.nokia.com/browse/QTBUG-19717 )
Actually http://bugreports.qt.nokia.com/browse/QTBUG-19697 should have
made it to your inbox earlier ...
On Wednesday 08 June 2011 21:45:22 Shantanu Tushar Jha wrote:
Any suggestions on what Qt library I can use for
that? The library should be able to support extraction and compression on
all platforms Qt supports.
If you are asking on a KDE list, you are asking for
probably need to store information which thumbnails where accessed
recently or frequently, so you do not delete the wrong ones.
Christoph Feck (kdepepo)
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
add that
information.
Christoph Feck (kdepepo)
KDE Quality Team
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
On Monday 08 August 2011 08:49:05 Thiago Macieira wrote:
On Monday, 8 de August de 2011 03:18:29 Christoph Feck wrote:
How exactly the massif tool needs to be used to analyze/improve
our KDE applications is beyond this mail; someone else might add
that information.
While not ideal
On Thursday 11 August 2011 12:44:52 Mario Fux wrote:
- Apricot: a mini-computer, thrifty in power consumption and
disappearing behind the screen
Apricot is a registered trademark, http://www.apricotcomputers.com/
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
more bugzilla rights, and resolve bugs accordingly. If
you manage to resolve five bugs a day, we would be very happy.
Christoph Feck (kdepepo)
KDE Quality Team
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
, which is
included in the Qt sources (util/normalize). This way you do not need
to format the sources manually.
Christoph Feck (kdepepo)
KDE Quality Team
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
, but I would prefer the plural name.
Another suggested rename is audiocd-kio to kio-audiocd, which is
in line with other kio repos.
Anyway, good work, I will check the actual contents soon :)
Christoph Feck (kdepepo)
KDE Quality Team
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub
On Wednesday 22 August 2012 22:28:48 Albert Astals Cid wrote:
El Dimecres, 22 d'agost de 2012, a les 02:16:50, Christoph Feck va
escriure:
On Wednesday 22 August 2012 00:54:12 Andreas Pakulat wrote:
// This doesn't work
KPushButton btn;
btn.setIcon(QIcon::fromTheme(QString::fromUtf8
On Wednesday 05 September 2012 20:10:53 Alexander Neundorf wrote:
In KDE3 it was possible to set the wallpaper via dcop in kdesktop.
So we can't do this anymore ?
It's still being worked on, see bug 217950 and linked review request.
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub
On Thursday 01 November 2012 22:19:03 Lamarque V. Souza wrote:
Em Thursday 01 November 2012, Ben Cooksley escreveu:
Hi everyone,
Hi,
The following projects which are in KDE Review appear to have
been there for more than 2 weeks:
- appmenu kded module (kded-appmenu)
- KIMToy
are probably wrong, too. In Qt4,
current != selected, so to reselect the next item after cut/delete,
you have to use the overload that accepts the
QItemSelectionModel::SelectionFlags command.
Christoph Feck (kdepepo)
KDE Quality Team
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub
:)
https://mail.kde.org/mailman/listinfo/kde-pim
Christoph Feck (kdepepo)
KDE Quality Team
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
understand that users might prefer consistency
instead of diversity.
See also http://mobile.osnews.com/printer.php?news_id=26085
Christoph Feck (kdepepo)
KDE Quality Team
Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
301 - 400 of 1041 matches
Mail list logo
