Re: [Kde-hardware-devel] Review Request 121538: Add aboutToSuspend signal

2014-12-15 Thread Kai Uwe Broulik
--- Not really, signal appears on qdbusviewer though. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121537: Remove systemd version checks

2014-12-15 Thread Kai Uwe Broulik
, suspending the session still works and now uses the Login1suspendjob here, although I don't use systemd but I do have logind. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: [Kde-hardware-devel] Review Request 121508: Allow turning off keyboard in dim display action

2014-12-15 Thread Kai Uwe Broulik
?! File Attachments Settings in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/14/f4650b04-42c1-4d4b-b772-710623300fa9__dimkeyboard.png Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware

[Kde-hardware-devel] Review Request 121603: Turn off keyboard in DPMS action

2014-12-19 Thread Kai Uwe Broulik
in sync with the screen (as much as it can be synced given the dpms is handled by the X server) and turns back on when moving the mouse again. Don't know whether the C++11 initializer list I used it permitted here. Thanks, Kai Uwe Broulik ___ Kde

Re: [Kde-hardware-devel] Review Request 121603: Turn off keyboard in DPMS action

2014-12-20 Thread Kai Uwe Broulik
it permitted here. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121506: Add setBrightnessSilent calls that don't show the OSD

2014-12-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121506/#review72376 --- Ping - Kai Uwe Broulik On Dez. 14, 2014, 1 nachm., Kai Uwe

Re: [Kde-hardware-devel] Review Request 121506: Add setBrightnessSilent calls that don't show the OSD

2014-12-22 Thread Kai Uwe Broulik
/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 58a1b80 Diff: https://git.reviewboard.kde.org/r/121506/diff/ Testing --- The calls work as expected for both keyboard and screen, both silent and normal. Thanks, Kai Uwe Broulik

[Kde-hardware-devel] Review Request 121693: Wait for notification service before emitting them

2014-12-27 Thread Kai Uwe Broulik
it was not running (30s timeout), and started plasma shortly after kded (emit once service is there). Works fine, looks much sleeker now, and notifications also only seem to be fired once regardless of when they have been for the first time. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121693: Wait for notification service before emitting them

2014-12-27 Thread Kai Uwe Broulik
/121693/#comment50583 Qt 5.4 would allow us to use a lambda instead - Kai Uwe Broulik On Dez. 27, 2014, 12:53 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-hardware-devel] Review Request 121699: Expose whether a lid is present over dbus

2014-12-28 Thread Kai Uwe Broulik
/powerdevilcore.cpp 05ee2e6 Diff: https://git.reviewboard.kde.org/r/121699/diff/ Testing --- isLidPresent is true on my laptop, dunno why the method is not const but the other one isn't either. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel

[Kde-hardware-devel] Review Request 121798: KScreen fade effect connector for PowerDevil

2015-01-03 Thread Kai Uwe Broulik
to be established *before* powering down). Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121693: Wait for notification service before emitting them

2015-01-02 Thread Kai Uwe Broulik
of when they have been for the first time. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121791: Get rid of profile migrator

2015-01-02 Thread Kai Uwe Broulik
daemon/powerdevilprofilegenerator.h 1882e02 daemon/powerdevilprofilegenerator.cpp 9ae5b73 Diff: https://git.reviewboard.kde.org/r/121791/diff/ Testing --- Removed my powermanagementprofilesrc file, restarted kded, created proper default profile. Thanks, Kai Uwe Broulik

[Kde-hardware-devel] Review Request 121791: Get rid of profile migrator

2015-01-02 Thread Kai Uwe Broulik
Diff: https://git.reviewboard.kde.org/r/121791/diff/ Testing --- Removed my powermanagementprofilesrc file, restarted kded, created proper default profile. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org

[Kde-hardware-devel] Review Request 121815: Cleanup BrightnessOSDWidget

2015-01-03 Thread Kai Uwe Broulik
like it did before. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-02-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/#review75557 --- I suppose this is obsolete now? - Kai Uwe Broulik On Jan

Re: [Kde-hardware-devel] Review Request 122283: Increase the preferred number of screen brightness steps to 20.

2015-02-07 Thread Kai Uwe Broulik
it, but now I managed to get the X server use the intel backlight interface instead. Could you rebase this patch to current master? It didn't apply. - Kai Uwe Broulik On Jan. 27, 2015, 11:10 nachm., Nikita Skovoroda wrote

Re: Review Request 122360: Make FTP error messages prettier

2015-02-08 Thread Kai Uwe Broulik
Diff: https://git.reviewboard.kde.org/r/122360/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[Kde-hardware-devel] Review Request 122414: Port DPMS to XCB

2015-02-03 Thread Kai Uwe Broulik
not test inhibition handling. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122414: Port DPMS to XCB

2015-02-09 Thread Kai Uwe Broulik
button can turn off the screen, and after timeout turns off and properly wakes up again. Did not test inhibition handling. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: [Kde-hardware-devel] Review Request 121915: Add lidClosedChanged signal to org.kde.Solid.PowerManagement

2015-01-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121915/#review74374 --- This has been submitted, right? - Kai Uwe Broulik On Jan

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

2015-01-20 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/121386/diff/ Testing --- My hopes were that it would give us a more precise backlight handling but I get a range of 0..10 nonetheless. Other than that seems to work exactly like it did before. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

2015-01-22 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/121386/diff/ Testing --- My hopes were that it would give us a more precise backlight handling but I get a range of 0..10 nonetheless. Other than that seems to work exactly like it did before. Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 122128: Don't listen for Login1 Lock signal anymore

2015-01-19 Thread Kai Uwe Broulik
, visit: https://git.reviewboard.kde.org/r/122128/#review74288 --- On Jan. 18, 2015, 4:05 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-01-19 Thread Kai Uwe Broulik
/powerdevilupowerbackend.cpp https://git.reviewboard.kde.org/r/122151/#comment51592 Same here - Kai Uwe Broulik On Jan. 19, 2015, 3:46 nachm., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-hardware-devel] Review Request 122130: Expose inhibitions over dbus

2015-01-19 Thread Kai Uwe Broulik
org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement/PolicyAgent org.kde.Solid.PowerManagement.PolicyAgent.ListInhibitions Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

2015-01-19 Thread Kai Uwe Broulik
a range of 0..10 nonetheless. Other than that seems to work exactly like it did before. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 122128: Don't listen for Login1 Lock signal anymore

2015-01-18 Thread Kai Uwe Broulik
, I have no idea how I could tell Login1 to tell others to lock. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122130: Expose inhibitions over dbus

2015-01-18 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/122130/diff/ Testing --- Works, I can list the inhibitions using qdbus --literal org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement/PolicyAgent org.kde.Solid.PowerManagement.PolicyAgent.ListInhibitions Thanks, Kai Uwe Broulik

[Kde-hardware-devel] Review Request 122316: Fix powerdevil brightness calls breaking kded #2

2015-01-29 Thread Kai Uwe Broulik
on the helper now but I was never able to reproduce the problem. The OSD does not show up when changing the brightness through the keys but I don't know whether that was the case without this patch already. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing

Re: [Kde-hardware-devel] Review Request 122316: Fix powerdevil brightness calls breaking kded #2

2015-01-29 Thread Kai Uwe Broulik
the problem. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122316: Fix powerdevil brightness calls breaking kded #2

2015-01-29 Thread Kai Uwe Broulik
/backends/upower/powerdevilupowerbackend.cpp 51a052a Diff: https://git.reviewboard.kde.org/r/122316/diff/ Testing --- I'm running on the helper now but I was never able to reproduce the problem. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

2015-01-24 Thread Kai Uwe Broulik
/uploaded/files/2015/01/24/7ea3d406-0f0a-491b-9539-9de93e42bb4b__powerdevilstuff2.png Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

2015-01-23 Thread Kai Uwe Broulik
behavior, and then rethink adding the options. Inline, a few niggles about naming when reading the code and trying to understand it, nothing really major. Kai Uwe Broulik wrote: That's why I added the usability group. :) You are right that actually neither of these features

Re: Review Request 108312: Use view-certificate for SSL settings KCM

2015-02-01 Thread Kai Uwe Broulik
icon. Diffs - kio/kssl/kcm/kcm_ssl.desktop c1cebd6 Diff: https://git.reviewboard.kde.org/r/108312/diff/ Testing --- kbuildsycoca4 doesn't complain :-) Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 122343: Make sure that brightness up/down actions produce visible changes.

2015-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122343/#review75135 --- Ship it! Ship It! - Kai Uwe Broulik On Jan. 31, 2015, 7

Review Request 122360: Make FTP error messages prettier

2015-02-01 Thread Kai Uwe Broulik
/show_bug.cgi?id=318079 Repository: kio Description --- This is the patch from Review 110084 rebased on frameworks and using remoteEncoding Diffs - src/ioslaves/ftp/ftp.cpp b060c95 Diff: https://git.reviewboard.kde.org/r/122360/diff/ Testing --- Works. Thanks, Kai Uwe

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2015-02-01 Thread Kai Uwe Broulik
elements do). File Attachments KPageDialog icon adapted https://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconding.png Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 107505: Show Battery Low notification on startup along with Broken Battery notifications so it doesn't appear before workspace is up

2015-02-01 Thread Kai Uwe Broulik
, after 30 seconds in the workspace, I got a notification saying my battery is low. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121798: KScreen fade effect connector for PowerDevil

2015-01-05 Thread Kai Uwe Broulik
Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121798: KScreen fade effect connector for PowerDevil

2015-01-05 Thread Kai Uwe Broulik
the fade effect, wait for it to be done and then tell Logind to suspend which completely takes care of the locking (and more importantly the waiting for the lock to be established *before* powering down). Thanks, Kai Uwe Broulik ___ Kde-hardware

[Kde-hardware-devel] Review Request 121857: Remove lock screen on suspend and use fade effect

2015-01-05 Thread Kai Uwe Broulik
and the screen locks, if enabled, both if Logind1 is connected or not (fallback). Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[Kde-hardware-devel] Review Request 121992: Add Battery energyFull and energyFullDesign

2015-01-11 Thread Kai Uwe Broulik
groups. Also, we should really add Q_DECL_OVERRIDE all over the place since adding new methods at 5 different places is quite error-prone. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman

[Kde-hardware-devel] Review Request 121995: Animate screen brightness change

2015-01-11 Thread Kai Uwe Broulik
sliders adjusting slightly delayed. Didn't test using the helper rather than XRandr. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 121992: Add Battery energyFull and energyFullDesign

2015-01-12 Thread Kai Uwe Broulik
. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

2015-01-14 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/122048/#review74001 --- On Jan. 13, 2015, 11:16 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-hardware-devel] Review Request 121995: Animate screen brightness change

2015-02-09 Thread Kai Uwe Broulik
or using the brightness keys, the screen brightness changes smoothly with the OSD reporting the proper value and battery monitor sliders adjusting slightly delayed. Didn't test using the helper rather than XRandr. Thanks, Kai Uwe Broulik ___ Kde-hardware

Review Request 122590: Guard kglobalaccel against QApplication

2015-02-16 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/122590/diff/ Testing --- screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for. Thanks, Kai Uwe Broulik

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-16 Thread Kai Uwe Broulik
and what the widget is actually for. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 121815: Cleanup BrightnessOSDWidget

2015-01-04 Thread Kai Uwe Broulik
/brightnessosdwidget.cpp f85e25c Diff: https://git.reviewboard.kde.org/r/121815/diff/ Testing --- Works like it did before. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: [Kde-hardware-devel] Review Request 121798: KScreen fade effect connector for PowerDevil

2015-01-07 Thread Kai Uwe Broulik
and then tell Logind to suspend which completely takes care of the locking (and more importantly the waiting for the lock to be established *before* powering down). Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org

Re: [Kde-hardware-devel] Review Request 121857: Remove lock screen on suspend and use fade effect

2015-01-07 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/121857/diff/ Testing --- Suspending the machine invokes the fade effect and the screen locks, if enabled, both if Logind1 is connected or not (fallback). Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-11 Thread Kai Uwe Broulik
. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-14 Thread Kai Uwe Broulik
--- On März 13, 2015, 6:36 vorm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893

Review Request 122893: Populate KIconDialog on showEvent

2015-03-10 Thread Kai Uwe Broulik
/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-13 Thread Kai Uwe Broulik
dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-12 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 1e9af6c54470e890597739f8f2189b0743a00b6f by Kai Uwe Broulik to branch master. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-12 Thread Kai Uwe Broulik
button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-03-10 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Frameworks, David Edmundson and Martin Gräßlin. Changes --- Submitted with commit dcb5c0403c5caad901a46b2ae496078af0a90d12 by Kai Uwe Broulik to branch master. Repository: kglobalaccel Description --- KGlobalAccelPrivate uses a QWidget

Re: Review Request 123169: Show percentage value beside brightness level slider

2015-03-29 Thread Kai Uwe Broulik
the percentage from the brightness sliders in the battery monitor since you basically change the brightness to your liking and not to some odd percentage, so adding them back in the PowerDevil settings doesn't make sense. - Kai Uwe Broulik On März 29, 2015, 9:42 vorm., Siddhartha Sahu wrote

Re: Review Request 123169: Show percentage value beside brightness level slider

2015-03-29 Thread Kai Uwe Broulik
On März 29, 2015, 6:34 nachm., Kai Uwe Broulik wrote: Thank you for this patch! However, we chose to remove the percentage from the brightness sliders in the battery monitor since you basically change the brightness to your liking and not to some odd percentage, so adding them back

Re: [Kde-hardware-devel] Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread Kai Uwe Broulik
On März 29, 2015, 6 nachm., Kai Uwe Broulik wrote: File Attachment: snapshot4.png - snapshot4.png https://git.reviewboard.kde.org/r/123164/#fcomment383 It's Paired, what would Connect do? David Rosca wrote: It would connect to the device :) That means, connect the HID

Re: automatic translator for dolphin service menu .desktop files

2015-03-01 Thread Kai Uwe Broulik
Am Samstag, 28. Februar 2015, 01:39:41 schrieb Helmy: thank you Alexander for your reply, the intended use for this is KDE service menus and the text in those is 90% of the time is only one or two words Something like that was done once, and resulted in Space (for the space key) being

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76686 --- Ping, Frameworks people? - Kai Uwe Broulik On Feb. 16

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-26 Thread Kai Uwe Broulik
stuff but I have no idea whether this is the right approach and what the widget is actually for. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] Review Request 121992: Add Battery energyFull and energyFullDesign

2015-01-13 Thread Kai Uwe Broulik
and Windows as well (and IOKit stubs) but I cannot test these, hence adding kdewin and kde-mac groups. Also, we should really add Q_DECL_OVERRIDE all over the place since adding new methods at 5 different places is quite error-prone. Thanks, Kai Uwe Broulik

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2015-01-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/#review73975 --- Ping? - Kai Uwe Broulik On Feb. 28, 2014, 1:53 nachm

Re: Review Request 122029: Fix generation of KAuth DBus helper service file

2015-01-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122029/#review73976 --- Perhaps fixes Bug 337674 and Bug 341775 ? - Kai Uwe Broulik

Re: Distros and QtWebEngine

2015-04-21 Thread Kai Uwe Broulik
‎Note that QtQuick Text never uses RichText unless told, AutoText only enables StyledText when it finds something that looks like a tag before the first line break.    Originalnachricht   Von: Thomas Lübking Gesendet: Montag, 20. April 2015 23:27 An: Jeremy Whiting Cc: kdelibs Betreff: Re:

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-04-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review79218 --- On April 5, 2015, 8:56 nachm., Kai Uwe Broulik wrote

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-04-26 Thread Kai Uwe Broulik
On April 19, 2015, 8:20 nachm., Albert Vaca Cintora wrote: I don't understand the portable media player part. Does it do something? Besides that, I think we need to fix the issues opened by Lamarque and Alex, but looks good to me :) Kai Uwe Broulik wrote: Solid has been designed

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-05-11 Thread Kai Uwe Broulik
On Mai 10, 2015, 5:08 nachm., Kai Uwe Broulik wrote: daemon/backends/upower/powerdevilupowerbackend.cpp, line 175 https://git.reviewboard.kde.org/r/123475/diff/2/?file=362775#file362775line175 Somehow that code path is never executed making init stuck when XRandR is not supported

Re: [Kde-hardware-devel] Review Request 123704: Consider overall percentage when emitting battery warning on startup

2015-05-10 Thread Kai Uwe Broulik
marked as submitted. Review request for Solid. Changes --- Submitted with commit d3d2ebcfd214a892ac79484cfb8cb6fcbf7fc917 by Kai Uwe Broulik to branch Plasma/5.3. Bugs: 347470 https://bugs.kde.org/show_bug.cgi?id=347470 Repository: powerdevil Description --- When you happened

[Kde-hardware-devel] Review Request 123704: Consider overall percentage when emitting battery warning on startup

2015-05-09 Thread Kai Uwe Broulik
/diff/ Testing --- Notification still seems to work fine on my one battery system; I don't have two batteries, so this needs further testing. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-16 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/123806/#comment55182 You could probably simplify that to m_ui.kcfg_WhitespacesAsSymbols-setEnabled(m_ui.kcfg_AllowWhitespaces-isChecked()); - Kai Uwe Broulik On Mai 16, 2015, 12:40 nachm., Patrick Eigensatz wrote

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Kai Uwe Broulik
break. However, if you copy more than one whitespace sequence you won't be able to identify them in the klipper menu. But your concerns are right. I could try to implement an option for this, although I've never done this before and I would surely need some assistance... Kai Uwe

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/123797/#comment55163 use .isEmpty() rather than string comparison plasma-workspace/klipper/historyitem.cpp (line 89) https://git.reviewboard.kde.org/r/123797/#comment55164 return nullptr; - Kai Uwe Broulik On Mai 15, 2015, 2:24 nachm., Patrick Eigensatz

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Kai Uwe Broulik
On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the

Re: Review Request 123736: single QQmlEngine for all applets

2015-05-12 Thread Kai Uwe Broulik
-RequiredExtensions=LaunchApp will still have own engine You mean SharedEngine? :) - Kai Uwe Broulik On Mai 12, 2015, 3:30 nachm., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Solid::AcAdapter gone w/o replacement, ie. all is Battery now?

2015-05-17 Thread Kai Uwe Broulik
Hi Thomas, I'm afraid there is no replacement currently, the overall situation is a bit of a mess. Lukas Tinkl is currently working on a proper replacement for the Solid::PowerManagement stuff, called solid-power, which will have the appShouldConserveResources thingie like the old one.

Re: Solid::AcAdapter gone w/o replacement, ie. all is Battery now?

2015-05-17 Thread Kai Uwe Broulik
The only problem could be if NoCharge means Unknown, but I assume that's academic. NoCharge as far as Solid Battery is concerned means either not charging, not yet charging (eg. just plugged in AC), not yet discharging (pending discharge), or unknown. It does know fully charged, however. My

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Kai Uwe Broulik
against plasma-workspace ;) - Kai Uwe Broulik On Mai 15, 2015, 6:33 nachm., Patrick Eigensatz wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797

[Kde-hardware-devel] Review Request 123418: Add X11 guards

2015-04-18 Thread Kai Uwe Broulik
/xrandrbrightness.cpp f1cd5a5 daemon/kwinkscreenhelpereffect.h 4d0a163 daemon/kwinkscreenhelpereffect.cpp dec5d65 Diff: https://git.reviewboard.kde.org/r/123418/diff/ Testing --- Compiles both with and without HAVE_XCB but I don't have a Wayland setup. Thanks, Kai Uwe Broulik

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/#review79171 --- Please use the kdeframeworks group, kdelibs is 4.x - Kai Uwe

Re: [Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

2015-04-06 Thread Kai Uwe Broulik
/#review78538 --- On April 5, 2015, 5:31 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123262

Re: [Kde-hardware-devel] Review Request 123256: Hardcode device order

2015-04-04 Thread Kai Uwe Broulik
marked as submitted. Review request for Solid. Changes --- Submitted with commit 6219c8e4877b38962af2e0d5db0f8eaa70c03bb8 by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- Rather than going through the device type enum backwards where Battery comes

Re: [Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

2015-04-05 Thread Kai Uwe Broulik
--- On April 5, 2015, 3:44 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123262

Re: [Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

2015-04-05 Thread Kai Uwe Broulik
/powerdevilupowerbackend.cpp 87b9cc7 Diff: https://git.reviewboard.kde.org/r/123262/diff/ Testing --- It's working pretty nicely, I can adjust brightness of my desktop monitor through battery monitor and have it automatically dimmed after a timeout. Thanks, Kai Uwe Broulik

Re: Review Request 123216: Save some memory in kglobalaccel runtime

2015-04-01 Thread Kai Uwe Broulik
/122590/ ? - Kai Uwe Broulik On April 1, 2015, 5:23 nachm., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123216

Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-05 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/124014/#comment55623 You probably want to add an alias for the showAlphaChannel, title, and currentColor properties? - Kai Uwe Broulik On Juni 5, 2015, 10:46 vorm., David Edmundson wrote

Re: [Kde-hardware-devel] Review Request 124037: Allow to cancel critical battery timer

2015-06-08 Thread Kai Uwe Broulik
marked as submitted. Review request for Plasma, Solid and KDE Usability. Changes --- Submitted with commit 9bb399ef24a3323788ef3084f2e404c8831f251b by Kai Uwe Broulik to branch master. Repository: powerdevil Description --- To prevent David from eventually breaking his bones

[Kde-hardware-devel] Review Request 124037: Allow to cancel critical battery timer

2015-06-07 Thread Kai Uwe Broulik
fit into the popup at all now) File Attachments Notification with close button https://git.reviewboard.kde.org/media/uploaded/files/2015/06/07/f99c0164-4436-462f-974b-ddc5df0ce500__powerdevilcanceltimeout.png Thanks, Kai Uwe Broulik

Re: [Kde-hardware-devel] Review Request 124037: Allow to cancel critical battery timer

2015-06-09 Thread Kai Uwe Broulik
--- On Juni 8, 2015, 5:30 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124037

Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-06 Thread Kai Uwe Broulik
- 95) https://git.reviewboard.kde.org/r/124014/#comment55674 Now you get half the opacity opacity is set to the color's opacity but the color also has the opacity. Either use Qt.rgba(color.r, color.g, color.b, 1) or just drop the opacity - Kai Uwe Broulik On Juni 6, 2015, 10

Re: Review Request 124089: Connected timeout before timer start.

2015-06-12 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/124089/#comment55801 New connect syntax maybe? Also, please don't give a Ship It to yourself, that's for the maintainers. - Kai Uwe Broulik On Juni 12, 2015, 8:27 nachm., Jordan He wrote: --- This is an automatically

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Kai Uwe Broulik
On Juni 30, 2015, 8:30 vorm., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Kai Uwe Broulik
/kkeyserver_mac.cpp:64:13: warning: unused variable 'lastLayoutID' [-Wunused-variable] static long lastLayoutID = -1; ^ 1 warning generated. make[1]: *** [src/CMakeFiles/KF5WindowSystem.dir/all] Error 2 make: *** [all] Error 2 - Kai Uwe Broulik On Juni 30, 2015, 6:19 vorm., Martin

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-07-03 Thread Kai Uwe Broulik
works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124253: Resurrect dead code and fix two memory leaks

2015-07-04 Thread Kai Uwe Broulik
On Juli 4, 2015, 4:18 nachm., Kai Uwe Broulik wrote: daemon/backends/upower/login1suspendjob.cpp, line 83 https://git.reviewboard.kde.org/r/124253/diff/1/?file=383152#file383152line83 If you're at it, please change this to the new connect syntax: connect(watcher

Re: Review Request 124253: Resurrect dead code and fix two memory leaks

2015-07-04 Thread Kai Uwe Broulik
/login1suspendjob.cpp (line 81) https://git.reviewboard.kde.org/r/124253/#comment56401 If you're at it, please change this to the new connect syntax: connect(watcher, QDBusPendingCallWatcher::finished, this, Login1SuspendJob::sendResult); - Kai Uwe Broulik On Juli 4, 2015, 4:12 nachm., Maxim

<    1   2   3   4   5   6   7   8   9   10   >