D24025: Don't use KCrash on Android

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We don't want/have KCrash on Android, so diable the pieces there TEST

D24024: Bundle plugin files on Android

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R307:2ce4d6164797: Bundle plugin files on Android (authored by nicolasfella). REPOSITORY R307 KPeople CHANGES SINCE

D24024: Bundle plugin files on Android

nicolasfella created this revision. nicolasfella added reviewers: apol, vkrause. nicolasfella added a project: Android. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We need to tell

D23968: Use app specific location for DB on Android

nicolasfella added a comment. I thought the same thing, but I'm not sure if changing that could break some apps REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D23968 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23968: Use app specific location for DB on Android

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY GenericDataLocation is typically not trivially writable on Android.

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

nicolasfella added a comment. This fixed it for me, thanks REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23944 To: dfaure, vkrause, nicolasfella, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23828: Disable DBus pieces on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R307:82c681f7ff27: Disable DBus pieces on Android (authored by nicolasfella). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23828?vs=65736=65823 REVISION DETAIL

D22365: KNotification macOS native support by NSNotificationCenter

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Let's get this in REVISION DETAIL https://phabricator.kde.org/D22365 To: Inoki, rjvbb, nicolasfella Cc: nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2,

D23835: Add TabKCM

nicolasfella edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23835 To: nicolasfella, mart Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

nicolasfella updated this revision to Diff 65761. nicolasfella added a comment. - Implement Vlad's suggestion REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23835?vs=65760=65761 BRANCH tabkcm REVISION DETAIL https://phabricator.kde.org/D23835

D23835: Add TabKCM

nicolasfella added a comment. In D23835#528688 , @ngraham wrote: > Nice, I think we need this. > > From the image, I think the frame's background color needs to be the same as the active tab color, and there shouldn't be a line separating

D23835: Add TabKCM

nicolasfella updated this revision to Diff 65760. nicolasfella added a comment. - Remove line beneath active tab REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23835?vs=65755=65760 BRANCH tabkcm REVISION DETAIL https://phabricator.kde.org/D23835

D23835: Add TabKCM

nicolasfella edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23835 To: nicolasfella, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23835: Add TabKCM

nicolasfella created this revision. nicolasfella added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We have quite a few KCMs that use tabs as top-level components. Since

D23828: Disable DBus pieces on Android

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY No DBus on Android. The few places do not seem critically necessary.

D23755: Fix no device available text

This revision was automatically updated to reflect the committed changes. Closed by commit R495:f30debdd498e: Fix no device available text (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23755?vs=65517=65568 REVISION DETAIL

D23755: Fix no device available text

nicolasfella updated this revision to Diff 65517. nicolasfella added a comment. - Do same for bluetooth REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23755?vs=65515=65517 BRANCH fix REVISION DETAIL https://phabricator.kde.org/D23755

D23755: Fix no device available text

nicolasfella edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D23755 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23755: Fix no device available text

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R495 Purpose Library BRANCH fix REVISION DETAIL

D20433: Use mount point returned from DBus instead of using property value

nicolasfella abandoned this revision. nicolasfella added a comment. The issue has been fixed in another commit REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20433 To: nicolasfella, broulik, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

nicolasfella removed a reviewer: markg. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni,

D23341: Fixed Telegram Desktop plugin on Fedora

This revision was automatically updated to reflect the committed changes. Closed by commit R495:1afcf7101db7: Fixed Telegram Desktop plugin on Fedora (authored by xvitaly, committed by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D23341: Fixed Telegram Desktop plugin on Fedora

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Thanks! I assume you don't have commit rights, so I'll need your email address please to merge this REPOSITORY R495 Purpose Library REVISION DETAIL

D23341: Fixed Telegram Desktop plugin on Fedora

nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. Please add this to https://cgit.kde.org/purpose.git/tree/src/plugins/telegram/telegramplugin.json#n136 too REPOSITORY R495 Purpose Library REVISION DETAIL

D23149: Only build tests when DBus is available

This revision was automatically updated to reflect the committed changes. Closed by commit R245:f7149af10e4b: Only build tests when DBus is available (authored by nicolasfella). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23149?vs=63732=64104 REVISION

D23124: Remove unused DBus XML file

This revision was automatically updated to reflect the committed changes. Closed by commit R289:ee235f11c13a: Remove unused DBus XML file (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23124?vs=63655=64103 REVISION DETAIL

D22805: set autorcc and autouic by default

nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter, apol, nicolasfella Cc: nicolasfella, cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel,

D22805: set autorcc and autouic by default

nicolasfella reopened this revision. nicolasfella added a comment. This revision is now accepted and ready to land. This seems to cause the build of sonnet to fail: https://invent.kde.org/snippets/394 Another user has reported that ktexteditor and knewstuff fail too REPOSITORY R240

D23224: Fix capitalization of Nextcloud

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D23224 To: z3ntu, nicolasfella Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23163: Remove double check for DBus

This revision was automatically updated to reflect the committed changes. Closed by commit R289:ffd4373116a8: Remove double check for DBus (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23163?vs=63772=63775 REVISION DETAIL

D23163: Remove double check for DBus

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Once is enough TEST PLAN builds REPOSITORY R289

D23149: Only build tests when DBus is available

nicolasfella updated this revision to Diff 63732. nicolasfella added a comment. - Fix case REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23149?vs=63712=63732 BRANCH dbustest REVISION DETAIL https://phabricator.kde.org/D23149 AFFECTED FILES

D23149: Only build tests when DBus is available

nicolasfella marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik, bruns, #frameworks Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23149: Only build tests when DBus is available

nicolasfella added a comment. Yes, QtDBus is available on Windows, so no change there REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik, bruns, #frameworks Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh,

D23149: Only build tests when DBus is available

nicolasfella added reviewers: bcooksley, broulik, bruns, Frameworks. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik, bruns, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23149: Only build tests when DBus is available

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The tests require DBus REPOSITORY R245 Solid BRANCH dbustest REVISION DETAIL

D23124: Remove unused DBus XML file

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This file appears to be unused TEST PLAN KNotifications

D23088: KWindowSystem: add setNewStartupId(QWindow *...) overload

nicolasfella added a reviewer: zzag. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23088 To: dfaure, broulik, davidedmundson, zzag Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23062: Disable KCONFIG_USE_DBUS on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R237:710883fbbb0a: Disable KCONFIG_USE_DBUS on Android (authored by nicolasfella). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23062?vs=63450=63470 REVISION DETAIL

D23062: Disable KCONFIG_USE_DBUS on Android

nicolasfella created this revision. nicolasfella added reviewers: apol, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Since DBus is not available on Android we don't ever want it

D22958: Add initial Android support to ecm_add_app_icon

nicolasfella added a comment. Why do you restrict it to SVGs? Wouldn't you be able to use PNGs as well? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22958 To: hein, #frameworks, mart, leinir, apol Cc: nicolasfella, kde-frameworks-devel,

D22868: Revamp Kirigami.AboutPage

nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. This breaks the display of main actions on mobile REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart,

D22763: [KDirOperator] Use more human-readable sort order descriptions

nicolasfella added a comment. Code looks sensible, haven't tried it yet INLINE COMMENTS > kdiroperator.cpp:1979 > > +/* > KToggleAction *descendingAction = new KToggleAction(i18n("Descending"), > this); > d->actionCollection->addAction(QStringLiteral("descending"), >

D22714: Add missing KIOWIDGETS_NO_DEPRECTAED check

This revision was automatically updated to reflect the committed changes. Closed by commit R241:22179dfeb576: Add missing KIOWIDGETS_NO_DEPRECTAED check (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22714?vs=62467=62532 REVISION

D22714: Add missing KIOWIDGETS_NO_DEPRECTAED check

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It is marked as deprecated but didn't have the #ifdef check

D22705: Deprecate KRun::runService

nicolasfella updated this revision to Diff 62465. nicolasfella added a comment. - Add @deprecated since REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22705?vs=62446=62465 BRANCH depre2 REVISION DETAIL https://phabricator.kde.org/D22705 AFFECTED FILES

D22705: Deprecate KRun::runService

nicolasfella marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22705 To: nicolasfella, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22689: Replace QString::null with QString

nicolasfella reopened this revision. nicolasfella added a comment. This revision is now accepted and ready to land. This breaks building Okular for me [ 0%] Automatic MOC for target urldetecttest [ 0%] Automatic MOC for target okular [ 0%] Automatic MOC for target okularcore

D22689: Replace QString::null with QString

nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid, apol, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22705: Deprecate KRun::runService

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY A comment suggests to deprecate/remove it for KF6, but there's no

D22701: [kfileutils] Add isExecutableFile from KRun

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY isExecutableFile is a useful function independent of KRun. Move it

D22694: Add KDevelop files to gitignore

This revision was automatically updated to reflect the committed changes. Closed by commit R293:e1b51aadb61c: Add KDevelop files to gitignore (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22694?vs=62423=62425 REVISION DETAIL

D22693: [tags] Fix coding style

This revision was automatically updated to reflect the committed changes. Closed by commit R293:9c9f6b758c2c: [tags] Fix coding style (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22693?vs=62422=62426 REVISION DETAIL

D22694: Add KDevelop files to gitignore

nicolasfella created this revision. nicolasfella added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R293 Baloo BRANCH gi REVISION DETAIL

D22693: [tags] Fix coding style

nicolasfella created this revision. nicolasfella added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R293 Baloo BRANCH cs REVISION DETAIL

D22683: Link against KIOCore instead of KIOWidgets in kioslaves

This revision was automatically updated to reflect the committed changes. Closed by commit R293:6961fdbd7b83: Link against KIOCore instead of KIOWidgets in kioslaves (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22683?vs=62391=62421

D22683: Link against KIOCore instead of KIOWidgets in kioslaves

nicolasfella retitled this revision from "[kioslaves/tags] Link against KIOCore instead of KIOWidgets" to "Link against KIOCore instead of KIOWidgets in kioslaves". nicolasfella edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22683

D22683: [kioslaves/tags] Link against KIOCore instead of KIOWidgets

nicolasfella updated this revision to Diff 62391. nicolasfella added a comment. - Do the same for timeline REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22683?vs=62389=62391 BRANCH kiow REVISION DETAIL https://phabricator.kde.org/D22683 AFFECTED

D22683: [kioslaves/tags] Link against KIOCore instead of KIOWidgets

nicolasfella created this revision. nicolasfella added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The Tags ioslave doesn't need KIOWidgets, KIOCore is enough TEST

D22657: Use non-deprecated suggestName

This revision was automatically updated to reflect the committed changes. Closed by commit R495:0a10698cb5c0: Use non-deprecated suggestName (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22657?vs=62331=62385 REVISION

D22658: Use non-deprecated suggestName

This revision was automatically updated to reflect the committed changes. Closed by commit R239:36a409210949: Use non-deprecated suggestName (authored by nicolasfella). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22658?vs=62333=62355 REVISION

D22637: Deprecate suggestName

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4cdf7f01c191: Deprecate suggestName (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22637?vs=62325=62354#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D22656: Replace implementation of suggestName with KFileUtils::suggestName

This revision was automatically updated to reflect the committed changes. Closed by commit R241:65010677ff35: Replace implementation of suggestName with KFileUtils::suggestName (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D22658: Use non-deprecated suggestName

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R239 KDELibs4Support BRANCH nd REVISION DETAIL

D22657: Use non-deprecated suggestName

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R495 Purpose Library BRANCH nd REVISION DETAIL

D22656: Replace implementation of suggestName with KFileUtils::suggestName

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This way we avoid having duplicate code. Also remove the now unneeded

D22637: Deprecate suggestName

nicolasfella updated this revision to Diff 62325. nicolasfella added a comment. - Include deprecated since - Don't build with KIOCORE_NO_DEPRECATED REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22637?vs=62271=62325 BRANCH depre REVISION DETAIL

D22638: Port internal usage of KIO::suggestName

This revision was automatically updated to reflect the committed changes. Closed by commit R241:23e5b099b0e9: Port internal usage of KIO::suggestName (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22638?vs=62272=62323 REVISION DETAIL

D22638: Port internal usage of KIO::suggestName

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R241 KIO BRANCH nodeprecated REVISION DETAIL

D22637: Deprecate suggestName

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY KCoreAddons now has a drop-in replacement. Deprecate this so it can be

D22620: Add function to suggest a unique filename

This revision was automatically updated to reflect the committed changes. Closed by commit R244:03b9bdee4f52: Add function to suggest a unique filename (authored by nicolasfella). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22620?vs=6=62223

D22620: Add function to suggest a unique filename

nicolasfella updated this revision to Diff 6. nicolasfella added a comment. - Don't steal David's copyright - Remove TODO REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22620?vs=62218=6 BRANCH suggestname REVISION DETAIL

D22620: Add function to suggest a unique filename

nicolasfella updated this revision to Diff 62218. nicolasfella added a comment. - Add test REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22620?vs=62215=62218 BRANCH suggestname REVISION DETAIL https://phabricator.kde.org/D22620 AFFECTED FILES

D22620: Add function to suggest a unique filename

nicolasfella edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D22620 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22620: Add function to suggest a unique filename

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This is a copy of KIO::suggestName. It doesn't use anything from KIO

D22554: Finer No-Dbus on Windows

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:67 > + else() > +set(HAVE_DBUSMENUQT 0) > + endif() Here REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel,

D22554: Finer No-Dbus on Windows

nicolasfella added a comment. Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron,

D22554: Finer No-Dbus on Windows

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:70 > + > + if (TARGET Qt5::DBus) > +qt5_add_dbus_adaptor(knotifications_SRCS > org.kde.StatusNotifierItem.xml Now we have two checks for this REPOSITORY R289 KNotifications REVISION DETAIL

D22536: Don't advertise using KPassivePopup

This revision was automatically updated to reflect the committed changes. Closed by commit R239:9f55912f1ae3: Dont advertise using KPassivePopup (authored by nicolasfella). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22536?vs=61999=62047 REVISION

D22544: [RFC] Deprecate KPassivePopup

nicolasfella added a reviewer: broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22544: [RFC] Deprecate KPassivePopup

nicolasfella edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22544: [RFC] Deprecate KPassivePopup

nicolasfella edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22544: [RFC] Deprecate KPassivePopup

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY KPassivePopup is hideous and broken in many ways. Currently it

D22536: Don't advertise using KPassivePopup

nicolasfella added a reviewer: Frameworks. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D22536 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22536: Don't advertise using KPassivePopup

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY KNotification should always be used instead of KPassivePopup REPOSITORY R239 KDELibs4Support BRANCH

D21661: add snoretoast backend for KNotifications on Windows

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:48 > + ) > + find_package(Qt5Network REQUIRED) > + list(APPEND knotifications_SRCS notifybysnore.cpp) find_package calls are usually in the toplevel CMakeLists.txt > knotification.cpp:382 > +#elif defined(Q_OS_WIN) > +

D22520: Remove Growl support

nicolasfella edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22520 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22520: Remove Growl support

nicolasfella updated this revision to Diff 61942. nicolasfella added a comment. - Remove unneeded include REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22520?vs=61941=61942 BRANCH growl REVISION DETAIL https://phabricator.kde.org/D22520

D22520: Remove Growl support

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We're about to get proper backends for Windows and macOS.

D21660: remove dbus for windows build and change audio dep logic

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel,

D21660: remove dbus for windows build and change audio dep logic

nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n,

D21660: remove dbus for windows build and change audio dep logic

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:40 > +if (NOT ANDROID) > +find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus) > +else () Move it down to the audio logic, the if check is the same REPOSITORY R289 KNotifications BRANCH

D21660: change audio dep logic wrt win32

nicolasfella added inline comments. INLINE COMMENTS > brute4s99 wrote in CMakeLists.txt:38 > Update: nope. I think it's still use for the dbus interfaces. I confirmed by > ending the `dbus-daemon.exe` process by hand to see it. Turns out, dbus is > quite important for KDE Connect regardless of

D21660: change audio dep logic wrt win32

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH arcpatch-D21660 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel,

D21660: change audio dep logic wrt win32

nicolasfella added inline comments. INLINE COMMENTS > brute4s99 wrote in CMakeLists.txt:38 > I was trying to simplify code there by removing `NOT`. Should I remove this > change? Yes. It is neither related to Windows nor audio. What you can to is to add Windows to the condition to not look

D21660: change audio dep logic wrt win32

nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. This needs rebasing since I recently changed the audio logic for Android INLINE COMMENTS > CMakeLists.txt:38 > find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG

D22093: Don't show progress window for jobs that don't report progress

nicolasfella created this revision. nicolasfella added reviewers: apol, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Most plugins (all but the youtube one) don't report any progress

D21986: Change initial size of the config dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R495:e6e0be782237: Change initial size of the config dialog (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21986?vs=60310=60599

D21986: Change initial size of the config dialog

nicolasfella retitled this revision from "RFC: Change initial size of the config dialog" to "Change initial size of the config dialog". REPOSITORY R495 Purpose Library BRANCH size REVISION DETAIL https://phabricator.kde.org/D21986 To: nicolasfella, #vdg, apol, ngraham Cc: aacid,

D22055: Improve Job Dialog buttons' icons and text

nicolasfella accepted this revision. REPOSITORY R495 Purpose Library BRANCH better-job-dialog-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22055 To: ngraham, nicolasfella, apol, GB_2, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

<    2   3   4   5   6   7   8   9   10   >