D10362: Change reveal password button logic

ndavis added a comment. -1 for the current version How am I supposed to type with 2 hands and see the password at the same time if I have to hold down the left mouse button? -0.75 for the previous version of the patch We normally show the action that will happen when a button

D22155: Add new activities and virtual desktops icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I'm accepting this, but make sure you don't land this until you've submitted the other patches. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons

D22155: Add new activities and virtual desktops icons

ndavis added a comment. Nice job! Are there other patches coming soon to fix the code where `preferences-activities` was used? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n,

D22108: [TabBar] Remove exterior margins

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D22108#487329 , @filipf wrote: > In D22108#487218 , @ndavis wrote: > > > 1+ visually. How

D22108: [TabBar] Remove exterior margins

ndavis added a comment. 1+ visually. How does it look with a vertical panel? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22108 To: filipf, #vdg, #plasma, ngraham Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22003: Change selected text color to black

ndavis edited the summary of this revision. ndavis added a dependency: D22000: [colors/Breeze] Change selected text color to black. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D22003 To: ndavis, #vdg, #breeze, #plasma Cc: kde-frameworks-devel, LeGast00n,

D22003: Change selected text color to black

ndavis created this revision. ndavis added reviewers: VDG, Breeze, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Also make black text color match the Shade Black color:

D21966: Add disk-quota icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH icon REVISION DETAIL https://phabricator.kde.org/D21966 To: nicolasfella, #plasma, #breeze, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, michaelh,

D21957: Add disk-quota icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH diskquota REVISION DETAIL https://phabricator.kde.org/D21957 To: nicolasfella, #breeze, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21919: Change joystick settings icon to game controller

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7ef3c35c7ed6: Change joystick settings icon to game controller (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21919?vs=60102=60113

D21919: Change joystick settings icon to game controller

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21919 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21919 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY BUG: 406679 FIXED-IN: 5.60 REPOSITORY R266 Breeze Icons BRANCH joystick-settings

D21813: RFC: Consider adding more padding to the desktop theme

ndavis added a comment. Hmm. I don't think we should increase the padding on the desktop theme. That kind of approach seems like it would work best once we know the contents of notifications and OSDs are aligned how we want them to be in the code. REPOSITORY R242 Plasma Framework

D21813: RFC: Consider adding more padding to the desktop theme

ndavis added a comment. In D21813#479952 , @ngraham wrote: > I like the rounder corners! :) I don't, but those aren't meant to be discussed in this RFC anyway. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D21813: RFC: Consider adding more padding to the desktop theme

ndavis added a comment. Besides the notifications, where does this add padding? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

ndavis added a comment. I just tried the patch on my own computer and I noticed a few more things that need to be changed: - The canvas size is 128x128 px when it should be 48x48 - Strokes need to be converted to paths ( [Ctrl] + [Alt] + [c] ). Strokes don't always look correct in

D21656: Create a breeze icon for kfourinline

ndavis added a comment. We don't normally do the gloss wave in Breeze. That's more of a Tango/Oxygen thing. How about adding some holes instead to make it look more like the real thing? https://www.gamesworld.com.au/wp-content/uploads/2015/10/cardinal-four-in-a-row.jpg Just some ideas:

D21632: Add edit-select-text, make 16px draw-text like 22px

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6227d63efa20: Add edit-select-text, make 16px draw-text like 22px (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21632?vs=59283=59287

D21632: Add edit-select-text, make 16px draw-text like 22px

ndavis added a dependent revision: D21633: Change Text Selection icon to edit-select-text. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21632 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21632 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Okular uses draw-text for the text selection tool, but it has 2 different icons at

D21574: Update KBruch icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH kbruch REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n,

D21574: Update KBruch icon

ndavis added a comment. In D21574#474173 , @ognarb wrote: > Sorry it arc who also uploaded the png that I created for the review, I will fix it. Ah, fair enough. Easy mistake to make. REPOSITORY R266 Breeze Icons REVISION DETAIL

D21574: Update KBruch icon

ndavis added a comment. Once you're done with the SVG, make sure you clean it: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis,

D21574: Update KBruch icon

ndavis added a comment. Wait, is this a PNG? This needs to be an SVG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. There needs to be a copy in breeze dark as well. Nice job though! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis

D21526: Add help-donate-[currency] icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:e759724fab78: Add help-donate-[currency] icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21526?vs=58990=59060 REVISION DETAIL

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

This revision was automatically updated to reflect the committed changes. Closed by commit R266:ff72016e444c: Make Breeze Dark use same Kolourpaint icon as Breeze (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21521?vs=58977=58998

D21526: Add help-donate-[currency] icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH donate-currency (branched from master) REVISION DETAIL https://phabricator.kde.org/D21526 To: ndavis, #vdg, sitter, broulik, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21523: Add 22px notifications icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:cdd90177d393: Add 22px notifications icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21523?vs=58983=58997 REVISION DETAIL

D21523: Add 22px notifications icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH notifications-22px (branched from master) REVISION DETAIL https://phabricator.kde.org/D21523 To: ndavis, #vdg, filipf, ngraham Cc: ngraham, filipf, kde-frameworks-devel, michaelh, bruns

D21523: Add 22px notifications icons

ndavis added a comment. done REPOSITORY R266 Breeze Icons BRANCH notifications-22px (branched from master) REVISION DETAIL https://phabricator.kde.org/D21523 To: ndavis, #vdg, filipf, ngraham Cc: ngraham, filipf, kde-frameworks-devel, michaelh, bruns

D21526: Add help-donate-[currency] icons

ndavis retitled this revision from "Add more help-donate currencies" to "Add help-donate-[currency] icons". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21526 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21526: Add more help-donate currencies

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21526 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21526: Add more help-donate currencies

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY These are only 16px icons. According to the bug report, these will be used in the

D21523: Add 22px notifications icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH notifications-22px (branched from master) REVISION DETAIL

D21523: Add 22px notifications icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21523 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21521 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21521 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

ndavis updated this revision to Diff 58977. ndavis added a comment. - Stop top edge of wood from bleeding around the colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21521?vs=58975=58977 BRANCH kolourpaint-app (branched from master) REVISION

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21521 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21521 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY For a while now, Breeze Dark icons have had a different Kolourpaint icon. I think the

D21511: Make falkon icon a real SVG

This revision was automatically updated to reflect the committed changes. Closed by commit R266:ac701bd091cf: Make falkon icon a real SVG (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21511?vs=58944=58948 REVISION DETAIL

D21511: Make falkon icon a real SVG

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21511 To: ndavis, #vdg, #falkon Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb8f02de76d5: Make Breeze Light/Dark use more system colors (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D21378: Make Breeze Light/Dark use more system colors

ndavis added a comment. @mart If you're not opposed to this patch, I'll go ahead and land this. REPOSITORY R242 Plasma Framework (Library) BRANCH less-custom-colors (branched from master) REVISION DETAIL https://phabricator.kde.org/D21378 To: ndavis, #vdg, #plasma, mart, filipf Cc:

D21378: Make Breeze Light/Dark use more system colors

ndavis added a comment. In D21378#469607 , @filipf wrote: > So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a

D21378: Make Breeze Light/Dark use more system colors

ndavis added a comment. In D21378#469525 , @lavender wrote: > In D21378#469517 , @mart wrote: > > > the idea is kinda nice and with some schemes it will work just perfect... > > however i think it

D21378: Make Breeze Light/Dark use more system colors

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Requested in T8755 REPOSITORY R242 Plasma

D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:2847d7c8716c: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip (authored by ndavis). REPOSITORY R266 Breeze

D21264: Display accurate status message during installation

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R432 File Sharing (Samba) integration BRANCH update-status-message-during-installation (branched from master) REVISION DETAIL https://phabricator.kde.org/D21264 To: ngraham, #vdg, #frameworks,

D20708: Change input-* device icon styles, add 16px icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:2078a10ea1b0: Change input-* device icon styles, add 16px icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20708?vs=58047=58138

D21218: Create new icon for Knights based on Anjuta's icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH anjuta-to-knights (branched from master) REVISION DETAIL https://phabricator.kde.org/D21218 To: ngraham, #vdg, ndavis Cc: ndavis, ognarb,

D21218: Create new icon for Knights based on Anjuta's icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Once you've optimized the SVGs, I'll approve this. https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization REPOSITORY R266 Breeze Icons

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

ndavis added a comment. In D21218#465340 , @ognarb wrote: > Why not mirror the Anjuta icon and use the same background color as the original Knights icon? So that it looks closer to the original. I think this is probably better and might

D20708: Change input-* device icon styles, add 16px icons

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20708 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

ndavis updated this revision to Diff 58047. ndavis added a comment. Add new dialog-input-devices icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20708?vs=56657=58047 BRANCH input-icons (branched from master) REVISION DETAIL

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis added a comment. In D20140#464824 , @ngraham wrote: > In practice, the thumbnail delegates are much smaller; is anyone gonna notice that (famous last words)? If you and anyone else reviewing this patch thinks it's OK, I'll just

D20708: Change input-* device icon styles, add 16px icons

ndavis added a comment. In D20708#454298 , @ngraham wrote: > Even if only Inkscape currently uses the icon, as a rule we ignore that kind of information for code/content in Frameworks, because //in principle// any app could use it. It's more

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis added a comment. In D20140#458379 , @filipf wrote: > Which still leaves you with fixing the gaps when there's not thumbnail. I'd suggest to do: > > `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2` > > and call it

D15934: Add battery and bluetooth icons for other DE compatibility

ndavis abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15934 To: ndavis, #vdg Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The arrow-*-double icons were symlinked to the go-top/bottom/first/last icons. Those

D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21084 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21063: Symlink arrow-*-double to go-*-skip

ndavis added a comment. Whoops. Forgot there were no 24px go-*-skip icons. I'll have to fix that and then the patch will work. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21063 To: ndavis, #vdg, ngraham Cc: jriddell, kde-frameworks-devel, michaelh,

D21063: Symlink arrow-*-double to go-*-skip

This revision was automatically updated to reflect the committed changes. Closed by commit R266:04be2a08ab1b: Symlink arrow-*-double to go-*-skip (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21063?vs=57700=57723 REVISION DETAIL

D21063: Symlink arrow-*-double to go-*-skip

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21063 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21063: Symlink arrow-*-double to go-*-skip

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Previously, the arrow-*-double icons were symlinked to go-top/bottom/first/last icons,

D19812: Add a web page to view and compare icons of different sizes

ndavis added a comment. In D19812#455478 , @ngraham wrote: > TBH I wonder how useful this actually is. Hopefully some of the other folks involved in making icons (@ndavis, @GB_2, @trickyricky26) can comment on whether or not this would be

D20825: Fix wrong group names for 22, 32 px in audio.svg

This revision was automatically updated to reflect the committed changes. Closed by commit R242:176643f48c84: Fix wrong group names for 22, 32 px in audio.svg (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D20825: Fix wrong group names for 22, 32 px in audio.svg

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Before this fix, the system tray audio widget would try to use the 32px icons where

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH add-edit-remove-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

ndavis added a comment. More like center version in this SVG: F6788395: paint-none.svg.2019_04_23_05_53_37.0.svg F6788396: Screenshot_20190423_055953.png Notice how the lines appear to have a thickness

D20693: Remove pixelated border

ndavis added a comment. +1 for the change to the large thumbnail, but I think the smaller thumbnails need something to show that they can be clicked. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D20693 To: leinir, #knewstuff, ngraham, sitter, #vdg Cc: ndavis,

D20695: Add more icon sizes for audio, configure, distribute

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b5ec56091ed3: Add more icon sizes for audio, configure, distribute (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

ndavis added a comment. The 22px version needs to have 1px thick lines and 3px margins on each side. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20700: Add "edit-remove" icon symlink

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I'll accept this if you also make 22px versions. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D20708: Change input-* device icon styles, add 16px icons

ndavis added a comment. Actually, `dialog-input-devices` is used by inkscape for configuring pointing devices and tablets. AFAIK, only Inkscape uses that icon. If I made it show more types of devices, it would be more accurate to use a tablet. Looking at the Input Devices dock in Inkscape,

D20708: Change input-* device icon styles, add 16px icons

ndavis added a comment. In D20708#453690 , @ngraham wrote: > Overall very nice. > > Instead of symlinking `input-mouse` to `dialog-input-devices`, I think it might make more sense to rename `dialog-input-devices` to be `input-mouse` and

D20700: Add "edit-remove" icon symlink

ndavis added a comment. In D20700#453565 , @GB_2 wrote: > `list-remove` is just a minus icon, which has no context and looks weird when used alone, without `list-add` next to it. An example where the new icon can be used is D20576

D20708: Change input-* device icon styles, add 16px icons

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20708 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20708: Change input-* device icon styles, add 16px icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY `devices/16` was missing some `input-*` icons. `input-keyboard-virtual` looked more like

D20700: Add "edit-remove" icon symlink

ndavis added a comment. Why does `list-remove` need an alternative? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

ndavis updated this revision to Diff 56622. ndavis added a comment. Fix 16-16-audio-volume-muted REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20695?vs=56621=56622 BRANCH add-new-size (branched from master) REVISION DETAIL

D20695: Add more icon sizes for audio, configure, distribute

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20695 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20695 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

ndavis updated this revision to Diff 56621. ndavis added a comment. Add 16px audio icons REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20695?vs=56619=56621 BRANCH add-new-size (branched from master) REVISION DETAIL

D20695: Add more icon sizes for audio, configure, distribute

ndavis planned changes to this revision. ndavis added a comment. Oops, looks like I need 16px audio icons as well for the volume/mute icons inside the opened audio widget. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20695 To: ndavis, #vdg,

D20695: Add more icon sizes for audio, configure, distribute

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20695 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The tooltip for the audio system tray widget and panel edit mode had blurry

D20672: Add an icon for Thunderbolt KCM

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg, ndavis, ngraham Cc: abetts, ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh,

D20672: Add an icon for Thunderbolt KCM

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Actually, one last thing. Can you save it as a plain SVG so that it isn't filled with Inkscape metadata? REPOSITORY R266 Breeze Icons REVISION DETAIL

D20672: Add an icon for Thunderbolt KCM

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I like the new top color. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20672 To: yurchor, #vdg, ndavis, ngraham Cc: ndavis, GB_2, filipf,

D20672: Add an icon for Thunderbolt KCM

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. A few problems: 1. That circle has a diameter of 27.9px instead of 28px 2. There is no copy of the icon in `icons-dark/preferences/32/` 3. The top of the gradient is

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bd8264e92869: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze… (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

ndavis added a comment. One concern: Previously, the `go-up` icon in `go.svg` used a completely different style from the other `go-*` icons. Does anyone know why that was? I can't find any reason for it to use a different style. REPOSITORY R242 Plasma Framework (Library) REVISION

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

ndavis added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20623 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

<    3   4   5   6   7   8   9   10   11   12   >