D23926: Move "Details" tab to second place in Properties dialog

GB_2 added a comment. Ping :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, azyx, dmenig, nikolaik, pberestov, manueljlin,

D23879: Add Qt Designer icon symlink

GB_2 abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23879 To: GB_2, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D26043: Add edit mode menu item to desktop widget context menu

GB_2 updated this revision to Diff 73195. GB_2 marked an inline comment as done. GB_2 added a comment. Use David's suggestion REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26043?vs=71675=73195 BRANCH arcpatch-D26043 REVISION DETAIL

D26043: Add edit mode menu item to desktop widget context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R242:629db2f3b55b: Add edit mode menu item to desktop widget context menu (authored by GB_2). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26043: Add edit mode menu item to desktop widget context menu

GB_2 added a comment. Ping :-) REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D26043 To: GB_2, #plasma, #vdg, mart, ngraham Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D26043: Add edit mode menu item to desktop widget context menu

GB_2 added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26043 To: GB_2, #plasma, #vdg, mart Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D26043: Add edit mode menu item to desktop widget context menu

GB_2 added inline comments. INLINE COMMENTS > broulik wrote in containmentinterface.cpp:1128 > Please check `m_containment->immutability()` so we don't add this if widgets > are locked Are you sure? It is already automatically disabled when immutability is `UserImmutable` and completely

D24522: Add presentwindows icon (old "task view" from windows)

GB_2 added a comment. In D24522#544338 , @Zren wrote: > > `preferences-system-windows-effect-presentwindows` > > That would look like the `homerun` icon, which looks like the "windows" logo. > > F7557693: 2019-10-09___13-01-07.png

D23352: make button icons follow a reasonable size and layout

GB_2 added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23352 To: camiloh, #plasma, mart, ngraham Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D26043: Add edit mode menu item to desktop widget context menu

GB_2 updated this revision to Diff 71675. GB_2 added a comment. Remove space REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26043?vs=71674=71675 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26043 AFFECTED FILES

D26043: Add edit mode menu item to desktop widget context menu

GB_2 updated this revision to Diff 71674. GB_2 added a comment. Decrease line count REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26043?vs=71670=71674 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26043 AFFECTED

D26043: Add edit mode menu item to desktop widget context menu

GB_2 added a reviewer: mart. GB_2 added a subscriber: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26043 To: GB_2, #plasma, #vdg, mart Cc: mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D26043: Add edit mode menu item to desktop widget context menu

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY - much improves discoverability of the ability to move added widgets without clicking and

D26043: Add edit mode menu item to desktop widget context menu

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26043 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

GB_2 added a comment. In D25360#573798 , @IlyaBizyaev wrote: > Should this also affect GTK apps? There's a matching radio group in the GTK KCM. D25703 REPOSITORY R252 Framework Integration

D25149: Add a new template for KCMs

GB_2 added reviewers: Plasma, Frameworks. GB_2 added a project: Plasma. GB_2 added a subscriber: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava, #plasma, #frameworks Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb,

D25149: Add a new template for KCMs

GB_2 added a comment. In D25149#559684 , @tcanabrava wrote: > We need a better icon. it's the icon for the `Plasmoid` template. Why not use the system settings icon as it's a KCM template? REPOSITORY R242 Plasma Framework (Library)

D25123: [WIP] New yakuake logo/icon

GB_2 added a comment. In D25123#560491 , @ndavis wrote: > I think I prefer C the most now that I've seen it next to other icons. It has a similar level of detail to other Breeze icons. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

GB_2 added a comment. +1 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D25049 To: ngraham, #vdg, #plasma, mart Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23951: Improve panel options menu entries

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bbe0148db5d1: Improve panel options menu entries (authored by GB_2). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=68467=68469

D23951: Improve panel options menu entries

GB_2 removed a dependent revision: D24162: Hide "Lock Widgets" button from panel edit mode toolbar. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma,

D23951: Improve panel options menu entries

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

GB_2 updated this revision to Diff 68467. GB_2 added a comment. Don't hide lock action here REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=8=68467 BRANCH arcpatch-D23951 REVISION DETAIL

D23951: Improve panel options menu entries

GB_2 retitled this revision from "Improve and clean up panel options menu entries" to "Improve panel options menu entries". GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart

D23951: Improve and clean up panel options menu entries

GB_2 marked an inline comment as done. GB_2 added a comment. In D23951#551472 , @mart wrote: > i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in the UI (hide "Lock Widgets" from the UI) i would try to go from the context

D23951: Improve and clean up panel options menu entries

GB_2 added a comment. In D23951#551472 , @mart wrote: > i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in the UI (hide "Lock Widgets" from the UI) i would try to go from the context menu plugin instead and not adding the

D23951: Improve and clean up panel options menu entries

GB_2 added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D24263: edit mode action

GB_2 added inline comments. INLINE COMMENTS > corona.cpp:502 > +}); > +editAction->setText(i18n("Customize Layout")); > +editAction->setAutoRepeat(true); Missing ellipsis (...) REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editModeActionwq! REVISION DETAIL

D24746: [kpropertiesdialog] adjust ui for root directory

GB_2 accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks, GB_2 Cc: ahmadsamir, GB_2,

D24746: [kpropertiesdialog] adjust ui for root directory

GB_2 added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

GB_2 added a comment. Can we also set the root folder icon? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24537: Icons for windy weather

GB_2 added a comment. Can you clean the SVGs a bit? REPOSITORY R266 Breeze Icons BRANCH windy-weather-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis, ngraham Cc: GB_2, vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

GB_2 added a dependent revision: D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg,

D24318: Make 32px document-save icon colorful

GB_2 added a comment. In D24318#542048 , @ndavis wrote: > Yeah, that was a feature of the original icon that I didn't remove. I wasn't so sure about it either. If you don't like it then remove it :P REPOSITORY R266 Breeze Icons

D24598: Update elisa icon

GB_2 added a comment. I don't think it makes sense to change the icon here if D12992 already does it. If you want it to progress then take over the revision and work on the completely new style there or make a ping comment and have some patience.

D24263: edit mode action

GB_2 added inline comments. INLINE COMMENTS > corona.cpp:419 > +} else { > +editAction->setText(i18n("Customize Layout")); > +} Missing ellipsis (...) REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editModeActionwq! REVISION DETAIL

D23951: Improve and clean up panel options menu entries

GB_2 retitled this revision from "Improve desktop layout and panel editing UX" to "Improve and clean up panel options menu entries". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg,

D24415: Add standard icons to support to all entries in QDialogButtonBox

This revision was automatically updated to reflect the committed changes. Closed by commit R252:50593c561899: Add standard icons to support to all entries in QDialogButtonBox (authored by GB_2). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

GB_2 added inline comments. INLINE COMMENTS > ppeter wrote in executablefileopendialog.cpp:58 > if (mode == OnlyExecute) > connect(executeButton, ...) > else if (mode == OpenAsExecute) > ... > > looks better :) That would be against the common KDE coding style:

D24415: Add standard icons to support to all entries in QDialogButtonBox

GB_2 updated this revision to Diff 67336. GB_2 marked 2 inline comments as done. GB_2 added a comment. Address comments REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24415?vs=67329=67336 BRANCH master REVISION DETAIL

D24415: Add standard icons to support to all entries in QDialogButtonBox

GB_2 created this revision. GB_2 added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 398973 Implement the new enumarations introduced in Qt 5.14:

D24415: Add standard icons to support to all entries in QDialogButtonBox

GB_2 added a reviewer: davidedmundson. GB_2 added a subscriber: davidedmundson. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24415 To: GB_2, #frameworks, #vdg, davidedmundson Cc: davidedmundson, #vdg, kde-frameworks-devel, #frameworks, LeGast00n, GB_2,

D24318: Make 32px document-save icon colorful

GB_2 added a comment. In D24318#541839 , @ndavis wrote: > How about this? > F7513643: document-save.svg > F7513644: montage.png I love it! REPOSITORY

D24384: Move Amusement to Games directory instead of Games > Toys

GB_2 edited the summary of this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24384 To: guoyunhe, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24263: edit mode action

GB_2 resigned from this revision. This revision now requires review to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma, #vdg Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24263: edit mode action

GB_2 accepted this revision as: VDG, GB_2. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editModeActionwq! REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, kde-frameworks-devel,

D24263: edit mode action

GB_2 added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma, #vdg Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24263: edit mode action

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in corona.cpp:406 > This isn't just editing editing widgets; maybe "Enter Edit Mode" ? That would > make the name better correspond with the text of the opposite state too. > > Alternatives: > > - Edit Layout and Widgets/Freeze

D23388: add a border for the toolbars WIP

GB_2 added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

GB_2 added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, ian,

D23951: Improve desktop layout and panel editing UX

GB_2 added 1 blocking reviewer(s): Plasma. This revision now requires review to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh,

D23951: Improve desktop layout and panel editing UX

GB_2 added a dependency: D24246: Only show panel toolbox when desktop toolbox is open. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n,

D23951: Improve desktop layout and panel editing UX

GB_2 removed a dependency: D24246: Only show panel toolbox when desktop toolbox is open. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n,

D23951: Improve desktop layout and panel editing UX

GB_2 added a dependency: D24246: Only show panel toolbox when desktop toolbox is open. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n,

D24239: make editMode a corona global property

GB_2 added a dependent revision: D24246: Only show panel toolbox when desktop toolbox is open. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24239 To: mart, #plasma, #vdg Cc: ngraham, GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24239: make editMode a corona global property

GB_2 added a comment. Thanks! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24239 To: mart, #plasma, #vdg Cc: GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24227: Add colorful preferences-desktop-filter icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:63b9438be1e4: Add colorful preferences-desktop-filter icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24227?vs=66839=66846 REVISION

D24227: Add colorful preferences-desktop-filter icon

GB_2 updated this revision to Diff 66839. GB_2 added a comment. Make bottom hard show slightly stronger REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24227?vs=66838=66839 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24227

D24227: Add colorful preferences-desktop-filter icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 406900 F7431167: preferences-desktop-filter Icon.png

D23879: Add Qt Designer icon symlink

GB_2 planned changes to this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23879 To: GB_2, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Improve desktop layout and panel editing UX

GB_2 added a comment. In D23951#537202 , @ngraham wrote: > we need to wait for a visible non-right-click method to enter Panel Edit Mode. I think we'll need a task for that. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D23951: Improve desktop layout and panel editing UX

GB_2 added a comment. In D23951#537202 , @ngraham wrote: > +1 in general, but since this removes the GUI ability to enter locked mode, it can't land until D23952 is ready, which means we need to wait for a

D23951: Improve desktop layout and panel editing UX

GB_2 added a comment. Changed the menu again! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Improve desktop layout and panel editing UX

GB_2 edited dependent revision(s), added 1: D24162: Hide "Lock Widgets" button from panel edit mode toolbar; removed 1: D23952: Remove panel toolbox. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg,

D23951: Improve desktop layout and panel editing UX

GB_2 removed a dependency: D23950: Only show "Add Widgets..." panel context menu option in panel edit mode. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n,

D23951: Improve desktop layout and panel editing UX

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Improve desktop layout and panel editing UX

GB_2 updated this revision to Diff 8. GB_2 added a comment. Fix diff REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=66162=8 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23951 AFFECTED FILES

D19620: Use a searchbar similar to the one in okular

GB_2 added a comment. Ping. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23879: Add Qt Designer icon symlink

GB_2 updated this revision to Diff 66167. GB_2 added a comment. Also for Qt 4 REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23879?vs=66166=66167 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23879 AFFECTED FILES

D23879: Add Qt Designer icon symlink

GB_2 updated this revision to Diff 66166. GB_2 added a comment. Rename to `designer-qt5` to avoid overriding unrelated icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23879?vs=65857=66166 BRANCH master REVISION DETAIL

D23951: Improve desktop layout and panel editing UX

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Improve desktop layout and panel editing UX

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Improve desktop layout and panel editing UX

GB_2 updated this revision to Diff 66162. GB_2 added a comment. Really add back "Show Alternatives..." item REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=66160=66162 BRANCH

D23951: Improve desktop layout and panel editing UX

GB_2 updated this revision to Diff 66160. GB_2 added a comment. Add back "Show Alternatives..." item REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=66103=66160 BRANCH

D23969: [kpropertiesdialog] add icons for the size section

This revision was automatically updated to reflect the committed changes. Closed by commit R241:764616b91b21: [kpropertiesdialog] add icons for the size section (authored by tienisto, committed by GB_2). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D23969: [kpropertiesdialog] add icons for the size section

GB_2 accepted this revision. REPOSITORY R241 KIO BRANCH kpropertiesdialog-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D23969 To: tienisto, #vdg, ngraham, GB_2 Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk,

D23972: Add icons for "Open With" and "Actions" menus

GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Excellent! REPOSITORY R241 KIO BRANCH icons-in-context-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D23972 To: ngraham, #vdg, GB_2 Cc: kde-frameworks-devel,

D23951: Improve desktop layout and panel editing UX

GB_2 added a dependent revision: D23952: Remove panel toolbox clean up editing options. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Improve desktop layout and panel editing UX

GB_2 retitled this revision from "Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option" to "Improve desktop layout and panel editing UX". GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

GB_2 updated this revision to Diff 66103. GB_2 added a comment. Only show "Unlock Widgets" in the UI and only show "Show Alternatives..." in panel edit mode REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=66095=66103 BRANCH

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

GB_2 added a comment. In D23951#531545 , @ngraham wrote: > Two things with this patch series: > > 1. Now there's no way to lock widgets without entering panel edit mode. Feels like we might as well just get rid of unlocked mode entirely. Or

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

GB_2 edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

GB_2 added a dependency: D23950: Only show "Add Widgets..." and "Lock Widgets" panel context menu options in panel edit mode. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma,

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY See M144 and T10047

D23942: Add enablefont and disablefont icon for kfontinst KCM

GB_2 accepted this revision. GB_2 added a comment. Now it's good! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

GB_2 added a comment. In D23942#531364 , @guoyunhe wrote: > @GB_2 is it correct now? There's still a hardcoded `style="fill:#da4453"` in the `disable` icons. REPOSITORY R266 Breeze Icons REVISION DETAIL

D23942: Add enablefont and disablefont icon for kfontinst KCM

GB_2 added a comment. In D23942#531349 , @guoyunhe wrote: > I was asked to remove the hard code color like: `fill="currentColor"` and `fill="#da4453"`. But I see other icons have something like `style="fill:currentColor"`. Can anyone tell me

D23942: Add enablefont and disablefont icon for kfontinst KCM

GB_2 added a comment. In D23942#531347 , @guoyunhe wrote: > @ndavis it looks strange when I removed the inline style > > {F7351830} The inline style needs to be included, how it is now. REPOSITORY R266 Breeze Icons REVISION

D23942: Add enablefont and disablefont icon for kfontinst KCM

GB_2 accepted this revision. GB_2 added a comment. Then it's fine. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

GB_2 added a comment. In D23942#531330 , @ngraham wrote: > Shouldn't the checkmark be green? FWIW, both should be black/white. Disabling is not a destructive action like removing. REPOSITORY R266 Breeze Icons REVISION DETAIL

D23926: Move "Details" tab to second place in Properties dialog

GB_2 added a comment. +1 Next time please also add VDG as a subsriber and reviewer if there is a UI related change :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg Cc: GB_2, #vdg, #dolphin, #frameworks,

D23926: Move "Details" tab to second place in Properties dialog

GB_2 added reviewers: Frameworks, VDG. GB_2 added a project: VDG. GB_2 added subscribers: Frameworks, Dolphin, VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg Cc: #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio,

D23879: Add Qt Designer icon symlink

GB_2 planned changes to this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23879 To: GB_2, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23879: Add Qt Designer icon symlink

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY This symlink was missing, so the desktop file was using the default icon. TEST PLAN The Qt

D23879: Add Qt Designer icon symlink

GB_2 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23879 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D10362: Change reveal password button logic

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb18347e4dea: Change reveal password button logic (authored by GB_2). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65592=65681

D23782: Add "edit-none-border" icon

GB_2 added a comment. In D23782#527672 , @ndavis wrote: > This is kind of more like a selection icon than a No Borders icon TBH. I'm not sure if this is really more accurate than `edit-none`. Yeah, maybe it's best if we just use that.

  1   2   3   4   >