D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ilic added inline comments. INLINE COMMENTS > dfaure wrote in kuitmarkup.cpp:90 > Interesting idea, this simplifies the code. > > However the name "wsRx" no longer matches what this regexp does. > > Also, the old trimming is missing here, isn't it? > I guess \s*:?\s* is needed, and \s*/?\s* >

D26408: ki18n: add unittest for KUitSetup::setFormatForMarker

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D26408 To: dfaure, ilic Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26413: Hide Kuit::setupForDomain and KuitSetup from the public API

ilic added a comment. In D26413#587390 , @dfaure wrote: > Alternative approach: export it and unittest it, D26408 . > > @ilic your input would be very welcome on which approach should be taken. I don't

D24898: Add KLocalizedString::untranslatedText

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D24898 To: aacid, ilic Cc: apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24898: Add KLocalizedString::untranslatedText

ilic added a comment. An apparent need for this functionality was popping up from time to time, but somehow never got too serious. Probably because each time it would have been just a convenience, since the original text could have been transported to where it is needed next to the

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

ilic added a comment. The idea was indeed to deprecate stripping of context, and not only the macro name, for the reason Alber provided. The apparent counterexample in kuitmarkup.cpp is seen only due to macro-within-macro call and the macro expansion order, which is a situation that

D22698: Support passing target to ki18n_wrap_ui macro

ilic accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D22698 To: daandemeyer, ilic Cc: ltoscano, alexmerry, turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22698: Support passing target to ki18n_wrap_ui macro

ilic added a comment. (As a maintainer) I can just say, that I'm not qualified to judge if the added behavior and implementation fits the modern CMake practices. If someone else confirms this is indeed the case, I'm happy to accept it. REVISION DETAIL https://phabricator.kde.org/D22698

D22069: Localize long number strings

ilic added a comment. The way forward is to find out why making that one dot-to-comma change and having fr_FR.utf8 glibc locale installed is not sufficient to get the test to pass. To my understanding, an explicit QLocale::setDefault() call either 1) should not be necessary, or 2) it should

D22069: Localize long number strings

ilic added a comment. I'm not sure about what happens with global state, but at any rate, what I expected is that in klocalizedstringtest.cpp exactly one character is modified, replacing dot with comma in string " 4.20". Do you have fr_FR.utf8 glibc locale installed on your system?

D22069: Localize long number strings

ilic added inline comments. INLINE COMMENTS > klocalizedstringtest.cpp:222 > + > +QLocale::setDefault(QLocale(QLocale::French)); > +QCOMPARE(ki18n("%1").subs(4.2, 5, 'f', 2).toString(), The French locale is already being set in line 45 using setlocale, for which the system has to have

D22069: Localize long number strings

ilic added a comment. Still lacks the change in unit test in autotests/klocalizedstringtest.cpp, from " 4.20" to " 4,20". REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: ilic, kde-frameworks-devel, broulik,

D14686: API docs: fix *xi18n* calls in example code to use correct variants

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH fixxi18ncallexamples REVISION DETAIL https://phabricator.kde.org/D14686 To: kossebau, ilic Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14473: Fix KCatalog::translate when translation is same as original text

ilic accepted this revision. ilic added a comment. This revision is now accepted and ready to land. I distinctly remember having had the same quandry once, and then someone from the gettext side said to compare pointers. Even the comment to dngettext call in the plural version of

D12355: [API dox] New UI marker @info:placeholder

ilic added a comment. In D12355#255342 , @ilic wrote: > The diff is a bit weird, as if it is for the vallusuffix from D12353 . But looks good in the repository as committed. ...or, my browser did

D12355: [API dox] New UI marker @info:placeholder

ilic added a comment. The diff is a bit weird, as if it is for the vallusuffix from D12353 . But looks good in the repository as committed. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12355 To: kossebau, #localization, ilic

D12353: [API dox] New UI marker @item:valuesuffix

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH additemvaluesuffixuimaker REVISION DETAIL https://phabricator.kde.org/D12353 To: kossebau, #localization, ilic Cc: #frameworks, michaelh, bruns

D11149: Create a constructor for KLocalizedStringPrivate

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11149 To: jtamate, #frameworks, ilic Cc: ilic, michaelh

D11149: Create a constructor for KLocalizedStringPrivate

ilic added inline comments. INLINE COMMENTS > klocalizedstring.cpp:202-204 > + :format() > + ,numberSet(false) > + ,markupAware(false) Should have space after colon/comma? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11149 To: jtamate, #frameworks

D10758: Use QLocale instead of QLocale::system

ilic accepted this revision. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D10758 To: aacid, apol, ilic Cc: lueck, #frameworks, michaelh

D8351: API dox: add note about calling setApplicationDomain after QApp creation

ilic added a comment. Yes, I guess in the end it's the simplest way to look at it. One thing though: I'd add at least another sentence claryfing that unlike an i18n* call, a ki18n* can happen at any time, and only its toString method should be called after Q*App instance creation

D9585: Fix finding libintl when "cross"-compiling native Yocto packages

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D9585 To: vkrause, #frameworks, ilic

D9295: do not treat ts-pmap-compile as exectuable

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D9295 To: sitter, ilic Cc: #frameworks

D9162: KI18n: fix a number of double lookups

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D9162 To: dfaure, ilic Cc: #frameworks

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ilic added a comment. `KStandardShortcut::Preferences` label is being overridden in KConfigWidgets's `src/kstandardaction_p.h` to `" %1..."` and %1 substituted with current application name. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham,

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ilic added a comment. "Configure Application" does sound better than "Preferences", but that's just my opinion as a random translator, no link to my i18n plumber's hat :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik,

D8351: API dox: add note about calling setApplicationDomain after QApp creation

ilic added a comment. Well... it's a tough situation. It is not by design that `i18n` calls should in any way depend on creation of `QApplication`, and also any library may place an `i18n` call before the main program creates `QApplication`. The only solution I see is that environment is

D7033: Port ki18n from QtScript to QtQml

ilic added a comment. I can't say about QtScript to QtQML conversion, but wrt. those FIXMEs, removing variable argument lists obviously breaks compatibility, and especially the acall function makes no sense without it. REPOSITORY R249 KI18n REVISION DETAIL

D7523: Use the application domain when doing i18n of actions

ilic accepted this revision. ilic added a comment. This revision is now accepted and ready to land. I'd say the patch is fine as it is. If this code is invoked through an intermediate library, that library's definition of TRANSLATION_DOMAIN will have no effect, instead kross'

D5208: Allow loading i18n catalogs from arbitrary locations

ilic accepted this revision. ilic added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > davidedmundson wrote in kcatalog.cpp:124 > I think I still need it. > > QHash::value() isn't marked as being atomic so we still need to make sure > we're not reading at

D5208: Allow loading i18n catalogs from arbitrary locations

ilic added inline comments. INLINE COMMENTS > davidedmundson wrote in klocalizedstringtest.cpp:59 > Pretty sure it's fine. kactivities and kjs use them with no issue. Well, since no-one else complained either, guess it's ok. Easy to fix later if someone does complain. > ilic wrote in

D6339: Remove custom doxygen config files

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH removecustomdoxygencfg REVISION DETAIL https://phabricator.kde.org/D6339 To: kossebau, #frameworks, ilic

D6338: DOXYGEN_PREPROC -> DOXYGEN_SHOULD_SKIP_THIS, to standardize within KF5

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH standardizedoxygenppmacro REVISION DETAIL https://phabricator.kde.org/D6338 To: kossebau, #frameworks, ilic

D5455: Extend Programmer's Guide with notes about influence of setlocale()

ilic accepted this revision. ilic added a comment. All good to me. REPOSITORY R249 KI18n BRANCH addNoteAboutGettextLocaleIssuse REVISION DETAIL https://phabricator.kde.org/D5455 To: kossebau, #frameworks, ilic, aacid Cc: aacid

D5455: Extend Programmer's Guide with notes about influence of setlocale()

ilic added a comment. I guess not bad to mention this stuff, but I would make following adaptations: 1. Move the section as subsection of "Controlling Language Of Catalog to Use", and give it a more focused ( title, e.g. "Placing i18n calls before creation of QCoreApplication". 2.

D5208: Allow loading i18n catalogs from arbitrary locations

ilic added inline comments. INLINE COMMENTS > klocalizedstring.h:558 > > +static void addDomainLocaleDir(const QByteArray , const QString > ); > + Misses docstring. It should be made clear that this method is for "special purposes" (e.g. plugins and whatnot), and that normal programs

D5208: Allow loading i18n catalogs from arbitrary locations

ilic requested changes to this revision. ilic added a comment. This revision now requires changes to proceed. I think it's fine to add this capability, especially given that Gettext (which Ki18n is an extension of) not only has it, but uses it exclusively (it does not search through any

D5195: don't add the autotests dir when test building is disabled

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D5195 To: sitter, ilic Cc: #frameworks

Re: Review Request 127800: Format number in KLocalizedString::subs

> On Мај 1, 2016, 6:40 по п., Chusslove Illich wrote: > > To have localized numbers is the expected behavior (and documented as > > such). But it was "temporarily" disabled between kdelibs and KF5, until > > replacements for KLocale were decided. I don

Re: Review Request 129455: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129455/#review101088 --- Ship it! Ship It! - Chusslove Illich On Нов. 20, 2016

Re: Review Request 128243: Fix parsing of env vars in KLocalizedStringPrivateStatics::initializeLocaleLanguages()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128243/#review96878 --- Ship it! Ship It! - Chusslove Illich On Јун 18, 2016

Re: Review Request 128243: Fix parsing of env vars in KLocalizedStringPrivateStatics::initializeLocaleLanguages()

> On Јун 19, 2016, 1:11 пре п., Chusslove Illich wrote: > > a) Right, old code is obviously wrong (sigh). > > > > b) According to Gettext convention, LANGUAGE is a fine-tuning variable and > > it (each of its colon-separated parts) is to be taken as-is, wit

Re: Review Request 127834: ki18n: Fix theoretically possible use-after-free in gettext when using strict ANSI compilers

isit: > https://git.reviewboard.kde.org/r/127834/ > --- > > (Updated Мај 7, 2016, 6:12 пре п.) > > > Review request for KDE Frameworks, Localization and Translation (l10n) and > Chusslove Illich. > > > Repository: ki18n > > > Description > --- >

Re: Review Request 127834: ki18n: Fix theoretically possible use-after-free in gettext when using strict ANSI compilers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127834/#review95232 --- Ship it! Ship It! - Chusslove Illich On Мај 5, 2016, 3

Re: Review Request 127800: Format number in KLocalizedString::subs

> On Мај 1, 2016, 6:40 по п., Chusslove Illich wrote: > > To have localized numbers is the expected behavior (and documented as > > such). But it was "temporarily" disabled between kdelibs and KF5, until > > replacements for KLocale were decided. I don

Re: Review Request 127800: Format number in KLocalizedString::subs

> On Мај 1, 2016, 6:40 по п., Chusslove Illich wrote: > > To have localized numbers is the expected behavior (and documented as > > such). But it was "temporarily" disabled between kdelibs and KF5, until > > replacements for KLocale were decided. I don

Re: Review Request 127800: Format number in KLocalizedString::subs

id you run unit tests? Could be some of them needs adapting. - Chusslove Illich On Мај 1, 2016, 12:47 пре п., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 127784: Add a small note to the documentation on how tips are i18n'ed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127784/#review94998 --- Ship it! Ship It! - Chusslove Illich On Април 28, 2016

Re: Review Request 127777: Make KTipDialog use the domain of the application when translating the tips

, until someone asks for it. To me KTipDialog looks like something that is really going to be used directly by applications, and if someone does find a reason to wrap it into another library, can also ask for adding the domain parameter. - Chusslove Illich On Април 28, 2016, 12:48 пре п., Albert

Re: Finding local translations?

pplicationTranslations call). I checked it now with KWrite, and that is what is happening. I could happily munge XDG_DATA_DIRS before QApplication in KWrite is created, and KCatalog would heed it. -- Chusslove Illich (Часлав Илић) signature.asc Description:

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127275/#review93265 --- Ship it! Ship It! - Chusslove Illich On Март 7, 2016

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

> On Март 4, 2016, 4:01 по п., Chusslove Illich wrote: > > src/klocalizedstring.cpp, line 368 > > <https://git.reviewboard.kde.org/r/127275/diff/1/?file=447946#file447946line368> > > > > I would nevertheless ifdef it. It may be that some strange thing is &

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

tps://git.reviewboard.kde.org/r/127275/#comment63522> I would nevertheless ifdef it. It may be that some strange thing is intentionally done with locale variables (e.g. to test something or kill localization), and then the behavior would deviate from that documented for Gettext. - Chusslove Illich On

Re: Review Request 127233: Skip looking up . and .. to find the translations for an application

... how do you count them, by strace or? - Chusslove Illich On Март 1, 2016, 3:01 пре п., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/#review92271 --- Ship it! Ship It! - Chusslove Illich On Феб. 11, 2016

Re: Review Request 127002: Add KLocalizedString::getLanguages()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127002/#review92121 --- Ship it! Ship It! - Chusslove Illich On Феб. 7, 2016

Re: Review Request 126934: Reduce use of gettext API.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126934/#review91899 --- Ship it! Ship It! - Chusslove Illich On Феб. 1, 2016

Re: Review Request 126934: Reduce use of gettext API.

would look somewhat "disbalanced" if someone inspects it later. Could you maybe remove all uses of *cgettext API, so that the changes are symmetric for both dnpgettext* and dpgettext* functions/macros? - Chusslove Illich On Јан. 31, 2016, 9:53 пре п., Andreas Cord-Land

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126476/#review90002 --- Ship it! Ship It! - Chusslove Illich On Дец. 23, 2015, 4

Re: Review Request 126489: Reduce unwanted type changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126489/#review90005 --- Ship it! Ship It! - Chusslove Illich On Дец. 23, 2015, 5

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

tps://git.reviewboard.kde.org/r/126476/#comment61680> Missing std::abs. - Chusslove Illich On Дец. 23, 2015, 3:41 по п., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

eply, visit: > https://git.reviewboard.kde.org/r/126476/ > ------- > > (Updated Дец. 23, 2015, 1:53 по п.) > > > Review request for KDE Frameworks and Chusslove Illich. > > > Repository: ki18n > > > Desc

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

plural calls in QML, the first argument must be the plural-deciding number. Best in the part where it currently mentions that the first integer-typed argument is plural-deciding. - Chusslove Illich On Дец. 23, 2015, 1:53 по п., Aleix Pol Gonzalez

Re: about ki18n/locales: installing only a subset?

> [: René J.V. Bertin :] > [...] AFAIK it's always been a habit among distributions to package > languages separately. Which distributions? Not the ones I use, Debian and Suse. I know only of Ubuntu doing it. >> [: Chusslove Illich :] >> Furthermore, if one thinks of stri

Re: about ki18n/locales: installing only a subset?

>> [: Chusslove Illich :] >> It has a use in every situation where multiple-language users work in a >> centrally administered network. Like in... an office. > > [: René J.V. Bertin :] > How many offices do you know that require all known languages to be > installed

Re: about ki18n/locales: installing only a subset?

anually from the repo, that will not work properly. There will be versioning mismatches, and some files will be omitted, as PO files are not the only translation-related files. So this should be done only with a much stronger reason than disk usage. -- Chusslove Illich (Часлав Илић) signature.asc Description

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Дец. 4, 2015, 10:35 пре п., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be u

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Дец. 4, 2015, 10:35 пре п., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be u

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Дец. 4, 2015, 10:35 пре п., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be u

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Дец. 4, 2015, 10:35 пре п., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be u

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

, to install its own translations. And so do other higher-tier frameworks. So I'm not sure when this no-Gettext/no-Python build is supposed to be useful. When one wants to omit translations? - Chusslove Illich On Дец. 4, 2015, 1:17 пре п., Boudewijn Rempt wrote

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Дец. 4, 2015, 10:35 пре п., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be u

Re: Review Request 126152: Fly away from QString::isNull() in favor of isEmpty()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126152/#review88755 --- Ship it! Ship It! - Chusslove Illich On Нов. 24, 2015, 12

Re: Review Request 126087: Move the i18n context from KDeclarative

the message will be messed up more than necessary. Better substitute something, e.g. "???". - Chusslove Illich On Нов. 23, 2015, 12:54 по п., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e

Re: Review Request 126087: Move the i18n context from KDeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88721 --- Ship it! Ship It! - Chusslove Illich On Нов. 23, 2015, 1

Re: Review Request 126087: Move the i18n context from KDeclarative

this should be a loop over all arguments, until first successful conversion. (Of course, better if the originating numeric types can be recovered.) - Chusslove Illich On Нов. 19, 2015, 5 по п., Aleix Pol Gonzalez wrote: > > --- >

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Нов. 17, 2015, 9:43 пре п., Chusslove Illich wrote: > > Could you also document the usage in docs/programmers-guide.md (section > > #link_cat)? I'm not much into QML, so it would help me understand the > > implications of the usage. > > > > It seems

Re: Review Request 126087: Move the i18n context from KDeclarative

-guide.md (section #link_cat)? I'm not much into QML, so it would help me understand the implications of the usage. It seems to me other three series of calls (xi18n*, ki18n*, kxi18n*) should be made available as well. - Chusslove Illich On Нов. 16, 2015, 3:55 по п., Aleix Pol Gonzalez wrote

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On Окт. 18, 2015, 10:44 пре п., Albert Astals Cid wrote: > > src/kmainwindow.cpp, line 209 > > > > > > This is not going to work, you need to undefine TRANSLATION_DOMAIN > > include klocalizedstring again and

Re: Review Request 125695: Make KAboutData::translators/setTranslators simple

, it should not depend on anything Gettext related. And because there is no such special message convention in Qt, makes little sense to use Qt::tr(). - Chusslove Illich On Окт. 19, 2015, 12:38 пре п., Albert Astals Cid wrote

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

marked as submitted. Review request for KDE Frameworks, Alexander Potashev and Matthew Dawson. Changes --- Submitted with commit 2fff683110385047bd20fb5f0b68a008b48320dd by Chusslove Illich (?? ) to branch master. Repository: kconfig Description --- When using Ki18n

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

:47 по п., Chusslove Illich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123872/ --- (Updated Јун 21, 2015, 10:47 по п

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

://git.reviewboard.kde.org/r/123872/diff/ Testing --- Compiles. Thanks, Chusslove Illich ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123872/#review80698 --- On Мај 21, 2015, 5:21 по п., Chusslove Illich wrote

Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

/kconfig_compiler/kconfig_compiler.cpp 7160bb5 Diff: https://git.reviewboard.kde.org/r/123872/diff/ Testing --- Compiles. Thanks, Chusslove Illich ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 123453: ki18n: Remove mention of language skipping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123453/#review79331 --- Ship it! Ship It! - Chusslove Illich On Април 21, 2015, 9

Re: Review Request 122937: Preserve translation domain when merging KXmlGui files

marked as submitted. Review request for KDE Frameworks, David Faure and Lasse Liehu. Changes --- Submitted with commit 2920e946c24d78eb0b6b3038a9cc38a8897ce4ac by Chusslove Illich (?? ) to branch master. Repository: kxmlgui Description --- When two .rc documents

Review Request 122937: Preserve translation domain when merging KXmlGui files

/kxmlguiclient.cpp 12d3f44 Diff: https://git.reviewboard.kde.org/r/122937/diff/ Testing --- Tested an application that previously had an untranslated menu title due to this issue, now it is translated. Thanks, Chusslove Illich ___ Kde-frameworks

Re: Review Request 122754: Remove use of KI18N_MODULE_DIR.

works. - Chusslove Illich On Феб. 28, 2015, 2:52 по п., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122754

Re: Review Request 122204: Mark results as required.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122204/#review74632 --- Ship it! Ship It! - Chusslove Illich On Јан. 22, 2015, 7

Re: delay i18n arg replacement

placeholder-like sequences (e.g. if foo above contained %1). -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: Review Request 122039: ki18n: add BUILD_WITH_QTSCRIPT option.

://git.reviewboard.kde.org/r/122039/ --- (Updated Јан. 13, 2015, 4:08 по п.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Use case: to use KIO core in an embedded device, having

Re: Review Request 122039: ki18n: add BUILD_WITH_QTSCRIPT option.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122039/#review73955 --- Ship it! Ship It! - Chusslove Illich On Јан. 13, 2015, 4

Re: Review Request 121717: libksysguard/processtable: Add new column Relative Start Time

On Јан. 10, 2015, 5:29 по п., Dominik Haumann wrote: processui/timeutil.h, line 67 https://git.reviewboard.kde.org/r/121717/diff/2/?file=337999#file337999line67 No sure, but maybe in some language we need a proper singular / plural handling here, too? Same for the

Re: Translations in frameworks released tarballs

on packages that have foo5_* catalog name. My bad, fix attached. -- Chusslove Illich (Часлав Илић) From c7e9a79f337cf8eb65a46fe66cfb189bf1bba376 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Chusslove=20Illich=20=28=D0=A7=D0=B0=D1=81=D0=BB=D0=B0?= =?UTF-8?q?=D0=B2=20=D0=98=D0=BB=D0=B8=D1=9B=29?= caslav.i

Re: Translations are broken in KF5 apps

for Frameworks is still not resolved (to my knowledge?), so translations are actually not released right now. -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Translations are broken in KF5 apps

[: Chusslove Illich :] To note additionally, packaging of translations for Frameworks is still not resolved (to my knowledge?), so translations are actually not released right now. [: Albert Astals Cid :] I see the translations in the tarballs. Why do you say they are not released? My

Re: Review Request 118690: Introduce a KLocalizedTranslator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118690/#review60357 --- Ship it! Ship It! - Chusslove Illich On June 12, 2014, 10

Re: Review Request 118692: Fix reading of entries for language/country combinations

On June 12, 2014, 1:58 p.m., David Faure wrote: Looks good; but I'm surprised that it works :) the code for using fallbacks must be in there somewhere already then? (if de_DE not present then use de). This patch is only about not skipping these two entries (de and de_CH), but how

Re: Review Request 118692: Fix reading of entries for language/country combinations

specifies the parsing, but not the writing. In fact the only example is the other way around: Name=Foo Name[sr_YU]=... Name[sr@Latn]=... Name[sr]=... Chusslove Illich wrote: So... support for handling the language codes listed by David is simply gone in KF5

  1   2   3   >