D19811: Add Smali syntax highlighting file

[Dāvis Mosāns]

davispuh updated this revision to Diff 54631.
davispuh added a comment.


  Reduce size of test file

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19811?vs=54120=54631

BRANCH
  smali

REVISION DETAIL
  https://phabricator.kde.org/D19811

AFFECTED FILES
  autotests/folding/test.smali.fold
  autotests/html/test.smali.html
  autotests/input/test.smali
  autotests/reference/test.smali.ref
  data/syntax/smali.xml

To: davispuh, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19811: Add Smali syntax highlighting file

[Dāvis Mosāns]

davispuh updated this revision to Diff 54120.
davispuh added a comment.


  Add a test

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19811?vs=54046=54120

BRANCH
  smali

REVISION DETAIL
  https://phabricator.kde.org/D19811

AFFECTED FILES
  autotests/folding/test.smali.fold
  autotests/html/test.smali.html
  autotests/input/test.smali
  autotests/reference/test.smali.ref
  data/syntax/smali.xml

To: davispuh, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19811: Add Smali syntax highlighting file

[Dāvis Mosāns]

davispuh updated this revision to Diff 54046.
davispuh added a comment.


  Use MIT license

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19811?vs=54045=54046

BRANCH
  smali

REVISION DETAIL
  https://phabricator.kde.org/D19811

AFFECTED FILES
  data/syntax/smali.xml

To: davispuh, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19811: Add Smali syntax highlighting file

[Dāvis Mosāns]

davispuh created this revision.
davispuh added reviewers: cullmann, dhaumann, vkrause.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davispuh requested review of this revision.

TEST PLAN
  Open 
https://github.com/JesusFreke/smali/blob/master/smali/src/test/resources/LexerTest/RealSmaliFileTest.smali

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  smali

REVISION DETAIL
  https://phabricator.kde.org/D19811

AFFECTED FILES
  data/syntax/smali.xml

To: davispuh, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19533: Don't crash on malformed syntax highlighting files

[Dāvis Mosāns]

davispuh updated this revision to Diff 53970.
davispuh added a comment.


  Also check for present formats

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19533?vs=53237=53970

BRANCH
  malformed

REVISION DETAIL
  https://phabricator.kde.org/D19533

AFFECTED FILES
  src/syntax/katehighlight.cpp

To: davispuh, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh added a comment.


  In D19644#428074 , @bruns wrote:
  
  > Do not create a new transaction per file, thats costly.
  
  
  Still less expensive than single transaction for 1k files

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh updated this revision to Diff 53549.
davispuh edited the summary of this revision.
davispuh edited the test plan for this revision.
davispuh added a comment.


  Don't create transaction for every file

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19644?vs=53537=53549

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19644

AFFECTED FILES
  src/engine/writetransaction.cpp
  src/tools/balooctl/main.cpp

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh added a comment.


  In D19644#428047 , @bruns wrote:
  
  > A transaction can not be split up, thats the reason it is a transaction ...
  
  
  It can and they must be split in a lot smaller transactions. Currently 
sometimes baloo uses way too big transactions which causes memory usage to 
spike.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh edited the summary of this revision.
davispuh edited the test plan for this revision.
davispuh added reviewers: dhaumann, bruns, ngraham.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
davispuh requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19644

AFFECTED FILES
  src/engine/writetransaction.cpp
  src/tools/balooctl/main.cpp

To: davispuh
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19533: Don't crash on malformed syntax highlighting files

[Dāvis Mosāns]

davispuh updated this revision to Diff 53237.
davispuh added a comment.


  Don't duplicate code

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19533?vs=53236=53237

BRANCH
  malformed

REVISION DETAIL
  https://phabricator.kde.org/D19533

AFFECTED FILES
  src/syntax/katehighlight.cpp

To: davispuh, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19533: Don't crash on malformed syntax highlighting files

[Dāvis Mosāns]

davispuh updated this revision to Diff 53236.
davispuh added a comment.


  Whoops...

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19533?vs=53235=53236

BRANCH
  malformed

REVISION DETAIL
  https://phabricator.kde.org/D19533

AFFECTED FILES
  src/syntax/katehighlight.cpp

To: davispuh, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19533: Don't crash on malformed syntax highlighting files

[Dāvis Mosāns]

davispuh updated this revision to Diff 53235.
davispuh added a comment.


  Allow invalid Format()

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19533?vs=53177=53235

BRANCH
  malformed

REVISION DETAIL
  https://phabricator.kde.org/D19533

AFFECTED FILES
  CMakeLists.txt
  src/syntax/katehighlight.cpp

To: davispuh, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh updated this revision to Diff 53234.
davispuh added a comment.


  Improvements

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19532?vs=53175=53234

BRANCH
  context

REVISION DETAIL
  https://phabricator.kde.org/D19532

AFFECTED FILES
  autotests/input/syntax/brokenlang.xml
  autotests/syntaxrepository_test.cpp
  autotests/test-config.h.in
  src/lib/abstracthighlighter.cpp
  src/lib/definition.cpp

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh added a comment.


  In D19532#425381 , @cullmann wrote:
  
  > Calling the ::get is no issue.
  
  
  That's good then, but we can't use `applyFormat(0, text.size(), Format());` 
because Kate asserts when `!Format->isValid()` which it won't be so we have to  
`return State();` and also see D19533 

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh added a comment.


  In D19532#425376 , @cullmann wrote:
  
  > No, because defData isn't defined there yet, it's created only later with 
auto defData = DefinitionData::get(d->m_definition);
  >
  > => you can just move that up some lines, or?
  >
  > I actually have taken a short look, perhaps a issue is already that 
"isValid()" is true even if we fail to load anything useful.
  
  
  I'm not sure if we can call `DefinitionData::get(d->m_definition);` when 
`m_definition->isValid` isn't valid.
  So we still would end up with pretty much the same
  
if (!d->m_definition.isValid()) {
return State();
}
auto defData = DefinitionData::get(d->m_definition);
if (!defData->isLoaded()) {
return State();
}
  
  or wrap it all around
  
if (d->m_definition.isValid()) {

}
  
  
  
  In D19532#425378 , @cullmann wrote:
  
  > F6660164: test.diff 
  >
  > This would be my proposed patch + unit test.
  
  
  are you sure we're allowed to call `DefinitionData::get(d->m_definition);` 
when `m_definition->isValid` isn't valid ?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh added a comment.


  In D19532#424926 , @cullmann wrote:
  
  > Hi, first: good thing to get this fixed, yes, it shall not crash.
  >
  > For the fix: Wouldn't it be enough to just change the
  >
  > if (!d->m_definition.isValid()) {
  >
  >   applyFormat(0, text.size(), Format());
  >
  > ​  ...
  >
  > shortcut to check for
  >
  > if (!d->m_definition.isValid() || defData->isLoaded()) {
  
  
  No, because `defData` isn't defined there yet, it's created only later with 
`auto defData = DefinitionData::get(d->m_definition);`

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19533: Don't crash on malformed syntax highlighting files

[Dāvis Mosāns]

davispuh added reviewers: cullmann, dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19533

To: davispuh, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh added a dependent revision: D19533: Don't crash on malformed syntax 
highlighting files.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19533: Don't crash on malformed syntax highlighting files

[Dāvis Mosāns]

davispuh added a dependency: D19532: Don't crash when no contexts are present.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19533

To: davispuh, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19533: Don't crash on malformed syntax highlighting files

[Dāvis Mosāns]

davispuh created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davispuh requested review of this revision.

TEST PLAN
  1. Create malformed syntax highlighting file with missing end tags
  2. Place it in ~/.local/share/katepart5/syntax/
  3. Open Kate with file which uses that syntax highlighting

REPOSITORY
  R39 KTextEditor

BRANCH
  malformed

REVISION DETAIL
  https://phabricator.kde.org/D19533

AFFECTED FILES
  src/syntax/katehighlight.cpp

To: davispuh
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh updated this revision to Diff 53175.
davispuh added a comment.


  Actually fix it

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19532?vs=53170=53175

BRANCH
  context

REVISION DETAIL
  https://phabricator.kde.org/D19532

AFFECTED FILES
  src/lib/abstracthighlighter.cpp
  src/lib/definition.cpp

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh added a comment.


  Creating a syntax highlighting file with few unclosed tags made Kate to 
crash. No matter how malformed XML it loads, editor should never crash as it 
can cause loss of unsaved work.
  
  Crash is caused by
  
Context* DefinitionData::initialContext() const
{
Q_ASSERT(!contexts.isEmpty());
return contexts.first();
}
  
  which is called from
  
State AbstractHighlighter::highlightLine(const QString& text, const State 
)
{
Q_D(AbstractHighlighter);

// verify definition, deal with no highlighting being enabled
d->ensureDefinitionLoaded();
if (!d->m_definition.isValid()) {
applyFormat(0, text.size(), Format());
return State();
}

// verify/initialize state
auto defData = DefinitionData::get(d->m_definition);
auto newState = state;
auto stateData = StateData::get(newState);
const DefinitionRef currentDefRef(d->m_definition);
if (!stateData->isEmpty() && (stateData->m_defRef != currentDefRef)) {
qCDebug(Log) << "Got invalid state, resetting.";
stateData->clear();
}
if (stateData->isEmpty()) {
stateData->push(defData->initialContext(), QStringList());
stateData->m_defRef = currentDefRef;
}
  
  here's the backtrace itself
  
#0  0x7fe9863b4d7f in raise () from /usr/lib/libc.so.6
#1  0x7fe98639f672 in abort () from /usr/lib/libc.so.6
#2  0x7fe9867567fc in QMessageLogger::fatal(char const*, ...) const () 
from /usr/lib/libQt5Core.so.5
#3  0x7fe986755c28 in qt_assert(char const*, char const*, int) () from 
/usr/lib/libQt5Core.so.5
#4  0x7fe985e966f3 in 
KSyntaxHighlighting::DefinitionData::initialContext (this=) from 
/usr/lib/libKF5SyntaxHighlighting.so.5
#5  0x7fe985e981c2 in 
KSyntaxHighlighting::AbstractHighlighter::highlightLine 
(this=this@entry=0x55c256cba090, text=..., state=...)
at /usr/include/qt/QtCore/qlist.h:151
#6  0x7fe988464b6f in KateHighlighting::doHighlight 
(this=0x55c256cba090, prevLine=, textLine=0x55c25690cb70, 
nextLine=nextLine@entry=0x55c2569b7420, ctxChanged=@0x7ffe2d101ae3: 
false, tabWidth=8)
at /usr/src/debug/ktexteditor/src/buffer/katetextline.h:311
#7  0x7fe9883facbd in KateBuffer::doHighlight (invalidate=, endLine=, startLine=, 
this=0x55c257a097d0) at 
/usr/src/debug/ktexteditor/src/document/katebuffer.h:203
#8  KateBuffer::doHighlight (this=0x55c257a097d0, startLine=, endLine=, invalidate=)
at /usr/src/debug/ktexteditor/src/document/katebuffer.cpp:360
#9  0x7fe9883d8cf4 in KTextEditor::DocumentPrivate::kateTextLine 
(this=0x55c255de2c10, i=0)
at /usr/src/debug/ktexteditor/src/document/katedocument.cpp:5249
#10 0x7fe98844a0a5 in KateLineLayout::textLine (this=0x55c256b75980, 
reloadForce=reloadForce@entry=false)
at /usr/src/debug/ktexteditor/src/render/katelinelayout.cpp:79
#11 0x7fe988440350 in KateRenderer::layoutLine (this=0x55c256cef2a0, 
lineLayout=..., maxwidth=-1, cacheLayout=)
at /usr/src/debug/ktexteditor/src/render/katerenderer.cpp:1021
#12 0x7fe988444591 in KateLayoutCache::line (this=0x55c256cee360, 
realLine=0, virtualLine=)
at /usr/include/c++/8.2.1/bits/atomic_base.h:295
#13 0x7fe988446a6a in KateLayoutCache::updateViewCache 
(this=this@entry=0x55c256cee360, startPos=..., 
newViewLineCount=newViewLineCount@entry=40, 
viewLinesScrolled=viewLinesScrolled@entry=0)
at /usr/src/debug/ktexteditor/src/render/katelayoutcache.cpp:242
#14 0x7fe98848916b in KateViewInternal::updateView 
(this=0x55c255f63a50, changed=true, viewLinesScrolled=viewLinesScrolled@entry=0)
at /usr/src/debug/ktexteditor/src/include/ktexteditor/cursor.h:98
#15 0x7fe98846f3a7 in KTextEditor::ViewPrivate::updateView 
(this=0x55c255f30f40, changed=)
at /usr/src/debug/ktexteditor/src/view/kateview.cpp:2047
#16 0x7fe9883dc786 in KTextEditor::DocumentPrivate::makeAttribs 
(this=this@entry=0x55c255de2c10, needInvalidate=needInvalidate@entry=false)
at /usr/src/debug/ktexteditor/src/document/katedocument.cpp:2910
#17 0x7fe9883dc7fc in KTextEditor::DocumentPrivate::bufferHlChanged 
(this=0x55c255de2c10)
at /usr/src/debug/ktexteditor/src/document/katedocument.cpp:1876
#18 0x7fe9883faaad in KateBuffer::setHighlight (this=0x55c257a097d0, 
hlMode=)
at /usr/src/debug/ktexteditor/src/document/katebuffer.cpp:346
#19 0x7fe9883ec4ff in KTextEditor::DocumentPrivate::updateFileType 
(this=this@entry=0x55c255de2c10, newType=..., user=user@entry=false)
at /usr/src/debug/ktexteditor/src/document/katedocument.cpp:5061
#20 0x7fe9883ef5b4 in KTextEditor::DocumentPrivate::openFile 
(this=0x55c255de2c10) at /usr/src/debug/ktexteditor/src/utils/kateglobal.h:252
#21 

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh added reviewers: cullmann, dhaumann, vandenoever.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Dāvis Mosāns]

davispuh created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davispuh requested review of this revision.

TEST PLAN
  1. Compiled
  2. Placed malformed XML in ~/.local/share/katepart5/syntax/
  3. Opened a file which uses that previously created highlighter

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  context

REVISION DETAIL
  https://phabricator.kde.org/D19532

AFFECTED FILES
  src/lib/definition.cpp

To: davispuh
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

Re: Scrap baloo?

[Dāvis Mosāns]

What about using already existing solutions for indexing and storage?
like for example there are projects:

* Apache Lucene - https://lucene.apache.org/
* Apache Solr - https://lucene.apache.org/solr/  (it's built on top of Lucene)
* ElasticSearch - https://www.elastic.co/
* Xapian - https://xapian.org/

these all are search engines and isn't that Baloo's goal to index
files and search them...
I'm just throwing this idea about using something already meant for
such purpose.
For example, for my use case currently I've like ~20TB of data
(documents, photos, audio, video) and I want to index and search them
all.

Re: Review Request 127281: [kio-extras] Audio (id3) thumbnailer

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127281/#review93176
---



do you know about https://github.com/eplightning/audiothumbs-frameworks ? it 
works fine with Qt5/KF5 and I've been using to for months. I wonder if there 
would be some better way with either merging it all in here or something 
without duplicating code. Currently it supports more formats than this RR gives.

- Dāvis Mosāns


On marts 4, 2016, 11:43 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127281/
> ---
> 
> (Updated marts 4, 2016, 11:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> This is basically a port and cleanup of the Audio Thumbnailer to KF5, I find 
> it useful to ship this by default. Minus the FLAC part as I don't have any 
> FLAC stuff :)
> 
> 
> Diffs
> -
> 
>   thumbnail/CMakeLists.txt 4addb26 
>   thumbnail/audiocreator.h PRE-CREATION 
>   thumbnail/audiocreator.cpp PRE-CREATION 
>   thumbnail/audiothumbnail.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127281/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/04/b099ec03-7fa7-4ed3-91c4-bc55c62c72ca__Screenshot_20160304_224228.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127187/#review92814
---




src/lib/activitiesmodel.h (line 96)
<https://git.reviewboard.kde.org/r/127187/#comment63238>

Wouldn't it be better to use _MSC_VER <= 1800 /* MSVC2013 */

as maybe it works for MSVC2015?


- Dāvis Mosāns


On Feb. 26, 2016, 11:32 a.m., Thomas Friedrichsmeier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127187/
> ---
> 
> (Updated Feb. 26, 2016, 11:32 a.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> ---
> 
> MSVC (2013) complains that beginResetModel(), etc. are protected. This patch 
> allows the code to compile. It is clearly not very elegant, but both my 
> templating- and MSVC-foo is extremely limited. Not sure, if there is a better 
> fix.
> 
> 
> Diffs
> -
> 
>   src/lib/activitiesmodel.h 7258b73 
> 
> Diff: https://git.reviewboard.kde.org/r/127187/diff/
> 
> 
> Testing
> ---
> 
> Now compiles with MSVC 2013 on Windows.
> 
> 
> Thanks,
> 
> Thomas Friedrichsmeier
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126587: Add option to build with gcov support

[Dāvis Mosāns]

> On Jan. 2, 2016, 3:57 a.m., Aleix Pol Gonzalez wrote:
> > Well, then it's implemented by `ECMCoverageOption.cmake` in ECM, and 
> > included by `KDECompilerSettings.cmake`. If anything, the proper fix would 
> > be to remove this kind of code from elsewhere.

Indeed.


- Dāvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126587/#review90426
---


On Dec. 31, 2015, 11:13 p.m., Dāvis Mosāns wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126587/
> ---
> 
> (Updated Dec. 31, 2015, 11:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjsembed
> 
> 
> Description
> ---
> 
> Add option to build with gcov support
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e 
> 
> Diff: https://git.reviewboard.kde.org/r/126587/diff/
> 
> 
> Testing
> ---
> 
> Compiles
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126587: Add option to build with gcov support

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126587/
---

(Updated Jan. 4, 2016, 10:21 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kjsembed


Description
---

Add option to build with gcov support


Diffs
-

  CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e 

Diff: https://git.reviewboard.kde.org/r/126587/diff/


Testing
---

Compiles


Thanks,

Dāvis Mosāns

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126587: Add option to build with gcov support

[Dāvis Mosāns]

> On Jan. 2, 2016, 1:56 a.m., Aleix Pol Gonzalez wrote:
> > That's provided by ecm, isn't it?

I don't know... I based this on KWin 
https://quickgit.kde.org/?p=kwin.git=blob=master=CMakeLists.txt#l249


- Dāvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126587/#review90423
---


On Dec. 31, 2015, 11:13 p.m., Dāvis Mosāns wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126587/
> ---
> 
> (Updated Dec. 31, 2015, 11:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjsembed
> 
> 
> Description
> ---
> 
> Add option to build with gcov support
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e 
> 
> Diff: https://git.reviewboard.kde.org/r/126587/diff/
> 
> 
> Testing
> ---
> 
> Compiles
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126587: Add option to build with gcov support

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126587/
---

Review request for KDE Frameworks.


Repository: kjsembed


Description
---

Add option to build with gcov support


Diffs
-

  CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e 

Diff: https://git.reviewboard.kde.org/r/126587/diff/


Testing
---

Compiles


Thanks,

Dāvis Mosāns

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125756: Initialize QFunctionPointer to nullptr

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125756/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Need to initialize QFunctionPointer to nullptr because otherwise it's used 
unitialized
causing m_eglCreateImageKHR check to pass and crashing plasmashell because of 
invalid call.
Look at xcbWindowToTextureEGL function in 
src/declarativeimports/core/windowthumbnail.cpp


Diffs
-

  src/declarativeimports/core/windowthumbnail.h 
576b053229a8cfc15b6fadd8d4e6ff07f937565d 

Diff: https://git.reviewboard.kde.org/r/125756/diff/


Testing
---

Verified that plasmashell doesn't crash anymore.


Thanks,

Dāvis Mosāns

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125756: Initialize QFunctionPointer to Q_NULLPTR

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125756/
---

(Updated Oct. 22, 2015, 3:31 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Use Q_NULLPTR and initialize in cpp


Summary (updated)
-

Initialize QFunctionPointer to Q_NULLPTR


Repository: plasma-framework


Description (updated)
---

Need to initialize QFunctionPointer to Q_NULLPTR because otherwise it's used 
unitialized
causing m_eglCreateImageKHR check to pass and crashing plasmashell because of 
invalid call.
Look at xcbWindowToTextureEGL function in 
src/declarativeimports/core/windowthumbnail.cpp


Diffs (updated)
-

  src/declarativeimports/core/windowthumbnail.cpp 
5a5274e1eacdb9b91ff500e1ebf9046930891ecf 

Diff: https://git.reviewboard.kde.org/r/125756/diff/


Testing
---

Verified that plasmashell doesn't crash anymore.


Thanks,

Dāvis Mosāns

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125756: Initialize QFunctionPointer to Q_NULLPTR

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125756/
---

(Updated Oct. 22, 2015, 1:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 39f8db95c2dd227cf46eccb22b5b3860224894a6 by D?vis Mos?ns 
to branch master.


Repository: plasma-framework


Description
---

Need to initialize QFunctionPointer to Q_NULLPTR because otherwise it's used 
unitialized
causing m_eglCreateImageKHR check to pass and crashing plasmashell because of 
invalid call.
Look at xcbWindowToTextureEGL function in 
src/declarativeimports/core/windowthumbnail.cpp


Diffs
-

  src/declarativeimports/core/windowthumbnail.cpp 
5a5274e1eacdb9b91ff500e1ebf9046930891ecf 

Diff: https://git.reviewboard.kde.org/r/125756/diff/


Testing
---

Verified that plasmashell doesn't crash anymore.


Thanks,

Dāvis Mosāns

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125556: Install CamelCase headers

[Dāvis Mosāns]

> On Oct. 11, 2015, 2:02 p.m., Alexander Potashev wrote:
> > libmediawiki is not part of KF5, I would avoid installing into 
> > /usr/include/KF5 to prevent possible collision in the future.

ok, like this? but it also installs KF5/mediawiki_version.h that's from main 
CMakeLists.txt


- Dāvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125556/#review86657
---


On Oct. 11, 2015, 10:46 p.m., Dāvis Mosāns wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125556/
> ---
> 
> (Updated Oct. 11, 2015, 10:46 p.m.)
> 
> 
> Review request for KDE Frameworks and Adrián Chaves Fernández.
> 
> 
> Repository: libmediawiki
> 
> 
> Description
> ---
> 
> They were generated but wasn't installed.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a8e095ab0a5eaf86c2fc3b5035ef5d476b899023 
> 
> Diff: https://git.reviewboard.kde.org/r/125556/diff/
> 
> 
> Testing
> ---
> 
> Compiles and headers are installed.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125556: Install CamelCase headers

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125556/
---

(Updated Oct. 11, 2015, 10:46 p.m.)


Review request for KDE Frameworks and Adrián Chaves Fernández.


Changes
---

don't put in KF5


Repository: libmediawiki


Description
---

They were generated but wasn't installed.


Diffs (updated)
-

  src/CMakeLists.txt a8e095ab0a5eaf86c2fc3b5035ef5d476b899023 

Diff: https://git.reviewboard.kde.org/r/125556/diff/


Testing
---

Compiles and headers are installed.


Thanks,

Dāvis Mosāns

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125556: Install CamelCase headers

[Dāvis Mosāns]

> On Oct. 12, 2015, 12:03 a.m., David Faure wrote:
> > src/CMakeLists.txt, line 24
> > <https://git.reviewboard.kde.org/r/125556/diff/3/?file=410588#file410588line24>
> >
> > Well, then the lib itself shouldn't be called KF5MediaWiki?
> > 
> > But of course changing this is only possible if it hasn't been released 
> > yet.

idk, ask it whoever is maintaining it :D it doesn't really matter for me what 
it's called :P
but if it's changed it will need changes in like kipi-plugins (and maybe 
elsewhere) because currently it uses KF5MediaWiki


- Dāvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125556/#review86673
-------


On Oct. 11, 2015, 10:46 p.m., Dāvis Mosāns wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125556/
> ---
> 
> (Updated Oct. 11, 2015, 10:46 p.m.)
> 
> 
> Review request for KDE Frameworks and Adrián Chaves Fernández.
> 
> 
> Repository: libmediawiki
> 
> 
> Description
> ---
> 
> They were generated but wasn't installed.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a8e095ab0a5eaf86c2fc3b5035ef5d476b899023 
> 
> Diff: https://git.reviewboard.kde.org/r/125556/diff/
> 
> 
> Testing
> ---
> 
> Compiles and headers are installed.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125556: Install CamelCase headers

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125556/
---

(Updated Oct. 11, 2015, 2:56 a.m.)


Review request for KDE Frameworks and Adrián Chaves Fernández.


Changes
---

update


Repository: libmediawiki


Description
---

They were generated but wasn't installed.


Diffs (updated)
-

  src/CMakeLists.txt a8e095ab0a5eaf86c2fc3b5035ef5d476b899023 

Diff: https://git.reviewboard.kde.org/r/125556/diff/


Testing
---

Compiles and headers are installed.


Thanks,

Dāvis Mosāns

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125556: Install CamelCase headers

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125556/
---

Review request for KDE Frameworks and Adrián Chaves Fernández.


Repository: libmediawiki


Description
---

They were generated but wasn't installed.


Diffs
-

  src/CMakeLists.txt a8e095ab0a5eaf86c2fc3b5035ef5d476b899023 

Diff: https://git.reviewboard.kde.org/r/125556/diff/


Testing
---

Compiles and headers are installed.


Thanks,

Dāvis Mosāns

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Love for Konqueror

[Dāvis Mosāns]

2015-09-07 12:10 GMT+03:00 Allan Sandfeld Jensen :
>> I think using [1] CEF (Chromium Embedded Framework) could be good idea as
>> then both [2] Blink and [3] Servo can be used.
>>
> CEF also doesn't appear to have had an update since January 2015. It doesn't
> appear regularly maintained.

I don't know where you looked, but that's just false. There have been
2 CEF releases
(and ~120 commits) since January.

https://bitbucket.org/chromiumembedded/cef/wiki/BranchesAndBuilding#markdown-header-release-branches
https://cefbuilds.com/

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Love for Konqueror

[Dāvis Mosāns]

2015-09-06 13:27 GMT+03:00 David Faure :
> (redirecting to kfm-devel where konqueror development used to happen)
>
> On Tuesday 09 December 2014 21:10:01 Martin Steigerwald wrote:
>> Hi!
>>
>> I see some discussion in the thread "Re: Is Konqueror still a live project?",
>> which seems to be incomplete in my kmail devel-ml folder tough, but it 
>> doesn´t
>> seem it came to any conclusion.
>>
>> I am posting as a user who reports bug, helped with a little performance
>> optimization work and CRM114 spamfilter configuration for KMail and builds 
>> some
>> stuff to help testing and to make it short:
>>
>> I miss an updated Konqi. I mean the Konqueror webbrowser.
>>
>> I used it often but I use it less and less as it has various problems:
>>
>> - websites not rendering correctly with KHTML
>>
>> - Strg + / - zoom not working for Webkit (thats why I have it at KHTML to
>> resize websites quickly in Akregator)
>>
>> - Issues with SSL/TLS certificate handling (on certain sites I get asked 
>> about
>> certifictate from fbstatic.com or so, seems sites who link to facebook 
>> stuff, I
>> tried accepting the cert or disallowing it but I get this again and again)
>>
>>
>> Alternatives all have their weaknesses.
>>
>> - Iceweasel / Firefox: I just look at the GTK file dialog box it uses and I 
>> am
>> done with it (sorry, to be honest: One of the worst usability nightmares
>> *ever*). Or that you cannot search cookie exception rules. And integration
>> issues with KDE here and there. I know people tried making KDE integration,
>> but it is not readily available in Debian.
>
> Not even the file dialog integration? Wow. That one works well in OpenSuSE.
>
>> - Chromium: It still feels like a forein body in my KDE desktop. It is fast
>> and all that… but what gives, even with system window borders…
>>
>>
>> And then only Konqi does:
>>
>> - ton of other protocols and KIO stuff
>>
>> - easily have several windows open which are *separate* processes (unlike
>> Iceweasel or Chromium or even Qupzilla it seems, and I think even rekonq 
>> which
>> is not currently packaged for Debian, last is 0.9.2-1 for Wheezy, I do have a
>> 2.4.2 package from someone who did one, but thats also not updated)
>>
>> - integrate that well with KDE desktop, bookmark handling, Alt-F2 krunner 
>> stuff
>> and so on. Some of the Alt-F2 stuff doesn´t work as I replaced default 
>> browser
>> with Qupzilla at the moment. I do not remember which at the moment, but there
>> are things that don´t work with it.
>>
>> - web archives into war files. I loved this, but this also only works with
>> KHTML.
>
> That last bit should be easy to fix, I would think.
>
>> I bet webbrowser work is a lot of work… but are there any plans, ideas?
>>
>> Right now I get the impression it at least to some extent bitrots, which is
>> sad.
>>
>> Konqi with updated web engine… and well, okay, maybe a core set of
>> functionality, maybe it doesn´t need all the functions, maybe some kind of
>> usability studies could reveal what people want most in it, miss most with
>> other browsers compared to Konqueror.
>>
>> I think Konqueror was once one of the pillars of KDE. I´d love to see a
>> comeback of it. My C++ coding skills are pretty basic, but I would like to
>> help in ways I can. And maybe it can be QMLified for its GUI.
>>
>>
>> Right now there is no webbrowser that really satisfies me to use in Plasma
>> desktop.
>>
>> I know this is may be a huge one, but I wanted to draw some attention to 
>> this.
>
> I agree with everything you said, but I just don't have time to take care of 
> Konqueror
> in addition to KF5 and Qt contributions.
>
> In fact, there are a number of orthogonal issues:
>
> * Konqueror's GUI itself, which requires a sensibility to usability and 
> modern GUIs
> (see my blog for a set of ideas from Nuno years ago, or Rekonq for an 
> alternative).
> Is Rekonq still developed / maintained, btw?
>
> * The webbrowsing engine. KHTML is fully under our control, but bitrotting.
> QtWebKit is "frozen" by Qt, so hard to change.
> QtWebEngine is AFAIK a closed monolith where we can't integrate KIO.
> There's no good choice in there it seems :(

There are choices, just have to choose one.

Maintaining web engine is a massive task (web standards are huge) and it's not
really practical for small team. Also from user's perspective when two engines
support standards correctly then it doesn't matter which engine is used and more
important is UI/UX. Thus I would say that using not actively
maintained web engine
is worst choice. Even Opera switched from their own Presto engine to Blink.

So choice is between which actively maintained web engine to use.
Gecko, Servo, Blink or WebKit2? (QtWebEngine is basically
Chromium/Blink wrapper)

I think using [1] CEF (Chromium Embedded Framework) could be good idea as
then both [2] Blink and [3] Servo can be used.

[1] https://bitbucket.org/chromiumembedded/cef
[2] https://www.chromium.org/blink
[3] 

Re: Plasma Applet for Audio Volume for kdereview

[Dāvis Mosāns]

2015-08-10 13:33 GMT+03:00 Sebastian Kügler se...@kde.org:
 On Sunday, August 09, 2015 14:59:59 Dāvis Mosāns wrote:
 2015-08-05 15:45 GMT+03:00 Jonathan Riddell j...@jriddell.org:
  plasma-pa is a new volume manager and is intended to be a replacement for
  KMix in Plasma.
 
  We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview
  for your reviewing attention.
 
  https://projects.kde.org/projects/kdereview/plasma-pa

 I can't find how to move specific application to different output like
 you can in KMix, it's not implemented?
 This is very important feature for me. Also I think it would be handy
 if in tray would be another tab
 for changing volume for applications too and wouldn't need to open settings.

 You can do that from the KCM, but not from the Plasmoid. Whether that's a
 usecase we want to support at this point, I'm not sure (I personally would
 like to see switching outputs per source easily). It's not material for its
 first release, anyway. We're past feature freeze and the goal was to get a
 basic first version released rather than having it lingering for a long time.

I looked there, System Settings - Multimedia - Audio Volume - Applications
and don't see there any option for switching output device, only
changing volume.
Also I'm not only one who's wondering about this
https://www.reddit.com/r/kde/comments/3igy0v/is_there_any_way_in_the_new_audio_applet_to/

Re: Replacement for KDateTime

[Dāvis Mosāns]

2015-08-11 0:37 GMT+03:00 David Jarvie djar...@kde.org:
 On Mon, August 10, 2015 11:31 am, Dāvis Mosāns wrote:
 2015-08-10 11:34 GMT+03:00 John Layt j...@layt.net:
 On 9 August 2015 at 17:26, Dāvis Mosāns davis...@gmail.com wrote:


 When I implement date/time related things I always use timestamps in
 UTC everywhere
 and when need to display to user or pass to some API then convert to
 respective
 format and timezone. Any other way makes it only more complicated.


 That works well when recording the time something occurred at, i.e. in
 the
 past, but it just doesn't work for events scheduled in the future when
 the
 time zone rules could change for both the source of the event and in any
 observers location. For example, if I'm in UTC+2 and I schedule a
 meeting
 every Monday  at 10am for the next 2 years, and the government changes
 the
 time zone rule from UTC+2 to UTC+3, if I stored the event time in UTC
 then
 my meeting has suddenly changed from 10am to 11am! If someone in the New
 York office phones in to the meeting, and their time zone rules change
 relative to UTC then they also get the wrong time. The only workable
 solution is to store the event in local time zone for the event location
 (unless they explicitly want UTC), and then convert it to the
 destination
 time zone at the last possible moment.


 Indeed, I hadn't thought about this. Basically there's 2 types of time,
 one
 is distinct fixed time point (I've worked only with these) and other
 is human time
 which doesn't really represent a distinct time because it might change
 relative
 to UTC.
 So if I set event to see solar eclipse I need to set it in UTC as
 otherwise it will
 be wrong when timezone or DST changes. But for meetings and other similar
 things need it in human time as it doesn't matter that current 10am
 actually isn't
 that that same 10am when it was set. Also thinking about this I
 realized that for
 human time you don't need timezone but actually a place, location. Because
 as you said timezone can change and it only depends on location. So to
 convert time between different locations you need to get current timezones
 for
 both locations. Timezone when event was set is useless because it might
 have changed by now. So basically need to store time in either UTC or with
 human time and location. Also location should be as precise as possible
 because theoretically country can split and each part change to
 different timezone.

 I think you misunderstand what is meant by time zone as defined by
 iCalendar and as it is used in the other mails in this thread. It means
 the set of offsets from UTC used officially in a country or region and
 when they apply, and how this changes over the years. In many locations,
 the time zone therefore defines UTC offsets for summer and winter and the
 dates and times in each year when the transitions between winter and
 summer time take place. I.e. a time zone is essentially what you refer to
 as human time.


Kinda, with timezone I meant it in form of plain offsets like +02:00 and that's
useless because that doesn't really tell anything.
Also timezones as implemented in Windows are bad because there same time
zone is used for multiple regions/countries. That's why I said you need a
location for human time (and not timezone like +02:00) and no, human time isn't
same as timezone, as I could have alarm set at 10:00 (human time) without any
timezone information so that even when moving countries (and changing clock
timezone) alarm still would be at 10:00 local time.

I didn't mentioned how such location to timezone mapping could be implemented
but everyone probably knows that tz database is actually such mapping.
Europe/Berlin is a location in Germany and it represents all timezone offsets
used there for various timezone periods. Also I was speculating that location
should be very precise because theoretically for example currently if user lives
in Düsseldorf and you're using Europe/Berlin timezone (which is correct now) but
then Germany decides to use different timezones for different parts of country,
say new timezone Euopre/Düsseldorf, that user now will have incorrect old
timezone for events, etc.  but if you store city and then map city to
timezone it all
would work as long as you've up-to-date mappings.

Seems currently time zone is quite ambiguous word and shouldn't use it to mean
time zone offset (but then again, that's what it is...), it's also
ambiguous because
it can refer to different time zone implementations (eg. like Windows vs tz
database).

Re: Plasma Applet for Audio Volume for kdereview

[Dāvis Mosāns]

2015-08-05 15:45 GMT+03:00 Jonathan Riddell j...@jriddell.org:
 plasma-pa is a new volume manager and is intended to be a replacement for 
 KMix in Plasma.

 We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview 
 for your reviewing attention.

 https://projects.kde.org/projects/kdereview/plasma-pa


I can't find how to move specific application to different output like
you can in KMix, it's not implemented?
This is very important feature for me. Also I think it would be handy
if in tray would be another tab
for changing volume for applications too and wouldn't need to open settings.

Re: Replacement for KDateTime

[Dāvis Mosāns]

2015-08-09 17:54 GMT+03:00 Sergio Martins iamser...@gmail.com:
 On Monday, August 03, 2015 14:59:59 Dāvis Mosāns wrote:
 Sorry for injecting myself, but IMO there's no such thing as Date-only and
 what you need is something like QDateTimeRange (just made up) where you
 would have start QDateTime, end QDateTime and it could represent any
 Event/Interval. Like whole day, part of day or even multiple days. And
 could also check whether some QDateTime is inside this range.

 Hi,

 iCalendar RFC (which KCalCore implements) distinguishes between all day events
 and events with time. A time interval going from 00:00:00 to 23:59:59 is not
 equivalent to a date only event, so we can't go that route.


Interesting, but I don't really see why would need to consider them different...
to me it seems pointless, also by the way to represent while day range
must be from
00:00:00 (including) to 00:00:00 (excluding) as with 23:59:59 you miss
milli/nano-seconds.
When I implement date/time related things I always use timestamps in
UTC everywhere
and when need to display to user or pass to some API then convert to respective
format and timezone. Any other way makes it only more complicated.

Re: Replacement for KDateTime

[Dāvis Mosāns]

2015-08-10 11:34 GMT+03:00 John Layt j...@layt.net:
 On 9 August 2015 at 17:26, Dāvis Mosāns davis...@gmail.com wrote:


 When I implement date/time related things I always use timestamps in
 UTC everywhere
 and when need to display to user or pass to some API then convert to
 respective
 format and timezone. Any other way makes it only more complicated.


 That works well when recording the time something occurred at, i.e. in the
 past, but it just doesn't work for events scheduled in the future when the
 time zone rules could change for both the source of the event and in any
 observers location. For example, if I'm in UTC+2 and I schedule a meeting
 every Monday  at 10am for the next 2 years, and the government changes the
 time zone rule from UTC+2 to UTC+3, if I stored the event time in UTC then
 my meeting has suddenly changed from 10am to 11am! If someone in the New
 York office phones in to the meeting, and their time zone rules change
 relative to UTC then they also get the wrong time. The only workable
 solution is to store the event in local time zone for the event location
 (unless they explicitly want UTC), and then convert it to the destination
 time zone at the last possible moment.


Indeed, I hadn't thought about this. Basically there's 2 types of time, one
is distinct fixed time point (I've worked only with these) and other
is human time
which doesn't really represent a distinct time because it might change relative
to UTC.
So if I set event to see solar eclipse I need to set it in UTC as
otherwise it will
be wrong when timezone or DST changes. But for meetings and other similar
things need it in human time as it doesn't matter that current 10am
actually isn't
that that same 10am when it was set. Also thinking about this I
realized that for
human time you don't need timezone but actually a place, location. Because
as you said timezone can change and it only depends on location. So to
convert time between different locations you need to get current timezones for
both locations. Timezone when event was set is useless because it might
have changed by now. So basically need to store time in either UTC or with
human time and location. Also location should be as precise as possible
because theoretically country can split and each part change to
different timezone.

Re: Review Request 124542: CMake fixes for Windows build

[Dāvis Mosāns]

 On Aug. 8, 2015, 5:40 p.m., Kevin Funk wrote:
  @Luigi: Bump?
 
 Luigi Toscano wrote:
 I was waiting for D?vis' answer, but given that 5.13 is out, there is 
 enough time to fix it before 5.14. So let's go, and thanks.
 
 Luigi Toscano wrote:
 Just please remember to use a more descriptive commit message than just 
 the bug number :)

Why would you wait for me..., I was just commenting and I don't have any 
objections as otherwise I would have said something. Of course proper fix would 
be preferable to any workarounds (I generally really dislike hacks :P) but 
workaround today is better than nothing (broken app) for ages.


- Dāvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124542/#review83574
---


On Aug. 6, 2015, 9:37 a.m., Kevin Funk wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124542/
 ---
 
 (Updated Aug. 6, 2015, 9:37 a.m.)
 
 
 Review request for Documentation, KDE Frameworks and Luigi Toscano.
 
 
 Bugs: 348061
 https://bugs.kde.org/show_bug.cgi?id=348061
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 BUG: 348061
 
 
 Diffs
 -
 
   cmake/uriencode.cmake e5f3c3acd93d3871e44b6e6fb29ad7113e18d751 
 
 Diff: https://git.reviewboard.kde.org/r/124542/diff/
 
 
 Testing
 ---
 
 Adding ':' to the list of escaped characters is probably not an ideal 
 solution, but let me hear your ideas.
 
 
 Thanks,
 
 Kevin Funk
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Replacement for KDateTime

[Dāvis Mosāns]

2015-08-02 21:32 GMT+03:00 David Jarvie djar...@kde.org:

 Date-only KDateTime instances are not only used for Event start/end
 timestamps. In KAlarm they are also used among other things for alarm snooze
 times (independently of whether the event is date-only or not). So usage of
 the date-only attribute is *not* restricted to Events (even if that is all
 it is used for in kcalcore).


Sorry for injecting myself, but IMO there's no such thing as Date-only and
what you need is something like QDateTimeRange (just made up) where you would
have start QDateTime, end QDateTime and it could represent any Event/Interval.
Like whole day, part of day or even multiple days. And could also check whether
some QDateTime is inside this range.

Re: Replacement for KDateTime

[Dāvis Mosāns]

2015-08-03 15:26 GMT+03:00 David Jarvie djar...@kde.org:
 On Monday 03 Aug 2015 12:59:59 you wrote:

 2015-08-02 21:32 GMT+03:00 David Jarvie djar...@kde.org:

 

  Date-only KDateTime instances are not only used for Event start/end

  timestamps. In KAlarm they are also used among other things for alarm
  snooze

  times (independently of whether the event is date-only or not). So usage
  of

  the date-only attribute is *not* restricted to Events (even if that is
  all

  it is used for in kcalcore).

 



 Sorry for injecting myself, but IMO there's no such thing as Date-only and

 what you need is something like QDateTimeRange (just made up) where you
 would

 have start QDateTime, end QDateTime and it could represent any
 Event/Interval.

 Like whole day, part of day or even multiple days. And could also check
 whether

 some QDateTime is inside this range.



 Date-only extends the current QDateTime concept to allow it to represent a
 single date (which is intrinsically a time range) or a single date-time,
 without requiring any extra date-time information to be stored - only a
 boolean flag is required to indicate whether the time component should be
 ignored.



 A generalised time range on the other hand requires storing distinct start
 and end times, and cannot (except for special cases) be represented by a
 single date or date-time.


That sounds like kind of a hack... trying to save few bytes for very
minimal use case.
As soon as you'll need to represent something outside of that you'll
need a proper range.
Besides can implement range with QDateTime + qint64

Re: Replacement for KDateTime

[Dāvis Mosāns]

2015-08-03 17:33 GMT+03:00 David Jarvie djar...@kde.org:
 On Monday 03 Aug 2015 14:29:41 Dāvis Mosāns wrote:

 2015-08-03 15:26 GMT+03:00 David Jarvie djar...@kde.org:

  On Monday 03 Aug 2015 12:59:59 you wrote:

 

  2015-08-02 21:32 GMT+03:00 David Jarvie djar...@kde.org:

 

  

 

   Date-only KDateTime instances are not only used for Event start/end

   timestamps. In KAlarm they are also used among other things for alarm

   snooze

   times (independently of whether the event is date-only or not). So
   usage

   of

   the date-only attribute is *not* restricted to Events (even if that
   is

   all

   it is used for in kcalcore).

  

 

 

 

  Sorry for injecting myself, but IMO there's no such thing as Date-only
  and

  what you need is something like QDateTimeRange (just made up) where you

  would

  have start QDateTime, end QDateTime and it could represent any

  Event/Interval.

 

  Like whole day, part of day or even multiple days. And could also check

  whether

  some QDateTime is inside this range.

 

 

 

  Date-only extends the current QDateTime concept to allow it to represent
  a

  single date (which is intrinsically a time range) or a single date-time,

  without requiring any extra date-time information to be stored - only a

  boolean flag is required to indicate whether the time component should
  be

  ignored.

 

 

 

  A generalised time range on the other hand requires storing distinct
  start

  and end times, and cannot (except for special cases) be represented by a

  single date or date-time.

 



 That sounds like kind of a hack... trying to save few bytes for very

 minimal use case.

 As soon as you'll need to represent something outside of that you'll

 need a proper range.

 Besides can implement range with QDateTime + qint64



 My point is that a QDateTime already contains both a date and a date-time. A
 date-only option provides the option to select one or the other. QDateTime
 does not contain a range, so a time range is something different (except for
 the special case of a single date). Adding a flag to select data which is
 already there is IMHO different in scope from adding extra data (either
 another QDateTime or a qint64).


Ok, I don't really understand what's your use case and so I don't see why you
would need that. There's QDate and QTime, you can use QDateTime::date() to
extract QDate and for other cases you really do need a range. Sounds
like you want QDateOrTime (also made up), but I think very few applications
would use something like. And IMO that's bad design, because cleaner code
would be with method overloads which take either QDate or QTime.

Re: Replacement for KDateTime

[Dāvis Mosāns]

2015-08-03 20:09 GMT+03:00 Martin Klapetek martin.klape...@gmail.com:
 On Mon, Aug 3, 2015 at 6:34 PM, Thiago Macieira thi...@kde.org wrote:

 On Monday 03 August 2015 08:33:54 Martin Klapetek wrote:
   If the format you're looking for requires support from translators,
   please
   add
   a new class to QtCore.
 
  Suppose there's such QLocale setting as described above, then it would
  be just a matter of some regexp inside the time formatting function
  which
  would add/remove the ap/AP strings for the clock. I imagine.

 How would that setting be set? Who would set it? Is that something that
 the
 clock app would use and allow the user to set?

 If so, why not extract the time format and show that to the user? Or, at
 least, parse it to set the default of Use 24-hour clock? If the user
 wants
 to toggle 24-hour, save the new time format in the config file and use it
 to
 format the time next time.


 I may have explained it poorly, so let me try again. tl;dr at the bottom :)

 I can put a checkbox to the Plasma panel clock which would either
 enable or disable 24h clock format. And in fact we do exactly that.
 If the user wants to see 24h clock format in the panel, he can check
 that checkbox. If he wants AM/PM clock, he can uncheck the checkbox.
 Simple as that.

 The implementation takes the Qt.locale().timeFormat(Locale.ShortFormat)
 (it's QML), checks for the 24h clock option and either adds AP
 or removes AP from the format string returned by Qt.locale().
 The actual clock on the panel is then printed using
 Qt.formatTime(currentTimeObject, thatModifiedTimeFormatString).

 Now, this will affect _only_ the Plasma panel clock. This will _not_
 affect Dolphin's time stamps, Gwenview's picture-taken times,
 this won't affect anything else but the panel clock and the panel clock
 alone. But if I want to have 24h clock format, I want it everywhere,
 in all apps, system-wide, not _only_ in the panel clock. Everything
 else will be however using time formatted by the LC_TIME locale
 default format.

 Currently each and every application would have to implement similar
 code as the Plasma panel clock - get the locale's time format string,
 check for some config, add/remove AP from the format string, print
 the time using QDateTime().toString(theModifiedTimeFormatString).
 Or each application would have to read the date/time format string
 from somewhere, some global config in order to have the same time
 format everywhere.

 Is it clear now? Do you see what I'm getting at?

 Setting different LC_TIME values proven to not be feasible, because
 very often users want just 24h clock format _and_ their locale's
 date format. Or some date format and their locale's time format.

 Ideally there would be a global setting, set from System Settings,
 perhaps written into ~/.config/QtProject.conf, which QLocale could
 internally read and return the time formatted according to that setting
 already. This would spare every single application doing it on its own.
 Then, calling QDateTime().toString() or QLocale().toString(QDateTime)
 would return the time formatted by user preference already and it would
 return it in all apps, uniformly, same format.

 I guess such feature might not be feasible for QLocale, hence my
 suggestion to bring back KLocale in a limited form, purely for global
 date/time formatting purposes around KDE apps, to have the same
 date/time format everywhere around.

 As a side note, missing global date/time format setting is a regression
 from the kde4 times.

 ---

 tl;dr - it'd be nice to be able to set a custom time format for all
 QDateTime/
 QLocale users without them needing to do anything at all.

 Hope it's clear now :)

 Cheers
 --
 Martin Klapetek | KDE Developer


What about non-Qt applications? I was thinking about this and actually it would
be a workaround for LC_ locales which are too limiting. Currently locale
can be in format language[_script][_country][.codeset][@modifier] which
represents country's standard but not user's preferences like use of 24h clock
instead of 12h.

Using @modifier for such user preferences could be one of solutions by
creating locale like en_US.UTF-8@24h and it would work for all applications
(note that currently QLocale ignores modifier) but what when need some other
preferences, it would become too complex as even currently locales like
de_DE@euro are used.

So better would be to introduce new variable LC_SETTINGS which would
contain a list of user preferences that override some aspects of locale and
user could use different settings than his country's locale as
currently only way
is to use different countries locale. But with such variable, user, for example,
could specify LC_SETTINGS=24h:euro and no matter which locale
(eg. even en_US) he would always get 24h clock with euro as currency. And
mostly only libc and Qt would need this change as applications which
use standard functions like strftime would work correctly as it would be done
automatically.

Re: Help wanted to evolve KDEs music players

[Dāvis Mosāns]

2015-08-04 15:49 GMT+03:00 Reindl Harald h.rei...@thelounge.net:


 Am 04.08.2015 um 14:25 schrieb Martin Sandsmark:

 On Tue, Aug 04, 2015 at 09:47:57PM +1000, Joseph Crowell wrote:

 Some of the codec dependencies are from non-free libraries with closed
 source code.


 Which codecs/libraries are you talking about?


 While other players utilize separate libraries and you can package them
 for
 download without crossing this precarious line, usually VLC has it's own
 bundled codec libraries.


 Please point me to any libraries that VLC bundles, I can't find any


 rpm -q --filesbypkg vlc-core  | grep \.so
 and that below is only a part


That's rubbish, you can't check it that way, of course it will be compiled
in a package... also probably all those libraries are open source.
Download VLC source tarball and you'll see there 0 compiled binaries.

As for licensing and patent issues distributions can (and probably do)
remove those parts and compile --without-something, issue solved.

Users who wish those features can replace their system package with their
own compiled one or just add missing plugins or whatever. (some Fedora
users use RPM Fusion repo for non-free packages)

About media player as advanced power user (media collection in several
TBs) I still haven't found any decent cross-platform media player, mostly
choice is between beautiful UI but lack of features (there are plenty of such
players) or somewhat feature full (VLC) but no good UI.

Creating any kind of backend is pointless as any missing features would be
better contributed to VLC, etc. so probably best would be just create a
frontend for LibVLC (there's even VLC-Qt, http://vlc-qt.tano.si/) and when
creating a frontend you could have multiple versions of it for different
usage patterns, like very simple basic one and other powerful feature full.

 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Re: Help wanted to evolve KDEs music players

[Dāvis Mosāns]

2015-08-04 22:45 GMT+03:00 Stefan Bruens stefan.bru...@rwth-aachen.de:
 On Tuesday 04 August 2015 19:29:27 Dāvis Mosāns wrote:
 2015-08-04 19:04 GMT+03:00 Thomas Lübking thomas.luebk...@gmail.com:
  On Dienstag, 4. August 2015 17:41:35 CEST, Martin Sandsmark wrote:
  since the free decoder apparently isn't available anymore
 
  http://www.oneplaydirect.com/oneplay/oneplay-mp3-decoder/
 
  Most stuff ain't for free, though (and unlike the mp3 thing, binary only),
  but still legal (even in the US)
 
  http://www.oneplaydirect.com/oneplay/oneplay-codec-pack/
 
  So the difference is that you can use gstreamer to legally playback all
  cool stuff (but of course everyone with a brain is going to use gst-ugly)
 LOL, from that oneplay mp3 page Issues to be aware of

  if you ship GStreamer with our binary MP3 plug-in, you need to be sure
  that
  you don't ship any GPL-licensed plug-ins that could end up being used
  together with the MP3 plug-in, as this would be a violation of the GPL.
  You also need to make sure you don't ship any GPL-licensed players which
  would use this plug-in.

 So basically even if you wanted to use it legally you can't use most of
 players as almost everything is GPL... of course you don't have to abide by
 it but then what was point of trying to do it legally as you can do it
 easier in other ways...

 Learn to read.

 If you *ship* GStreamer ...

 It is completely legal to *use* the binary Fluendo plugin with a GPLed player.


Nope, it's not legal (I'm not lawyer) but even if you don't distribute
you still violate
GPL as you can't mix GPL with GPL incompatible license. Only difference is that
no one will know that you violate GPL, same as pirating...

Look at http://www.gnu.org/licenses/gpl-faq.html#GPLInProprietarySystem
 I'd like to incorporate GPL-covered software in my proprietary system.
 I have no permission to use that software except what the GPL gives me.
 Can I do this?
 You cannot incorporate GPL-covered software in a proprietary system. The
 goal of the GPL is to grant everyone the freedom to copy, redistribute,
 understand, and modify a program. If you could incorporate GPL-covered
 software into a non-free system, it would have the effect of making the
 GPL-covered software non-free too.

 However, in many cases you can distribute the GPL-covered software
 alongside your proprietary system. To do this validly, you must make sure
 that the free and non-free programs communicate at arms length, that they
 are not combined in a way that would make them effectively a single program.

 The difference between this and “incorporating” the GPL-covered software is
 partly a matter of substance and partly form. The substantive part is this: 
 if the
 two programs are combined so that they become effectively two parts of one
 program, then you can't treat them as two separate programs. So the GPL has
 to cover the whole thing.

When GPL licensed media player is linked with GStreamer which dynamically loads
that non-free library, it all would become a single program covered by GPL and
it's not legally possible to do so because of incompatible license you are
violating that media player's GPL license because you weren't granted
a license for
it to use it with non-free code.


 And unfortunately you quoted only part of the text, and left out the other
 important part:
 
 Fortunately, most GStreamer plug-ins are LGPL, and many of the playback
 applications come with licensing terms that allow them to be used with non-
 free plug-ins. The Totem media player and the Banshee music player are two
 examples.
 


most? *citation needed*, also I was talking only about GPL'd players.

 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Re: Help wanted to evolve KDEs music players

[Dāvis Mosāns]

2015-08-04 19:04 GMT+03:00 Thomas Lübking thomas.luebk...@gmail.com:
 On Dienstag, 4. August 2015 17:41:35 CEST, Martin Sandsmark wrote:

 since the free decoder apparently isn't available anymore


 http://www.oneplaydirect.com/oneplay/oneplay-mp3-decoder/

 Most stuff ain't for free, though (and unlike the mp3 thing, binary only),
 but still legal (even in the US)

 http://www.oneplaydirect.com/oneplay/oneplay-codec-pack/

 So the difference is that you can use gstreamer to legally playback all cool
 stuff (but of course everyone with a brain is going to use gst-ugly)



LOL, from that oneplay mp3 page Issues to be aware of
 if you ship GStreamer with our binary MP3 plug-in, you need to be sure that
 you don't ship any GPL-licensed plug-ins that could end up being used
 together with the MP3 plug-in, as this would be a violation of the GPL.
 You also need to make sure you don't ship any GPL-licensed players which
 would use this plug-in.

So basically even if you wanted to use it legally you can't use most of players
as almost everything is GPL... of course you don't have to abide by it but then
what was point of trying to do it legally as you can do it easier in
other ways...

 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Re: Help wanted to evolve KDEs music players

[Dāvis Mosāns]

2015-08-04 20:13 GMT+03:00 Martin Sandsmark martin.sandsm...@kde.org:
 On Tue, Aug 04, 2015 at 07:29:27PM +0300, Dāvis Mosāns wrote:
 So basically even if you wanted to use it legally you can't use most of 
 players
 as almost everything is GPL... of course you don't have to abide by it but 
 then
 what was point of trying to do it legally as you can do it easier in
 other ways...

 Yes, this is kind of what makes it so absurd for me.

 The reason we can't use LGPLed libvlc in free software is because there is no
 company selling unfree modules for it.

 I do understand the reasoning though, and even if I don't agree with it, the
 policy seems to be set in stone in Fedora et al. So I don't see any reason to
 argue or try to convince anyone.


Well, actually you can use, just have to ignore Fedora (and maybe some other
distros), users can always get packages themselves like many do.
VLC is widely used and it seems silly that only reason for not using
libvlc would
be because some distros don't ship it and thus preventing it even for
other distro
users.

 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Re: Review Request 124542: CMake fixes for Windows build

[Dāvis Mosāns]

On Aug. 2, 2015, 12:35 a.m., Kevin Funk wrote:
  Looking back at the review which introduced the escaping, namely 
  https://git.reviewboard.kde.org/r/120648/ , I escaped the comma as well in 
  the first review. I don't remember why I removed them. Apart from that 
  usage, comma are invalid characters in NTFS (according 
  https://kb.acronis.com/content/39790) so we shouldn't hit them; they could 
  work on ext[234]/xfs/whatever but I think that libxml2 could handle them. 
  The only thing I would like to test (and if you volunteer for that I 
  wouldn't complain :) is a test where the path to the DTD does contain a 
  comma, to be sure that not escaping it does work on Linux. Or we could just 
  call it as don't do that and forget about it :)

Comma is not invalid character for NTFS, maybe you meant colon :?
Anyway in either case NTFS have 2 file namespaces, one is Win32 where invalid 
characters are

 * NUL
 * / (slash)
 * \ (backslash)
 * : (colon)
 * * (asterisk)
 * ? (Question mark)
 *  (quote)
 *  (less than)
 *  (greater than)
 * | (pipe)

and other is POSIX namespace where all Unicode code points are valid except NUL 
and / (slash).
On Linux, NTFS-3G by default will create all files in POSIX namespace thus it 
will allow creating filename with colon : and other illegal characters in 
NTFS.
And on Windows if you use WinAPI directly you can also create such filenames in 
POSIX namespace.

As for which characters to escape in URI, see 
https://url.spec.whatwg.org/#url-code-points and also RFCs 1738, 2396, 3986. 
Both comma and colon is allowed in URI so seems bug is somewhere else and this 
is just a workaround.


- Dāvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124542/#review83305
---


On Aug. 1, 2015, 12:40 p.m., Kevin Funk wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124542/
 ---
 
 (Updated Aug. 1, 2015, 12:40 p.m.)
 
 
 Review request for Documentation, KDE Frameworks and Luigi Toscano.
 
 
 Bugs: 348061
 https://bugs.kde.org/show_bug.cgi?id=348061
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 BUG: 348061
 
 
 Diffs
 -
 
   cmake/uriencode.cmake e5f3c3acd93d3871e44b6e6fb29ad7113e18d751 
 
 Diff: https://git.reviewboard.kde.org/r/124542/diff/
 
 
 Testing
 ---
 
 Adding ':' to the list of escaped characters is probably not an ideal 
 solution, but let me hear your ideas.
 
 
 Thanks,
 
 Kevin Funk
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124443: Don't try to put document without data

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124443/
---

(Updated July 28, 2015, 2:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo.


Changes
---

Submitted with commit f20e386c3cb4233078489213f8ca892e43769c08 by D?vis Mos?ns 
to branch master.


Repository: baloo


Description
---

When file's data extractor fails or skips for whatever reason then doc.m_data 
will be empty
causing assert so just skip it.

ASSERT: !url.isEmpty() in file 
/mnt/KDE/kde/workspace/baloo/src/engine/documentdatadb.cpp, line 60


Diffs
-

  src/engine/writetransaction.cpp a5936b8cbfdd64ddc10b24f283358aca308c1131 

Diff: https://git.reviewboard.kde.org/r/124443/diff/


Testing
---

Doesn't cause assert anymore.


Thanks,

Dāvis Mosāns


 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Re: Review Request 124439: Add missing 'continue' for balooctl

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124439/
---

(Updated July 28, 2015, 2:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and Vishesh Handa.


Changes
---

Submitted with commit 1da4085b138f7133f373991340e5fdaf948088a2 by D?vis Mos?ns 
to branch master.


Repository: baloo


Description
---

Currently it would say it's skiping file because it's already indexed, but 
actually it wouldn't skip and raise assert

$ balooctl index file.txt
Skipping: file.txt Reason: Already indexed
Indexing file.txt
ASSERT: !url.isEmpty() in file 
/mnt/KDE/kde/workspace/baloo/src/engine/documentdatadb.cpp, line 60


Diffs
-

  src/tools/balooctl/main.cpp e8f29b21e0100508f39ba5a6a45536979803f144 

Diff: https://git.reviewboard.kde.org/r/124439/diff/


Testing
---

Verified that now it skips file and don't cause assert.


Thanks,

Dāvis Mosāns


 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Re: Review Request 124443: Don't try to put document without data

[Dāvis Mosāns]

 On jūlijs 27, 2015, 4:35 p.m., Vishesh Handa wrote:
  Sorry about taking so long to respond. Please ping me (hangouts/irc) next 
  time if I'm taking too long.

No worries, see also my other RR #124439


- Dāvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124443/#review83049
---


On jūlijs 27, 2015, 6:16 p.m., Dāvis Mosāns wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124443/
 ---
 
 (Updated jūlijs 27, 2015, 6:16 p.m.)
 
 
 Review request for Baloo.
 
 
 Repository: baloo
 
 
 Description
 ---
 
 When file's data extractor fails or skips for whatever reason then doc.m_data 
 will be empty
 causing assert so just skip it.
 
 ASSERT: !url.isEmpty() in file 
 /mnt/KDE/kde/workspace/baloo/src/engine/documentdatadb.cpp, line 60
 
 
 Diffs
 -
 
   src/engine/writetransaction.cpp a5936b8cbfdd64ddc10b24f283358aca308c1131 
 
 Diff: https://git.reviewboard.kde.org/r/124443/diff/
 
 
 Testing
 ---
 
 Doesn't cause assert anymore.
 
 
 Thanks,
 
 Dāvis Mosāns
 



 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Re: Review Request 124443: Don't try to put document without data

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124443/
---

(Updated jūlijs 27, 2015, 6:16 p.m.)


Review request for Baloo.


Changes
---

Remove value if empty


Repository: baloo


Description
---

When file's data extractor fails or skips for whatever reason then doc.m_data 
will be empty
causing assert so just skip it.

ASSERT: !url.isEmpty() in file 
/mnt/KDE/kde/workspace/baloo/src/engine/documentdatadb.cpp, line 60


Diffs (updated)
-

  src/engine/writetransaction.cpp a5936b8cbfdd64ddc10b24f283358aca308c1131 

Diff: https://git.reviewboard.kde.org/r/124443/diff/


Testing
---

Doesn't cause assert anymore.


Thanks,

Dāvis Mosāns


 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Re: Review Request 124439: Add missing 'continue' for balooctl

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124439/
---

(Updated jūlijs 24, 2015, 2 p.m.)


Review request for Baloo.


Changes
---

also add 'endl'


Repository: baloo


Description
---

Currently it would say it's skiping file because it's already indexed, but 
actually it wouldn't skip and raise assert

$ balooctl index file.txt
Skipping: file.txt Reason: Already indexed
Indexing file.txt
ASSERT: !url.isEmpty() in file 
/mnt/KDE/kde/workspace/baloo/src/engine/documentdatadb.cpp, line 60


Diffs (updated)
-

  src/tools/balooctl/main.cpp e8f29b21e0100508f39ba5a6a45536979803f144 

Diff: https://git.reviewboard.kde.org/r/124439/diff/


Testing
---

Verified that now it skips file and don't cause assert.


Thanks,

Dāvis Mosāns


 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Review Request 124443: Don't try to put document without data

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124443/
---

Review request for Baloo.


Repository: baloo


Description
---

When file's data extractor fails or skips for whatever reason then doc.m_data 
will be empty
causing assert so just skip it.

ASSERT: !url.isEmpty() in file 
/mnt/KDE/kde/workspace/baloo/src/engine/documentdatadb.cpp, line 60


Diffs
-

  src/engine/writetransaction.cpp a5936b8cbfdd64ddc10b24f283358aca308c1131 

Diff: https://git.reviewboard.kde.org/r/124443/diff/


Testing
---

Doesn't cause assert anymore.


Thanks,

Dāvis Mosāns


 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Review Request 124439: Add missing 'continue' for balooctl

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124439/
---

Review request for Baloo.


Repository: baloo


Description
---

Currently it would say it's skiping file because it's already indexed, but 
actually it wouldn't skip and raise assert

$ balooctl index file.txt
Skipping: file.txt Reason: Already indexed
Indexing file.txt
ASSERT: !url.isEmpty() in file 
/mnt/KDE/kde/workspace/baloo/src/engine/documentdatadb.cpp, line 60


Diffs
-

  src/tools/balooctl/main.cpp e8f29b21e0100508f39ba5a6a45536979803f144 

Diff: https://git.reviewboard.kde.org/r/124439/diff/


Testing
---

Verified that now it skips file and don't cause assert.


Thanks,

Dāvis Mosāns


 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 

Re: Review Request 124414: Fix kbuildsycoca5 --global

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124414/
---

(Updated jūlijs 22, 2015, 6:04 p.m.)


Review request for KDE Frameworks.


Repository: kservice


Description
---

Currently kbuildsycoca5 --global does crash because Qt uses XDG_DATA_HOME as 
first choice for GenericDataLocation
and with --global it's set to - which is invalid path. kbuildsycoca5 
attempts to create -/kservices5/ksycoca5 which raises ASSERT failure in 
KConfig.

ASSERT: QDir::isAbsolutePath(file) in file 
/mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line 597

#5  0x7f6128c3c528 in raise () from /usr/lib/libc.so.6
#6  0x7f6128c3d93a in abort () from /usr/lib/libc.so.6
#7  0x7f61293c74a9 in qt_message_fatal (context=..., message=synthetic 
pointer) at global/qlogging.cpp:1578
#8  QMessageLogger::fatal (this=this@entry=0x7ffc2f4d2250, 
msg=msg@entry=0x7f61296345f0 ASSERT: \%s\ in file %s, line %d) at 
global/qlogging.cpp:781
#9  0x7f61293c05bc in qt_assert 
(assertion=assertion@entry=0x7f6129cbfea8 QDir::isAbsolutePath(file), 
file=file@entry=0x7f6129cbfdf0 
/mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, 
line=line@entry=597) at global/qglobal.cpp:2968
#10 0x7f6129ca299f in KConfigIniBackend::setFilePath (this=0x1ecb360, 
file=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp:597
#11 0x7f6129c8bc5b in KConfigPrivate::changeFileName (this=0x1ed5af0, 
name=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfig.cpp:609
#12 0x7f6129ca9a2e in KDesktopFile::KDesktopFile (this=0x7ffc2f4d23e0, 
resourceType=QStandardPaths::GenericDataLocation, fileName=...) at 
/mnt/AUR/kconfig-git/src/kconfig/src/core/kdesktopfile.cpp:54
#13 0x004214e1 in KBuildServiceFactory::createEntry 
(this=optimized out, file=...) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildservicefactory.cpp:102
#14 0x00415358 in KBuildSycoca::createEntry 
(this=this@entry=0x1eb0950, file=..., addToFactory=addToFactory@entry=true) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:153
#15 0x00416d21 in KBuildSycoca::build (this=this@entry=0x1eb0950) 
at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:273
#16 0x0041755d in KBuildSycoca::recreate 
(this=this@entry=0x1eb0950) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:419
#17 0x00411636 in main (argc=3, argv=optimized out) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:802


Diffs (updated)
-

  src/kbuildsycoca/kbuildsycoca.cpp 074a7d830f7d3781960e64c16f721fae9edc26f9 

Diff: https://git.reviewboard.kde.org/r/124414/diff/


Testing
---

Seems to be working, atleast doesn't crash anymore.


Thanks,

Dāvis Mosāns

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124414: Fix kbuildsycoca5 --global

[Dāvis Mosāns]

 On jūlijs 22, 2015, 11:47 a.m., David Faure wrote:
  Why not shortcut that - hack altogether, and set XDG_DATA_HOME to the 
  second entry in standardLocations(GenericDataLocation)?
  
  In any case, I don't think --global leads to something useful, but sure, 
  fix the assert ;)
 
 Dāvis Mosāns wrote:
 This fix doesn't rely on Qt internals so that if something changes on Qt 
 side it will still work.
 But if we'll always replace XDG_DATA_HOME with 2nd entry from 
 GenericDataLocation and then Qt changes ordering it might not work (like 
 XDG_DATA_HOME could be 2nd entry).
 
 Also it's not said that Qt won't change ~/.local/share to something 
 else so this ? alternative isn't Qt change proof either.
 
   QStringList paths = 
 QStandardPaths::standardLocations(QStandardPaths::GenericDataLocation);
   for (auto it = paths.constBegin(); it != paths.constEnd(); ++it) {
   if (!it-endsWith(/.local/share)) {
   qputenv(XDG_DATA_HOME, it-toLocal8Bit());
   break;
   }
   }
 
 David Faure wrote:
 Well, this fix does rely on XDG_DATA_HOME having any influence at all on 
 what QStandardPaths returns :-)
 (which is why it won't work on e.g. Windows, but that's a separate story)
 
 If someone adds caching into QStandardPaths, for instance, then the 
 qputenv of - will have no effect anymore, while my suggestion would still 
 work.
 
 Qt can't change the ordering, it's XDG-mandated. Even Qt adding a more 
 local path would be a big problem, since XDG says we should save into 
 XDG_DATA_HOME, not somewhere else.
 
 And ~/.local/share is also part of the XDG spec (but this suggested 
 endsWith() is fragile, could match unwanted paths).
 
 Overall I stand by what I said previously.

Ok, updated to just set 2nd entry.


- Dāvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124414/#review82800
---


On jūlijs 22, 2015, 6:04 p.m., Dāvis Mosāns wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124414/
 ---
 
 (Updated jūlijs 22, 2015, 6:04 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kservice
 
 
 Description
 ---
 
 Currently kbuildsycoca5 --global does crash because Qt uses XDG_DATA_HOME 
 as first choice for GenericDataLocation
 and with --global it's set to - which is invalid path. kbuildsycoca5 
 attempts to create -/kservices5/ksycoca5 which raises ASSERT failure in 
 KConfig.
 
 ASSERT: QDir::isAbsolutePath(file) in file 
 /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line 597
 
 #5  0x7f6128c3c528 in raise () from /usr/lib/libc.so.6
 #6  0x7f6128c3d93a in abort () from /usr/lib/libc.so.6
 #7  0x7f61293c74a9 in qt_message_fatal (context=..., 
 message=synthetic pointer) at global/qlogging.cpp:1578
 #8  QMessageLogger::fatal (this=this@entry=0x7ffc2f4d2250, 
 msg=msg@entry=0x7f61296345f0 ASSERT: \%s\ in file %s, line %d) at 
 global/qlogging.cpp:781
 #9  0x7f61293c05bc in qt_assert 
 (assertion=assertion@entry=0x7f6129cbfea8 QDir::isAbsolutePath(file), 
 file=file@entry=0x7f6129cbfdf0 
 /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, 
 line=line@entry=597) at global/qglobal.cpp:2968
 #10 0x7f6129ca299f in KConfigIniBackend::setFilePath (this=0x1ecb360, 
 file=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp:597
 #11 0x7f6129c8bc5b in KConfigPrivate::changeFileName (this=0x1ed5af0, 
 name=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfig.cpp:609
 #12 0x7f6129ca9a2e in KDesktopFile::KDesktopFile 
 (this=0x7ffc2f4d23e0, resourceType=QStandardPaths::GenericDataLocation, 
 fileName=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kdesktopfile.cpp:54
 #13 0x004214e1 in KBuildServiceFactory::createEntry 
 (this=optimized out, file=...) at 
 /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildservicefactory.cpp:102
 #14 0x00415358 in KBuildSycoca::createEntry 
 (this=this@entry=0x1eb0950, file=..., addToFactory=addToFactory@entry=true) 
 at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:153
 #15 0x00416d21 in KBuildSycoca::build (this=this@entry=0x1eb0950) 
 at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:273
 #16 0x0041755d in KBuildSycoca::recreate 
 (this=this@entry=0x1eb0950) at 
 /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:419
 #17 0x00411636 in main (argc=3, argv=optimized out) at 
 /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:802
 
 
 Diffs
 -
 
   src/kbuildsycoca/kbuildsycoca.cpp

Re: Review Request 124414: Fix kbuildsycoca5 --global

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124414/
---

(Updated July 22, 2015, 6:01 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 4c25a027a93171787ce075f177ca5840da57a496 by D?vis Mos?ns 
to branch fix_path.


Repository: kservice


Description
---

Currently kbuildsycoca5 --global does crash because Qt uses XDG_DATA_HOME as 
first choice for GenericDataLocation
and with --global it's set to - which is invalid path. kbuildsycoca5 
attempts to create -/kservices5/ksycoca5 which raises ASSERT failure in 
KConfig.

ASSERT: QDir::isAbsolutePath(file) in file 
/mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line 597

#5  0x7f6128c3c528 in raise () from /usr/lib/libc.so.6
#6  0x7f6128c3d93a in abort () from /usr/lib/libc.so.6
#7  0x7f61293c74a9 in qt_message_fatal (context=..., message=synthetic 
pointer) at global/qlogging.cpp:1578
#8  QMessageLogger::fatal (this=this@entry=0x7ffc2f4d2250, 
msg=msg@entry=0x7f61296345f0 ASSERT: \%s\ in file %s, line %d) at 
global/qlogging.cpp:781
#9  0x7f61293c05bc in qt_assert 
(assertion=assertion@entry=0x7f6129cbfea8 QDir::isAbsolutePath(file), 
file=file@entry=0x7f6129cbfdf0 
/mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, 
line=line@entry=597) at global/qglobal.cpp:2968
#10 0x7f6129ca299f in KConfigIniBackend::setFilePath (this=0x1ecb360, 
file=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp:597
#11 0x7f6129c8bc5b in KConfigPrivate::changeFileName (this=0x1ed5af0, 
name=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfig.cpp:609
#12 0x7f6129ca9a2e in KDesktopFile::KDesktopFile (this=0x7ffc2f4d23e0, 
resourceType=QStandardPaths::GenericDataLocation, fileName=...) at 
/mnt/AUR/kconfig-git/src/kconfig/src/core/kdesktopfile.cpp:54
#13 0x004214e1 in KBuildServiceFactory::createEntry 
(this=optimized out, file=...) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildservicefactory.cpp:102
#14 0x00415358 in KBuildSycoca::createEntry 
(this=this@entry=0x1eb0950, file=..., addToFactory=addToFactory@entry=true) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:153
#15 0x00416d21 in KBuildSycoca::build (this=this@entry=0x1eb0950) 
at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:273
#16 0x0041755d in KBuildSycoca::recreate 
(this=this@entry=0x1eb0950) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:419
#17 0x00411636 in main (argc=3, argv=optimized out) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:802


Diffs
-

  src/kbuildsycoca/kbuildsycoca.cpp 074a7d830f7d3781960e64c16f721fae9edc26f9 

Diff: https://git.reviewboard.kde.org/r/124414/diff/


Testing
---

Seems to be working, atleast doesn't crash anymore.


Thanks,

Dāvis Mosāns

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124414: Fix kbuildsycoca5 --global

[Dāvis Mosāns]

 On jūlijs 22, 2015, 11:47 a.m., David Faure wrote:
  Why not shortcut that - hack altogether, and set XDG_DATA_HOME to the 
  second entry in standardLocations(GenericDataLocation)?
  
  In any case, I don't think --global leads to something useful, but sure, 
  fix the assert ;)

This fix doesn't rely on Qt internals so that if something changes on Qt side 
it will still work.
But if we'll always replace XDG_DATA_HOME with 2nd entry from 
GenericDataLocation and then Qt changes ordering it might not work (like 
XDG_DATA_HOME could be 2nd entry).

Also it's not said that Qt won't change ~/.local/share to something else so 
this ? alternative isn't Qt change proof either.

  QStringList paths = 
QStandardPaths::standardLocations(QStandardPaths::GenericDataLocation);
  for (auto it = paths.constBegin(); it != paths.constEnd(); ++it) {
  if (!it-endsWith(/.local/share)) {
  qputenv(XDG_DATA_HOME, it-toLocal8Bit());
  break;
  }
  }


- Dāvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124414/#review82800
---


On jūlijs 21, 2015, 11:51 p.m., Dāvis Mosāns wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124414/
 ---
 
 (Updated jūlijs 21, 2015, 11:51 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kservice
 
 
 Description
 ---
 
 Currently kbuildsycoca5 --global does crash because Qt uses XDG_DATA_HOME 
 as first choice for GenericDataLocation
 and with --global it's set to - which is invalid path. kbuildsycoca5 
 attempts to create -/kservices5/ksycoca5 which raises ASSERT failure in 
 KConfig.
 
 ASSERT: QDir::isAbsolutePath(file) in file 
 /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line 597
 
 #5  0x7f6128c3c528 in raise () from /usr/lib/libc.so.6
 #6  0x7f6128c3d93a in abort () from /usr/lib/libc.so.6
 #7  0x7f61293c74a9 in qt_message_fatal (context=..., 
 message=synthetic pointer) at global/qlogging.cpp:1578
 #8  QMessageLogger::fatal (this=this@entry=0x7ffc2f4d2250, 
 msg=msg@entry=0x7f61296345f0 ASSERT: \%s\ in file %s, line %d) at 
 global/qlogging.cpp:781
 #9  0x7f61293c05bc in qt_assert 
 (assertion=assertion@entry=0x7f6129cbfea8 QDir::isAbsolutePath(file), 
 file=file@entry=0x7f6129cbfdf0 
 /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, 
 line=line@entry=597) at global/qglobal.cpp:2968
 #10 0x7f6129ca299f in KConfigIniBackend::setFilePath (this=0x1ecb360, 
 file=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp:597
 #11 0x7f6129c8bc5b in KConfigPrivate::changeFileName (this=0x1ed5af0, 
 name=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfig.cpp:609
 #12 0x7f6129ca9a2e in KDesktopFile::KDesktopFile 
 (this=0x7ffc2f4d23e0, resourceType=QStandardPaths::GenericDataLocation, 
 fileName=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kdesktopfile.cpp:54
 #13 0x004214e1 in KBuildServiceFactory::createEntry 
 (this=optimized out, file=...) at 
 /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildservicefactory.cpp:102
 #14 0x00415358 in KBuildSycoca::createEntry 
 (this=this@entry=0x1eb0950, file=..., addToFactory=addToFactory@entry=true) 
 at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:153
 #15 0x00416d21 in KBuildSycoca::build (this=this@entry=0x1eb0950) 
 at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:273
 #16 0x0041755d in KBuildSycoca::recreate 
 (this=this@entry=0x1eb0950) at 
 /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:419
 #17 0x00411636 in main (argc=3, argv=optimized out) at 
 /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:802
 
 
 Diffs
 -
 
   src/kbuildsycoca/kbuildsycoca.cpp 074a7d830f7d3781960e64c16f721fae9edc26f9 
 
 Diff: https://git.reviewboard.kde.org/r/124414/diff/
 
 
 Testing
 ---
 
 Seems to be working, atleast doesn't crash anymore.
 
 
 Thanks,
 
 Dāvis Mosāns
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 124414: Fix kbuildsycoca5 --global

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124414/
---

Review request for KDE Frameworks.


Repository: kservice


Description
---

Currently kbuildsycoca5 --global does crash because Qt uses XDG_DATA_HOME as 
first choice for GenericDataLocation
and with --global it's set to - which is invalid path. kbuildsycoca5 
attempts to create -/kservices5/ksycoca5 which raises ASSERT failure in 
KConfig.

ASSERT: QDir::isAbsolutePath(file) in file 
/mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line 597

#5  0x7f6128c3c528 in raise () from /usr/lib/libc.so.6
#6  0x7f6128c3d93a in abort () from /usr/lib/libc.so.6
#7  0x7f61293c74a9 in qt_message_fatal (context=..., message=synthetic 
pointer) at global/qlogging.cpp:1578
#8  QMessageLogger::fatal (this=this@entry=0x7ffc2f4d2250, 
msg=msg@entry=0x7f61296345f0 ASSERT: \%s\ in file %s, line %d) at 
global/qlogging.cpp:781
#9  0x7f61293c05bc in qt_assert 
(assertion=assertion@entry=0x7f6129cbfea8 QDir::isAbsolutePath(file), 
file=file@entry=0x7f6129cbfdf0 
/mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, 
line=line@entry=597) at global/qglobal.cpp:2968
#10 0x7f6129ca299f in KConfigIniBackend::setFilePath (this=0x1ecb360, 
file=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp:597
#11 0x7f6129c8bc5b in KConfigPrivate::changeFileName (this=0x1ed5af0, 
name=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfig.cpp:609
#12 0x7f6129ca9a2e in KDesktopFile::KDesktopFile (this=0x7ffc2f4d23e0, 
resourceType=QStandardPaths::GenericDataLocation, fileName=...) at 
/mnt/AUR/kconfig-git/src/kconfig/src/core/kdesktopfile.cpp:54
#13 0x004214e1 in KBuildServiceFactory::createEntry 
(this=optimized out, file=...) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildservicefactory.cpp:102
#14 0x00415358 in KBuildSycoca::createEntry 
(this=this@entry=0x1eb0950, file=..., addToFactory=addToFactory@entry=true) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:153
#15 0x00416d21 in KBuildSycoca::build (this=this@entry=0x1eb0950) 
at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:273
#16 0x0041755d in KBuildSycoca::recreate 
(this=this@entry=0x1eb0950) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:419
#17 0x00411636 in main (argc=3, argv=optimized out) at 
/mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:802


Diffs
-

  src/kbuildsycoca/kbuildsycoca.cpp 074a7d830f7d3781960e64c16f721fae9edc26f9 

Diff: https://git.reviewboard.kde.org/r/124414/diff/


Testing
---

Seems to be working, atleast doesn't crash anymore.


Thanks,

Dāvis Mosāns

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124414: Fix kbuildsycoca5 --global

[Dāvis Mosāns]

 On jūlijs 22, 2015, 2:20 a.m., Aleix Pol Gonzalez wrote:
  src/kbuildsycoca/kbuildsycoca.cpp, line 686
  https://git.reviewboard.kde.org/r/124414/diff/1/?file=386602#file386602line686
 
  Would it work by using `qunsetenv`?
  
  It looks like XDG_DATA_HOME is just being invalidated here.

Nope, it doesn't, if it's removed with qunsetenv or set empty  then Qt will 
use ~/.local/share


- Dāvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124414/#review82795
---


On jūlijs 21, 2015, 11:51 p.m., Dāvis Mosāns wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124414/
 ---
 
 (Updated jūlijs 21, 2015, 11:51 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kservice
 
 
 Description
 ---
 
 Currently kbuildsycoca5 --global does crash because Qt uses XDG_DATA_HOME 
 as first choice for GenericDataLocation
 and with --global it's set to - which is invalid path. kbuildsycoca5 
 attempts to create -/kservices5/ksycoca5 which raises ASSERT failure in 
 KConfig.
 
 ASSERT: QDir::isAbsolutePath(file) in file 
 /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line 597
 
 #5  0x7f6128c3c528 in raise () from /usr/lib/libc.so.6
 #6  0x7f6128c3d93a in abort () from /usr/lib/libc.so.6
 #7  0x7f61293c74a9 in qt_message_fatal (context=..., 
 message=synthetic pointer) at global/qlogging.cpp:1578
 #8  QMessageLogger::fatal (this=this@entry=0x7ffc2f4d2250, 
 msg=msg@entry=0x7f61296345f0 ASSERT: \%s\ in file %s, line %d) at 
 global/qlogging.cpp:781
 #9  0x7f61293c05bc in qt_assert 
 (assertion=assertion@entry=0x7f6129cbfea8 QDir::isAbsolutePath(file), 
 file=file@entry=0x7f6129cbfdf0 
 /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, 
 line=line@entry=597) at global/qglobal.cpp:2968
 #10 0x7f6129ca299f in KConfigIniBackend::setFilePath (this=0x1ecb360, 
 file=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp:597
 #11 0x7f6129c8bc5b in KConfigPrivate::changeFileName (this=0x1ed5af0, 
 name=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfig.cpp:609
 #12 0x7f6129ca9a2e in KDesktopFile::KDesktopFile 
 (this=0x7ffc2f4d23e0, resourceType=QStandardPaths::GenericDataLocation, 
 fileName=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kdesktopfile.cpp:54
 #13 0x004214e1 in KBuildServiceFactory::createEntry 
 (this=optimized out, file=...) at 
 /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildservicefactory.cpp:102
 #14 0x00415358 in KBuildSycoca::createEntry 
 (this=this@entry=0x1eb0950, file=..., addToFactory=addToFactory@entry=true) 
 at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:153
 #15 0x00416d21 in KBuildSycoca::build (this=this@entry=0x1eb0950) 
 at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:273
 #16 0x0041755d in KBuildSycoca::recreate 
 (this=this@entry=0x1eb0950) at 
 /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:419
 #17 0x00411636 in main (argc=3, argv=optimized out) at 
 /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:802
 
 
 Diffs
 -
 
   src/kbuildsycoca/kbuildsycoca.cpp 074a7d830f7d3781960e64c16f721fae9edc26f9 
 
 Diff: https://git.reviewboard.kde.org/r/124414/diff/
 
 
 Testing
 ---
 
 Seems to be working, atleast doesn't crash anymore.
 
 
 Thanks,
 
 Dāvis Mosāns
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel