[Differential] [Changed Subscribers] D4201: Make it possible to lower KCrash to tier 1
shumski added inline comments.
INLINE COMMENTS
> config-kcrash.h.cmake:7
> +
> +#cmakedefine KCRASH_PLUGIN_INSTALL_DIR "${KCRASH_PLUGIN_INSTALL_DIR}"
CMAKE_INSTALL_FULL_PLUGINDIR/kcrashhandlers
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D4201
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #frameworks, dfaure
Cc: shumski, anthonyfieroni, graesslin
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > Fear I am still missing what you mean. So let's go explicitely, here is what > I understand to happen: > > There are six different cases when using this macro and on the first > invocation of cmake, from the combinations of installing to a different > prefix or the same prefix as Qt (2 variants) versus > KDE_INSTALL_USE_QT_SYS_PATHS being not set/defined, set to ON, set to OFF (3 > variants). > > In these 3 cases plugins, QCH & Co. will be all installed to Qt system dirs > and thus automatically picked up by Qt, without the need for further env var > settings: > > - -DKDE_INSTALL_USE_QT_SYS_PATHS=ON, different prefix > - -DKDE_INSTALL_USE_QT_SYS_PATHS=ON, same prefix > - KDE_INSTALL_USE_QT_SYS_PATHS not passed as argument, same prefix (so > > In the three other cases plugins, QCH & Co will be installed in dirs and need > further env var settings, for Qt (and Qt Assistant) to also pick up the stuff. > > Where do we see things differently? And just to make sure, you have seen the > right lines at the link I passed before, how > _default_KDE_INSTALL_USE_QT_SYS_PATHS is set to ON if the same prefix is used? Hm, i guess i haven't checked KDEInstallDirs in a while. Somehow i remember KDE_INSTALL_USE_QT_SYS_PATHS was only activated by default if CMAKE_INSTALL_PREFIX was /usr. Ok, so the non-recognition part should not happen that often -> I'm assuming qch files are looked up as QLibraryInfo::DocumentationPath (so, QT_INSTALL_DOCS) + *qch. So with your path, they will not be found (yeah with different prefix they aren0t still found, but with qch/ subdir user needs one additional envar for KF5 qch's - imagine you need to export QT_PLUGIN_PATH for Qt plugins, and one more path for KF5 plugins). I don't see a reason to append qch subdir to installation location -> as if you're intentionally hiding those files ;-) REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > But isn't this free recognition happening via KDE_INSTALL_USE_QT_SYS_PATHS as > well? > At least this is how I understand > https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDEInstallDirs.cmake#n442 > to work. > This is also what I rely on, as I agree that it should also happen when > installing to the same prefix :) It is :) But with this latest revision it is not when that var is off =) I'm saying that for both cases it should happen. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > Not sure what you mean, please point out the issue you see here with more > details :) > > The plan here is: > if KDE_INSTALL_USE_QT_SYS_PATHS is set, install QCH files to QT_INSTALL_DOCS, > if not, some "normal" dir (there is no standard dir for QCH in general > currently, everybody installs their 3rd-party QCH files somewhere). > See thread > http://lists.qt-project.org/pipermail/development/2016-November/027856.html > and especially the latest > http://lists.qt-project.org/pipermail/development/2016-November/028001.html > Feedback is very welcome. I mean, addition of qch subdir is 'your' invention here. If Frameworks were to use only qmake build-system, i'm sure qch files would end up in QT_INSTALL_DOCS directory. I.e. for KDE_INSTALL_USE_QT_SYS_PATHS=ON the paths are Qt's, so are with KDE_INSTALL_USE_QT_SYS_PATHS=OFF, just that for the latter case they are read from sources, opposed to querying qmake. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
shumski added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:534 > +else() > +_define_relative(QTQCHDIR DATAROOTDIR "doc/QCH" > +"documentation bundles in QCH format for Qt-extending libraries") I think e.g. QMLDIR, PLUGINDIR, ECM_MKSPECS_INSTALL_DIR, etc. are vanilla Qt's. QCH files are thus installed straight into QT_INSTALL_DOCS dir AFAICS ... REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
shumski added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:82 > Imagine another project with a lib MyLib linking against KJobWidgets (in the > public interface). For MyLib also a QCH file should be created. To create > proper links from the QCH file for MyLib into the QCH file of KJobWidgets > (via qthelp:// urls), doxygen/the qt tools need to have access to some > information. This information is bound to the KF5JobWidgets_QCH target (see > https://phabricator.kde.org/D2854). > By exporting the target here and including it into KF5JobWidgetsConfig.cmake, > this information then is automatically available to the ecm_add_qch call with > MyLib and passing just the target name in the LINK_QCH argument. Allright, make sense. REVISION DETAIL https://phabricator.kde.org/D3439 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud Cc: shumski
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
shumski added a comment. > a) recommended install path for qch and tag files? At least when KDE_INSTALL_USE_QT_SYS_PATHS is TRUE, one could use QT_INSTALL_DOCS (via ECMQueryQmake) var. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Changed Subscribers] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
shumski added inline comments.
INLINE COMMENTS
> CMakeLists.txt:82
>
> +ecm_install_qch_export(
> +TARGETS KF5JobWidgets_QCH
I wonder about the reasoning behind the existence of this export, and
installation of it...
> CMakeLists.txt:98
> +TAGFILE_INSTALL_DESTINATION ${KDE_INSTALL_FULL_DATADIR}/qch
> +QCH_INSTALL_DESTINATION ${KDE_INSTALL_FULL_DATADIR}/qch
> +)
Is this really the right place?
REVISION DETAIL
https://phabricator.kde.org/D3439
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, #frameworks, ochurlaud
Cc: shumski
Re: Review Request 129260: Add find module for QtPlatformSupport
> On Oct. 25, 2016, 1:31 p.m., Hrvoje Senjan wrote:
> > find-modules/FindQt5PlatformSupport.cmake, line 75
> > <https://git.reviewboard.kde.org/r/129260/diff/1/?file=482953#file482953line75>
> >
> > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and
> > ${PKG_Qt5PlatformSupport_INCLUDEDIR}/QtPlatformSupport/ be marked as
> > Qt5PlatformSupport_INCLUDE_DIR?
>
> Kai Uwe Broulik wrote:
> I suppose? Dunno, I just copied it from KWin and I know nothing about
> CMake syntax.
>
> Hrvoje Senjan wrote:
> Well, all other modules have both INCLUDE_DIRS and PRIVATE_INCLUDE_DIRS...
> Also, IMO it's a better idea to include ECMQueryQmake and use e.g.
> query_qmake(qt_install_include_dir QT_INSTALL_HEADERS) then to use pkgconfig.
>
> Kai Uwe Broulik wrote:
> You've just lost me.
Something like http://paste.opensuse.org/74147268
- Hrvoje
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100256
---
On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
>
> (Updated Oct. 25, 2016, 1:21 p.m.)
>
>
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> ---
>
> Comes from KWin and will eventually be used in Plasma Integration, hence
> moving it to extra-cmake-modules.
>
>
> Diffs
> -
>
> find-modules/FindQt5PlatformSupport.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
>
>
> Testing
> ---
>
> Removed it from KWin, built KWin, worked.
>
> Built plasma-integration with QDBusMenu private stuff, worked, although
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an
> upstream issue since it works with the files Kwin includes.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
Re: Review Request 129260: Add find module for QtPlatformSupport
> On Oct. 25, 2016, 1:31 p.m., Hrvoje Senjan wrote:
> > find-modules/FindQt5PlatformSupport.cmake, line 75
> > <https://git.reviewboard.kde.org/r/129260/diff/1/?file=482953#file482953line75>
> >
> > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and
> > ${PKG_Qt5PlatformSupport_INCLUDEDIR}/QtPlatformSupport/ be marked as
> > Qt5PlatformSupport_INCLUDE_DIR?
>
> Kai Uwe Broulik wrote:
> I suppose? Dunno, I just copied it from KWin and I know nothing about
> CMake syntax.
Well, all other modules have both INCLUDE_DIRS and PRIVATE_INCLUDE_DIRS...
Also, IMO it's a better idea to include ECMQueryQmake and use e.g.
query_qmake(qt_install_include_dir QT_INSTALL_HEADERS) then to use pkgconfig.
- Hrvoje
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100256
---
On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
>
> (Updated Oct. 25, 2016, 1:21 p.m.)
>
>
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> ---
>
> Comes from KWin and will eventually be used in Plasma Integration, hence
> moving it to extra-cmake-modules.
>
>
> Diffs
> -
>
> find-modules/FindQt5PlatformSupport.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
>
>
> Testing
> ---
>
> Removed it from KWin, built KWin, worked.
>
> Built plasma-integration with QDBusMenu private stuff, worked, although
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an
> upstream issue since it works with the files Kwin includes.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
Re: Review Request 129260: Add find module for QtPlatformSupport
> On Oct. 25, 2016, 1:37 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't this be in Qt? What am I missing? > > Martin Gräßlin wrote: > Yes it should, but it isn't. No idea why not. The module is internal, so it intentionally doesn't install any cmake files. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100257 --- On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129260/ > --- > > (Updated Oct. 25, 2016, 1:21 p.m.) > > > Review request for KDE Frameworks, Alex Merry and Martin Gräßlin. > > > Repository: extra-cmake-modules > > > Description > --- > > Comes from KWin and will eventually be used in Plasma Integration, hence > moving it to extra-cmake-modules. > > > Diffs > - > > find-modules/FindQt5PlatformSupport.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129260/diff/ > > > Testing > --- > > Removed it from KWin, built KWin, worked. > > Built plasma-integration with QDBusMenu private stuff, worked, although > includes there sometimes omit the QtPlatformSupport/ prefix but this is an > upstream issue since it works with the files Kwin includes. > > > Thanks, > > Kai Uwe Broulik > >
Re: Review Request 129260: Add find module for QtPlatformSupport
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100256
---
find-modules/FindQt5PlatformSupport.cmake (line 75)
<https://git.reviewboard.kde.org/r/129260/#comment67323>
Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and
${PKG_Qt5PlatformSupport_INCLUDEDIR}/QtPlatformSupport/ be marked as
Qt5PlatformSupport_INCLUDE_DIR?
- Hrvoje Senjan
On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
>
> (Updated Oct. 25, 2016, 1:21 p.m.)
>
>
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> ---
>
> Comes from KWin and will eventually be used in Plasma Integration, hence
> moving it to extra-cmake-modules.
>
>
> Diffs
> -
>
> find-modules/FindQt5PlatformSupport.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
>
>
> Testing
> ---
>
> Removed it from KWin, built KWin, worked.
>
> Built plasma-integration with QDBusMenu private stuff, worked, although
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an
> upstream issue since it works with the files Kwin includes.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/#review99643 --- src/declarativeimports/core/windowthumbnail.cpp (line 231) <https://git.reviewboard.kde.org/r/128763/#comment67000> This is added in Qt 5.6, but: set (REQUIRED_QT_VERSION "5.3.0") which is also wrong. - Hrvoje Senjan On Sept. 3, 2016, 10:33 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128763/ > --- > > (Updated Sept. 3, 2016, 10:33 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > WindowThumbnail did some open GL operations, discarding old textures, in the > GUI thread. Whislt it's not going to cause a threading issue (as > updatePaintNode always ran when the main thread was blocked) we're not meant > to mix threads with openGL contexts. > > It also seems to have a GL leak on nvidia, which was previously masked > by the double delete fixed in https://git.reviewboard.kde.org/r/126131/diff/2/ > It seems only one worked, and in the applied version we went with the wrong > one. > > This patch makes use of QQuickItem::releaseResources to delete the GL > textures on window change and destructor; it's then removed from > stopRedirecting so that start/stop redirecting handles xcb on the GUI thread > and updatePaintNode/discardPixmap is the GL stuff on the render thread. > > See http://doc.qt.io/qt-5/qquickitem.html#graphics-resource-handling > > REVIEW: > > > Diffs > - > > src/declarativeimports/core/windowthumbnail.h > 7276f95de16e71006618f3282d8eaf419a199d1d > src/declarativeimports/core/windowthumbnail.cpp > d106994315099ab6e6f948c31a606d5309ae03e2 > > Diff: https://git.reviewboard.kde.org/r/128763/diff/ > > > Testing > --- > > Using nvidia with proprietory drivers (which puts me > QSG_RENDER_LOOP=threaded) mouse over the panel a lot. VRAM didn't increase. > Previews still appear. > "Used Dedicated Memory:" in nvidia-settings remained roughly static, rather > than constantly increasing. > > > Thanks, > > David Edmundson > >
Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127169/#review96298 --- kde-modules/KDEInstallDirs.cmake (line 431) <https://git.reviewboard.kde.org/r/127169/#comment65096> FWIW, this defacto makes Qt5Core required for anyone that doesn't explicitly disables KDE_INSTALL_USE_QT_SYS_PATHS. E.g. labplot uses ECM and Qt4. - Hrvoje Senjan On April 7, 2016, 1:08 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127169/ > --- > > (Updated April 7, 2016, 1:08 a.m.) > > > Review request for Extra Cmake Modules, KDE Frameworks and Albert Vaca > Cintora. > > > Repository: extra-cmake-modules > > > Description > --- > > Make Qt and ECM-based projects use the same directory sctructure (i.e. where > plugins are, libs, etc.) by default. Otherwise it creates a tiny mess that > might be controlled but usually won't. > > In the end, otherwise, people need to keep adapting their systems with > environment variables anyway. All distros end up setting always this setting > as ON, as well as brave developers who don't have separate prefixes for Qt > and KDE. > > > Diffs > - > > kde-modules/KDEInstallDirs.cmake ebd48fa > > Diff: https://git.reviewboard.kde.org/r/127169/diff/ > > > Testing > --- > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127597: Fix generation of path to xcb plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/#review94358 --- This is still not 100% correct. The define should be bullet proof for both relative and absolute PLUGIN_INSTALL_DIR - Hrvoje Senjan On Tra. 7, 2016, 9:55 ujutro, Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127597/ > --- > > (Updated Tra. 7, 2016, 9:55 ujutro) > > > Review request for KDE Frameworks. > > > Repository: kwindowsystem > > > Description > --- > > The path was wrong which is the reason why X11 windows don't have > icons in kwin_wayland. > > > Diffs > - > > src/config-kwindowsystem.h.cmake 9afe81f9757de5e8e2d9387aa5c641955da08164 > > Diff: https://git.reviewboard.kde.org/r/127597/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127090: Clean KWalletQuery cmake file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127090/#review92774 --- This is not 100% correct. KF5DocTools is searched nowhere, so doc subdir is now never added. - Hrvoje Senjan On Feb. 25, 2016, 1:34 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127090/ > --- > > (Updated Feb. 25, 2016, 1:34 a.m.) > > > Review request for KDE Frameworks and Valentin Rusu. > > > Repository: kwallet > > > Description > --- > > I saw it didn't build because I needed a build with KDocTools, ended up > cleaning a bit more. > > > Diffs > - > > src/runtime/kwallet-query/CMakeLists.txt 42b4687 > src/runtime/kwallet-query/src/main.cpp c19cb29 > > Diff: https://git.reviewboard.kde.org/r/127090/diff/ > > > Testing > --- > > Built with and without KDocTools. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite common. > > So I am not sure about the best solution (bump dep upstream have it patched > > downstream, or just leave it the way it is and do not require a higher > > version number). > > Martin Gräßlin wrote: > I didn't even realize that it requires a higher version as I'm running > Debian and just use what's available. As I don't want the change to be > disruptive for devs I think not increasing the build-dep is better. IMO, rasing te dep is better, as people will wonder why they have polkit-qt-1 not compiling out of the sudden. If downstreams will patch polkit to have the new function, they can just as well patch polkit-qt-1 not to require 0.113. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/#review90956 --- On Jan. 12, 2016, 10:09 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126723/ > --- > > (Updated Jan. 12, 2016, 10:09 a.m.) > > > Review request for KDE Frameworks, David Edmundson, Hrvoje Senjan, and > Matthias Klumpp. > > > Repository: polkit-qt-1 > > > Description > --- > > This adds a new method to SystemBusNameSubject to get to the > UnixUserIdentity for the subject. > > > Diffs > - > > core/polkitqt1-subject.h 4c7a22bae51a501f9aed2eadac0579baea174d0d > core/polkitqt1-subject.cpp f0d69c647f00728525ee78e946a938f270ddb300 > > Diff: https://git.reviewboard.kde.org/r/126723/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite common. > > So I am not sure about the best solution (bump dep upstream have it patched > > downstream, or just leave it the way it is and do not require a higher > > version number). > > Martin Gräßlin wrote: > I didn't even realize that it requires a higher version as I'm running > Debian and just use what's available. As I don't want the change to be > disruptive for devs I think not increasing the build-dep is better. > > Hrvoje Senjan wrote: > IMO, rasing te dep is better, as people will wonder why they have > polkit-qt-1 not compiling out of the sudden. > If downstreams will patch polkit to have the new function, they can just > as well patch polkit-qt-1 not to require 0.113. > > Martin Gräßlin wrote: > > If downstreams will patch polkit to have the new function, they can > just as well patch polkit-qt-1 not to require 0.113. > > my concern is more about our devs than downstreams. E.g. Debian doesn't > have the 0.113, so all devs running Debian based systems will get a missing > dependency although it would compile just fine. I understand, but that it compiles is only by chance. At least a comment in the code would be nice if the req. version won't be bumped. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/#review90956 --- On Jan. 12, 2016, 10:09 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126723/ > ------- > > (Updated Jan. 12, 2016, 10:09 a.m.) > > > Review request for KDE Frameworks, David Edmundson, Hrvoje Senjan, and > Matthias Klumpp. > > > Repository: polkit-qt-1 > > > Description > --- > > This adds a new method to SystemBusNameSubject to get to the > UnixUserIdentity for the subject. > > > Diffs > - > > core/polkitqt1-subject.h 4c7a22bae51a501f9aed2eadac0579baea174d0d > core/polkitqt1-subject.cpp f0d69c647f00728525ee78e946a938f270ddb300 > > Diff: https://git.reviewboard.kde.org/r/126723/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen
> On Dec. 24, 2015, 9:23 p.m., Hrvoje Senjan wrote:
> > backends/CMakeLists.txt, line 3
> > <https://git.reviewboard.kde.org/r/126381/diff/7/?file=424946#file424946line3>
> >
> > Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should
> > be marked as required in top CMakeLists.tyt
>
> Sebastian Kügler wrote:
> KF5Wayland is required in top-level CMakeLists.txt. Where did you see
> that it isn't?
>find_package(KF5Wayland CONFIG)
There's no REQUIRED keyword here AFAICS
- Hrvoje
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review90076
---
On Dec. 22, 2015, 12:46 a.m., Sebastian Kügler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
>
> (Updated Dec. 22, 2015, 12:46 a.m.)
>
>
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
>
>
> Repository: libkscreen
>
>
> Description
> ---
>
> This adds a kwayland backend to libkscreen.
>
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
>
> Enlisting outputs
>
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
>
> Configuring outputs
>
> The backend asks the global OutputManagement interface for an
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
>
> For this to work, the compositor should support the Wayland
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and
> OuputConfiguration.
>
> General working
>
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
>
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
>
>
> Diffs
> -
>
> CMakeLists.txt efac5ce
> autotests/CMakeLists.txt 07b7bbc
> autotests/configs/default.json 3ac3e19
> autotests/testconfigserializer.cpp 1af3069
> autotests/testkwaylandbackend.cpp PRE-CREATION
> autotests/testkwaylandconfig.cpp PRE-CREATION
> backends/CMakeLists.txt ff5d751
> backends/kwayland/CMakeLists.txt PRE-CREATION
> backends/kwayland/README.md PRE-CREATION
> backends/kwayland/waylandbackend.h PRE-CREATION
> backends/kwayland/waylandbackend.cpp PRE-CREATION
> backends/kwayland/waylandconfig.h PRE-CREATION
> backends/kwayland/waylandconfig.cpp PRE-CREATION
> backends/kwayland/waylandoutput.h PRE-CREATION
> backends/kwayland/waylandoutput.cpp PRE-CREATION
> backends/kwayland/waylandscreen.h PRE-CREATION
> backends/kwayland/waylandscreen.cpp PRE-CREATION
> src/backendmanager.cpp 89ae31e
> src/config.cpp e8b8a8f
> src/screen.h 4cd1e82
> tests/CMakeLists.txt d5e41d5
> tests/kwayland/CMakeLists.txt PRE-CREATION
> tests/kwayland/main.cpp PRE-CREATION
> tests/kwayland/waylandconfigreader.h PRE-CREATION
> tests/kwayland/waylandconfigreader.cpp PRE-CREATION
> tests/kwayland/waylandtestserver.h PRE-CREATION
> tests/kwayland/waylandtestserver.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126381/diff/
>
>
> Testing
> ---
>
> The patch c
Re: [Kde-hardware-devel] Review Request 126381: kwayland backend for libkscreen
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review90076
---
backends/CMakeLists.txt (line 3)
<https://git.reviewboard.kde.org/r/126381/#comment61717>
Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should be
marked as required in top CMakeLists.tyt
- Hrvoje Senjan
On Dec. 22, 2015, 12:46 a.m., Sebastian Kügler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
>
> (Updated Dec. 22, 2015, 12:46 a.m.)
>
>
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
>
>
> Repository: libkscreen
>
>
> Description
> ---
>
> This adds a kwayland backend to libkscreen.
>
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
>
> Enlisting outputs
>
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
>
> Configuring outputs
>
> The backend asks the global OutputManagement interface for an
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
>
> For this to work, the compositor should support the Wayland
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and
> OuputConfiguration.
>
> General working
>
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
>
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
>
>
> Diffs
> -
>
> CMakeLists.txt efac5ce
> autotests/CMakeLists.txt 07b7bbc
> autotests/configs/default.json 3ac3e19
> autotests/testconfigserializer.cpp 1af3069
> autotests/testkwaylandbackend.cpp PRE-CREATION
> autotests/testkwaylandconfig.cpp PRE-CREATION
> backends/CMakeLists.txt ff5d751
> backends/kwayland/CMakeLists.txt PRE-CREATION
> backends/kwayland/README.md PRE-CREATION
> backends/kwayland/waylandbackend.h PRE-CREATION
> backends/kwayland/waylandbackend.cpp PRE-CREATION
> backends/kwayland/waylandconfig.h PRE-CREATION
> backends/kwayland/waylandconfig.cpp PRE-CREATION
> backends/kwayland/waylandoutput.h PRE-CREATION
> backends/kwayland/waylandoutput.cpp PRE-CREATION
> backends/kwayland/waylandscreen.h PRE-CREATION
> backends/kwayland/waylandscreen.cpp PRE-CREATION
> src/backendmanager.cpp 89ae31e
> src/config.cpp e8b8a8f
> src/screen.h 4cd1e82
> tests/CMakeLists.txt d5e41d5
> tests/kwayland/CMakeLists.txt PRE-CREATION
> tests/kwayland/main.cpp PRE-CREATION
> tests/kwayland/waylandconfigreader.h PRE-CREATION
> tests/kwayland/waylandconfigreader.cpp PRE-CREATION
> tests/kwayland/waylandtestserver.h PRE-CREATION
> tests/kwayland/waylandtestserver.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126381/diff/
>
>
> Testing
> ---
>
> The patch contains a test server, which is used for the autotests.
>
> The test server uses KWayland's server classes and is set up from the json
> config data we use for the other tests. That means that the backends runs
> against a real server to test everything.
>
> I also tested the kscreen UI, which also works as expected.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: Review Request 126453: Fix library order
> On Dec. 21, 2015, 5:33 p.m., Hrvoje Senjan wrote: > > A public header here (DownloadWidget) includes QWidget > > Kevin Funk wrote: > Qt5::Widgets is still in PUBLIC scope Oops, i could swear i've seen it moved into PRIVATE section. Ignore. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126453/#review89837 --- On Dec. 21, 2015, 5:06 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126453/ > --- > > (Updated Dec. 21, 2015, 5:06 p.m.) > > > Review request for KDE Frameworks, Heiko Becker and Jeremy Whiting. > > > Repository: knewstuff > > > Description > --- > > Fixes issues leading to creation of QTBUG-47240 > > > Diffs > - > > src/CMakeLists.txt cc606444e48b0e519551183c022ccecdac0aa62f > > Diff: https://git.reviewboard.kde.org/r/126453/diff/ > > > Testing > --- > > > Thanks, > > Kevin Funk > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126453: Fix library order
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126453/#review89837 --- A public header here (DownloadWidget) includes QWidget - Hrvoje Senjan On Dec. 21, 2015, 5:06 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126453/ > --- > > (Updated Dec. 21, 2015, 5:06 p.m.) > > > Review request for KDE Frameworks, Heiko Becker and Jeremy Whiting. > > > Repository: knewstuff > > > Description > --- > > Fixes issues leading to creation of QTBUG-47240 > > > Diffs > - > > src/CMakeLists.txt cc606444e48b0e519551183c022ccecdac0aa62f > > Diff: https://git.reviewboard.kde.org/r/126453/diff/ > > > Testing > --- > > > Thanks, > > Kevin Funk > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89369 --- i had the similar problem after commit f35e514 (only empty panel would be shown). this patch fixes the problem here. - Hrvoje Senjan On Dec. 11, 2015, 7:48 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126320/ > --- > > (Updated Dec. 11, 2015, 7:48 p.m.) > > > Review request for KDE Frameworks, Plasma and Alex Richardson. > > > Repository: plasma-framework > > > Description > --- > > plasma-scriptengine.desktop defines the property "X-Plasma-ComponentTypes" > as Type=QStringList. When reading it using KPluginMetaData::value(..) it > expects a QString back. This used to work but regressed in kcoreaddons in > commit cfd18cf09b559a050fd6a2680ad4e71eeb950383. Now I'm not sure if calling > KPluginMetaData::value(..) on a property that is known to be a stringlist > should actually return a QString (Alex?), but making it read the property > as a stringlist works and is correct and also fixes Plasma startup for me. > > > Diffs > - > > src/plasma/scripting/scriptengine.cpp 1b132de > > Diff: https://git.reviewboard.kde.org/r/126320/diff/ > > > Testing > --- > > Plasma would get stuck on startup, now I can run Plasma again. > > > Thanks, > > Martin Klapetek > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88438 --- >assuming, that is, distros push out the updates together don't assume this ;-) at least send a mail to kde-distro-packagers about the sideeffects if those 3 are pushed asynchronously - Hrvoje Senjan On Nov. 16, 2015, 6:06 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126091/ > --- > > (Updated Nov. 16, 2015, 6:06 p.m.) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Repository: khotkeys > > > Description > --- > > After moving KSnapshot to Extragear I've modified it to install its own > khotkeys file (which it does correctly). Spectacle already installs its own > KHotkeys file, so there's no reason anymore for KHotkeys to include its own > PrintScreen hotkey file. > > I'll push out a special release of KSnapshot for distributions to use once > the Plasma 5.5 version of KHotkeys is pushed out, so printscreen > functionality won't be broken on the desktop (assuming, that is, distros push > out the updates together). > > > Diffs > - > > data/CMakeLists.txt f3bcb57 > data/printscreen.khotkeys e583311 > > Diff: https://git.reviewboard.kde.org/r/126091/diff/ > > > Testing > --- > > Doesn't install the printscreen.khotkeys file anymore > > > Thanks, > > Boudhayan Gupta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125561: Align FindGettext with CMP002 policy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/ --- (Updated Oct. 10, 2015, 2:05 p.m.) Status -- This change has been marked as submitted. Review request for Build System, kdelibs, Localization and Translation (l10n), Albert Astals Cid, and Alexander Neundorf. Changes --- Submitted with commit fd59e696d0a27e28b5551dff3d88d94d16787c2b by Hrvoje Senjan to branch KDE/4.14. Repository: kdelibs Description --- Otherwise some apps fail to build with kdelibs >= 4.14.11: ``` CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 (ADD_CUSTOM_TARGET): add_custom_target cannot create target "pofiles" because another target with the same name already exists. The existing target is a custom target created in source directory "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for policy CMP0002 for more details. Call Stack (most recent call first): po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES) ``` Diffs - cmake/modules/FindGettext.cmake 91e88f7 Diff: https://git.reviewboard.kde.org/r/125561/diff/ Testing --- Skanlite now builds. Thanks, Hrvoje Senjan
Re: Review Request 125560: Give unique names to the targets created by KDE4Macros.cmake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125560/ --- (Updated Oct. 10, 2015, 2:05 p.m.) Status -- This change has been marked as submitted. Review request for Build System, kdelibs and Luigi Toscano. Changes --- Submitted with commit 1b0cb8ed48b5bf816cd5fe27d435568e69d94113 by Hrvoje Senjan to branch KDE/4.14. Repository: kdelibs Description --- Backport of review 116650. Needed to fix build of some software after kdelibs' 4.14.11 cmake refactoring Diffs - cmake/modules/KDE4Macros.cmake 8622959 Diff: https://git.reviewboard.kde.org/r/125560/diff/ Testing --- k3b and skanlite tarballs now build. Thanks, Hrvoje Senjan
Re: Review Request 120393: [kdelibs4support] Kill dead code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/ --- (Updated Oct. 10, 2015, 10:36 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks, David Faure and Vishesh Handa. Repository: kdelibs4support Description --- Strigi check has been removed in commit c8f4c69650c71276b2a2263212addde63764e58b, and soprano wasn't even ported to Qt5 (afaik), so this was never compiled. Diffs - autotests/kfilemetainfotest.cpp c751cdd src/CMakeLists.txt b662893 src/config-kdelibs4support.h.cmake 1af3ee0 src/kio/kfilemetadataconfigurationwidget.cpp 259b205 src/kio/kfilemetadataprovider.cpp 3468546 src/kio/kfilemetadataprovider_p.h 31137b2 src/kio/kfilemetadatawidget.cpp 1edb069 src/kio/kfilemetainfo.cpp eae1295 src/kio/kfilemetainfoitem.cpp 62f760d src/kio/kfilemetainfoitem_p.h 8929e46 src/kio/knfotranslator.cpp 8eec6a1 Diff: https://git.reviewboard.kde.org/r/120393/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125561: Align FindGettext with CMP002 policy
> On Oct. 10, 2015, 2:40 p.m., Alexander Semke wrote: > > Sholdn't the proposed patch in https://bugs.kde.org/show_bug.cgi?id=293030 > > already fix the problem? Which patch? I only see the whole file there. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86622 --- On Oct. 10, 2015, 1:42 a.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125561/ > --- > > (Updated Oct. 10, 2015, 1:42 a.m.) > > > Review request for Build System, kdelibs, Localization and Translation > (l10n), Albert Astals Cid, and Alexander Neundorf. > > > Repository: kdelibs > > > Description > --- > > Otherwise some apps fail to build with kdelibs >= 4.14.11: > ``` > CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 > (ADD_CUSTOM_TARGET): > add_custom_target cannot create target "pofiles" because another target > with the same name already exists. The existing target is a custom target > created in source directory > "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for > policy CMP0002 for more details. > Call Stack (most recent call first): > po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES) > ``` > > > Diffs > - > > cmake/modules/FindGettext.cmake 91e88f7 > > Diff: https://git.reviewboard.kde.org/r/125561/diff/ > > > Testing > --- > > Skanlite now builds. > > > Thanks, > > Hrvoje Senjan > >
Re: Review Request 125561: Align FindGettext with CMP002 policy
> On Oct. 10, 2015, 11:23 a.m., Albert Astals Cid wrote: > > This is so much cleaner and easier to understand, what would be a way to > > test this, i.e. which tarball do i use that has the problem this is fixing? > > Albert Astals Cid wrote: > i.e. you mention skanlite, but which tarball of it exactly? > > Yuri Chornoivan wrote: > It can be LabPlot as well: > > http://download.kde.org/stable/labplot/2.1.0/labplot-2.1.0-RC1.tar.xz > > Alexander Semke wrote: > > http://download.kde.org/stable/labplot/2.1.0/labplot-2.1.0-RC2.tar.xz.mirrorlist You can try with e.g. kraft 0.58, kde-gtk-config 2.2.1, skanlite 1.1... - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86609 ------- On Oct. 10, 2015, 1:42 a.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125561/ > --- > > (Updated Oct. 10, 2015, 1:42 a.m.) > > > Review request for Build System, kdelibs, Localization and Translation > (l10n), Albert Astals Cid, and Alexander Neundorf. > > > Repository: kdelibs > > > Description > --- > > Otherwise some apps fail to build with kdelibs >= 4.14.11: > ``` > CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 > (ADD_CUSTOM_TARGET): > add_custom_target cannot create target "pofiles" because another target > with the same name already exists. The existing target is a custom target > created in source directory > "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for > policy CMP0002 for more details. > Call Stack (most recent call first): > po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES) > ``` > > > Diffs > - > > cmake/modules/FindGettext.cmake 91e88f7 > > Diff: https://git.reviewboard.kde.org/r/125561/diff/ > > > Testing > --- > > Skanlite now builds. > > > Thanks, > > Hrvoje Senjan > >
Re: Review Request 125561: Align FindGettext with CMP002 policy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/ --- (Updated Oct. 10, 2015, 1:42 a.m.) Review request for Build System, kdelibs, Localization and Translation (l10n), Albert Astals Cid, and Alexander Neundorf. Changes --- Minimal surgery to FindGettext Summary (updated) - Align FindGettext with CMP002 policy Repository: kdelibs Description --- Otherwise some apps fail to build with kdelibs >= 4.14.11: ``` CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 (ADD_CUSTOM_TARGET): add_custom_target cannot create target "pofiles" because another target with the same name already exists. The existing target is a custom target created in source directory "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for policy CMP0002 for more details. Call Stack (most recent call first): po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES) ``` Diffs (updated) - cmake/modules/FindGettext.cmake 91e88f7 Diff: https://git.reviewboard.kde.org/r/125561/diff/ Testing --- Skanlite now builds. Thanks, Hrvoje Senjan
Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/ --- Review request for Build System, kdelibs, Localization and Translation (l10n), Albert Astals Cid, and Alexander Neundorf. Repository: kdelibs Description --- Otherwise some apps fail to build with kdelibs >= 4.14.11: ``` CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 (ADD_CUSTOM_TARGET): add_custom_target cannot create target "pofiles" because another target with the same name already exists. The existing target is a custom target created in source directory "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for policy CMP0002 for more details. Call Stack (most recent call first): po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES) ``` Diffs - cmake/modules/FindGettext.cmake 91e88f7 Diff: https://git.reviewboard.kde.org/r/125561/diff/ Testing --- Skanlite now builds. Thanks, Hrvoje Senjan
Re: Review Request 125529: switch kde4libs defaults from oxygen to breeze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125529/#review86378 --- As this is a behvioral change (well, closest categorisation), i would avoid merging this to kdelibs4, and mail kde-distro-packagers with a link to this review instead ;-) - Hrvoje Senjan On Oct. 5, 2015, 4:21 p.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125529/ > --- > > (Updated Oct. 5, 2015, 4:21 p.m.) > > > Review request for kdelibs and Jonathan Riddell. > > > Repository: kdelibs > > > Description > --- > > This enables tighter integration with default Plasma 5 appearance in all > cases, previously all KDE4 applications would be themed using the Plasma 5 > Breeze style through a kconf_update script called kde4breeze. This util > writes configs into the user home to make sure KDE4 apps appear breeze > themed. Unfortunately this does not work with sudo'd applications as they > would use a different HOME and thus use the Oxygen theme by default, making > them not fit in with the rest of the default theming. > The patch switches the default icon theme as well as widget style > from oxygen to breeze. > It also adjusts the hardcoded default color values in kcolorscheme from > oxygen to breeze > (thanks to Kai Uwe Broulik https://git.reviewboard.kde.org/r/124872/) > > > Diffs > - > > kdeui/colors/kcolorscheme.cpp a6650ace52117c4abcfc1893228dc23e3ab6299a > kdeui/icons/kicontheme.cpp d9efbb0275e1094c887bb62382d5ddb4135684d7 > kdeui/kernel/kstyle.cpp 95a71c24842338fbe6bf5128f6fb76029960b64a > > Diff: https://git.reviewboard.kde.org/r/125529/diff/ > > > Testing > --- > > > Thanks, > > Harald Sitter > >
Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
> On Oct. 3, 2015, 10:08 a.m., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by definition cannot have a version check). Moving stuff between > > products is hard! > > > > So you were right, better install this under a different filename like in > > your v1 of the patch (just doublecheck that having two definitions of the > > same servicetype in two different files doesn't break things, but I don't > > think it does). And in the second step (later) we can reuse that filename > > to provide a different servicetypename and deprecate KonqPopupMenuPlugin. > > Sorry for not realizing this sooner. > > > > In any case, due to the issue with translations we wanted to commit this > > after today's release (but of course this delays the fix by one month). > > Unless Luigi is available this weekend to do the merging, but it's getting > > tight. > > Luigi Toscano wrote: > I would say that it's better to postpone for the next release (merge > immediately after the tag), so there is a bit more time to catch issues and > it's not risky for this release (too tight now, exactly). > since the latest libkonq release installs konqpopupmenuplugin.desktop already But that release is kdelibs4 based, so there shouldn't be any conflict here... - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276 --- On Oct. 3, 2015, 9:50 a.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > --- > > (Updated Oct. 3, 2015, 9:50 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > --- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git=blob=94a680ac215b4638a0c7cdd2b20bc7830b9619f2=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > - > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/konqpopupmenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > --- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125359: Remove baloo-monitor from baloo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/#review85827 --- src/tools/CMakeLists.txt <https://git.reviewboard.kde.org/r/125359/#comment59273> Please mention in the changelog that users that will upgrade to KF5 5.15 will lose the app. - Hrvoje Senjan On Sept. 23, 2015, 3:11 p.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125359/ > --- > > (Updated Sept. 23, 2015, 3:11 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > --- > > Since we have the monitor as KCM in KInfoCenter now no point keeping it in 2 > places. > > > Diffs > - > > src/qml/experimental/CMakeLists.txt d0f5481 > src/qml/experimental/baloomonitorplugin.cpp 1997782 > src/qml/experimental/monitor.h PRE-CREATION > src/qml/experimental/monitor.cpp PRE-CREATION > src/tools/CMakeLists.txt 7e5da67 > src/tools/baloo-monitor/CMakeLists.txt 4c8ac67 > src/tools/baloo-monitor/constants.js 2e8f26a > src/tools/baloo-monitor/main.cpp 9f108ea > src/tools/baloo-monitor/main.qml 01dfc3f > src/tools/baloo-monitor/monitor.h a864511 > src/tools/baloo-monitor/monitor.cpp 0b205d9 > src/tools/baloo-monitor/qml.qrc afd9e4c > > Diff: https://git.reviewboard.kde.org/r/125359/diff/ > > > Testing > --- > > > Thanks, > > Pinak Ahuja > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 125284: make install name of applications.menu file a cached cmake variable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/#review85585 --- +1 This will save a lot of patch rebasing :D (i'm assuming every distro renames the file) - Hrvoje Senjan On Sept. 17, 2015, 11:32 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125284/ > --- > > (Updated Sept. 17, 2015, 11:32 a.m.) > > > Review request for KDE Frameworks, David Faure, Jonathan Riddell, and Rex > Dieter. > > > Repository: kservice > > > Description > --- > > To not conflict with kde4runtime nor gnome nor xfce, distributions may > choose to have a different name for their applications.menu file. > To enable this without pitchy patching make the installed name fully > parameterized via the cmake variable APPLICATIONS_MENU_NAME. > > This is based on the debian/kubuntu patch to rename the file: > http://anonscm.debian.org/cgit/pkg-kde/frameworks/kservice.git/tree/debian/patches/kubuntu_rename-application-menu-file.diff?h=kubuntu_wily_archive=de26b631f641b0aa5e2e184443ff6970ed5e8b56 > > > Diffs > - > > CMakeLists.txt 958db4a4891a982b7e9a1bd5c903cb4d126e1cdc > src/CMakeLists.txt 5ea5b002411a098a0111a6ee552c554ec461cc28 > src/sycoca/kbuildsycoca.cpp 60a60662ac014ddc73825ca40f604730e0596537 > > Diff: https://git.reviewboard.kde.org/r/125284/diff/ > > > Testing > --- > > clean cmake && make && make install > > -- Installing: ./etc/xdg/menus/applications.menu > > changed cached var && make && make install > > -- Installing: ./etc/xdg/menus/kf5-applications.menu > > > Thanks, > > Harald Sitter > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125243: Trivial CMake corrections for Baloo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125243/ --- (Updated Sept. 16, 2015, 6:20 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit f1731c26fd27d8eafcf487bd5fae181beefcc904 by Hrvoje Senjan to branch master. Repository: baloo Description --- 1) Be explicit about which modules are required 2) Find dependancies as the rest of KF5 ecosystem Diffs - CMakeLists.txt d419b91 KF5BalooConfig.cmake.in cc0f543 src/file/CMakeLists.txt 0b5d1d9 Diff: https://git.reviewboard.kde.org/r/125243/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124919: Re-organize D-Bus interfaces
> On Aug. 31, 2015, 10:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > <https://git.reviewboard.kde.org/r/124919/diff/2/?file=398321#file398321line26> > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit > > Harald Sitter wrote: > Yeah unfortunately removing methods from the dbus interfaces and renaming > the interfaces files (file.index -> fileindexer) is as SiC as it gets. In > particular considering the interfaces are getting installed they are forming > part of the public API. > > Pinak Ahuja wrote: > * I didn't realize messing around with the D-Bus interfaces would be a > big deal. Forgive me for my ignorance, but what is a SiC change? From the > discussion above, SiC change seems to be a change in the public API? What is > the proper way to handle it. > > * Also I looked at plasma-desktop, it does generate a D-Bus interface for > baloo in baloo kcm but doesn't seem to be using it? Should I just remove it > from there? > > Vishesh Handa wrote: > They are not part of the public API. I refuse to place additional > restrictions which do not allow Baloo to evolve. > > I grepped the plasma code, and it seems the KCM does depend on the > interface in the dbus in the CMakeLists but does not actually use it > anywhere. I've fixed it plasma-desktop 5.4 branch. > > For this release, if you guys want we can still ship the old dbus > interface, but it won't work. >They are not part of the public API. I refuse to place additional restrictions >which do not allow Baloo to evolve. Please see other similar reviews for another framework: https://git.reviewboard.kde.org/r/122926/ https://git.reviewboard.kde.org/r/122970/ If you install an interface, it's public, doesn't matter do you consider it such or no ;-) (It's not a matter 'do we want' it, but that's incorrect. There are possible users outside projects.kde.org.) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124919/#review84622 --- On Aug. 30, 2015, 6:32 p.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124919/ > --- > > (Updated Aug. 30, 2015, 6:32 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > --- > > * Previously mainhub class was being used to forward D-Bus calls to relevant > objects > * Now each object that needs D-Bus communication is registered as a separate > D-Bus object and communication takes place directly. > * FileContentIndexer has been made a long lived class now to register a D-Bus > object for it. > > > Diffs > - > > src/dbus/CMakeLists.txt 7c37d94 > src/file/filecontentindexer.h eeaa93f > src/file/filecontentindexer.cpp 26f98a3 > src/file/fileindexscheduler.h 90c23c9 > src/file/fileindexscheduler.cpp 89587bc > src/file/indexerstate.h 2ed8ec9 > src/file/mainhub.h 08993c6 > src/file/mainhub.cpp dcfac30 > src/tools/baloo-monitor/CMakeLists.txt 1abb16a > src/tools/baloo-monitor/monitor.h 597690a > src/tools/baloo-monitor/monitor.cpp 485db87 > src/tools/balooctl/CMakeLists.txt 2823e65 > src/tools/balooctl/main.cpp 81bedf6 > src/tools/balooctl/monitor.h 2a39ba9 > src/tools/balooctl/monitor.cpp c5d3b50 > > Diff: https://git.reviewboard.kde.org/r/124919/diff/ > > > Testing > --- > > baloo-monitor and balooctl seem to be working as before. > > > Thanks, > > Pinak Ahuja > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 124919: Re-organize D-Bus interfaces
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124919/#review84622 --- src/dbus/CMakeLists.txt (line 26) <https://git.reviewboard.kde.org/r/124919/#comment58559> This looks like a SiC change to me, no? e.g. plasma-desktop won't build with this commit - Hrvoje Senjan On Aug. 30, 2015, 6:32 p.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124919/ > --- > > (Updated Aug. 30, 2015, 6:32 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > --- > > * Previously mainhub class was being used to forward D-Bus calls to relevant > objects > * Now each object that needs D-Bus communication is registered as a separate > D-Bus object and communication takes place directly. > * FileContentIndexer has been made a long lived class now to register a D-Bus > object for it. > > > Diffs > - > > src/dbus/CMakeLists.txt 7c37d94 > src/file/filecontentindexer.h eeaa93f > src/file/filecontentindexer.cpp 26f98a3 > src/file/fileindexscheduler.h 90c23c9 > src/file/fileindexscheduler.cpp 89587bc > src/file/indexerstate.h 2ed8ec9 > src/file/mainhub.h 08993c6 > src/file/mainhub.cpp dcfac30 > src/tools/baloo-monitor/CMakeLists.txt 1abb16a > src/tools/baloo-monitor/monitor.h 597690a > src/tools/baloo-monitor/monitor.cpp 485db87 > src/tools/balooctl/CMakeLists.txt 2823e65 > src/tools/balooctl/main.cpp 81bedf6 > src/tools/balooctl/monitor.h 2a39ba9 > src/tools/balooctl/monitor.cpp c5d3b50 > > Diff: https://git.reviewboard.kde.org/r/124919/diff/ > > > Testing > --- > > baloo-monitor and balooctl seem to be working as before. > > > Thanks, > > Pinak Ahuja > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 123030: Let KHtml be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123030/ --- (Updated July 13, 2015, 6:54 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit 093c96c87b3267ed16dce6faae98df139e1c1407 by Hrvoje Senjan to branch master. Repository: khtml Description --- Only search for public deps in cmake config Diffs - KF5KHtmlConfig.cmake.in 74e822c src/CMakeLists.txt c6f5fab Diff: https://git.reviewboard.kde.org/r/123030/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review82237 --- src/pluginwrapper.cpp (line 68) https://git.reviewboard.kde.org/r/124220/#comment56613 After updating to latest master, i wonder do we need this debug enabled by default? :D - Hrvoje Senjan On July 7, 2015, 1:31 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/ --- (Updated July 7, 2015, 1:31 p.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- A plugin interface is added which allows a platform specific plugin to implement an interface. If the plugin does not implement the interface, it will fall back to the default implementation. Also if no plugin can be resolved it will fall back to the default implementation. This replaces the existing compile time and runtime selection. In order to make this work the KWindowInfoPrivate is changed from a templated approach to using pure virtuals just like the other private implementations in this library. As the platform specific parts are no longer compiled in we cannot just delegate the KWindowSystem::icon with NETWinInfo overload to the xcb implementation. In order to solve this problem the required method is added to the private interface with a default implementation which does not return anything. If we are not on platform xcb and KWindowSystem is compiled with X11 support the plugin for xcb is loaded and the call gets delegated to the xcb implementation. This allows e.g. KWin to still read icons for Xwayland clients. Diffs - src/CMakeLists.txt ff2ce392ecd7969eb94543528c7a670ea0fcd870 src/config-kwindowsystem.h.cmake fa0eec115870be27a17ec7b398e40f0c7506f11b src/kwindoweffects.cpp fd88e20e1728506f135bcd5ecda3c05754839717 src/kwindoweffects_dummy.cpp 3e24cecb5c7d25883c179b622abdb5ab06587c33 src/kwindoweffects_dummy_p.h PRE-CREATION src/kwindoweffects_p.h 7c740da952f279a2c5fe689daa5a06c131fa9c9d src/kwindowinfo.cpp f29828581cdaecb7613c3f62cff72aa1fc33c266 src/kwindowinfo_dummy_p.h PRE-CREATION src/kwindowinfo_p.h 6727dd1715a13e5bd7793275620c5fa682318f1c src/kwindowsystem.cpp 789132e1b4883dd54218d29af9710dedfe6218e1 src/kwindowsystem_dummy_p.h PRE-CREATION src/kwindowsystem_p.h 0b5f3e8aeb7b70234c61c59979abd840f349b154 src/kwindowsystemplugininterface.cpp PRE-CREATION src/kwindowsystemplugininterface_p.h PRE-CREATION src/platforms/wayland/CMakeLists.txt PRE-CREATION src/platforms/wayland/plugin.h PRE-CREATION src/platforms/wayland/plugin.cpp PRE-CREATION src/platforms/wayland/wayland.json PRE-CREATION src/platforms/xcb/CMakeLists.txt PRE-CREATION src/platforms/xcb/kwindoweffects.cpp src/platforms/xcb/kwindoweffects_x11.h PRE-CREATION src/platforms/xcb/kwindowinfo.cpp src/platforms/xcb/kwindowinfo_p_x11.h src/platforms/xcb/kwindowsystem.cpp src/platforms/xcb/kwindowsystem_p_x11.h src/platforms/xcb/plugin.h PRE-CREATION src/platforms/xcb/plugin.cpp PRE-CREATION src/platforms/xcb/xcb.json PRE-CREATION src/pluginwrapper.cpp PRE-CREATION src/pluginwrapper_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124220/diff/ Testing --- * unit tests still pass (X11) * kwin_wayland still shows icons for Xwayland clients Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review82168 --- Seems kwindowsystem master doesn't build now (against Qt 5.5 at least): ``` [ 55s] In file included from /home/abuild/rpmbuild/BUILD/kwindowsystem-5.12.0git.20150707T133122~569a723/src/kwindowinfo.cpp:21:0: [ 55s] /home/abuild/rpmbuild/BUILD/kwindowsystem-5.12.0git.20150707T133122~569a723/src/kwindowinfo_p.h:72:11: error: 'QScopedPointer' does not name a type [ 55s] const QScopedPointerPrivate d; [ 55s]^ [ 55s] /home/abuild/rpmbuild/BUILD/kwindowsystem-5.12.0git.20150707T133122~569a723/src/kwindowinfo.cpp: In constructor 'KWindowInfoPrivate::KWindowInfoPrivate(WId, NET::Properties, NET::Properties2)': [ 55s] /home/abuild/rpmbuild/BUILD/kwindowsystem-5.12.0git.20150707T133122~569a723/src/kwindowinfo.cpp:55:7: error: class 'KWindowInfoPrivate' does not have any field named 'd' [ 55s] : d(new Private(window, properties, properties2)) [ 55s]^ [ 55s] /home/abuild/rpmbuild/BUILD/kwindowsystem-5.12.0git.20150707T133122~569a723/src/kwindowinfo.cpp: In member function 'WId KWindowInfoPrivate::win() const': [ 55s] /home/abuild/rpmbuild/BUILD/kwindowsystem-5.12.0git.20150707T133122~569a723/src/kwindowinfo.cpp:65:12: error: 'd' was not declared in this scope [ 55s] return d-window; [ 55s] ^ ``` - Hrvoje Senjan On Srp. 7, 2015, 1:31 popodne, Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/ --- (Updated Srp. 7, 2015, 1:31 popodne) Review request for KDE Frameworks. Repository: kwindowsystem Description --- A plugin interface is added which allows a platform specific plugin to implement an interface. If the plugin does not implement the interface, it will fall back to the default implementation. Also if no plugin can be resolved it will fall back to the default implementation. This replaces the existing compile time and runtime selection. In order to make this work the KWindowInfoPrivate is changed from a templated approach to using pure virtuals just like the other private implementations in this library. As the platform specific parts are no longer compiled in we cannot just delegate the KWindowSystem::icon with NETWinInfo overload to the xcb implementation. In order to solve this problem the required method is added to the private interface with a default implementation which does not return anything. If we are not on platform xcb and KWindowSystem is compiled with X11 support the plugin for xcb is loaded and the call gets delegated to the xcb implementation. This allows e.g. KWin to still read icons for Xwayland clients. Diffs - src/CMakeLists.txt ff2ce392ecd7969eb94543528c7a670ea0fcd870 src/config-kwindowsystem.h.cmake fa0eec115870be27a17ec7b398e40f0c7506f11b src/kwindoweffects.cpp fd88e20e1728506f135bcd5ecda3c05754839717 src/kwindoweffects_dummy.cpp 3e24cecb5c7d25883c179b622abdb5ab06587c33 src/kwindoweffects_dummy_p.h PRE-CREATION src/kwindoweffects_p.h 7c740da952f279a2c5fe689daa5a06c131fa9c9d src/kwindowinfo.cpp f29828581cdaecb7613c3f62cff72aa1fc33c266 src/kwindowinfo_dummy_p.h PRE-CREATION src/kwindowinfo_p.h 6727dd1715a13e5bd7793275620c5fa682318f1c src/kwindowsystem.cpp 789132e1b4883dd54218d29af9710dedfe6218e1 src/kwindowsystem_dummy_p.h PRE-CREATION src/kwindowsystem_p.h 0b5f3e8aeb7b70234c61c59979abd840f349b154 src/kwindowsystemplugininterface.cpp PRE-CREATION src/kwindowsystemplugininterface_p.h PRE-CREATION src/platforms/wayland/CMakeLists.txt PRE-CREATION src/platforms/wayland/plugin.h PRE-CREATION src/platforms/wayland/plugin.cpp PRE-CREATION src/platforms/wayland/wayland.json PRE-CREATION src/platforms/xcb/CMakeLists.txt PRE-CREATION src/platforms/xcb/kwindoweffects.cpp src/platforms/xcb/kwindoweffects_x11.h PRE-CREATION src/platforms/xcb/kwindowinfo.cpp src/platforms/xcb/kwindowinfo_p_x11.h src/platforms/xcb/kwindowsystem.cpp src/platforms/xcb/kwindowsystem_p_x11.h src/platforms/xcb/plugin.h PRE-CREATION src/platforms/xcb/plugin.cpp PRE-CREATION src/platforms/xcb/xcb.json PRE-CREATION src/pluginwrapper.cpp PRE-CREATION src/pluginwrapper_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124220/diff/ Testing --- * unit tests still pass (X11) * kwin_wayland still shows icons for Xwayland clients Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks
Re: Review Request 124186: [runtime] Install headers and library for the private part
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124186/#review81783 --- src/runtime/CMakeLists.txt (line 26) https://git.reviewboard.kde.org/r/124186/#comment56093 I can't say what's more correct, as this would be a precedent for installing private headers, maybe maybe going Qt way would be more consistent? ($module/$version/$module) - Hrvoje Senjan On June 26, 2015, 1:51 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124186/ --- (Updated June 26, 2015, 1:51 p.m.) Review request for KDE Frameworks and Martin Klapetek. Repository: kglobalaccel Description --- We need to make the library and plugin interface available to support more platforms. On a Plasma Wayland session it's required that KWin becomes KGlobalAccel. KWin is the only process which can filter key events and for security reasons KWin will not delegate them to other applications. This means KWin needs to create KGlobalAccelD before KWin or any other process tries to register a global shortcuts triggering kglobalaccel5 to be started. In addition KWin needs to provide it's own plugin which it can interact with. Diffs - src/runtime/CMakeLists.txt 248762f98a6d5b24d4298976bdd1b5a1b4cf1a2c Diff: https://git.reviewboard.kde.org/r/124186/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123438: Make KAUTH_HELPER_INSTALL_ABSOLUTE_DIR available to all KAuth users
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123438/ --- (Updated May 30, 2015, 5:15 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Aleix Pol Gonzalez and Daniel Vrátil. Changes --- Submitted with commit add32bbfc92b89ad5e77c99427f22743589c6c5d by Hrvoje Senjan to branch master. Repository: kauth Description --- Not only those that use KAUTH_INSTALL_HELPER_FILES function. Diffs - CMakeLists.txt 6193047 KF5AuthConfig.cmake.in 7af5276 cmake/KF5AuthMacros.cmake 50b7ad1 Diff: https://git.reviewboard.kde.org/r/123438/diff/ Testing --- Otherwise, for org.kde.fontinst.service in plasma-desktop we get e.g. Exec=/fontinst, as KAUTH_HELPER_INSTALL_ABSOLUTE_DIR is empty. This means that Plasma 5.2.95 has a broken fontinst service. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123438: Make KAUTH_HELPER_INSTALL_ABSOLUTE_DIR available to all KAuth users
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123438/#review80863 --- ping - Hrvoje Senjan On April 20, 2015, 3:07 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123438/ --- (Updated April 20, 2015, 3:07 p.m.) Review request for KDE Frameworks, Aleix Pol Gonzalez and Daniel Vrátil. Repository: kauth Description --- Not only those that use KAUTH_INSTALL_HELPER_FILES function. Diffs - CMakeLists.txt 6193047 KF5AuthConfig.cmake.in 7af5276 cmake/KF5AuthMacros.cmake 50b7ad1 Diff: https://git.reviewboard.kde.org/r/123438/diff/ Testing --- Otherwise, for org.kde.fontinst.service in plasma-desktop we get e.g. Exec=/fontinst, as KAUTH_HELPER_INSTALL_ABSOLUTE_DIR is empty. This means that Plasma 5.2.95 has a broken fontinst service. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123030: Let KHtml be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123030/#review80864 --- ping - Hrvoje Senjan On April 16, 2015, 4:06 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123030/ --- (Updated April 16, 2015, 4:06 p.m.) Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- Only search for public deps in cmake config Diffs - KF5KHtmlConfig.cmake.in 74e822c src/CMakeLists.txt c6f5fab Diff: https://git.reviewboard.kde.org/r/123030/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120393: [kdelibs4support] Kill dead code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/#review80866 --- Ok. Will update diff to kill nepomuk only. What about forwarding headers? They are still installed - Hrvoje Senjan On March 18, 2015, 7:24 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/ --- (Updated March 18, 2015, 7:24 p.m.) Review request for KDE Frameworks, David Faure and Vishesh Handa. Repository: kdelibs4support Description --- Strigi check has been removed in commit c8f4c69650c71276b2a2263212addde63764e58b, and soprano wasn't even ported to Qt5 (afaik), so this was never compiled. Diffs - autotests/kfilemetainfotest.cpp c751cdd src/CMakeLists.txt b662893 src/config-kdelibs4support.h.cmake 1af3ee0 src/kio/kfilemetadataconfigurationwidget.cpp 259b205 src/kio/kfilemetadataprovider.cpp 3468546 src/kio/kfilemetadataprovider_p.h 31137b2 src/kio/kfilemetadatawidget.cpp 1edb069 src/kio/kfilemetainfo.cpp eae1295 src/kio/kfilemetainfoitem.cpp 62f760d src/kio/kfilemetainfoitem_p.h 8929e46 src/kio/knfotranslator.cpp 8eec6a1 Diff: https://git.reviewboard.kde.org/r/120393/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123032: Search for public dep in KPeople's cmake config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123032/#review80865 --- Raised the issue of minimal vs all in r123031 - Hrvoje Senjan On March 18, 2015, 7:30 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123032/ --- (Updated March 18, 2015, 7:30 p.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kpeople Description --- Both KF5::PeopleBackend and KF5::PeopleWidgets need Qt5Widgets publicly, so search them. Diffs - KF5PeopleConfig.cmake.in 05ae340 Diff: https://git.reviewboard.kde.org/r/123032/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123031: Let Kross be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/ --- (Updated May 26, 2015, 10:04 p.m.) Review request for Build System, KDE Frameworks and Alex Merry. Repository: kross Description (updated) --- Only search for public deps in cmake config. Open question - shall we search *all* public deps, or minimal ones? e.g. target 1 link Qt5Core, target 2 links Qt5Gui. Do we search for both, or just Qt5Core? Diffs - KF5KrossConfig.cmake.in e89cee2 Diff: https://git.reviewboard.kde.org/r/123031/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review80415 --- src/platformtheme/kdeplatformfiledialoghelper.cpp (line 300) https://git.reviewboard.kde.org/r/123335/#comment55170 This somehow breaks dialogs from QFileDialog. e.g. standarddialogs' QFileDialog::getOpenFileName() from Qt examples, smplayer, vlc dialogs are all broken (they don't show). Strangely, removing this line fixes the problem here - Hrvoje Senjan On April 17, 2015, 10 a.m., David Rosca wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/ --- (Updated April 17, 2015, 10 a.m.) Review request for KDE Frameworks, David Faure and Lukáš Tinkl. Repository: frameworkintegration Description --- 9814e4b773b2b34afafa0c5d242594bbb4f9a6ae fixed QML file dialogs but broke QtWidgets dialogs. QFileDialog static functions - dialog would open, but any user interaction is blocked (cannot select files or click on anything). QFileDialog *d = new QFileDialog(parent); d-open(); - dialog would not open at all The first issue occurs because exec() is called on already shown dialog. This is fixed by explicit hide() before calling exec() - kind of hacky :/ The second issue is fixed by always calling show(). Diffs - autotests/CMakeLists.txt 00e4a41 autotests/kfiledialog_unittest.cpp 45a139a autotests/kfiledialogqml_unittest.cpp PRE-CREATION autotests/qml/filedialog_parentless.qml PRE-CREATION autotests/qml/filedialog_withparent.qml PRE-CREATION src/platformtheme/kdeplatformfiledialoghelper.cpp 92ab107 Diff: https://git.reviewboard.kde.org/r/123335/diff/ Testing --- QML dialogs: example from bug 334963 works fine file dialog from plasma desktop settings - wallpapers works fine QtWidgets dialogs: static dialogs from qtbase/examples/widgets/dialogs/standarddialogs works fine QFileDialog *d = new QFileDialog(parent); d-open(); works fine test app: https://paste.kde.org/psddcng5n I'm running Qt 5.4.1. Are there any other types of dialogs that I forgot (and possibly broke)? Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123745: Stop producing warnings about CMP0037 policy
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123745/
---
(Updated May 13, 2015, 8:02 p.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit 38b0eeec41de0e916dd834b849f7ddcfa06bdafc by Hrvoje Senjan
to branch master.
Repository: kauth
Description
---
Let cmake know ALL is not the name in this custom command. As a bonus, one can
really execute make ${HELPER_ID}.policy in projects where policies are
generated by kauth.
Diffs
-
cmake/KF5AuthMacros.cmake 3508236
Diff: https://git.reviewboard.kde.org/r/123745/diff/
Testing
---
Configured powerdevil, no warning, before it nagged:
```
[ 110s] CMake Warning (dev) at /usr/lib64/cmake/KF5Auth/KF5AuthMacros.cmake:76
(add_custom_target):
[ 110s] Policy CMP0037 is not set: Target names should not be reserved and
should
[ 110s] match a validity pattern. Run cmake --help-policy CMP0037 for
policy
[ 110s] details. Use the cmake_policy command to set the policy and
suppress this
[ 110s] warning.
[ 110s]
[ 110s] The target name actions for org.kde.powerdevil.backlighthelper is
[ 110s] reserved or not valid for certain CMake features, such as generator
[ 110s] expressions, and may result in undefined behavior.
[ 110s] Call Stack (most recent call first):
[ 110s] daemon/BackendConfig.cmake:46 (kauth_install_actions)
[ 110s] daemon/CMakeLists.txt:96 (include)
```
Also make org.kde.powerdevil.backlighthelper.policy now works.
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123745: Stop producing warnings about CMP0037 policy
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123745/
---
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Repository: kauth
Description
---
Let cmake know ALL is not the name in this custom command. As a bonus, one can
really execute make ${HELPER_ID}.policy in projects where policies are
generated by kauth.
Diffs
-
cmake/KF5AuthMacros.cmake 3508236
Diff: https://git.reviewboard.kde.org/r/123745/diff/
Testing
---
Configured powerdevil, no warning, before it nagged:
```
[ 110s] CMake Warning (dev) at /usr/lib64/cmake/KF5Auth/KF5AuthMacros.cmake:76
(add_custom_target):
[ 110s] Policy CMP0037 is not set: Target names should not be reserved and
should
[ 110s] match a validity pattern. Run cmake --help-policy CMP0037 for
policy
[ 110s] details. Use the cmake_policy command to set the policy and
suppress this
[ 110s] warning.
[ 110s]
[ 110s] The target name actions for org.kde.powerdevil.backlighthelper is
[ 110s] reserved or not valid for certain CMake features, such as generator
[ 110s] expressions, and may result in undefined behavior.
[ 110s] Call Stack (most recent call first):
[ 110s] daemon/BackendConfig.cmake:46 (kauth_install_actions)
[ 110s] daemon/CMakeLists.txt:96 (include)
```
Also make org.kde.powerdevil.backlighthelper.policy now works.
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123626: port libplasma away from sycoca as much as possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review79977 --- I would keep this for safety until Plasma 5.4 is released, then try to remove it again First, sorry for being the bad cop, i'd just like to avoid any future (irreversible) problems, and that distros delivering monthly KF5 updates continue doing so in the future ;-) Please don't remove anything ever, KF5 promises backward compatibility forever, not until $someotherproductversion... Distros where assured over and over again in the famous thread that no-bugfix-only KF5 releases will be a good thing for everyone, and they should be treated as bugfix releases (same as we can update kdelibs to 4.14.99 with kde-workspace 4.11.99). If a distro would release with $someotherproductversion-1, and update KF5 monthly they would get nice reports about broken desktops - and in principle all non-rolling distros won't deliver new feature releases for desktop and applications. - Hrvoje Senjan On May 6, 2015, 7:21 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 7:21 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache) a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well Diffs - KF5PlasmaConfig.cmake.in dee79ca src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 src/plasma/applet.cpp 2dda381 src/plasma/containment.cpp 7eabbb8 src/plasma/containmentactions.cpp f24bdac src/plasma/dataengine.cpp 4b3d671 src/plasma/package.cpp 4e0be88 src/plasma/packagestructure.cpp b2686b6 src/plasma/pluginloader.cpp 0ce349a src/plasma/private/applet_p.cpp 2cbfd06 src/plasma/private/dataenginemanager.cpp b9c5d8e src/plasma/scripting/appletscript.h 863d707 src/plasma/scripting/dataenginescript.h f7ad3c2 src/plasma/scripting/scriptengine.cpp cc407e7 src/plasma/service.h b5d9b5a src/plasma/service.cpp 3e9d852 src/plasmapkg/plasmapkg.cpp d606365 src/scriptengines/CMakeLists.txt f566406 src/scriptengines/qml/CMakeLists.txt e7130db src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 Diff: https://git.reviewboard.kde.org/r/123626/diff/ Testing --- still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine latest version still installs metadata files in kservices5. I would keep this for safety until Plasma 5.4 is released, then try to remove it again Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123551: Introduce the deprecated plugin system for now
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/#review79650 --- Maybe you want to query kservice only in case plugins haven't been found via KPluginLoader? - Hrvoje Senjan On April 29, 2015, 1:16 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123551/ --- (Updated April 29, 2015, 1:16 a.m.) Review request for KDE Frameworks, KDEPIM and Hrvoje Senjan. Repository: kpeople Description --- Also support the old backend plugin system in KPeople until dependencies can adopt the new format. Diffs - CMakeLists.txt 6452c2d metainfo.yaml 7259adb src/CMakeLists.txt eba092c src/personpluginmanager.cpp 365280e src/widgets/CMakeLists.txt bfe1188 src/widgets/actions.cpp 2f1d60d src/widgets/persondetailsview.cpp 7c18c74 Diff: https://git.reviewboard.kde.org/r/123551/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123402: Moves away from KService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123402/#review79641 --- As this breaks released KTp (15.04.x), IMHO best is either to revert this one, or still provide fallback for kservice plugins... I know KF5 guarantees binary and source compatibility, not explicitly runtime, but this will upset users and distros if they'll have broken contacts for 2 months until 15.08 get out... - Hrvoje Senjan On April 20, 2015, 7:50 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123402/ --- (Updated April 20, 2015, 7:50 p.m.) Review request for KDE Frameworks, KDEPIM and Martin Klapetek. Repository: kpeople Description --- Using KPluginFactory for instantiating the plugins, maybe we could do a bit better there and just use QPluginLoader which is what we seem to need on most cases. See discussion on depending patch. Tier 3 - Tier 2 Diffs - CMakeLists.txt 11e2aa6 metainfo.yaml 9795646 src/CMakeLists.txt 225cee5 src/personpluginmanager.cpp 9dd3f6e src/widgets/actions.cpp ed7e02c src/widgets/persondetailsview.cpp 8a2ef5c Diff: https://git.reviewboard.kde.org/r/123402/diff/ Testing --- My KTP contact list still works, tests still pass and example applications still work as well. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123438: Make KAUTH_HELPER_INSTALL_ABSOLUTE_DIR available to all KAuth users
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123438/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and Daniel Vrátil. Repository: kauth Description --- Not only those that use KAUTH_INSTALL_HELPER_FILES function. Diffs - CMakeLists.txt 6193047 KF5AuthConfig.cmake.in 7af5276 cmake/KF5AuthMacros.cmake 50b7ad1 Diff: https://git.reviewboard.kde.org/r/123438/diff/ Testing --- Otherwise, for org.kde.fontinst.service in plasma-desktop we get e.g. Exec=/fontinst, as KAUTH_HELPER_INSTALL_ABSOLUTE_DIR is empty. This means that Plasma 5.2.95 has a broken fontinst service. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123421/ --- Review request for KDE Frameworks, Gregor Mi and Jeremy Whiting. Repository: knewstuff Description --- Like it's done with the rest of the frameworks. Diffs - data/CMakeLists.txt 32d39ab src/kmoretools/kmoretools.h 89e75b5 src/kmoretools/kmoretools.cpp 27a0f74 Diff: https://git.reviewboard.kde.org/r/123421/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123421/ --- (Updated April 19, 2015, 1:24 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Gregor Mi and Jeremy Whiting. Changes --- Submitted with commit 31d27cb16d370774af3ef291117d161619b30c48 by Hrvoje Senjan to branch master. Repository: knewstuff Description --- Like it's done with the rest of the frameworks. Diffs - data/CMakeLists.txt 32d39ab src/kmoretools/kmoretools.h 89e75b5 src/kmoretools/kmoretools.cpp 27a0f74 Diff: https://git.reviewboard.kde.org/r/123421/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability
On April 18, 2015, 11:29 p.m., Gregor Mi wrote: Ship It! Gregor Mi wrote: Thanks for also taking care of the commments/documentation. There is some more, which I will do later. Ok, founds some other references to old location and adjusted them also. Please check the commit message: if other apps are to install files into this dir, then a better solution would be to have KDE_INSTALL_KMORETOOLS5DIR which would expand to DATAROOTDIR/kmoretools5. For this we have time until 5.10.0 is relased and location becomes a part of the public API. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123421/#review79182 --- On April 19, 2015, 3:24 a.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123421/ --- (Updated April 19, 2015, 3:24 a.m.) Review request for KDE Frameworks, Gregor Mi and Jeremy Whiting. Repository: knewstuff Description --- Like it's done with the rest of the frameworks. Diffs - data/CMakeLists.txt 32d39ab src/kmoretools/kmoretools.h 89e75b5 src/kmoretools/kmoretools.cpp 27a0f74 Diff: https://git.reviewboard.kde.org/r/123421/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897
On April 17, 2015, 6:16 p.m., Aleix Pol Gonzalez wrote: Wouldn't it have been easier to add the subdirectory in the interface? Or you want users of the library to specify the namespace? Also the former one would have been fine as long as the header and the export file are in the same directory, which seems to be the case... Maybe it would be easier, but this seems to be indeed namespaced framework, same like Solid and KParts. David's commit is correct, though it uncovered further problems in this frameworks, and it's consumers. It is now indeed the question whether to make networkmanager-qt correctly export and install it's headers at the cost of a SiC (even though the SiC is triggered by incorrect usage of includes)... - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/#review79137 --- On April 17, 2015, 5:53 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/ --- (Updated April 17, 2015, 5:53 p.m.) Review request for KDE Frameworks, David Faure and Jan Grulich. Repository: networkmanager-qt Description --- The headers include networkmanagerqt_export.h, which is now in lowercase directory, and is not in public INTERFACE includes. We need to change all the includes, and place where the export is generated. Diffs - src/CMakeLists.txt 0dc3f2e src/accesspoint.h 99895ef src/activeconnection.h 6edd0ae src/adsldevice.h d7c92ba src/bluetoothdevice.h 4baf4a3 src/bonddevice.h 82eafa2 src/bridgedevice.h 68b3e00 src/connection.h a20d1f7 src/device.h bca098b src/dhcp4config.h 35082ba src/dhcp6config.h 91ca914 src/genericdevice.h d95fab0 src/generictypes.h cd45430 src/gredevice.h eeb682c src/infinibanddevice.h c9597cb src/ipaddress.h ebc3e5f src/ipconfig.h 5eb0227 src/iproute.h 13afe15 src/macvlandevice.h ab02831 src/manager.h e79b933 src/modemdevice.h e40d457 src/olpcmeshdevice.h 9af2342 src/secretagent.h 02e4c9a src/settings.h f5fe486 src/settings/adslsetting.h 89ab5b5 src/settings/bluetoothsetting.h 9a32851 src/settings/bondsetting.h f3ae1ec src/settings/bridgeportsetting.h 7a8f74a src/settings/bridgesetting.h 4628cf5 src/settings/cdmasetting.h ecd30da src/settings/connectionsettings.h 252f8e9 src/settings/genericsetting.h 610568a src/settings/gsmsetting.h 1a152b2 src/settings/infinibandsetting.h 713e01e src/settings/ipv4setting.h bdfcc58 src/settings/ipv6setting.h 7e7ca9e src/settings/olpcmeshsetting.h 217682d src/settings/pppoesetting.h a3c5d79 src/settings/pppsetting.h 4755288 src/settings/security8021xsetting.h 486f1bc src/settings/serialsetting.h fa0bf57 src/settings/setting.h 86c6e83 src/settings/teamsetting.h ba58a5d src/settings/template.h 4f9f680 src/settings/vlansetting.h 8432eab src/settings/vpnsetting.h 67aea4e src/settings/wimaxsetting.h 9fd887a src/settings/wiredsetting.h fec6860 src/settings/wirelesssecuritysetting.h 5c9a1da src/settings/wirelesssetting.h 12eed72 src/teamdevice.h e42bc81 src/tundevice.h dd66977 src/utils.h d091c5e src/vethdevice.h c9322d0 src/vlandevice.h bfe2948 src/vpnconnection.h acd0d2e src/vpnplugin.h 3a4f181 src/wimaxdevice.h fb202fa src/wimaxnsp.h c9bd856 src/wireddevice.h 193710c src/wirelessdevice.h 6137036 src/wirelessnetwork.h 1d5cb7b Diff: https://git.reviewboard.kde.org/r/123401/diff/ Testing --- Plasma-nm no longer fails due to original problem, but incorect usage of nm-qt includes: vpnuiplugin.h:31:43: fatal error: NetworkManagerQt/generictypes.h: No such file or directory Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/ --- (Updated April 17, 2015, 6:06 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Faure and Jan Grulich. Changes --- Submitted with commit 13c90ad8e83dc24e8c4e88d2f152ae692b6bdc34 by Hrvoje Senjan to branch master. Repository: networkmanager-qt Description --- The headers include networkmanagerqt_export.h, which is now in lowercase directory, and is not in public INTERFACE includes. We need to change all the includes, and place where the export is generated. Diffs - src/CMakeLists.txt 0dc3f2e src/accesspoint.h 99895ef src/activeconnection.h 6edd0ae src/adsldevice.h d7c92ba src/bluetoothdevice.h 4baf4a3 src/bonddevice.h 82eafa2 src/bridgedevice.h 68b3e00 src/connection.h a20d1f7 src/device.h bca098b src/dhcp4config.h 35082ba src/dhcp6config.h 91ca914 src/genericdevice.h d95fab0 src/generictypes.h cd45430 src/gredevice.h eeb682c src/infinibanddevice.h c9597cb src/ipaddress.h ebc3e5f src/ipconfig.h 5eb0227 src/iproute.h 13afe15 src/macvlandevice.h ab02831 src/manager.h e79b933 src/modemdevice.h e40d457 src/olpcmeshdevice.h 9af2342 src/secretagent.h 02e4c9a src/settings.h f5fe486 src/settings/adslsetting.h 89ab5b5 src/settings/bluetoothsetting.h 9a32851 src/settings/bondsetting.h f3ae1ec src/settings/bridgeportsetting.h 7a8f74a src/settings/bridgesetting.h 4628cf5 src/settings/cdmasetting.h ecd30da src/settings/connectionsettings.h 252f8e9 src/settings/genericsetting.h 610568a src/settings/gsmsetting.h 1a152b2 src/settings/infinibandsetting.h 713e01e src/settings/ipv4setting.h bdfcc58 src/settings/ipv6setting.h 7e7ca9e src/settings/olpcmeshsetting.h 217682d src/settings/pppoesetting.h a3c5d79 src/settings/pppsetting.h 4755288 src/settings/security8021xsetting.h 486f1bc src/settings/serialsetting.h fa0bf57 src/settings/setting.h 86c6e83 src/settings/teamsetting.h ba58a5d src/settings/template.h 4f9f680 src/settings/vlansetting.h 8432eab src/settings/vpnsetting.h 67aea4e src/settings/wimaxsetting.h 9fd887a src/settings/wiredsetting.h fec6860 src/settings/wirelesssecuritysetting.h 5c9a1da src/settings/wirelesssetting.h 12eed72 src/teamdevice.h e42bc81 src/tundevice.h dd66977 src/utils.h d091c5e src/vethdevice.h c9322d0 src/vlandevice.h bfe2948 src/vpnconnection.h acd0d2e src/vpnplugin.h 3a4f181 src/wimaxdevice.h fb202fa src/wimaxnsp.h c9bd856 src/wireddevice.h 193710c src/wirelessdevice.h 6137036 src/wirelessnetwork.h 1d5cb7b Diff: https://git.reviewboard.kde.org/r/123401/diff/ Testing --- Plasma-nm no longer fails due to original problem, but incorect usage of nm-qt includes: vpnuiplugin.h:31:43: fatal error: NetworkManagerQt/generictypes.h: No such file or directory Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/ --- (Updated April 17, 2015, 5:34 p.m.) Review request for KDE Frameworks, David Faure and Jan Grulich. Changes --- Make sure make install passes Repository: networkmanager-qt Description --- The headers include networkmanagerqt_export.h, which is now in lowercase directory, and is not in public INTERFACE includes. We need to change all the includes, and place where the export is generated. Diffs (updated) - src/CMakeLists.txt 0dc3f2e src/accesspoint.h 99895ef src/activeconnection.h 6edd0ae src/adsldevice.h d7c92ba src/bluetoothdevice.h 4baf4a3 src/bonddevice.h 82eafa2 src/bridgedevice.h 68b3e00 src/connection.h a20d1f7 src/device.h bca098b src/dhcp4config.h 35082ba src/dhcp6config.h 91ca914 src/genericdevice.h d95fab0 src/generictypes.h cd45430 src/gredevice.h eeb682c src/infinibanddevice.h c9597cb src/ipaddress.h ebc3e5f src/ipconfig.h 5eb0227 src/iproute.h 13afe15 src/macvlandevice.h ab02831 src/manager.h e79b933 src/modemdevice.h e40d457 src/olpcmeshdevice.h 9af2342 src/secretagent.h 02e4c9a src/settings.h f5fe486 src/settings/adslsetting.h 89ab5b5 src/settings/bluetoothsetting.h 9a32851 src/settings/bondsetting.h f3ae1ec src/settings/bridgeportsetting.h 7a8f74a src/settings/bridgesetting.h 4628cf5 src/settings/cdmasetting.h ecd30da src/settings/connectionsettings.h 252f8e9 src/settings/genericsetting.h 610568a src/settings/gsmsetting.h 1a152b2 src/settings/infinibandsetting.h 713e01e src/settings/ipv4setting.h bdfcc58 src/settings/ipv6setting.h 7e7ca9e src/settings/olpcmeshsetting.h 217682d src/settings/pppoesetting.h a3c5d79 src/settings/pppsetting.h 4755288 src/settings/security8021xsetting.h 486f1bc src/settings/serialsetting.h fa0bf57 src/settings/setting.h 86c6e83 src/settings/teamsetting.h ba58a5d src/settings/template.h 4f9f680 src/settings/vlansetting.h 8432eab src/settings/vpnsetting.h 67aea4e src/settings/wimaxsetting.h 9fd887a src/settings/wiredsetting.h fec6860 src/settings/wirelesssecuritysetting.h 5c9a1da src/settings/wirelesssetting.h 12eed72 src/teamdevice.h e42bc81 src/tundevice.h dd66977 src/utils.h d091c5e src/vethdevice.h c9322d0 src/vlandevice.h bfe2948 src/vpnconnection.h acd0d2e src/vpnplugin.h 3a4f181 src/wimaxdevice.h fb202fa src/wimaxnsp.h c9bd856 src/wireddevice.h 193710c src/wirelessdevice.h 6137036 src/wirelessnetwork.h 1d5cb7b Diff: https://git.reviewboard.kde.org/r/123401/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.
On April 17, 2015, 5:24 p.m., Hrvoje Senjan wrote: This breaks the build of plasma-workspace ``` [ 413s] In file included from /usr/include/KF5/NetworkManagerQt/NetworkManagerQt/Manager:1:0, [ 413s] from /home/abuild/rpmbuild/BUILD/plasma-workspace-5.3.91git~20150418T140715~73ee8a0/dataengines/geolocation/location_ip.cpp:31: [ 413s] /usr/include/KF5/NetworkManagerQt/networkmanagerqt/manager.h:26:37: fatal error: networkmanagerqt_export.h: No such file or directory [ 413s] #include networkmanagerqt_export.h [ 413s] ^ ``` The headers include networkmanagerqt_export.h, which is now in lowercase directory, and is not in public INTERFACE includes... https://git.reviewboard.kde.org/r/123401/ - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123348/#review79132 --- On April 17, 2015, 2:10 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123348/ --- (Updated April 17, 2015, 2:10 p.m.) Review request for KDE Frameworks and Jan Grulich. Repository: networkmanager-qt Description --- The examples didn't build because NetworkManagerQt/Manager didn't exist locally in the builddir. Using ecm_generate_headers properly for such a namespaced framework (i.e. with PREFIX, like KParts does) fixes that, and makes the installation of the headers more standard: NetworkManagerQt/Manager and networkmanagerqt/manager.h, all lowercase; both only available if linking to KF5::NetworkManagerQt. This will break users of NetworkManagerQt/manager.h though (camelcase/lowercase mix), if there are any. Diffs - src/CMakeLists.txt d59949bd2264b1e10de3bc4fedb9e50b8c88f1f3 Diff: https://git.reviewboard.kde.org/r/123348/diff/ Testing --- Compiled examples, ran make install and checked destination paths, rebuilt plasma-nm succesfully. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/ --- Review request for KDE Frameworks, David Faure and Jan Grulich. Repository: networkmanager-qt Description --- The headers include networkmanagerqt_export.h, which is now in lowercase directory, and is not in public INTERFACE includes. We need to change all the includes, and place where the export is generated. Diffs - src/CMakeLists.txt 0dc3f2e src/accesspoint.h 99895ef src/activeconnection.h 6edd0ae src/adsldevice.h d7c92ba src/bluetoothdevice.h 4baf4a3 src/bonddevice.h 82eafa2 src/bridgedevice.h 68b3e00 src/connection.h a20d1f7 src/device.h bca098b src/dhcp4config.h 35082ba src/dhcp6config.h 91ca914 src/genericdevice.h d95fab0 src/generictypes.h cd45430 src/gredevice.h eeb682c src/infinibanddevice.h c9597cb src/ipaddress.h ebc3e5f src/ipconfig.h 5eb0227 src/iproute.h 13afe15 src/macvlandevice.h ab02831 src/manager.h e79b933 src/modemdevice.h e40d457 src/olpcmeshdevice.h 9af2342 src/secretagent.h 02e4c9a src/settings.h f5fe486 src/settings/adslsetting.h 89ab5b5 src/settings/bluetoothsetting.h 9a32851 src/settings/bondsetting.h f3ae1ec src/settings/bridgeportsetting.h 7a8f74a src/settings/bridgesetting.h 4628cf5 src/settings/cdmasetting.h ecd30da src/settings/connectionsettings.h 252f8e9 src/settings/genericsetting.h 610568a src/settings/gsmsetting.h 1a152b2 src/settings/infinibandsetting.h 713e01e src/settings/ipv4setting.h bdfcc58 src/settings/ipv6setting.h 7e7ca9e src/settings/olpcmeshsetting.h 217682d src/settings/pppoesetting.h a3c5d79 src/settings/pppsetting.h 4755288 src/settings/security8021xsetting.h 486f1bc src/settings/serialsetting.h fa0bf57 src/settings/setting.h 86c6e83 src/settings/teamsetting.h ba58a5d src/settings/template.h 4f9f680 src/settings/vlansetting.h 8432eab src/settings/vpnsetting.h 67aea4e src/settings/wimaxsetting.h 9fd887a src/settings/wiredsetting.h fec6860 src/settings/wirelesssecuritysetting.h 5c9a1da src/settings/wirelesssetting.h 12eed72 src/teamdevice.h e42bc81 src/tundevice.h dd66977 src/utils.h d091c5e src/vethdevice.h c9322d0 src/vlandevice.h bfe2948 src/vpnconnection.h acd0d2e src/vpnplugin.h 3a4f181 src/wimaxdevice.h fb202fa src/wimaxnsp.h c9bd856 src/wireddevice.h 193710c src/wirelessdevice.h 6137036 src/wirelessnetwork.h 1d5cb7b Diff: https://git.reviewboard.kde.org/r/123401/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123401/ --- (Updated April 17, 2015, 5:53 p.m.) Review request for KDE Frameworks, David Faure and Jan Grulich. Repository: networkmanager-qt Description --- The headers include networkmanagerqt_export.h, which is now in lowercase directory, and is not in public INTERFACE includes. We need to change all the includes, and place where the export is generated. Diffs - src/CMakeLists.txt 0dc3f2e src/accesspoint.h 99895ef src/activeconnection.h 6edd0ae src/adsldevice.h d7c92ba src/bluetoothdevice.h 4baf4a3 src/bonddevice.h 82eafa2 src/bridgedevice.h 68b3e00 src/connection.h a20d1f7 src/device.h bca098b src/dhcp4config.h 35082ba src/dhcp6config.h 91ca914 src/genericdevice.h d95fab0 src/generictypes.h cd45430 src/gredevice.h eeb682c src/infinibanddevice.h c9597cb src/ipaddress.h ebc3e5f src/ipconfig.h 5eb0227 src/iproute.h 13afe15 src/macvlandevice.h ab02831 src/manager.h e79b933 src/modemdevice.h e40d457 src/olpcmeshdevice.h 9af2342 src/secretagent.h 02e4c9a src/settings.h f5fe486 src/settings/adslsetting.h 89ab5b5 src/settings/bluetoothsetting.h 9a32851 src/settings/bondsetting.h f3ae1ec src/settings/bridgeportsetting.h 7a8f74a src/settings/bridgesetting.h 4628cf5 src/settings/cdmasetting.h ecd30da src/settings/connectionsettings.h 252f8e9 src/settings/genericsetting.h 610568a src/settings/gsmsetting.h 1a152b2 src/settings/infinibandsetting.h 713e01e src/settings/ipv4setting.h bdfcc58 src/settings/ipv6setting.h 7e7ca9e src/settings/olpcmeshsetting.h 217682d src/settings/pppoesetting.h a3c5d79 src/settings/pppsetting.h 4755288 src/settings/security8021xsetting.h 486f1bc src/settings/serialsetting.h fa0bf57 src/settings/setting.h 86c6e83 src/settings/teamsetting.h ba58a5d src/settings/template.h 4f9f680 src/settings/vlansetting.h 8432eab src/settings/vpnsetting.h 67aea4e src/settings/wimaxsetting.h 9fd887a src/settings/wiredsetting.h fec6860 src/settings/wirelesssecuritysetting.h 5c9a1da src/settings/wirelesssetting.h 12eed72 src/teamdevice.h e42bc81 src/tundevice.h dd66977 src/utils.h d091c5e src/vethdevice.h c9322d0 src/vlandevice.h bfe2948 src/vpnconnection.h acd0d2e src/vpnplugin.h 3a4f181 src/wimaxdevice.h fb202fa src/wimaxnsp.h c9bd856 src/wireddevice.h 193710c src/wirelessdevice.h 6137036 src/wirelessnetwork.h 1d5cb7b Diff: https://git.reviewboard.kde.org/r/123401/diff/ Testing (updated) --- Plasma-nm no longer fails due to original problem, but incorect usage of nm-qt includes: vpnuiplugin.h:31:43: fatal error: NetworkManagerQt/generictypes.h: No such file or directory Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123348/#review79132 --- This breaks the build of plasma-workspace ``` [ 413s] In file included from /usr/include/KF5/NetworkManagerQt/NetworkManagerQt/Manager:1:0, [ 413s] from /home/abuild/rpmbuild/BUILD/plasma-workspace-5.3.91git~20150418T140715~73ee8a0/dataengines/geolocation/location_ip.cpp:31: [ 413s] /usr/include/KF5/NetworkManagerQt/networkmanagerqt/manager.h:26:37: fatal error: networkmanagerqt_export.h: No such file or directory [ 413s] #include networkmanagerqt_export.h [ 413s] ^ ``` The headers include networkmanagerqt_export.h, which is now in lowercase directory, and is not in public INTERFACE includes... - Hrvoje Senjan On April 17, 2015, 2:10 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123348/ --- (Updated April 17, 2015, 2:10 p.m.) Review request for KDE Frameworks and Jan Grulich. Repository: networkmanager-qt Description --- The examples didn't build because NetworkManagerQt/Manager didn't exist locally in the builddir. Using ecm_generate_headers properly for such a namespaced framework (i.e. with PREFIX, like KParts does) fixes that, and makes the installation of the headers more standard: NetworkManagerQt/Manager and networkmanagerqt/manager.h, all lowercase; both only available if linking to KF5::NetworkManagerQt. This will break users of NetworkManagerQt/manager.h though (camelcase/lowercase mix), if there are any. Diffs - src/CMakeLists.txt d59949bd2264b1e10de3bc4fedb9e50b8c88f1f3 Diff: https://git.reviewboard.kde.org/r/123348/diff/ Testing --- Compiled examples, ran make install and checked destination paths, rebuilt plasma-nm succesfully. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123030: Let KHtml be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123030/ --- (Updated April 16, 2015, 4:06 p.m.) Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- KF5TextWidgets and KF5Codecs are used in public headers; search for them also Repository: khtml Description --- Only search for public deps in cmake config Diffs (updated) - KF5KHtmlConfig.cmake.in 74e822c src/CMakeLists.txt c6f5fab Diff: https://git.reviewboard.kde.org/r/123030/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120393: [kdelibs4support] Kill dead code
On March 19, 2015, 12:23 a.m., Vishesh Handa wrote: I'm all for getting rid of the Nepomuk code. However, I'm not too sure about the strigi part. That should still work. Hrvoje Senjan wrote: It does not ;-) Originally, this review added back the find_package(Strigi) call which was removed a while back (at least before 5.0.0), so this code was/is never compiled. Vishesh Handa wrote: I still cannot give it a ship it. We need to collectively decide if we want to let the Strigi integration be broken and remove the code. Or add the dependency again and see why it doesn't work. Albert Astals Cid wrote: Agreeing with Vishesh here, can you send a new email to kde-core-devel mailing list mentioning what should we do, if stop supporting strigi or not in kdelibs4support? This way we can get a more project wide discussion about it. Maybe there was a misunderstanding - i do not know do strigi related code works if compiled - problem was/is they where never compiled since, and before 5.0.0. Anyway, i'll compose a k-c-d mail laters... - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/#review77714 --- On March 18, 2015, 7:24 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/ --- (Updated March 18, 2015, 7:24 p.m.) Review request for KDE Frameworks, David Faure and Vishesh Handa. Repository: kdelibs4support Description --- Strigi check has been removed in commit c8f4c69650c71276b2a2263212addde63764e58b, and soprano wasn't even ported to Qt5 (afaik), so this was never compiled. Diffs - autotests/kfilemetainfotest.cpp c751cdd src/CMakeLists.txt b662893 src/config-kdelibs4support.h.cmake 1af3ee0 src/kio/kfilemetadataconfigurationwidget.cpp 259b205 src/kio/kfilemetadataprovider.cpp 3468546 src/kio/kfilemetadataprovider_p.h 31137b2 src/kio/kfilemetadatawidget.cpp 1edb069 src/kio/kfilemetainfo.cpp eae1295 src/kio/kfilemetainfoitem.cpp 62f760d src/kio/kfilemetainfoitem_p.h 8929e46 src/kio/knfotranslator.cpp 8eec6a1 Diff: https://git.reviewboard.kde.org/r/120393/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120393: [kdelibs4support] Kill dead code
On March 19, 2015, 12:23 a.m., Vishesh Handa wrote: I'm all for getting rid of the Nepomuk code. However, I'm not too sure about the strigi part. That should still work. It does not ;-) Originally, this review added back the find_package(Strigi) call which was removed a while back (at least before 5.0.0), so this code was/is never compiled. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/#review77714 --- On March 18, 2015, 7:24 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/ --- (Updated March 18, 2015, 7:24 p.m.) Review request for KDE Frameworks, David Faure and Vishesh Handa. Repository: kdelibs4support Description --- Strigi check has been removed in commit c8f4c69650c71276b2a2263212addde63764e58b, and soprano wasn't even ported to Qt5 (afaik), so this was never compiled. Diffs - autotests/kfilemetainfotest.cpp c751cdd src/CMakeLists.txt b662893 src/config-kdelibs4support.h.cmake 1af3ee0 src/kio/kfilemetadataconfigurationwidget.cpp 259b205 src/kio/kfilemetadataprovider.cpp 3468546 src/kio/kfilemetadataprovider_p.h 31137b2 src/kio/kfilemetadatawidget.cpp 1edb069 src/kio/kfilemetainfo.cpp eae1295 src/kio/kfilemetainfoitem.cpp 62f760d src/kio/kfilemetainfoitem_p.h 8929e46 src/kio/knfotranslator.cpp 8eec6a1 Diff: https://git.reviewboard.kde.org/r/120393/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122313: Expose to world whether KPty has been built with utempter library
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122313/ --- (Updated March 19, 2015, 11:18 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit acf078d84d8f1c4d5fcf28cf9a9f570760ba1501 by Hrvoje Senjan to branch master. Repository: kpty Description --- Equivalent to https://svn.reviewboard.kde.org/r/2468/ It was lost in KF5 porting, and it was directly used to determine whether kwrited should be built as module, or executable (in this case, it would be a SUID binary, which Qt5 no longer -by default- allows) Diffs - CMakeLists.txt 7fe77da7b0bc97c6f64db4fcc63ef7831fa065b1 KF5PtyConfig.cmake.in 04bde7bffd209b57e755a66278025ee8b6453770 cmake/FindUTEMPTER.cmake PRE-CREATION src/CMakeLists.txt caf2f0ba87ad4173af9860ae369b43d50ffd219f src/ConfigureChecks.cmake f52be3f5e031c73dd7d26296622c14c9d69db42c Diff: https://git.reviewboard.kde.org/r/122313/diff/ Testing --- built, cmake configuration looks ok. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Change in kio[master]: Consolidate find_package calls
Hello Aleix Pol Gonzalez, David Faure,
I'd like you to do a code review. Please visit
https://gerrit.vesnicky.cesnet.cz/r/432
to review the following change.
Change subject: Consolidate find_package calls
..
Consolidate find_package calls
Remove all duplicated find_package calls from 2nd and below level
CMakeLists. One exception is KF5XmlGui, which needs to be found for
autotests; previously it was found through KF5Bookmarks' find_dependency call.
This will fix build against KF5 master with BUILD_TESTING=ON (=default).
Change-Id: I9025505d57fe82438dea8c0270f962bf9fed36cf
---
M CMakeLists.txt
M autotests/CMakeLists.txt
M autotests/http/CMakeLists.txt
M src/filewidgets/CMakeLists.txt
M src/ioslaves/help/CMakeLists.txt
M src/ioslaves/http/CMakeLists.txt
6 files changed, 1 insertion(+), 17 deletions(-)
git pull ssh://gerrit.vesnicky.cesnet.cz:29418/kio refs/changes/32/432/1
diff --git a/CMakeLists.txt b/CMakeLists.txt
index b1cd0e1..577f8c5 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -46,6 +46,7 @@
find_package(KF5IconThemes ${KF5_DEP_VERSION} REQUIRED)
find_package(KF5ItemViews ${KF5_DEP_VERSION} REQUIRED)
find_package(KF5JobWidgets ${KF5_DEP_VERSION} REQUIRED)
+find_package(KF5XmlGui ${KF5_DEP_VERSION} REQUIRED)
find_package(KF5WidgetsAddons ${KF5_DEP_VERSION} REQUIRED)
find_package(KF5WindowSystem ${KF5_DEP_VERSION} REQUIRED)
endif()
diff --git a/autotests/CMakeLists.txt b/autotests/CMakeLists.txt
index 69c8957..1bbcb35 100644
--- a/autotests/CMakeLists.txt
+++ b/autotests/CMakeLists.txt
@@ -8,11 +8,7 @@
add_subdirectory(http)
add_subdirectory(kcookiejar)
-find_package(Qt5Widgets REQUIRED)
-
### unittests ###
-
-find_package(Qt5Concurrent 5.2.0 REQUIRED NO_MODULE)
ecm_add_tests(
kacltest.cpp
diff --git a/autotests/http/CMakeLists.txt b/autotests/http/CMakeLists.txt
index 069d7ae..a55c2cc 100644
--- a/autotests/http/CMakeLists.txt
+++ b/autotests/http/CMakeLists.txt
@@ -1,7 +1,3 @@
-find_package(Qt5Test REQUIRED)
-find_package(Qt5Widgets REQUIRED)
-find_package(KF5Archive ${KF5_DEP_VERSION} REQUIRED)
-
find_package(ZLIB)
set_package_properties(ZLIB PROPERTIES DESCRIPTION Support for gzip
compressed files and data streams
URL http://www.zlib.net;
diff --git a/src/filewidgets/CMakeLists.txt b/src/filewidgets/CMakeLists.txt
index 37c3f26..903baad 100644
--- a/src/filewidgets/CMakeLists.txt
+++ b/src/filewidgets/CMakeLists.txt
@@ -1,8 +1,5 @@
project(KIOFileWidgets)
-find_package(KF5Bookmarks ${KF5_DEP_VERSION} REQUIRED)
-find_package(KF5XmlGui ${KF5_DEP_VERSION} REQUIRED)
-
configure_file(config-kiofilewidgets.h.cmake
${CMAKE_CURRENT_BINARY_DIR}/config-kiofilewidgets.h)
set(kiofilewidgets_SRCS
diff --git a/src/ioslaves/help/CMakeLists.txt b/src/ioslaves/help/CMakeLists.txt
index 8b7b21e..1895669 100644
--- a/src/ioslaves/help/CMakeLists.txt
+++ b/src/ioslaves/help/CMakeLists.txt
@@ -2,7 +2,6 @@
remove_definitions(-DQT_NO_CAST_FROM_ASCII)
-find_package(KF5Archive ${KF5_DEP_VERSION} REQUIRED)
find_package(LibXslt)
set_package_properties(LibXslt PROPERTIES
URL http://xmlsoft.org/XSLT;
@@ -27,8 +26,6 @@
configure_file(config-help.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-help.h )
#macro_additional_clean_files( ${CMAKE_CURRENT_BINARY_DIR}/checkXML )
-
-find_package(Qt5Core 5.2.0 REQUIRED NO_MODULE)
### next target ###
diff --git a/src/ioslaves/http/CMakeLists.txt b/src/ioslaves/http/CMakeLists.txt
index 76a8e28..0066bd1 100644
--- a/src/ioslaves/http/CMakeLists.txt
+++ b/src/ioslaves/http/CMakeLists.txt
@@ -3,9 +3,6 @@
include(ConfigureChecks.cmake)
configure_file(config-kioslave-http.h.cmake
${CMAKE_CURRENT_BINARY_DIR}/config-kioslave-http.h )
-find_package(X11)
-set(HAVE_X11 ${X11_FOUND})
-
if(GSSAPI_FOUND)
set(HAVE_LIBGSSAPI 1)
if(GSSAPI_FLAVOR STREQUAL MIT)
--
To view, visit https://gerrit.vesnicky.cesnet.cz/r/432
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9025505d57fe82438dea8c0270f962bf9fed36cf
Gerrit-PatchSet: 1
Gerrit-Project: kio
Gerrit-Branch: master
Gerrit-Owner: Hrvoje Senjan hrvoje.sen...@gmail.com
Gerrit-Reviewer: Aleix Pol Gonzalez aleix...@kde.org
Gerrit-Reviewer: David Faure fa...@kde.org
Gerrit-Reviewer: Michael Palimaka kensing...@gentoo.org
Gerrit-Reviewer: Patrick Spendrin ps...@gmx.de
Gerrit-Reviewer: Sysadmin Testing Account n...@kde.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120393: [kdelibs4support] Kill dead code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/ --- (Updated March 18, 2015, 7:24 p.m.) Review request for KDE Frameworks, David Faure and Vishesh Handa. Changes --- bring back accidentally removed #else case Repository: kdelibs4support Description --- Strigi check has been removed in commit c8f4c69650c71276b2a2263212addde63764e58b, and soprano wasn't even ported to Qt5 (afaik), so this was never compiled. Diffs (updated) - autotests/kfilemetainfotest.cpp c751cdd src/CMakeLists.txt b662893 src/config-kdelibs4support.h.cmake 1af3ee0 src/kio/kfilemetadataconfigurationwidget.cpp 259b205 src/kio/kfilemetadataprovider.cpp 3468546 src/kio/kfilemetadataprovider_p.h 31137b2 src/kio/kfilemetadatawidget.cpp 1edb069 src/kio/kfilemetainfo.cpp eae1295 src/kio/kfilemetainfoitem.cpp 62f760d src/kio/kfilemetainfoitem_p.h 8929e46 src/kio/knfotranslator.cpp 8eec6a1 Diff: https://git.reviewboard.kde.org/r/120393/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123032: Search for public dep in KPeople's cmake config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123032/ --- (Updated March 18, 2015, 7:30 p.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Changes --- Search only for Qt5Gui, it's used by 'core' KPeople library Repository: kpeople Description --- Both KF5::PeopleBackend and KF5::PeopleWidgets need Qt5Widgets publicly, so search them. Diffs (updated) - KF5PeopleConfig.cmake.in 05ae340 Diff: https://git.reviewboard.kde.org/r/123032/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123030: Let KHtml be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123030/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- Only search for public deps in cmake config Diffs - KF5KHtmlConfig.cmake.in 74e822c Diff: https://git.reviewboard.kde.org/r/123030/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123034: [Plasma-framework] Search for KF5Service in cmake config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123034/ --- Review request for KDE Frameworks and Marco Martin. Repository: plasma-framework Description --- It's a public dep, so make sure it's pulled in for p-f consumers Diffs - KF5PlasmaConfig.cmake.in 48fceb3 Diff: https://git.reviewboard.kde.org/r/123034/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123031: Let Kross be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/ --- Review request for KDE Frameworks. Repository: kross Description --- Only search for public deps in cmake config Diffs - KF5KrossConfig.cmake.in e89cee2 Diff: https://git.reviewboard.kde.org/r/123031/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122313: Expose to world whether KPty has been built with utempter library
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122313/#review77694 --- ping - Hrvoje Senjan On Jan. 29, 2015, 7:54 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122313/ --- (Updated Jan. 29, 2015, 7:54 p.m.) Review request for KDE Frameworks and David Faure. Repository: kpty Description --- Equivalent to https://svn.reviewboard.kde.org/r/2468/ It was lost in KF5 porting, and it was directly used to determine whether kwrited should be built as module, or executable (in this case, it would be a SUID binary, which Qt5 no longer -by default- allows) Diffs - CMakeLists.txt 7fe77da7b0bc97c6f64db4fcc63ef7831fa065b1 KF5PtyConfig.cmake.in 04bde7bffd209b57e755a66278025ee8b6453770 cmake/FindUTEMPTER.cmake PRE-CREATION src/CMakeLists.txt caf2f0ba87ad4173af9860ae369b43d50ffd219f src/ConfigureChecks.cmake f52be3f5e031c73dd7d26296622c14c9d69db42c Diff: https://git.reviewboard.kde.org/r/122313/diff/ Testing --- built, cmake configuration looks ok. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123032: Search for public dep in KPeople's cmake config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123032/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kpeople Description --- Both KF5::PeopleBackend and KF5::PeopleWidgets need Qt5Widgets publicly, so search them. Diffs - KF5PeopleConfig.cmake.in 05ae340 Diff: https://git.reviewboard.kde.org/r/123032/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122828: Be more explicit regarding KBookmarks deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122828/#review77693 --- ping - Hrvoje Senjan On March 5, 2015, 8:41 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122828/ --- (Updated March 5, 2015, 8:41 p.m.) Review request for KDE Frameworks and David Faure. Repository: kbookmarks Description --- this adds KWidetsAddons to public linker flags, but also reduces number of frameworks needed for KBookmarks to be useable. removal of kconfig.h could be considered a minor SiC, though e.g. kio kio-extras built fine with this change Diffs - CMakeLists.txt 4b5a25c KF5BookmarksConfig.cmake.in 8a14d7d src/CMakeLists.txt 23e3709 src/kbookmarkimporter.h 3f15040 src/kbookmarkmanager.cpp 7c5fa2d Diff: https://git.reviewboard.kde.org/r/122828/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122828: Be more explicit regarding KBookmarks deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122828/ --- (Updated March 18, 2015, 8:36 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 14ec99b72ec8f71f0b3bf3486808370dea3b8be9 by Hrvoje Senjan to branch master. Repository: kbookmarks Description --- this adds KWidetsAddons to public linker flags, but also reduces number of frameworks needed for KBookmarks to be useable. removal of kconfig.h could be considered a minor SiC, though e.g. kio kio-extras built fine with this change Diffs - CMakeLists.txt 4b5a25c KF5BookmarksConfig.cmake.in 8a14d7d src/CMakeLists.txt 23e3709 src/kbookmarkimporter.h 3f15040 src/kbookmarkmanager.cpp 7c5fa2d Diff: https://git.reviewboard.kde.org/r/122828/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123031: Let Kross be useable w/o searching for private deps
On March 18, 2015, 8:40 p.m., Christophe Giboudeaux wrote: KF5KrossConfig.cmake.in, line 9 https://git.reviewboard.kde.org/r/123031/diff/1/?file=355503#file355503line9 Are you sure ? ./ui/actioncollectionview.h:27:#include QWidget Hrvoje Senjan wrote: this is now similar (reverse) as with kpeople review request. do we find the public deps for all targets, or for the 'minimal' one? Christophe Giboudeaux wrote: Maybe I misunderstood the find_dependency goal but it sounds to me that if you #include a file in your installed header, it becomes de facto a dependency Agreed. But some frameworks have more targets, and one can use only one of those. So i guess the question is (in general), shall the deps for whole framework be searched, or only for the 'core' one? - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/#review77700 --- On March 18, 2015, 9:13 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/ --- (Updated March 18, 2015, 9:13 p.m.) Review request for KDE Frameworks. Repository: kross Description --- Only search for public deps in cmake config Diffs - KF5KrossConfig.cmake.in e89cee2 Diff: https://git.reviewboard.kde.org/r/123031/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123033: [KPackage] Search for KF5CoreAddons in cmake config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123033/ --- Review request for KDE Frameworks and Marco Martin. Repository: kpackage Description --- They are (only) public dep, so make sure they are pulled in for KPackage consumers Diffs - KF5PackageConfig.cmake.in 469f7a7 Diff: https://git.reviewboard.kde.org/r/123033/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120393: [kdelibs4support] Kill dead code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/ --- (Updated March 18, 2015, 7:17 p.m.) Review request for KDE Frameworks, David Faure and Vishesh Handa. Changes --- remove dead code instead Summary (updated) - [kdelibs4support] Kill dead code Repository: kdelibs4support Description (updated) --- Strigi check has been removed in commit c8f4c69650c71276b2a2263212addde63764e58b, and soprano wasn't even ported to Qt5 (afaik), so this was never compiled. Diffs (updated) - autotests/kfilemetainfotest.cpp c751cdd src/CMakeLists.txt b662893 src/config-kdelibs4support.h.cmake 1af3ee0 src/kio/kfilemetadataconfigurationwidget.cpp 259b205 src/kio/kfilemetadataprovider.cpp 3468546 src/kio/kfilemetadataprovider_p.h 31137b2 src/kio/kfilemetadatawidget.cpp 1edb069 src/kio/kfilemetainfo.cpp eae1295 src/kio/kfilemetainfoitem.cpp 62f760d src/kio/kfilemetainfoitem_p.h 8929e46 src/kio/knfotranslator.cpp 8eec6a1 Diff: https://git.reviewboard.kde.org/r/120393/diff/ Testing (updated) --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123031: Let Kross be useable w/o searching for private deps
On March 18, 2015, 8:40 p.m., Christophe Giboudeaux wrote: KF5KrossConfig.cmake.in, line 9 https://git.reviewboard.kde.org/r/123031/diff/1/?file=355503#file355503line9 Are you sure ? ./ui/actioncollectionview.h:27:#include QWidget this is now similar (reverse) as with kpeople review request. do we find the public deps for all targets, or for the 'minimal' one? - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/#review77700 --- On March 18, 2015, 9:13 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/ --- (Updated March 18, 2015, 9:13 p.m.) Review request for KDE Frameworks. Repository: kross Description --- Only search for public deps in cmake config Diffs - KF5KrossConfig.cmake.in e89cee2 Diff: https://git.reviewboard.kde.org/r/123031/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123031: Let Kross be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/ --- (Updated March 18, 2015, 9:13 p.m.) Review request for KDE Frameworks. Changes --- search Qt5Widgets also Repository: kross Description --- Only search for public deps in cmake config Diffs (updated) - KF5KrossConfig.cmake.in e89cee2 Diff: https://git.reviewboard.kde.org/r/123031/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123034: [Plasma-framework] Search for KF5Service in cmake config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123034/ --- (Updated March 18, 2015, 8:28 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Marco Martin. Changes --- Submitted with commit ca1e2377fbf98f2bb5567c6984d55e0fefb34bc0 by Hrvoje Senjan to branch master. Repository: plasma-framework Description --- It's a public dep, so make sure it's pulled in for p-f consumers Diffs - KF5PlasmaConfig.cmake.in 48fceb3 Diff: https://git.reviewboard.kde.org/r/123034/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123033: [KPackage] Search for KF5CoreAddons in cmake config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123033/ --- (Updated March 18, 2015, 8:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Marco Martin. Changes --- Submitted with commit b7a966a737b11278128d86f6d384d7aee96699d1 by Hrvoje Senjan to branch master. Repository: kpackage Description --- They are (only) public dep, so make sure they are pulled in for KPackage consumers Diffs - KF5PackageConfig.cmake.in 469f7a7 Diff: https://git.reviewboard.kde.org/r/123033/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122958: Let KTextWidgets be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122958/ --- Review request for KDE Frameworks and Laurent Montel. Repository: ktextwidgets Description --- KF5Completion, KF5ConfigWidgets, KF5IconThemes, KF5Service and KF5WindowSystem are all private deps, don't search for them in config Diffs - KF5TextWidgetsConfig.cmake.in 4a550f7 Diff: https://git.reviewboard.kde.org/r/122958/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122955: Let KNotifyConfig be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122955/ --- (Updated March 14, 2015, 8:25 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Edmundson. Changes --- Submitted with commit 7f6306cc303bbca636d4c8f1e035d377fdaa419b by Hrvoje Senjan to branch master. Repository: knotifyconfig Description --- KF5KIO and KF5I18n are private deps, don't search for them in config Diffs - KF5NotifyConfigConfig.cmake.in e44bd62 Diff: https://git.reviewboard.kde.org/r/122955/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122954: Let KNotifications be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122954/ --- (Updated March 14, 2015, 8:23 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit 20fb23c58d5b94e652c476372d1d8f61bf48f0fc by Hrvoje Senjan to branch master. Repository: knotifications Description --- KF5WindowSystem isn't public dep, no need to find it as such Diffs - KF5NotificationsConfig.cmake.in 0466797 Diff: https://git.reviewboard.kde.org/r/122954/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122960: Let KXmlGui be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122960/ --- (Updated March 15, 2015, 1:50 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 842cf9872c9db0c1618b919feeec8f04d657c4f9 by Hrvoje Senjan to branch master. Repository: kxmlgui Description --- KF5GlobalAccel, KF5IconThemes, KF5ItemViews, KF5TextWidgets, KF5WindowSystem and KF5Attica are all private deps, don't search for them in config Diffs - KF5XmlGuiConfig.cmake.in cb0e66f Diff: https://git.reviewboard.kde.org/r/122960/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122959: Minor cleanup of KWallet private/public deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122959/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet Description --- (only) QtGui is used publicly, so make the buildsystem also recognize that Diffs - src/api/KWallet/CMakeLists.txt 9709559 src/api/KWallet/KF5WalletConfig.cmake.in 7851ea1 tests/KWallet/CMakeLists.txt b155f64 Diff: https://git.reviewboard.kde.org/r/122959/diff/ Testing --- builds Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122953: Let KNewStuff be useable w/o searching for private deps
On March 14, 2015, 8:10 p.m., Jeremy Whiting wrote: I'm not sure I understand what this is for. If you try to build with knewstuff and kio and karchive aren't present, it wont run properly. Is this to make stuff that uses knewstuff build when the dependencies are there, but their headers are missing or something? Hrvoje Senjan wrote: if i want to implement something with knewstuff, in principle i shouldn't need karchive and kio headers, etc. - unless i want also access to their API, but then i'll search for them explicitly. this mostly makes a difference for packagers, and users of packages; frameworks devs will have all of KF5 built anyway. Christoph Feck wrote: Can you be more explicit regarding packages? Does that mean that e.g. installing knewstuff-devel does no longer drag in kio-devel? yes, that is the idea. kio-devel shall be needed to build knewstuff, but knewstuff-devel wouldn't anymore require kio-devel - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122953/#review77472 --- On March 14, 2015, 8:06 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122953/ --- (Updated March 14, 2015, 8:06 p.m.) Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- KF5Archive and KF5KIO are private deps, don't search for them in config Diffs - KF5NewStuffConfig.cmake.in bbbfdd0 Diff: https://git.reviewboard.kde.org/r/122953/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122952: Let KIconThemes be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122952/ --- (Updated March 14, 2015, 8:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit dc49bca7426f2ad9518364900407ee06a2e096cb by Hrvoje Senjan to branch master. Repository: kiconthemes Description --- Only Qt5::Widgets are public, so let the config searches only them Diffs - KF5IconThemesConfig.cmake.in 2eab79c Diff: https://git.reviewboard.kde.org/r/122952/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122959: Minor cleanup of KWallet private/public deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122959/ --- (Updated March 14, 2015, 8:37 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Valentin Rusu. Changes --- Submitted with commit 6259a4c9bf71d451784e65909460aecf794b31e6 by Hrvoje Senjan to branch master. Repository: kwallet Description --- (only) QtGui is used publicly, so make the buildsystem also recognize that Diffs - src/api/KWallet/CMakeLists.txt 9709559 src/api/KWallet/KF5WalletConfig.cmake.in 7851ea1 tests/KWallet/CMakeLists.txt b155f64 Diff: https://git.reviewboard.kde.org/r/122959/diff/ Testing --- builds Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122951: Let KEmoticons be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122951/ --- (Updated March 15, 2015, 1:56 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 2f47d9308a952f765c2752728733c9404e77bd47 by Hrvoje Senjan to branch master. Repository: kemoticons Description --- KF5Archive isn't public dep, no need to find it as such Diffs - KF5EmoticonsConfig.cmake.in 7c1ac47 Diff: https://git.reviewboard.kde.org/r/122951/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122956: Let KParts be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122956/ --- (Updated March 15, 2015, 1:55 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit af6342fe8a938558ed6a04f8f644e44ea5a5a935 by Hrvoje Senjan to branch master. Repository: kparts Description --- KF5Notifications isn't public dep, no need to find it as such Diffs - KF5PartsConfig.cmake.in d501254 Diff: https://git.reviewboard.kde.org/r/122956/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122960: Let KXmlGui be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122960/ --- Review request for KDE Frameworks. Repository: kxmlgui Description --- KF5GlobalAccel, KF5IconThemes, KF5ItemViews, KF5TextWidgets, KF5WindowSystem and KF5Attica are all private deps, don't search for them in config Diffs - KF5XmlGuiConfig.cmake.in cb0e66f Diff: https://git.reviewboard.kde.org/r/122960/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122953: Let KNewStuff be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122953/ --- (Updated March 14, 2015, 8:23 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit 2db4df1d650951bd46fb6bafe38d3ddc741c425e by Hrvoje Senjan to branch master. Repository: knewstuff Description --- KF5Archive and KF5KIO are private deps, don't search for them in config Diffs - KF5NewStuffConfig.cmake.in bbbfdd0 Diff: https://git.reviewboard.kde.org/r/122953/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122952: Let KIconThemes be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122952/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description --- Only Qt5::Widgets are public, so let the config searches only them Diffs - KF5IconThemesConfig.cmake.in 2eab79c Diff: https://git.reviewboard.kde.org/r/122952/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122956: Let KParts be useable w/o searching for private deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122956/ --- Review request for KDE Frameworks and David Faure. Repository: kparts Description --- KF5Notifications isn't public dep, no need to find it as such Diffs - KF5PartsConfig.cmake.in d501254 Diff: https://git.reviewboard.kde.org/r/122956/diff/ Testing --- Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
