[Differential] [Request, 69 lines] D4628: Add ability to disable saving in `KTextEditor::Document`

russellg created this revision. russellg set the repository for this revision to R39 KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY I'm currently writing an application where the user is

Re: Suggestion to Remove KFloppy and hold back K3b

Am 15. Februar 2017 23:58:50 MEZ schrieb Wolfgang Bauer : >Am Mittwoch, 15. Februar 2017, 22:21:19 schrieb Martin Gräßlin: >> Please do not consider starting a GUI application as root a >possibility. > >Ok, but partitionmanager does exactly that. It restarts itself as root >if run

[Differential] [Updated, 70 lines] D4628: Add ability to disable saving in `KTextEditor::Document`

russellg removed R39 KTextEditor as the repository for this revision. russellg updated this revision to Diff 11390. russellg added a comment. Updated the test to be slightly better. Use `QVERIFY(...)` instead of `QCOMPARE(..., true)` in one case, and make sure that `saveEnabled()` is false

[Differential] [Commented On] D4537: EditorConfig support

dhaumann added a comment. Patch looks already pretty good, I think we're soon there. INLINE COMMENTS > gszymaszek wrote in editorconfig.cpp:23 > Is it OK to initialize `m_handle` in the constructor? If so, is `m_handle(0)` > necessary? Yes, this is good now. > editorconfig.cpp:34-56 >

[Differential] [Updated, 259 lines] D4537: EditorConfig support

gszymaszek updated this revision to Diff 11365. gszymaszek marked 2 inline comments as done. gszymaszek added a comment. Pulled check-variable-functions out of EditorConfig class, moved some variable definitions into main loop of parser. REPOSITORY R39 KTextEditor CHANGES SINCE LAST

[Differential] [Updated, 259 lines] D4537: EditorConfig support

gszymaszek updated this revision to Diff 11366. gszymaszek added a comment. key and value are const. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4537?vs=11365=11366 REVISION DETAIL https://phabricator.kde.org/D4537 AFFECTED FILES CMakeLists.txt

[Differential] [Closed] D3826: Detect inotify.

This revision was automatically updated to reflect the committed changes. adridg marked 2 inline comments as done. Closed by commit R240:a02c4d0152a7: Detect inotify. (authored by adridg). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.

This revision was automatically updated to reflect the committed changes. Closed by commit R159:d2cbef5d94f3: Add Boost_INCLUDE_DIR to kactivities-stats autotests. (authored by adridg). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.

adridg added a comment. I'm going to claim feedback timeout, plus all it does is add some -I flags when compiling the tests. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D4248 EMAIL PREFERENCES

[Differential] [Request, 13 lines] D4620: allow to add application actions on an open menu

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY even if the menu has already been created, cause setapplicationActions to add actions in

[Differential] [Updated, 283 lines] D4576: [WIP]: integrate drop menu and filecopy drop menu

mart updated this revision to Diff 11368. mart added a comment. - use dropjobs instead of directly accessing its qmenu REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4576?vs=11307=11368 BRANCH arcpatch-D4576 REVISION DETAIL

Re: Review Request 128664: Nested tags for Baloo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/ --- (Updated Feb. 15, 2017, 1:26 p.m.) Review request for Baloo and

[Differential] [Commented On] D4584: KDirWatch: replace QList by std::vector to save on new/delete.

smartins added inline comments. INLINE COMMENTS > dfaure wrote in kdirwatch.cpp:1379 > Detaches? a std::vector? doh! REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4584 EMAIL PREFERENCES

Re: Review Request 128665: Nested tags for Baloo Widgets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128665/ --- (Updated Feb. 15, 2017, 1:26 p.m.) Review request for Baloo. Changes

[Differential] [Commented On] D4414: don't regenerate frames when setting every property

drosca added a comment. I now get tons of binding loop errors from FrameSvgItem, it also breaks delegates in networkmanager and bluetooth applets. On the screenshot you can see that the last 3 delegates (HUAWEI, UPC and Internet) are slightly moved to the left and hovering over them will

[Differential] [Changed Subscribers] D4584: KDirWatch: replace QList by std::vector to save on new/delete.

smartins added inline comments. INLINE COMMENTS > kdirwatch.cpp:1379 > > -Q_FOREACH (Client *c, e->m_clients) { > -if (c->instance == nullptr || c->count == 0) { > +for (Client : e->m_clients) { > +if (c.instance == nullptr || c.count == 0) { can m_clients be shared ?

[Differential] [Accepted] D4584: KDirWatch: replace QList by std::vector to save on new/delete.

mwolff accepted this revision. mwolff added a reviewer: mwolff. mwolff added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dfaure wrote in kdirwatch_p.h:84 > Given that the same thing happens by default, what would be the reason to > make it explicit?

[Differential] [Updated, 11 lines] D4620: allow to add application actions on an open menu

mart updated this revision to Diff 11371. mart added a comment. - remove useless signal REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4620?vs=11369=11371 BRANCH phab/setActionsLater REVISION DETAIL https://phabricator.kde.org/D4620 AFFECTED FILES

[Differential] [Commented On] D4620: allow to add application actions on an open menu

hein added a comment. Much nicer than the other approach, just one question. INLINE COMMENTS > dropjob.cpp:324 > +for (QMenu *menu : d->m_menus) { > +if (!d->m_appActions.isEmpty() || !d->m_pluginActions.isEmpty()) { > +menu->addSeparator(); Should this be && instead

[Differential] [Abandoned] D4575: add a popupmenuabouttoshow version that exposes the menu

mart abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4575 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: hein, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[Differential] [Request, 799 lines] D4625: Icons for Plasma Vault

ivan created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Merge branch 'master' into ivan/plasmavault-icons REPOSITORY R266 Breeze Icons BRANCH ivan/plasmavault-icons REVISION DETAIL

[Differential] [Request, 958 lines] D4626: Renamed icons for encrypted and decripted folders

ivan created this revision. ivan added reviewers: alex-l, andreaska. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Since the icons are in places, not in actions, changed the names to imply state, not action.

[Differential] [Accepted] D4626: Renamed icons for encrypted and decripted folders

andreaska accepted this revision. andreaska added a comment. This revision is now accepted and ready to land. good point. If you want to use this icons I'll make them for the other places size. REPOSITORY R266 Breeze Icons BRANCH ivan/rename-icons REVISION DETAIL

[Differential] [Request, 3 lines] D4624: Added arc config file

ivan created this revision. ivan added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Added arc configuration file REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4624 AFFECTED FILES .arcconfig

[Differential] [Closed] D4624: Added arc config file

This revision was automatically updated to reflect the committed changes. Closed by commit R266:bc60e3c2f85f: Added arc config file (authored by ivan). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4624?vs=11382=11383 REVISION DETAIL

Re: Suggestion to Remove KFloppy and hold back K3b

Am 2017-02-15 19:50, schrieb Wolfgang Bauer: On 11 February 2017 at 13:44, Jonathan Riddell wrote: I recommend KFloppy be removed from Applications releases. It couldn't find my floppy drive and when I hacked the code to tell it where to look it depended on an external tool

[Differential] [Closed] D4626: Renamed icons for encrypted and decripted folders

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b79085c027c0: Renamed icons for encrypted and decripted folders (authored by ivan). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4626?vs=11385=11386#toc REPOSITORY R266 Breeze Icons

Re: Suggestion to Remove KFloppy and hold back K3b

Am Mittwoch, 15. Februar 2017, 21:55:12 schrieb Boudhayan Gupta: > What would you say about using Solid to probe floppy drives? I think > Solid already has the necessary hooks, but if it doesn't, we can add > them. Sounds interesting. Thanks for the suggestion. I will have a look at that too.

[Differential] [Commented On] D4626: Renamed icons for encrypted and decripted folders

ivan added a comment. I will use them, but don't do that just yet - I want to propose some changes to them. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4626 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, alex-l,

Re: Suggestion to Remove KFloppy and hold back K3b

Am Mittwoch, 15. Februar 2017, 22:21:19 schrieb Martin Gräßlin: > Please do not consider starting a GUI application as root a possibility. Ok, but partitionmanager does exactly that. It restarts itself as root if run as user. So that instantly would rule out partionmanager as a proposed

[Differential] [Commented On] D4584: KDirWatch: replace QList by std::vector to save on new/delete.

dfaure added inline comments. INLINE COMMENTS > smartins wrote in kdirwatch.cpp:1379 > can m_clients be shared ? If yes, htis detaches Detaches? a std::vector? > mwolff wrote in kdirwatch_p.h:84 > right, but that's what you want to state here, no? anyhow, I'm also OK with > leaving it as-is

[Differential] [Changed Subscribers] D4620: allow to add application actions on an open menu

dfaure added inline comments. INLINE COMMENTS > hein wrote in dropjob.cpp:324 > Should this be && instead of ||? "Add actions if either of those is not > empty" seems weird, what's the reasoning? It's a copy of the if() on line 311. But there it makes sense. Here not so much ;) What if there

Re: Suggestion to Remove KFloppy and hold back K3b

On 11 February 2017 at 13:44, Jonathan Riddell wrote: > I recommend KFloppy be removed from Applications releases. It > couldn't find my floppy drive and when I hacked the code to tell it > where to look it depended on an external tool fdformat which didn't > work anyway.

Re: Suggestion to Remove KFloppy and hold back K3b

Wolfgang Bauer ha scritto: > Am Mittwoch, 15. Februar 2017, 22:21:19 schrieb Martin Gräßlin: >> Please do not consider starting a GUI application as root a possibility. > > Ok, but partitionmanager does exactly that. It restarts itself as root if run > as user. > So that instantly would rule out

[Differential] [Request, 14 lines] D4619: Printing: Respect footer font, fix footer vertical position, make header/footer separator line visually lighter

atomsymbol created this revision. atomsymbol added a reviewer: kfunk. atomsymbol set the repository for this revision to R39 KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Fixes bug 376060