D7078: [server] Fix crash when sending selection to a DDI without a DataSource

davidedmundson added a comment. I don't think we did go in there because we have a selection, otherwise other->selection() wouldn't be null. If we want DDI::sendSelection(DDI *other) to always keep the client in sync we should do: auto selection = other->selection(); if

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/47/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 17:17:19 + Build duration: 21 min and counting

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

graesslin added a comment. ping! This is a crash fix. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol,

D7216: refactor kpackagetool away from stringy options

apol added a comment. if that makes you happy, it makes me happy. +1 REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D7216 To: sitter, sebas, apol Cc: #frameworks

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

graesslin added a comment. > the send_selection spec says we should be passing a null resource if we have no selection, whereas this version creates a data offer with nothing in it. But we have a selection, that's the point. We just don't have a datasource on the selection.

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

davidedmundson commandeered this revision. davidedmundson edited reviewers, added: matank; removed: davidedmundson. davidedmundson added a comment. > I can confrim that mart's patch ( https://phabricator.kde.org/D7127) solves the issue. I'll close this . REPOSITORY R242 Plasma

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

davidedmundson abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7071 To: davidedmundson, #plasma, matank Cc: mart, plasma-devel, davidedmundson, ltoscano, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7058: Initialize the "Pause" button state in the widget tracker

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D7058 To: apol, #frameworks, dfaure Cc: aacid

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/50/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 06:39:29 + Build duration: 17 min and counting JUnit Tests

D7045: Remove busy loop check in TransferJobPrivate::slotDataReqFromDevice

dfaure added a comment. isn't this about the case where there is more data available than MAX_READ_BUF_SIZE, so we didn't read it all and we need to loop around to read the rest? OK, that's not what the if says, but I think that's still one case where we need to loop. So maybe it should

D7153: Drop broken mid-button click handling

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah, hmm, I used to use that feature. E.g. in konqueror, just like an MMB click would open links in a different tab, MMB on the back button would open the previous page in a different tab.

D7196: Fix accepting dialogs with ctrl+return when buttons are renamed

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D7196 To: apol, #frameworks, dfaure

D7094: Include a module for finding qml imports as runtime dependencies

sitter added inline comments. INLINE COMMENTS > apol wrote in ECMFindQMLModule.cmake.in:30 > Doing find_program for now. The right fix would be to change Qt to export the > `qmlplugindump` target. You still need to do "something" if qmlplugindump isn't found. Print a `message(WARNING` and/or

Re: Building games.

Hi Shashwat, On 09/08/2017, at 7:27 AM, Shashwat Mishra wrote: > I am actually not sure how one can build games that use mouse to interact > with it on C++? First, continue this discussion on KDE games development . Re the use of the mouse, first you need to get

D7058: Initialize the "Pause" button state in the widget tracker

This revision was automatically updated to reflect the committed changes. Closed by commit R288:35b442449166: Initialize the "Pause" button state in the widget tracker (authored by apol). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7058?vs=17531=17920

D7094: Include a module for finding qml imports as runtime dependencies

apol updated this revision to Diff 17922. apol added a comment. if no qmlplugindump REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7094?vs=17911=17922 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7094 AFFECTED FILES

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux Cc: #frameworks, #build_system

D7196: Fix accepting dialogs with ctrl+return when buttons are renamed

This revision was automatically updated to reflect the committed changes. Closed by commit R252:7524bf1535b4: Fix accepting dialogs with ctrl+return when buttons are renamed (authored by apol). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D7094: Include a module for finding qml imports as runtime dependencies

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Oh it's gorgeous! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7094 To: apol, #build_system, #frameworks, sitter Cc: dfaure, aacid

D7094: Include a module for finding qml imports as runtime dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit R240:e5301edf1daf: Include a module for finding qml imports as runtime dependencies (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/37/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 11:10:29 + Build duration: 2 min 35 sec and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/46/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 11:10:29 + Build duration: 2 min 28 sec and counting

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

kfunk accepted this revision. kfunk added a comment. I like the initiative, +1 REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: kfunk, #frameworks, #build_system

D6774: Fix labels of DeleteFile/RenameFile actions

This revision was automatically updated to reflect the committed changes. Closed by commit R265:b0a481e66905: Fix labels of DeleteFile/RenameFile actions (authored by elvisangelaccio). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6774?vs=17901=17942

KDE CI: Frameworks kconfig kf5-qt5 XenialQt5.7 - Build # 26 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20XenialQt5.7/26/ Project: Frameworks kconfig kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 20:35:14 + Build duration: 42 sec and counting CONSOLE OUTPUT

D6775: Fix labels of DeleteFile/RenameFile actions

This revision was automatically updated to reflect the committed changes. Closed by commit R237:0a166cb2b421: Fix labels of DeleteFile/RenameFile actions (authored by elvisangelaccio). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6775?vs=16884=17944

KDE CI: Frameworks kconfigwidgets kf5-qt5 XenialQt5.7 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20XenialQt5.7/21/ Project: Frameworks kconfigwidgets kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 20:28:49 + Build duration: 1 min 20 sec and counting

D6775: Fix labels of DeleteFile/RenameFile actions

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. The StandardShortcut enum is seriously lacking documentation (for each enum value)... REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D6775 To:

D7153: Drop broken mid-button click handling

This revision was automatically updated to reflect the committed changes. Closed by commit R263:c47154c9fbdb: Drop broken mid-button click handling (authored by elvisangelaccio). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7153?vs=17756=17940 REVISION

KDE CI: Frameworks kxmlgui kf5-qt5 XenialQt5.7 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20XenialQt5.7/31/ Project: Frameworks kxmlgui kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 20:00:47 + Build duration: 59 sec and counting CONSOLE OUTPUT

konqueror5/Mac : kf5.kio.widgets: KonqRun(x) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist."

Hi, Not sure where to ask about this: I recently upgraded to frameworks 5.35.0 and applications 17.04.2 . I don't think I tested konqueror5 with a remote website (on Mac), and discover today that it fails with terminal errors of the style kf5.kio.widgets: KonqRun(0x7f89f7dd9db0) ERROR (stat):

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

graesslin added a comment. In https://phabricator.kde.org/D7078#134111, @davidedmundson wrote: > Isn't the real bug from that trace here: > > datadevice_interface.cpp:204 > void DataDeviceInterface::sendSelection(DataDeviceInterface *other) >

KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/38/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 17:17:19 + Build duration: 2 min 39 sec and counting

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: kfunk, #frameworks, #build_system

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

davidedmundson added a comment. Isn't the real bug from that trace here: datadevice_interface.cpp:204 void DataDeviceInterface::sendSelection(DataDeviceInterface *other) d->createDataOffer(other->selection()); it's valid for other->selection() to be null, so this should be

D5631: Fix directory based search.

elvisangelaccio added a comment. Any reason why this hasn't been committed yet? REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D5631 To: xuetianweng, #frameworks, lbeltrame Cc: elvisangelaccio, lbeltrame

D7045: Remove busy loop check in TransferJobPrivate::slotDataReqFromDevice

dfaure added a comment. Yes that would be a good idea. AFAICS it's still one good reason to loop around, i.e. it's a possible regression from this patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7045 To: aacid Cc: dfaure, apol, #frameworks

D7045: Remove busy loop check in TransferJobPrivate::slotDataReqFromDevice

aacid added a comment. If you read the code (and the test that was failing once i changed the code), no i don't think it is about that. Do you want me to add a unit test for that scenario? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7045 To: aacid Cc: dfaure,

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/19/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 21:40:29 + Build duration: 1 min 40 sec and counting CONSOLE OUTPUT

D5631: Fix directory based search.

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5f6bd28119c6: Fix directory based search. (authored by xuetianweng). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5631?vs=13905=17950 REVISION DETAIL

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

aacid added a comment. You broke all the builds REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: aacid, kfunk, #frameworks, #build_system

D6775: Fix labels of DeleteFile/RenameFile actions

elvisangelaccio added a reviewer: dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D6775 To: elvisangelaccio, #frameworks, dfaure

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/49/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 23:32:21 + Build duration: 3 min 41 sec and counting

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

cgiboudeaux added a comment. In https://phabricator.kde.org/D7198#134234, @cgiboudeaux wrote: > Fixed with https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498 (+ https://phabricator.kde.org/R240:ef01c93637e1840ee701673970a371c011e36a40) REPOSITORY R240

KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/42/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 23:54:26 + Build duration: 2 min 3 sec and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/39/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 23:23:31 + Build duration: 1 min 58 sec and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/48/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 23:23:31 + Build duration: 2 min 47 sec and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/40/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 23:32:21 + Build duration: 1 min 54 sec and counting

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

cgiboudeaux added a comment. Fixed with https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: aacid, kfunk, #frameworks, #build_system

KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/41/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 23:45:26 + Build duration: 2 min 2 sec and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/50/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 23:45:26 + Build duration: 3 min 33 sec and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/51/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 23:54:26 + Build duration: 2 min 45 sec and counting

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/51/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 10 Aug 2017 02:51:02 + Build duration: 26 min and counting JUnit Tests

KDE CI: Frameworks kparts kf5-qt5 WindowsQt5.7 - Build # 35 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20WindowsQt5.7/35/ Project: Frameworks kparts kf5-qt5 WindowsQt5.7 Date of build: Thu, 10 Aug 2017 02:50:42 + Build duration: 27 min and counting JUnit Tests Name:

D7216: refactor kpackagetool away from stringy options

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY A notable advantage of qcommandlineoption is that using the objects the compiler makes sure that everyone is talking about the same option.