D10405: Stuff the "Couldn't find executable" message box into a queued lambda

2018-02-13 Thread Eike Hein
hein added a comment. There's a problem with my patch :(. QMetaObject::invokeMethod(context, functor) is new in Qt 5.10. I don't think we can depend on that yet, right? Ah, but QTimer::singleShot added an overload w/ context in 5.4 .. REPOSITORY R241 KIO REVISION DETAIL

D10378: Deprecate KFileItemList and introduce KFileItemListV2

2018-02-13 Thread Mark Gaiser
markg added a comment. @dfaure What's your preference here? I do "want" to work on this, no promises though. It could take a very long while ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10378 To: markg, dfaure Cc: #frameworks, michaelh

D9912: [KNewFileMenu] KDirNotify::emitFilesAdded after storedPut

2018-02-13 Thread David Faure
dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9912 To: broulik, dfaure, ngraham Cc: ngraham, #frameworks, michaelh

D10464: Initialize m_actualGroup to NormalColorGroup

2018-02-13 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D10464 To: apol, #frameworks, dfaure Cc: michaelh

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

2018-02-13 Thread Eike Hein
hein added a comment. (Side note: I like the idea of a KRun job - something like that could even be added without needing a KIO 6.) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart, ngraham Cc: #frameworks, michaelh

D10325: [KFileWidget] Hide places frame and header

2018-02-13 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > apol wrote in kfilewidget.cpp:1351 > Does it really make sense that it's a dock if it can't be interacted with? I don't know. You can still resize the panel, I also wanted to keep the patch as unintrusive as possible. REPOSITORY R241 KIO

D10054: Fix: View jumps when Scroll past end of document is enabled

2018-02-13 Thread Dominik Haumann
dhaumann added a comment. Question is: what happens in the vi test? Did we really introduce a regression or is the test wrong? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham,

How to temporarily change KConfig-data for a unit test?

2018-02-13 Thread Michael Heidelbach
Hi! Currently I'm working on baloo-widgets. For a unit test I need to temporarily change KConfig data. My approach would be like this: initTestCase()     KConfig config("baloofileinformationrc", KConfig::NoGlobals);     KConfigGroup settings = config.group("Show");         set everything

D10380: Refactor KCoreDirLister(Cache) to use KFileItemListV2 where possible.

2018-02-13 Thread Mark Gaiser
markg abandoned this revision. markg added a comment. As this is a no-go, rightfully so! Abandoning it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10380 To: markg, dfaure Cc: #frameworks, michaelh

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

2018-02-13 Thread Eike Hein
hein updated this revision to Diff 27048. hein added a comment. - Fall back to qWarning if !qGuiApp - Use QTimer::singleShot to work on older Qt REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10405?vs=27046=27048 BRANCH master REVISION DETAIL

D10437: Limit the use of file.so for privilege operation to one application

2018-02-13 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. @dfaure I was thinking about revoking authorization just before the idle slave is reassigned by klauncher. polkit-qt-1 provides `revokeTemporaryAuthorization` just for this purpose. We only need to implement it on KAuth's side. Then on slave's side we can do

D9912: [KNewFileMenu] KDirNotify::emitFilesAdded after storedPut

2018-02-13 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:8b809b715f09: [KNewFileMenu] KDirNotify::emitFilesAdded after storedPut (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9912?vs=25446=27042

D10414: Add move semantics support to KIO::UDSEntry.

2018-02-13 Thread Mark Gaiser
markg added a comment. Ahh, will fix that when i get home. I missed the @since lines in KFileITem as well. Is it OK if i just add them outside of phabricator? They will get an "@since 5.43" i think. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To: markg,

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-13 Thread David Faure
dfaure added a comment. What? no no, KIO::defaultJobUiDelegateExtension()->requestMessageBox() is a kind of singleton, no refactoring needed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart, ngraham Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-13 Thread David Faure
dfaure added a comment. Which plugins? This stuff is for the application to decide how it wants to handle user interactions like the rename dialog, the skip dialog, the confirm-deletion dialog, and messageboxes. KIOWidgets provides a default implementation (with modal dialogs), but it

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 133 - Still Unstable!

2018-02-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/133/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 13 Feb 2018 08:54:07 + Build duration: 9 min 38 sec and counting JUnit Tests Name:

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

2018-02-13 Thread Eike Hein
hein retitled this revision from "Don't proceed in runCommandInternal if the executable doesn't exit" to "Stuff the "Couldn't find executable" message box into a queued lambda". hein edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

2018-02-13 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > krun.cpp:1616 > // (or with a full path, if m_executable is absolute), and then in > the PATH. > -if (!QFile(m_executable).exists() && > QStandardPaths::findExecutable(m_executable).isEmpty()) { > -QEventLoopLocker

D10414: Add move semantics support to KIO::UDSEntry.

2018-02-13 Thread David Faure
dfaure added a comment. Yes. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To: markg, dfaure Cc: apol, #frameworks, michaelh

D7849: Fix the tray icon scaling on HiDPI screens

2018-02-13 Thread Alexander Potashev
aspotashev added a comment. related bug report: https://bugs.kde.org/show_bug.cgi?id=360333 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: aspotashev, ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson,

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-13 Thread Eike Hein
hein added a comment. It's totally conceivable for e.g. a KPart or a Plasma plugin to open a QWidget-based window where the KMessageBox is appropriate, and if there's only a global interface instance and Plasma overrides it to hide all message boxes it's going to break KIO users in plugins.

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.7 - Build # 38 - Fixed!

2018-02-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.7/38/ Project: Frameworks knewstuff kf5-qt5 SUSEQt5.7 Date of build: Tue, 13 Feb 2018 09:40:21 + Build duration: 3 min 24 sec and counting JUnit Tests

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-13 Thread Eike Hein
hein added a comment. Thanks for the solution for sure, but - it requires writing a million lines of boilerplate, extensively refactoring KRun and adding reams of new overloads to its API (there would need to be some way to pass an instance of that interface to all these - not internal -

D10414: Add move semantics support to KIO::UDSEntry.

2018-02-13 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Sorry, just spotted one last typo (and two missing @since), feel free to push after fixing. INLINE COMMENTS > udsentrytest.cpp:231 > +{ > +// Create a temporaty file. Just

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 113 - Still Unstable!

2018-02-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/113/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Feb 2018 08:54:07 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 131 - Still Unstable!

2018-02-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/131/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Tue, 13 Feb 2018 08:54:07 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.7 - Build # 37 - Failure!

2018-02-13 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.7/37/ Project: Frameworks knewstuff kf5-qt5 SUSEQt5.7 Date of build: Mon, 12 Feb 2018 04:15:55 + Build duration: 1 day 5 hr and counting CONSOLE OUTPUT

D10437: Limit the use of file.so for privilege operation to one application

2018-02-13 Thread David Faure
dfaure added a comment. Sounds good, but the tricky part will be finding how to run some code in the (idle) slave at the right time. Maybe in SlaveBase::disconnectSlave() ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10437 To: chinmoyr, #frameworks, dfaure, fvogt

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-13 Thread Eike Hein
hein updated this revision to Diff 27046. hein added a comment. New approach. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10405?vs=26821=27046 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10405 AFFECTED FILES src/widgets/krun.cpp To:

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-13 Thread Eike Hein
hein added a comment. There's a Job::setUiDelegateExtension though in addition to KIO::setDefaultJobUiDelegateExtension. A global would wreak havoc with stuff like plugins, no? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson,

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 37 - Still Unstable!

2018-02-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/37/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Feb 2018 14:32:30 + Build duration: 43 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 61 - Still Unstable!

2018-02-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/61/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 13 Feb 2018 14:32:30 + Build duration: 12 min and counting JUnit

D10464: Initialize m_actualGroup to NormalColorGroup

2018-02-13 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:581dc48ff836: Initialize m_actualGroup to NormalColorGroup (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Re: How to temporarily change KConfig-data for a unit test?

2018-02-13 Thread Aleix Pol
On Tue, Feb 13, 2018 at 1:14 PM, Michael Heidelbach wrote: > Hi! > > Currently I'm working on baloo-widgets. For a unit test I need to > temporarily change KConfig data. > > My approach would be like this: > > initTestCase() > > KConfig config("baloofileinformationrc",

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 64 - Still Unstable!

2018-02-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/64/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 13 Feb 2018 14:32:30 + Build duration: 11 min and counting JUnit

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz added a comment. In D8056#205614 , @ngraham wrote: > interspersing the CLI command and application filtering would be a mistake. Say I type `kate`. Am I intending to use the `kate` command, or select the "Kate" app? It's ambiguous if we

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz updated this revision to Diff 27079. simgunz added a comment. - Fix OK button not disabled when category is selected - Fix cannot accept selection if filter line edit is empty REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8056?vs=24488=27079 BRANCH

D10450: Generate a custom target in kcoreaddons_desktop_to_json

2018-02-13 Thread Friedrich W . H . Kossebau
kossebau added a comment. To add some code to my words, a proposed fix for the detected unneeded json file and separate cmdl tool dependency now up here: https://phabricator.kde.org/D10485 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz added a comment. Fixed the problems reported by @rkflx hopefully without introducing new ones. I did some testing and now everything seems ok, but please check again. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. interspersing the CLI command and application filtering would be a mistake. Say I type `kate`. Am I intending to use the `kate` command, or select the "Kate" app? It's ambiguous if we use one text field for both. REPOSITORY R241 KIO REVISION DETAIL

D7849: Fix the tray icon scaling on HiDPI screens

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. Does this actually fully fix https://bugs.kde.org/show_bug.cgi?id=360333? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: aspotashev, ngraham, anthonyfieroni, broulik, #frameworks,

Re: How to temporarily change KConfig-data for a unit test?

2018-02-13 Thread Michael Heidelbach
On 13.02.2018 15:42, Aleix Pol wrote: On Tue, Feb 13, 2018 at 1:14 PM, Michael Heidelbach wrote: Hi! Currently I'm working on baloo-widgets. For a unit test I need to temporarily change KConfig data. My approach would be like this: initTestCase() KConfig

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz added a comment. The tooltip of the line edit now says: `Type some text to filter the application tree.\nPress down arrow to navigate the results tree.` I suggest to change it to: `Type to filter the application tree or type the name of a command.\nPress down arrow to navigate the

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. It's been a while since I tested (could you re-based it on current master?), but I was under the impression that the text box gave priority to the app filtering unless you checked the semi-hidden option to enable command-line completion instead. REPOSITORY R241

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz updated this revision to Diff 27084. simgunz added a comment. - Automatically select first match of the filter - ArrowDown on lineEdit pass focus to QTreeView - Add tooltip to explain how to use the search filter - Fix code styling - Set appModel and proxyModel together, store

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz added a comment. I rebased to master and updated the review. I hope I didn't messed up anything. In D8056#205621 , @ngraham wrote: > I was under the impression that the text box gave priority to the app filtering unless you checked

D10365: New icon for Elisa music player

2018-02-13 Thread Andreas Kainz
andreask added a comment. can we get it now to master? @paullesur is hopefully interested in other icon's too. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10365 To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien Cc: mmustac,

Re: How to temporarily change KConfig-data for a unit test?

2018-02-13 Thread Michael Heidelbach
On 13.02.2018 20:38, Martin Flöser wrote: Am 2018-02-13 15:42, schrieb Aleix Pol: On Tue, Feb 13, 2018 at 1:14 PM, Michael Heidelbach wrote: Hi! Currently I'm working on baloo-widgets. For a unit test I need to temporarily change KConfig data. My approach would be like

D10054: Fix: View jumps when Scroll past end of document is enabled

2018-02-13 Thread Christoph Cullmann
cullmann added a comment. No idea ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 51 - Unstable!

2018-02-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/51/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 13 Feb 2018 20:37:37 + Build duration: 8 min 38 sec and counting JUnit Tests

Re: How to temporarily change KConfig-data for a unit test?

2018-02-13 Thread Martin Flöser
Am 2018-02-13 15:42, schrieb Aleix Pol: On Tue, Feb 13, 2018 at 1:14 PM, Michael Heidelbach wrote: Hi! Currently I'm working on baloo-widgets. For a unit test I need to temporarily change KConfig data. My approach would be like this: initTestCase() KConfig

D10492: add 64px media icons for elisa

2018-02-13 Thread Andreas Kainz
andreask created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. andreask requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10492 AFFECTED

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 51 - Unstable!

2018-02-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/51/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 13 Feb 2018 20:37:38 + Build duration: 2 min 37 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 48 - Unstable!

2018-02-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/48/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Feb 2018 20:37:37 + Build duration: 3 min 28 sec and counting JUnit

D10494: update handle- icons for kirigami

2018-02-13 Thread Andreas Kainz
andreask created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. andreask requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10494 AFFECTED

D10492: add 64px media icons for elisa

2018-02-13 Thread Andreas Kainz
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:6800b88f1819: add 64px media icons for elisa (authored by andreask). REPOSITORY R266 Breeze Icons CHANGES SINCE

D10494: update handle- icons for kirigami

2018-02-13 Thread Andreas Kainz
andreask added reviewers: alex-l, mart. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: #frameworks, michaelh

D10494: update handle- icons for kirigami

2018-02-13 Thread Andreas Kainz
andreask added a comment. the old icon with 12 dots are a bit of a overkill now with three dot's compare to three lines. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: #frameworks, michaelh

Now is the time for all prospective GSoC mentors to gear up!

2018-02-13 Thread Valorie Zimmerman
Hello everyone, our application to become a part of Google Summer of Code has been accepted! So, if you are going to become a mentor, now is the time to: 1. Ensure you are subscribed to KDE-Soc-Mentor mail list [1]. 2. Write to kde-soc-men...@kde.org to be invited to the GSoC web app. This way

D10054: Fix: View jumps when Scroll past end of document is enabled

2018-02-13 Thread Dominik Haumann
dhaumann closed this revision. dhaumann added a comment. Close as it should work now. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D10494: update handle- icons for kirigami

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. needs moar screenshots REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: ngraham, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. In D8056#205595 , @simgunz wrote: > Fixed the problems reported by @rkflx hopefully without introducing new ones. I did some testing and now

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 40 - Fixed!

2018-02-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/40/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Tue, 13 Feb 2018 21:35:53 + Build duration: 15 min and counting JUnit Tests

D10054: Fix: View jumps when Scroll past end of document is enabled

2018-02-13 Thread Dominik Haumann
dhaumann added a comment. This is fixed, see commit https://phabricator.kde.org/R39:1a38adebb64e6e7d5acb756f68166d56d8ba0b72 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham,

D10494: update handle- icons for kirigami

2018-02-13 Thread Andreas Kainz
andreask added a comment. F5710538: photo5773697838952328398.jpg left after right before REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

2018-02-13 Thread Andreas Kainz
andreask added a comment. F5710546: Screenshot_20180213_230517.png sorry wrong screenshot left new right old REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: ngraham,

D10494: update handle- icons for kirigami

2018-02-13 Thread Matheus Marinho
matheusm added a comment. The current icon reminds me of a phone dialer. +1 for the new icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D10495: Workaround to restore KF5 programs from system tray

2018-02-13 Thread Andrius Štikonas
stikonas created this revision. stikonas added reviewers: wbauer, Plasma, davidedmundson, volkov. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. stikonas requested review of this revision. REVISION SUMMARY Currently

D10495: Workaround to restore KF5 programs from system tray

2018-02-13 Thread Andrius Štikonas
stikonas added a comment. This is more to start some discussion on system tray under Wayland. I'm not sure myself if this should be committed. I just use this workaround locally until winId() works on Wayland. REPOSITORY R289 KNotifications REVISION DETAIL

D10494: update handle- icons for kirigami

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. Thanks! I hate to throw cold water on your hard work here, but is the new one really any better? I'm not sure either the old or the new icon convey "swipe left here". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To:

D10494: update handle- icons for kirigami

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. Same thing, though. The icons on the left don't scream "Swipe me to the left!" It's a tough one. I have trouble imagining //any// icon that could communicate that, but of course I'm not an icon designer. REPOSITORY R266 Breeze Icons REVISION DETAIL

D10492: add 64px media icons for elisa

2018-02-13 Thread Andreas Kainz
andreask added a comment. cause I changed my workflow and start use arc but I wasn't interested into a review. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10492 To: andreask Cc: ngraham, #frameworks, michaelh

D10492: add 64px media icons for elisa

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. If you're going to use arc and Phabricator, wait for reviews. If you don't want to wait for reviews, then just push directly. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10492 To: andreask Cc: ngraham, #frameworks, michaelh

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 39 - Fixed!

2018-02-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/39/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Tue, 13 Feb 2018 21:35:53 + Build duration: 12 min and counting JUnit Tests

D10492: add 64px media icons for elisa

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. Why bother to ask for a review on Phabricator if you're not going to post screenshots so people can see your changes or wait for any reviews before committing? If you don't want a review, just push to master directly. REPOSITORY R266 Breeze Icons REVISION DETAIL

D10494: update handle- icons for kirigami

2018-02-13 Thread Andreas Kainz
andreask added a comment. it doesn't matter where the element in kirigami swap it's for settings and have an dotted icon would only increase publicity like here in discover have three dot's in each line will give you the information that you can do something, but the focus is more on the

D10494: update handle- icons for kirigami

2018-02-13 Thread Marijo Mustac
mmustac added a comment. I agree with Andreas and think that the new icon is a huge improvement. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. In D10494#205867 , @andreask wrote: > it doesn't matter where the element in kirigami swap it's for settings and have an dotted icon would only increase publicity like here in discover have three dot's in each line will

D10495: Workaround to restore KF5 programs from system tray

2018-02-13 Thread Wolfgang Bauer
wbauer added a subscriber: KWin. wbauer added a comment. Indeed. One thing that started this is https://bugs.kde.org/show_bug.cgi?id=389663 I do think this should be fixed on the lower level if possible. Adding KWin as subscriber as well to hopefully get most people that have more

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz added a comment. > - [↓] to move focus (this breaks with the completion enabled, though) Only for completion: popup. Still works for completion: auto I have changed the tooltip as suggested. I think we are ready to land it. Can't wait to see the gif! REPOSITORY R241

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Simone Gaiarin
simgunz updated this revision to Diff 27136. simgunz added a comment. - Improve tooltip to let user know he can type a command REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8056?vs=27084=27136 BRANCH openwithdialog-filter-app-tree REVISION DETAIL

D10495: Workaround to restore KF5 programs from system tray

2018-02-13 Thread Martin Flöser
graesslin added a comment. In D10495#205811 , @stikonas wrote: > This is more to start some discussion on system tray under Wayland. I'm not sure myself if this should be committed. I just use this workaround locally until winId() works on

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. I'm super excited to see this happening. Fantastic work, @simgunz, and thanks as always for your incredibly thorough review prowess, @rkflx. I'm planning to feature this in the coming Sunday's Usability & Productivity post as it it not only a //serious// improvement