D10741: Use Locale::name() instead of Locale::bcp47Name()

2018-02-23 Thread Hannah von Reth
vonreth added a comment. I think it never worked at all, or it worked in the kde3 days or what ever. I think on a full blown KDE setup the defaults are never used as the system settings provide something different. But to be sure, all dicts I ever seen where encoded the unix way, en_US,

D10741: Use Locale::name() instead of Locale::bcp47Name()

2018-02-23 Thread Hannah von Reth
vonreth added a comment. Any feedback? This patch is needed to make sonnet work on windows at all... REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D10741 To: vonreth, dfaure, mlaurent, kfunk, vkrause Cc: #frameworks, michaelh

D10759: Use QLocale instead of QLocale::system

2018-02-23 Thread Friedrich W . H . Kossebau
kossebau added a reviewer: ilic. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10759 To: aacid, apol, ilic Cc: apol, #frameworks, #build_system, michaelh

D10758: Use QLocale instead of QLocale::system

2018-02-23 Thread Friedrich W . H . Kossebau
kossebau added a reviewer: ilic. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D10758 To: aacid, apol, ilic Cc: lueck, #frameworks, michaelh

D10759: Use QLocale instead of QLocale::system

2018-02-23 Thread Friedrich W . H . Kossebau
kossebau added a comment. Might be an idea indeed to switch to default language instead of system one. Can you tell at which point the system one is estimated, and based on what? Grepping QLocale::system on lxr.kde.org

D10777: Define __ANDROID_API__

2018-02-23 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I've never seen these so I'm surprised. Good that you figured it out though :) Can you remove the comment above? REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D10771: Save some memory allocations by using the right API

2018-02-23 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R237:b435e3747d2d: Save some memory allocations by using the right API (authored by apol). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10771?vs=27853=27885 REVISION

D10757: Reset QLocale internals when we have a custom app language

2018-02-23 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > apol wrote in kswitchlanguagedialog_p.cpp:94 > Not saying this is good or bad but clearly looks like Qt is missing some API > there. I don't know, the problem as far as i see it is that we're trying to do this in a generic way, a regular app

D10741: Use Locale::name() instead of Locale::bcp47Name()

2018-02-23 Thread Aleix Pol Gonzalez
apol added a comment. Wouldn't that mean that we are either breaking other systems or that it never worked at all? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D10741 To: vonreth, dfaure, mlaurent, kfunk, vkrause Cc: apol, #frameworks, michaelh

D10757: Reset QLocale internals when we have a custom app language

2018-02-23 Thread Albert Astals Cid
aacid updated this revision to Diff 27886. aacid retitled this revision from "Set QLocale too when we have a custom app language" to "Reset QLocale internals when we have a custom app language". aacid removed a subscriber: apol. aacid added a comment. Use QSystemLocale trick to reset QLocale

D10759: Use QLocale instead of QLocale::system

2018-02-23 Thread Albert Astals Cid
aacid added a comment. there's a new revision of D10757 that shouldn't need this at all. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10759 To: aacid, apol, ilic Cc: kossebau, apol, #frameworks,

D10757: Reset QLocale internals when we have a custom app language

2018-02-23 Thread Albert Astals Cid
aacid added a subscriber: lueck. aacid added a comment. @lueck can you try this new version *without* https://phabricator.kde.org/D10758 and https://phabricator.kde.org/D10759 ? This should be enough to get QLocale to update itself. REPOSITORY R263 KXmlGui BRANCH master REVISION

D10757: Reset QLocale internals when we have a custom app language

2018-02-23 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kswitchlanguagedialog_p.cpp:94 > +// this is highly dependant on Qt internals, so may break, but oh > well > +QSystemLocale *dummy = new QSystemLocale(); > +delete dummy; Not saying this is good or bad but clearly looks like

D10741: Use Locale::name() instead of Locale::bcp47Name()

2018-02-23 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. You mean "it worked in kdelibs4". This is a kdelibs4->KF5 porting issue. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D10741 To: vonreth,

D10757: Set QLocale too when we have a custom app language

2018-02-23 Thread Friedrich W . H . Kossebau
kossebau added a reviewer: ilic. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D10757 To: aacid, apol, ilic Cc: apol, #frameworks, michaelh

D10758: Use QLocale instead of QLocale::system

2018-02-23 Thread Chusslove Illich
ilic accepted this revision. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D10758 To: aacid, apol, ilic Cc: lueck, #frameworks, michaelh

D10758: Use QLocale instead of QLocale::system

2018-02-23 Thread Albert Astals Cid
aacid added a comment. there's a new revision of D10757 that shouldn't need this at all. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D10758 To: aacid, apol, ilic Cc: lueck, #frameworks, michaelh

D10783: Yacc/Bison: Fix the $ symbol and update syntax for Bison

2018-02-23 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10783 To: nibags, #framework_syntax_highlighting Cc: #framework_syntax_highlighting, #frameworks, michaelh, genethomas, cullmann, vkrause, dhaumann

D10783: Yacc/Bison: Fix the $ symbol and update syntax for Bison

2018-02-23 Thread Nibaldo González
nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. nibags requested review of this revision. REVISION SUMMARY Hi The Yacc/Bison file highlights as 'dsError' the '$' symbol (it is used as pseudo-variable).

D10783: Yacc/Bison: Fix the $ symbol and update syntax for Bison

2018-02-23 Thread Nibaldo González
nibags edited the summary of this revision. nibags added a reviewer: Framework: Syntax Highlighting. nibags added a project: Framework: Syntax Highlighting. nibags added a subscriber: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D8958: Fix unintentional breadcrumb menu item activation

2018-02-23 Thread Алексей Шилин
aleksejshilin added a comment. In D8958#212246 , @ngraham wrote: > @aleksejshilin doesn't have commit access Actually, I do now. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8958 To: aleksejshilin,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 146 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/146/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Feb 2018 17:43:17 + Build duration: 21 min and counting JUnit Tests Name: (root)

D8958: Fix unintentional breadcrumb menu item activation

2018-02-23 Thread Алексей Шилин
aleksejshilin edited the summary of this revision. REPOSITORY R241 KIO BRANCH fix_accidental_breadcrumb_menu_item_activation REVISION DETAIL https://phabricator.kde.org/D8958 To: aleksejshilin, #frameworks, dfaure Cc: broulik, ngraham, michaelh

D8958: Fix unintentional breadcrumb menu item activation

2018-02-23 Thread Алексей Шилин
This revision was automatically updated to reflect the committed changes. Closed by commit R241:4a6a3b81bedc: Fix unintentional breadcrumb menu item activation (authored by aleksejshilin). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8958?vs=26872=27866

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 144 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/144/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Fri, 23 Feb 2018 17:43:17 + Build duration: 20 min and counting JUnit Tests Name: (root)

Re: Please comment on T8054

2018-02-23 Thread pointedstick
Looks like great stuff! At this point, I think the student has surpassed the teacher. :) Your work is very advanced, and I'm not sure I can add anything of value beyond what Adriaan de Groot said. It's so exciting to see Baloo rise from the ashes like this. Nate On Fri, 23 Feb 2018

D8958: Fix unintentional breadcrumb menu item activation

2018-02-23 Thread Nathaniel Graham
ngraham added a comment. @aleksejshilin doesn't have commit access, so would you like to land this, @dfaure? REPOSITORY R241 KIO BRANCH fix_accidental_breadcrumb_menu_item_activation REVISION DETAIL https://phabricator.kde.org/D8958 To: aleksejshilin, #frameworks, dfaure Cc:

D10732: Help automoc to find metadata JSON files referenced in the code

2018-02-23 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 27868. kossebau added a comment. have each macro added only once (closer to current draft of ECM macro) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10732?vs=27751=27868 BRANCH

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 126 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/126/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Feb 2018 17:43:17 + Build duration: 14 min and counting JUnit Tests Name:

D10716: handle wrong password when using sudo which asks for another password

2018-02-23 Thread Jonathan Riddell
jriddell updated this revision to Diff 27859. jriddell added a comment. - remove debugging REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=27858=27859 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10716 AFFECTED FILES .gitignore

D10716: handle wrong password when using sudo which asks for another password

2018-02-23 Thread Jonathan Riddell
jriddell added a comment. Add test. This uses the real sudo and su on your system, I fear that creating a stub replacement wouldn't be necessarily a reliable recreation. It does mean adding your own password.h with #defines for your user and root password REPOSITORY R299 KDESu

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

2018-02-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY The comment says it's resolved in Qt 5.6.1+

D10716: handle wrong password when using sudo which asks for another password

2018-02-23 Thread Jonathan Riddell
jriddell updated this revision to Diff 27858. jriddell added a comment. - add test - allow passwords to be separate - remove debugging REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=27691=27858 BRANCH master REVISION DETAIL

D10771: Save some memory allocations by using the right API

2018-02-23 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. apol requested review of this revision. TEST PLAN tests pass REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D10771 AFFECTED FILES

D10733: Help automoc to find metadata JSON files referenced in the code

2018-02-23 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 27869. kossebau added a comment. have each macro added only once (closer to current draft of ECM macro) REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10733?vs=27752=27869 BRANCH useCMAKE_AUTOMOC_DEPEND_FILTERS

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.9 - Build # 6 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.9/6/ Project: Frameworks kimageformats kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Feb 2018 18:09:47 + Build duration: 55 sec and counting JUnit Tests

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.7 - Build # 9 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.7/9/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.7 Date of build: Fri, 23 Feb 2018 18:09:47 + Build duration: 2 min 5 sec and counting JUnit Tests

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/9/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Feb 2018 18:09:47 + Build duration: 3 min 49 sec and counting JUnit

D10776: Make it possible to generate po files in parallel

2018-02-23 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, sitter. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY Instead of going file by file, feed them to cmake at once. Should improve build times on some systems. TEST PLAN

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-02-23 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin Cc: markg, ngraham, #frameworks, michaelh

D10777: Define __ANDROID_API__

2018-02-23 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY This is needed for NDK headers to work

Re: Searching for KF5CddbConfig.cmake

2018-02-23 Thread Christoph Feck
On 23.02.2018 17:29, Konrad Kostecki wrote: Hi there! This is my first message here. Just wanted to say hello all! I'm compiling fantastic tool soundkonverter in version 3.0.1 ( https://github.com/dfaust/soundkonverter/releases) on Mint 18.3 (basically Ubuntu 16.04) and I can't pass this error

D10778: balooctl: Remove checkDb option

2018-02-23 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, ngraham. michaelh added a project: Baloo. Restricted Application added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY It has no value for users and is confusing them.

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-02-23 Thread Jaime Torres Amate
jtamate requested changes to this revision. jtamate added a comment. This revision now requires changes to proceed. My guess is that the problem is not in the direct delete of local files. In fact, unlink() in most of the modern filesystems is not affected by the size of the file and is

D10778: balooctl: Remove checkDb option

2018-02-23 Thread Nathaniel Graham
ngraham accepted this revision as: Baloo, ngraham. ngraham added a comment. This revision is now accepted and ready to land. +1, get rid of that thing! REPOSITORY R293 Baloo BRANCH remove-checkdb (branched from master) REVISION DETAIL https://phabricator.kde.org/D10778 To: michaelh,

D10747: Implement zwp_linux_dmabuf_v1

2018-02-23 Thread Roman Gilg
romangg added a task: T8067: Support zwp_linux_dmabuf. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart Cc: plasma-devel,

D10778: balooctl: Remove checkDb option

2018-02-23 Thread Michael Heidelbach
This revision was automatically updated to reflect the committed changes. Closed by commit R293:ca333ba316a7: balooctl: Remove checkDb option (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10778?vs=27874=27880 REVISION DETAIL

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 36 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/36/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Fri, 23 Feb 2018 20:45:08 + Build duration: 8 min 44 sec and counting JUnit Tests Name:

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Feb 2018 20:45:07 + Build duration: 8 min 56 sec and counting JUnit Tests Name:

D10771: Save some memory allocations by using the right API

2018-02-23 Thread Mark Gaiser
markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D10771 To: apol, #frameworks, markg Cc: markg, michaelh

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-23 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH removeeffectlessOBJECT_DEPENDS REVISION DETAIL https://phabricator.kde.org/D10665 To: kossebau, #frameworks, apol Cc: michaelh

D10758: Use QLocale instead of QLocale::system

2018-02-23 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D10758 To: aacid, apol Cc: lueck, #frameworks, michaelh

D10764: [AppletQuickItem] Preload applet expander only if not already expanded

2018-02-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:48b62d1a2763: [AppletQuickItem] Preload applet expander only if not already expanded (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Please comment on T8054

2018-02-23 Thread Michael Heidelbach
It all said, except "Hi!" ... and maybe: C++-wise I'll be entering areas where I've never been before. ... and ... Cheers, Michael

D10764: [AppletQuickItem] Preload applet expander only if not already expanded

2018-02-23 Thread Luca Beltrame
lbeltrame added a comment. +1 from me, fixes the issue I had. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10764 To: broulik, #plasma, mart, lbeltrame Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10759: Use QLocale instead of QLocale::system

2018-02-23 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I'm guessing that QLocale::default defaults to QLocale::system? REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10759 To: aacid, apol Cc:

D10757: Set QLocale too when we have a custom app language

2018-02-23 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. +1 Looks messy, should we look into getting it in Qt? REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D10757 To: aacid, apol Cc: apol,

D10764: [AppletQuickItem] Preload applet expander only if not already expanded

2018-02-23 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10764 To: broulik, #plasma, mart, lbeltrame Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed,

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 73 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/73/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Fri, 23 Feb 2018 12:00:36 + Build duration: 9 min 8 sec and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 70 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/70/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Feb 2018 12:00:36 + Build duration: 10 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 46 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/46/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Feb 2018 12:00:36 + Build duration: 10 min and counting

D10658: [UDisksDeviceBackend] Avoid double lookup

2018-02-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R245:14e104f801bf: [UDisksDeviceBackend] Avoid multiple lookup (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10658?vs=27545=27838 REVISION DETAIL

KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9 - Build # 32 - Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.9/32/ Project: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 20 Feb 2018 14:33:11 + Build duration: 2 days 20 hr and counting

D10764: [AppletQuickItem] Preload applet expander only if not already expanded

2018-02-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart, lbeltrame. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY When an applet is placed on

D10671: [UDisks] Fix auto-mount regression

2018-02-23 Thread Dmitry Khlestkov
dkhlestkov added a comment. Yes REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh

Re: kdiff3 status

2018-02-23 Thread Wolfgang Bauer
Am Samstag, 17. Februar 2018, 05:03:52 schrieb Wolfgang Bauer: > While it builds fine in general, I couldn't get the kfileitemaction plugin > to build, so that it shows up in dolphin's context menu e.g. I think I found the reason meanwhile: if I additionally install the *KDE4* development files

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/54/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 23 Feb 2018 13:17:36 + Build duration: 8 min 41 sec and counting JUnit Tests

Re: kdiff3 status

2018-02-23 Thread Michael Reeves
That branch is dead. I thought initially there might be more divergence. The last push was stop git from complaining every time I push. The dependencies at this stage could be easy backed down a little if there's demand for it. Based on your feed back it doesn't seem like that's the case. I had

Re: kdiff3 status

2018-02-23 Thread Wolfgang Bauer
Am Dienstag, 20. Februar 2018, 01:47:26 schrieben Sie: > I'll take a look thanks. Is it given error out out or just not building? I should have been more detailed in the first place, sorry. It is not being built at all. From the build log: -- kabstractfileitemactionplugin.h found... NO

Re: Elisa Music Player is in kdereview

2018-02-23 Thread Matthieu Gallien
Hello, On lundi 5 février 2018 20:35:02 CET Matthieu Gallien wrote: > Hello, > > Elisa is now in kdereview and aiming for extragear/multimedia. We may (in > agreement with the module maintainer) move later to the Multimedia KDE > Applications module. > > It is a music player written with qml

Re: kdiff3 status

2018-02-23 Thread Michael Reeves
On Sat, Feb 17, 2018 at 4:03 AM, Wolfgang Bauer wrote: > I haven't looked at the code at all, I'll leave that up to others. > > But one thing: > While it builds fine in general, I couldn't get the kfileitemaction plugin > to > build, so that it shows up in dolphin's context menu

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-23 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R244:2af64ee1e295: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 38 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/38/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Feb 2018 13:17:36 + Build duration: 4 min 44 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 49 - Still Unstable!

2018-02-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/49/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Fri, 23 Feb 2018 13:17:36 + Build duration: 7 min 51 sec and counting JUnit Tests

D10671: [UDisks] Fix auto-mount regression

2018-02-23 Thread Nathaniel Graham
ngraham added a comment. Do any #frameworks folks want to chime in before I land this? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: ngraham, sefaeyeoglu, rikmills,