KDE Frameworks 5.44.0 released

2018-03-10 Thread David Faure
10th March 2018. KDE today announces the release of KDE Frameworks 5.44.0. KDE Frameworks are 78 addon libraries to Qt which provide a wide variety of commonly needed functionality in mature, peer reviewed and well tested libraries with friendly licensing terms. For an introduction see the Framewo

Q_ASSERT(!FalseSecurity)

2018-03-10 Thread Michael Heidelbach
Hi! Am I getting something wrong? Or is "Q_ASSERT(m_writeTrans); m_writeTrans->commit();" providing false security? Shouldn't it better be "Q_ASSERT(m_writeTrans); if (m_writeTrans) {     m_writeTrans->commit(); ? Baloo's code is full of Q_ASSERTs that have no correspondin

Re: Q_ASSERT(!FalseSecurity)

2018-03-10 Thread James Augustus Zuccon
Good pickup - I'm not sure of the answer but my interpretation of it is the same as yours. Here's a StackOverflow thread that might be good reference for anyone else that wants to chime in: https://stackoverflow.com/questions/12573230/q-assert-release-build-semantics#12573446 Cheers! On Sat, Mar

How to improve --help message?

2018-03-10 Thread Michael Heidelbach
Hi! Currently balooctl's help looks like this: $ balooctl  ---help Usage: balooctl [options] command status enable disable start stop restart suspend resume check index clear config monitor indexSize list

March 15, 2018: KDE Applications 18.04 Dependency Freeze

2018-03-10 Thread Albert Astals Cid
So what the subject says, get your dependencies in ASAP. Cheers, Albert

Re: March 15, 2018: KDE Applications 18.04 Dependency Freeze

2018-03-10 Thread Michael Heidelbach
On 10.03.2018 10:39, Albert Astals Cid wrote: So what the subject says, get your dependencies in ASAP. Cheers, Albert Hi Albert! What exactly is a dependency freeze? Cheers, Michael

Re: Q_ASSERT(!FalseSecurity)

2018-03-10 Thread Sven Brauch
Hi, On 03/10/2018 09:53 AM, Michael Heidelbach wrote: > Am I getting something wrong? Or is > >    "Q_ASSERT(m_writeTrans); > >    m_writeTrans->commit();" > > providing false security? a lot of KDE code is written this way. It will end up crashing in both debug and release, but in debug the m

Re: Q_ASSERT(!FalseSecurity)

2018-03-10 Thread Albert Astals Cid
El dissabte, 10 de març de 2018, a les 10:37:12 CET, Sven Brauch va escriure: > Hi, > > On 03/10/2018 09:53 AM, Michael Heidelbach wrote: > > Am I getting something wrong? Or is > > > >"Q_ASSERT(m_writeTrans); > > > >m_writeTrans->commit();" > > > > providing false security? > > a lot

Re: March 15, 2018: KDE Applications 18.04 Dependency Freeze

2018-03-10 Thread Albert Astals Cid
El dissabte, 10 de març de 2018, a les 10:41:03 CET, Michael Heidelbach va escriure: > On 10.03.2018 10:39, Albert Astals Cid wrote: > > So what the subject says, get your dependencies in ASAP. > > > > Cheers, > > > >Albert > > Hi Albert! > > What exactly is a dependency freeze? Should ha

Re: March 15, 2018: KDE Applications 18.04 Dependency Freeze

2018-03-10 Thread Michael Heidelbach
Thanks, I should have known, but had forgotten the term 'dependency freeze'. To be sure: I can still submit review requests but shall not land them before 5. April? What will happen, when I (inadvertently) brake a dependency freeze? On 10.03.2018 10:55, Albert Astals Cid wrote: El dissabte,

Re: March 15, 2018: KDE Applications 18.04 Dependency Freeze

2018-03-10 Thread Sandro Knauß
Hey, > I should have known, but had forgotten the term 'dependency freeze'. To > be sure: I can still submit review requests but shall not land them > before 5. April? What will happen, when I (inadvertently) brake a > dependency freeze? you can do everything. Create, accept, delete review reques

Re: How to improve --help message?

2018-03-10 Thread Michael Heidelbach
A "Geistesblitz": I'm going to do it the same way akonadictl does. Other ideas are still very much appreciated. On 10.03.2018 10:30, Michael Heidelbach wrote: Hi! Currently balooctl's help looks like this: $ balooctl  ---help Usage: balooctl [options] command status enable disable start stop

KF5 Conversion problems

2018-03-10 Thread Robin Atwood
This is my first KDE4->KF5 conversion so brace for a lot of n00b questions! To start I am getting compile failures because the wrong include files are getting picked up: [8/10] Building CXX object src/CMakeFiles/kmtail.dir/kmtail_autogen/mocs_compilation.cpp.o FAILED: src/CMakeFiles/kmtail.dir/

Re: KF5 Conversion problems

2018-03-10 Thread Christoph Feck
On 10.03.2018 15:51, Robin Atwood wrote: This is my first KDE4->KF5 conversion so brace for a lot of n00b questions! To start I am getting compile failures because the wrong include files are getting picked up: [...] /usr/include/kdialog.h:35:25: fatal error: QtGui/QDialog: No such file or dire

Re: KF5 Conversion problems

2018-03-10 Thread Robin Atwood
On Saturday 10 March 2018, Christoph Feck wrote: > On 10.03.2018 15:51, Robin Atwood wrote: > > This is my first KDE4->KF5 conversion so brace for a lot of n00b > > questions! To start I am getting compile failures because the wrong > > include files are > > > getting picked up: > [...] > > > /us

Is it possible to mock an external drive (for unit testing)?

2018-03-10 Thread Michael Heidelbach
Hi! Is it? How? Do examples exist? Thanks in advance, Michael

Re: KF5 Conversion problems

2018-03-10 Thread Michael Pyne
On Sat, Mar 10, 2018 at 10:58:14PM +0700, Robin Atwood wrote: > On Saturday 10 March 2018, Christoph Feck wrote: > > On 10.03.2018 15:51, Robin Atwood wrote: > > > This is my first KDE4->KF5 conversion so brace for a lot of n00b > > > questions! To start I am getting compile failures because the wr