D19557: Update css

ognarb created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Header look like http://docs.carlschwan.eu/ Screenshot comming TEST PLAN Wasn't

D19557: Update css

ognarb added reviewers: VDG, Documentation. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19771: Use placeholder instead of label

ognarb added a comment. > I'm not aware of why we tend to use three dots instead of the real ellipsis character. Possibly because that character can be challenging to type. Best to follow the existing convention, I think. The advantage of using the unicode ellipsis character, is that

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19771: Use placeholder instead of label

ognarb created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ognarb requested review of this revision. REVISION SUMMARY See https://hig.kde.org/style/writing/placeholder.html Also change Find -> Search in Search and

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

ognarb updated this revision to Diff 53906. ognarb added a comment. Remove icon to option button REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53505=53906 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19771: Use placeholder instead of label

ognarb planned changes to this revision. ognarb added a comment. Look likes I misread a part of the HIG: Since the placeholder won’t be visible anymore as soon as the user types, you should only use it on standalone input elements, not in groups of input elements such as forms. So the

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19771: Use placeholder instead of label

ognarb updated this revision to Diff 53922. ognarb added a comment. Use proper Unicode ellipsis REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19771?vs=53919=53922 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19771 AFFECTED FILES

D19771: Use placeholder instead of label

ognarb edited the summary of this revision. ognarb added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann,

D19771: Use placeholder instead of label

ognarb added a reviewer: VDG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19557: Update design to look more similar to kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R238:a67daca8199c: Update design to look more similar to kde.org (authored by ognarb). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53616=53617 REVISION

D19557: Update design to look more similar to kde.org

ognarb added a comment. In D19557#428634 , @ltoscano wrote: > Thank you! And sorry for the ping-pong. No problems ;) Thanks for the review. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL

D19557: Update design to look more similar to kde.org

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor, ltoscano Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh,

D19557: Update design to look more similar to kde.org

ognarb updated this revision to Diff 53616. ognarb added a comment. Don't change image link and remove kde.png REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53603=53616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557

D19557: Update css

ognarb added a comment. In D19557#428614 , @ltoscano wrote: > No, wait a minute. What happens with pages which are not regenerated? They use the old link for the image, also the jpg version instead of the png. I tested with new page and

D19557: Update css

ognarb updated this revision to Diff 53598. ognarb added a comment. - Add deleted image - Rename top-kde.png to kde.png - Fix strange margin issues for some elements @rooty The font can be changed in the khelpcenter settings. But it's strange that it doesn't use Plasma settings per

D19557: Update css

ognarb updated this revision to Diff 53603. ognarb added a comment. Don't change image size REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53598=53603 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

ognarb added a comment. In D19557#428618 , @ltoscano wrote: > In D19557#428617 , @ognarb wrote: > > > They use the old link for the image, also the jpg version instead of the png. I tested with new

D19557: Update design to look more similar to kde.org

ognarb retitled this revision from "Update css" to "Update design to look more similar to kde.org". ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg,

D19557: Update css

ognarb added a comment. In D19557#426051 , @aacid wrote: > Why changing from jpg to png for the image file ? I only had a png version in my hard drive, but if it's a problem I can convert the png in a jpg. In D19557#426057

D19557: Update css

ognarb updated this revision to Diff 53367. ognarb added a comment. Add breeze like style for note/info/warning/tip admonitions and make image responsive REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53359=53367 BRANCH master REVISION

D19557: Update css

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb updated this revision to Diff 53359. ognarb edited the test plan for this revision. ognarb added a comment. Change to jpg and remove now useless files REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53251=53359 BRANCH master REVISION

D19620: Use a searchbar similar to the one from okular

ognarb edited the summary of this revision. ognarb added reviewers: VDG, Frameworks. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one from okular

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Improve consistency between different KDE apps. It's not perfect (close button isn't aligned). Screenshot

D19557: Update css

ognarb updated this revision to Diff 53469. ognarb added a comment. Improve display inline media REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53367=53469 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19620: Use a searchbar similar to the one in okular

ognarb retitled this revision from "Use a searchbar similar to the one from okular" to "Use a searchbar similar to the one in okular". REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

ognarb updated this revision to Diff 53505. ognarb added a comment. Add icons REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53488=53505 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES

D19620: Use a searchbar similar to the one in okular

ognarb updated this revision to Diff 53488. ognarb edited the summary of this revision. ognarb added a comment. This revision is now accepted and ready to land. Use placeholder text and clearButton REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19557: Update css

ognarb added a comment. @aacid it is ready to land? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb updated this revision to Diff 53521. ognarb added a comment. Use correct breeze color for important and warning REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53469=53521 BRANCH master REVISION DETAIL

D19895: Use https for links in the UI and documentation

ognarb added a comment. I made sure that all the links are still working. So +1 INLINE COMMENTS > kproxydlg.ui:45 > Automatic detection is performed using the bWeb Proxy Auto-Discovery > Protocol (WPAD)/b.p > -bNOTE:/b This option might not work properly or not work at > all in some

D19771: Use placeholder instead of label

ognarb added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh,

D19620: Use a searchbar similar to the one in okular

ognarb updated this revision to Diff 53928. ognarb added a comment. Use Unicode ellipsis REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53906=53928 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES

D19557: Update css

ognarb updated this revision to Diff 53542. ognarb added a comment. Change png image REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53541=53542 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

ognarb updated this revision to Diff 53545. ognarb added a comment. Use inkscape to generate png REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53544=53545 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

ognarb updated this revision to Diff 53541. ognarb added a comment. Use png instead of jpg REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53521=53541 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

ognarb added a comment. In D19557#428086 , @bruns wrote: > Is it intentional the PNG is 129x129 while the JPEG is 128x128? I have no idea why 129x129. I used `convert` to convert the svg to png, just like I did with the jpg. But I will

D19557: Update css

ognarb added a comment. Lol 128x128 png image 6kb, 129x129 png image 2kb REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham,

D19557: Update css

ognarb updated this revision to Diff 53544. ognarb added a comment. Use a 128x128 png image REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53542=53544 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

ognarb updated this revision to Diff 53546. ognarb added a comment. Apply optipng. Thanks @bruns I learned something new :D. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53545=53546 BRANCH master REVISION DETAIL

D21574: Update KBruch icon

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Inspired from application-edu and cantor icon TEST PLAN Screenshot comming REPOSITORY R266 Breeze Icons BRANCH

D21574: Update KBruch icon

ognarb edited the test plan for this revision. ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D19771: Use placeholder instead of label

ognarb abandoned this revision. ognarb added a comment. I don't have time and the motivation for this revision anymore. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham,

D21574: Update KBruch icon

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

ognarb updated this revision to Diff 59131. ognarb added a comment. Add shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59123=59131 BRANCH kbruch REVISION DETAIL https://phabricator.kde.org/D21574 AFFECTED FILES

D21574: Update KBruch icon

ognarb added a comment. In D21574#474171 , @ndavis wrote: > Wait, is this a PNG? This needs to be just an SVG. We don't ship PNGs in breeze-icons. Sorry it arc who also uploaded the png that I created for the review, I will fix it.

D21574: Update KBruch icon

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:86d0782cf4e2: Update KBruch icon (authored by ognarb). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59187=59189 REVISION DETAIL

D21574: Update KBruch icon

ognarb updated this revision to Diff 59187. ognarb added a comment. - Optimize icon with scour-icon - Copy icon to breeze-dark - Remove png REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59131=59187 BRANCH kbruch REVISION DETAIL

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59372. ognarb added a comment. Crop shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59371=59372 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59707. ognarb added a comment. Change color of some points REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59706=59707 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59720. ognarb added a comment. Use more round corner. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59707=59720 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59706. ognarb added a comment. Still works in progress (need to add the gradiend) but some improvement REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59372=59706 BRANCH master REVISION DETAIL

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

ognarb added a comment. Why not mirror the Anjuta icon and use the same background color as the original Knights icon? So that it looks closer to the original. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21218 To: ngraham, #vdg Cc: ognarb,

D19771: Use placeholder instead of label

ognarb added a comment. Hi, I try to find time to look into it this weekend ;). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, domson,

Re: RFC: Running clang-format across all Plasma (and more?) repos

Hi, I like the idea a lot and I would love to do the same for the websites. Probably using tools like [PHP Coding Standards Fixer](https://cs.symfony.com/). Cheers, Carl ‐‐‐ Original Message ‐‐‐ On Thursday 11 July 2019 16:18, David Edmundson wrote: > One topic discussed at the

D24015: Added scripts to create a webfont out of all breeze action icons

ognarb added inline comments. INLINE COMMENTS > Gruntfile.js:13 > +types: 'eot,woff2,ttf,svg', > +optimize: false > +} why not true? REPOSITORY R266 Breeze Icons REVISION DETAIL

D24015: Added scripts to create a webfont out of all breeze action icons

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24015 To: fabianr, ndavis, ognarb Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2,

D22797: Fix typo - GridView -> ScrollView

ognarb added a reviewer: Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22797 To: ognarb, #plasma Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22797: Fix typo - GridView -> ScrollView

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Probably the result of a bad copy pasta ;) TEST PLAN Not tested REPOSITORY R296 KDeclarative BRANCH master

D22797: Fix typo - GridView -> ScrollView

This revision was automatically updated to reflect the committed changes. Closed by commit R296:2571616ec547: Fix typo - GridView - ScrollView (authored by ognarb). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22797?vs=62705=62708 REVISION DETAIL

D19620: Use a searchbar similar to the one in okular

ognarb abandoned this revision. ognarb added a comment. I completly forgot about this patch and since KHTML is dead and is getting removed from most of our apps, it doesn't makes sence to land this patch. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To:

D21169: Add app icon for the Kirogi Drone control app

ognarb added a comment. kde.org/applications use the icons from breeze-icons. So I think it's worth adding to breeze-icons or improving how the icon are fetched in kde.org/applications. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21169 To: trickyricky26,

D25123: [WIP] New yakuake logo/icon

ognarb added a reviewer: hein. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein Cc: ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

D25149: Add a new Template for KCM's.

ognarb added a comment. Another related todo would be to update/rewrite https://techbase.kde.org/Development/Tutorials/KCM_HowTo after this template is merged and include information about it ;) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

Kdenlive mini sprint

Relaying Kdenlive developers :) Hi all On November 1st we'll be having a mini sprint to improve the effects and compositing UI/UX for the 19.12 release. Join us from 9AM till 2PM at kdenlive (IRC or Telegram) to participate in this effort. You can find some issues we'll be focusing on (open

Re: Sysadmin Load Reduction: Code Related Services

Hi all, Can the gitlab api be of useful in the future? e.g https://invent.kde.org/api/v4/groups/7 Cheers, Carl ‐‐‐ Original Message ‐‐‐ On Saturday, November 16, 2019 9:51 AM, Ben Cooksley wrote: > On Sat, Nov 16, 2019 at 10:39 PM Albert Astals Cid aa...@kde.org wrote: > > > El

T11542: Remove KHTML

ognarb added a revision: D25714: Port away from deprecated KHtml. TASK DETAIL https://phabricator.kde.org/T11542 To: ognarb Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, asturmlechner, cfeck, cullmann,

Re: (No Subject)

I'm now in contact with Anuj  Carl \ Original Message On 4 Dec 2019, 08:45, Anuj Bansal < bansalan...@gmail.com> wrote: > > > > Hello Everyone! > > I am an aspiring web developer and I would like to participate in Season of > KDE. Can anyone guide me to any Web Development

D26010: Update the kiten log

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Mix the labplot icon and the hiraganas for kiten Another possibility would be to use the kile icon with the same

D26010: Update the kiten log

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26010 To: ognarb Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

ognarb added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26010 To: ognarb, #breeze Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

ognarb added inline comments. INLINE COMMENTS > dvratil wrote in calendarentry.h:63 > Use `std::unique_ptr const d` for automatic memory > management. This wasn't done, I still see `CalendarEntryPrivate *d;` > nicolasfella wrote in calendarplugin.h:39 > My idea was to be able to add a d-ptr

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

ognarb added a comment. Instead of using uncrustify-kf5, shouldn't we use the clang-format file from T11214 ? REPOSITORY R374 KolourPaint REVISION DETAIL https://phabricator.kde.org/D24672 To: ahmadsamir, kde-frameworks-devel Cc: ognarb,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ognarb added inline comments. INLINE COMMENTS > kcategorydrawer.cpp:88 > +textRect.setTop(textRect.top() + 4); > +textRect.setLeft(textRect.left() + 8); > textRect.setHeight(fontMetrics.height()); Instead of using magic number, I would create a constant named padding.

D24390: Add more file and directories to exclude filters

ognarb added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24390 To: ognarb, #baloo Cc: kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24390: Add more file and directories to exclude filters

ognarb created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. ognarb requested review of this revision. TEST PLAN None for the moment REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D24390

D24390: Add more file and directories to exclude filters

ognarb added inline comments. INLINE COMMENTS > ngraham wrote in fileexcludefilters.cpp:137 > This one makes me a little nervous since it's a not-very-uncommon English > word, not something implicitly technical that we can be safe excluding. > > Is there any other way we could exclude the

D24568: Provide clang-format target with a common KDE style file

ognarb added inline comments. INLINE COMMENTS > KDEClangFormat.cmake:11 > +# > +# :: > +# need doc REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann Cc: ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D24568: Provide clang-format target with a common KDE style file

ognarb added a comment. There is probably a way to run clang-format only on a patch. See http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting But should we not prefer running clang format one time, instead of having only some part of the code auto-formatted?

Re: Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

+ 1 Commit with the name "Merge branch 'branch-name' into 'master' are not helpful. Cheers, Carl On Sunday, October 13, 2019 10:57:20 PM CEST Albert Astals Cid wrote: > I find the merge behavior to be not what we've been doing in phabricator so > given the idea is to maintain our workflows i'd

D25495: Fix Sonnet autodetect failing on Indian langs

ognarb added a reviewer: cullmann. ognarb added a comment. Adding a potential reviewer :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Fwd: gsoc ktoblzcheck

Hello, You might want to click on the contact Rhabacker link. If you are asked to login and don't have an account yet, you can create an account in identity.kde.org and then log through phabricator.kde.org. I hope it help. Best regards, Carl \ Original Message On 24 Feb

D27601: KConfig: Convert to SPDX license statements

ognarb added inline comments. INLINE COMMENTS > cordlandwehr wrote in kcfg.xsd:20 > Actually, I though quite a time about this and at the end did a comparison of > the permissions specifically provided by this statement: use, copy and modify > (yet there is no explicit statement of

D27851: Add rss icons in action

This revision was automatically updated to reflect the committed changes. Closed by commit R266:861f6ab52dc3: Add rss icons in action (authored by ognarb). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27851?vs=76976=76979 REVISION DETAIL

  1   2   3   >