Re: Review Kid3
> The usage of bugzilla is not under discussion right now for any project. I have now switched to bugzilla in the code and on the web site.
Re: Review Kid3
El diumenge, 23 de febrer de 2020, a les 17:35:28 CET, Urs Fleisch va escriure: > >> Right. Urs, could you please request creation of a bugzilla product? > > Then could someone please tell me how to request creation of a bugzilla > product? I could not find such an option on https://bugs.kde.org/. https://go.kde.org/systickets Cheers, Albert
Re: Review Kid3
>> Right. Urs, could you please request creation of a bugzilla product? Then could someone please tell me how to request creation of a bugzilla product? I could not find such an option on https://bugs.kde.org/.
Re: Review Kid3
El dimecres, 19 de febrer de 2020, a les 6:39:50 CET, Urs Fleisch va escriure: > Hi Albert, > > > You don't need all that > > echo "Extracting po/en/kid3_qt.po" > > part, scripty just does it every single day for you > > I saw that an English po is now generated and downloaded when using > translations/download-pos.sh. In this case the file po/en/kid3_qt.po > already exists and the "Extracting po/en/kid3_qt.po" part is not executed, > so it does not harm. What could be improved in scripty's job is the fact > that it generates a full English po with a lot of wrong "translations" > therein (fuzzy, guessed incorrectly by msgmerge). msgmerge should not be > called on po files which only contain plurals. But anyway, I explicitly > call lupdate with the -pluralonly option in translations/po2ts.py, so the > wrong translations do not harm in the end. > > > I don't understand why you have that po2ts.py either, we have an > extra-cmake-modules > > thing that will make it for you (ECMCreateQmFromPoFiles.cmake), you > should be using it :) > > I tried it with ECMPoQmTools, but unfortunately, it didn't work in this > case. I documented this in the header of translations/CMakeLists.txt: > > # Using ecm_install_po_files_as_qm() from ECMPoQmTools does not work > # because the generated ts files do not have context information, > # just one single context with an empty name. So what you are saying is that ecm_install_po_files_as_qm doesn't work at all? That's strange since it works for lots of KDE Frameworks that use it. In the future, please when you find what seems to be a bug like that tell us about it so we can make it work and you don't have to do your own thing. Cheers, Albert > > Regards, > Urs >
Re: Review Kid3
Urs Fleisch ha scritto: > Hi Christoph, > >>> You should change the bug reporting to use bugzilla not your email address > in KAboutData >> >> Right. Urs, could you please request creation of a bugzilla product? > > I discussed the migration of the existing bug reports, feature requests and > help form items with Jonathan, and we agreed that GitLab issues > (https://invent.kde.org/kde/kid3/issues) are used for this purpose. All > existing issues from SourceForge have been migrated to GitLab and the source > code is fixed to point to this location. This is not a decision that a single project could take alone. I believe some people (including Jonathan) have good reasons for moving to gitlab, but as a community we can't have a split triaging process. If we move, we should move every project, and at this point of the gitlab migration there are still other issues. Moreover, we should make sure of our tooling works with gitlab too in addition to bugzilla and handle the transition. It is a project which require works and it will take time. Also, issue handling in gitlab is more limited then what bugzilla can provide, and by the time we settle down with the gitlab migration, bugzilla may have also catched up with some of the missing features. The usage of bugzilla is not under discussion right now for any project. -- Luigi
Re: Review Kid3
Hi Christoph, >> You should change the bug reporting to use bugzilla not your email address in KAboutData > > Right. Urs, could you please request creation of a bugzilla product? I discussed the migration of the existing bug reports, feature requests and help form items with Jonathan, and we agreed that GitLab issues ( https://invent.kde.org/kde/kid3/issues) are used for this purpose. All existing issues from SourceForge have been migrated to GitLab and the source code is fixed to point to this location. Regards, Urs
Re: Review Kid3
Hi Albert, > You don't need all that > echo "Extracting po/en/kid3_qt.po" > part, scripty just does it every single day for you I saw that an English po is now generated and downloaded when using translations/download-pos.sh. In this case the file po/en/kid3_qt.po already exists and the "Extracting po/en/kid3_qt.po" part is not executed, so it does not harm. What could be improved in scripty's job is the fact that it generates a full English po with a lot of wrong "translations" therein (fuzzy, guessed incorrectly by msgmerge). msgmerge should not be called on po files which only contain plurals. But anyway, I explicitly call lupdate with the -pluralonly option in translations/po2ts.py, so the wrong translations do not harm in the end. > I don't understand why you have that po2ts.py either, we have an extra-cmake-modules > thing that will make it for you (ECMCreateQmFromPoFiles.cmake), you should be using it :) I tried it with ECMPoQmTools, but unfortunately, it didn't work in this case. I documented this in the header of translations/CMakeLists.txt: # Using ecm_install_po_files_as_qm() from ECMPoQmTools does not work # because the generated ts files do not have context information, # just one single context with an empty name. Regards, Urs
Re: Review Kid3
On 02/13/20 22:14, Albert Astals Cid wrote: You should change the bug reporting to use bugzilla not your email address in KAboutData Right. Urs, could you please request creation of a bugzilla product? Thanks, Christoph
Re: Review Kid3
El dilluns, 17 de febrer de 2020, a les 11:03:06 CET, Urs Fleisch va escriure:
> > tr("%n files", "", m_fileCount)
> > And if you know, how do you solve it?
>
> Thanks, Albert, this was in fact a problem. I have now read
> https://community.kde.org/Frameworks/Frameworks_Localization_Policy and
> fixed it accordingly, see
> https://invent.kde.org/kde/kid3/commit/723218fa6fdda2caeba7179d666b4c1976612ccf
You don't need all that
echo "Extracting po/en/kid3_qt.po"
part, scripty just does it every single day for you.
I don't understand why you have that po2ts.py either, we have an
extra-cmake-modules thing that will make it for you
(ECMCreateQmFromPoFiles.cmake), you should be using it :)
Cheers,
Albert
Re: Review Kid3
> tr("%n files", "", m_fileCount)
> And if you know, how do you solve it?
Thanks, Albert, this was in fact a problem. I have now read
https://community.kde.org/Frameworks/Frameworks_Localization_Policy and
fixed it accordingly, see
https://invent.kde.org/kde/kid3/commit/723218fa6fdda2caeba7179d666b4c1976612ccf
.
Re: Review Kid3
El divendres, 14 de febrer de 2020, a les 11:47:18 CET, Urs Fleisch va escriure:
> > lupdate is complaining about singular messages
> >
> > ../src/gui/forms/basemainwindow.cpp:639: '%n folders' message is missing
> '//~ singular' comment
> > ../src/gui/forms/basemainwindow.cpp:639: '%n folders' message is missing
> '//~ plural' comment
> > ../src/gui/forms/basemainwindow.cpp:642: '%n files' message is missing
> '//~ singular' comment
> > ../src/gui/forms/basemainwindow.cpp:642: '%n files' message is missing
> '//~ plural' comment
> > ../src/gui/forms/basemainwindow.cpp:645: '%n selected' message is missing
> '//~ singular' comment
> > ../src/gui/forms/basemainwindow.cpp:645: '%n selected' message is missing
> '//~ plural' comment
>
> I have never seen this message. What can I do to reproduce it?
https://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Systems#Testing_your_Messages.sh_script
> What has to be done to get rid of it?
H, actually now i see this may not totally be a problem for you but then
indeed it may be a problem for you :D
Let me ask you a question and then i'll explain myself later depending what
your answer is :)
Do you know of the problem of things like
tr("%n files", "", m_fileCount)
actually not working in English unless you provide a translation file? And by
not working i mean that it will say "1 files".
And if you know, how do you solve it?
Cheers,
Albert
>
> > You should change the bug reporting to use bugzilla not your email address
> > in KAboutData, the url of the webpage also seems "old"
>
> Thanks for pointing at this, I have now replaced all references to
> SourceForge [0b59626b].
>
Re: Review Kid3
> lupdate is complaining about singular messages > > ../src/gui/forms/basemainwindow.cpp:639: '%n folders' message is missing '//~ singular' comment > ../src/gui/forms/basemainwindow.cpp:639: '%n folders' message is missing '//~ plural' comment > ../src/gui/forms/basemainwindow.cpp:642: '%n files' message is missing '//~ singular' comment > ../src/gui/forms/basemainwindow.cpp:642: '%n files' message is missing '//~ plural' comment > ../src/gui/forms/basemainwindow.cpp:645: '%n selected' message is missing '//~ singular' comment > ../src/gui/forms/basemainwindow.cpp:645: '%n selected' message is missing '//~ plural' comment I have never seen this message. What can I do to reproduce it? What has to be done to get rid of it? > You should change the bug reporting to use bugzilla not your email address > in KAboutData, the url of the webpage also seems "old" Thanks for pointing at this, I have now replaced all references to SourceForge [0b59626b].
Re: Review Kid3
> Short legal review: > (..) > Please add the missing licenses files to the root folder. > If possible, also add BSD license headers to your FindXXX.cmake files. Thanks for looking at this, it is now fixed [f8ef0d60].
Re: Review Kid3
El dijous, 13 de febrer de 2020, a les 7:11:45 CET, Urs Fleisch va escriure: > Hello everybody, > > As you may know, Kid3, an audio tagger, has moved from SourceForge.net to > kde.org. Jonathan Riddell is attending the incubation process as a sponsor. > To complete the incubation, I would kindly ask you to execute a KDE review > on the project. > > Website: https://kid3.kde.org/ > Git, Issues: https://invent.kde.org/kde/kid3/ > Incubator: https://community.kde.org/Incubator/Projects/kid3 > Translation state: https://l10n.kde.org/stats/gui/trunk-kf5/po/kid3_qt.po/ > Documentation state: https://l10n.kde.org/stats/doc/trunk-kf5/po/kid3.po/ > > Kid3 exists since 2003 and I would say that it is quite mature. As it is > also available as a Qt-only version (without KDE dependencies) and for > macOS, Windows and Android, the build system differs a bit from the typical > KDE application. lupdate is complaining about singular messages ../src/gui/forms/basemainwindow.cpp:639: '%n folders' message is missing '//~ singular' comment ../src/gui/forms/basemainwindow.cpp:639: '%n folders' message is missing '//~ plural' comment ../src/gui/forms/basemainwindow.cpp:642: '%n files' message is missing '//~ singular' comment ../src/gui/forms/basemainwindow.cpp:642: '%n files' message is missing '//~ plural' comment ../src/gui/forms/basemainwindow.cpp:645: '%n selected' message is missing '//~ singular' comment ../src/gui/forms/basemainwindow.cpp:645: '%n selected' message is missing '//~ plural' comment You should change the bug reporting to use bugzilla not your email address in KAboutData, the url of the webpage also seems "old" $ kid3 QCommandLineParser: already having an option named "h" QCommandLineParser: already having an option named "help-all" QCommandLineParser: already having an option named "v" Cheers, Albert > > Best regards, > Urs >
Re: Review Kid3
Hello, On jeudi 13 février 2020 07:11:45 CET Urs Fleisch wrote: > Hello everybody, > > As you may know, Kid3, an audio tagger, has moved from SourceForge.net to > kde.org. Jonathan Riddell is attending the incubation process as a sponsor. > To complete the incubation, I would kindly ask you to execute a KDE review > on the project. > > Website: https://kid3.kde.org/ > Git, Issues: https://invent.kde.org/kde/kid3/ > Incubator: https://community.kde.org/Incubator/Projects/kid3 > Translation state: https://l10n.kde.org/stats/gui/trunk-kf5/po/kid3_qt.po/ > Documentation state: https://l10n.kde.org/stats/doc/trunk-kf5/po/kid3.po/ > > Kid3 exists since 2003 and I would say that it is quite mature. As it is > also available as a Qt-only version (without KDE dependencies) and for > macOS, Windows and Android, the build system differs a bit from the typical > KDE application. > Short legal review: COPYING contains the GPL-2.0-or-later license. Most files are under this license except a couple ones: - LGPL-2.1-or-later in src/plugins/taglibmetadata/taglibext/mp2 and src/ plugins/taglibmetadata/taglibext (+MPL-1.1 for the latter) - LGPL-2.1-only in src/plugins/taglibmetadata/taglibext/tdebug.h, src/plugins/ kid3qml/qmlpp.py - LGPL-3.0-only in src/qml/, src/plugins/kid3qml, src/core/model - LGPL-2.0-only in src/plugins/oggflacmetadata Please add the missing licenses files to the root folder. If possible, also add BSD license headers to your FindXXX.cmake files. Christophe
Re: Review Kid3
> Is there a way to subscribe to bugs reported there? Another possibility is to click on the bell icon near the top on the project web site. In the drop-down you can select "Watch". Regards, Urs
Re: Review Kid3
On Thu, Feb 13, 2020 at 9:12 PM Christoph Feck wrote: > > On 02/13/20 07:11, Urs Fleisch wrote: > > As you may know, Kid3, an audio tagger, has moved from SourceForge.net to > > kde.org. Jonathan Riddell is attending the incubation process as a sponsor. > > To complete the incubation, I would kindly ask you to execute a KDE review > > on the project. > > > > Website: https://kid3.kde.org/ > > Git, Issues: https://invent.kde.org/kde/kid3/ > > Is there a way to subscribe to bugs reported there? By starring the project. Once that is done, you can customise the address the notifications are delivered to, along with how the notifications are delivered to you, at https://invent.kde.org/profile/notifications Please note that in general, Gitlab is supposed to be used to handle Developer tasks/issues, rather than user bugs. > > > Incubator: https://community.kde.org/Incubator/Projects/kid3 > > Translation state: https://l10n.kde.org/stats/gui/trunk-kf5/po/kid3_qt.po/ > > Documentation state: https://l10n.kde.org/stats/doc/trunk-kf5/po/kid3.po/ > > > > Kid3 exists since 2003 and I would say that it is quite mature. As it is > > also available as a Qt-only version (without KDE dependencies) and for > > macOS, Windows and Android, the build system differs a bit from the typical > > KDE application. > > -- > Christoph Feck > KDE Bug Triaging Team > Cheers, Ben
Re: Review Kid3
On 02/13/20 07:11, Urs Fleisch wrote: As you may know, Kid3, an audio tagger, has moved from SourceForge.net to kde.org. Jonathan Riddell is attending the incubation process as a sponsor. To complete the incubation, I would kindly ask you to execute a KDE review on the project. Website: https://kid3.kde.org/ Git, Issues: https://invent.kde.org/kde/kid3/ Is there a way to subscribe to bugs reported there? Incubator: https://community.kde.org/Incubator/Projects/kid3 Translation state: https://l10n.kde.org/stats/gui/trunk-kf5/po/kid3_qt.po/ Documentation state: https://l10n.kde.org/stats/doc/trunk-kf5/po/kid3.po/ Kid3 exists since 2003 and I would say that it is quite mature. As it is also available as a Qt-only version (without KDE dependencies) and for macOS, Windows and Android, the build system differs a bit from the typical KDE application. -- Christoph Feck KDE Bug Triaging Team
