Re: Review Request 129185: [baloo] Add a small benchmark for PostingCodec::encode()

2016-10-15 Thread Christian Ehrlicher 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129185/
---

(Updated Oct. 15, 2016, 11:46 a.m.)


Review request for Baloo.


Changes
---

Use QTest to make it a real unit test including a benchmark


Repository: baloo


Description
---

This small test is used to test if the changes inside PostingCodec::encode() do 
not break anything. It also does some benchmarking to show the speedup.


Diffs (updated)
-

  tests/benchmarks/CMakeLists.txt 0d74718 
  tests/benchmarks/positioncodectest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129185/diff/


Testing
---


Thanks,

Christian Ehrlicher

Re: Review Request 129185: [baloo] Add a small benchmark for PostingCodec::encode()

2016-10-14 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129185/#review100011
---




tests/benchmarks/positioncodectest.cpp (line 47)


You can use QBENCHMARK_ONCE and QBENCHMARK for some of this.


- Aleix Pol Gonzalez


On Oct. 14, 2016, 10:57 p.m., Christian Ehrlicher wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129185/
> ---
> 
> (Updated Oct. 14, 2016, 10:57 p.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This small test is used to test if the changes inside PostingCodec::encode() 
> do not break anything. It also does some benchmarking to show the speedup.
> 
> 
> Diffs
> -
> 
>   tests/benchmarks/CMakeLists.txt 0d74718 
>   tests/benchmarks/positioncodectest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129185/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Christian Ehrlicher
> 
>