Re: kio-stash is in KDE Review
Hey, > Not too sure what is going on with that part - I also did 'gpg2 > --send-keys 2A7D2DAE'. However, it doesn't show up when I search for > it on keys.gnupg.net Well you should maybe define the keyserver, than you know where it is :) I Personally prefere the sks-keservers.net: gpg --keyserver hkp://pool.sks-keyservers.net --send-key they also have a TLS version, to use that see: https://sks-keyservers.net/overview-of-pools.php But you are free to use any other keyserver and know what keyserver you are using :) Best Regards, sandro
Re: kio-stash is in KDE Review
> Tar is signed with key 2A7D2DAE but I can't find it on the keyservers, where > was it submitted? Not too sure what is going on with that part - I also did 'gpg2 --send-keys 2A7D2DAE'. However, it doesn't show up when I search for it on keys.gnupg.net On Tue, Jul 4, 2017 at 2:31 PM, Jonathan Riddell wrote: > On Fri, Jun 30, 2017 at 08:18:51AM +0530, Arnav Dhamija wrote: >> >> Tagging 1.0 >> >> gpg: Signature made Thu 29 Jun 2017 12:31:50 BST using RSA key ID DBAF2267 >> >> gpg: Can't check signature: No public key > > Tar is signed with key 2A7D2DAE but I can't find it on the keyservers, where > was it submitted? > > Jonathan -- arnav dhamija
Re: kio-stash is in KDE Review
On Fri, Jun 30, 2017 at 08:18:51AM +0530, Arnav Dhamija wrote: > >> Tagging 1.0 > >> gpg: Signature made Thu 29 Jun 2017 12:31:50 BST using RSA key ID DBAF2267 > >> gpg: Can't check signature: No public key Tar is signed with key 2A7D2DAE but I can't find it on the keyservers, where was it submitted? Jonathan
Re: kio-stash is in KDE Review
Planet says you've released, well done :) Do send an announce to kde-apps-announce@ so we know about it Jonathan On Fri, Jun 30, 2017 at 08:18:51AM +0530, Arnav Dhamija wrote: > > I can't find your key on the openpgp key servers > > I've uploaded the keys. Please let me know if there still is any problem. > > > Please hold on the release. The Messages.sh was fixed only yesterday, so 1.0 > > won't have translations. It may not be an issue, but I would pay a bit of > > attention to that. > > Could the English version of this be released with 1.0 and then > translations added in a future version? > > On Thu, Jun 29, 2017 at 5:15 PM, Luigi Toscano > wrote: > > On Thursday, 29 June 2017 13:41:51 CEST Jonathan Riddell wrote: > >> Looks like you're getting there :) > >> > >> Tagging 1.0 > >> gpg: Signature made Thu 29 Jun 2017 12:31:50 BST using RSA key ID DBAF2267 > >> gpg: Can't check signature: No public key > > > > Please hold on the release. The Messages.sh was fixed only yesterday, so 1.0 > > won't have translations. It may not be an issue, but I would pay a bit of > > attention to that. > > > > -- > > Luigi > > > > -- > arnav dhamija
Re: kio-stash is in KDE Review
Arnav Dhamija ha scritto: > On Thu, Jun 29, 2017 at 5:15 PM, Luigi Toscano > wrote: >> Please hold on the release. The Messages.sh was fixed only yesterday, so 1.0 >> won't have translations. It may not be an issue, but I would pay a bit of >> attention to that. > > Could the English version of this be released with 1.0 and then > translations added in a future version? Up to the release manager (in this case, you). In this case the messages are mostly error messages; on the other side, the translation of the appdata is useful in order to find the program. But please pay attention to this kind of things in the future (this is valid for any release manager). -- Luigi
Re: kio-stash is in KDE Review
> I can't find your key on the openpgp key servers I've uploaded the keys. Please let me know if there still is any problem. > Please hold on the release. The Messages.sh was fixed only yesterday, so 1.0 > won't have translations. It may not be an issue, but I would pay a bit of > attention to that. Could the English version of this be released with 1.0 and then translations added in a future version? On Thu, Jun 29, 2017 at 5:15 PM, Luigi Toscano wrote: > On Thursday, 29 June 2017 13:41:51 CEST Jonathan Riddell wrote: >> Looks like you're getting there :) >> >> Tagging 1.0 >> gpg: Signature made Thu 29 Jun 2017 12:31:50 BST using RSA key ID DBAF2267 >> gpg: Can't check signature: No public key > > Please hold on the release. The Messages.sh was fixed only yesterday, so 1.0 > won't have translations. It may not be an issue, but I would pay a bit of > attention to that. > > -- > Luigi -- arnav dhamija
Re: kio-stash is in KDE Review
On Thursday, 29 June 2017 13:41:51 CEST Jonathan Riddell wrote: > Looks like you're getting there :) > > Tagging 1.0 > gpg: Signature made Thu 29 Jun 2017 12:31:50 BST using RSA key ID DBAF2267 > gpg: Can't check signature: No public key Please hold on the release. The Messages.sh was fixed only yesterday, so 1.0 won't have translations. It may not be an issue, but I would pay a bit of attention to that. -- Luigi
Re: kio-stash is in KDE Review
Looks like you're getting there :) Tagging 1.0 gpg: Signature made Thu 29 Jun 2017 12:31:50 BST using RSA key ID DBAF2267 gpg: Can't check signature: No public key I can't find your key on the openpgp key servers gpg2 --send-keys DBAF2267 should do it Jonathan
Re: [kde-devel] Re: kio-stash is in KDE Review
On Thu, Jun 29, 2017 at 8:11 AM, Arnav Dhamija wrote: > Thanks for the suggestions. I've made all these changes in the latest > commits. One thing bugging me is that the ID in the AppStream file > needs a .desktop file, but I don't have one as this is an application. > Should I leave it as it is or create a .desktop file for the same? You don't need a .desktop file, something like org.kde.kio-stash would be ok (check it with 'appstreamcli validate'). > > I'll be uploading the tarball shortly. > > On Wed, Jun 28, 2017 at 9:05 PM, Jonathan Riddell wrote: >> >> Versioning entirely depends on the project in question. >> >> For a library with API/ABI stability it's important to set the right version >> and update it on API/ABI changes. >> >> For anything else it's not too important but it's useful to have one >> so people can report bugs on a known version, however I'm not sure >> there's a good way to do so with a kioslave so maybe you can get away >> with not doing it at all. >> >>> Also, I have some confusion about AppStream procedure. >>> >>> > Your desktop file should be org.kde.foo.desktop. This is also your >>> > desktop-id, so whenver you may need that. It's basically your file name. >>> > If you have a D-Bus service ... make sure that your D-Bus service name >>> > matches this or change your desktop file to match the service address >>> > (whichever seems more appropriate) >>> > The name part 'foo' MUST be the name of your binary. >>> >>> In my case, I have two binaries - 'filestash.so' and >>> 'stashnotifier.so'. I also have a D-Bus service name >>> 'org.kde.kio.StashNotifier'. What would be my org.kde.foo name in this >>> case? >> >> It's not an application so I don't think it needs to match to a .desktop >> file, you'll need a AppStream file for it. I'm not sure what >> the D-Bus stuff is about I'm afraid. >> >>> Also, as for the screenshot part - my application is not really a GUI >>> application as it is an ioslave. Would a screenshot of Dolphin loading >>> the stash:/ ioslave do for this purpose? >> >> Yes Dolphin would be fine, it's used by Discover and other package managers >> when people are offered to install it. >> >> The files in the Git repository are still +x permission, that should be >> removed. >> >> Jonathan > > > > -- > arnav dhamija
Re: kio-stash is in KDE Review
On Wed, Jun 28, 2017 at 1:27 PM, Arnav Dhamija wrote: > Yes. I have decided to move it under KDE ExtraGear Utils. I'm working > with the guide Boudhayan posted in the previous email to make a > tarball out of it to ship it for release. As a note for anyone doing moves in the future, please use "git mv" to relocate your project to make the operation fully atomic. It also makes tracing those changes, and reverting if necessary, easier. Cheers, Ben > > On Wed, Jun 28, 2017 at 4:01 AM, Ben Cooksley wrote: >> On Wed, Jun 21, 2017 at 8:27 PM, Boudhayan Gupta wrote: >>> You use something called "releaseme" to create a tarball, upload it to ftp >>> and ask Sysadmin to release it. Then you write a release announcement and >>> distro packagers pick it up. >>> >>> More detailed info here: https://techbase.kde.org/ReleasingExtragearSoftware >> >> Ping. >> Has there been any progress on getting the final location of KIO Stash >> finalised so it can move out of KDE Review? >> It appears to have passed unless there are any outstanding unresolved >> objections i've missed. >> >> Cheers, >> Ben >> >>> >>> >>> Freundliche Grüße >>> Boudhayan Gupta >>> KDE e.V. - Sysadmin and Community Working Groups >>> +49 151 71032970 >>> >>> On 21 June 2017 at 08:43, Arnav Dhamija wrote: Sounds great then. My question is - where are KDE Extragear apps actually distributed? Are they only available in repos, or are they distributed with mainline builds of Plasma distros such as Neon and Kubuntu? Also, are there any other follow up formalities I have to do to 'ship' this for good? On Wed, Jun 21, 2017 at 3:49 AM, Albert Astals Cid wrote: > El dimarts, 20 de juny de 2017, a les 11:24:49 CEST, Arnav Dhamija va > escriure: >> > ok, tests pass now here locally too, *but* they don't finish, i.e. >> > the >> > testdaemon process keeps running forever, does anyone else see this? >> >> It turns out I hadn't terminated the QProcess after the test case had >> finished executing. This is fixed in the latest commit to master. > > Great :) > >> >> > Can you please update your Readme.md? >> >> >> I have done this, with a small note under the heading mentioning that >> it is >> a GSoC project. > > Sounds good :) > >> Now, we can start discussing the shipping of the ioslave and whether >> it's a >> better fit for KDE extragear or for mainline KDE Frameworks. I would be >> happy with releasing it in extra gear initially and later moving it to >> KDE >> Applications/Frameworks if there is enough interest from the community >> to >> do so. > > Personally, i think you should go for extragear first since it gives you > much > more freedom on doing releases (vs a fixed 4 months for KDE > Applications) > which in case of a new project is always interesting since it allows you > to > introduce features more rapidly in answer to users that start using it. > On the > downside you need to learn to do the releases, but for a small product > is not > that hard. > > Cheers, > Albert > >> >> On Tue, Jun 20, 2017 at 2:34 AM, Albert Astals Cid >> wrote: >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija >> > va >> > >> > escriure: >> > > Hi! >> > > >> > > I had made the kio-stash ioslave last year as part of my GSoC 2016 >> > > Project. Now that most of the changes which I wished to make in >> > > Dolphin relevant to the ioslave are part of master, I wish to ship >> > > the >> > > ioslave soon. >> > > >> > > The project is now in KDE review and is awaiting feedback. The link >> > > for the same can be found here: >> > > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6 >> > >> > 672ac907b8 >> > >> > > The source of the project can be found here: >> > > https://cgit.kde.org/kio-stash.git/ >> > >> > Can you please update your Readme.md? >> > >> > # GSoC 2016 File Stash project for KDE >> > >> > sounds bad, we're not in 2016 anymore, >> > >> > # File Stash kioslave >> > >> > sounds more clear of what it is. >> > >> > Cheers, >> > >> > Albert >> > >> > > Thanks. > > -- arnav dhamija >>> >>> > > > > -- > arnav dhamija
Re: [kde-devel] Re: kio-stash is in KDE Review
Thanks for the suggestions. I've made all these changes in the latest commits. One thing bugging me is that the ID in the AppStream file needs a .desktop file, but I don't have one as this is an application. Should I leave it as it is or create a .desktop file for the same? I'll be uploading the tarball shortly. On Wed, Jun 28, 2017 at 9:05 PM, Jonathan Riddell wrote: > > Versioning entirely depends on the project in question. > > For a library with API/ABI stability it's important to set the right version > and update it on API/ABI changes. > > For anything else it's not too important but it's useful to have one > so people can report bugs on a known version, however I'm not sure > there's a good way to do so with a kioslave so maybe you can get away > with not doing it at all. > >> Also, I have some confusion about AppStream procedure. >> >> > Your desktop file should be org.kde.foo.desktop. This is also your >> > desktop-id, so whenver you may need that. It's basically your file name. >> > If you have a D-Bus service ... make sure that your D-Bus service name >> > matches this or change your desktop file to match the service address >> > (whichever seems more appropriate) >> > The name part 'foo' MUST be the name of your binary. >> >> In my case, I have two binaries - 'filestash.so' and >> 'stashnotifier.so'. I also have a D-Bus service name >> 'org.kde.kio.StashNotifier'. What would be my org.kde.foo name in this >> case? > > It's not an application so I don't think it needs to match to a .desktop > file, you'll need a AppStream file for it. I'm not sure what the > D-Bus stuff is about I'm afraid. > >> Also, as for the screenshot part - my application is not really a GUI >> application as it is an ioslave. Would a screenshot of Dolphin loading >> the stash:/ ioslave do for this purpose? > > Yes Dolphin would be fine, it's used by Discover and other package managers > when people are offered to install it. > > The files in the Git repository are still +x permission, that should be > removed. > > Jonathan -- arnav dhamija
Re: [kde-devel] Re: kio-stash is in KDE Review
Versioning entirely depends on the project in question. For a library with API/ABI stability it's important to set the right version and update it on API/ABI changes. For anything else it's not too important but it's useful to have one so people can report bugs on a known version, however I'm not sure there's a good way to do so with a kioslave so maybe you can get away with not doing it at all. > Also, I have some confusion about AppStream procedure. > > > Your desktop file should be org.kde.foo.desktop. This is also your > > desktop-id, so whenver you may need that. It's basically your file name. > > If you have a D-Bus service ... make sure that your D-Bus service name > > matches this or change your desktop file to match the service address > > (whichever seems more appropriate) > > The name part 'foo' MUST be the name of your binary. > > In my case, I have two binaries - 'filestash.so' and > 'stashnotifier.so'. I also have a D-Bus service name > 'org.kde.kio.StashNotifier'. What would be my org.kde.foo name in this > case? It's not an application so I don't think it needs to match to a .desktop file, you'll need a AppStream file for it. I'm not sure what the D-Bus stuff is about I'm afraid. > Also, as for the screenshot part - my application is not really a GUI > application as it is an ioslave. Would a screenshot of Dolphin loading > the stash:/ ioslave do for this purpose? Yes Dolphin would be fine, it's used by Discover and other package managers when people are offered to install it. The files in the Git repository are still +x permission, that should be removed. Jonathan
Re: [kde-devel] Re: kio-stash is in KDE Review
Is the versioning part on that page still relevant? Many KDE applications I've seen just list the required version of a library as a single decimal separated string (e.g. KF5_MIN_VERSION "5.28.0" rather than splitting it into variables). Also, I have some confusion about AppStream procedure. > Your desktop file should be org.kde.foo.desktop. This is also your > desktop-id, so whenver you may need that. It's basically your file name. > If you have a D-Bus service ... make sure that your D-Bus service name > matches this or change your desktop file to match the service address > (whichever seems more appropriate) > The name part 'foo' MUST be the name of your binary. In my case, I have two binaries - 'filestash.so' and 'stashnotifier.so'. I also have a D-Bus service name 'org.kde.kio.StashNotifier'. What would be my org.kde.foo name in this case? Also, as for the screenshot part - my application is not really a GUI application as it is an ioslave. Would a screenshot of Dolphin loading the stash:/ ioslave do for this purpose? On Wed, Jun 28, 2017 at 4:47 PM, Jonathan Riddell wrote: > > The page was out of date so I made some updates. Let me know of any unclear > or missing information. > https://techbase.kde.org/ReleasingExtragearSoftware > > You need to remove kio-stash from kdereview in repo-metadata, this will mess > up the translations. > > You have i18n() used but no Messages.sh to extract the messages. > > You need to include a full copy of GPL 2 in a file called COPYING in the top > level of the repo. > > You should include an AppStream file and add a screenshot to > product-screenshots > https://community.kde.org/Guidelines_and_HOWTOs/AppStream > https://phabricator.kde.org/source/websites-product-screenshots/ > > Jonathan -- arnav dhamija
Re: [kde-devel] Re: kio-stash is in KDE Review
Minor nitpicks: 1) Tag names should start with v, such as "v1.2.3" 2) You don't actually have to sign the tarball cryptographically, just give sysadmin a SHA2-256 or better hash out-of-band (i.e., through Phabricator which you access over HTTPS). Freundliche Grüße Boudhayan Gupta KDE e.V. - Sysadmin and Community Working Groups +49 151 71032970 On 28 June 2017 at 13:17, Jonathan Riddell wrote: > > The page was out of date so I made some updates. Let me know of any > unclear or missing information. > https://techbase.kde.org/ReleasingExtragearSoftware > > You need to remove kio-stash from kdereview in repo-metadata, this will > mess up the translations. > > You have i18n() used but no Messages.sh to extract the messages. > > You need to include a full copy of GPL 2 in a file called COPYING in the > top level of the repo. > > You should include an AppStream file and add a screenshot to > product-screenshots > https://community.kde.org/Guidelines_and_HOWTOs/AppStream > https://phabricator.kde.org/source/websites-product-screenshots/ > > Jonathan >
Re: [kde-devel] Re: kio-stash is in KDE Review
The page was out of date so I made some updates. Let me know of any unclear or missing information. https://techbase.kde.org/ReleasingExtragearSoftware You need to remove kio-stash from kdereview in repo-metadata, this will mess up the translations. You have i18n() used but no Messages.sh to extract the messages. You need to include a full copy of GPL 2 in a file called COPYING in the top level of the repo. You should include an AppStream file and add a screenshot to product-screenshots https://community.kde.org/Guidelines_and_HOWTOs/AppStream https://phabricator.kde.org/source/websites-product-screenshots/ Jonathan
Re: kio-stash is in KDE Review
Yes. I have decided to move it under KDE ExtraGear Utils. I'm working with the guide Boudhayan posted in the previous email to make a tarball out of it to ship it for release. On Wed, Jun 28, 2017 at 4:01 AM, Ben Cooksley wrote: > On Wed, Jun 21, 2017 at 8:27 PM, Boudhayan Gupta wrote: >> You use something called "releaseme" to create a tarball, upload it to ftp >> and ask Sysadmin to release it. Then you write a release announcement and >> distro packagers pick it up. >> >> More detailed info here: https://techbase.kde.org/ReleasingExtragearSoftware > > Ping. > Has there been any progress on getting the final location of KIO Stash > finalised so it can move out of KDE Review? > It appears to have passed unless there are any outstanding unresolved > objections i've missed. > > Cheers, > Ben > >> >> >> Freundliche Grüße >> Boudhayan Gupta >> KDE e.V. - Sysadmin and Community Working Groups >> +49 151 71032970 >> >> On 21 June 2017 at 08:43, Arnav Dhamija wrote: >>> >>> Sounds great then. My question is - where are KDE Extragear apps >>> actually distributed? Are they only available in repos, or are they >>> distributed with mainline builds of Plasma distros such as Neon and >>> Kubuntu? >>> >>> Also, are there any other follow up formalities I have to do to 'ship' >>> this for good? >>> >>> On Wed, Jun 21, 2017 at 3:49 AM, Albert Astals Cid wrote: >>> > El dimarts, 20 de juny de 2017, a les 11:24:49 CEST, Arnav Dhamija va >>> > escriure: >>> >> > ok, tests pass now here locally too, *but* they don't finish, i.e. >>> >> > the >>> >> > testdaemon process keeps running forever, does anyone else see this? >>> >> >>> >> It turns out I hadn't terminated the QProcess after the test case had >>> >> finished executing. This is fixed in the latest commit to master. >>> > >>> > Great :) >>> > >>> >> >>> >> > Can you please update your Readme.md? >>> >> >>> >> >>> >> I have done this, with a small note under the heading mentioning that >>> >> it is >>> >> a GSoC project. >>> > >>> > Sounds good :) >>> > >>> >> Now, we can start discussing the shipping of the ioslave and whether >>> >> it's a >>> >> better fit for KDE extragear or for mainline KDE Frameworks. I would be >>> >> happy with releasing it in extra gear initially and later moving it to >>> >> KDE >>> >> Applications/Frameworks if there is enough interest from the community >>> >> to >>> >> do so. >>> > >>> > Personally, i think you should go for extragear first since it gives you >>> > much >>> > more freedom on doing releases (vs a fixed 4 months for KDE >>> > Applications) >>> > which in case of a new project is always interesting since it allows you >>> > to >>> > introduce features more rapidly in answer to users that start using it. >>> > On the >>> > downside you need to learn to do the releases, but for a small product >>> > is not >>> > that hard. >>> > >>> > Cheers, >>> > Albert >>> > >>> >> >>> >> On Tue, Jun 20, 2017 at 2:34 AM, Albert Astals Cid >>> >> wrote: >>> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija >>> >> > va >>> >> > >>> >> > escriure: >>> >> > > Hi! >>> >> > > >>> >> > > I had made the kio-stash ioslave last year as part of my GSoC 2016 >>> >> > > Project. Now that most of the changes which I wished to make in >>> >> > > Dolphin relevant to the ioslave are part of master, I wish to ship >>> >> > > the >>> >> > > ioslave soon. >>> >> > > >>> >> > > The project is now in KDE review and is awaiting feedback. The link >>> >> > > for the same can be found here: >>> >> > > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6 >>> >> > >>> >> > 672ac907b8 >>> >> > >>> >> > > The source of the project can be found here: >>> >> > > https://cgit.kde.org/kio-stash.git/ >>> >> > >>> >> > Can you please update your Readme.md? >>> >> > >>> >> > # GSoC 2016 File Stash project for KDE >>> >> > >>> >> > sounds bad, we're not in 2016 anymore, >>> >> > >>> >> > # File Stash kioslave >>> >> > >>> >> > sounds more clear of what it is. >>> >> > >>> >> > Cheers, >>> >> > >>> >> > Albert >>> >> > >>> >> > > Thanks. >>> > >>> > >>> >>> >>> >>> -- >>> arnav dhamija >> >> -- arnav dhamija
Re: kio-stash is in KDE Review
On Wed, Jun 21, 2017 at 8:27 PM, Boudhayan Gupta wrote: > You use something called "releaseme" to create a tarball, upload it to ftp > and ask Sysadmin to release it. Then you write a release announcement and > distro packagers pick it up. > > More detailed info here: https://techbase.kde.org/ReleasingExtragearSoftware Ping. Has there been any progress on getting the final location of KIO Stash finalised so it can move out of KDE Review? It appears to have passed unless there are any outstanding unresolved objections i've missed. Cheers, Ben > > > Freundliche Grüße > Boudhayan Gupta > KDE e.V. - Sysadmin and Community Working Groups > +49 151 71032970 > > On 21 June 2017 at 08:43, Arnav Dhamija wrote: >> >> Sounds great then. My question is - where are KDE Extragear apps >> actually distributed? Are they only available in repos, or are they >> distributed with mainline builds of Plasma distros such as Neon and >> Kubuntu? >> >> Also, are there any other follow up formalities I have to do to 'ship' >> this for good? >> >> On Wed, Jun 21, 2017 at 3:49 AM, Albert Astals Cid wrote: >> > El dimarts, 20 de juny de 2017, a les 11:24:49 CEST, Arnav Dhamija va >> > escriure: >> >> > ok, tests pass now here locally too, *but* they don't finish, i.e. >> >> > the >> >> > testdaemon process keeps running forever, does anyone else see this? >> >> >> >> It turns out I hadn't terminated the QProcess after the test case had >> >> finished executing. This is fixed in the latest commit to master. >> > >> > Great :) >> > >> >> >> >> > Can you please update your Readme.md? >> >> >> >> >> >> I have done this, with a small note under the heading mentioning that >> >> it is >> >> a GSoC project. >> > >> > Sounds good :) >> > >> >> Now, we can start discussing the shipping of the ioslave and whether >> >> it's a >> >> better fit for KDE extragear or for mainline KDE Frameworks. I would be >> >> happy with releasing it in extra gear initially and later moving it to >> >> KDE >> >> Applications/Frameworks if there is enough interest from the community >> >> to >> >> do so. >> > >> > Personally, i think you should go for extragear first since it gives you >> > much >> > more freedom on doing releases (vs a fixed 4 months for KDE >> > Applications) >> > which in case of a new project is always interesting since it allows you >> > to >> > introduce features more rapidly in answer to users that start using it. >> > On the >> > downside you need to learn to do the releases, but for a small product >> > is not >> > that hard. >> > >> > Cheers, >> > Albert >> > >> >> >> >> On Tue, Jun 20, 2017 at 2:34 AM, Albert Astals Cid >> >> wrote: >> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija >> >> > va >> >> > >> >> > escriure: >> >> > > Hi! >> >> > > >> >> > > I had made the kio-stash ioslave last year as part of my GSoC 2016 >> >> > > Project. Now that most of the changes which I wished to make in >> >> > > Dolphin relevant to the ioslave are part of master, I wish to ship >> >> > > the >> >> > > ioslave soon. >> >> > > >> >> > > The project is now in KDE review and is awaiting feedback. The link >> >> > > for the same can be found here: >> >> > > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6 >> >> > >> >> > 672ac907b8 >> >> > >> >> > > The source of the project can be found here: >> >> > > https://cgit.kde.org/kio-stash.git/ >> >> > >> >> > Can you please update your Readme.md? >> >> > >> >> > # GSoC 2016 File Stash project for KDE >> >> > >> >> > sounds bad, we're not in 2016 anymore, >> >> > >> >> > # File Stash kioslave >> >> > >> >> > sounds more clear of what it is. >> >> > >> >> > Cheers, >> >> > >> >> > Albert >> >> > >> >> > > Thanks. >> > >> > >> >> >> >> -- >> arnav dhamija > >
Re: kio-stash is in KDE Review
You use something called "releaseme" to create a tarball, upload it to ftp and ask Sysadmin to release it. Then you write a release announcement and distro packagers pick it up. More detailed info here: https://techbase.kde.org/ReleasingExtragearSoftware Freundliche Grüße Boudhayan Gupta KDE e.V. - Sysadmin and Community Working Groups +49 151 71032970 On 21 June 2017 at 08:43, Arnav Dhamija wrote: > Sounds great then. My question is - where are KDE Extragear apps > actually distributed? Are they only available in repos, or are they > distributed with mainline builds of Plasma distros such as Neon and > Kubuntu? > > Also, are there any other follow up formalities I have to do to 'ship' > this for good? > > On Wed, Jun 21, 2017 at 3:49 AM, Albert Astals Cid wrote: > > El dimarts, 20 de juny de 2017, a les 11:24:49 CEST, Arnav Dhamija va > > escriure: > >> > ok, tests pass now here locally too, *but* they don't finish, i.e. the > >> > testdaemon process keeps running forever, does anyone else see this? > >> > >> It turns out I hadn't terminated the QProcess after the test case had > >> finished executing. This is fixed in the latest commit to master. > > > > Great :) > > > >> > >> > Can you please update your Readme.md? > >> > >> > >> I have done this, with a small note under the heading mentioning that > it is > >> a GSoC project. > > > > Sounds good :) > > > >> Now, we can start discussing the shipping of the ioslave and whether > it's a > >> better fit for KDE extragear or for mainline KDE Frameworks. I would be > >> happy with releasing it in extra gear initially and later moving it to > KDE > >> Applications/Frameworks if there is enough interest from the community > to > >> do so. > > > > Personally, i think you should go for extragear first since it gives you > much > > more freedom on doing releases (vs a fixed 4 months for KDE Applications) > > which in case of a new project is always interesting since it allows you > to > > introduce features more rapidly in answer to users that start using it. > On the > > downside you need to learn to do the releases, but for a small product > is not > > that hard. > > > > Cheers, > > Albert > > > >> > >> On Tue, Jun 20, 2017 at 2:34 AM, Albert Astals Cid > wrote: > >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija > va > >> > > >> > escriure: > >> > > Hi! > >> > > > >> > > I had made the kio-stash ioslave last year as part of my GSoC 2016 > >> > > Project. Now that most of the changes which I wished to make in > >> > > Dolphin relevant to the ioslave are part of master, I wish to ship > the > >> > > ioslave soon. > >> > > > >> > > The project is now in KDE review and is awaiting feedback. The link > >> > > for the same can be found here: > >> > > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6 > >> > > >> > 672ac907b8 > >> > > >> > > The source of the project can be found here: > >> > > https://cgit.kde.org/kio-stash.git/ > >> > > >> > Can you please update your Readme.md? > >> > > >> > # GSoC 2016 File Stash project for KDE > >> > > >> > sounds bad, we're not in 2016 anymore, > >> > > >> > # File Stash kioslave > >> > > >> > sounds more clear of what it is. > >> > > >> > Cheers, > >> > > >> > Albert > >> > > >> > > Thanks. > > > > > > > > -- > arnav dhamija >
Re: kio-stash is in KDE Review
Sounds great then. My question is - where are KDE Extragear apps actually distributed? Are they only available in repos, or are they distributed with mainline builds of Plasma distros such as Neon and Kubuntu? Also, are there any other follow up formalities I have to do to 'ship' this for good? On Wed, Jun 21, 2017 at 3:49 AM, Albert Astals Cid wrote: > El dimarts, 20 de juny de 2017, a les 11:24:49 CEST, Arnav Dhamija va > escriure: >> > ok, tests pass now here locally too, *but* they don't finish, i.e. the >> > testdaemon process keeps running forever, does anyone else see this? >> >> It turns out I hadn't terminated the QProcess after the test case had >> finished executing. This is fixed in the latest commit to master. > > Great :) > >> >> > Can you please update your Readme.md? >> >> >> I have done this, with a small note under the heading mentioning that it is >> a GSoC project. > > Sounds good :) > >> Now, we can start discussing the shipping of the ioslave and whether it's a >> better fit for KDE extragear or for mainline KDE Frameworks. I would be >> happy with releasing it in extra gear initially and later moving it to KDE >> Applications/Frameworks if there is enough interest from the community to >> do so. > > Personally, i think you should go for extragear first since it gives you much > more freedom on doing releases (vs a fixed 4 months for KDE Applications) > which in case of a new project is always interesting since it allows you to > introduce features more rapidly in answer to users that start using it. On the > downside you need to learn to do the releases, but for a small product is not > that hard. > > Cheers, > Albert > >> >> On Tue, Jun 20, 2017 at 2:34 AM, Albert Astals Cid wrote: >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va >> > >> > escriure: >> > > Hi! >> > > >> > > I had made the kio-stash ioslave last year as part of my GSoC 2016 >> > > Project. Now that most of the changes which I wished to make in >> > > Dolphin relevant to the ioslave are part of master, I wish to ship the >> > > ioslave soon. >> > > >> > > The project is now in KDE review and is awaiting feedback. The link >> > > for the same can be found here: >> > > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6 >> > >> > 672ac907b8 >> > >> > > The source of the project can be found here: >> > > https://cgit.kde.org/kio-stash.git/ >> > >> > Can you please update your Readme.md? >> > >> > # GSoC 2016 File Stash project for KDE >> > >> > sounds bad, we're not in 2016 anymore, >> > >> > # File Stash kioslave >> > >> > sounds more clear of what it is. >> > >> > Cheers, >> > >> > Albert >> > >> > > Thanks. > > -- arnav dhamija
Re: kio-stash is in KDE Review
El dimarts, 20 de juny de 2017, a les 11:24:49 CEST, Arnav Dhamija va escriure: > > ok, tests pass now here locally too, *but* they don't finish, i.e. the > > testdaemon process keeps running forever, does anyone else see this? > > It turns out I hadn't terminated the QProcess after the test case had > finished executing. This is fixed in the latest commit to master. Great :) > > > Can you please update your Readme.md? > > > I have done this, with a small note under the heading mentioning that it is > a GSoC project. Sounds good :) > Now, we can start discussing the shipping of the ioslave and whether it's a > better fit for KDE extragear or for mainline KDE Frameworks. I would be > happy with releasing it in extra gear initially and later moving it to KDE > Applications/Frameworks if there is enough interest from the community to > do so. Personally, i think you should go for extragear first since it gives you much more freedom on doing releases (vs a fixed 4 months for KDE Applications) which in case of a new project is always interesting since it allows you to introduce features more rapidly in answer to users that start using it. On the downside you need to learn to do the releases, but for a small product is not that hard. Cheers, Albert > > On Tue, Jun 20, 2017 at 2:34 AM, Albert Astals Cid wrote: > > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va > > > > escriure: > > > Hi! > > > > > > I had made the kio-stash ioslave last year as part of my GSoC 2016 > > > Project. Now that most of the changes which I wished to make in > > > Dolphin relevant to the ioslave are part of master, I wish to ship the > > > ioslave soon. > > > > > > The project is now in KDE review and is awaiting feedback. The link > > > for the same can be found here: > > > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6 > > > > 672ac907b8 > > > > > The source of the project can be found here: > > > https://cgit.kde.org/kio-stash.git/ > > > > Can you please update your Readme.md? > > > > # GSoC 2016 File Stash project for KDE > > > > sounds bad, we're not in 2016 anymore, > > > > # File Stash kioslave > > > > sounds more clear of what it is. > > > > Cheers, > > > > Albert > > > > > Thanks.
Re: kio-stash is in KDE Review
> > ok, tests pass now here locally too, *but* they don't finish, i.e. the > testdaemon process keeps running forever, does anyone else see this? It turns out I hadn't terminated the QProcess after the test case had finished executing. This is fixed in the latest commit to master. Can you please update your Readme.md? > I have done this, with a small note under the heading mentioning that it is a GSoC project. Now, we can start discussing the shipping of the ioslave and whether it's a better fit for KDE extragear or for mainline KDE Frameworks. I would be happy with releasing it in extra gear initially and later moving it to KDE Applications/Frameworks if there is enough interest from the community to do so. On Tue, Jun 20, 2017 at 2:34 AM, Albert Astals Cid wrote: > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va > escriure: > > Hi! > > > > I had made the kio-stash ioslave last year as part of my GSoC 2016 > > Project. Now that most of the changes which I wished to make in > > Dolphin relevant to the ioslave are part of master, I wish to ship the > > ioslave soon. > > > > The project is now in KDE review and is awaiting feedback. The link > > for the same can be found here: > > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6 > 672ac907b8 > > > > The source of the project can be found here: > > https://cgit.kde.org/kio-stash.git/ > > Can you please update your Readme.md? > > # GSoC 2016 File Stash project for KDE > > sounds bad, we're not in 2016 anymore, > > # File Stash kioslave > > sounds more clear of what it is. > > Cheers, > Albert > > > > > Thanks. > > > -- arnav dhamija
Re: kio-stash is in KDE Review
El dilluns, 19 de juny de 2017, a les 10:06:35 CEST, Jonathan Riddell va escriure: > Better as kio-extras in KDE Applications no? I've no idea, the original email didn't explain what kio-stash is. Ok, i went and read the README.md to me it really sounds really specialized, but if the world wants it in kio-extras i won't complain much. Cheers, Albert > > Jonathan > > On 19 June 2017 at 10:00, Arnav Dhamija wrote: > > Thanks. I have fixed this and the kio-stash ioslave passes all the > > test cases on CI here: > > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20k > > f5-qt5%20SUSEQt5.9/ > > > > The build log for the same can be found here: > > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20k > > f5-qt5%20SUSEQt5.9/11/timestamps/?time=HH:mm:ss&appendLog&locale=en_US > > > > I feel the ioslave is now ready to be shipped. The question is if it > > can be included as part of KDE Frameworks for the next major release > > or if it should be a separate package only in KDE Extra gear. > > > > On Mon, Jun 19, 2017 at 3:07 AM, Albert Astals Cid wrote: > >> El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va > >> > >> escriure: > >>> Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and > >>> ran the following commands after cloning the repo and creating a build > >>> directory: > >>> > >>> cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE .. > >>> make > >> > >> git code does not compile as of now. > >> > >> Cheers, > >> > >> Albert > >>> > >>> sudo make install > >>> kdeinit5 > >>> > >>> ..and then I ran the tests using 'ctest -v'. It passed slavetest with > >>> no issues (18 out of 18 tests passed). My guess why it doesn't work > >>> you is because you haven't run kdeinit5 after installing the ioslave. > >>> If not that, the testdaemon process might not have been successfully > >>> registered on the system D-Bus when thes test is run. > >>> > >>> Is there a way I can see if my test cases pass on KDE's CI > >>> infrastructure to narrow down the problem? If so, I will a sysadmin to > >>> do so. > >>> > >>> On Tue, Jun 13, 2017 at 4:16 AM, Albert Astals Cid wrote: > >>> > El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va > >>> > > >>> > escriure: > >>> >> > Do you mean i have to manually start a process for the tests to > >>> >> > succeed? > >>> >> > >>> >> If installed correctly with kdeinit restarted and the Stash Daemon is > >>> >> running in kded5, it is not required. However, I cannot recall what > >>> >> steps are needed for this to happen as I think it requires a system > >>> >> restart or logout to do so. > >>> >> > >>> >> Hence, I have created a fallback testdaemon program which creates a > >>> >> daemon process for the Stash Daemon to run. This is launched > >>> >> automatically by the test suite if the test suite cannot find the > >>> >> Stash Daemon running in kded. I just patched it so that it finds the > >>> >> path to the testdaemon program correctly (it had the wrong path when > >>> >> you tested it). It should pass the test cases now with no manual > >>> >> invocation of the testdaemon process. > >>> > > >>> > Doesn't seem to work for me. > >>> > > >>> > https://paste.kde.org/ptnn5hhkt > >>> > > >>> > Cheers, > >>> > > >>> > Albert > >>> >> > >>> >> On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid wrote: > >>> >> > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va > >>> > > >>> > escriure: > >>> >> >> Yes, I will file a sysadmin ticket for the same. Until I do so, > >>> >> >> could > >>> >> >> you send me the output of the test suite in a screenshot or as > >>> >> >> plain > >>> >> >> text? > >>> >> >> > >>> >> >> The ioslave works by storing a list of virtual files and folders > >>> >> >> in a > >>> >> >> process running in the KDED, communicating with it over D-Bus. > >>> >> >> Hence, > >>> >> >> some of the tests won't work unless a) the testdaemon process is > >>> >> >> started > >>> >> > > >>> >> > Do you mean i have to manually start a process for the tests to > >>> >> > succeed? > >>> >> > > >>> >> > If that is the case, that's not acceptable. > >>> >> > > >>> >> > Cheers, > >>> >> > > >>> >> > Albert > >>> >> >> > >>> >> >> or b) the Stash KIO slave watcher is running in KDED. Usually > >>> >> >> it requires a restart of KDED and a kdeinit after installing the > >>> >> >> ioslave to have the Stash daemon running in KDED. > >>> >> >> > >>> >> >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid > >> > >> wrote: > >>> >> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav > >>> >> >> > Dhamija > >>> >> >> > va > >>> >> >> > > >>> >> >> > escriure: > >>> >> >> >> Hi! > >>> >> >> >> > >>> >> >> >> I had made the kio-stash ioslave last year as part of my GSoC > >>> >> >> >> 2016 > >>> >> >> >> Project. Now that most of the changes which I wished to make in > >>> >> >> >> Dolphin relevant
Re: kio-stash is in KDE Review
El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va escriure: > Hi! > > I had made the kio-stash ioslave last year as part of my GSoC 2016 > Project. Now that most of the changes which I wished to make in > Dolphin relevant to the ioslave are part of master, I wish to ship the > ioslave soon. > > The project is now in KDE review and is awaiting feedback. The link > for the same can be found here: > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672ac907b8 > > The source of the project can be found here: > https://cgit.kde.org/kio-stash.git/ Can you please update your Readme.md? # GSoC 2016 File Stash project for KDE sounds bad, we're not in 2016 anymore, # File Stash kioslave sounds more clear of what it is. Cheers, Albert > > Thanks.
Re: kio-stash is in KDE Review
El dilluns, 19 de juny de 2017, a les 14:30:22 CEST, Arnav Dhamija va escriure: > Thanks. I have fixed this and the kio-stash ioslave passes all the > test cases on CI here: > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5 > -qt5%20SUSEQt5.9/ > > The build log for the same can be found here: > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5 > -qt5%20SUSEQt5.9/11/timestamps/?time=HH:mm:ss&appendLog&locale=en_US ok, tests pass now here locally too, *but* they don't finish, i.e. the testdaemon process keeps running forever, does anyone else see this? Cheers, Albert > > I feel the ioslave is now ready to be shipped. The question is if it > can be included as part of KDE Frameworks for the next major release > or if it should be a separate package only in KDE Extra gear. > > On Mon, Jun 19, 2017 at 3:07 AM, Albert Astals Cid wrote: > > El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va > > > > escriure: > >> Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and > >> ran the following commands after cloning the repo and creating a build > >> directory: > >> > >> cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE .. > >> make > > > > git code does not compile as of now. > > > > Cheers, > > > > Albert > >> > >> sudo make install > >> kdeinit5 > >> > >> ..and then I ran the tests using 'ctest -v'. It passed slavetest with > >> no issues (18 out of 18 tests passed). My guess why it doesn't work > >> you is because you haven't run kdeinit5 after installing the ioslave. > >> If not that, the testdaemon process might not have been successfully > >> registered on the system D-Bus when thes test is run. > >> > >> Is there a way I can see if my test cases pass on KDE's CI > >> infrastructure to narrow down the problem? If so, I will a sysadmin to > >> do so. > >> > >> On Tue, Jun 13, 2017 at 4:16 AM, Albert Astals Cid wrote: > >> > El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va > >> > > >> > escriure: > >> >> > Do you mean i have to manually start a process for the tests to > >> >> > succeed? > >> >> > >> >> If installed correctly with kdeinit restarted and the Stash Daemon is > >> >> running in kded5, it is not required. However, I cannot recall what > >> >> steps are needed for this to happen as I think it requires a system > >> >> restart or logout to do so. > >> >> > >> >> Hence, I have created a fallback testdaemon program which creates a > >> >> daemon process for the Stash Daemon to run. This is launched > >> >> automatically by the test suite if the test suite cannot find the > >> >> Stash Daemon running in kded. I just patched it so that it finds the > >> >> path to the testdaemon program correctly (it had the wrong path when > >> >> you tested it). It should pass the test cases now with no manual > >> >> invocation of the testdaemon process. > >> > > >> > Doesn't seem to work for me. > >> > > >> > https://paste.kde.org/ptnn5hhkt > >> > > >> > Cheers, > >> > > >> > Albert > >> >> > >> >> On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid wrote: > >> >> > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va > >> > > >> > escriure: > >> >> >> Yes, I will file a sysadmin ticket for the same. Until I do so, > >> >> >> could > >> >> >> you send me the output of the test suite in a screenshot or as > >> >> >> plain > >> >> >> text? > >> >> >> > >> >> >> The ioslave works by storing a list of virtual files and folders in > >> >> >> a > >> >> >> process running in the KDED, communicating with it over D-Bus. > >> >> >> Hence, > >> >> >> some of the tests won't work unless a) the testdaemon process is > >> >> >> started > >> >> > > >> >> > Do you mean i have to manually start a process for the tests to > >> >> > succeed? > >> >> > > >> >> > If that is the case, that's not acceptable. > >> >> > > >> >> > Cheers, > >> >> > > >> >> > Albert > >> >> >> > >> >> >> or b) the Stash KIO slave watcher is running in KDED. Usually > >> >> >> it requires a restart of KDED and a kdeinit after installing the > >> >> >> ioslave to have the Stash daemon running in KDED. > >> >> >> > >> >> >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid > > > > wrote: > >> >> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav > >> >> >> > Dhamija > >> >> >> > va > >> >> >> > > >> >> >> > escriure: > >> >> >> >> Hi! > >> >> >> >> > >> >> >> >> I had made the kio-stash ioslave last year as part of my GSoC > >> >> >> >> 2016 > >> >> >> >> Project. Now that most of the changes which I wished to make in > >> >> >> >> Dolphin relevant to the ioslave are part of master, I wish to > >> >> >> >> ship > >> >> >> >> the > >> >> >> >> ioslave soon. > >> >> >> >> > >> >> >> >> The project is now in KDE review and is awaiting feedback. The > >> >> >> >> link > >> >> >> >> for the same can be found here: > >> >> >> >> https://phabricator.kde.org/R247:0
Re: kio-stash is in KDE Review
Better as kio-extras in KDE Applications no? Jonathan On 19 June 2017 at 10:00, Arnav Dhamija wrote: > Thanks. I have fixed this and the kio-stash ioslave passes all the > test cases on CI here: > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5-qt5%20SUSEQt5.9/ > > The build log for the same can be found here: > https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5-qt5%20SUSEQt5.9/11/timestamps/?time=HH:mm:ss&appendLog&locale=en_US > > I feel the ioslave is now ready to be shipped. The question is if it > can be included as part of KDE Frameworks for the next major release > or if it should be a separate package only in KDE Extra gear. > > On Mon, Jun 19, 2017 at 3:07 AM, Albert Astals Cid wrote: >> El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va >> escriure: >>> Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and >>> ran the following commands after cloning the repo and creating a build >>> directory: >>> >>> cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE .. >>> make >> >> git code does not compile as of now. >> >> Cheers, >> Albert >> >>> sudo make install >>> kdeinit5 >>> >>> ..and then I ran the tests using 'ctest -v'. It passed slavetest with >>> no issues (18 out of 18 tests passed). My guess why it doesn't work >>> you is because you haven't run kdeinit5 after installing the ioslave. >>> If not that, the testdaemon process might not have been successfully >>> registered on the system D-Bus when thes test is run. >>> >>> Is there a way I can see if my test cases pass on KDE's CI >>> infrastructure to narrow down the problem? If so, I will a sysadmin to >>> do so. >>> >>> On Tue, Jun 13, 2017 at 4:16 AM, Albert Astals Cid wrote: >>> > El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va >>> > >>> > escriure: >>> >> > Do you mean i have to manually start a process for the tests to >>> >> > succeed? >>> >> >>> >> If installed correctly with kdeinit restarted and the Stash Daemon is >>> >> running in kded5, it is not required. However, I cannot recall what >>> >> steps are needed for this to happen as I think it requires a system >>> >> restart or logout to do so. >>> >> >>> >> Hence, I have created a fallback testdaemon program which creates a >>> >> daemon process for the Stash Daemon to run. This is launched >>> >> automatically by the test suite if the test suite cannot find the >>> >> Stash Daemon running in kded. I just patched it so that it finds the >>> >> path to the testdaemon program correctly (it had the wrong path when >>> >> you tested it). It should pass the test cases now with no manual >>> >> invocation of the testdaemon process. >>> > >>> > Doesn't seem to work for me. >>> > >>> > https://paste.kde.org/ptnn5hhkt >>> > >>> > Cheers, >>> > >>> > Albert >>> >> >>> >> On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid wrote: >>> >> > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va >>> > >>> > escriure: >>> >> >> Yes, I will file a sysadmin ticket for the same. Until I do so, could >>> >> >> you send me the output of the test suite in a screenshot or as plain >>> >> >> text? >>> >> >> >>> >> >> The ioslave works by storing a list of virtual files and folders in a >>> >> >> process running in the KDED, communicating with it over D-Bus. Hence, >>> >> >> some of the tests won't work unless a) the testdaemon process is >>> >> >> started >>> >> > >>> >> > Do you mean i have to manually start a process for the tests to >>> >> > succeed? >>> >> > >>> >> > If that is the case, that's not acceptable. >>> >> > >>> >> > Cheers, >>> >> > >>> >> > Albert >>> >> >> >>> >> >> or b) the Stash KIO slave watcher is running in KDED. Usually >>> >> >> it requires a restart of KDED and a kdeinit after installing the >>> >> >> ioslave to have the Stash daemon running in KDED. >>> >> >> >>> >> >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid >> wrote: >>> >> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija >>> >> >> > va >>> >> >> > >>> >> >> > escriure: >>> >> >> >> Hi! >>> >> >> >> >>> >> >> >> I had made the kio-stash ioslave last year as part of my GSoC 2016 >>> >> >> >> Project. Now that most of the changes which I wished to make in >>> >> >> >> Dolphin relevant to the ioslave are part of master, I wish to ship >>> >> >> >> the >>> >> >> >> ioslave soon. >>> >> >> >> >>> >> >> >> The project is now in KDE review and is awaiting feedback. The link >>> >> >> >> for the same can be found here: >>> >> >> >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672a >>> >> >> >> c90 >>> >> >> >> 7b8 >>> >> >> >> >>> >> >> >> The source of the project can be found here: >>> >> >> >> https://cgit.kde.org/kio-stash.git/ >>> >> >> > >>> >> >> > Can you please get it covered by the CI? >>> >> >> > >>> >> >> > I have some of the tests failing but don't know if it is because my >>> >> >> > setup >>> >> >> > is a bit br
Re: kio-stash is in KDE Review
Thanks. I have fixed this and the kio-stash ioslave passes all the test cases on CI here: https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5-qt5%20SUSEQt5.9/ The build log for the same can be found here: https://build-sandbox.kde.org/view/Extragear/job/Extragear%20kio-stash%20kf5-qt5%20SUSEQt5.9/11/timestamps/?time=HH:mm:ss&appendLog&locale=en_US I feel the ioslave is now ready to be shipped. The question is if it can be included as part of KDE Frameworks for the next major release or if it should be a separate package only in KDE Extra gear. On Mon, Jun 19, 2017 at 3:07 AM, Albert Astals Cid wrote: > El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va > escriure: >> Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and >> ran the following commands after cloning the repo and creating a build >> directory: >> >> cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE .. >> make > > git code does not compile as of now. > > Cheers, > Albert > >> sudo make install >> kdeinit5 >> >> ..and then I ran the tests using 'ctest -v'. It passed slavetest with >> no issues (18 out of 18 tests passed). My guess why it doesn't work >> you is because you haven't run kdeinit5 after installing the ioslave. >> If not that, the testdaemon process might not have been successfully >> registered on the system D-Bus when thes test is run. >> >> Is there a way I can see if my test cases pass on KDE's CI >> infrastructure to narrow down the problem? If so, I will a sysadmin to >> do so. >> >> On Tue, Jun 13, 2017 at 4:16 AM, Albert Astals Cid wrote: >> > El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va >> > >> > escriure: >> >> > Do you mean i have to manually start a process for the tests to >> >> > succeed? >> >> >> >> If installed correctly with kdeinit restarted and the Stash Daemon is >> >> running in kded5, it is not required. However, I cannot recall what >> >> steps are needed for this to happen as I think it requires a system >> >> restart or logout to do so. >> >> >> >> Hence, I have created a fallback testdaemon program which creates a >> >> daemon process for the Stash Daemon to run. This is launched >> >> automatically by the test suite if the test suite cannot find the >> >> Stash Daemon running in kded. I just patched it so that it finds the >> >> path to the testdaemon program correctly (it had the wrong path when >> >> you tested it). It should pass the test cases now with no manual >> >> invocation of the testdaemon process. >> > >> > Doesn't seem to work for me. >> > >> > https://paste.kde.org/ptnn5hhkt >> > >> > Cheers, >> > >> > Albert >> >> >> >> On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid wrote: >> >> > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va >> > >> > escriure: >> >> >> Yes, I will file a sysadmin ticket for the same. Until I do so, could >> >> >> you send me the output of the test suite in a screenshot or as plain >> >> >> text? >> >> >> >> >> >> The ioslave works by storing a list of virtual files and folders in a >> >> >> process running in the KDED, communicating with it over D-Bus. Hence, >> >> >> some of the tests won't work unless a) the testdaemon process is >> >> >> started >> >> > >> >> > Do you mean i have to manually start a process for the tests to >> >> > succeed? >> >> > >> >> > If that is the case, that's not acceptable. >> >> > >> >> > Cheers, >> >> > >> >> > Albert >> >> >> >> >> >> or b) the Stash KIO slave watcher is running in KDED. Usually >> >> >> it requires a restart of KDED and a kdeinit after installing the >> >> >> ioslave to have the Stash daemon running in KDED. >> >> >> >> >> >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid > wrote: >> >> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija >> >> >> > va >> >> >> > >> >> >> > escriure: >> >> >> >> Hi! >> >> >> >> >> >> >> >> I had made the kio-stash ioslave last year as part of my GSoC 2016 >> >> >> >> Project. Now that most of the changes which I wished to make in >> >> >> >> Dolphin relevant to the ioslave are part of master, I wish to ship >> >> >> >> the >> >> >> >> ioslave soon. >> >> >> >> >> >> >> >> The project is now in KDE review and is awaiting feedback. The link >> >> >> >> for the same can be found here: >> >> >> >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672a >> >> >> >> c90 >> >> >> >> 7b8 >> >> >> >> >> >> >> >> The source of the project can be found here: >> >> >> >> https://cgit.kde.org/kio-stash.git/ >> >> >> > >> >> >> > Can you please get it covered by the CI? >> >> >> > >> >> >> > I have some of the tests failing but don't know if it is because my >> >> >> > setup >> >> >> > is a bit broken at this moment, so wanted to check in CI if the >> >> >> > tests >> >> >> > were file but I have not been able to find it there. >> >> >> > >> >> >> > Cheers, >> >> >> > >> >> >> > Ablert >> >> >> >> >> >> >> >> Thanks. > > -
Re: kio-stash is in KDE Review
El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va escriure: > Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and > ran the following commands after cloning the repo and creating a build > directory: > > cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE .. > make git code does not compile as of now. Cheers, Albert > sudo make install > kdeinit5 > > ..and then I ran the tests using 'ctest -v'. It passed slavetest with > no issues (18 out of 18 tests passed). My guess why it doesn't work > you is because you haven't run kdeinit5 after installing the ioslave. > If not that, the testdaemon process might not have been successfully > registered on the system D-Bus when thes test is run. > > Is there a way I can see if my test cases pass on KDE's CI > infrastructure to narrow down the problem? If so, I will a sysadmin to > do so. > > On Tue, Jun 13, 2017 at 4:16 AM, Albert Astals Cid wrote: > > El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va > > > > escriure: > >> > Do you mean i have to manually start a process for the tests to > >> > succeed? > >> > >> If installed correctly with kdeinit restarted and the Stash Daemon is > >> running in kded5, it is not required. However, I cannot recall what > >> steps are needed for this to happen as I think it requires a system > >> restart or logout to do so. > >> > >> Hence, I have created a fallback testdaemon program which creates a > >> daemon process for the Stash Daemon to run. This is launched > >> automatically by the test suite if the test suite cannot find the > >> Stash Daemon running in kded. I just patched it so that it finds the > >> path to the testdaemon program correctly (it had the wrong path when > >> you tested it). It should pass the test cases now with no manual > >> invocation of the testdaemon process. > > > > Doesn't seem to work for me. > > > > https://paste.kde.org/ptnn5hhkt > > > > Cheers, > > > > Albert > >> > >> On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid wrote: > >> > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va > > > > escriure: > >> >> Yes, I will file a sysadmin ticket for the same. Until I do so, could > >> >> you send me the output of the test suite in a screenshot or as plain > >> >> text? > >> >> > >> >> The ioslave works by storing a list of virtual files and folders in a > >> >> process running in the KDED, communicating with it over D-Bus. Hence, > >> >> some of the tests won't work unless a) the testdaemon process is > >> >> started > >> > > >> > Do you mean i have to manually start a process for the tests to > >> > succeed? > >> > > >> > If that is the case, that's not acceptable. > >> > > >> > Cheers, > >> > > >> > Albert > >> >> > >> >> or b) the Stash KIO slave watcher is running in KDED. Usually > >> >> it requires a restart of KDED and a kdeinit after installing the > >> >> ioslave to have the Stash daemon running in KDED. > >> >> > >> >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid wrote: > >> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija > >> >> > va > >> >> > > >> >> > escriure: > >> >> >> Hi! > >> >> >> > >> >> >> I had made the kio-stash ioslave last year as part of my GSoC 2016 > >> >> >> Project. Now that most of the changes which I wished to make in > >> >> >> Dolphin relevant to the ioslave are part of master, I wish to ship > >> >> >> the > >> >> >> ioslave soon. > >> >> >> > >> >> >> The project is now in KDE review and is awaiting feedback. The link > >> >> >> for the same can be found here: > >> >> >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672a > >> >> >> c90 > >> >> >> 7b8 > >> >> >> > >> >> >> The source of the project can be found here: > >> >> >> https://cgit.kde.org/kio-stash.git/ > >> >> > > >> >> > Can you please get it covered by the CI? > >> >> > > >> >> > I have some of the tests failing but don't know if it is because my > >> >> > setup > >> >> > is a bit broken at this moment, so wanted to check in CI if the > >> >> > tests > >> >> > were file but I have not been able to find it there. > >> >> > > >> >> > Cheers, > >> >> > > >> >> > Ablert > >> >> >> > >> >> >> Thanks.
Re: kio-stash is in KDE Review
On Thu, Jun 15, 2017 at 9:04 AM, Albert Astals Cid wrote: > El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va > escriure: >> Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and >> ran the following commands after cloning the repo and creating a build >> directory: >> >> cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE .. >> make >> sudo make install >> kdeinit5 >> >> ..and then I ran the tests using 'ctest -v'. It passed slavetest with >> no issues (18 out of 18 tests passed). My guess why it doesn't work >> you is because you haven't run kdeinit5 after installing the ioslave. >> If not that, the testdaemon process might not have been successfully >> registered on the system D-Bus when thes test is run. >> >> Is there a way I can see if my test cases pass on KDE's CI >> infrastructure to narrow down the problem? If so, I will a sysadmin to >> do so. > > You said you were asking for kio-stash to be added to CI? What happened with > that? Or am i misremembering? I actioned the request this morning (my time). > > Cheers, > Albert Regards, Ben > >> >> On Tue, Jun 13, 2017 at 4:16 AM, Albert Astals Cid wrote: >> > El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va >> > >> > escriure: >> >> > Do you mean i have to manually start a process for the tests to >> >> > succeed? >> >> >> >> If installed correctly with kdeinit restarted and the Stash Daemon is >> >> running in kded5, it is not required. However, I cannot recall what >> >> steps are needed for this to happen as I think it requires a system >> >> restart or logout to do so. >> >> >> >> Hence, I have created a fallback testdaemon program which creates a >> >> daemon process for the Stash Daemon to run. This is launched >> >> automatically by the test suite if the test suite cannot find the >> >> Stash Daemon running in kded. I just patched it so that it finds the >> >> path to the testdaemon program correctly (it had the wrong path when >> >> you tested it). It should pass the test cases now with no manual >> >> invocation of the testdaemon process. >> > >> > Doesn't seem to work for me. >> > >> > https://paste.kde.org/ptnn5hhkt >> > >> > Cheers, >> > >> > Albert >> >> >> >> On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid wrote: >> >> > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va >> > >> > escriure: >> >> >> Yes, I will file a sysadmin ticket for the same. Until I do so, could >> >> >> you send me the output of the test suite in a screenshot or as plain >> >> >> text? >> >> >> >> >> >> The ioslave works by storing a list of virtual files and folders in a >> >> >> process running in the KDED, communicating with it over D-Bus. Hence, >> >> >> some of the tests won't work unless a) the testdaemon process is >> >> >> started >> >> > >> >> > Do you mean i have to manually start a process for the tests to >> >> > succeed? >> >> > >> >> > If that is the case, that's not acceptable. >> >> > >> >> > Cheers, >> >> > >> >> > Albert >> >> >> >> >> >> or b) the Stash KIO slave watcher is running in KDED. Usually >> >> >> it requires a restart of KDED and a kdeinit after installing the >> >> >> ioslave to have the Stash daemon running in KDED. >> >> >> >> >> >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid > wrote: >> >> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija >> >> >> > va >> >> >> > >> >> >> > escriure: >> >> >> >> Hi! >> >> >> >> >> >> >> >> I had made the kio-stash ioslave last year as part of my GSoC 2016 >> >> >> >> Project. Now that most of the changes which I wished to make in >> >> >> >> Dolphin relevant to the ioslave are part of master, I wish to ship >> >> >> >> the >> >> >> >> ioslave soon. >> >> >> >> >> >> >> >> The project is now in KDE review and is awaiting feedback. The link >> >> >> >> for the same can be found here: >> >> >> >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672a >> >> >> >> c90 >> >> >> >> 7b8 >> >> >> >> >> >> >> >> The source of the project can be found here: >> >> >> >> https://cgit.kde.org/kio-stash.git/ >> >> >> > >> >> >> > Can you please get it covered by the CI? >> >> >> > >> >> >> > I have some of the tests failing but don't know if it is because my >> >> >> > setup >> >> >> > is a bit broken at this moment, so wanted to check in CI if the >> >> >> > tests >> >> >> > were file but I have not been able to find it there. >> >> >> > >> >> >> > Cheers, >> >> >> > >> >> >> > Ablert >> >> >> >> >> >> >> >> Thanks. > >
Re: kio-stash is in KDE Review
El dimecres, 14 de juny de 2017, a les 21:42:58 CEST, Arnav Dhamija va escriure: > Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and > ran the following commands after cloning the repo and creating a build > directory: > > cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE .. > make > sudo make install > kdeinit5 > > ..and then I ran the tests using 'ctest -v'. It passed slavetest with > no issues (18 out of 18 tests passed). My guess why it doesn't work > you is because you haven't run kdeinit5 after installing the ioslave. > If not that, the testdaemon process might not have been successfully > registered on the system D-Bus when thes test is run. > > Is there a way I can see if my test cases pass on KDE's CI > infrastructure to narrow down the problem? If so, I will a sysadmin to > do so. You said you were asking for kio-stash to be added to CI? What happened with that? Or am i misremembering? Cheers, Albert > > On Tue, Jun 13, 2017 at 4:16 AM, Albert Astals Cid wrote: > > El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va > > > > escriure: > >> > Do you mean i have to manually start a process for the tests to > >> > succeed? > >> > >> If installed correctly with kdeinit restarted and the Stash Daemon is > >> running in kded5, it is not required. However, I cannot recall what > >> steps are needed for this to happen as I think it requires a system > >> restart or logout to do so. > >> > >> Hence, I have created a fallback testdaemon program which creates a > >> daemon process for the Stash Daemon to run. This is launched > >> automatically by the test suite if the test suite cannot find the > >> Stash Daemon running in kded. I just patched it so that it finds the > >> path to the testdaemon program correctly (it had the wrong path when > >> you tested it). It should pass the test cases now with no manual > >> invocation of the testdaemon process. > > > > Doesn't seem to work for me. > > > > https://paste.kde.org/ptnn5hhkt > > > > Cheers, > > > > Albert > >> > >> On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid wrote: > >> > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va > > > > escriure: > >> >> Yes, I will file a sysadmin ticket for the same. Until I do so, could > >> >> you send me the output of the test suite in a screenshot or as plain > >> >> text? > >> >> > >> >> The ioslave works by storing a list of virtual files and folders in a > >> >> process running in the KDED, communicating with it over D-Bus. Hence, > >> >> some of the tests won't work unless a) the testdaemon process is > >> >> started > >> > > >> > Do you mean i have to manually start a process for the tests to > >> > succeed? > >> > > >> > If that is the case, that's not acceptable. > >> > > >> > Cheers, > >> > > >> > Albert > >> >> > >> >> or b) the Stash KIO slave watcher is running in KDED. Usually > >> >> it requires a restart of KDED and a kdeinit after installing the > >> >> ioslave to have the Stash daemon running in KDED. > >> >> > >> >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid wrote: > >> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija > >> >> > va > >> >> > > >> >> > escriure: > >> >> >> Hi! > >> >> >> > >> >> >> I had made the kio-stash ioslave last year as part of my GSoC 2016 > >> >> >> Project. Now that most of the changes which I wished to make in > >> >> >> Dolphin relevant to the ioslave are part of master, I wish to ship > >> >> >> the > >> >> >> ioslave soon. > >> >> >> > >> >> >> The project is now in KDE review and is awaiting feedback. The link > >> >> >> for the same can be found here: > >> >> >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672a > >> >> >> c90 > >> >> >> 7b8 > >> >> >> > >> >> >> The source of the project can be found here: > >> >> >> https://cgit.kde.org/kio-stash.git/ > >> >> > > >> >> > Can you please get it covered by the CI? > >> >> > > >> >> > I have some of the tests failing but don't know if it is because my > >> >> > setup > >> >> > is a bit broken at this moment, so wanted to check in CI if the > >> >> > tests > >> >> > were file but I have not been able to find it there. > >> >> > > >> >> > Cheers, > >> >> > > >> >> > Ablert > >> >> >> > >> >> >> Thanks.
Re: kio-stash is in KDE Review
Just to check I setup a brand new virtualbox with KDE Neon 5.8 LTS and ran the following commands after cloning the repo and creating a build directory: cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE .. make sudo make install kdeinit5 ...and then I ran the tests using 'ctest -v'. It passed slavetest with no issues (18 out of 18 tests passed). My guess why it doesn't work you is because you haven't run kdeinit5 after installing the ioslave. If not that, the testdaemon process might not have been successfully registered on the system D-Bus when thes test is run. Is there a way I can see if my test cases pass on KDE's CI infrastructure to narrow down the problem? If so, I will a sysadmin to do so. On Tue, Jun 13, 2017 at 4:16 AM, Albert Astals Cid wrote: > El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va > escriure: >> > Do you mean i have to manually start a process for the tests to succeed? >> >> If installed correctly with kdeinit restarted and the Stash Daemon is >> running in kded5, it is not required. However, I cannot recall what >> steps are needed for this to happen as I think it requires a system >> restart or logout to do so. >> >> Hence, I have created a fallback testdaemon program which creates a >> daemon process for the Stash Daemon to run. This is launched >> automatically by the test suite if the test suite cannot find the >> Stash Daemon running in kded. I just patched it so that it finds the >> path to the testdaemon program correctly (it had the wrong path when >> you tested it). It should pass the test cases now with no manual >> invocation of the testdaemon process. > > Doesn't seem to work for me. > > https://paste.kde.org/ptnn5hhkt > > Cheers, > Albert > >> >> On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid wrote: >> > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va > escriure: >> >> Yes, I will file a sysadmin ticket for the same. Until I do so, could >> >> you send me the output of the test suite in a screenshot or as plain >> >> text? >> >> >> >> The ioslave works by storing a list of virtual files and folders in a >> >> process running in the KDED, communicating with it over D-Bus. Hence, >> >> some of the tests won't work unless a) the testdaemon process is >> >> started >> > >> > Do you mean i have to manually start a process for the tests to succeed? >> > >> > If that is the case, that's not acceptable. >> > >> > Cheers, >> > >> > Albert >> >> >> >> or b) the Stash KIO slave watcher is running in KDED. Usually >> >> it requires a restart of KDED and a kdeinit after installing the >> >> ioslave to have the Stash daemon running in KDED. >> >> >> >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid wrote: >> >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va >> >> > >> >> > escriure: >> >> >> Hi! >> >> >> >> >> >> I had made the kio-stash ioslave last year as part of my GSoC 2016 >> >> >> Project. Now that most of the changes which I wished to make in >> >> >> Dolphin relevant to the ioslave are part of master, I wish to ship the >> >> >> ioslave soon. >> >> >> >> >> >> The project is now in KDE review and is awaiting feedback. The link >> >> >> for the same can be found here: >> >> >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672ac90 >> >> >> 7b8 >> >> >> >> >> >> The source of the project can be found here: >> >> >> https://cgit.kde.org/kio-stash.git/ >> >> > >> >> > Can you please get it covered by the CI? >> >> > >> >> > I have some of the tests failing but don't know if it is because my >> >> > setup >> >> > is a bit broken at this moment, so wanted to check in CI if the tests >> >> > were file but I have not been able to find it there. >> >> > >> >> > Cheers, >> >> > >> >> > Ablert >> >> >> >> >> >> Thanks. > > -- arnav dhamija
Re: kio-stash is in KDE Review
El divendres, 9 de juny de 2017, a les 11:45:14 CEST, Arnav Dhamija va escriure: > > Do you mean i have to manually start a process for the tests to succeed? > > If installed correctly with kdeinit restarted and the Stash Daemon is > running in kded5, it is not required. However, I cannot recall what > steps are needed for this to happen as I think it requires a system > restart or logout to do so. > > Hence, I have created a fallback testdaemon program which creates a > daemon process for the Stash Daemon to run. This is launched > automatically by the test suite if the test suite cannot find the > Stash Daemon running in kded. I just patched it so that it finds the > path to the testdaemon program correctly (it had the wrong path when > you tested it). It should pass the test cases now with no manual > invocation of the testdaemon process. Doesn't seem to work for me. https://paste.kde.org/ptnn5hhkt Cheers, Albert > > On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid wrote: > > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va escriure: > >> Yes, I will file a sysadmin ticket for the same. Until I do so, could > >> you send me the output of the test suite in a screenshot or as plain > >> text? > >> > >> The ioslave works by storing a list of virtual files and folders in a > >> process running in the KDED, communicating with it over D-Bus. Hence, > >> some of the tests won't work unless a) the testdaemon process is > >> started > > > > Do you mean i have to manually start a process for the tests to succeed? > > > > If that is the case, that's not acceptable. > > > > Cheers, > > > > Albert > >> > >> or b) the Stash KIO slave watcher is running in KDED. Usually > >> it requires a restart of KDED and a kdeinit after installing the > >> ioslave to have the Stash daemon running in KDED. > >> > >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid wrote: > >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va > >> > > >> > escriure: > >> >> Hi! > >> >> > >> >> I had made the kio-stash ioslave last year as part of my GSoC 2016 > >> >> Project. Now that most of the changes which I wished to make in > >> >> Dolphin relevant to the ioslave are part of master, I wish to ship the > >> >> ioslave soon. > >> >> > >> >> The project is now in KDE review and is awaiting feedback. The link > >> >> for the same can be found here: > >> >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672ac90 > >> >> 7b8 > >> >> > >> >> The source of the project can be found here: > >> >> https://cgit.kde.org/kio-stash.git/ > >> > > >> > Can you please get it covered by the CI? > >> > > >> > I have some of the tests failing but don't know if it is because my > >> > setup > >> > is a bit broken at this moment, so wanted to check in CI if the tests > >> > were file but I have not been able to find it there. > >> > > >> > Cheers, > >> > > >> > Ablert > >> >> > >> >> Thanks.
Re: kio-stash is in KDE Review
> Do you mean i have to manually start a process for the tests to succeed? If installed correctly with kdeinit restarted and the Stash Daemon is running in kded5, it is not required. However, I cannot recall what steps are needed for this to happen as I think it requires a system restart or logout to do so. Hence, I have created a fallback testdaemon program which creates a daemon process for the Stash Daemon to run. This is launched automatically by the test suite if the test suite cannot find the Stash Daemon running in kded. I just patched it so that it finds the path to the testdaemon program correctly (it had the wrong path when you tested it). It should pass the test cases now with no manual invocation of the testdaemon process. On Fri, Jun 9, 2017 at 1:47 AM, Albert Astals Cid wrote: > El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va escriure: >> Yes, I will file a sysadmin ticket for the same. Until I do so, could >> you send me the output of the test suite in a screenshot or as plain >> text? >> >> The ioslave works by storing a list of virtual files and folders in a >> process running in the KDED, communicating with it over D-Bus. Hence, >> some of the tests won't work unless a) the testdaemon process is >> started > > Do you mean i have to manually start a process for the tests to succeed? > > If that is the case, that's not acceptable. > > Cheers, > Albert > >> or b) the Stash KIO slave watcher is running in KDED. Usually >> it requires a restart of KDED and a kdeinit after installing the >> ioslave to have the Stash daemon running in KDED. >> >> On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid wrote: >> > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va >> > >> > escriure: >> >> Hi! >> >> >> >> I had made the kio-stash ioslave last year as part of my GSoC 2016 >> >> Project. Now that most of the changes which I wished to make in >> >> Dolphin relevant to the ioslave are part of master, I wish to ship the >> >> ioslave soon. >> >> >> >> The project is now in KDE review and is awaiting feedback. The link >> >> for the same can be found here: >> >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672ac907b8 >> >> >> >> The source of the project can be found here: >> >> https://cgit.kde.org/kio-stash.git/ >> > >> > Can you please get it covered by the CI? >> > >> > I have some of the tests failing but don't know if it is because my setup >> > is a bit broken at this moment, so wanted to check in CI if the tests >> > were file but I have not been able to find it there. >> > >> > Cheers, >> > >> > Ablert >> >> >> >> Thanks. > > -- arnav dhamija
Re: kio-stash is in KDE Review
El dijous, 8 de juny de 2017, a les 16:25:02 CEST, Arnav Dhamija va escriure: > Yes, I will file a sysadmin ticket for the same. Until I do so, could > you send me the output of the test suite in a screenshot or as plain > text? > > The ioslave works by storing a list of virtual files and folders in a > process running in the KDED, communicating with it over D-Bus. Hence, > some of the tests won't work unless a) the testdaemon process is > started Do you mean i have to manually start a process for the tests to succeed? If that is the case, that's not acceptable. Cheers, Albert > or b) the Stash KIO slave watcher is running in KDED. Usually > it requires a restart of KDED and a kdeinit after installing the > ioslave to have the Stash daemon running in KDED. > > On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid wrote: > > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va > > > > escriure: > >> Hi! > >> > >> I had made the kio-stash ioslave last year as part of my GSoC 2016 > >> Project. Now that most of the changes which I wished to make in > >> Dolphin relevant to the ioslave are part of master, I wish to ship the > >> ioslave soon. > >> > >> The project is now in KDE review and is awaiting feedback. The link > >> for the same can be found here: > >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672ac907b8 > >> > >> The source of the project can be found here: > >> https://cgit.kde.org/kio-stash.git/ > > > > Can you please get it covered by the CI? > > > > I have some of the tests failing but don't know if it is because my setup > > is a bit broken at this moment, so wanted to check in CI if the tests > > were file but I have not been able to find it there. > > > > Cheers, > > > > Ablert > >> > >> Thanks.
Re: kio-stash is in KDE Review
In the git repo all the files are permission executable, they shouldn't be. There's no documentation. I'm unsure how hard a requirement this is these days. Use title case for name in src/iodaemon/stashnotifier.json When I use Dolphin to copy a file over I get a dialog daying "Could not copy.", some more information here might be useful. The daemon wasn't loaded. Dolphin gains a Stash button which splits the view and opens Stash kioslave. I'd expect that clicking it again would close the view but it doesn't. (Dolphin code) There's no Messages.sh to extract the strings. Consider asking VDG for a new icon for this in Dolphin, currently it uses the folder icon which isn't very informative. Copy of GPL 2 needed in top directory called COPYING. Use the GPL header with the URL in it rather than postal address so it doesn't get out of date if FSF moves https://community.kde.org/Policies/Licensing_Policy#GPL_Header Nudge the KDE neon developers to add a build to Neon Jonathan On 26 May 2017 at 18:25, Arnav Dhamija wrote: > Hi! > > I had made the kio-stash ioslave last year as part of my GSoC 2016 > Project. Now that most of the changes which I wished to make in > Dolphin relevant to the ioslave are part of master, I wish to ship the > ioslave soon. > > The project is now in KDE review and is awaiting feedback. The link > for the same can be found here: > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672ac907b8 > > The source of the project can be found here: > https://cgit.kde.org/kio-stash.git/ > > Thanks. > > -- > arnav dhamija
Re: kio-stash is in KDE Review
Yes, I will file a sysadmin ticket for the same. Until I do so, could you send me the output of the test suite in a screenshot or as plain text? The ioslave works by storing a list of virtual files and folders in a process running in the KDED, communicating with it over D-Bus. Hence, some of the tests won't work unless a) the testdaemon process is started or b) the Stash KIO slave watcher is running in KDED. Usually it requires a restart of KDED and a kdeinit after installing the ioslave to have the Stash daemon running in KDED. On Thu, Jun 8, 2017 at 3:42 AM, Albert Astals Cid wrote: > El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va > escriure: >> Hi! >> >> I had made the kio-stash ioslave last year as part of my GSoC 2016 >> Project. Now that most of the changes which I wished to make in >> Dolphin relevant to the ioslave are part of master, I wish to ship the >> ioslave soon. >> >> The project is now in KDE review and is awaiting feedback. The link >> for the same can be found here: >> https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672ac907b8 >> >> The source of the project can be found here: >> https://cgit.kde.org/kio-stash.git/ > > Can you please get it covered by the CI? > > I have some of the tests failing but don't know if it is because my setup is a > bit broken at this moment, so wanted to check in CI if the tests were file but > I have not been able to find it there. > > Cheers, > Ablert > >> >> Thanks. > > -- arnav dhamija
Re: kio-stash is in KDE Review
El divendres, 26 de maig de 2017, a les 22:55:11 CEST, Arnav Dhamija va escriure: > Hi! > > I had made the kio-stash ioslave last year as part of my GSoC 2016 > Project. Now that most of the changes which I wished to make in > Dolphin relevant to the ioslave are part of master, I wish to ship the > ioslave soon. > > The project is now in KDE review and is awaiting feedback. The link > for the same can be found here: > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672ac907b8 > > The source of the project can be found here: > https://cgit.kde.org/kio-stash.git/ Can you please get it covered by the CI? I have some of the tests failing but don't know if it is because my setup is a bit broken at this moment, so wanted to check in CI if the tests were file but I have not been able to find it there. Cheers, Ablert > > Thanks.
Re: kio-stash is in KDE Review
Hi everyone I have touched upon any concerns people have had with the ioslave in my previous email. If no one has any objections, I would like to ship this to KDE Extra Modules. More specifically, it will be suited for kde-extragear-utils, if that division is still relevant in KDE extragear. The sysadmin task for the same can be found here: https://phabricator.kde.org/T6285 On Sat, May 27, 2017 at 3:43 PM, Arnav Dhamija wrote: > First off, thanks for all the reviews! > >> >> We simulate a "virtual://" protocol[*] which can contain virtual >> folders containing references to real files and folders. > > > I did not know that such a feature exists! It seems like this feature is > Krusader specific without tapping into KIO as such? > >> It would be great if we can get rid of this "Krusader only" solution and >> replace it with >> your *real* KIO protocol. Some questions: Is it persistent (between >> reboots)? And does it >> support general file URLs (e.g. ftp://localhost/path/to/file.txt) or only >> local >> "file://"-files? > > > The list of files is not persistent across reboots. That idea was scrapped > fairly early on during the development of this project. It could probably be > implemented using xattr if such a feature is needed. I haven't tested much > on other protocols, but it does have problems copying from some protocols > such as mtp. > > That said, being a kioslave, it works well with Dolphin, the KDE Folder view > Plasmoid, and Konqueror for file operations. > >> * ../src/iodaemon/stashnotifier.cpp:183:9: warning: variable 'fileType' is >> uninitialized when used here >> This should probably be fixed. >> >> * You are linking to KI18n but you are not using i18n() calls in your >> code. Have a look at [1]. >> >> * The dbus adaptor could probably use build-time generation via cmake, >> rather than being committed to the git repo. If you need an example look at >> the CMakeLists.txt in kio/src/kioexec (qt5_add_dbus_adaptor and friends). > > > Thanks, I have fixed the first two issues. My response to the last issue is > given below. > >> Files that contain autogenerated code should ideally not be "edited". >> >> Do you remember why editing was needed? > > >> Not exactly, Arnav will know that. But it's not really too big a >> problem for a project this size. In fact I do the same thing in >> Spectacle. > > > I believe we needed to make some specific changes to the autogenerated XML > at some point in the project. These changes were later scrapped, so it uses > the directly autogenerated code with no modifications. As Boudhayan said, > the justification for not changing it to be invoked on compilation was for > simplicity and that the D-Bus code was rarely updated throughout the > development of the project. > >> Maintainers will leave and we will inherit the code, so there will be >> noone to >> ask. > > > I will be available to maintain this code when it gets released in the KDE > software ecosystem. > > > On Sat, May 27, 2017 at 2:53 PM, Albert Astals Cid wrote: >> >> El dissabte, 27 de maig de 2017, a les 0:29:51 CEST, Boudhayan Gupta va >> escriure: >> > Hi, >> > >> > On 27 May 2017 at 00:20, Albert Astals Cid wrote: >> > > El divendres, 26 de maig de 2017, a les 23:48:18 CEST, Boudhayan Gupta >> > > va >> > > >> > > escriure: >> > >> Hi, >> > >> >> > >> On 26 May 2017 at 20:31, Elvis Angelaccio >> wrote: >> > >> > * The dbus adaptor could probably use build-time generation via >> > >> > cmake, >> > >> > rather than being committed to the git repo. If you need an example >> > >> > look >> > >> > at >> > >> > the CMakeLists.txt in kio/src/kioexec (qt5_add_dbus_adaptor and >> > >> > friends). >> > >> >> > >> IIRC we did that first, but then figured we needed to edit the >> > >> generated code (I was the mentor for this project). >> > > >> > > That seems dangerous, what if sometime in the future you need to >> > > regenerate >> > > the adaptor because you add new functions or something? >> > > >> > > Files that contain autogenerated code should ideally not be "edited". >> > > >> > > Do you remember why editing was needed? >> > >> > Not exactly, Arnav will know that. But it's not really too big a >> > problem for a project this size. In fact I do the same thing in >> > Spectacle. >> > >> > Granted this isn't best practice, but the effort required to do it >> > right (whatever way that might be) was inordinately large for the >> > scope of the project. At some point someone who's trying to patch this >> > part of the code might get stuck, but figuring out that generated code >> > was edited isn't difficult at all, as neither is asking the maintainer >> > how the code works. >> >> Maintainers will leave and we will inherit the code, so there will be >> noone to >> ask. >> >> If you need to do some changes to generated code either document it or >> just >> don't do changes in the generated code. >> >> Cheers, >> Albert >> >> > >> > Thanks, >> > Boudhayan >> > >> > > Cheers, >> > > >> > > Albert
Re: kio-stash is in KDE Review
First off, thanks for all the reviews! > We simulate a "virtual://" protocol[*] which can contain virtual > folders containing references to real files and folders. > I did not know that such a feature exists! It seems like this feature is Krusader specific without tapping into KIO as such? It would be great if we can get rid of this "Krusader only" solution and > replace it with > your *real* KIO protocol. Some questions: Is it persistent (between > reboots)? And does it > support general file URLs (e.g. ftp://localhost/path/to/file.txt) or only > local > "file://"-files? The list of files is not persistent across reboots. That idea was scrapped fairly early on during the development of this project. It could probably be implemented using xattr if such a feature is needed. I haven't tested much on other protocols, but it does have problems copying from some protocols such as mtp. That said, being a kioslave, it works well with Dolphin, the KDE Folder view Plasmoid, and Konqueror for file operations. * ../src/iodaemon/stashnotifier.cpp:183:9: warning: variable 'fileType' is > uninitialized when used here > This should probably be fixed. > > * You are linking to KI18n but you are not using i18n() calls in your > code. Have a look at [1]. > > * The dbus adaptor could probably use build-time generation via cmake, > rather than being committed to the git repo. If you need an example look at > the CMakeLists.txt in kio/src/kioexec (qt5_add_dbus_adaptor and friends). > Thanks, I have fixed the first two issues. My response to the last issue is given below. Files that contain autogenerated code should ideally not be "edited". > > Do you remember why editing was needed? > Not exactly, Arnav will know that. But it's not really too big a > problem for a project this size. In fact I do the same thing in > Spectacle. > I believe we needed to make some specific changes to the autogenerated XML at some point in the project. These changes were later scrapped, so it uses the directly autogenerated code with no modifications. As Boudhayan said, the justification for not changing it to be invoked on compilation was for simplicity and that the D-Bus code was rarely updated throughout the development of the project. Maintainers will leave and we will inherit the code, so there will be noone > to > ask. > I will be available to maintain this code when it gets released in the KDE software ecosystem. On Sat, May 27, 2017 at 2:53 PM, Albert Astals Cid wrote: > El dissabte, 27 de maig de 2017, a les 0:29:51 CEST, Boudhayan Gupta va > escriure: > > Hi, > > > > On 27 May 2017 at 00:20, Albert Astals Cid wrote: > > > El divendres, 26 de maig de 2017, a les 23:48:18 CEST, Boudhayan Gupta > va > > > > > > escriure: > > >> Hi, > > >> > > >> On 26 May 2017 at 20:31, Elvis Angelaccio > wrote: > > >> > * The dbus adaptor could probably use build-time generation via > cmake, > > >> > rather than being committed to the git repo. If you need an example > > >> > look > > >> > at > > >> > the CMakeLists.txt in kio/src/kioexec (qt5_add_dbus_adaptor and > > >> > friends). > > >> > > >> IIRC we did that first, but then figured we needed to edit the > > >> generated code (I was the mentor for this project). > > > > > > That seems dangerous, what if sometime in the future you need to > > > regenerate > > > the adaptor because you add new functions or something? > > > > > > Files that contain autogenerated code should ideally not be "edited". > > > > > > Do you remember why editing was needed? > > > > Not exactly, Arnav will know that. But it's not really too big a > > problem for a project this size. In fact I do the same thing in > > Spectacle. > > > > Granted this isn't best practice, but the effort required to do it > > right (whatever way that might be) was inordinately large for the > > scope of the project. At some point someone who's trying to patch this > > part of the code might get stuck, but figuring out that generated code > > was edited isn't difficult at all, as neither is asking the maintainer > > how the code works. > > Maintainers will leave and we will inherit the code, so there will be > noone to > ask. > > If you need to do some changes to generated code either document it or just > don't do changes in the generated code. > > Cheers, > Albert > > > > > Thanks, > > Boudhayan > > > > > Cheers, > > > > > > Albert > > > > > >> > Cheers, > > >> > Elvis > > >> > > > >> > [1]: https://api.kde.org/frameworks/ki18n/html/prg_guide.html > > >> > > >> Freundliche Grüße > > >> Boudhayan Gupta > > >> KDE e.V. - Sysadmin and Community Working Groups > > >> +49 151 71032970 > > > -- arnav dhamija
Re: kio-stash is in KDE Review
El dissabte, 27 de maig de 2017, a les 0:29:51 CEST, Boudhayan Gupta va escriure: > Hi, > > On 27 May 2017 at 00:20, Albert Astals Cid wrote: > > El divendres, 26 de maig de 2017, a les 23:48:18 CEST, Boudhayan Gupta va > > > > escriure: > >> Hi, > >> > >> On 26 May 2017 at 20:31, Elvis Angelaccio wrote: > >> > * The dbus adaptor could probably use build-time generation via cmake, > >> > rather than being committed to the git repo. If you need an example > >> > look > >> > at > >> > the CMakeLists.txt in kio/src/kioexec (qt5_add_dbus_adaptor and > >> > friends). > >> > >> IIRC we did that first, but then figured we needed to edit the > >> generated code (I was the mentor for this project). > > > > That seems dangerous, what if sometime in the future you need to > > regenerate > > the adaptor because you add new functions or something? > > > > Files that contain autogenerated code should ideally not be "edited". > > > > Do you remember why editing was needed? > > Not exactly, Arnav will know that. But it's not really too big a > problem for a project this size. In fact I do the same thing in > Spectacle. > > Granted this isn't best practice, but the effort required to do it > right (whatever way that might be) was inordinately large for the > scope of the project. At some point someone who's trying to patch this > part of the code might get stuck, but figuring out that generated code > was edited isn't difficult at all, as neither is asking the maintainer > how the code works. Maintainers will leave and we will inherit the code, so there will be noone to ask. If you need to do some changes to generated code either document it or just don't do changes in the generated code. Cheers, Albert > > Thanks, > Boudhayan > > > Cheers, > > > > Albert > > > >> > Cheers, > >> > Elvis > >> > > >> > [1]: https://api.kde.org/frameworks/ki18n/html/prg_guide.html > >> > >> Freundliche Grüße > >> Boudhayan Gupta > >> KDE e.V. - Sysadmin and Community Working Groups > >> +49 151 71032970
Re: kio-stash is in KDE Review
Hi, On 27 May 2017 at 00:20, Albert Astals Cid wrote: > El divendres, 26 de maig de 2017, a les 23:48:18 CEST, Boudhayan Gupta va > escriure: >> Hi, >> >> On 26 May 2017 at 20:31, Elvis Angelaccio wrote: >> > * The dbus adaptor could probably use build-time generation via cmake, >> > rather than being committed to the git repo. If you need an example look >> > at >> > the CMakeLists.txt in kio/src/kioexec (qt5_add_dbus_adaptor and friends). >> >> IIRC we did that first, but then figured we needed to edit the >> generated code (I was the mentor for this project). > > That seems dangerous, what if sometime in the future you need to regenerate > the adaptor because you add new functions or something? > > Files that contain autogenerated code should ideally not be "edited". > > Do you remember why editing was needed? Not exactly, Arnav will know that. But it's not really too big a problem for a project this size. In fact I do the same thing in Spectacle. Granted this isn't best practice, but the effort required to do it right (whatever way that might be) was inordinately large for the scope of the project. At some point someone who's trying to patch this part of the code might get stuck, but figuring out that generated code was edited isn't difficult at all, as neither is asking the maintainer how the code works. Thanks, Boudhayan > > Cheers, > Albert > >> >> > Cheers, >> > Elvis >> > >> > [1]: https://api.kde.org/frameworks/ki18n/html/prg_guide.html >> >> Freundliche Grüße >> Boudhayan Gupta >> KDE e.V. - Sysadmin and Community Working Groups >> +49 151 71032970 > >
Re: kio-stash is in KDE Review
El divendres, 26 de maig de 2017, a les 23:48:18 CEST, Boudhayan Gupta va escriure: > Hi, > > On 26 May 2017 at 20:31, Elvis Angelaccio wrote: > > * The dbus adaptor could probably use build-time generation via cmake, > > rather than being committed to the git repo. If you need an example look > > at > > the CMakeLists.txt in kio/src/kioexec (qt5_add_dbus_adaptor and friends). > > IIRC we did that first, but then figured we needed to edit the > generated code (I was the mentor for this project). That seems dangerous, what if sometime in the future you need to regenerate the adaptor because you add new functions or something? Files that contain autogenerated code should ideally not be "edited". Do you remember why editing was needed? Cheers, Albert > > > Cheers, > > Elvis > > > > [1]: https://api.kde.org/frameworks/ki18n/html/prg_guide.html > > Freundliche Grüße > Boudhayan Gupta > KDE e.V. - Sysadmin and Community Working Groups > +49 151 71032970
Re: kio-stash is in KDE Review
Hi, On 26 May 2017 at 20:31, Elvis Angelaccio wrote: > * The dbus adaptor could probably use build-time generation via cmake, > rather than being committed to the git repo. If you need an example look at > the CMakeLists.txt in kio/src/kioexec (qt5_add_dbus_adaptor and friends). IIRC we did that first, but then figured we needed to edit the generated code (I was the mentor for this project). > Cheers, > Elvis > > [1]: https://api.kde.org/frameworks/ki18n/html/prg_guide.html Freundliche Grüße Boudhayan Gupta KDE e.V. - Sysadmin and Community Working Groups +49 151 71032970
Re: kio-stash is in KDE Review
On venerdì 26 maggio 2017 19:25:11 CEST, Arnav Dhamija wrote: Hi! I had made the kio-stash ioslave last year as part of my GSoC 2016 Project. Now that most of the changes which I wished to make in Dolphin relevant to the ioslave are part of master, I wish to ship the ioslave soon. The project is now in KDE review and is awaiting feedback. * ../src/iodaemon/stashnotifier.cpp:183:9: warning: variable 'fileType' is uninitialized when used here This should probably be fixed. * You are linking to KI18n but you are not using i18n() calls in your code. Have a look at [1]. * The dbus adaptor could probably use build-time generation via cmake, rather than being committed to the git repo. If you need an example look at the CMakeLists.txt in kio/src/kioexec (qt5_add_dbus_adaptor and friends). Cheers, Elvis [1]: https://api.kde.org/frameworks/ki18n/html/prg_guide.html
Re: kio-stash is in KDE Review
Hi Arnav, I don't know if you were aware of it, but Krusader has something very similar to your "stash://" protocol. We simulate a "virtual://" protocol[*] which can contain virtual folders containing references to real files and folders. It is persistent by saving/loading all lists to a config file and can be used e.g. for copying/moving temporary files or saving search results. It would be great if we can get rid of this "Krusader only" solution and replace it with your *real* KIO protocol. Some questions: Is it persistent (between reboots)? And does it support general file URLs (e.g. ftp://localhost/path/to/file.txt) or only local "file://"-files? Cheers and happy coding! Alex [*] https://cgit.kde.org/krusader.git/tree/krusader/FileSystem/virtualfilesystem.h On 26.05.2017 19:25, Arnav Dhamija wrote: > Hi! > > I had made the kio-stash ioslave last year as part of my GSoC 2016 > Project. Now that most of the changes which I wished to make in > Dolphin relevant to the ioslave are part of master, I wish to ship the > ioslave soon. > > The project is now in KDE review and is awaiting feedback. The link > for the same can be found here: > https://phabricator.kde.org/R247:0f4dc333ac8469b36d1b3a1cedd0a6672ac907b8 > > The source of the project can be found here: > https://cgit.kde.org/kio-stash.git/ > > Thanks. >
