D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. I did some more testing, and everything seems to work fine: sudo su cd /usr/share/applications sleep 2 && mv org.kde.kfind.desktop org.kde.kfind.desktop_# no KFind now sleep 2 && mv org.kde.kfind.desktop_ org.kde.kfind.desktop# KFind

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. No problem. I'm glad it works :) REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, feverfew, meven,

D22594: [Dolphin] Open Preferred Search Tool action

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Well now I'm embarrassed to admit that I probably didn't. I think I updated it but forgot to compile lol. Sorry for wasting your time! This looks great to me now. @elvisangelaccio do

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. Hmm... Are you using the latest diff (https://phabricator.kde.org/D22594?id=62212)? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: kfm-devel, kde-doc-english, aprcela, fprice,

D22199: New plugin to open the selected file path

nononux marked 2 inline comments as done. nononux added inline comments. INLINE COMMENTS > dhaumann wrote in plugin_kateopenselection.cpp:80 > A PluginViewKateOpenSelection instance is created here for every > KTextEditor::MainWindow - this is ok and works as designed / intended. > > However,

D22594: [Dolphin] Open Preferred Search Tool action

ngraham added a comment. No, I already had KFind installed. I just opened Dolphin and looked at the menu item, nothing fancy. :/ F7070963: repro-2019-07-21_16.08.02.webm REPOSITORY R318 Dolphin REVISION DETAIL

D22199: New plugin to open the selected file path

nononux updated this revision to Diff 62250. nononux added a comment. Fix the required parts, I hope it's ok this time :) REPOSITORY R40 Kate CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22199?vs=61266=62250 BRANCH openselection (branched from master) REVISION DETAIL

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. > The way you've implemented the menu item naming seems a bit fragile though True. It's really hard to update it reliably. KMoreTools* do not provide an easy way to get notified that the tools changed. Even current solution in "More Search Tools" menu

D22594: [Dolphin] Open Preferred Search Tool action

ngraham added a comment. All right, you've convinced me on the shortcut. The way you've implemented the menu item naming seems a bit fragile though (and in line 1410 of `src/dolphinmainwindow.cpp`, it's not used at all). In my testing, the name doesn't show up and it falls back to the

D22199: New plugin to open the selected file path

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. The KTextEditor::Command implementation is wrong, see my other comments. Please fix this first :-) INLINE COMMENTS > plugin_kateopenselection.cpp:80 > +{ > +return new

D22602: Updated copyright years

gengisdave accepted this revision as: gengisdave. gengisdave added a comment. This revision is now accepted and ready to land. No objections REPOSITORY R167 Krusader BRANCH copyright-years REVISION DETAIL https://phabricator.kde.org/D22602 To: nmel, #krusader, gengisdave Cc:

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added a comment. > 2. For the keyboard shortcut let's use Alt instead of Shift. It is an alternate search, after all. I found `Ctrl+Shift+F` to be much more popular for "search", "advanced search", "search in all ...", "find in ...", "advanced find", etc.:

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski updated this revision to Diff 62212. pdabrowski edited the summary of this revision. pdabrowski added a comment. > 1. Instead of showing a generic text, how about making it actually say "Search with https://phabricator.kde.org/D22594?vs=62211=62212 REVISION DETAIL

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski updated this revision to Diff 62211. pdabrowski added a comment. > 3. Whenever you change anything in a .rc file, you need to bump the version number that appears at the top of the file. Done. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

D22199: New plugin to open the selected file path

nononux added a comment. Hi, can the code be pushed ? I don't think there are still changes to do. (I don't have a dev account) REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D22199 To: nononux Cc: dhaumann, pino, yurchor, kwrite-devel, kde-doc-english, gennad,

[labplot] po: Revert "[translation] add copy of po files for building packages"

Git commit add9013f66f61d1c03cf04e3cd4f17130d7651aa by Luigi Toscano. Committed on 21/07/2019 at 09:25. Pushed by ltoscano into branch 'master'. Revert "[translation] add copy of po files for building packages" Please don't - this breaks the translation system. Just use releaseme, following the

[labplot] po: [translation] add copy of po files for building packages

Git commit 2db4e2c9ceb5aa5beca66012d0a63915ab513db8 by Stefan Gerlach. Committed on 21/07/2019 at 09:14. Pushed by sgerlach into branch 'master'. [translation] add copy of po files for building packages A +20209 -0po/bs/labplot2.po A +18710 -0po/ca/labplot2.po A +18703 -0

D22602: Updated copyright years

nmel added a project: Krusader. REPOSITORY R167 Krusader REVISION DETAIL https://phabricator.kde.org/D22602 To: nmel, #krusader Cc: kde-doc-english, gennad, fbampaloukas, nmel, mjanczara, miroslavm, skadinna, janlepper, abika, martinkostolny, asensi, gengisdave, andreaska

D22602: Updated copyright years

nmel created this revision. nmel added a reviewer: Krusader. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. nmel requested review of this revision. TEST PLAN Check if any file is missing the update. REPOSITORY R167 Krusader BRANCH copyright-years