ngraham added a comment.
Still looks great to me in testing.
REPOSITORY
R223 Okular
BRANCH
new-annotation-toolbar_ToggleActionMenu
REVISION DETAIL
https://phabricator.kde.org/D15580
To: simgunz, #okular, #vdg, ngraham
Cc: kde-doc-english, andreashurka, yurchor, trickyricky26,
simgunz updated this revision to Diff 69406.
simgunz added a comment.
- Apply KDE Frameworks astyle
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15580?vs=69405=69406
BRANCH
new-annotation-toolbar_ToggleActionMenu
REVISION DETAIL
simgunz updated this revision to Diff 69405.
simgunz added a comment.
- Minor refactor
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15580?vs=69380=69405
BRANCH
new-annotation-toolbar_ToggleActionMenu
REVISION DETAIL
simgunz added a comment.
> Might it be a hint that there are too many toolbars? I think only the part
should have the annotation toolbar, so it is clear which is affected by the
hide action.
Not defining the annotation toolbar also in `shell.rc` makes the
implementation of the action
simgunz marked 2 inline comments as done.
REPOSITORY
R223 Okular
BRANCH
new-annotation-toolbar_ToggleActionMenu
REVISION DETAIL
https://phabricator.kde.org/D15580
To: simgunz, #okular, #vdg, ngraham
Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano,
cfeck,
simgunz updated this revision to Diff 69380.
simgunz added a comment.
- Merge remote-tracking branch 'origin/master' into
new-annotation-toolbar_ToggleActionMenu
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15580?vs=69379=69380
BRANCH
simgunz updated this revision to Diff 69379.
simgunz added a comment.
Herald added a project: Documentation.
Herald added a subscriber: kde-doc-english.
- Add setToolBarVisible method
- Fix annotation toolbar only hidden in first main window
REPOSITORY
R223 Okular
CHANGES SINCE LAST
