D23767: Remove UI options related to window tabbing

zzag added a comment. Please squash this change into D23069 . It would be better to remove window tabbing all at once. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D23767 To: gladhorn, #kwin Cc: zzag, kwin, kde-doc-english,

D23767: Remove UI options related to window tabbing

zzag added inline comments. INLINE COMMENTS > windows.cpp:60-61 > #define KWIN_INACTIVE_SKIP_TASKBAR "InactiveTabsSkipTaskbar" > #define KWIN_AUTOGROUP_SIMILAR "AutogroupSimilarWindows" > #define KWIN_AUTOGROUP_FOREGROUND "AutogroupInForeground" > #define KWIN_SEPARATE_SCREEN_FOCUS

D23415: Improve comprehensibility and consistency of window placement mode names

zzag added a comment. In D23415#520175 , @ngraham wrote: > But that doesn't make sense to me. The reason to rename it in the code as well is to preserve internal consistency with the user-displayed strings. If we only rename the enums and not

D22894: Rename "Desktop Effects" to "Graphical Effects"

zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. It should stay "Desktop Effects." > Effects It's too ambiguous. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D22894 To: ngraham, #vdg, #kwin, GB_2,

D23415: Improve comprehensibility and consistency of window placement mode names

zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. In D23415#519223 , @cfeck wrote: > Is zero corner top-right on RTL systems? No, this placement policy doesn't take into account

D23415: Improve comprehensibility and consistency of window placement mode names

zzag added a comment. I'm against renaming "smart" placement policy for couple reasons: (a) it's been called like this since its inception , i.e. starting from late 1999 (b) "smart" is a catchy name,

D23415: Improve comprehensibility and consistency of window placement mode names

zzag added a comment. I don't think that renaming smart and maximizing placement policy is worth the trouble. REPOSITORY R108 KWin BRANCH better-window-placement-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D23415 To: ngraham, #kwin, #vdg, ndavis Cc: zzag,

D23415: Improve comprehensibility and consistency of window placement mode names

zzag added a comment. Argh, I see... We have "Zero-Cornered" and "Top-Left Corner" in window rules kcm and kwin options kcm. That's a good catch! REPOSITORY R108 KWin BRANCH better-window-placement-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D23415 To:

D23415: Improve comprehensibility and consistency of window placement mode names

zzag added a comment. In D23415#518815 , @ndavis wrote: > I don't think a native English speaker would be confused by the wording, but if you think non-native English speakers might get confused, that's something worth considering.

D23415: Improve comprehensibility and consistency of window placement mode names

zzag added a comment. > Renaming "Smart" to "Avoid Overlapping" The new name has imperative mood, which looks odd when looking at other names. > Renaming "Maximizing" to "Maximized" "Maximizing" indicates that the placement policy maximizes clients. "Maximized" indicates

D22894: Rename "Desktop Effects" to "Graphical Effects"

zzag added a comment. I just don't want to repeat the history. KDE was rebranded in 2008-2009 and people (including me) still refer to KDE Plasma as "KDE." REPOSITORY R108 KWin BRANCH desktop-to-graphical (branched from master) REVISION DETAIL https://phabricator.kde.org/D22894 To:

D22894: Rename "Desktop Effects" to "Graphical Effects"

zzag added a comment. > My claim is that when your typical user sees the word "desktop", they don't think of the generic concept of the desktop metaphor (which is a developer concept). Using different terminology among users and developers is wrong. Sometimes one just has to learn new

D22894: Rename "Desktop Effects" to "Graphical Effects"

zzag added a comment. https://en.wikipedia.org/wiki/Desktop_metaphor REPOSITORY R108 KWin BRANCH desktop-to-graphical (branched from master) REVISION DETAIL https://phabricator.kde.org/D22894 To: ngraham, #vdg, #kwin, GB_2 Cc: zzag, GB_2, kwin, kde-doc-english, LeGast00n, sbergeron,

D22894: Rename "Desktop Effects" to "Graphical Effects"

zzag added a comment. > - Inappropriate use of the word "Desktop." In the typical user's understanding, the desktop is the thing with a wallpaper and icons on it. "Desktop" is a metaphor. "Desktop background" is the proper way to address such clients. > - Inconsistent terminology:

D22894: Rename "Desktop Effects" to "Graphical Effects"

zzag added a comment. > Because KWin maintainers have indicated in D14561 Small correction: I'm not KWin maintainers. REPOSITORY R108 KWin BRANCH desktop-to-graphical (branched from master) REVISION DETAIL https://phabricator.kde.org/D22894

D22894: Rename "Desktop Effects" to "Graphical Effects"

zzag added a comment. -1, sorry. I don't see any reason to change the name. As I said previously, people started using "desktop effects" long time ago. Bug reports, news articles, forum posts and so on use "desktop effects." Deviating from this terminology perhaps isn't a good idea.

D20017: Update URLs to use https

zzag accepted this revision. REPOSITORY R108 KWin BRANCH arcpatch-D20017 REVISION DETAIL https://phabricator.kde.org/D20017 To: vkrause, yurchor, zzag Cc: zzag, yurchor, kwin, kde-doc-english, jraleigh, gennad, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot,

D16537: [KCMs] move GHNS buttons to the normal location

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH consistent-location-for-ghns-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16537 To: ngraham, #kwin, #vdg, zzag Cc: kwin, kde-doc-english, mkulinski,