D11898: Implemented bookmark quick search

This revision was automatically updated to reflect the committed changes. Closed by commit R167:a7f169df15d8: Implemented bookmark quick search (authored by nmel). REPOSITORY R167 Krusader CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11898?vs=31350=31785 REVISION DETAIL

D11898: Implemented bookmark quick search

martinkostolny accepted this revision as: martinkostolny. martinkostolny added a comment. Same goes for me, sorry for not replying. The patch works as expected :). REPOSITORY R167 Krusader BRANCH bookmark-search-merge_arc REVISION DETAIL https://phabricator.kde.org/D11898 To: nmel,

D11898: Implemented bookmark quick search

rade accepted this revision. REPOSITORY R167 Krusader BRANCH bookmark-search-merge_arc REVISION DETAIL https://phabricator.kde.org/D11898 To: nmel, #krusader, martinkostolny, rade, asensi, gengisdave, abika Cc: kde-doc-english, nmel, mjanczara, miroslavm, janlepper, abika,

D11898: Implemented bookmark quick search

nmel added a comment. I assume Martin and Rade are also fine with merging this branch. We tested it a lot during the development stage. REPOSITORY R167 Krusader BRANCH bookmark-search-merge_arc REVISION DETAIL https://phabricator.kde.org/D11898 To: nmel, #krusader, martinkostolny,

D11898: Implemented bookmark quick search

nmel added a comment. Toni, thanks for the review and testing! I'll wait for others till the EOW. If no complains, I'm going to push it on Monday. REPOSITORY R167 Krusader BRANCH bookmark-search-merge_arc REVISION DETAIL https://phabricator.kde.org/D11898 To: nmel, #krusader,

D11898: Implemented bookmark quick search

asensi accepted this revision as: asensi. This revision is now accepted and ready to land. REPOSITORY R167 Krusader BRANCH bookmark-search-merge_arc REVISION DETAIL https://phabricator.kde.org/D11898 To: nmel, #krusader, martinkostolny, rade, asensi, gengisdave, abika Cc:

D11898: Implemented bookmark quick search

nmel updated this revision to Diff 31350. nmel added a comment. Updated the merge. REPOSITORY R167 Krusader CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11898?vs=31192=31350 BRANCH bookmark-search-merge_arc REVISION DETAIL https://phabricator.kde.org/D11898 AFFECTED

D11898: Implemented bookmark quick search

rade added a comment. In D11898#239150 , @asensi wrote: > If a user has opened his bookmark menu, he has a bookmark named "Documents" > and he presses Shift+D... nothing happens. Good catch! I have created a fix for that here D11906

D11898: Implemented bookmark quick search

asensi added a comment. Thank you, all! > Please test various aspects of the bookmark search for this merge. One thing I have noticed, at least using Kubuntu 17.10: If a user has opened his bookmark menu, he has a bookmark named Documents and he presses Shift+D...

D11898: Implemented bookmark quick search

nmel added reviewers: martinkostolny, rade, asensi, gengisdave, abika. nmel added a project: Krusader. nmel added a comment. + more devs for visibility. Please test if you have time. REPOSITORY R167 Krusader REVISION DETAIL https://phabricator.kde.org/D11898 To: nmel, #krusader,

D11898: Implemented bookmark quick search

nmel created this revision. nmel added a reviewer: Krusader. Restricted Application added a subscriber: kde-doc-english. nmel requested review of this revision. REVISION SUMMARY Merge branch 'bookmark-quicksearch' into master ADDED: bookmark quick search (type symbols in bookmark menu to